- 22 Oct, 2020 40 commits
-
-
Hajime Hoshi authored
Until committing finishes, |dom_content_loaded_| should represent the old document's state, but this is now reset at CommitNavigation. This means that |dom_content_loaded_| is reset at committing starts. This CL fixes the timing of resetting |dom_content_loaded_| to DidCommitNewDocument so that |dom_content_loaded_| is reset when the committing finishes. Bug: 1137725 Change-Id: I386c9bb855b45a94e4f2ae36e04f3f09b8f20610 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483550Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#819780}
-
Henrik Boström authored
This is a simple C++ wrapper of VTPixelBufferTransferSession, which together with PixelBufferPool can easily be set up to do a large range of conversions and scaling directly in the capturer process. The bulk of this CL is testing. This CL: - Implements PixelBufferTransferer. - Adds testing utility methods in the anonymous namespace of the unittest file for creating YUVS buffers from RGB and verifying the RGB color of YUVS buffers. This is done with the help of libyuv. - Add tests for copying, rescaling and verifying the color with YUVS. - Add tests for converting YUVS -> X -> Y -> YUVS and verify we end up with the original color. We do this for all X and Y: YUVS, NV12, UYVY, I420. Starting and ending with YUVS is done so that the test utilities only have to read and set colors based on this format, rather than implement conversions for all formats. // TBR for media/capture/BUILD.gn changes. TBR=guidou@chromium.org Bug: chromium:1132299 Change-Id: If61f05d93dbb419992670d315b78e27f1f287ae0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438250Reviewed-by:
Henrik Boström <hbos@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Reviewed-by:
Markus Handell <handellm@google.com> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#819779}
-
Daniel Cheng authored
This is needed because wasm-eval is not yet standardized, yet it remains useful for allowing something stricter than unsafe-eval. Bug: v8:7041 Change-Id: I7d45f4b4f2bb930536af56a25082f6a938d4b804 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488389 Commit-Queue: Mike West <mkwst@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#819778}
-
Yu-Hsuan Hsu authored
Fix a small type: AudioManagerCras -> AudioManagerCrasBase Change-Id: I17decae7ed93b953c4376a7ce319a8c647c56a43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483543 Commit-Queue: Yu-Hsuan Hsu <yuhsuan@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#819777}
-
Arthur Hemery authored
We currently have no tests verifying the cross-origin isolated state of ServiceWorkers, as well as the processes they use for the different combinations. This adds 8 tests: - Installing + starting a service worker * For all combinations of document/SW isolation - 4 cases - Quick starting a service worker * For all combinations of document/SW isolation - 4 cases Bug: 1131404 Change-Id: Ib03980a2aeb78bbd78453813094292f3c31ae310 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485216Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Arthur Hemery <ahemery@chromium.org> Cr-Commit-Position: refs/heads/master@{#819776}
-
Piotr Tworek authored
The code uses std::unique_ptr so we need memory include. Libcxx somehow pulls it indirectly, but builds using libstdc++ fail. Bug: 957519 Change-Id: I597ddd9d8a5f3bb949b2d2c1c8cb526b752c87d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489521Reviewed-by:
Mike Wittman <wittman@chromium.org> Commit-Queue: Piotr Tworek <ptworek@vewd.com> Cr-Commit-Position: refs/heads/master@{#819775}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/2e1091e0ef69..d74754378f09 2020-10-22 syoussefi@chromium.org Vulkan: Support vertex attribute aliasing for matrix types If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: jonahr@google.com Change-Id: I84a36aa9e730a0bd67f54e7c8daac9ee69e77b4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491348Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#819774}
-
Colin Blundell authored
When the renderer detects that the user's focus on the webpage has changed to no longer be on the current form, it currently sends the browser a notification that the focus is no longer on the current form only if it (the renderer) has registered that the user has interacted with the current form. However, the renderer registers this interaction only when the user submits or saves the form. In the case of WebView and WebLayer, the browser also needs to get this information in the case where the user has focused on a form and then moved focus off (without submitting). Without getting this information, the browser won't trigger autofill if the user taps back on the form (see [1] for details). (Chrome's flow operates differently and isn't subject to this particular problem). This CL loosens the condition under which the renderer sends this notification, sending it whenever focus has moved to a null element (i.e., is definitely not on a form). As Chrome relies on the current semantics of the notification (that it is sent only when the renderer has previously registered an interaction with the current form), we add a |had_interacted_form| boolean to the Mojo method. Chrome uses this parameter to short-circuit out of handling the call from the renderer if there was no previously-interacted form. In the longer term, it would be desirable to eliminate the need for this parameter (e.g., by ensuring that its value always matched that of AutofillManager's |pending_form_data_|). That, however, is beyond the scope of this CL. This CL is thus a no-op for Chrome, while extending WebView/WebLayer to handle the case where focus moves off of a form to a non-form element and then back onto the form. There is an edge case that this CL doesn't handle: when focus moves from a non-interacted form to a distinct form, AutofillAgent still does not send the FocusNoLongerOnForm() call (as it doesn't today). AutofillAgent cannot currently distinguish this case from the case where focus moves from an element in a non-interacted form to a separate element in that same form (when FocusNoLongerOnForm() should definitely *not* be sent). We could make this possible by adding more state to autofill_agent.cc, but that class is sufficiently complex as-is that it's not worth the extra complexity that this would engender. To verify: In Web{Layer, View}Shell, go to any website with a form on it for which autofill will trigger. Focus on a form field and observe the autofill popup trigger. Tap away to cause it to disappear, tap back on the field, and verify that the popup triggers again. [1] https://docs.google.com/document/d/1tyQ5XQLssIoa1AIPJ9WjOnW6-lPZpmpSrxkf5-6HYgc/edit#heading=h.u1hpn0gmjp2e (internal-only, apologies) Bug: 1127339 Change-Id: I2c954f81840ff2fbe010fb730866416d3f10c29b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409297Reviewed-by:Scott Violet <sky@chromium.org> Reviewed-by:
Michael Bai <michaelbai@chromium.org> Reviewed-by:
Christoph Schwering <schwering@google.com> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#819773}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: I7f38264b62d9d9ab8ceca93f4435b15782585443 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491199Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8462cfcb03a5..1c5210c268e2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC beverloo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1130697 Tbr: beverloo@google.com Change-Id: I5a050a2cac1a84fb1042bd807c957271fb2977fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491663Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#819771}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/c3fb4c6d3915..9be16a326a9b 2020-10-22 landrey@webrtc.org Use separate entity groups for Token and child measurements If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1128357 Tbr: oysteine@google.com Change-Id: I218c65d1fb341532c682a5fe214847885cc71910 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491198Reviewed-by:
-
David authored
Doc: http://go/backlight-better-crash-report#heading=h.wtrp256ggmr3 Context around this change is, we want to not report crash reports in chrome://media-app when devtools has ever been opened. This shouldn't have much of effect on other crashReportPrivate clients: * Non SWAs: VK, Secure shell: users shouldn't be opening devtools. * SWAs: chrome://media-app (wants this), chrome://help-app (probably wants this) Change-Id: I10a0ae94d1facc9533aaca0dc5c2dc9aa35848cb Bug: b/169635499 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465407 Commit-Queue: David Lei <dlei@google.com> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Bugs Nash <bugsnash@chromium.org> Auto-Submit: David Lei <dlei@google.com> Cr-Commit-Position: refs/heads/master@{#819769}
-
Sylvain Defresne authored
In preparation of supporting arm64 simulator build (for Apple Silicon macs), we need to decouple the fact that a build is a simulator build from the `target_cpu`. This was done by introducing a `target_environment` variable that can be set by the user (the default value is set using the same heuristic based on value of `target_cpu` if unset). Configure setup-gn.py to be explicit about setting the variable. Bug: 1138425 Change-Id: Ic8f84ef260972e542ea456d6e85e43080e81da36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489984 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#819768}
-
Paul Lewis authored
The current behavior of the web bindings is to load files from the debug subdirectory of resources/inspector when the debug-devtools flag is set. However, this does not work as the debug build does not include the module information. Additionally, it is not necessary as the version of the DevTools frontend in resources/inspector works just fine for the debug case. This CL, therefore, removes the redirection from resources/inspector to resources/inspector/debug, and in the process allows DevTools developers to run `npm run debug-test` from the DevTools repo successfully. R=tvanderlippe@chromium.org Change-Id: I036697bd99cbc6c010a6be3bd17511fce7ee28d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489628 Auto-Submit: Paul Lewis <aerotwist@chromium.org> Reviewed-by:
Tim van der Lippe <tvanderlippe@chromium.org> Reviewed-by:
-
Wojciech Bielawski authored
Summary: Jinja2 already supports python3, but templates must be aware of environment they're run on. This commit fixes: "TypeError: '<' not supported between instances of 'dict' and 'dict'" when template is rendered using python3 Bug: 1138872 Change-Id: I08221a397c9e49f36ac652d5cc274ebcdca953fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485063Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#819766}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e267464b897d..6c5f7774fc2a 2020-10-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 84f5eeb6dd9b to e02d8938821a (3 revisions) 2020-10-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 4bdce889 to 502ec4ce (465 revisions) 2020-10-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from e2147a58a233 to d74754378f09 (16 revisions) 2020-10-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from cca03ca6bfe9 to 22505a5afe1f (9 revisions) 2020-10-22 johnstiles@google.com Reland "Create a basic IRNode pooling system." 2020-10-21 fmalita@chromium.org [svg] Add support for preserveAspectRatio 2020-10-21 johnstiles@google.com Pop the symbol table if compilation fails. 2020-10-21 kjlubick@google.com [canvaskit] Load resources into wasm gms/unit tests. 2020-10-21 egdaniel@google.com In Vk don't set dynamic blend constant on Pipeline if we don't use it. 2020-10-21 tdenniston@google.com [svg] Add gradientUnits attribute, value, and parsing 2020-10-21 jlavrova@google.com Underline decorations with gaps and no text 2020-10-21 bsalomon@google.com Reland "Perform bounding rect-relative calcs in full float in GrRRectBlurEffect" 2020-10-21 brianosman@google.com Add several more visualizations to Skia.natvis If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC egdaniel@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: chromium:1138810 Tbr: egdaniel@google.com Test: Test: Test: TransformFeedbackTest.NonExistentTransformFeedbackVaryingWithGLPrefix:/ES3_OpenGLTest: Test: angle_perftests --gtest_filter="*fifa_mobile*"Test: Test: angle_perftests --gtest_filter="*free_fire*"Test: Test: angle_perftests --gtest_filter="*marvel_contest_of_champions*"Test: Test: angle_perftests --gtet_filter="*kartrider_rush*" Change-Id: I8a33e162c6268953559e6902925ed1f6466bdc4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491801Reviewed-by:
-
Hayato Ito authored
Disable WebViewAccessibilityTest.FocusAccessibilityNestedFrame. TBR=dlibby@microsoft.com Bug: 1141313 Change-Id: I2939705a8e0a9ba3c94ba131493a77b1586ed440 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491575Reviewed-by:
Hayato Ito <hayato@chromium.org> Commit-Queue: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#819764}
-
Felipe Erias authored
The scrollbar-width CSS property allows the author to set the maximum thickness of an element’s scrollbars when they are shown. Its value is one of the keywords "auto", "thin", and "none". This is part of the CSSScrollbars feature (status: test). See the CSS Scrollbars spec for more details: https://drafts.csswg.org/css-scrollbars Bug: 891944 Change-Id: Iddc833d6af877c312a11452a6cfdcb05d45b1a63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488947Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Felipe Erias Morandeira <felipeerias@gmail.com> Cr-Commit-Position: refs/heads/master@{#819763}
-
Mugdha Lakhani authored
Expose an API to perform a prerender (implemented using NoStatePrefetch). A browsertest and a javatest have been added to verify the expected behavior. Bug: 1136091 Change-Id: I158b5b954fbbf2e3cb9821180d6afd6aa042abd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470634 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#819762}
-
Kent Tamura authored
Having both of fieldset-percent-height.html and fieldset-percetage-block-size.html is confusing. Merge the new one into the old one. Change-Id: Ibcdf17d744c4cd622a8db33f6706cdc9f65ad416 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491573 Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#819761}
-
philipel authored
Bug: none Change-Id: I0bb244b3795da211d43a30684a61e079d127a68a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489881Reviewed-by:
-
Kent Tamura authored
We'd like to share the logic with LayoutNG. This CL fixes some failing tests with LayoutNGTextField flag. This CL has no behavior changes for now. Bug: 1040826 Change-Id: I0c5fa3da1eab44b35c0395298c72ba123bdd1ea3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491700Reviewed-by:
-
Mohamed Amir Yosef authored
This is preparation for adding the functionality of moving multiple passwords from settings view. Mocks are in the linked bug. TBR=karandeepb@chromium.org Bug: 1139263 Change-Id: I8d801c73e5566a9c44c9a69ea099fe2116d8cdde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481124 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#819758}
-
Patrick Brosset authored
Unfortunately the devtools frontend and a bunch of tests that check it live in 2 separate repos (chromium.src and devtools_frontend), this means that sometimes a frontend change will cause tests to fail, and the only way to deal with this is first disable those tests in chromium.src then land the frontend change, then go back, fix and re-enable those tests. This disables 2 color-swatch tests in order to land: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2480042 Bug: 1137438 Change-Id: I0c81bc188260173f5b041dd53d63d866fabf43df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490282Reviewed-by:
Alex Rudenko <alexrudenko@chromium.org> Commit-Queue: Patrick Brosset <patrick.brosset@microsoft.com> Cr-Commit-Position: refs/heads/master@{#819757}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1603322998-a2bfaa167e3697b2b14734e406c0399abff8eaf1.profdata to chrome-linux-master-1603346243-3f07f08fc669370b6060ed7693324b959ad870ad.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I003ed2c4807c7d0c6e1f8e15ea82e796a555a445 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491664Reviewed-by:
-
rbpotter authored
Currently, the request list path in optimize_webui is computed based only on the host name. Add a '-v2' to the path for Polymer 2 builds (only applies to OS settings), to avoid the possibility of v2 and v3 builds accessing the same request list when generating dependency files. Collisions result in v2 dependencies being listed in the v3 build.d file, and vice versa, leading to build failures. Bug: 1132403 Change-Id: I4d92676db501669ddb99b204abfc4413dd8e2087 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491241 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#819755}
-
Wojciech Dzierżanowski authored
AutoPictureInPictureTriggeredWhenFullscreen can be moved from the InProcessBrowserTest-based (i.e., full browser) PictureInPictureWindowControllerBrowserTest to the ContentShell-based PictureInPictureContentBrowserTest. We can get rid of some of the unnecessary baggage without sacrificing coverage. In particular, fullscreen in this case means sizing the video to the size of the window rather than actual fullscreen. Compared to the PictureInPictureWindowControllerBrowserTest version, the new test doesn't try to verify PiP window visibility. That's because there are other tests that do it specifically, and the focus of this test are video element state transitions. Bug: 1058087 Change-Id: I7decc1674811c7c25c538b65bdcd46d67b07e8dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470525Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Wojciech Dzierżanowski <wdzierzanowski@opera.com> Cr-Commit-Position: refs/heads/master@{#819754}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I8317652a9b4c76df9fc0ae138ed79d63add1a6c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491350Reviewed-by:
-
sandromaggi authored
This refactors |GetFieldValue| to take an |ElementFinder::Result| instead of a |Selector|. Bug: b/168107066 Change-Id: I015c7159872e5328648ba0990275540886c5ecc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2478943 Commit-Queue: Sandro Maggi <sandromaggi@google.com> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#819752}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/337086da0b11..0517bfe506ad 2020-10-22 thestig@chromium.org Remove `FXDIB_Format::kRgba`. 2020-10-22 thestig@chromium.org Remove `FXDIB_Format::k8bppRgba`. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: Ib77649cde5d1bae65679ce30f31a4ea1b59af433 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491347Reviewed-by:
-
Mark Cogan authored
In mid-2017, files used only for the experimental "clean" architecture of iOS Chrome lived alongside the "classic" iOS Chrome files. To docu- ment which files were exclusive to the new architecture, some README.md files were created in some directories. The split between old and new architectures is long gone, and many of the files these READMEs refer to no longer exist. This CL just deletes them. TBR: stkhapugin@chromium.org Change-Id: Ic5b4df4535effff269ae9a4f56f07e3e79f394e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489886 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#819750}
-
Gang Wu authored
Bug: 1056501 Change-Id: If85d5c9d4ae144c10ba3c4a14cd1702508825f0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485343Reviewed-by:
Tomasz Wiszkowski <ender@google.com> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Gang Wu <gangwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#819749}
-
Polina Bondarenko authored
Modify policy description and extend owners. BUG=b:170187468 TEST=none Change-Id: I721b1ce65daf77cd975d4c1a4032de77a04e4be9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490104Reviewed-by:
Sergey Poromov <poromov@chromium.org> Auto-Submit: Polina Bondarenko <pbond@chromium.org> Commit-Queue: Polina Bondarenko <pbond@chromium.org> Cr-Commit-Position: refs/heads/master@{#819748}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/c51c18a5866c..cab003ff2dd9 2020-10-22 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. 2020-10-22 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I084658668005afde2bc69f37e07b92a69746a5f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491349Reviewed-by:
-
Joshua Berenhaus authored
Some of the Edge engineers got confused by this string and thought their histogram was missing from the xml file. I tested this string with them and they understood the failure better. Thought it might be useful for the entire project but feel free to suggest other options or push back! Change-Id: I6fa6aa98329e419ca6f3b687a42a683ba7bd6828 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487691Reviewed-by:
Cliff Smolinsky <cliffsmo@microsoft.com> Reviewed-by:
-
Clemens Arbesser authored
This CL removes the behavior where the client would overwrite failed action statuses with navigation error, if present. It seems that the navigation error flag may be set too often, but more crucially, overwriting the status makes debugging harder. The backend can still investigate navigation_info to determine whether a navigation error occurred. Bug: b/170401521 Change-Id: I7d164f8c1a3746e8b7c1786461d30c1178002fa5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485166Reviewed-by:
Marian Fechete <marianfe@google.com> Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Commit-Queue: Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#819745}
-
Ramin Halavati authored
User type filter is updated to return correct type for ephemeral Guest profiles. This change is behind disabled |EnableEphemeralGuestProfilesOnDesktop| flag. Please see go/ephemeral-guest-profiles for more context. Bug: 1125474 Change-Id: Id5743e7d22cb9a1043e64ae7b6a696f41d0724d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470656Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#819744}
-
Jan Wilken Dörrie authored
This change replaces existing usages of autofill::PasswordForm with password_manager::PasswordForm in //ios. Bug: 1067347 Change-Id: Ie696e85f6cc8bd0ecfefd1baf0feba827ca92b06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487323Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#819743}
-
Piotr Tworek authored
The code uses size_t, so it needs to include stddef.h. This works fine in default setup using libcxx, but fails with libstdc++. Bug: 957519 Change-Id: Id6bca0bbc911253a3be9a67b01dc348e467490ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489303Reviewed-by:
Eric Orth <ericorth@chromium.org> Commit-Queue: Piotr Tworek <ptworek@vewd.com> Cr-Commit-Position: refs/heads/master@{#819742}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/9606cffa66d0..c4af5cd3397d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I68cd6d1c00dbd0e979d3bf04bb7103101c13793a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491522Reviewed-by:
-
