- 26 Jan, 2019 40 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/233357879a53..debfdbae2ec3 Created with: gclient setdep -r src-internal@debfdbae2ec3 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I295c0cbc65500ac0ae7a8946d11d614caf86a725 Reviewed-on: https://chromium-review.googlesource.com/c/1437924Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#626349}
-
Annie Sullivan authored
If there is no user input event, but there is an intent timestamp, then use the intent timestamp as the input time. The intent received timestamp is documented as "Timestamp the timestamp at which Chrome received the intent that triggered this URL load, as returned by System.currentMillis." Bug: 893162 Change-Id: I7520a685611abcdf0050c5f77ad54b7ac50ad27b Reviewed-on: https://chromium-review.googlesource.com/c/1435743Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Annie Sullivan <sullivan@chromium.org> Cr-Commit-Position: refs/heads/master@{#626348}
-
Andrey Kosyakov authored
This reverts commit b95462ad. Reason for revert: broke 32-bit linux builds: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Builder%20%28dbg%29%2832%29/98305 Original change's description: > Take the process limit into account in GetMaxRendererProcessCount() on Linux. > > On Linux, given sufficient RAM, GetMaxRendererProcessCount() can now > return a value as high as (RLIMIT_NPROC / 2), instead of being capped to > a hard-coded maximum. This lets the browser start more processes and > have more process isolation between renderers if the environment can > support it. > > This also makes the browser behave better when running in an environment > that is constrained by the process limit. > > BUG=104689 > > Change-Id: I2b249bc4b1e1c2e52579cf6fd603798f3e028249 > Reviewed-on: https://chromium-review.googlesource.com/c/1088242 > Commit-Queue: Lei Zhang <thestig@chromium.org> > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> > Reviewed-by: Charlie Reis <creis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#626313} TBR=creis@chromium.org,thestig@chromium.org,thomasanderson@chromium.org Change-Id: I069d5b7bb4ab4c86624c24794de8e6c1671fa822 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 104689 Reviewed-on: https://chromium-review.googlesource.com/c/1437589Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#626347}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/f2b63146dd6b..33625e18d47e git log f2b63146dd6b..33625e18d47e --date=short --no-merges --format='%ad %ae %s' 2019-01-26 gbiv@google.com SimpleChrome: remove lld-specific flags from gold builds Created with: gclient setdep -r src/third_party/chromite@33625e18d47e The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I4263b506e8edaf1b521ed6c806cdefb5ee7599bd Reviewed-on: https://chromium-review.googlesource.com/c/1437922Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#626346}
-
Justin Cohen authored
This experiment will run for 2 weeks, and be reverted on or before Feb 11th. Bug: 925617 Change-Id: I19fd3a7890a948f39c68d6fc4e4dcbc8be0b39e1 Reviewed-on: https://chromium-review.googlesource.com/c/1431712 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#626345}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/35fed637e9de..233357879a53 Created with: gclient setdep -r src-internal@233357879a53 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I510495ad26d7d02cbccdbccb03820fa1d6cab5aa Reviewed-on: https://chromium-review.googlesource.com/c/1437921Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#626344}
-
BUG=762641 TBR=michaelpg@google.com Change-Id: I625e88ac495e5a3ba2e1ccd17f7e4fd603261ed0 Reviewed-on: https://chromium-review.googlesource.com/c/1437235Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#626343}
-
Andrew Grieve authored
Rather than a "star" symbol. Bug: 826008 Change-Id: I1bf9e9a3fa5b9126a0d57e14adb35f1af3dbb5ad Reviewed-on: https://chromium-review.googlesource.com/c/1426175 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#626342}
-
David 'Digit' Turner authored
A few third-party packages mistakenly provide their localized strings for Norwegian with the incorrect 'no' locale tag (which represents a macro language, not a real one), instead of 'nb', the expected value. As such, these strings were omitted from the build and missing from APKs and bundles. This fixes the issue by ensuring that 'no' strings are recognized as 'nb' ones, if the package provides them. This CL thus adds 'nb' strings for the following 13 string resources in the Monochrome bundle: hats_lib_close_button_description hats_lib_default_prompt_title hats_lib_default_star_rating_bar_description hats_lib_default_thank_you hats_lib_next hats_lib_none_of_the_above hats_lib_open_text_hint hats_lib_open_text_no_pii hats_lib_prompt_no_thanks hats_lib_prompt_take_our_survey hats_lib_submit hats_lib_survey_page_number hats_lib_thank_you_followup_message + Disable pylint warnings properly now that of presubmit scripts have been fixed to parse the line-too-long directives properly [1] [1] https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1396094 BUG=920960 R=agrieve@chromium.org,benmason@chromium.org,estevenson@chromium.org,yfriedman@chromium.org Change-Id: Ied74827c2e53c81f165b2fbcaec9f35d7e893290 Reviewed-on: https://chromium-review.googlesource.com/c/1437174Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: David Turner <digit@chromium.org> Cr-Commit-Position: refs/heads/master@{#626341}
-
Koji Ishii authored
Legacy computes VisualRect of InlineBox to the same one as the VisualRect of their LayoutObject with adjustments to relative to the inline formatting context. On the other hand, LayoutNG used to compute VisualRect for every fragment, even for inline. When Finch indicates pre-paint is slower in LayoutNG, iterating fragments and calling SelfInkOverflow() + MapFragmentLocalRectToVisualRect() for each is the most suspicious. We don't have much different code in pre-paint for LayoutNG other than this. This patch changes LayoutNG to compute the VisualRect the same way as legacy. Paint invalidation tests were rebased, mostly closer to legacy results. line-flow-with-floats-* are still more similar to NG before this change, probably because NG handles floats differently. Also this patch leaves the loop to pre-compute VisualSelectionRect. It should also be eliminated if possible, but the work is not in this patch. blink_perf.paint didn't show pre-paint was slower in NG, so the improvements are not seen there: https://pinpoint-dot-chromeperf.appspot.com/job/129dcf9d540000 Change-Id: I0add5fe9e44d7814502090c0f2807fe9c975f11a Reviewed-on: https://chromium-review.googlesource.com/c/1429302Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#626340}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8cb3911f7e9b..35fed637e9de Created with: gclient setdep -r src-internal@35fed637e9de The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ifa5ff2d02cd33342614a4bb95ae94b1c934839a2 Reviewed-on: https://chromium-review.googlesource.com/c/1437920Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#626339}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/48c3b49693ae..f2b63146dd6b git log 48c3b49693ae..f2b63146dd6b --date=short --no-merges --format='%ad %ae %s' 2019-01-26 lamontjones@chromium.org BuildStore: Redirect FinishChildConfig function through BuildStore 2019-01-26 ahassani@chromium.org build_dlc: Some nits 2019-01-26 chowes@google.com build_dlc: Only copy directory contents into DLC image. 2019-01-26 dgarrett@google.com build_stages: Use explicit cache directory paths. 2019-01-26 dgarrett@google.com workspace_builders: One board for factorybranch. Created with: gclient setdep -r src/third_party/chromite@f2b63146dd6b The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I0d46ae7363bc49ccf37e9c1b284d0348c9319e81 Reviewed-on: https://chromium-review.googlesource.com/c/1438027Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#626338}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d7373af4b529..8cb3911f7e9b Created with: gclient setdep -r src-internal@8cb3911f7e9b The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Id44bc5af508733db43e3ff6aa812b32057671c30 Reviewed-on: https://chromium-review.googlesource.com/c/1438026Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#626337}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I664858de798ac16136a2334050ae0d4fbd572a86 Reviewed-on: https://chromium-review.googlesource.com/c/1437327Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#626336}
-
Armando Miraglia authored
This CL gets rid of the googHotword constraint in the renderer process. This property was available only with the legacy constraints syntax. A follow-up CL will remove the property in the browser process. Intent to deprecate and remove: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/WlIzSK6-xq0 BUG=577627,564574,924485 Change-Id: I7c0e9ab0608db841c5428187d50174770949067e Reviewed-on: https://chromium-review.googlesource.com/c/1426688Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Armando Miraglia <armax@chromium.org> Cr-Commit-Position: refs/heads/master@{#626335}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f6ccdc6c3e62..d7373af4b529 Created with: gclient setdep -r src-internal@d7373af4b529 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I8a868ff295645f2fc94970d063e6fc7f17e91071 Reviewed-on: https://chromium-review.googlesource.com/c/1438118Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#626334}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I134a944022e1c2290b50b4d2f38fddcb27f7ee70 Reviewed-on: https://chromium-review.googlesource.com/c/1438116Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#626333}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I0d21d1f7b8bb5c7c62d274b31eeadf5d71121c98 Reviewed-on: https://chromium-review.googlesource.com/c/1438117Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#626332}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/16a2fe7e1553..f6ccdc6c3e62 Created with: gclient setdep -r src-internal@f6ccdc6c3e62 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I2392305c62101ef6544754b4323460f0ff022bf5 Reviewed-on: https://chromium-review.googlesource.com/c/1438114Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#626331}
-
Andrew Grieve authored
Bug: 912690 Change-Id: I6148fd6f980b334638ee8ab5b4abbef97cbd99ce Reviewed-on: https://chromium-review.googlesource.com/c/1437979 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#626330}
-
Dale Curtis authored
Adds a trace in VideoRendererImpl::Render() and VideoFrameSubmitter::SubmitFrame() with information on the frame selected and the frame submitted. BUG=none TEST=chrome://tracing shows frame info. R=liberato Change-Id: I7ec27258db43bf420f35f0cde23b907bee26a23e Reviewed-on: https://chromium-review.googlesource.com/c/1436488 Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#626329}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7c4d51cc6482..16a2fe7e1553 Created with: gclient setdep -r src-internal@16a2fe7e1553 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I69271985b4b31de5383a51fe374f52234549672a Reviewed-on: https://chromium-review.googlesource.com/c/1438024Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#626328}
-
Kevin Strohbehn authored
Bug: NA Change-Id: I92b5b7e81c7712c8476c9690975a6e8283f24a14 Reviewed-on: https://chromium-review.googlesource.com/c/1438000 Commit-Queue: Kevin Strohbehn <ginko@google.com> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#626327}
-
Chromium WPT Sync authored
Using wpt-import in Chromium fce0b4f7. With Chromium commits locally applied on WPT: 20defaa4 "[LayoutNG] ComputeReplacedSize min/max width/height fix" 40748e1e "Upstream fast/workers to external/wpt/workers: first batch." 6691ad3f "Fix preload tests failing on wpt.fyi dashboard, second attempt" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I7323dec27ef3c8c5a0a7566abfa219b1590ef5ec Reviewed-on: https://chromium-review.googlesource.com/c/1437977Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#626326}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/fe9504cfbd59..7c4d51cc6482 Created with: gclient setdep -r src-internal@7c4d51cc6482 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:920652,chromium:828647,chromium:828648,chromium:828649,chromium:828650,chromium:828651,chromium:828672 TBR=mmoss@chromium.org Change-Id: I2a5a270975ed4b339b9f0f6b3520f7f45926198f Reviewed-on: https://chromium-review.googlesource.com/c/1437726Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#626325}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=kariah@chromium.org Change-Id: Ie59d8115c6e317d091391b1551b3c9ce351d3b3d Reviewed-on: https://chromium-review.googlesource.com/c/1437584Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#626324}
-
Findit authored
This reverts commit 726375b6. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 626289 as the culprit for flakes in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vNzI2Mzc1YjZhMGM1NTgzZjRkNmMzN2EwZDVlZGFmMjQyMWNiNzJiOQw Sample Failed Build: https://ci.chromium.org/buildbot/chromium.mac/Mac10.13%20Tests/9272 Sample Failed Step: webkit_layout_tests on Intel GPU on Mac Sample Flaky Test: external/wpt/html/semantics/embedded-content/the-iframe-element/iframe_sandbox_navigation_download_allow_downloads_without_user_activation.sub.tentative.html Original change's description: > Add tentative WPT to verify download in sandbox > > General testing idea: > For a network request, we store a token in stash. And after a fixed > period of time sufficient for the download to finish, if there are > any, we validate the token in the stash to see if the network request > was issued and finished successfully. > > In the case of <a download> where the decision of download can be made > before resource fetching, the server sets the token immediately. > > In the case of navigation to a download, the server will stream a > response over 1 seconds and set the token at the end only when the > socket has been connected. So it is able to detect any download > cancellation while fetching the resource. > > Bug: 539938 > Change-Id: I734c8cc18d1f761f16646c6b859a6b731ab40ff5 > Reviewed-on: https://chromium-review.googlesource.com/c/1422667 > Commit-Queue: Yao Xiao <yaoxia@chromium.org> > Reviewed-by: Mike West <mkwst@chromium.org> > Cr-Commit-Position: refs/heads/master@{#626289} Change-Id: Id343b8de2a751856b27907ba4c8dfb52715e4598 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 539938 Reviewed-on: https://chromium-review.googlesource.com/c/1437999 Cr-Commit-Position: refs/heads/master@{#626323}
-
Dan Beam authored
crisper.js:formatted:6217 Uncaught TypeError: Cannot read property 'getDetailsButton' of null at HTMLElement.getDetailsButton (crisper.js:formatted:6217) at HTMLElement.onViewExitFinish_ (crisper.js:formatted:8074) at HTMLElement.handler (polymer-extracted.js:11) at crisper.js:formatted:2132 at async Promise.all (chrome://extensions/index 0) I'm fairly sure this was caused in https://crrev.com/c/1125507 Unfortunately, CrExtensionsManagerUnitTest.UninstallFromDetails is flaky and currently DISABLED_ (I re-enabled it locally and it didn't fail). Bummer. R=rbpotter@chromium.org BUG=none Change-Id: Ic390a4ee61d61832f9aee96ca5d9a2f2d9310c40 Reviewed-on: https://chromium-review.googlesource.com/c/1437949 Commit-Queue: Dan Beam (slow until 1/29) <dbeam@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Auto-Submit: Dan Beam (slow until 1/29) <dbeam@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#626322}
-
Hector Carmona authored
This is because we don't have a good list of email providers to recommend that will be relevant based on locale. Bug: 924274 Change-Id: I432c1a81e0c0272673edace4ac82781dbb216c45 Reviewed-on: https://chromium-review.googlesource.com/c/1437554 Commit-Queue: Hector Carmona <hcarmona@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Auto-Submit: Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#626321}
-
Fabrice de Gans-Riberi authored
This implements setting and using the |headers| data in LoadUrlParams. A new test fixture is added to ensure the extra headers are properly received by the test server. Reason for reland: Now with extra nullptr dereference check. Bug: 923598 Change-Id: Ie677bc7a13da381f018e1de94daa4742462803cf Reviewed-on: https://chromium-review.googlesource.com/c/1437937 Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#626320}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/11455bfdc0c5..71b05185eb63 git log 11455bfdc0c5..71b05185eb63 --date=short --no-merges --format='%ad %ae %s' 2019-01-25 primiano@google.com Merge "perfetto-ui: cd ui; ./npm audit fix" 2019-01-25 primiano@google.com Merge "perfetto-ui: Fix presubmits" 2019-01-25 primiano@google.com Add DISCARD policy to TraceBuffer Created with: gclient setdep -r src/third_party/perfetto@71b05185eb63 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:115601774 TBR=perfetto-bugs@google.com Change-Id: Id75211486ff6a18c7531b439d5a83c88f399ae58 Reviewed-on: https://chromium-review.googlesource.com/c/1437857Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#626319}
-
David Tseng authored
Change-Id: I7ac749bfa0115479b133e9e9f53390b9ebf4022a Reviewed-on: https://chromium-review.googlesource.com/c/1435114Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#626318}
-
Azeem Arshad authored
This CL adds a new ConnectionEstablisher implementation that supports FCM web push based background notifications in ChromeOS - Android Message for Web integration. This implementation uses a regular message dispatch to the service worker to allow it to register for push notifications. See go/awm-cros-fcm. Bug: 920831 Change-Id: I2bc555313468fc210f183f8c7ce5f786b68e383f Reviewed-on: https://chromium-review.googlesource.com/c/1432796 Commit-Queue: Azeem Arshad <azeemarshad@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Jeremy Klein <jlklein@chromium.org> Cr-Commit-Position: refs/heads/master@{#626317}
-
Andrey Kosyakov authored
Mark external/wpt/html/semantics/links/links-created-by-a-and-area-elements/target_blank_implicit_noopener.tentative.html as timing out on win TBR=ossu Bug: 626703 913932 Change-Id: I12a8ee4d3d9948a074b0060a84c40b63c9f2e350 Reviewed-on: https://chromium-review.googlesource.com/c/1437582Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#626316}
-
CJ DiMeglio authored
This should have been removed with https://chromium-review.googlesource.com/c/chromium/src/+/1379178 but I guess was missed. Bug: 836549 Change-Id: I452b29f252cb6664281388ab5866ddad8005a48b Reviewed-on: https://chromium-review.googlesource.com/c/1437702Reviewed-by:
Tommy Steimel <steimel@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org> Cr-Commit-Position: refs/heads/master@{#626315}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I01c0f7e9e6b9d25752b9fe83b6cd116c485613b4 Reviewed-on: https://chromium-review.googlesource.com/c/1437730Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#626314}
-
Lei Zhang authored
On Linux, given sufficient RAM, GetMaxRendererProcessCount() can now return a value as high as (RLIMIT_NPROC / 2), instead of being capped to a hard-coded maximum. This lets the browser start more processes and have more process isolation between renderers if the environment can support it. This also makes the browser behave better when running in an environment that is constrained by the process limit. BUG=104689 Change-Id: I2b249bc4b1e1c2e52579cf6fd603798f3e028249 Reviewed-on: https://chromium-review.googlesource.com/c/1088242 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#626313}
-
Chromium WPT Sync authored
Using wpt-import in Chromium d2f7dfae. With Chromium commits locally applied on WPT: f643497e "[resource-timing] Modify is_secure_context_ based on resource" 20defaa4 "[LayoutNG] ComputeReplacedSize min/max width/height fix" 40748e1e "Upstream fast/workers to external/wpt/workers: first batch." 6691ad3f "Fix preload tests failing on wpt.fyi dashboard, second attempt" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=markdittmer No-Export: true Change-Id: I12709d90e33a1d2bee62a8f62a5a6afe5a402603 Reviewed-on: https://chromium-review.googlesource.com/c/1437718Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#626312}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/1b0dd7244802..48c3b49693ae git log 1b0dd7244802..48c3b49693ae --date=short --no-merges --format='%ad %ae %s' 2019-01-26 chrome-bot@chromium.org Update config settings by config-updater. 2019-01-25 tbegin@google.com sludge: change full builder to release builder 2019-01-25 bhthompson@google.com Add R73 release branch builders Created with: gclient setdep -r src/third_party/chromite@48c3b49693ae The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Idb988a786bc080e0f588c040fdcde2882f152399 Reviewed-on: https://chromium-review.googlesource.com/c/1435727Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#626311}
-
Tommy Steimel authored
This fixes an issue where Chrome will only download a video/3gpp file instead of playing it when opened with Chrome. Bug: 910658, 923081 Change-Id: I0fcdfe5952f0020c35fe09a0db85a4e83fe4d37a Reviewed-on: https://chromium-review.googlesource.com/c/1437720Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#626310}
-