GitLab

BUG=702498

Review-Url: https://codereview.chromium.org/2753063003
Cr-Commit-Position: refs/heads/master@{#457735}

BUG=chromium:702201
R=sullivan@chromium.org, nednguyen@google.com

Review-Url: https://codereview.chromium.org/2744243007
Cr-Commit-Position: refs/heads/master@{#457734}

adds a warning when the --use-fake-ui-for-media-stream flag is used.
This flag is used in automated testing and skips the getUserMedia permissions
prompt. It might be slightly harmful to real users.

BUG=520377

Review-Url: https://codereview.chromium.org/2727143006
Cr-Commit-Position: refs/heads/master@{#457733}

The scheduleFreeMemoryMonitoring method post a task to the IO thread to log the
free memory. There is no need to defer it further.

BUG=649338

Review-Url: https://codereview.chromium.org/2751993003
Cr-Commit-Position: refs/heads/master@{#457732}

This allows to reset references inside PasswordFormManager to data owned by the
associated FormFetcher instances.  See
https://docs.google.com/document/d/12CH_SV1gIJKaEIGTs7gWBiXrCMlBa3o32OyC2LRtPAo/edit#heading=h.jz2q52kebs7k
for more details.

BUG=621355

Review-Url: https://codereview.chromium.org/2752173003
Cr-Commit-Position: refs/heads/master@{#457731}

BUG=702554
TBR=tapted@chromium.org

Review-Url: https://codereview.chromium.org/2753263002 .
Cr-Commit-Position: refs/heads/master@{#457730}

Disable DevToolsBeforeUnloadTest.TestUndockedDevToolsInspectedTabClose and DevToolsBeforeUnloadTest.TestDockedDevToolsInspectedBrowserClose on Win

BUG=702171
TBR=nhiroki@chromium.org

Review-Url: https://codereview.chromium.org/2756143002 .
Cr-Commit-Position: refs/heads/master@{#457729}

https://codereview.chromium.org/2754883002 enables
perf_json_generator to also generate benchmark.csv. This change
updates the name of perf_json_generator to reflect that it is
also generating a csv file.

BUG=chromium:575318

Review-Url: https://codereview.chromium.org/2757433003
Cr-Commit-Position: refs/heads/master@{#457728}

Revert of Fuzzer for TextCodecs (patchset #8 id:140001 of https://codereview.chromium.org/2731643002/ )

Reason for revert:
Huge size regression on fuzzer archives.

BUG=702485

Original issue's description:
> Fuzzer for TextCodecs
>
> Fuzzer originally written by jsbell here:
> https://codereview.chromium.org/2546233002
>
> This introduces a libFuzzer-based fuzzer template (which can be run locally
> or via ClusterFuzz) for the WTF::TextCodec implementations. It
> introduces a new target for every text codec.
>
> Fuzzer docs: https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/getting_started.md
>
> This patch also includes a generated fuzzer corpus.
>
> Review-Url: https://codereview.chromium.org/2731643002
> Cr-Commit-Position: refs/heads/master@{#457512}
> Committed: https://chromium.googlesource.com/chromium/src/+/bb69cdf76b25cee534e6b84a5c55f4453ee3c828

TBR=mmoroz@chromium.org,jsbell@chromium.org,aizatsky@google.com,haraken@chromium.org,csharrison@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review-Url: https://codereview.chromium.org/2755083002
Cr-Commit-Position: refs/heads/master@{#457727}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/f7036b13..4e3e3842

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2756513005
Cr-Commit-Position: refs/heads/master@{#457726}

Use it in https://codereview.chromium.org/2751833005/

BUG=694451

Review-Url: https://codereview.chromium.org/2747253004
Cr-Commit-Position: refs/heads/master@{#457725}

BUG=None
TEST=None

Review-Url: https://codereview.chromium.org/2747373006
Cr-Commit-Position: refs/heads/master@{#457724}

The headers and footer of the CollectionViewModel should not be parameterized
as the implementation as Item is a convenience.

BUG=none

Review-Url: https://codereview.chromium.org/2750373004
Cr-Commit-Position: refs/heads/master@{#457723}

BUG=700859
TBR=guidou@chromium.org

Review-Url: https://codereview.chromium.org/2757833003
Cr-Commit-Position: refs/heads/master@{#457722}

The API to fetch remote content suggestions is private; it won't work
without the official Google Chrome API keys. If they're not available,
don't even attempt to fetch.

TBRing a new enum entry in histograms.xml
TBR=asvitkine

BUG=702189

Review-Url: https://codereview.chromium.org/2750393002
Cr-Commit-Position: refs/heads/master@{#457721}

The summary notification supports subtext that provides more context for
what the notification is.  This allows us to say something like
"Downloads" which makes it clear what this group of items is.

BUG=701989

Review-Url: https://codereview.chromium.org/2749953006
Cr-Commit-Position: refs/heads/master@{#457720}

BUG=702301

Review-Url: https://codereview.chromium.org/2751913005
Cr-Commit-Position: refs/heads/master@{#457719}

Build: https://build.chromium.org/p/chromium.infra.cron/builders/rebaseline-o-matic/builds/634812

https://chromium.googlesource.com/chromium/src/+/b586056392985

BUG=667324
TBR=hayato@chromium.org

Review-Url: https://codereview.chromium.org/2760563002 .
Cr-Commit-Position: refs/heads/master@{#457718}

BUG=702471

Review-Url: https://codereview.chromium.org/2755033003
Cr-Commit-Position: refs/heads/master@{#457717}

BUG=690467

Review-Url: https://codereview.chromium.org/2752563003
Cr-Commit-Position: refs/heads/master@{#457716}

When the TreeScope invalidation root is already with SubtreeStyleChange
there is no need to schedule ruleset invalidations for that scope. We
did not end up scheduling the invalidation sets, but went through a lot
of unnecessary steps in scheduleInvalidationsForRuleSets(). Instead,
just return early.

Added some more tests and corrected typos from
https://crrev.com/5fef4a38

Review-Url: https://codereview.chromium.org/2751193004
Cr-Commit-Position: refs/heads/master@{#457715}

We no longer need to use v2beta, because the Team Drive functions are
now available in v2.

TEST=google_apis_unittests --gtest_filter=DriveApiUrlGeneratorTest.*
BUG=649911

Review-Url: https://codereview.chromium.org/2747423004
Cr-Commit-Position: refs/heads/master@{#457714}

This CL lets Blink talk directly with Device Service to consume the
mojo interface device.mojom.ScreenOrientationListener, then removes
content::ScreenOrientationObserver completely.

BUG=678545

Review-Url: https://codereview.chromium.org/2751513007
Cr-Commit-Position: refs/heads/master@{#457713}

This was originally landed in https://codereview.chromium.org/2734193002 and,
before that, in https://codereview.chromium.org/2694083005. But it broke chrome
when component build is on. The issue was that
//services/resource_coordinator:lib is a static library with static local
variables. This CL fixes it.

Tested on a component build.

An example interaction diagram (to see the large image, click on it):
https://docs.google.com/document/d/1Mz64egjuZ4WsYw9AKKWdTvl0Il706EWdCy24V87R_F4/edit#heading=h.1ku5wcoxqifr

BUG=679830, 697773, 697384, 697062

Review-Url: https://codereview.chromium.org/2741203002
Cr-Commit-Position: refs/heads/master@{#457712}

In iterators it's now called __next__(), not next(), apparently.

Review-Url: https://codereview.chromium.org/2754473007
Cr-Commit-Position: refs/heads/master@{#457711}

vibration_browsertest.cc tests vibration integration between Blink and
the browser. It does this by injecting a fake VibrationManager impl
into RenderFrameHost's InterfaceRegistry.
However, this blocks us to port VibrationManager to be hosted in
Device Service because after that there is no such mechanism to do this.

So this CL replaces these browsertests with layout tests, with a TODO
to add 'main frame reload' tests later, because for now we consider that
'sub frame reload' tests have actually covered what we want to verify
for lifecycle of NavigatorVibration.

BUG=686692
TEST=blink_tests

Review-Url: https://codereview.chromium.org/2731953003
Cr-Commit-Position: refs/heads/master@{#457710}

Review-Url: https://codereview.chromium.org/2749513010
Cr-Commit-Position: refs/heads/master@{#457709}

Revert of Reduce runtime of osc-negative-freq test (patchset #3 id:40001 of https://codereview.chromium.org/2751213002/ )

Reason for revert:
After this patch, osc-negative-freq.html is consistently failing on WebKit Mac10.11 (retina):
https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Mac10.11%20%28retina%29/builds/13573

Original issue's description:
> Reduce runtime of osc-negative-freq test
>
> Reduce the sample rate and duration of the osc-negative-freq test to
> make it run faster for MSAN tests.  Tightened up the thresholds for
> the new test.
>
> On a Z620 machine running linux, the debug runtime was 1.414 sec. It
> is now 0.860, roughtly 60% as long as before.
>
> BUG=701418
> TEST=osc-negative-freq.html
>
> Review-Url: https://codereview.chromium.org/2751213002
> Cr-Commit-Position: refs/heads/master@{#457608}
> Committed: https://chromium.googlesource.com/chromium/src/+/db917052bfb936546b2602cdb657c310778c6451

TBR=hongchan@chromium.org,qyearsley@chromium.org,rtoy@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=701418

Review-Url: https://codereview.chromium.org/2756113003
Cr-Commit-Position: refs/heads/master@{#457708}

Remove FrameHost::subFrameCount(), incrementSubframeCount() and
decrementSubframeCount(), and redirect all calls to Page.

BUG=691794

Review-Url: https://codereview.chromium.org/2737243003
Cr-Commit-Position: refs/heads/master@{#457707}

Disable info_collection_tests on 'Linux ChromiumOS Ozone (Intel)' otherwise
'Linux ChromiumOS Ozone Builder' will try (and fail) to build chrome.

BUG=angleproject:1423
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2753163002
Cr-Commit-Position: refs/heads/master@{#457706}

The spec is: https://svgwg.org/svg2-draft/struct.html#UseShadowTree (5.6.1. The
use-element shadow tree)

This CL is basically a fix for a regression, which was intentionally introduced
in https://codereview.chromium.org/2186823002, where I removed the code to
prevent universal XSS.

The most part of this CL is a re-land of the code which was removed there.
See also the following CLs as necessary changes before landing this CL:
- https://codereview.chromium.org/2537143004
- https://codereview.chromium.org/2752763002

Regarding, event#currentTarget(), the current spec is unclear.  So, this CL
honored the original behavior.

BUG=667324

Review-Url: https://codereview.chromium.org/2742293006
Cr-Commit-Position: refs/heads/master@{#457705}

Make ash::mojom::ShelfItem match ash::ShelfItem.
Add required type and status enums; traits for all three.
Add a unit test for the ShelfItem struct traits.

Move ash/common/shelf/shelf_item_types.h to ash/public/cpp/shelf_item.h
Define ShelfID as int64_t for cross-platform and mojo type clarity.
Header and type usage cleanup.

BUG=557406
TEST=NONE; no functional behavior changes.
R=jamescook@chromium.org,tsepez@chromium.org
TBR=sky@chromium.org,reed@google.com

Review-Url: https://codereview.chromium.org/2750463009
Cr-Commit-Position: refs/heads/master@{#457704}

The dir auto code was using layoutObject()->style() to find the direction()
style value, but this means for a display: none element it'd fail to find the
direction and then we'd get the wrong answer.

Instead we should use computedStyle(), then we get the cached style for
display: none elements (or things like <option>) and correctly invalidate
the style when the properties that impact the auto direction change.

Review-Url: https://codereview.chromium.org/2746363012
Cr-Commit-Position: refs/heads/master@{#457703}

Currently, content scripts for all extensions are injected in single
task, causing a big jank on main thread. This patch changes
document_end and document_idle content scripts to run in separate tasks
asynchronously. The window.onload event is blocked until all
document_end scripts are injected.

This new behavior is protected by a feature switch, disabled by default.

To enable asynchronous execution, this CL adds a option parameter to
WebLocalFrame::requestExecuteScriptInIsolatedWorld(). Inside Blink,
it uses SuspendableScriptExecutor's ability to delay execution. So
async script executions are posted as timer tasks.

To test the new behavior, browser tests in content_script_apitest.cc
are parameterized so they run with and without the flag enabled.
Also, some extensions for tests are switched from document_idle to
document_end, since after this patch there's no reliable way to make
sure that all document_idle scripts have finished.

BUG=636655

Review-Url: https://codereview.chromium.org/2633253002
Cr-Commit-Position: refs/heads/master@{#457702}

This is required to implement crbug.com/698656.

BUG=698656

Review-Url: https://codereview.chromium.org/2741343015
Cr-Commit-Position: refs/heads/master@{#457701}

This CL makes MD Bookmarks responsive to bookmarks being moved.

BUG=692843
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2750463010
Cr-Commit-Position: refs/heads/master@{#457700}

This CL simplifies a Callback rebinding in cacheinvalidation, so that
it doesn't take a method pointer to Callback::Run.

Review-Url: https://codereview.chromium.org/2758723002
Cr-Commit-Position: refs/heads/master@{#457699}

BUG=701236
TBR=kbr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2760503002
Cr-Commit-Position: refs/heads/master@{#457698}

BUG=702329
TBR=enne@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2756853002
Cr-Commit-Position: refs/heads/master@{#457697}

Running time of loading.mobile test on nexus5X bot is exceeding 5 hours
timeout. This patch reduces number of each {easy,tough}_{ttfmp,tti} case
from 5 to 3, total stories from 50 to 42.

BUG=702175

Review-Url: https://codereview.chromium.org/2754883003
Cr-Commit-Position: refs/heads/master@{#457696}