- 28 Jul, 2020 40 commits
-
-
Kai Ninomiya authored
And: - Deprecates mapReadAsync, mapWriteAsync, and createBufferMapped. - Updates one other usage of the old mapping API. - Add GPUBufferUsage.QUERY_RESOLVE for compatibility with tests I'm writing. Bug: 1069302 Change-Id: I4710883d6ae1f66d3cd0f8216bc335d1e751472c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299538 Commit-Queue: Kai Ninomiya <kainino@chromium.org> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Reviewed-by:
Austin Eng <enga@chromium.org> Cr-Commit-Position: refs/heads/master@{#792149}
-
Charlie Harrison authored
Right now the conversions UI just looks at presence / absence of the ConversionManager to determine whether the feature is enabled. This isn't enough since we allow the embedder to disable at run-time. Bug: 1109987 Change-Id: Icf0622e5c21bba2a4995ba0dbde4a8ae5bf76e49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321238Reviewed-by:
John Delaney <johnidel@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#792148}
-
Xianzhu Wang authored
Most of the code is copied from perf_tests/paint/select-all-words.html Change-Id: I3d231a67f8162ac3145f070df38875de1a72dfa1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321233 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#792147}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/b1d870649dd5..43f111af3540 2020-07-27 primiano@google.com install-build-deps: clean node_modules when updating node 2020-07-27 dproy@google.com build: Update the nodejs version If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Test: Test: manual on mac Change-Id: I009e5610e8fc3793d7832ab5eaf6374e5c64f706 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321634Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#792146}
-
Brian Sheedy authored
Re-enables the Telemetry minidump symbolization tests on CrOS Betty devices, as the failures that caused them to be disabled appear to no longer be an issue. Bug: 1038043 Change-Id: Ibe335c60cb85ed29bd478dbfe6369d7e40d5c4e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321402Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#792145}
-
Avi Drissman authored
If another channel of Chromium is already default, don't ask to become default. Bug: 1109417 Change-Id: I095410b47a64731c7ca7fbafa5f3e3427ec89d42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318193Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#792144}
-
Ben Schwartz authored
This hides all the server choice fields when "Choose another provider" is not selected. It also adjusts the label and removes the bottom horizontal line, as requested. Bug: 1106095 Change-Id: Ib362f5f2507235dd63c76d1fd857943425bb7f00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320131Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Ben Schwartz <bemasc@chromium.org> Cr-Commit-Position: refs/heads/master@{#792143}
-
Sicheng Li authored
1. Adds the CustomTabOrientationController in SharedActivityCoordinator 2. Calls the setCanControlOrientaton() in the SharedActivityCoordinator#updateUi() 3. Implements the CustomTabOrientationController#setCanControlOrientaton() 4. Modifies the method of mapping orientation from AndroidX (convertOrientationType()) to chromium as we now take int as parameter instead of String 5. Imports ScreenOrientationLockType class to handle lock type 6. Adds a method as ScreenOrientationProviderImpl#setOverrideDefaultOrientation() to get the default screen orientation lock for TWAs or WebAPKs. Bug: 812797,989606 Change-Id: If07122814a7ca0e68f40fa70d9df24c68e3c5ccf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276255Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Sicheng Li <scli@google.com> Auto-Submit: Sicheng Li <scli@google.com> Cr-Commit-Position: refs/heads/master@{#792142}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: Ia859e9e047f269cc301f938cfdb14ba1618757b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321968Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#792141}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/0307e9114c30..b3038f8cb5c5 2020-07-28 johnstiles@google.com Remove layout(key) support for rects and points. 2020-07-27 johnstiles@google.com Update DataEntry struct to properly support move semantics. 2020-07-27 johnstiles@google.com Allow GLSL processor keys to use floats with full precision. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC borenet@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: borenet@google.com Change-Id: Idd39a70ff7f79e56292c7d166b9f04a000ecc6b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321633Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/478f7fed94ec..0dde0b31cf31 2020-07-27 kahinds@microsoft.com Convert localized URL-only strings to normal strings If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I10a6cd911f113480c1b096210b181a906cdfacea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321629Reviewed-by:
-
Chris Harrelson authored
Tables always paint collapsed borders, even if the rows are seprately composited. While we don't need to invalidate paint for the table (because the row is the DisplayItemClient for the borders), we do need to cause repaint for its painting layer, because the table paints those borders. See also (*), which removed the code that previously had the same effect. There was previously no test for this code. (*) https://chromium-review.googlesource.com/c/chromium/src/+/2317848 Change-Id: I269101d3bf28445c0ec3d1f6bcad1a23cf3e46d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321234 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#792138}
-
Krishna Govind authored
TBR=benmason@chromium.org Change-Id: I9f2af40de2705fb07dc0ef18aba665ea26564b31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321826 Commit-Queue: Krishna Govind <govind@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#792137}
-
Mike Wittman authored
Supports alignment of pointers without forcing users to employ the casts required to use the existing functions. Enables only for pointers to 1 byte types (e.g. uint8_t/char) to avoid ambiguity about whether alignment is measured in bytes or sizeof of the pointed-to type. Updates code to use the new functions. Change-Id: If196122876c7e753b3faaa116fdf1874d8cf1db9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300342 Commit-Queue: Mike Wittman <wittman@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Wan-Teh Chang <wtc@google.com> Reviewed-by:
vmpstr <vmpstr@chromium.org> Auto-Submit: Mike Wittman <wittman@chromium.org> Cr-Commit-Position: refs/heads/master@{#792136}
-
Siyu An authored
Bug: 1095037 Change-Id: I456518658b6d2f3f1609947269aed5cce58f503c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321108Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Siyu An <siyua@chromium.org> Cr-Commit-Position: refs/heads/master@{#792135}
-
Yuke Liao authored
Exclude ui_base_unittest from linux lacros builders due to a compile failure. Bug: 1110072 Change-Id: Ia228c2d6959d4821c2258d68bccb0a34d02bf02e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321244Reviewed-by:
Sven Zheng <svenzheng@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#792134}
-
Hitoshi Yoshida authored
This reverts commit 662e18cb. Reason for revert: This CL seems to be a trigger of a test failure on Mac. Bug: 1110172 Original change's description: > Don't use constrained dialogs for macOS certificate viewer. > > Instead parent the sheet to the specified gfx::NativeWindow directly. > This avoids a host of bugs around the native constrained dialogs > machinery, but does mean the dialog is now window-modal rather than > tab-modal. On Windows, where we also use the native dialog, the sheet is > similarly window-modal and the certificate viewer only ever opens in > response to the user clicking in browser-owned UI or DevTools, so there > shouldn't be an abuse concern. > > See https://crbug.com/1098786#c4 > > Bug: 762915, 1078158, 1098786 > Change-Id: Iafeee58fd04aff9f8b88e8c2f030fe18913f81f2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2313160 > Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> > Commit-Queue: David Benjamin <davidben@chromium.org> > Cr-Commit-Position: refs/heads/master@{#791907} TBR=ellyjones@chromium.org,davidben@chromium.org Change-Id: I8e29389c8a609daeed12b13d50b3d8d27f8959d6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 762915 Bug: 1078158 Bug: 1098786 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320913Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#792133}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/308078b0ca18..52d2563373fa 2020-07-27 jmadill@chromium.org Disable GPU time tracking in trace tests. 2020-07-27 cclao@google.com Vulkan: Add cache for driver uniform descriptor set 2020-07-27 syoussefi@chromium.org Vulkan: Fix render target's tracking of content defined 2020-07-27 m.maiya@samsung.com Vulkan: Enable VK_KHR_get_memory_requirements2 extension 2020-07-27 cclao@google.com Vulkan: Increase default uniform buffer size to 64K If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC tobine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: tobine@google.com Change-Id: Ic92250b699dbe1d32b115681723177412599d520 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321787Reviewed-by:
-
John Williams authored
Bug: b/161609791, 1107157 Change-Id: I66010e578d8f7541134c5f80bb7b194fdeb9b42a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310903Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: John Williams <jrw@chromium.org> Cr-Commit-Position: refs/heads/master@{#792131}
-
Hitoshi Yoshida authored
This reverts commit 7ec7300a. Reason for revert: This CL still breaks interactive_ui_tests. See crbug.com/1110181 for the details. Bug: 1110181 Original change's description: > Reland "Add pixel browser tests for focus rings" > > Original Patch: https://chromium-review.googlesource.com/c/chromium/src/+/1986972 > Revert: https://chromium-review.googlesource.com/c/chromium/src/+/2148472 > > The original patch was reverted for three reasons: > 1. android-pie-x86-rel had slightly different pixel output. I am > addressing this with a fuzzy pixel comparator, and the bot passes in > "Choose Tryjobs". > 2. android-arm64-proguard-rel started failing, and surprisingly it > showed that it was using the linux baseline as the expected output. > This must have happened because I left in the logic for separate > marshmallow baselines but didn't provide a separate marshmallow > baseline. This shouldn't happen again now that I removed the check > for a separate marshmallow baseline. Unfortunately this bot does not > appear in "Choose Tryjobs," but I am confident that at the very least > the bot will not fail again for the same reason. > 3. Focus rings on different macos versions have different colors. I > fixed this in http://crrev.com/786769 and verified that it works by > running tests on the various macos bots available in "Choose Tryjobs" > > This patch also implements the suggestion crbug.com/1091661 and > re-enables the tests disabled in that bug. > > In the original patch, I made a new file called screenshot_test_utils, > but I found another function in browser_test_utils which does the same > thing, so this patch doesn't have screenshot_test_utils anymore. > > Bug: 1038425, 1022122, 1039866, 1091661 > Change-Id: Ic1642179bd3ca659f3b4b1f3a25c86a719518ede > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150765 > Commit-Queue: Joey Arhar <jarhar@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Reviewed-by: Mason Freed <masonfreed@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Cr-Commit-Position: refs/heads/master@{#792092} TBR=avi@chromium.org,sky@chromium.org,vmpstr@chromium.org,masonfreed@chromium.org,jarhar@chromium.org Change-Id: I33f8898677410e7674d2f396c5c29e507c52d0a4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1038425 Bug: 1022122 Bug: 1039866 Bug: 1091661 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2322006Reviewed-by:
-
Dominic Farolino authored
As per typical Chromium style, we separate system includes from intra-project includes. This CL fixes that for resource_loader.cc in Blink. Bug: N/A Change-Id: I6a64b76862df1c41b0e4f9be5ebabd3660c86a85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321250Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/master@{#792129}
-
Matthew Denton authored
Glibc 2.32 (development version) registers rseq on thread startup. Because libraries' ELF constructors may see that rseq is registered, and it is unclear that libraries should have to deal with rseq deregistration, just allow it globally. Otherwise rseq registration status will be out of sync between threads which could cause unexpected issues. Hopefully different parts of Chrome will leverage it for fast per-cpu data. Bug: 1104160 Change-Id: I3f93ee598004910ffde46ee782ba60b6201ae8ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298525 Commit-Queue: Matthew Denton <mpdenton@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#792128}
-
Rakina Zata Amni authored
Finishes the move of WebPreferences to WebContents that started in crrev.com/c/2263635 by moving OnWebkitPreferencesChanged, ComputeWebPreferences, SetSlowWebPreferences to WebContents. AX-Relnotes: n/a Bug: 1085003 Change-Id: I0a9973245f29d0fad785d279eecdc6c239b0f897 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2266917Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#792127}
-
Mike Dougherty authored
On iOS 14, when set as default browser, Chrome can receive http and https URLs directly from system and third party apps. Extend the metrics to capture this case separately from the default case where the source application is unknown. Bug: 1101058 Change-Id: Ieb269be5d93d00c07e23e25d366037667d986cd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315199Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#792126}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: I4c25f81b7892b2975677df81eb56639f7269271e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321535 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
-
Andrey Kosyakov authored
TBR=kvitek, wez ... with the exception of Fuchsia where they don't behave. Flakes/timeouts need further investigation, but they seem fine on most OSes most of the time and this is a piece of coverage that we can't sacrifice. Bug: 1107396, 1110091 Change-Id: Idb9da904566ad0a4d9bc77a9e9e159df2f03aaa5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321551Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#792124}
-
Jinsuk Kim authored
PreviewTab is enabled only on non-low-end devices. This CL stops its tests from running on build bots for low-end devices. Bug: 1096808 Change-Id: Ie314b05163a7d567074b2d284f7c3c1331b1c4ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321806Reviewed-by:
Donn Denman <donnd@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#792123}
-
nancylingwang authored
When there is only 1 icon file(icon_xxx.png) for the app, there could be 2 cases: 1. The icon is not the adaptive icon 2. The system just migrated from the adaptive icon feature disabled to enabled. To distinguish these 2 scenarios, modify the arc_app_list_prefs. If the adaptive icon feature is enabled, for non-adaptive icons, save the image to both icon_xxx.png and foreground_icon_xxx.png. Then ArcAppIcon can check the files to know whether the current icon is non-adaptive icon or the system migration case. If there is no foreground icon, that means the system migration case, then we should request the icon. Otherwise, that means the icon is a non-adaptive icon. This is also preparing for the next step, removing the icon_xxx.png, so that we can have 2 png files only: foreground_icon_xxx.png: Present the foreground image for the adaptive icon or the image for the non-adaptive icon. background_icon_xxx.png: Present the background image for the adaptive icon. TODO: Add the metric to verify whether we have non-adaptive icon scenario. If all icons return from ARC side are 2 layer, for the next step, we can add some DCHECK and remove the icon_xxx.png, and force checking both the foreground and background images. BUG=1083331 Change-Id: I516c4a317040da03902f80ddbaa9876325bfbd35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318885Reviewed-by:
Long Cheng <lgcheng@google.com> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#792122}
-
Adrienne Walker authored
Since sometimes the WebIDBGetDBNamesCallbacksImpl can be destroyed when the promise is resolved, make sure that no code that could reference it is still around. Store the async task as an optional member so it can be cleared during the destructor. Followup to: https://chromium-review.googlesource.com/c/chromium/src/+/2311620 Bug: 1109467 Change-Id: Id6a0ff0a3703fab94e9684e41f16d5a1bac20468 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321332Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: enne <enne@chromium.org> Auto-Submit: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#792121}
-
Reilly Grant authored
Renames these targets from "service" to "services" to match the other test target names defined for this directory. Change-Id: Idf0473638223747327c4c500b768ea43495e2e39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317859 Auto-Submit: Reilly Grant <reillyg@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#792120}
-
Brian Sheedy authored
Fixes GPU Telemetry tests on CrOS devices not capturing JavaScript console messages (and a large chunk of the actual browser logging) in the browser log artifacts. The cause was a combination of: 1. The --enable-logging=stderr flag we pass by default messes with browser logging on CrOS, apparently because stderr doesn't go anywhere on CrOS. 2. Not passing a --log-level flag, as apparently JavaScript logging is log enough verbosity (even when done via console.error) to show up with the default verbosity. Bug: 1102664 Change-Id: Ia06e59cb9bafcda32266960e4310e99bc2a831a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316846 Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#792119}
-
tby authored
There's a flaky DCHECK crash in launcher search, due to the query getting out of sync in the ranker vs the returned search results. This is caused by deeper problems, but this CL is a quick patch that should fix the immediate issue. Currently we don't update the most recent query if two searches happen in quick succession, even if the second search contains a genuinely new query. Let's fix that. Bug: 1109017 Change-Id: Iac78aef0dae6d4001fc0726ac0deb5ced9bd11aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319949Reviewed-by:
Jia Meng <jiameng@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#792118}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I81472cf59fbd23754ffb30f3545d0f159b7bad00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321791Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Iee8222c6d1a8faaef24267cff726abbf963a2d04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321343Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1595872800-d57a770d7bc200213efd65ae14b0000c1824f2dd.profdata to chrome-mac-master-1595894324-d422a20c76a9a0bf9c80e2917291820d179a400b.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I6b5a3fc99978ece7b870b8bc8bb10ac73d935586 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321845Reviewed-by:
-
Shengfa Lin authored
strip is incompatible on Mac with Linux, which could cause large binary size. Make sure it's linux env before running release script Bug: chromedriver:3556 Change-Id: I7f7d9b9a12bb78a558016a28a7c5ecc3dc7098de Notry: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321715Reviewed-by:
-
Scott Violet authored
SecurityInterstitialPage::ShouldCreateNewNavigation() is not used. BUG=none TEST=none Change-Id: I73bd846489577e786c28126b190d6c6256c3b4cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318317Reviewed-by:
Carlos IL <carlosil@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#792113}
-
Chris Lu authored
See bug for Finch Config Screenshot: https://drive.google.com/file/d/1MTSsMCjvCoTW4yBKGaH1wCBzOroVeWnT/view?usp=sharing Bug: 1107489 Change-Id: Ia01af991e4019ac10011b340b39dde358fbfdab0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309129 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#792112}
-
Ben Pastene authored
All Simple Chrome builders should have migrated to using args.gni files fetched during gclient-runhooks. And so there's no bot that should be calling out to `cros chrome-sdk` during GN-gen or compile any longer. Bug: 937821 Change-Id: If24f4b30e29232bef7bb969ea03afdae22e9143b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321231Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#792111}
-
Mario Bianucci authored
Prediction and prediction related features were all used for scrolling and input events, so they lived in blink and had scrolling specific names. This CL moved them from being blink and having feature specific names to being in ui/base with feature-agnostic names. The motivation for this move is to enable the prediction classes to be used elsewhere. Specifically, I will be using prediction from viz in order to predict future points on an ink stroke as part of the delegated ink trail feature in order to improve user perceived latency. Bug: 1052145 Change-Id: I3399ecabf962544dc1a4ecefe42583f1d717b6de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270635Reviewed-by:
Ella Ge <eirage@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Daniel Libby <dlibby@microsoft.com> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Mario Bianucci <mabian@microsoft.com> Cr-Commit-Position: refs/heads/master@{#792110}
-
