- 27 Feb, 2019 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/3c9baa37c2b7..f2eb10133f86 git log 3c9baa37c2b7..f2eb10133f86 --date=short --no-merges --format='%ad %ae %s' 2019-02-27 benjhayden@chromium.org Add report-template for spa 2019-02-27 benjhayden@chromium.org Add report-table for spa Created with: gclient setdep -r src/third_party/catapult@f2eb10133f86 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:918193,chromium:918193 TBR=sullivan@chromium.org Change-Id: I48041d41a746f119643e8f3c17a720ee62e99c29 Reviewed-on: https://chromium-review.googlesource.com/c/1491115Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#635936}
-
Oleg Davydov authored
Years ago DebugLogWriter used runners from SequencedWorkerPool to gather and archive logs, thus requiring sequence_token_name argument to identify pool. In b116e3b7 this was deprecated, work migrated to TaskScheduler. But sequence_token_name argument persisted and was passed into different methods without any real usage. Also migrate from legacy Callback to OnceCallback. Change-Id: If2b650fd6d7221be75002db28dd4afb46c14d6a5 Reviewed-on: https://chromium-review.googlesource.com/c/1480520Reviewed-by:
Rahul Chaturvedi <rkc@chromium.org> Reviewed-by:
Denis Kuznetsov <antrim@chromium.org> Commit-Queue: Oleg Davydov <burunduk@chromium.org> Cr-Commit-Position: refs/heads/master@{#635935}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2fe8f49257b7..49d0ee8be197 Created with: gclient setdep -r src-internal@49d0ee8be197 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Icf0796e0e4f9b271240451e8c7edc0d782155b2c Reviewed-on: https://chromium-review.googlesource.com/c/1491116Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#635934}
-
Dana Fried authored
This would have been expected behavior for a flex layout, but was not previously implemented. Along with re-implementing LocationBar::CalculatePreferredSize(), the associated bug should be addressed. Bug: 935218 Change-Id: Ib003672a89636e7d4e45bd5dc509eb810a6112e5 Reviewed-on: https://chromium-review.googlesource.com/c/1490524 Commit-Queue: Dana Fried <dfried@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#635933}
-
Clemens Arbesser authored
Bug: 806868 Change-Id: I8dabef308839aca8957226db91f7b98bae31c01e Reviewed-on: https://chromium-review.googlesource.com/c/1489206 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#635932}
-
Fredrik Söderquist authored
Since we no longer include the dash-effect when computing (appromixating) the stroke bounds, we don't need to trigger (re)layout when they change. This can help eliminate layouts for example for "line animations" like the one on https://jakearchibald.com/2013/animated-line-drawing-svg/ Bug: 435097 Change-Id: Iaf5298620889b6ed0cb10437514bb8af3104cc35 Reviewed-on: https://chromium-review.googlesource.com/c/1489202Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#635931}
-
tzik authored
This fixes a build failure of base_bind_rewriters, that seems broken by an autogenerated CL for IWYU. Change-Id: Ia872fde31ab9bc58b4e49aebfc326f6308e948e5 Reviewed-on: https://chromium-review.googlesource.com/c/1491067Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#635930}
-
Alex Danilo authored
Change https://chromium-review.googlesource.com/c/chromium/src/+/1474873 extended the information returned from handler matching for a file by retaining the reason for the matching (MIME type and/or file extension). This CL removes the old method call and replaces it with the extended method to clean up the code. Bug: 936296 Tests: Ran all browser and unit tests. Change-Id: I791c3885298fa480df9363f7e423047cb59ecd0d Reviewed-on: https://chromium-review.googlesource.com/c/1491063Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#635929}
-
Tim Song authored
TEST=manually tested with chrome://user-actions/ BUG=921250 Change-Id: I914462bf6fda10e9fd3d88d0f808ae04a44130ca Reviewed-on: https://chromium-review.googlesource.com/c/1488173 Commit-Queue: Tim Song <tengs@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#635928}
-
Rijubrata Bhaumik authored
Rename NFCMessage to NDEFMessage. nfc_message.idl -> ndef_message.idl git grep -l 'NFCMessage' | xargs sed -i 's/NFCMessage/NDEFMessage/g' git grep -l 'NfcMessage' | xargs sed -i 's/NfcMessage/NdefMessage/g' Java does not allow to import same className from different packages, which in this case is NdefMessage So not importing android.nfc.NdefMessage and using fully qualified name to avoid ambiguity. Repeat the same for NFCRecord -> NDEFRecord. Spec changes for this corresponding CL: https://github.com/w3c/web-nfc/commit/5b74305be004a8e758d4931f8409bd354bc4039e Bug: 520391 Change-Id: Ib88e0db5c9cd7fa973170f93c5f5352dcda6630e Reviewed-on: https://chromium-review.googlesource.com/c/1481296Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Cr-Commit-Position: refs/heads/master@{#635927}
-
Jan Krcal authored
After a full launch of UssWalletData on Stable, this CL simplifies parametrization for sync_intgration tests. From now on, we only switch between Directory and USS implementation of WalletMetadata. Bug: 853688 Change-Id: I500bbb66b5aed65d27ea9e4955bbfb4e31023630 Reviewed-on: https://chromium-review.googlesource.com/c/1489194 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Auto-Submit: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#635926}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/620621059b29..ab3f8674c9d2 git log 620621059b29..ab3f8674c9d2 --date=short --no-merges --format='%ad %ae %s' 2019-02-27 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset Created with: gclient setdep -r src/third_party/skia@ab3f8674c9d2 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=scroggo@chromium.org Change-Id: I2e02ca72c0c8c273d40a023112acb43d296afcb5 Reviewed-on: https://chromium-review.googlesource.com/c/1491113Reviewed-by:
-
François Beaufort authored
This CL adds a mute button in the Picture-in-Picture window that reflects the muted state of the video. If there is no audio track, mute button will be hidden. This button is working only if experimental blink feature MuteButton is enabled or if the Origin Trial with the same name is enabled. Screenshot: https://i.imgur.com/UqIhaIV.png Change-Id: Ibe91abdbcf54d01122010dfe0bf5b99a15415cec Bug: 935080 Reviewed-on: https://chromium-review.googlesource.com/c/1473271Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Eliot Courtney <edcourtney@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#635924}
-
Noel Gordon authored
Running tests will require a http server, puppeteer and some .js files to do the actual testing in a browser. Add a script to drive the whole testing process. Output: % npm run test tests PASS If there was a test failure, a test.log is available to figure out the problem. Bug: 935285 Change-Id: I12f69008d37c67433901ed6a37a3d7e9375abac3 Reviewed-on: https://chromium-review.googlesource.com/c/1491155Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#635923}
-
Adam Rice authored
Some worklet contexts lack MessagePort and so cannot implement tranferable streams. This is detected by looking for the MessagePort_postMessage function on the binding object, which is initialised during context creation. Previously MessagePort_postMessage was only placed on the binding object when it was available, meaning when it was absent the prototype chain was searched for it. Since this could be interfered with by code running on the page, initialise it to undefined instead. BUG=934201 Change-Id: Ic114d92300207f41a8b762457504a4d70009ee34 Reviewed-on: https://chromium-review.googlesource.com/c/1488402Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#635922}
-
Julie Jeongeun Kim authored
This CL moves mime_registry.mojom to public/mojom/mime in order to organize mojom files at mojom folder. Bug: 919393 Change-Id: I4c718d3560371e12ab7ca2522a0d43f1eddfe33c Reviewed-on: https://chromium-review.googlesource.com/c/1478650Reviewed-by:
-
Adam Rice authored
Make const accessors return const pointers. Mark more method arguments as const. BUG=902633 Change-Id: I4d743be2ab56af4d3a9be493ba4b322d5ef40b41 Reviewed-on: https://chromium-review.googlesource.com/c/1488396Reviewed-by:
-
chaopeng authored
The log shows the event target is not null. The issue maybe caused by OS does not send out OnContentUpdated which is the OS notify Chrome a event ready to read. I add a log to it see if OnContentUpdated called by OS or ignored. Bug: 914914 Change-Id: I0e63798c3382c2a10b7aade13600712b75bd3d31 Reviewed-on: https://chromium-review.googlesource.com/c/1489305Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Jianpeng Chao <chaopeng@chromium.org> Cr-Commit-Position: refs/heads/master@{#635919}
-
Kush Sinha authored
Bug: 925827 Change-Id: Ib3f4349a699a7e79e53b5319102874f9bad1b17d Reviewed-on: https://chromium-review.googlesource.com/c/1477854 Commit-Queue: Kush Sinha <sinhak@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#635918}
-
sczs authored
- InfobarBadgeTabHelper observes InfoBarManagerObserver for any Infobars that were presented or removed. - If the Infobar is a Message we will let the delegate know so it displays a badge. Bug: 911864 Change-Id: I3569efe9c982c1d473368ca199ce2a65251ce197 Reviewed-on: https://chromium-review.googlesource.com/c/1487797Reviewed-by:
Peter Lee <pkl@chromium.org> Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#635917}
-
Tim Song authored
TEST=manually verified UI BUG=860190 Change-Id: I431cf99e850f77ab64a02e054272c449cd9bc04e Reviewed-on: https://chromium-review.googlesource.com/c/1490505 Commit-Queue: Tim Song <tengs@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/75e6934397d8..2fe8f49257b7 Created with: gclient setdep -r src-internal@2fe8f49257b7 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I506674195c80a6db706f677aaf8726b9cd454b2c Reviewed-on: https://chromium-review.googlesource.com/c/1491114Reviewed-by:
-
Takashi Toyoshima authored
When activeTab permission is granted, the extension frame obtains a permission to access the web-page origin for the active tab beyond the CORS policy. API document: https://developer.chrome.com/extensions/activeTab Now that URLLoaderFactory interface can take a factory bound access list on its creation, we can handle the tab specific permission by pushing a new Factory with a factory bound list to the extension frames. This works only when NetworkService is enabled, but we can expect it will be available soon on desktops, and Extensions do not need to support mobiles. Design document: https://docs.google.com/document/d/1Aqhx9dOkv0ZI5CDg8zxafPC-JTA66Cu6e_Tu9i5G6wQ/edit?usp=sharing browser_tests --gtest_filter='*/ExtensionActiveTabTest.ActiveTab/*' pass now. Bug: 909639, 936310 Change-Id: I655fe783e827c96ede13904ecdc241f9b9673a8b Reviewed-on: https://chromium-review.googlesource.com/c/1351326 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#635914}
-
Hiroshige Hayashizaki authored
This reduces the number of recompiled files when core/frame/csp/content_security_policy.h is modified, from ~3000 to ~300. Bug: 934651 Change-Id: I2f072b0f2d61a8600bfe7f8873fb4267c34e80f3 Reviewed-on: https://chromium-review.googlesource.com/c/1485237Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#635913}
-
Krishna Govind authored
R=kariah@chromium.org Change-Id: I02c840c029cf07a5c7b9477b40ae6debb1726f2a Reviewed-on: https://chromium-review.googlesource.com/c/1490504Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#635912}
-
Daniel Cheng authored
Change-Id: I9e010bc19bb4dd99c7725c2a17559eff43634238 Reviewed-on: https://chromium-review.googlesource.com/c/1488477Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#635911}
-
Wenzhao Zang authored
Remove the deprecated v2 css class. Also remove unused assets. Bug: 812085 Change-Id: I2eef2dd7f1e6386e626903cc294b09d50df765c3 Reviewed-on: https://chromium-review.googlesource.com/c/1490738Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#635910}
-
Joel Hockey authored
Add check before showing installer, and also a check within CrostiniRestarter to ensure crostini is allowed before installing. Bug: 935121 Change-Id: Iea773184e5aa4fb41694e4b7d8b320a55242343a Reviewed-on: https://chromium-review.googlesource.com/c/1487751 Auto-Submit: Joel Hockey <joelhockey@chromium.org> Commit-Queue: Timothy Loh <timloh@chromium.org> Reviewed-by:
Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#635909}
-
Kush Sinha authored
Chrome OS Account Manager's observers need to map |AccountManager::AccountKey| to email ids. This mapping was being provided by |AccountMapperUtil|, but we want to eliminate that class and maintain the mapping directly in AccountManager. https://crrev.com/c/1452003 ensured that all new account additions in Chrome OS Account Manager have an email id associated with them. This patch makes the email id available for reading in observer notifications and |AccountManager::GetAccounts|. Bug: 925827 Test: chromeos_unittests --gtest_filter="*AccountManager*Test*" Test: unit_tests --gtest_filter="*CrOSOAuthDelegateTest*" Test: browser_tests --gtest_filter="*Arc*AuthService*Test*" Change-Id: I0e130ce968a02a37f2380460f6936b5cf169ae02 Reviewed-on: https://chromium-review.googlesource.com/c/1477691Reviewed-by:
-
John Abd-El-Malek authored
Reland "Remove mojo-blob-urls virtual test suites now that network service has launched on desktop and trunk is running with it enabled." This is a reland of 868af228 Original change's description: > Remove mojo-blob-urls virtual test suites now that network service has launched on desktop and trunk is running with it enabled. > > Bug: 933880 > Change-Id: I3fbc8b037126ddefe75fa1400e89486cc22d214c > Reviewed-on: https://chromium-review.googlesource.com/c/1488834 > Commit-Queue: John Abd-El-Malek <jam@chromium.org> > Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> > Auto-Submit: John Abd-El-Malek <jam@chromium.org> > Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> > Cr-Commit-Position: refs/heads/master@{#635708} TBR=mek@chromium.org Bug: 933880,936237 Change-Id: I8e52a7e55343fb5b41d684bd701d57e5a344eb06 Reviewed-on: https://chromium-review.googlesource.com/c/1490756Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#635907}
-
Luciano Pacheco authored
Bug: 778674 Change-Id: I6a69a7ed428c93d6f37ba6eb6c685b6ca850f787 Reviewed-on: https://chromium-review.googlesource.com/c/1490351 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#635906}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/0d1d8c12e826..3c9baa37c2b7 git log 0d1d8c12e826..3c9baa37c2b7 --date=short --no-merges --format='%ad %ae %s' 2019-02-27 benjhayden@chromium.org Add layoutTimeseries() for spa Created with: gclient setdep -r src/third_party/catapult@3c9baa37c2b7 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:918193 TBR=sullivan@chromium.org Change-Id: Ifa8053c825e921c185649d2ac6853c75bbdbfef8 Reviewed-on: https://chromium-review.googlesource.com/c/1491112Reviewed-by:
-
sczs authored
Bug: 911864 Change-Id: I98b9992822b6432ad2531f77b5749192e143dc52 Reviewed-on: https://chromium-review.googlesource.com/c/1488060Reviewed-by:
-
Josh Pratt authored
Changes the /crostini/shared_usb_devices page in crostini settings to more closely match /crostini/shared_paths and other settings UI. Bug: 930588 Change-Id: I14ec8a58ce4b263520efbdcd317281a30de3d2ad Reviewed-on: https://chromium-review.googlesource.com/c/1477569 Commit-Queue: Josh Pratt <jopra@chromium.org> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#635903}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f90ad85cf0cc..75e6934397d8 Created with: gclient setdep -r src-internal@75e6934397d8 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ia70c65cc11bd368ed3f501bcf69ae3a322f22f47 Reviewed-on: https://chromium-review.googlesource.com/c/1490389Reviewed-by:
-
Gayane Petrosyan authored
Remove blue rectange for focused element with .using-mouse-nav class. Previously CSS selector only selected children of .using-mouse-nav element that are focused. Bug: 935252 Change-Id: I338d995ab02076fc9fb671c660d8f397dd1a6898 Reviewed-on: https://chromium-review.googlesource.com/c/1490734Reviewed-by:
Kristi Park <kristipark@chromium.org> Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Cr-Commit-Position: refs/heads/master@{#635901}
-
Findit authored
This reverts commit d7c1e86c. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 635829 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2Q3YzFlODZjMzNjNDIzMjJmMWQ0M2QwOTU3NmUyZjNjNDFhOGUyNDEM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.memory/Linux%20ChromiumOS%20MSan%20Tests/11520 Sample Failed Step: browser_tests Original change's description: > Delay querying for printers list until the policy file is parsed > > A list of enterpise printers is not ready immediately after creation of > CupsPrintersManager. It caused a problem for testing procedure since from the > level of autotest_private_api we do not know if the final list is ready or > there are still some ongoing calculations. A new method called > OnEnterprisePrintersInitialized() was added to the observer of > CupsPrintersManager to solve this issue. Also whole code related to > enterprise printers were refactored, large part of functionality was moved > from SyncedPrintersManager to new class EnterprisePrintersProvider. Classes > ExternalPrintersPrefBridge and DeviceExternalPrintersSettingsBridge have been > merged into one class called CalculatorsPoliciesBinder. > > BUG=chromium:816996 > TEST=Tested on nautilus with the use of CL:1451591 > > Change-Id: I50745f18beacab213216e5f367db0d023190e9e4 > Reviewed-on: https://chromium-review.googlesource.com/c/1220547 > Commit-Queue: Piotr Pawliczek <pawliczek@chromium.org> > Reviewed-by: Achuith Bhandarkar <achuith@chromium.org> > Reviewed-by: Maksim Ivanov <emaxx@chromium.org> > Reviewed-by: Sean Kau <skau@chromium.org> > Auto-Submit: Piotr Pawliczek <pawliczek@chromium.org> > Cr-Commit-Position: refs/heads/master@{#635829} No-Presubmit: true No-Tree-Checks: true No-Try: true BUG=chromium:816996 Change-Id: I03bae898e61c3107977268bf33d1582fe6eacb81 Reviewed-on: https://chromium-review.googlesource.com/c/1491134 Cr-Commit-Position: refs/heads/master@{#635900}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/71865048224b..620621059b29 git log 71865048224b..620621059b29 --date=short --no-merges --format='%ad %ae %s' 2019-02-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 6c9fb0e6353c..ead1a345a36c (1 commits) 2019-02-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 9f20dd777b50..009696c56169 (2 commits) 2019-02-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 1bc7ee95f75b..6c9fb0e6353c (1 commits) 2019-02-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 7f6f891204d0..1bc7ee95f75b (1 commits) Created with: gclient setdep -r src/third_party/skia@620621059b29 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=scroggo@chromium.org Change-Id: If647d6f17d71ff6a9dcf0369458ddfb038e7164c Reviewed-on: https://chromium-review.googlesource.com/c/1490390Reviewed-by:
-
Miyoung Shin authored
- unsigned short -> uint16_t. - No logic changes. - Reference: https://google.github.io/styleguide/cppguide.html#Integer_Types Bug: 929986 Change-Id: Idddb94ba48c84b22cbaea850ae2c6d394759d50e Reviewed-on: https://chromium-review.googlesource.com/c/1490360Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/9e723d07..32291a4d Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ie0ce355f61c0b301fd0b0f4f8ca9cc114ac9574c Reviewed-on: https://chromium-review.googlesource.com/c/1490908Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#635897}
-
