GitLab

This fixes crashing bug. The check should be in ImageManager::OnImageFetched()
instead of ImageFetcherImpl::OnFetchComplete(). Indeed, the unit test in
image_fetcher_impl_browsertest.cc also allows it.

Also added extra non-NULL DCHECK in ImageManager::GetImageURL(), and
verified that current callers do not passing NULL to it.

BUG=428117
TBR=mathp

Review URL: https://codereview.chromium.org/689993004

Cr-Commit-Position: refs/heads/master@{#302258}

Make the isolate generation aware that the NaCl
can be disabled and don't try to use those files
if it is disabled.

BUG=428264
R=maruel@chromium.org
TEST=./build/gyp_chromium -Ddisable_nacl=1 && ninja -C out/Release

Review URL: https://codereview.chromium.org/687173002

Cr-Commit-Position: refs/heads/master@{#302257}

 - BisectPerformanceMetrics class:
   - Added src_cwd to constructor to allow easier mocking.
     Using os.getcwd() creates non-obvious expectations from
     the caller.
   - Exposed printer field to allow it being reused outside.
   - Added a comment explaining arguments to the constructor.
 - BisectOptions class:
   - Changed from deprecated optparse to argparse
   - Split _CreateCommandLineParser
   - Moved logic from ParseCommandLine to argparse where
     possible
 - Removed code related to ChromeOS

BUG=425652
R=qyearsley@chromium.org
CC=ojan@chromium.org

Review URL: https://codereview.chromium.org/691553002

Cr-Commit-Position: refs/heads/master@{#302256}

Blink roll fe66e723f6a575d814e559e9850eb741d2b1c0dd:5feaa4b285ce283c7ff54e29b95102f5d8bca17c (svn 184678:184702)

TBR=morrita

Review URL: https://codereview.chromium.org/695813002

Cr-Commit-Position: refs/heads/master@{#302255}

Revert of Registration of DevTools bridge in GCD. (patchset #4 id:80001 of https://codereview.chromium.org/677843006/)

Reason for revert:
Only CL that landed before http://build.chromium.org/p/chromium.mac/waterfall?builder=Mac%20Builder broke. Going to revert this CL to try and get the builder working again.

Original issue's description:
> Registration of DevTools bridge in GCD.
>
> Code for registering and unregistering instance of DevTools bridge in GCD.
> GCDRegistrationFragment is able to perform registration including:
> 1. Asking user for desired account to register.
> 2. Requesting OAuth permissions for GCD (may show confirmation activity to the user).
> 3. Registration in Cloud Messages if needed.
>
> It also shows toasts with registration/unregistration results.
>
> GCDRegistrationFragment is absstract and has no views. Testing implementation
> shows button "Registed in GCD/Unregister (registered for ...)". Registration is not
> persistent yet.
>
> BUG=383418
> TEST=New button in main activity of DevToolsBridgeTest.apk: register/unregister.
>
> Committed: https://crrev.com/a2da02bd99d78de549b617510551ec5e1f7073d9
> Cr-Commit-Position: refs/heads/master@{#302251}

TBR=mnaganov@chromium.org,serya@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=383418

Review URL: https://codereview.chromium.org/693153003

Cr-Commit-Position: refs/heads/master@{#302254}

Cr-Commit-Position: refs/heads/master@{#302253}

Currently if context menu is invoked on any anchor link and
'open in new tab' option is selected then nothing happens.
Adding code to launch new tab with selected url

BUG=428625

Review URL: https://codereview.chromium.org/682223003

Cr-Commit-Position: refs/heads/master@{#302252}

Code for registering and unregistering instance of DevTools bridge in GCD.
GCDRegistrationFragment is able to perform registration including:
1. Asking user for desired account to register.
2. Requesting OAuth permissions for GCD (may show confirmation activity to the user).
3. Registration in Cloud Messages if needed.

It also shows toasts with registration/unregistration results.

GCDRegistrationFragment is absstract and has no views. Testing implementation
shows button "Registed in GCD/Unregister (registered for ...)". Registration is not
persistent yet.

BUG=383418
TEST=New button in main activity of DevToolsBridgeTest.apk: register/unregister.

Review URL: https://codereview.chromium.org/677843006

Cr-Commit-Position: refs/heads/master@{#302251}

Improvements of TimeoutRetryThread so that it is possible to stop threads which have already timed out (instead of keeping them like zombie threads running in the background).

Provides a timeout_retry.WaitFor to wait until a condition becomes true.

Also migrates some DeviceUtils methods to use the new adb_wrapper:
- WaitUntilFullyBooted
- GetProp/SetProp
- GetApplicationPath

BUG=267773

Review URL: https://codereview.chromium.org/636273004

Cr-Commit-Position: refs/heads/master@{#302250}

This patch implements interaction with KHR_robustness. It's especially
concerned with handling CONTEXT_LOST_KHR errors: as soon as one is
encountered, the normal context loss handling code is triggered, with
the addition that context guilt information is queried from GL. The patch
fixes asserts caused by CONTEXT_LOST_KHR errors in debug mode, which
should help with further development, and hides CONTEXT_LOST_KHR errors
from command buffer clients which are not supposed to see them.

For plumbing, bindings are added for the KHR_robustness API entry points,
and command buffer autogenerated files are updated so that
GLES2Util::GetStringEnum works with CONTEXT_LOST_KHR.

Redundant LoseContext call that was called on the context after
LoseContext was already called on the whole context group is removed from
GLES2CommandDecoderImpl::OnOutOfMemoryError. The behavior that the guilty
context is unknown when an out of memory error is generated is kept, as
it does not make sense to point the finger at a specific context on an
when it is not known which context was actually consuming the most
memory.

BUG=428332

Review URL: https://codereview.chromium.org/689633003

Cr-Commit-Position: refs/heads/master@{#302249}

OnError was meant to support the "onerror" event for Web Notifications,
but it has no call sites. There are a few future use-cases for this event,
but those don't concern non-Web Notifications so we don't need this plumbing.

BUG=428370

Review URL: https://codereview.chromium.org/687183004

Cr-Commit-Position: refs/heads/master@{#302248}

BUG=426020

Review URL: https://codereview.chromium.org/675513002

Cr-Commit-Position: refs/heads/master@{#302247}

It'll likely have more people in the future,
but for now starting small until the API gets more stable.

BUG=422235
R=iannucci@chromium.org

Review URL: https://codereview.chromium.org/686073002

Cr-Commit-Position: refs/heads/master@{#302246}

Currently, PasswordAutofillAgent (in renderer) prepares password autofill suggestions for PasswordAutofillManager (in browser) and sends them via IPC.

But the manager has the data to generate the suggestions itself, so this CL makes it derive the suggestions from that data instead of hauling it through IPC.

This CL also adds one more test case to the PasswordAutofillManager unittest, to compensate for the coverage lost in the PasswordAutofillAgent browsertest by moving some logic out of the agent to the manager.

BUG=400186, 377422, 118601

Review URL: https://codereview.chromium.org/688633004

Cr-Commit-Position: refs/heads/master@{#302245}

They are no longer needed since nearly no extensions code gets built when extensions are disabled.

Review URL: https://codereview.chromium.org/680213003

Cr-Commit-Position: refs/heads/master@{#302244}

Removing 'is_null' from ServiceWorkerVersionInfo in favor of
comparing the version_id to kInvalidServiceWorker.

BUG=428488

Review URL: https://codereview.chromium.org/691413002

Cr-Commit-Position: refs/heads/master@{#302243}

This patch adds the icon to the top bar, so it's the same as in the left nav.

TEST=Tested manually with a FSP based extension.
BUG=None

Review URL: https://codereview.chromium.org/698433002

Cr-Commit-Position: refs/heads/master@{#302242}

BUG=406995
TEST=None

Review URL: https://codereview.chromium.org/691273004

Cr-Commit-Position: refs/heads/master@{#302241}

Previously, I didn't test it carefully...

TEST=Tested manually.
BUG=427776

Review URL: https://codereview.chromium.org/689003002

Cr-Commit-Position: refs/heads/master@{#302240}

Per git log. Numbers of CLs:
    84  kinaba@chromium.org
    50  hirono@chromium.org
    25  mtomasz@chromium.org
    24  yoshiki@chromium.org
    14  hirono
    13  hidehiko@chromium.org
    11  jamescook@chromium.org
    11  satorux@chromium.org
    10  fukino@chromium.org

TEST=Not related.
BUG=None

Review URL: https://codereview.chromium.org/697553002

Cr-Commit-Position: refs/heads/master@{#302239}

The app doesn't have any UI, so it shouldn't show in the launcher. It can't
be an extension because it uses file handlers.

We're going to remove this whitelist once file handlers availability to
extensions is resolved.

TEST=Tested manually that the icon is gone.
BUG=427747

Review URL: https://codereview.chromium.org/688123003

Cr-Commit-Position: refs/heads/master@{#302238}

Cr-Commit-Position: refs/heads/master@{#302237}

This makes generating the accessibility tree for at least one
page more than 25% faster, and it should help at least a bit on
almost any page.

BUG=427402

Review URL: https://codereview.chromium.org/682583002

Cr-Commit-Position: refs/heads/master@{#302236}

This CL associates .xhtm, .xhtml, and .shtml to the browser window.
The list matches what Chrome handles on Windows, enumerated at
src/chrome/installer/util/shell_util.cc#kDefaultFileAssociations.

BUG=427542

Review URL: https://codereview.chromium.org/693103003

Cr-Commit-Position: refs/heads/master@{#302235}

Nobody is using it from chrome/browser anymore.

Review URL: https://codereview.chromium.org/684973003

Cr-Commit-Position: refs/heads/master@{#302234}

0 is not a valid close code, but we're passing through the other invalid
codes. Let's apply the rule also to 0 for consistency.

R=ricea
BUG=428794

Review URL: https://codereview.chromium.org/690753009

Cr-Commit-Position: refs/heads/master@{#302233}

The app will be installed as an external component, as we don't want it to be
uninstalled by users.

TEST=Tested manually that the extension gets downloaded on startup.
BUG=427775

Review URL: https://codereview.chromium.org/686993003

Cr-Commit-Position: refs/heads/master@{#302232}

Related CLs:
http://crrev.com/658013002
http://crrev.com/679383002

BUG=423257
TEST=out/Release/browser_tests --gtest_filter=FileManagerPrivateApiTest.OnFileChanged

Review URL: https://codereview.chromium.org/693123002

Cr-Commit-Position: refs/heads/master@{#302231}

BUG=315436
TEST=out/Release/browser_tests --gtest_filter=FileManagerJsTest.*

Review URL: https://codereview.chromium.org/663513003

Cr-Commit-Position: refs/heads/master@{#302230}

This patch implements the storage::WatcherManager interface, which simply calls
the Add/RemoveWatcher methods on ProvidedFileSystemInterface implementations.

An additional callback has been added to AddWatcher, so it's easy to notify
WatcherManager about changes. Without that, we would have to observe provided
file system objects and store callbacks passed to WatcherManager::AddWatcher,
which would make the code complex.

Along the way the storage::WatcherManager interface has been refactored to have
consistent naming with FSP watching methods.

TEST=unit_tests: *ProvidedFileSystem*
BUG=248427

Review URL: https://codereview.chromium.org/689603002

Cr-Commit-Position: refs/heads/master@{#302229}

Tests for some of the ChromeOS UI elements, including:
- shelf and app launcher
- system tray
- volume/brightness sliders
- notifications
- overlay mode

BUG=None
TEST=this

Review URL: https://codereview.chromium.org/687353004

Cr-Commit-Position: refs/heads/master@{#302228}

BUG=427334

Review URL: https://codereview.chromium.org/689473002

Cr-Commit-Position: refs/heads/master@{#302227}

* Removes an image without [alt] from being spoken
* Adds a label to summary (e.g. Printing: 1 sheet of paper.)
* Removes "Loading preview..." from screen readers (hidden with opacity: 0 only)
* Adds more info to the custom pages input ("e.g. 1-3, 5, 8-11")

R=dmazzoni@chromium.org
BUG=383955

Review URL: https://codereview.chromium.org/697463002

Cr-Commit-Position: refs/heads/master@{#302226}

For such a small change, I don't think we need to run an experiment.

BUG=416148

Review URL: https://codereview.chromium.org/695693002

Cr-Commit-Position: refs/heads/master@{#302225}

This patch makes the icons smaller plus fixes the mask, so they are always
white (except transparent pixels) when selected.

TBR=fukino@chromium.org
TEST=Tested manually with 3 different icons.
BUG=412602

Review URL: https://codereview.chromium.org/693073002

Cr-Commit-Position: refs/heads/master@{#302224}

/** @type {number} */ cr.defineProperty(a, 'c'); doesn't compile because of the warning misplacedTypeAnnotation.
As the warning is from parser, it can not be suppressed by @suppress tag.
So this CL suppress the warning by compile option.

BUG=421562

Review URL: https://codereview.chromium.org/687453007

Cr-Commit-Position: refs/heads/master@{#302223}

Currently when tab manager is shown and user presses back key
then instead of hiding tab manager page is navigated to previous
entry. If there is nothing to navigate then application is exited.
Added code to hide tab manager view if back key is pressed and tab
manager view is on.

BUG=

Review URL: https://codereview.chromium.org/689583002

Cr-Commit-Position: refs/heads/master@{#302222}

When opening an archive with the new ZIP unpacker based on the File System
Provider API, we need to open on once it's mounted in the left nav.

However, in the current design, we can't say if a newly mounted volume is
a result of opening an archive.

As a temporary workaround, this CL makes Files app open all FSP based volumes
once they are mounted, but only in the focused window.

TEST=Tested manually with the new ZIP unpacker.
BUG=427776

Review URL: https://codereview.chromium.org/695713002

Cr-Commit-Position: refs/heads/master@{#302221}

BUG=267281
TEST=None

Review URL: https://codereview.chromium.org/693503002

Cr-Commit-Position: refs/heads/master@{#302220}

We'll soon remove AthenaStartPageView, so AppList independent
components like background should belong to HomeCardView.

This CL also fixes the bug of the visual effect; the spec is
saying that the gradient end should be white even in
the BOTTOM state.

BUG=425717
R=oshima@chromium.org
TEST=manually

Review URL: https://codereview.chromium.org/692643003

Cr-Commit-Position: refs/heads/master@{#302219}