GitLab

Bug: 775189
Change-Id: I29d8288d707157a09a12b695b2fd47e7cc40c6d0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994096
Commit-Queue: Rodney Ding <rodneyding@google.com>
Reviewed-by: Jason Chase <chasej@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732113}

This reverts commit fe842ad4.

Reason for revert: This seems to have introduced a crash in linux-chromeos-dbg. See crbug.com/1042349

Original change's description:
> Update and clarify view ownership for app-list views.
> 
> Bug: 648382
> Change-Id: I0d000accee686dd67b2db1e14cea20ff893835c5
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001399
> Commit-Queue: Allen Bauer <kylixrd@chromium.org>
> Reviewed-by: Alex Newcomer <newcomer@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#732019}

TBR=kylixrd@chromium.org,newcomer@chromium.org

Change-Id: I0eb8c79817cb992ae915de2af4f2a2e669e0bd3e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 648382
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003076Reviewed-by: Roberto Carrillo <robertocn@chromium.org>
Commit-Queue: Roberto Carrillo <robertocn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732112}

Added a label color update method to IconLabelBubbleView that is
called OnThemeChanged() and also when LocationIconView's Update()
method is called.

This is necessary as the LocationIconView may switch the foreground
color to red in the presence of a security context change, not
necessarily only during a theme change event.

Bug: 1042090
Change-Id: Ib0004bd519abfbf3ab27102b6304e9a9f75ec4e3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002855
Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732111}

https://dawn.googlesource.com/dawn.git/+log/2b24c3d92df5..0c66bcd13a54

git log 2b24c3d92df5..0c66bcd13a54 --date=short --first-parent --format='%ad %ae %s'
2020-01-15 enga@chromium.org Reland "Metal: Add CommandRecordingContext"
2020-01-15 rharrison@chromium.org Switch over to using CheckSpvcSuccess where possible
2020-01-15 rharrison@chromium.org Rolling 2 dependencies
2020-01-15 cwallez@chromium.org Add a proper license to webgpu.h's template.
2020-01-15 rharrison@chromium.org Return errors in ExtractSpirvInfo instead of sending to the device
2020-01-15 cwallez@chromium.org Introduce wgpu::Surface and implement it for HWND, X11 and Metal

Created with:
  gclient setdep -r src/third_party/dawn@0c66bcd13a54

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dawn-chromium-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel
Bug: None
Tbr: cwallez@google.com
Change-Id: I31b9439f2b75aa9adb098853aeef4fc74effced6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002838Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#732110}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a8e0880b3003..4175d400f36f


Created with:
  gclient setdep -r src-internal@4175d400f36f

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: chromium:1019796,chromium:1040973
Tbr: jbudorick@google.com
Change-Id: Id114ffb3a0f5137a3c602afa9fed0eb368dd09a7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003111Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#732109}

Bug: 1012776
Change-Id: Ief7d2bb5877b83de53f9c03273b254c42e364310
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995876Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Haiyang Pan <hypan@google.com>
Cr-Commit-Position: refs/heads/master@{#732108}

This CL:
- Makes WebappActivity use TwaFinishHandler
- Moves WebAPK specific logic to TwaFinishHandler
- Moves setting of TwaFinishHandler#setShouldAttemptFinishingTask() to
  SplashController

BUG=1041647

Change-Id: I1ec3964e0a28532a7d338e508cf6f2776f3584de
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1999326Reviewed-by: Glenn Hartmann <hartmanng@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Peter Conn <peconn@chromium.org>
Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732107}

In ExternalBeginFrameSource::AddObserver we send
OnBeginFrameSourcePausedChanged and missed BeginFrame for new observer.
If this observer was first one,
ExternalBeginFrameSourceClient::OnNeedsBeginFrames(true) will be
called, which can change the paused status.

This CL moves call to OnNeedsBeginFrames before adding new observer to
the list to avoid calling OnBeginFrameSourcePausedChanged twice.

Change-Id: I04ddbf489ceb67244600d113c5dd12ec3b743c3e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003288Reviewed-by: kylechar <kylechar@chromium.org>
Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732106}

`gn format` recently changed its formatting behavior
for deps, source, and a few other elements when they
are assigned (with =) single-element lists to be consistent
with the formatting of updates (with +=) with single-element.

Now that we've rolled in a GN binary with the change,
reformat all files so that people don't get presubmit
warnings due to this.

This CL was uploaded by git cl split.

R=flackr@chromium.org

Bug: 1041419
Change-Id: I7ff5060ebb5b369c81513b25dd9da6bb148a6c00
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994076
Auto-Submit: Nico Weber <thakis@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Commit-Queue: Robert Flack <flackr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732105}

Don't use in-app shelf insets in this case because in-app shelf does not
exist in the login screen.

Bug: 1035207
Change-Id: I3cf89db8146d69fc8ed9565c1e131bc14e966777
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001997Reviewed-by: Manu Cornet <manucornet@chromium.org>
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Auto-Submit: Alex Newcomer <newcomer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732104}

Also remove hsuregan@ and jordynass@ who no longer work on these areas.

Change-Id: I22a543609a84bbef67e72059c1e5ab8a85a0587c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002831
Auto-Submit: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: James Hawkins <jhawkins@chromium.org>
Reviewed-by: James Hawkins <jhawkins@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732103}

The primary device identifier in CryptAuth v2 DeviceSync is the Instance ID.
The (soon-to-be) legacy device identifier is the device's encoded public
key, given by RemoteDevice::GetDeviceId(). In v2 DeviceSync, device
public keys come end-to-end encrypted and might not be readily available.
During the migration to v2 DeviceSync, we need to support both identifiers.
Even after v2 DeviceSync is rolled out, we will continue to use the legacy
device identifier in multi-device applications like Smart Lock and Instant
Tethering--the legacy ID is baked heavily into those code bases.
Consequently, the RemoteDevice caches now need to support lookup and
storage by both the Instance ID and the legacy device ID.

In this CL, the RemoteDevice caches key devices by Instance ID and legacy
device ID, RemoteDevice::GetDeviceId(). Concretely, we replace the map
from legacy device ID to shared RemoteDevice pointer with a vector
of shared RemoteDevice pointers. We search this vector for either a
matching Instance ID or legacy device ID. All devices in the cache will
have a unique Instance ID, if one exists, and a unique legacy device ID,
RemoteDevice::GetDeviceId(), if one exists. Every device is guaranteed to
have at least one non-trivial ID. If a device is added with either ID
matching an existing device, the existing device is overwritten.

Here are a few scenarios that require storage/look-up by multiple IDs:
  - A v1 DeviceSync device that does not have an Instance ID.
  - A RemoteDevice cache built in the EasyUnlock sign-in service that does
    not track Instance ID.
  - A v2 DeviceSync device that does not have the legacy device id, i.e.
    public key, decrypted yet.
  - Multi-device applications, e.g. SmartLock, still track devices by the
    legacy device ID, so they might try to look up a v2 DeviceSync device--
    that has an Instance ID--by legacy device ID.

Note: Bypassing presubmit shared_ptr errors. We are working with existing
shared_ptrs. The migration from shared_ptr to scoped_refptr is complex, and
it is being tracked at https://crbug.com/960538.

No-Presubmit: true
Bug: 951969
Change-Id: I511c1a314bb98e8129516f38dd7a3f156fddbd09
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971652
Commit-Queue: Josh Nohle <nohle@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732102}

Previously ui::MODAL_TYPE_WINDOW type modal child window controls its
own visibility, thus when its modal parent window becomes visible, it
can still be invisible. This CL makes the modal parent window controls
its modal child window's visibility if its modal type is
ui::MODAL_TYPE_WINDOW.

Bug: 1036067
Change-Id: Icfeb612beec0d76419e9b0606986c8bc5791e12d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995463Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732101}

AcceleratedStaticBitmapImages created by WebGL rely on creating a
GL texture backing for a shared image to ensure the shared image
outlives the StaticBitmapImage. This in turn assumes that even if the
client explicitly destroys a shared image mailbox via
SharedImageInterface, they can continue to use this mailbox as long as
an associated representation is alive. This pattern is not something we
want to support.

This pattern also means that when a mailbox is stored on
SharedImageInterface, we can not safely assume that the metadata
associated with it can be cached correctly.

This change fixes this by transitioning WebGL to use the same factory
method for creating StaticBitmapImages as used by canvas2d. This in
turn also does the following:

1) Ensures that the correct texture target is plumbed through with the
   StaticBitmapImage.
2) Eliminates the needs to plumb an image and a release callback through
   a bunch of code. Since the image now owns the release callback.
3) Cleans up code in MailboxTextureHolder used to keep the mailbox's
   texture backing alive.
4) TransferToImageBitmap currently works by marking the resource as
   lost, which means it can not be recycled. These redundant
   reallocations are avoided with this change.

R=kbr@chromium.org

Bug: 1036142
Change-Id: I8824aa8d03a48e35e39744cc30c9d0313dcbed08
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1996124Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Klaus Weidner <klausw@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Khushal <khushalsagar@chromium.org>
Auto-Submit: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732100}

- Introduces the dialog for adding a print server in printer settings
- This is initially hidden behind the flag: enable-print-server-ui
- Added browser tests for this dialog.

Screen shots of the new UI:
Switch to print server dialog:
https://screenshot.googleplex.com/xYyeAukxOgu

Add print server dialog:
https://screenshot.googleplex.com/e7EQCrHGxan

Sample dialog error:
https://screenshot.googleplex.com/GnV6Fd4Jyk1

Bug:1015628
Test: browser tests

Change-Id: I419f8c8f159af75fc3a9b2cd5c2c6ed2dcf8288f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954669Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Bailey Berro <baileyberro@chromium.org>
Commit-Queue: jimmy gong <jimmyxgong@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732099}

https://swiftshader.googlesource.com/SwiftShader.git/+log/63468081e52e..5349f3c9d904

git log 63468081e52e..5349f3c9d904 --date=short --first-parent --format='%ad %ae %s'
2020-01-15 bclayton@google.com Vulkan: Disable SPIR-V preprocessing when debugging
2020-01-15 capn@google.com Produce less debug info in Kokoro builds

Created with:
  gclient setdep -r src/third_party/swiftshader@5349f3c9d904

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-chromium-autoroll
Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: swiftshader-team+autoroll@google.com
Change-Id: I76adbb330f4fd0145392e3419d581ab359eba570
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002985Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#732098}

There is a race when we wait on the response from FCM to give us the
message id of the sent message. If we for some reason get the ACK for
that message before the response from FCM, we discard the ACK and
timeout.

Bug: None
Change-Id: I35a1965aa5e1034af1b046099a60656ea61b59cf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001302
Commit-Queue: Richard Knoll <knollr@chromium.org>
Reviewed-by: Alex Chau <alexchau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732097}

This adds callbacks that notifies the client:
* when a new datagram can be read,
* when a new stream can be opened.

Bug: 1040236
Change-Id: I731bbc18951eb28dc8dd594db6a98036172a2e22
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001195Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Commit-Queue: Victor Vasiliev <vasilvv@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732096}

This reverts commit c02f2451.

Reason for revert: System apps are not required for managed users.

Original change's description:
> arc: Add concept of system default apps.
> 
> These apps exist on system image and available for all users. This also
> moves custom Play Store case handled separately before to system app.
> 
> TEST=unit test
> BUG=1013730
> 
> Change-Id: Iaf63d52c38c376b6b07930bc8ec88e5b9de4bb58
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865472
> Reviewed-by: Josh Horwich <jhorwich@chromium.org>
> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
> Commit-Queue: Yury Khmel <khmel@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#706920}

TBR=xiyuan@chromium.org,jhorwich@chromium.org,khmel@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1013730
Change-Id: I106b0bee9f55b655d467094e0a55f7d50679de7b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002720Reviewed-by: Yury Khmel <khmel@chromium.org>
Auto-Submit: Yury Khmel <khmel@chromium.org>
Commit-Queue: Yury Khmel <khmel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732095}

Bug: 994944
Test: CQ
Change-Id: Ib8bc6a552258c35c93699f5eb196bfbe7df9f252
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001069
Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732094}

The [1] CL enabled the FormControlsRefresh feature by default for
Windows, Linux, and ChromeOS. In the process, many layout tests were
disabled, because the form controls have a different appearance with
the feature enabled. This is one of several patches rebaselining those
disabled tests.

This CL removes a number of tests from /fast/forms related to pop-up
picker behavior. These tests are old, and assume *many* details of
the internal shadow implementation of the pickers, which are no longer
true with the FormControlsRefresh pickers. Those controls are also
better-tested with the new suite of tests at [2]. See crbug.com/1034611.
To maintain test coverage of the *old* form control popups, these old
tests will be moved into the virtual/form-controls-refresh-disabled
virtual test suite.

[1] http://crrev.com/c/1967608
[2] https://source.chromium.org/chromium/chromium/src/+/master:third_party/blink/web_tests/virtual/controls-refresh/

Bug: 1035582, 1034611
Change-Id: I35238a1923cd2a2a2612ee469957f8c6bd70b5b9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1997846
Commit-Queue: Mason Freed <masonfreed@chromium.org>
Reviewed-by: Dan Clark <daniec@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#732093}

It is invalid to have a visible browser window with no active WebContents,
but https://crbug.com/1032348 shows that it happens. This is a fix that
can be merged to M80 to avoid getting crashes on stable.

Instrumentation to better understand the problem is added in
https://chromium-review.googlesource.com/c/chromium/src/+/2001220

Bug: 1032348
Change-Id: Ia20a35fff65532d8f11110a097b94b72fbcf3dd6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001139
Commit-Queue: François Doray <fdoray@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Auto-Submit: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732092}

The Histogram macros output ms instead of sec.

Bug: 1014959
Change-Id: Ib182ae7762b0597fc6f1335b2254d3b3b9f88ae4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003209Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732091}

`gn format` recently changed its formatting behavior
for deps, source, and a few other elements when they
are assigned (with =) single-element lists to be consistent
with the formatting of updates (with +=) with single-element.

Now that we've rolled in a GN binary with the change,
reformat all files so that people don't get presubmit
warnings due to this.

This CL was uploaded by git cl split.

R=johnchen@chromium.org

Bug: 1041419
Change-Id: Id338c2ce6f613d444df42aaaa48f538cb91d8cf1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998626
Auto-Submit: Nico Weber <thakis@chromium.org>
Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732090}

Plumb a reason of why a call is made to
RemoveRow in the compromised_credentials_table
class so that when logging metrics, the reason is
known.

Bug: 1039870
Change-Id: Iba7de4a81450805927922fa905fe987cb58815b5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1990219
Commit-Queue: Bettina Dea <bdea@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732089}

This change hides the ChromeVox panel menu search feature behind a
flag so it can be tested before releasing to the public.

Bug: 684762
Change-Id: Idbe32523888403892f478b91ca0ec366fb128150
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001388Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Akihiro Ota <akihiroota@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732088}

Exposed COOKIE_CONTROLS_MODE and the corresponding kCookieControlsMode
enum in order to add a way to set the preference from Java.

Bug: 998063
Change-Id: I8526b7e0841ffa783845e1c08a44f54de5c72b69
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000761Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Commit-Queue: Ehimare Okoyomon <eokoyomon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732087}

Reland "Reland "Remove DOMDataStore::WrappedReference and hold TraceWrapperV8Reference directly in ephemeron map.""

This reverts commit 85a5bc56.

Reason for revert: https://chromium.googlesource.com/chromium/src.git/+/30dc3c578d7137c4a3935f272e884717a523905c should have fixed this?

Original change's description:
> Revert "Reland "Remove DOMDataStore::WrappedReference and hold TraceWrapperV8Reference directly in ephemeron map.""
> 
> This reverts commit 21cf7ca9.
> 
> Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=1019839#c39
> 
> Original change's description:
> > Reland "Remove DOMDataStore::WrappedReference and hold TraceWrapperV8Reference directly in ephemeron map."
> > 
> > This reverts commit bdc5aa8e.
> > 
> > Reason for revert: Crasher has been stealth-fixed, see https://crbug.com/1021171.
> > 
> > Original change's description:
> > > Revert "Remove DOMDataStore::WrappedReference and hold TraceWrapperV8Reference directly in ephemeron map."
> > > 
> > > This reverts commit 481fb0c1.
> > > 
> > > Reason for revert: speculative revert for crbug.com/1019839
> > > 
> > > Original change's description:
> > > > Remove DOMDataStore::WrappedReference and hold TraceWrapperV8Reference directly in ephemeron map.
> > > > 
> > > > Change-Id: I6ef8b0098a795dc550037306e7b972ea907b0fc1
> > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884285
> > > > Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
> > > > Reviewed-by: Kentaro Hara <haraken@chromium.org>
> > > > Commit-Queue: Jeremy Roman <jbroman@chromium.org>
> > > > Cr-Commit-Position: refs/heads/master@{#710616}
> > > 
> > > TBR=jbroman@chromium.org,haraken@chromium.org,mlippautz@chromium.org
> > > 
> > > # Not skipping CQ checks because original CL landed > 1 day ago.
> > > 
> > > Change-Id: Iba339b519f2aa602773ceb79c95948c1cffdcbdb
> > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893282
> > > Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
> > > Reviewed-by: Kentaro Hara <haraken@chromium.org>
> > > Commit-Queue: Ulan Degenbaev <ulan@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#711289}
> > 
> > TBR=ulan@chromium.org,jbroman@chromium.org,haraken@chromium.org,mlippautz@chromium.org
> > 
> > # Not skipping CQ checks because original CL landed > 1 day ago.
> > 
> > Change-Id: Iae455af51181d191f08e7af16cd8a1413aea2b37
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899783
> > Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
> > Reviewed-by: Jeremy Roman <jbroman@chromium.org>
> > Reviewed-by: Kentaro Hara <haraken@chromium.org>
> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
> > Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#712945}
> 
> TBR=ulan@chromium.org,jbroman@chromium.org,haraken@chromium.org,mlippautz@chromium.org
> 
> # Not skipping CQ checks because original CL landed > 1 day ago.
> 
> Change-Id: Ibac7d4ca203761eb2d472cd40364529976e688bf
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903608
> Reviewed-by: Jeremy Roman <jbroman@chromium.org>
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Commit-Queue: Jeremy Roman <jbroman@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#713472}

TBR=ulan@chromium.org,jbroman@chromium.org,haraken@chromium.org,mlippautz@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: Ibc57b71bfb86badd74c60610ff9adfb5e48a7be1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002968Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732086}

BUG=b:119914122
TEST=compile

Change-Id: I1aa22d6e468e86abb3dc8947ad4ddf6baca52d15
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002393Reviewed-by: Greg Kerr <kerrnel@chromium.org>
Commit-Queue: Polina Bondarenko <pbond@chromium.org>
Auto-Submit: Polina Bondarenko <pbond@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732085}

`gn format` recently changed its formatting behavior
for deps, source, and a few other elements when they
are assigned (with =) single-element lists to be consistent
with the formatting of updates (with +=) with single-element.

Now that we've rolled in a GN binary with the change,
reformat all files so that people don't get presubmit
warnings due to this.

This CL was uploaded by git cl split.

R=tsepez@chromium.org

Bug: 1041419
Change-Id: I0b313bdca77daa75e41535abfe706c7e6652aaa3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995853
Auto-Submit: Nico Weber <thakis@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732084}

Bug: 1040281
Change-Id: Ice6a078937ac8fce6589886742f778b7fde38f26
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994668
Commit-Queue: Peter Williamson <petewil@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Dan H <harringtond@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732083}

On Q+, PathUtils.getDownloadsDirectory use
Context.getExternalFilesDirs to retrieve the directory for offline page
api. This function may return null if Android doesn't mount any storage
volumes yet.

If this happens, simply return empty string here.

Bug: 1040260
Change-Id: I41bfb6f7581dd625e02a9e35f50ba258d967dbf0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993741Reviewed-by: Min Qin <qinmin@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Commit-Queue: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732082}

This fixes a window.__wptrunner_process_next_event crash while running WebLayer WPT.

Bug: 1019521
Change-Id: I26e53d0fa328fefd611ab531a5d166e59b25fd17
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001245Reviewed-by: Ben Pastene <bpastene@chromium.org>
Commit-Queue: Andrew Luo <aluo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732081}

We will enable these tests once the status indicator is enabled for
tablets.

Bug: 1042095, 1035584
Change-Id: I6e008e3a058fd6ffd4fade06a32621a49334bb1a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001268Reviewed-by: Theresa  <twellington@chromium.org>
Commit-Queue: Theresa  <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732080}

These rules should be integrated into //.eslintrc.js when
more of the codebase uses ===/!==.

R=dpapad@chromium.org
BUG=720034

Change-Id: I2b84fa8e952472d62a4f1241a6224dd17e78d6fa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001717
Commit-Queue: Dan Beam <dbeam@chromium.org>
Auto-Submit: Dan Beam <dbeam@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732079}

During v2 DeviceSync, if device metadata cannot be decrypted due to an
error or because the group private key was not returned by CryptAuth,
the device is still added to the registry without the new decrypted
metadata. Currently, old device metadata is cleared in the registry
until the new metadata can be decrypted.

In this CL, we ensure that any existing decrypted metadata from the
device registry will remain there until the new metadata can be
decrypted. Because we do not expect that metadata--namely the device
public key and beacon seeds--to change often or urgently, we preserve
existing decrypted data for the sake of continuity. (Note: the device
public key currently *never* rotates and the beacon seeds are valid
for roughly 6 weeks.)

As an example, consider a verified BetterTogether host phone using
Instant Tethering. If a DeviceSync call from the Chromebook rotates
the group key, all other devices, including the host phone, will need to
upload newly encrypted metadata that the Chromebook can decrypt. During
this interim period, we can most likely continue using the host phone's
old metadata to keep the tethering connection. In the previous
implementation, the Chromebook would wipe the phone's old metadata,
making the host "unverified" until the metadata can be decrypted. This
could cause a hiccup in service during every group key rotation. Now,
the device registry should have empty BetterTogether metadata only while
waiting for the *first* metadata decryption.

Bug: 951969
Change-Id: If9b93c0157d509e5cea2367eef0b58af69e04a19
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993745
Commit-Queue: Josh Nohle <nohle@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Auto-Submit: Josh Nohle <nohle@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732078}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/cb92763d..cd341453

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I3ab2f6f7af9a4aa4327a580daa44a071f75b4286
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002753Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#732077}

Signed Exchanges do not have a SSL connection version set. Exclude
such cases from the legacy TLS warning treatment to avoid spurious
warnings.

Bug: 1041773
Change-Id: I323e3c1206da32b629c82b4eb28fc0a67190e7cc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002830
Commit-Queue: Emily Stark <estark@chromium.org>
Reviewed-by: David Benjamin <davidben@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732076}

Change-Id: I2fe2b5f048edfb7d766ecfe3ad2f5801ef23496d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991620
Commit-Queue: Robbie Gibson <rkgibson@google.com>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732075}

This CL removes unnecessary deps/includes and tightens DEPS rules. Ash
and exo should no longer depend on //components/service/viz outside of
tests.

Bug: 936425
Change-Id: I5536a187fb3ef06145e96aafcaf403923873c996
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002749Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732074}