- 13 Aug, 2018 40 commits
-
-
Sam Zackrisson authored
- Adds a second (currently no-op) toggling of AEC2 and AECM, to allow for upstream changes in WebRTC (removing the EchoControlMobile API). - Localizes the creation of a webrtc::AudioProcessing::Config to avoid overwriting settings. Shortly, this will be the only way to toggle AECs in APM. Bug: webrtc:9535 Change-Id: I019408ec7e5b5e91afddfe854d607126ee065fdb Reviewed-on: https://chromium-review.googlesource.com/1152914Reviewed-by:
Oskar Sundbom <ossu@chromium.org> Reviewed-by:
Per Kjellander <perkj@chromium.org> Commit-Queue: Sam Zackrisson <saza@chromium.org> Cr-Commit-Position: refs/heads/master@{#582577}
-
Fredrik Söderquist authored
external/wpt/svg/text/reftests/text-multiline-001.svg external/wpt/svg/text/reftests/text-multiline-002.svg external/wpt/svg/text/reftests/text-multiline-003.svg => crbug.com/366558 external/wpt/svg/text/reftests/text-inline-size-001.svg external/wpt/svg/text/reftests/text-inline-size-002.svg external/wpt/svg/text/reftests/text-inline-size-003.svg external/wpt/svg/text/reftests/text-inline-size-005.svg external/wpt/svg/text/reftests/text-inline-size-006.svg external/wpt/svg/text/reftests/text-inline-size-007.svg external/wpt/svg/text/reftests/text-inline-size-101.svg external/wpt/svg/text/reftests/text-inline-size-201.svg => crbug.com/366553 external/wpt/svg/painting/reftests/markers-orient-001.svg => crbug.com/872697 (pending testfix) TBR=schenney@chromium.org BUG=366553,366558,872697 Change-Id: Ib75f5c0cda767108745618ab508a6a8730e3b1b1 Reviewed-on: https://chromium-review.googlesource.com/1172430Reviewed-by:
Fredrik Söderquist <fs@opera.com> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#582576}
-
Javier Ernesto Flores Robles authored
Test is failing on non tablet iOS 10 devices and it is flaky on all iOS 11 ones. Bug: 873633,873632 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ie95325a3256021a401c3f8055d5e71f6dc40a590 Reviewed-on: https://chromium-review.googlesource.com/1172358Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#582575}
-
Mugdha Lakhani authored
This will be required to implement match() and matchAll() on BackgroundFetchRegistration in a follow-up CL. Bug: 869918 Change-Id: I9ed88076488a035f313b9d16e0f41b3c168a0a09 Reviewed-on: https://chromium-review.googlesource.com/1169465Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#582574}
-
Ramin Halavati authored
Preferences related to unified consent are removed from the persistent storage list for incognito mode. After this CL, if these preferences are changed from incognito mode, they are only stored in memory and won't affect user profile. Bug: 861722 Change-Id: I733657f359b34369fcef0559660cd14c74bfb181 Reviewed-on: https://chromium-review.googlesource.com/1172131Reviewed-by:
Thomas Tangl <tangltom@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#582573}
-
Michael Lippautz authored
- Move temporary visitor scope to test infrastructure - Factor out integration tests that are independent from visitors Bug: chromium:843903 Change-Id: I3850cc48fe1b9186691722f3241e9de27cd0a29e Reviewed-on: https://chromium-review.googlesource.com/1172294 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#582572}
-
Ian Clelland authored
This just implements the infrastructure required for generating and sending reports with the Reporting API, and making them visible to ReportingObservers. Adding violation reporting to individual features will be handled in follow-up CLs. Bug: 867471 Change-Id: Iabfaebe00ae5a768d1b952a90aac1712aec5e158 Reviewed-on: https://chromium-review.googlesource.com/924475Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium ecdeaeda. With Chromium commits locally applied on WPT: 7dad0f17 "Added new Sec-Metadata Web Platform Tests." Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/22691 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: alexander.shalamov@intel.com, kenneth.r.christiansen@intel.com, rijubrata.bhaumik@intel.com: external/wpt/web-nfc alexander.shalamov@intel.com, rijubrata.bhaumik@intel.com, timvolodine@chromium.org: external/wpt/generic-sensor bajones@chromium.org: external/wpt/gamepad chongz@chromium.org: external/wpt/pointerlock external/wpt/touch-events dcheng@chromium.org, scottmg@chromium.org: external/wpt/domparsing eroman@chromium.org, rsleevi@chromium.org: external/wpt/WebCryptoAPI garykac@chromium.org: external/wpt/keyboard-map garykac@chromium.org, joedow@chromium.org: external/wpt/keyboard-lock hongchan@chromium.org, rtoy@chromium.org: external/wpt/webaudio igrigorik@chromium.org, panicker@chromium.org: external/wpt/performance-timeline jsbell@chromium.org: external/wpt/IndexedDB external/wpt/resources jsbell@chromium.org, mek@chromium.org: external/wpt/FileAPI external/wpt/webstorage kojii@chromium.org, ksakamoto@chromium.org: external/wpt/css/css-font-loading kpaulhamus@chromium.org: external/wpt/webauthn ksakamoto@chromium.org: external/wpt/resource-timing mcasas@chromium.org: external/wpt/mediacapture-record mkwst@chromium.org, andypaicu@chromium.org: external/wpt/content-security-policy mkwst@chromium.org, jochen@chromium.org: external/wpt/subresource-integrity mlamouri@chromium.org: external/wpt/mediasession external/wpt/remote-playback external/wpt/screen-orientation nzolghadr@chromium.org, mustaq@chromium.org: external/wpt/pointerevents ortuno@chromium.org: external/wpt/bluetooth panicker@chromium.org: external/wpt/page-visibility external/wpt/user-timing panicker@chromium.org, tdresser@chromium.org: external/wpt/paint-timing pwnall@chromium.org, jsbell@chromium.org: external/wpt/cookie-store rijubrata.bhaumik@intel.com, mcasas@chromium.org: external/wpt/html-media-capture rouslan@chromium.org, mathp@chromium.org: external/wpt/payment-method-basic-card external/wpt/payment-request tdresser@chromium.org: external/wpt/navigation-timing timvolodine@chromium.org: external/wpt/battery-status yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org: external/wpt/fetch NOAUTOREVERT=true TBR=lukebjerring No-Export: true Change-Id: I70a939515749e77646e0c697dfa888bedbe1a202 Reviewed-on: https://chromium-review.googlesource.com/1172209 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#582570}
-
Anders Hartvoll Ruud authored
When retrieving values via attributeStyleMap.get/getAll, produce the correct CSSStyleValue subclass according to the registration of the custom property. R=futhark@chromium.org Bug: 641877 Change-Id: If564fb039506a22162ad2521479fcb1c3de9336c Reviewed-on: https://chromium-review.googlesource.com/1172291Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Anders Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#582569}
-
perfetto-chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/c500e36711d5..a745cdf1c11f git log c500e36711d5..a745cdf1c11f --date=short --no-merges --format='%ad %ae %s' 2018-08-13 lalitm@google.com perfetto: fix string view unittest for Chromium autoroller 2018-08-12 primiano@google.com UI: Initial clean up and improvements 2018-08-10 dproy@google.com Fix hover for chrome slices 2018-08-10 primiano@google.com Add StringView class and switch trace processor to use it Created with: gclient setdep -r src/third_party/perfetto@a745cdf1c11f The AutoRoll server is located here: https://perfetto-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I8dd67c02eca58c773700485b29a7008a1a3a7bba Reviewed-on: https://chromium-review.googlesource.com/1172382Reviewed-by:
perfetto-chromium-autoroll <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: perfetto-chromium-autoroll <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#582568}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/553b6f68e1dc..af1759587922 git log 553b6f68e1dc..af1759587922 --date=short --no-merges --format='%ad %ae %s' 2018-08-13 nisse@webrtc.org Refactor RtpReceiverImpl, extracting CSRC book-keeping to its own class 2018-08-13 asapersson@webrtc.org Add initial support for RtpEncodingParameters max_framerate. Created with: gclient setdep -r src/third_party/webrtc@af1759587922 The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I0984c59dd627c52ccad8d87f269a64b07e9cde59 Reviewed-on: https://chromium-review.googlesource.com/1172383Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#582567}
-
Elad Alon authored
Bug: None Change-Id: Ied9165ff9f0cfb3cc411150ba50b09f2bf67cc04 Reviewed-on: https://chromium-review.googlesource.com/1144937 Commit-Queue: Elad Alon <eladalon@chromium.org> Reviewed-by:
Henrik Grunell <grunell@chromium.org> Cr-Commit-Position: refs/heads/master@{#582566}
-
Fredrik Söderquist authored
TBR=schenney@chromium.org BUG=863355 Change-Id: Ib58518bb68af39fb5e106cb0da0f08df5e6a832a Reviewed-on: https://chromium-review.googlesource.com/1172361Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#582565}
-
Maks Orlovich authored
Add an adapter for making migrating standalone executables that need both legacy and NetworkService APIs easier This lets one easily create a SharedURLLoaderFactory wrapping an existing URLRequestContextGetter. It should be used for standalone executables only --- things within the Browser should request the SharedURLLoaderFactory from Profile/StoragePartition/SystemNetworkContextManager as appropriate. Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I1a66d2bcad6307ee87014dc2d3134e673da5d16c Reviewed-on: https://chromium-review.googlesource.com/1150661 Commit-Queue: Maks Orlovich <morlovich@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#582564}
-
Thomas Tangl authored
The UnifiedConsentService needs a SyncService that is not NULL, otherwise it will crash. To fix this, the UnifiedConsentServiceFactory only creates a UnifiedConsentService if the SyncService is not NULL. Bug: 872451 Change-Id: I3f7c196273ce5cade9b2f1c88c410eae13569bf7 Reviewed-on: https://chromium-review.googlesource.com/1172301 Commit-Queue: Thomas Tangl <tangltom@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#582563}
-
Peter Wen authored
These folks have left Chrome or Google. Removing them to make it clear that these directories need more OWNERS (dgn@, aberent@, shenghuazhang@, sgurun@). Add mlamouri@ to replace removed //third_party/android_media OWNERS. Bug: None Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I4cf85a5dace5bdd4929d12617e5e12f11a58ca11 Reviewed-on: https://chromium-review.googlesource.com/1160771Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
David Turner <digit@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#582562}
-
Yuta Kitamura authored
It's possible to reach here even if Scheduler() just returns nullptr. Bug: 873207 Change-Id: I6664ccaa75fbcb31e4f9e75099d85404f8db8059 Reviewed-on: https://chromium-review.googlesource.com/1172178Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Yuta Kitamura <yutak@chromium.org> Cr-Commit-Position: refs/heads/master@{#582561}
-
Balazs Engedy authored
Bug: 849323 Change-Id: Ia5ed52ee21c634a018c8652f7dc3380673852956 Reviewed-on: https://chromium-review.googlesource.com/1169212Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#582560}
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/90f466a6cfab..35bc74d6d139 git log 90f466a6cfab..35bc74d6d139 --date=short --no-merges --format='%ad %ae %s' 2018-08-13 jiawei.shao@intel.com ES31: Support atomic functions on D3D11 - Part II Created with: gclient setdep -r src/third_party/angle@35bc74d6d139 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: Ie8c92f0d6a30925e284276d25418b9ae83880193 Reviewed-on: https://chromium-review.googlesource.com/1172244Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#582559}
-
Mohamed Amir Yosef authored
Since the BookmarkSyncServiceFactory doesn't start the BookmarkUndoService, it should use it only if it exists. This was the case already in non-ios factory. https://cs.chromium.org/chromium/src/chrome/browser/sync/bookmark_sync_service_factory.cc?l=38&rcl=46520ae13478333fe882e79041b667e5a3112796 However, by mistake, it was created in iOS factory which caused tests to fail here: https://chromium-review.googlesource.com/c/chromium/src/+/1052767 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I5f205fa575773b3382b1e4c90ac4afa19d41d77a Reviewed-on: https://chromium-review.googlesource.com/1171231Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#582558}
-
Anders Hartvoll Ruud authored
R=futhark@chromium.org Bug: 641877 Change-Id: Ia249aedc2abe7f249c28ab57732edfaf6c552f2e Reviewed-on: https://chromium-review.googlesource.com/1172295Reviewed-by:
-
Mathieu Perreault authored
Receives the data from sync and puts it in the AutofillTable. Wires the getter/setters all the way to PersonalDataManager. Bug: 870936 Test: components_unittests Change-Id: Ic6f262e63e529f42d8f7225042f0a007273e7ab7 Reviewed-on: https://chromium-review.googlesource.com/1170847Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#582556}
-
Jan Wilken Dörrie authored
This change restricts the usage of WriteWithoutResponse to macOS. On macOS this is required for performance reasons, but on other platforms this can lead to misbehavior. This results in requests not being handled correctly. Bug: 763303 Change-Id: I5b609fd70eafdf4b9abad680218a9e04ac302703 Reviewed-on: https://chromium-review.googlesource.com/1167515 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
-
Fergal Daly authored
The parser currently yields every 500ms unless it encounters a script tag. We will experiment with different values and observe the impact. https://goo.gl/zwQWyW Change-Id: I1dcec74fb41e438393e505323707c00d76b49d15 Reviewed-on: https://chromium-review.googlesource.com/1148172 Commit-Queue: Fergal Daly <fergal@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#582554}
-
Vasilii Sukhanov authored
Bug: 869343 Change-Id: Ic3506c14a51fca41a8c5ee84587d5947976178df Reviewed-on: https://chromium-review.googlesource.com/1172343 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#582553}
-
Yi Su authored
Add a helper function that returns text for tabs count: (-inf, 0] => "" (0, 100) => "num" [100, +inf) => ":)" Bug: 835801 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ica4607b10dbd1f241d4e5a07c32128a1f4607db8 Reviewed-on: https://chromium-review.googlesource.com/1172297Reviewed-by:
-
Morten Stenshorne authored
TBR=kojii@chromium.org Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I93fc321f19c2721b1bcaaee706a22969154b3911 Reviewed-on: https://chromium-review.googlesource.com/1172349 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#582551}
-
Maja Kabus authored
HTML*Element href and src test files merged into two HTMLElement-generic test files. Bug: 739170 Change-Id: I3cf49c9d72540c7f51439fb157f1d201048a349e Reviewed-on: https://chromium-review.googlesource.com/1146567 Commit-Queue: Mike West <mkwst@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#582550}
-
Juan Antonio Navarro Perez authored
Test started failing on: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Marshmallow%2064%20bit%20Tester/23204 TBR=haraken@chromium.org Bug: 873580 Change-Id: If9c53d9e0e959dd7a390434c41d3a33d40f01c65 Reviewed-on: https://chromium-review.googlesource.com/1172345Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#582549}
-
Ben Wagner authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/578bcf103a12..96b5e500909c $ git log 578bcf103..96b5e5009 --date=short --no-merges --format='%ad %ae %s' 2018-08-10 bungeman * src/sfnt/sfobjs.c (sfnt_done_face): Fix memory leak (#54435). 2018-08-10 ramakrishnan.nikhil Minor formatting. 2018-08-10 wl * src/base/ftobjs.c (FT_Render_Glyph_Internal): Improve tracing. 2018-08-10 wl Fix clang warnings. 2018-08-09 apodtele [raster, smooth] Reinstate bitmap size limits. 2018-08-08 apodtele [pcf] Revert massive unsigning. 2018-08-08 wl [smooth] Improve tracing. 2018-08-08 wl Add internal functions `FT_Trace_Disable' and `FT_Trace_Enable'. 2018-08-08 wl Debugging improvements. 2018-08-08 apodtele [pcf] Massive unsigning (part 2). 2018-08-08 apodtele [pcf] Massive unsigning (part 1). 2018-08-07 apodtele * src/pcf/pcfread.c (pcf_get_bitmaps): Unsign `offsets' and `bitmapSizes'. 2018-08-06 wl More comment formattings. 2018-08-06 wl * devel/ftoption.h: Synchronize with main `ftoption.h'. 2018-08-06 apodtele [pcf] Use unsigned types. 2018-08-06 wl Minor comment formatting. 2018-08-05 wl * src/truetype/ttgload.c (compute_glyph_metrics): Fix overflow. 2018-08-04 wl Ditto. 2018-08-04 wl * src/truetype/ttinterp.c (opcode_name): Fix typos. 2018-08-04 wl Fix clang warnings. 2018-07-31 wl * src/cid/cidtoken.h: Handle `XUID' keyword. 2018-07-31 wl [cid] Trace PostScript dictionaries. 2018-07-31 wl Minor documentation improvement. Created with: roll-dep src/third_party/freetype/src R=bungeman@chromium.org,drott@chromium.org CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_msan_rel_ng Bug: chromium:777151,pdfium:1131 Change-Id: Ib958a34663b7c1fa9dbdf63b54ac51cc21d14eea PDFium-Issue: pdfium:1133 Reviewed-on: https://chromium-review.googlesource.com/1171575 Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#582548}
-
Elad Alon authored
This is a reland of 94a8710d This is the second reland of the original CL (elaboration of initial fix approach follows below). The first fix did not work on the trybots (though it did locally); stopping all threads except the tests' main thread caused problems in other modules. This second CL takes a different approach, and uses a base::WeakPtr instead of base::Unretained(this) for tasks posted to the remote-bound manager. TBR=avi@chromium.org,pastarmovj@chromium.org Original change's description: > Reland "Support dynamic refresh of WebRtcEventLogCollectionAllowed policy" > > This is a reland of 7dae0f63 > > The original CL caused flakiness because, in production code, > WebRtcEventLogManager is torn down during Chrome shutdown, after > all threads other the the UI thread have quit. For unit tests, this > was not the case, and so the tests hit some use-after-destruction. > This was fixed by making the tests stop the non-UI threads before > tearing down WebRtcEventLogManager. > > Original change's description: > > Support dynamic refresh of WebRtcEventLogCollectionAllowed policy > > > > Add suport for dynamic refresh of WebRtcEventLogCollectionAllowed: > > 1. If the policy was disabled before, and becomes enabled, > > subsequent calls to StartRemoteLogging() will succeed (barring > > unrelated issues), even for peer connections created while the > > policy was disabled. > > 2. If the policy was enabled before, and becomes disabled: > > a. Peer connections associated with the profile reject > > calls to StartRemoteLogging(). > > b. Active logs (associated with the profile) are stopped, > > and those log files deleted. > > c. Pending log files (associated with the profile) are deleted. > > d. If a log file associated with the relevant profile is > > currently being uploaded, the upload will be cancelled, > > and the file deleted. > > > > Bug: 775415 > > Change-Id: I70a02ff04eded2926e56fa8e368715ec1ff7c34f > > Reviewed-on: https://chromium-review.googlesource.com/1162168 > > Reviewed-by: Guido Urdaneta <guidou@chromium.org> > > Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org> > > Reviewed-by: Avi Drissman <avi@chromium.org> > > Commit-Queue: Elad Alon <eladalon@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#581167} > > TBR=guidou@chromium.org > > Bug: 775415 > Change-Id: Ie6070a8843012580c9a6c069f65c01b8d63525ff > Reviewed-on: https://chromium-review.googlesource.com/1168962 > Commit-Queue: Elad Alon <eladalon@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org> > Cr-Commit-Position: refs/heads/master@{#582162} Bug: 775415 Change-Id: Ib174ee3eb9d2a7bc1c5a329e497d8b6d1de02e35 Reviewed-on: https://chromium-review.googlesource.com/1171682 Commit-Queue: Elad Alon <eladalon@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#582547}
-
Vasilii Sukhanov authored
TBR=pkotwicz@chromium.org Bug: 872847 Change-Id: Iae5cb8c652618511101b6516c918ee723712fe64 Reviewed-on: https://chromium-review.googlesource.com/1169803 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#582546}
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/7ae70d8fb360..90f466a6cfab git log 7ae70d8fb360..90f466a6cfab --date=short --no-merges --format='%ad %ae %s' 2018-08-13 jie.a.chen@intel.com Suppress cast warnings for active textures mask 2018-08-13 oetuaho@nvidia.com Clean up varying linkage in D3D Created with: gclient setdep -r src/third_party/angle@90f466a6cfab The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: I9c0f5acc04cbb6cea18a1010e836c3738d16a8db Reviewed-on: https://chromium-review.googlesource.com/1172243Reviewed-by:
-
Boris Sazonov authored
This CL disables Back button on the main consent bump screen. If SigninActivity is not in consent bump mode or there are entries in fragment manager back stack, Back button works as usual. Bug: 869426 Change-Id: Iec128e6cd01b9354f9da587da131a27776599c3d Reviewed-on: https://chromium-review.googlesource.com/1169605Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#582544}
-
Arthur Sonzogni authored
Currently, when a navigation is blocked by X-Frame-Options, the frame loads a blank page with an unique origin via the "data:," URL. Committing the real error page was not possible at that time. Mainly because of the interaction with the ChromeWebStore. See bug 622385. This CL removes the code preventing the renderer process to display the error page. Bug: 870815 Change-Id: I8d94f832791de019779679a7414371b6422e32fe Reviewed-on: https://chromium-review.googlesource.com/1163247 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#582543}
-
Fredrik Söderquist authored
These tests fail because of lack of support for references to general shapes from <textPath> and the 'side' attribute in <textPath>. crbug.com/366559 is the bug for supporting thos features, so redirect to it. Tests: external/wpt/svg/shapes/reftests/pathlength-003.svg external/wpt/svg/text/reftests/textpath-side-001.svg external/wpt/svg/text/reftests/textpath-shape-001.svg TBR=schenney@chromium.org BUG=366559,863355 Change-Id: Ia2fc56704fafd3ace0af949fceeaf2799f960fe7 Reviewed-on: https://chromium-review.googlesource.com/1172298Reviewed-by:
-
Pavel Beloborodov authored
BUG=863008 Change-Id: If083bc0703e251fb6e9c597fe5b7f842e37875c9 R=bauerb@chromium.org,sky@chromium.org Change-Id: If083bc0703e251fb6e9c597fe5b7f842e37875c9 Reviewed-on: https://chromium-review.googlesource.com/1135137 Commit-Queue: Thomas Tangl <tangltom@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#582541}
-
Rune Lillesveen authored
Was lost when introducing override in HTMLInputElement in [1]. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1072650 Bug: 871249 Change-Id: I9f33c88913dd00bf9f301b02fdb99bc43ecf82c6 Reviewed-on: https://chromium-review.googlesource.com/1172140Reviewed-by:
Anders Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#582540}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/f4cf64ec0669..553b6f68e1dc git log f4cf64ec0669..553b6f68e1dc --date=short --no-merges --format='%ad %ae %s' 2018-08-13 buildbot@webrtc.org Roll chromium_revision f7e49bb7..690394a8 (582110:582511) Created with: gclient setdep -r src/third_party/webrtc@553b6f68e1dc The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I526b9f0c1f8563f74e29eff9b79db812092aa7af Reviewed-on: https://chromium-review.googlesource.com/1172242Reviewed-by:
-
Donna Wu authored
This CL moves the permission checking in UsbDevice implementation to WebUsbService by adjusting some mojo interfaces. BUG=699790 Change-Id: Ie5842f1a433a8b05275b06f31f25320bcc10a4d7 Reviewed-on: https://chromium-review.googlesource.com/1166592 Commit-Queue: Donna Wu <donna.wu@intel.com> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#582538}
-
