GitLab

https://bugs.webkit.org/show_bug.cgi?id=64626

Reviewed by Darin Adler.

Source/WebCore: 

The bug was caused by willBeModified's always using block direction to determine
the direction to which the selection is collapsed. Fixed the bug by calling directionOfSelection
in willBeModified, which will return the text direction of the surrounding context when
the start and the end have the same direction. When the text directions at the start and at the end
of selection do not match, it uses the block's text direction.

Test: editing/selection/collapse-selection-in-bidi.html

* editing/FrameSelection.cpp:
(WebCore::FrameSelection::directionOfSelection): Added.
(WebCore::FrameSelection::willBeModified): Calls directionOfSelection.
(WebCore::FrameSelection::modifyMovingRight): Ditto.
(WebCore::FrameSelection::modifyMovingLeft): Ditto.
* editing/FrameSelection.h:

LayoutTests: 

Added a test to ensure collapsing directionless selection respects the direction of text around
the selection's end points.

* editing/selection/collapse-selection-in-bidi-expected.txt: Added.
* editing/selection/collapse-selection-in-bidi.html: Added.


git-svn-id: svn://svn.chromium.org/blink/trunk@93221 bbb929c8-8fbe-4397-9dbb-9b2b20218538

https://bugs.webkit.org/show_bug.cgi?id=66326

Patch by David Grogan <dgrogan@chromium.org> on 2011-08-17
Reviewed by Tony Chang.

* public/WebIDBTransactionCallbacks.h:

git-svn-id: svn://svn.chromium.org/blink/trunk@93220 bbb929c8-8fbe-4397-9dbb-9b2b20218538

https://bugs.webkit.org/show_bug.cgi?id=66352
        
Moved platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationCF.* files to platform/graphics/avfoundation/cf,
and moved platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.* files to platform/graphics/avfoundation/objc/.
        
While I was at it, added svn:eol-style property to the MediaPlayerPrivateAVFoundationObjC.* files.
        
Also, for some reason, Visual Studio decided to re-sort a couple files in \inspector\front-end\ in WebCore.vcproj, even though
I just re-sorted the project in r93215.

Reviewed by Eric Carlson.

No new tests; no functional change.

* WebCore.vcproj/WebCore.vcproj: Moved platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationCF.* files to platform/graphics/avfoundation/cf.

* WebCore.vcproj/WebCoreMediaQT.vsprops: Added $(ProjectDir)..\platform\graphics\avfoundation\cf to include paths.

* WebCore.xcodeproj/project.pbxproj: Moved platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.* files to platform/graphics/avfoundation/objc/.

* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationCF.cpp: Removed.
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationCF.h: Removed.
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.h: Removed.
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm: Removed.

* platform/graphics/avfoundation/cf: Added.
* platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp: Copied from Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationCF.cpp.
* platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.h: Copied from Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationCF.h.

* platform/graphics/avfoundation/objc: Added.
* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h: Copied from Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.h.
* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm: Copied from Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm.


git-svn-id: svn://svn.chromium.org/blink/trunk@93219 bbb929c8-8fbe-4397-9dbb-9b2b20218538

https://bugs.webkit.org/show_bug.cgi?id=66022

Reviewed by Darin Adler.

No new tests. Refactoring only.

Reduces instances where the font information is dirtied to save recalculation where it is not necessary.

* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
Call new setTextSizeAdjust function.
* css/CSSStyleSelector.h:
(WebCore::CSSStyleSelector::setTextSizeAdjust):
Add wrapper for RenderStyle::setTextSizeAdjust() that automatically updates m_fontDirty.
* rendering/style/RenderStyle.h:
(WebCore::RenderStyle::setTextSizeAdjust):
Make setTextSizeAdjust return true if the unlderlying value was changed.


git-svn-id: svn://svn.chromium.org/blink/trunk@93218 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://trac.webkit.org/changeset/93204
https://bugs.webkit.org/show_bug.cgi?id=66375

Test no longer crashing since r93171

* platform/chromium/test_expectations.txt:

git-svn-id: svn://svn.chromium.org/blink/trunk@93217 bbb929c8-8fbe-4397-9dbb-9b2b20218538

https://bugs.webkit.org/show_bug.cgi?id=66211

Holds Skia's unique font ID instead of FontPlatformData to avoid accessing freed FontPlatformData.

Reviewed by Tony Chang.

No new tests; no functional change.

* platform/graphics/chromium/HarfbuzzSkia.cpp:
(WebCore::releaseCachedHarfbuzzFace): Changed the argument.
(WebCore::HarfbuzzFace::HarfbuzzFace): Changed to have Skia's font uniqueID instead of FontPlatformData.
(WebCore::HarfbuzzFace::~HarfbuzzFace): Uses m_uniqueID to call releaseCachedHarfbuzzFace.
* platform/graphics/chromium/HarfbuzzSkia.h:


git-svn-id: svn://svn.chromium.org/blink/trunk@93216 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Re-sort the WebCore project with Visual Studio after recent changes that I assume were done by manually editing the XML.

* WebCore.vcproj/WebCore.vcproj:



git-svn-id: svn://svn.chromium.org/blink/trunk@93215 bbb929c8-8fbe-4397-9dbb-9b2b20218538

* platform/chromium-cg-mac-leopard/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png: Added.
* platform/chromium-cg-mac-leopard/fast/repaint/line-flow-with-floats-in-regions-expected.png: Added.
* platform/chromium-cg-mac/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png: Added.
* platform/chromium-cg-mac/fast/repaint/line-flow-with-floats-in-regions-expected.png: Added.
* platform/chromium-cg-mac/fast/repaint/overflow-flipped-writing-mode-block-in-regions-expected.png: Added.
* platform/chromium-win/fast/repaint/overflow-flipped-writing-mode-block-in-regions-expected.png: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: svn://svn.chromium.org/blink/trunk@93214 bbb929c8-8fbe-4397-9dbb-9b2b20218538

media/media-blocked-by-beforeload.html as flaky.

* platform/chromium/test_expectations.txt:

git-svn-id: svn://svn.chromium.org/blink/trunk@93213 bbb929c8-8fbe-4397-9dbb-9b2b20218538

* platform/chromium/test_expectations.txt:


git-svn-id: svn://svn.chromium.org/blink/trunk@93212 bbb929c8-8fbe-4397-9dbb-9b2b20218538

* platform/win/Skipped: Added fast/dom/shadow/tree-scope-crash.html.

git-svn-id: svn://svn.chromium.org/blink/trunk@93211 bbb929c8-8fbe-4397-9dbb-9b2b20218538

https://bugs.webkit.org/show_bug.cgi?id=65558

Add TIMEOUT expectation.

Unreviewed gardening.

* platform/chromium/test_expectations.txt:

git-svn-id: svn://svn.chromium.org/blink/trunk@93210 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Failure is tracked by <http://webkit.org/b/66376>.

* platform/win/fast/text/international/text-combine-image-test-expected.png:
* platform/win/fast/text/international/text-combine-image-test-expected.txt:

git-svn-id: svn://svn.chromium.org/blink/trunk@93209 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Failure is tracked by <http://webkit.org/b/66374>.

* platform/win/editing/deleting/regional-indicators-expected.txt: Added.

git-svn-id: svn://svn.chromium.org/blink/trunk@93208 bbb929c8-8fbe-4397-9dbb-9b2b20218538

* platform/win/fast/css/font-family-pictograph-expected.png: Added.
* platform/win/fast/css/font-family-pictograph-expected.txt: Added.

git-svn-id: svn://svn.chromium.org/blink/trunk@93207 bbb929c8-8fbe-4397-9dbb-9b2b20218538

These tests started failing in r93107 when I made Windows fall back to Lion results instead
of SnowLeopard results. This is good in general, but these particular tests happen to give
SnowLeopard-ish results due to some fonts that changed in Lion.

* platform/win/css1/font_properties/font-expected.png: Added.
* platform/win/css1/font_properties/font-expected.txt: Copied from platform/mac-snowleopard/css1/font_properties/font-expected.txt.
* platform/win/css2.1/t1508-c527-font-05-b-expected.png: Added.
* platform/win/css2.1/t1508-c527-font-05-b-expected.txt: Copied from platform/mac-snowleopard/css2.1/t1508-c527-font-05-b-expected.txt: Added.
* platform/win/css2.1/t1508-c527-font-10-c-expected.png: Added.
* platform/win/css2.1/t1508-c527-font-10-c-expected.txt: Copied from platform/mac-snowleopard/css2.1/t1508-c527-font-10-c-expected.txt.
* platform/win/fast/text/capitalize-boundaries-expected.png: Added.
* platform/win/fast/text/capitalize-boundaries-expected.txt: Copied from platform/win/fast/text/capitalize-boundaries-expected.txt.

git-svn-id: svn://svn.chromium.org/blink/trunk@93206 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Failure is tracked by <http://webkit.org/b/56101>.

* platform/win/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png: Added.
* platform/win/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt: Added.

git-svn-id: svn://svn.chromium.org/blink/trunk@93205 bbb929c8-8fbe-4397-9dbb-9b2b20218538

https://bugs.webkit.org/show_bug.cgi?id=66375

Sets a CRASH expectation for Windows debug.

Unreviewed gardening.

* platform/chromium/test_expectations.txt:

git-svn-id: svn://svn.chromium.org/blink/trunk@93204 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Set failing TEXT expectation for http/tests/security/mixedContent/insecure-plugin-in-iframe.html for all build flavors
http://crbug.com/26042

The test already has a failing TEXT expectation for DEBUG and for
LINUX RELEASE, but we're now seeing failures on Mac10.6. It looks like
it's generally flaky.

Unreviewed gardening.

* platform/chromium/test_expectations.txt:

git-svn-id: svn://svn.chromium.org/blink/trunk@93203 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Chromium Mac: Fix implementation of wkScrollbarMinimumTotalLengthNeededForThumb to match WebKitSystemInterface
https://bugs.webkit.org/show_bug.cgi?id=66311

Patch by Sailesh Agrawal <sail@chromium.org> on 2011-08-17
Reviewed by Dimitri Glazkov.

Updated wkScrollbarMinimumTotalLengthNeededForThumb() based on the latest disassembly of libWebKitSystemInterfaceLion.a.

* platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.mm:
(wkScrollbarMinimumTotalLengthNeededForThumb):

git-svn-id: svn://svn.chromium.org/blink/trunk@93202 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://trac.webkit.org/changeset/93186
https://bugs.webkit.org/show_bug.cgi?id=66114

Breaks LayoutTests on Chromium canary bots

Source/WebCore:

* platform/graphics/chromium/LayerChromium.h:
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::updateLayers):
(WebCore::LayerRendererChromium::drawLayersInternal):
(WebCore::LayerRendererChromium::drawLayer):
* platform/graphics/chromium/cc/CCLayerImpl.h:

LayoutTests:

* compositing/backface-visibility-hierarchical-transform-expected.png: Removed.
* compositing/backface-visibility-hierarchical-transform-expected.txt: Removed.
* compositing/backface-visibility-hierarchical-transform.html: Removed.

git-svn-id: svn://svn.chromium.org/blink/trunk@93201 bbb929c8-8fbe-4397-9dbb-9b2b20218538

https://bugs.webkit.org/show_bug.cgi?id=66212

Unreviewed gardening.

* platform/qt-4.8/Skipped:
 - Unskip fast/css/font-face-opentype.html.
 - Unskip http/tests/security/cross-frame-access-put.html, because it passes now.
* platform/qt-4.8/fast/css/font-face-opentype-expected.txt: Update Qt 4.8 specific expected result.

git-svn-id: svn://svn.chromium.org/blink/trunk@93200 bbb929c8-8fbe-4397-9dbb-9b2b20218538

AccessibilityRenderObject.cpp and InsertTextCommand.cpp
https://bugs.webkit.org/show_bug.cgi?id=66014

Reviewed by Hajime Morita.

Removed calls to deprecatedNode and deprecatedEditingOffsets in the following files.

* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::indexForVisiblePosition): Calls Position::rootEditableElement
and Range::setEnd(const Position&, ExceptionCode) instead of manually pulling deprecatedNode
and deprecatedEditingOffset.
(WebCore::AccessibilityRenderObject::index): Abstracted the logic to loop through render objects
from deprecatedNodes' renderer to m_renderer as renderObjectContainsPosition.
* dom/Position.h:
(WebCore::Position::rootEditableElement): Added.
* dom/Range.cpp:
(WebCore::Range::setStart): Added.
(WebCore::Range::setEnd): Added.
* dom/Range.h:
* editing/InsertTextCommand.cpp:
(WebCore::InsertTextCommand::insertTab):
* editing/RenderedPosition.cpp:
(WebCore::renderObjectContainsPosition): Extracted from AccessibilityRenderObject::index.
* editing/RenderedPosition.h:


git-svn-id: svn://svn.chromium.org/blink/trunk@93199 bbb929c8-8fbe-4397-9dbb-9b2b20218538

* platform/qt/Skipped:
 - Unskip tests removed by r93095.
 - Skip fast/repaint/japanese-rl-selection-repaint-in-regions.html introduced in r93144.
* platform/qt/fast/repaint/line-flow-with-floats-in-regions-expected.png: Added. (test introduced in r93144)
* platform/qt/fast/repaint/line-flow-with-floats-in-regions-expected.txt: Added. (test introduced in r93144)
* platform/qt/fast/repaint/overflow-flipped-writing-mode-block-in-regions-expected.png: Added. (test introduced in r93144)
* platform/qt/fast/repaint/overflow-flipped-writing-mode-block-in-regions-expected.txt: Added. (test introduced in r93144)

git-svn-id: svn://svn.chromium.org/blink/trunk@93198 bbb929c8-8fbe-4397-9dbb-9b2b20218538

https://bugs.webkit.org/show_bug.cgi?id=66238

Patch by Sailesh Agrawal <sail@chromium.org> on 2011-08-17
Reviewed by Dimitri Glazkov.

Overlay scrollbars were not visible if the user scrolled a page while the page was loading. The sequence of events necessary to reproduce this bug were:
  1. -[ScrollbarPainterDelegate scrollerImp:animateKnobAlphaTo:duration:] is called
  2. animation is delayed because shouldSuspendScrollAnimations() is true
  3. ScrollAnimatorChromiumMac::scroll() is called before the ScrollAnimatorChromiumMac::m_initialScrollbarPaintTimer is fired.
  4. At this point the scrollbar painter assumes the scrollbar is already visible (because of 1.) so the scrollbar's alpha stays at 0. Thus the scrollbar isn't visible until the page finishes loading.
It turns out that the root problem was that when the initialScrollbarPainterTimer fired I wasn't flashing the scrollbar correctly. My implementation of wkScrollbarPainterForceFlashScrollers() just called flashScrollers. The Safari implementation of this function also calls hideOverlayScrollers. Calling hideOverlayScrollers causes the alpha to change to 0 which prevents step 4 from happening.

Also, now that wkScrollbarPainterForceFlashScrollers is working correctly I don't need the extra logic I added to the initialScrollbarPainterTimer handler. That logic restarted the timer if shouldSuspendScrollAnimations() was true. But this isn't necessary since calling wkScrollbarPainterForceFlashScrollers() causes -[ScrollbarPainterDelegate setUpAnimation:...] to be called which does the exact same thing. Removing the extra logic reverts http://trac.webkit.org/changeset/92316.

* platform/chromium/ScrollAnimatorChromiumMac.mm:
(WebCore::ScrollAnimatorChromiumMac::initialScrollbarPaintTimerFired):
* platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.mm:
(wkScrollbarPainterForceFlashScrollers):

git-svn-id: svn://svn.chromium.org/blink/trunk@93197 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Web Inspector: maintain visible view hierarchy and dispatch common view events automatically
        https://bugs.webkit.org/show_bug.cgi?id=66131

        Reviewed by Pavel Feldman.

        Test: inspector/view-events.html

        - added a notion of an optional parent to a View
        - maintain a list of View children
        - dispatch common view events, such as show/hide/resize automatically through the hierarchy of visible views.
        - promoted Panel's logic of (re)storing scroll positions to view
        - demoted inheritScrollPositionFromView to a couple of views that need it.

        * inspector/front-end/ApplicationCacheItemsView.js:
        (WebInspector.ApplicationCacheItemsView.prototype.onResize):
        * inspector/front-end/ConsoleView.js:
        (WebInspector.ConsoleView.prototype.populateStatusBar):
        (WebInspector.ConsoleView.prototype.elementsToRestoreScrollPositionsFor):
        * inspector/front-end/CookieItemsView.js:
        (WebInspector.CookieItemsView.prototype.onResize):
        (WebInspector.SimpleCookiesTable.prototype.onResize):
        * inspector/front-end/DOMStorageItemsView.js:
        (WebInspector.DOMStorageItemsView.prototype.onResize):
        * inspector/front-end/DetailedHeapshotView.js:
        (WebInspector.DetailedHeapshotView.prototype.onResize):
        * inspector/front-end/Drawer.js:
        (WebInspector.Drawer.prototype.set visibleView):
        (WebInspector.Drawer.prototype.show):
        (WebInspector.Drawer.prototype.hide):
        (WebInspector.Drawer.prototype.onResize):
        (WebInspector.Drawer.prototype._animateDrawerHeight.animationFinished):
        (WebInspector.Drawer.prototype._animateDrawerHeight):
        (WebInspector.Drawer.prototype._statusBarDragging):
        (WebInspector.Drawer.prototype._endStatusBarDragging):
        * inspector/front-end/ElementsPanel.js:
        (WebInspector.ElementsPanel.prototype.onResize):
        * inspector/front-end/ExtensionPanel.js:
        * inspector/front-end/FontView.js:
        (WebInspector.FontView.prototype.onResize):
        * inspector/front-end/IFrameView.js:
        (WebInspector.IFrameView):
        * inspector/front-end/NetworkItemView.js:
        (WebInspector.NetworkItemView.prototype._installHighlightSupport):
        * inspector/front-end/NetworkPanel.js:
        (WebInspector.NetworkLogView):
        (WebInspector.NetworkLogView.prototype.elementsToRestoreScrollPositionsFor):
        (WebInspector.NetworkLogView.prototype.onResize):
        (WebInspector.NetworkLogView.prototype.wasShown):
        (WebInspector.NetworkLogView.prototype.willHide):
        (WebInspector.NetworkPanel):
        (WebInspector.NetworkPanel.prototype.show):
        (WebInspector.NetworkPanel.prototype._showResource):
        (WebInspector.NetworkPanel.prototype._closeVisibleResource):
        * inspector/front-end/Panel.js:
        (WebInspector.Panel.prototype.show):
        (WebInspector.Panel.prototype.hide):
        (WebInspector.Panel.prototype.performSearch.processChunk):
        (WebInspector.Panel.prototype.performSearch):
        (WebInspector.Panel.prototype.updateSidebarWidth):
        * inspector/front-end/PanelEnablerView.js:
        (WebInspector.PanelEnablerView.prototype.show):
        (WebInspector.PanelEnablerView.prototype.onResize):
        * inspector/front-end/ProfileView.js:
        (WebInspector.CPUProfileView.prototype.onResize):
        * inspector/front-end/ProfilesPanel.js:
        (WebInspector.ProfilesPanel.prototype.updateMainViewWidth):
        * inspector/front-end/ResourceCookiesView.js:
        (WebInspector.ResourceCookiesView.prototype.onResize):
        * inspector/front-end/ResourcePreviewView.js:
        (WebInspector.ResourcePreviewView.prototype.contentLoaded):
        * inspector/front-end/ResourceResponseView.js:
        (WebInspector.ResourceResponseView.prototype.contentLoaded):
        * inspector/front-end/ResourceTimingView.js:
        (WebInspector.ResourceTimingView.prototype.show):
        * inspector/front-end/ResourcesPanel.js:
        (WebInspector.ResourcesPanel.prototype.show):
        (WebInspector.ResourcesPanel.prototype._innerShowView):
        (WebInspector.ResourcesPanel.prototype.closeVisibleView):
        (WebInspector.ResourcesPanel.prototype.updateMainViewWidth):
        (WebInspector.FrameResourceTreeElement.prototype._recreateSourceView):
        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.ScriptsPanel.prototype.show):
        (WebInspector.ScriptsPanel.prototype._createSourceFrame):
        (WebInspector.ScriptsPanel.prototype._removeSourceFrame):
        (WebInspector.ScriptsPanel.prototype.setSidebarWidth):
        * inspector/front-end/SourceFrame.js:
        (WebInspector.SourceFrame):
        (WebInspector.SourceFrame.prototype.show):
        (WebInspector.SourceFrame.prototype.willHide):
        (WebInspector.SourceFrame.prototype.clearMessages):
        (WebInspector.SourceFrame.prototype._setTextViewerDecorations):
        (WebInspector.SourceFrame.prototype.inheritScrollPositions):
        * inspector/front-end/TabbedPane.js:
        (WebInspector.TabbedPane.prototype.appendTab):
        * inspector/front-end/TextViewer.js:
        (WebInspector.TextViewer.prototype.elementsToRestoreScrollPositionsFor):
        (WebInspector.TextViewer.prototype.inheritScrollPositions):
        (WebInspector.TextViewer.prototype.onResize):
        * inspector/front-end/TimelinePanel.js:
        (WebInspector.TimelinePanel.prototype.onResize):
        (WebInspector.TimelinePanel.prototype.elementsToRestoreScrollPositionsFor):
        (WebInspector.TimelinePanel.prototype.show):
        * inspector/front-end/View.js:
        (WebInspector.View):
        (WebInspector.View.prototype.wasShown):
        (WebInspector.View.prototype.willHide):
        (WebInspector.View.prototype._innerShow):
        (WebInspector.View.prototype.show):
        (WebInspector.View.prototype._innerHide):
        (WebInspector.View.prototype.hide):
        (WebInspector.View.prototype._detach):
        (WebInspector.View.prototype.elementsToRestoreScrollPositionsFor):
        (WebInspector.View.prototype.storeScrollPositions):
        (WebInspector.View.prototype.restoreScrollPositions):
        (WebInspector.View.prototype.addChildView):
        (WebInspector.View.prototype.removeChildView):
        (WebInspector.View.prototype.onResize):
        (WebInspector.View.prototype.doResize):
        (WebInspector.View.prototype.dispatchToSelfAndVisibleChildren):
        (WebInspector.View.prototype.dispatchToVisibleChildren):
        * inspector/front-end/inspector.js:
        (WebInspector.windowResize):

2011-08-16  Andrey Kosyakov  <caseq@chromium.org>

        Web Inspector: maintain visible view hierarchy and dispatch common view events automatically
        https://bugs.webkit.org/show_bug.cgi?id=66131

        Reviewed by Pavel Feldman.

        * inspector/view-events-expected.txt: Added.
        * inspector/view-events.html: Added.


git-svn-id: svn://svn.chromium.org/blink/trunk@93196 bbb929c8-8fbe-4397-9dbb-9b2b20218538

https://bugs.webkit.org/show_bug.cgi?id=66356

Reviewed by Dan Bernstein.

No new tests - no behavioral changes.

* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
Support cast from TextOverflow to CSSPrimitiveValue.
(WebCore::CSSPrimitiveValue::operator TextOverflow):
Support cast from CSSPrimitiveValue to TextOverflow.
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
Use HANDLE_INHERIT_AND_INITIAL_AND_PRIMITIVE macro for text overflow.
* rendering/style/RenderStyle.h:
(WebCore::InheritedFlags::textOverflow):
Return TextOverflow enum.
(WebCore::InheritedFlags::setTextOverflow):
Accept TextOverflow enum parameter.
(WebCore::InheritedFlags::initialTextOverflow):
Return TextOverflowClip.
* rendering/style/RenderStyleConstants.h:
Define TextOverflow enum.
* rendering/style/StyleRareNonInheritedData.h:
Change representation of text overflow from bool to one-bit unsigned.


git-svn-id: svn://svn.chromium.org/blink/trunk@93195 bbb929c8-8fbe-4397-9dbb-9b2b20218538

https://bugs.webkit.org/show_bug.cgi?id=66339
        
Generate a compile-time error for Production builds if !USE(AVFOUNDATION).

Reviewed by Darin Adler.

* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationCF.cpp: Generate a compile-time error for Production builds if !USE(AVFOUNDATION).


git-svn-id: svn://svn.chromium.org/blink/trunk@93194 bbb929c8-8fbe-4397-9dbb-9b2b20218538

tony^work added.  This directory will house Skia results for Chromium Mac.

* platform/chromium-mac-leopard: Added.


git-svn-id: svn://svn.chromium.org/blink/trunk@93191 bbb929c8-8fbe-4397-9dbb-9b2b20218538

https://bugs.webkit.org/show_bug.cgi?id=66359

Reviewed by Eric Seidel.

Once we have a Skia configuration on Chromium Mac, we'll use this CG
qualifier to note that expectations apply only to the CG configuration.

* Scripts/webkitpy/layout_tests/port/chromium.py:
* Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:


git-svn-id: svn://svn.chromium.org/blink/trunk@93190 bbb929c8-8fbe-4397-9dbb-9b2b20218538

https://bugs.webkit.org/show_bug.cgi?id=66351

JIT::privateCompilePutByIdTransition expects that regT0 and regT1
have the basePayload and baseTag respectively.  In some cases,
we may get to this generated code with one or both of these
registers trash.  One know case is that regT0 on ARM may be
trashed as regT0 (r0) is also arg0 and can be overrun with sp due
to calls to JIT::restoreReturnAddress().  This patch uses the
values on the stack.  A longer term solution is to work out all
cases so that the register entry assumptions can assured.

While fixing this, also determined that the additional stack offset
of sizeof(void*) is not needed for ARM.

Reviewed by Gavin Barraclough.

* jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::privateCompilePutByIdTransition):


git-svn-id: svn://svn.chromium.org/blink/trunk@93189 bbb929c8-8fbe-4397-9dbb-9b2b20218538

https://bugs.webkit.org/show_bug.cgi?id=66340

Reviewed by Adam Barth.

Test coming in a more comprehensive patch shortly. This is just a very targetted
patch to allow for easier merging.

* loader/CrossOriginAccessControl.cpp:
(WebCore::isOnAccessControlSimpleRequestHeaderWhitelist): Add referer to the list
of whitelisted headers. It can't be set by xhr so it is ok to whitelist it, but it is
set before calling this function. This is similar to what is done for "origin" in here.

git-svn-id: svn://svn.chromium.org/blink/trunk@93188 bbb929c8-8fbe-4397-9dbb-9b2b20218538

https://bugs.webkit.org/show_bug.cgi?id=66218

Reviewed by Tony Chang.

One mismatch reftest is expected to pass, the other is expected to
fail. The failed one is marked as 'WONTFIX' in test expectations
in chromium port and is skipped in other ports.

* fast/harness/sample-fail-mismatch-reftest-expected-mismatch.html: Added.
* fast/harness/sample-fail-mismatch-reftest.html: Added.
* fast/harness/sample-mismatch-reftest-expected-mismatch.html: Added.
* fast/harness/sample-mismatch-reftest.html: Added.
* platform/chromium/test_expectations.txt:
* platform/gtk/Skipped:
* platform/mac/Skipped:
* platform/qt/Skipped:
* platform/win/Skipped:

git-svn-id: svn://svn.chromium.org/blink/trunk@93187 bbb929c8-8fbe-4397-9dbb-9b2b20218538

https://bugs.webkit.org/show_bug.cgi?id=66114

Patch by Shawn Singh <shawnsingh@chromium.org> on 2011-08-16
Reviewed by James Robinson.

Source/WebCore:

Test: compositing/backface-visibility-hierarchical-transform.html

Added a data member to LayerChromium and CCLayerImpl that holds
the screen-space transform.   The transform is computed in
calculateDrawTransformsAndVisibility(), which is used during
updating (LayerChromium) and drawing (CCLayerImpl).  This transform
will also be used for other things, such as HUD drawing, in upcoming
patches.

Also fixed a FIXME in LayerRendererChromium::drawLayer, which
was not computing the entire hierarchy of transforms to determine
back-face visibility.  Now it simply uses the screen space transform.

* platform/graphics/chromium/LayerChromium.h:
(WebCore::LayerChromium::screenSpaceDrawTransform):
(WebCore::LayerChromium::setScreenSpaceDrawTransform):
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::updateLayers):
(WebCore::LayerRendererChromium::drawLayersInternal):
(WebCore::LayerRendererChromium::drawLayer):
(WebCore::calculateDrawTransformsAndVisibility):
* platform/graphics/chromium/cc/CCLayerImpl.h:
(WebCore::CCLayerImpl::screenSpaceDrawTransform):
(WebCore::CCLayerImpl::setScreenSpaceDrawTransform):

LayoutTests:

This case tests if backface visibility properly accounts for a hierarchy
of transforms.

* compositing/backface-visibility-hierarchical-transform-expected.png: Added.
* compositing/backface-visibility-hierarchical-transform-expected.txt: Added.
* compositing/backface-visibility-hierarchical-transform.html: Added.

git-svn-id: svn://svn.chromium.org/blink/trunk@93186 bbb929c8-8fbe-4397-9dbb-9b2b20218538

* platform/win-wk2/editing/deleting/delete-at-paragraph-boundaries-008-expected.txt:
* platform/win-wk2/editing/deleting/delete-ws-fixup-003-expected.txt:
* platform/win-wk2/editing/deleting/delete-ws-fixup-004-expected.txt:


git-svn-id: svn://svn.chromium.org/blink/trunk@93185 bbb929c8-8fbe-4397-9dbb-9b2b20218538

https://bugs.webkit.org/show_bug.cgi?id=66285

Reviewed by Dimitri Glazkov.

Fix the issue where a shadow host stops an event propagation if an
event happens at the children of shadow hosts, outside of the shadow root.

Source/WebCore:

Test: fast/dom/shadow/shadow-contents-event.html

* dom/EventDispatcher.cpp:
(WebCore::EventDispatcher::adjustToShadowBoundaries):

LayoutTests:

* fast/dom/shadow/details-summary-mouseover-expected.txt: Removed.
* fast/dom/shadow/details-summary-mouseover.html: Removed.
* fast/dom/shadow/shadow-contents-event-expected.txt: Added.
* fast/dom/shadow/shadow-contents-event.html: Added.


git-svn-id: svn://svn.chromium.org/blink/trunk@93184 bbb929c8-8fbe-4397-9dbb-9b2b20218538

https://bugs.webkit.org/show_bug.cgi?id=66325

Unreviewed.  Fixing an exception/typo seen on the bots (and testing to make sure it works).

* Scripts/webkitpy/layout_tests/port/mac.py:
* Scripts/webkitpy/layout_tests/port/mac_unittest.py:

git-svn-id: svn://svn.chromium.org/blink/trunk@93183 bbb929c8-8fbe-4397-9dbb-9b2b20218538

https://bugs.webkit.org/show_bug.cgi?id=65694

Patch by Per-Erik Brodin <per-erik.brodin@ericsson.com> on 2011-08-16
Reviewed by Alexey Proskuryakov.

Source/WebCore:

No new tests since there is no change in behavior.

* fileapi/FileReaderLoader.cpp:
(WebCore::FileReaderLoader::start):
* loader/DocumentThreadableLoader.cpp:
(WebCore::DocumentThreadableLoader::DocumentThreadableLoader):
(WebCore::DocumentThreadableLoader::makeSimpleCrossOriginAccessRequest):
* loader/ThreadableLoader.h:
(WebCore::ThreadableLoaderOptions::ThreadableLoaderOptions):
* notifications/Notification.cpp:
(WebCore::Notification::startLoading):
* xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::createRequest):

Source/WebKit/chromium:

* src/AssociatedURLLoader.cpp:
(WebKit::AssociatedURLLoader::loadAsynchronously):

git-svn-id: svn://svn.chromium.org/blink/trunk@93182 bbb929c8-8fbe-4397-9dbb-9b2b20218538

https://bugs.webkit.org/show_bug.cgi?id=66349

Reviewed by James Robinson.

As requested by jamesr.

* Scripts/webkitpy/tool/commands/rebaseline.py:


git-svn-id: svn://svn.chromium.org/blink/trunk@93178 bbb929c8-8fbe-4397-9dbb-9b2b20218538

https://bugs.webkit.org/show_bug.cgi?id=66344

win-wk2 didn't have some necessary baselines for an earlier patch;
they have been copied directly from LayoutTests/platform/chromium-win

Patch by Wyatt Carss <wcarss@chromium.org> on 2011-08-16
Reviewed by Ryosuke Niwa.

* platform/win-wk2/editing/deleting: Added.
* platform/win-wk2/editing/deleting/delete-at-paragraph-boundaries-008-expected.txt: Copied from LayoutTests/platform/chromium-win/editing/deleting/delete-at-paragraph-boundaries-008-expected.txt.
* platform/win-wk2/editing/deleting/delete-ws-fixup-003-expected.txt: Copied from LayoutTests/platform/chromium-win/editing/deleting/delete-ws-fixup-003-expected.txt.
* platform/win-wk2/editing/deleting/delete-ws-fixup-004-expected.txt: Copied from LayoutTests/platform/chromium-win/editing/deleting/delete-ws-fixup-004-expected.txt.
* platform/win-wk2/editing/selection/transformed-selection-rects-expected.txt: Copied from LayoutTests/platform/chromium-win/editing/selection/transformed-selection-rects-expected.txt.


git-svn-id: svn://svn.chromium.org/blink/trunk@93177 bbb929c8-8fbe-4397-9dbb-9b2b20218538