- 01 Aug, 2019 40 commits
-
-
Takashi Sakamoto authored
This reverts commit 1b08fa8e. Reason for revert: suspect causing unit_tests failure on linux-chromeos-dbg. https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/13673 deterministic failures: ArcAppLauncherForDefaultAppTest.AppIconUpdated/0 ArcAppLauncherForDefaultAppTest.AppIconUpdated/1 ... E.g. https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8906357365557383728/+/steps/unit_tests/0/logs/Deterministic_failure:_ArcAppLauncherForDefaultAppTest.AppIconUpdated__x2f_0__status_CRASH_/0 [ RUN ] ArcAppLauncherForDefaultAppTest.AppIconUpdated/0 Received signal 11 <unknown> 000000000000 #9 0x7f40f3cfd40b base::ThreadCheckerImpl::CalledOnValidThread() #10 0x5611fbac0319 arc::internal::ConnectionNotifier::RemoveObserver() #11 0x5611f8ea55e9 arc::ConnectionHolder<>::RemoveObserver() #12 0x5611ff697745 apps::ArcApps::~ArcApps() #13 0x5611ff69786c apps::ArcApps::~ArcApps() ... #22 0x7f40e9d8e740 KeyedServiceFactory::Disassociate() #23 0x7f40e9d8e834 KeyedServiceFactory::ContextDestroyed() #24 0x7f40de6a3503 BrowserContextKeyedServiceFactory::BrowserContextDestroyed() #25 0x7f40de6a3677 BrowserContextKeyedServiceFactory::ContextDestroyed() #26 0x7f40e9d8b145 DependencyManager::DestroyFactoriesInOrder() #27 0x7f40e9d8b1f5 DependencyManager::PerformInterlockedTwoPhaseShutdown() #28 0x5611fe3b3fc3 TestingProfile::~TestingProfile() #29 0x5611fe3b43cc TestingProfile::~TestingProfile() ... Original change's description: > Flip the AppServiceAsh feature default to enabled > > BUG=826982 > BUG=989789 > > Change-Id: I49bd3793bf9fcfc89726fd2f7df690421996e0fd > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728411 > Reviewed-by: Dominick Ng <dominickn@chromium.org> > Commit-Queue: Nigel Tao <nigeltao@chromium.org> > Cr-Commit-Position: refs/heads/master@{#683064} TBR=dominickn@chromium.org,nigeltao@chromium.org Change-Id: Iec931954750b6a58d2274c6479507e99efd2467a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 826982, 989789 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731091Reviewed-by:
Takashi Sakamoto <tasak@google.com> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#683108}
-
Kent Tamura authored
elements/toast/.eslintrc.js and kv-storage/.eslintrc.js were identical, and elements/virtual-scroller/.eslintrc.js had some differences. The following describes differences between them and decision for them. * virtual-scroller had '2' for no-magic-numbers exceptions. We keep the '2' exception. * virtual-scroller enabled max-len. We enable max-len. max-len is helpful because clang-format doesn't support *.mjs extension for now. * virtual-scroller had no no-lonely-if and no no-else-return. We drop them. Following these rules is sometimes harmful for code consistency. Change-Id: Icf3118e4d504248a55a284a763f7392c59793769 Bug: 976576 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1727447 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Domenic Denicola <domenic@chromium.org> Reviewed-by:
Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#683107}
-
Julie Jeongeun Kim authored
This CL is a part of moving access token management to OAuth2AccessTokenManager. It moves RegisterTokenResponse to private since it's only used by OAuth2AccessTokenManager::Fetcher which is a nested class in OAuth2AccessTokenManager. Bug: 967598 Change-Id: Ic51db4d938f955e920a33d00a6f74e07f88a8763 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731029Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#683106}
-
Kenichi Ishibashi authored
The motivation is to avoid creating GarbageCollected objects in WebEmbeddedWorkerImpl so that we can start service worker on the IO thread, not on the main thread. The IO thread runs without Oilpan and thus we can't create GarbageCollected objects on the IO thread. ServiceWorkerGlobalScopeProxy was a GarbageCollected object because it contained ParentExecutionContextTaskRunners which is also a GarbageCollected object. The only usage of the task runners was to get the default task runner so we can replace it with Thread::Current()->GetTaskRunner(), which returns a non GarbageCollected task runner. After this CL, ServiceWorkerThread owns ServiceWorkerGlobalScopeProxy as a unique_ptr, not a Persistent. The ownership of these classes are as follows and there seems no cycle ownership, so that's fine IIUC. WebEmbeddedWorkerImpl --(unique_ptr)--> ServiceWorkerThread ServiceWorkerThread --(was Persistent, now unique_ptr)--> ServiceWorkerGlobalScopeProxy ServiceWorkerThread --(CrossThreadPersistent)--> ServiceWorkerGlobalScope ServiceWorkerGlobalScopeProxy --(CrossThreadPersistent)--> ServiceWorkerGlobalScope ServiceWorkerGlobalScope --(raw reference)--> ServiceWorkerGlobalScopeProxy ServiceWorkerGlobalScope --(raw ptr)--> ServiceWorkerThread Bug: 988335 Change-Id: I5c9104e73300ac14b56f7ad9b337d71c53321d02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725530Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#683105}
-
Takashi Sakamoto authored
[Sheriff] Mark http/tests/devtools/indexeddb/live-update-indexeddb-list.js as flaky on Linux Tests (dbg). Bug: 989860 Change-Id: I6aef927384f588221e578d399fc2379f8fa82f6c Tbr: zmin@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730553Reviewed-by:
-
Glen Robertson authored
ie. return Result::kUrlLoaded (successful load) when loaded URL matches expected URL up to and including the path. Ignore changes after the "?". Bug: 989376 Change-Id: Ib4f719b879b9074ead66b135b7701863b15b80a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730449 Commit-Queue: Glen Robertson <glenrob@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#683103}
-
Maksim Sisov authored
Fix native GpuMemoryBuffers for Ozone/Wayland by implementing non implemented CreateNativePixmapAsync call. Bug: 989433 Change-Id: Ic178ac2d4f0716e4c4a00a0abb6686e64b980b90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728655Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#683102}
-
Yutaka Hirano authored
Bug: None Change-Id: Ic34ec4c6cb84c75a1fe7602fa43bd14fcef1595f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730890Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#683101}
-
Kunihiko Sakamoto authored
This is a preparation for supporting the new bundle format [1]. After this change, ParseMetadata() and ParseResponse() return error as Bundle{Metadata,Response}ParseError struct. At the moment these structs are just wrappers of string, but additional fields will be added in follow up CLs. [1] https://github.com/WICG/webpackage/pull/450 Bug: 969596 Change-Id: I5bdbc84149f818f07470999fc42c8680e46f2385 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724150 Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by:Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#683100}
-
Maksim Moskvitin authored
Original CL missed MAYBE prefix and this could lead to test flakiness on tsan tryjobs. Bug: 922900 Change-Id: I1faf72c55b7942ad53b4f0e0bd9efdee979f427b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729633 Auto-Submit: Maksim Moskvitin <mmoskvitin@google.com> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#683099}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/4828620d0a30..11243c3b6292 git log 4828620d0a30..11243c3b6292 --date=short --no-merges --format='%ad %ae %s' 2019-08-01 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go deps 2019-08-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src f6d0e4f5..9aeb39b9 (441 commits) Created with: gclient setdep -r src/third_party/skia@11243c3b6292 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=benjaminwagner@google.com Bug: chromium:None Change-Id: Icba13b9bf2aa706c775df7ee67a00d65747757b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730593Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#683098}
-
Benoît Lizé authored
Set the expiration date of these histograms to end of 2019, as they are still useful (and are recorded only once per renderer, so shouldn't be too large). Bug: 974926, 974925, 974924, 974923, 974922 Change-Id: I4a2fc1f2d0c86c8aa3ccf66477250b81515a69d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720871Reviewed-by:
Nik Bhagat <nikunjb@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#683097}
-
Takashi Sakamoto authored
[Sheriff] Mark http/tests/devtools/indexeddb/live-update-indexeddb-list.js as flaky on Mac10.13 (dbg). Bug: 989860 Change-Id: I7e078ae525b0c2fa6b20c504fcca2d1838557b2d Tbr: zmin@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730949Reviewed-by:
-
Yi Su authored
When a11y font size is used, long press on the "New Tab" button in tab grid will show a built-in a11y modal panel which contains an image and a title. Currently the title is missing, and this CL fixes it. BTW, the image is also changed to the larger image for incognito page instead of the small one. Bug: 989016 Change-Id: I706570f1002b82eaf33908006d09cc3498cb6e66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726090Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: Yi Su <mrsuyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#683095}
-
Kouhei Ueno authored
Bug: 981740 Change-Id: I5993bf635a541032818ade0a6aff183e7835a213 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716132Reviewed-by:
Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Lowell Manners <lowell@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#683094}
-
Alexey Baskakov authored
Rename PinAppToShelf to AddAppToQuickLaunchBar and CanPinAppToShelf to CanAddAppToQuickLaunchBar. The name should match ExternalInstallOptions::add_to_quick_launch_bar flag and flag's description: // If true, a shortcut is added to the "quick launch bar" of the OS: the Shelf // for Chrome OS, the Dock for macOS, and the Quick Launch Bar or Taskbar on // Windows. Currently this only works on Chrome OS. Delegate CanAddAppToQuickLaunchBar/AddAppToQuickLaunchBar to WebAppUiManager since this is UI-related business. It requires plumbing of WebAppUiManager to InstallFinalizer (InstallFinalizer is already plumbed to all WebAppInstallTasks) In next CLs: We will get rid of chrome/browser/extensions/bookmark_app_extension_util.cc completely. That's the last bookmark_app* prefixed file in extensions/. TBR=dominickn@chromium.org Bug: 901226 Change-Id: I152cdacb6c5c9cbd0ac6e42888a849e39e064af7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729402Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#683093}
-
Yue Zhang authored
Bug: 989319 Change-Id: I4ed0bb779e5bca4be0ebb6cc34db8ed74a1ed65a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730190Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#683092}
-
Yuki Shiino authored
- Implements __eq__ / __ne__ for IdlType - Implements VariadicType as a subclass of _ArrayLikeType - Implements UnionType.flattened_member_types (UnionType.__eq__ could be implemented based on flattened_member_types, but it was not used. See a comment of UnionType.__eq__.) Bug: 839389 Change-Id: I215da4624bf26681974e483138cf819d8eb24849 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728010Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#683091}
-
David Staessens authored
This CL fixes an incorrect log message in the video_decode_accelerator_tests and video_decode_accelerator_perf_tests. When the VDA requests a set of buffers during testing the number of buffers and size requested is logged, but the size was incorrectly displayed as HxH instead of WxH. TEST=ran new VD tests on eve BUG=None Change-Id: Ia58782e05dfef8b7a51e9ea0a06d7125c5e25790 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730950 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#683090}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/fd643a4782c9..32eaa7b5baa3 git log fd643a4782c9..32eaa7b5baa3 --date=short --no-merges --format='%ad %ae %s' 2019-08-01 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision d488661c..4b9d9012 (682945:683063) 2019-08-01 mellem@webrtc.org Reland "Only include payload in bytes sent/received." Created with: gclient setdep -r src/third_party/webrtc@32eaa7b5baa3 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: Ifec9ffc7be0522ec9a68f4b9db3677b0a56a67a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730570Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/22b6cbc9..a4a17b2e Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I2570b7cc3b14f684dde8317e03326082a39d1d20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729403Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#683088}
-
Kent Tamura authored
formatJapaneseImperialEra() threw an exception for year=275760 month=September. The function is called with these arguments on the startup of a picker because of MonthPopupButton._shouldUseShortMonth(). Bug: 989826 Change-Id: I308ea5087b0f6a8ff857ee1844c83e5970130933 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730769Reviewed-by:
Keishi Hattori <keishi@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#683087}
-
Chih-Yu Huang authored
This CL checks the V4L2 input and output queue before using it. It fixed the crash if we destruct a V4L2SVD instance without initializing it. BUG=chromium:941330 TEST=run video_decode_accelerator_tests on Kevin Change-Id: I01587f3adabeb001727949076b9895794c85404a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716447 Auto-Submit: Chih-Yu Huang <akahuang@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
-
Wei-Yin Chen (陳威尹) authored
Bug: 974079 Change-Id: I6b8209ad918900a37ad1f65250768bd7c3c9603a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729966 Auto-Submit: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5136bc88d5ae..7d5085a0056a Created with: gclient setdep -r src-internal@7d5085a0056a The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I6a9bc39a3d7cd0217ab65b59d063f3f344abe0b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730830Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#683084}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/78eedba78f03..4828620d0a30 git log 78eedba78f03..4828620d0a30 --date=short --no-merges --format='%ad %ae %s' 2019-08-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 324bdfed0692..27e2873765fa (1 commits) Created with: gclient setdep -r src/third_party/skia@4828620d0a30 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=benjaminwagner@google.com Bug: chromium:None Change-Id: Ifb7cf5316957d81e8716954256c7298a14b990ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730829Reviewed-by:
-
Joel Hockey authored
Currently loadTimeData.getBoolean('CROSTINI_ENABLED') is read in the foreground when a new window is started. This value is valid when the background is first started, but may become stale after CrostiniEvents for 'enable' or 'disable'. Update background page to listen for ENABLE/DISABLE events too, since we cannot assume that a foreground page is always open to relay them. Fixed CrostiniEvent to also always include vm_name. Test: browser_tests --gtest_filter="FilesApp*enableDisableCrostini*" Bug: 988371 Change-Id: Ie3888f529e12b70e1b934f50a3fe22035e78680e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728709 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:Noel Gordon <noel@chromium.org> Auto-Submit: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#683082}
-
Eli Ribble authored
Without this change when gsutil fails to download the data for a particular tarball we see a stacktrace. Now we'll see a nice message with potentially useful information from gsutil. This also adds the ability to see details of what update_sdk.py is doing by passing in "--verbose" at the commandline. Bug: 987325 Change-Id: Ic18ea878a9d7fb0427265517f01392503f4f9d77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717187 Commit-Queue: Eli Ribble <eliribble@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Auto-Submit: Eli Ribble <eliribble@chromium.org> Cr-Commit-Position: refs/heads/master@{#683081}
-
Alex Danilo authored
Feedback panels were visible on all active File Manager windows. Disable display of the panels if the File Picker is active which is deduced by using the 'type' of the main window body and using the existing CSS rule for visibility when the main body type is 'full-page' only. Also moves the panel location in the DOM to be contained by the dialog main panel in all cases so that positioning for layout will be relative to the dialog-main <div> rather than the 'dialog-container'. No-try: true Bug: 988193 Tests: browser_tests --gtest_filter="*PanelsDisabled". Change-Id: I5d152ab8a0d2cd7bf299c706223505da97ca7a27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1723572Reviewed-by:
Alex Danilo <adanilo@chromium.org> Reviewed-by:
-
Shuo-Peng Liao authored
PIXEL_FORMAT_MT21 maps to V4L2 fourcc format MT21, a proprietary format used for an intermediate frame between certain v4l2 video decoder and image processor. As long as we directly pass platform specific format via ImageProcessor::PortConfig, we shall remove the format which will not be seen outside platform specific implementation. BUG=985683 TEST=Run VDA_unittest and media_unittest on elm Change-Id: Ifb55f18d7cf71e6ea98749eff4d701cef30e472b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1723852 Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#683079}
-
Piotr Pawliczek authored
This is a fuzzer for ZeroconfPrinterDetector. Currently it works only with a set variable ASAN_OPTIONS=detect_odr_violation set to 0 or 1. According to OSS-Fuzz team, it is allowed and compatible with ClusterFuzz configuration. BUG=chromium:969666 TEST=tested locally on my workstation Change-Id: Ia614858c5f82e3b831d0c842f6f768b91149db45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1675686Reviewed-by:
Max Moroz <mmoroz@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Commit-Queue: Piotr Pawliczek <pawliczek@chromium.org> Auto-Submit: Piotr Pawliczek <pawliczek@chromium.org> Cr-Commit-Position: refs/heads/master@{#683078}
-
David Benjamin authored
Bug: none Change-Id: I6802b933c8d09f1d0d7f08abd11df13877c3e91d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1727436Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Carlos IL <carlosil@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#683077}
-
Ramin Halavati authored
No comments! Change-Id: Ibec9b76e384895a9376b3c6391c61f9327282e60 TBR: nicolaso@chromium.org Change-Id: Ibec9b76e384895a9376b3c6391c61f9327282e60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730151Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#683076}
-
Minggang Wang authored
This CL typemaps network.mojom.URLRequest with network::ResourceRequest for Blink variant. As it's the last CL of this series, the temporary url_request_for_blink.typemap will be deleted, and we will share the url_request.typemap used for Chromium variant. The final typemapping is: Before: none After: typemap with network::ResourceRequest This CL is part of a series of CLs which are targeted to typemap network.mojom.URLRequest with network::ResourceRequest for Blink variant finally. 1. https://chromium-review.googlesource.com/c/chromium/src/+/1669131 2. https://chromium-review.googlesource.com/c/chromium/src/+/1672768 3. https://chromium-review.googlesource.com/c/chromium/src/+/1680505 4. https://chromium-review.googlesource.com/c/chromium/src/+/1679984 5. This CL BUG=860403 Change-Id: I556712ff10efdc621fe46e019d24dd1ee4d8c419 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1683493Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
-
Eric Willigers authored
The Launch Service is used to open a new application window. TBR=avi@chromium.org Bug: 966288 Change-Id: Ibc7c1f49fa109335e81744ddda292a08f36b80a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1723794 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#683074}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/f3157c496d4b..2bd4cf346e06 git log f3157c496d4b..2bd4cf346e06 --date=short --no-merges --format='%ad %ae %s' 2019-08-01 rmhasan@google.com [Typ] Create a public static method in TestExpectations which finds unused expectation patterns Created with: gclient setdep -r src/third_party/catapult@2bd4cf346e06 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sadrul@google.com Bug: chromium:973936 Change-Id: Idfbbed3965076caced3f3322e8cf8216a2db18d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730750Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2880bd346d5c..5136bc88d5ae Created with: gclient setdep -r src-internal@5136bc88d5ae The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Iee1d8d756f632c1633e6a837d45b9d209f8b5637 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730752Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/588b4604c876..dcf3c07791fc git log 588b4604c876..dcf3c07791fc --date=short --no-merges --format='%ad %ae %s' 2019-08-01 hidehiko@chromium.org chromite: Run TastVMTest on betty-release. Created with: gclient setdep -r src/third_party/chromite@dcf3c07791fc The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Iabdf4e900c515a91fd7262ed4943f47faffb1f08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730751Reviewed-by:
-
Robert Ogden authored
It's not useful or used. Bug: 986522 Change-Id: Ic091ba24ea35e26e86750a722fa0a0dd22ef0039 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729532Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#683070}
-
David Benjamin authored
The CQ has been preventing changes that touch annotations.xml from landing: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8906385911867632656/+/steps/check_network_annotations__with_patch_/0/stdout There were problems with two of the entries. https://chromium-review.googlesource.com/c/chromium/src/+/1724519 fixed one of them, but then https://chromium-review.googlesource.com/c/chromium/src/+/1715304 reverted it in a mismerge. Additionally, https://chromium-review.googlesource.com/c/chromium/src/+/1726655 introduced a new instance. Fix them. Bug: none Change-Id: I254823c436a6fbffb2e20591c2ba1eb0346585ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729806 Auto-Submit: David Benjamin <davidben@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
-
