- 23 Aug, 2019 40 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b6e0bc79fa4e..4c555ee9b300 Created with: gclient setdep -r src-internal@4c555ee9b300 The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:991478 Change-Id: I4dab4ed77eddfa6f4cc031b7e73f8aea0627a5f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769145Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#690007}
-
minch authored
Delete not used LabelTrayView. Also DEFAULT_VIEW_LABEL and AddIconAndLabelForDefaultView that only used by this class. Also delete AddIconAndLabels, which is not used any more either. Bug: 982950 Change-Id: If1fd29d8273394ae0e38705c68ba7b53156a158c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764271Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Min Chen <minch@chromium.org> Cr-Commit-Position: refs/heads/master@{#690006}
-
Peter Boström authored
Bug: chromium:996915 Change-Id: Idd0a9b3c8d01af0c53d0fc52576a64025e655542 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769027 Commit-Queue: Robert Liao <robliao@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#690005}
-
Hwanseung Lee authored
Use enum class instead of enum for Wigdet::FrameType enum class is more type safety. Bug: 940736 Change-Id: I2242ea272731a6136ee0e48ce7a66495ed70fed2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1767292 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#690004}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/e7aecaad3386..0a07831a9da9 git log e7aecaad3386..0a07831a9da9 --date=short --no-merges --format='%ad %ae %s' 2019-08-23 hjd@google.com Merge "Make checkerboard boarding full height" Created with: gclient setdep -r src/third_party/perfetto@0a07831a9da9 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Bug: None Change-Id: I13437cdccdeb0e29eda6f4690748419a42dfeb35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769144Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#690003}
-
Jeevan Shikaram authored
This CL copies files from c/b/r/app_management into c/b/r/settings/chromeos/os_apps_page/app_management_page. Bug: 979531 Change-Id: Ibfb4cdb7201743f86c6601b8a1c97f2bd0f6a597 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752497 Commit-Queue: Jeevan Shikaram <jshikaram@chromium.org> Auto-Submit: Jeevan Shikaram <jshikaram@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#690002}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/94dbee77eb6c..afad531cd256 git log 94dbee77eb6c..afad531cd256 --date=short --no-merges --format='%ad %ae %s' 2019-08-23 dhanyaganesh@chromium.org config: Mark mistral as experimental Created with: gclient setdep -r src/third_party/chromite@afad531cd256 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I27905cd9f05d0112b6aa6e079f993bb42f82914c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769140Reviewed-by:
-
Erik Chen authored
There are several call sites that call WebView::MainFrameWidget()->Close() when they actually intend to call WebView::Close(). This happens to work because WebView::MainFrameWidget() currently returns itself, but will break when MainFrameWidget() is updated to return a real frame widget. Bug: 995981, 419087 Change-Id: I69068b86ce4af81766076a56349e999d675e67cb TBR: blundell@chromium.org, rockot@chromium.org, dalecurtis@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1767104 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Auto-Submit: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#690000}
-
Robert Ogden authored
Bug: 996870 Change-Id: I26b329130c19ff8cf9811e5ac504e2c358669a83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1766253Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#689999}
-
Robert Liao authored
No one seems to use subtitles or sublabels. BUG=865318 Change-Id: Ia850adabeab5aa280b2730e2a4177ac7a9f8d0cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764883 Auto-Submit: Robert Liao <robliao@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#689998}
-
Sophie Chang authored
This is pretty much guaranteed for DataSaver users to always happen and this reduces the likelihood of the race condition between data updates being in flight Bug: 997106 Change-Id: If2d827e9dc74e93dc8d203a6f7aa27cd590d617f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768819Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#689997}
-
Moe Ahmadi authored
- Adds NTP_REALBOX page classification to BaseSearchProvider::IsNTPPage() and makes it a public static method to use in AutocompleteResult. - Makes the logic to fall back to most visited site for zero suggest mobile only as there are currently no zero suggest experiments on Desktop and CrOS is handled differently. Bug: 996516 Change-Id: I25c33ea961a0afb53abe33f3326696160c6dc3f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1767605 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#689996}
-
Chris Harrelson authored
It has been in stable for a few releases now. Change-Id: Id550a5c03b6a5c0575df47ca313ca2d754d8a0f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1766449Reviewed-by:
Fergal Daly <fergal@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#689995}
-
Donn Denman authored
Adds another option to the Longpress Activation Chrome Flag to preserve Tap activation. Without it, the Tap gesture will no longer trigger Contextual Search. Also fix some minor bugs: 1) preserve the longpress selection even after the panel is closed. 2) fix a crash with Tap after a longpress selection triggered. 3) tap with existing longpress selection should not select. BUG=956277, 959040 Change-Id: I3c351a0227b55c996b645cb76e08976ce36a61e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764187Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#689994}
-
Xida Chen authored
sadrul@ is already reviewing a lot of metrics related code, this CL adds him as an owner. Bug: None Change-Id: Ifc4fca00f9128f28c669f64116465087ead3b4a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769053Reviewed-by:
enne <enne@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#689993}
-
James Cook authored
It just needs some margin on the top. Before: http://screen/z71qzJj0EJH After: http://screen/Nw4HWw6FUyC Bug: 996499 Change-Id: I3eacf6e23aa59b88794ef97fa11c37dbfda7cf84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769052 Commit-Queue: James Cook <jamescook@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Auto-Submit: James Cook <jamescook@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/60eaabde..9499165e Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I15dd5f8c4ce7af6bf003586e5b34f56f0a36479c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768783Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#689991}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/115cfe7a1b32..d6dc4b7e4533 git log 115cfe7a1b32..d6dc4b7e4533 --date=short --no-merges --format='%ad %ae %s' 2019-08-23 chrisforbes@google.com Store subpass index in ExecutionState, not in RenderPass Created with: gclient setdep -r src/third_party/swiftshader@d6dc4b7e4533 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: chromium:b/139824232 Change-Id: Id8bdaab75c9ff8d6c2f8269fc24527484302f2a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769156Reviewed-by:
-
Michael Crouse authored
Change-Id: Ie668ce7703601be8f64b9cc2557404f05203fdb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769219 Auto-Submit: Michael Crouse <mcrouse@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#689989}
-
Nicolás Peña Moreno authored
This CL makes the code align with making Exposed mandatory for interfaces. See the following for more details: https://github.com/web-platform-tests/wpt/pull/18382 https://github.com/heycam/webidl/pull/423 Change-Id: I293e80cd0d953f2f47480f838eecd5f588ec6d80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768918Reviewed-by:
Luke Bj <lukebjerring@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#689988}
-
Vladislav Kaznacheev authored
1. When creating AppList, delay bounds snapping until the widget has non-empty bounds 2. Add bounds snapping to AppListView::GetPreferredWidgetBoundsForState Bug: 995995 Test: manual Change-Id: I50def74367d33053fc1ce350efaf19c01f6255a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1767082 Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#689987}
-
Ken Rockot authored
Renderer processes currently get all of their process-scoped interfaces through a Connector. This moves them over to the ChildProcessHost API which routes directly from the ChildThreadImpl to an IO-thread binding associated with RenderProcessHostImpl. The IO-thread BinderRegistry for RPHI is moved from ConnectionFilterImpl to the IOThreadHostImpl to support this. The few Blink callsites which use GetConnector()+GetBrowserServiceName() have been updated to use a new Platform::GetBrowserInterfaceBrokerProxy() API which returns a pointer to the new ThreadSafeBrowserInterfaceBrokerProxy type. This type looks and feels similar to BrowserInterfaceBrokerProxy, but can be used from any thread. Thread-safety is a useful feature for process-scoped interface binding, but incurs slight overhead that is not necessary for context-scoped binding requests; hence the new type. As of this CL, use of Platform::GetInterfaceProvider() is equivalent to Platform::GetThreadSafeBrowserInterfaceBrokerProxy() in terms of where the requests get routed on the browser side, so the former can be incrementally converted to the latter. All dependencies on Connector and deprecated Service Manager service names have been removed from Blink. Follow-up CLs will remove the few remaining Connector dependencies from content/renderer and other child process types, and convert all GetInterfaceProvider() callsites to use GetBrowserInterfaceBrokerProxy() instead. Bug: 977637 Change-Id: I60ec171002df812b7ad34b0d87fa972910620fa2 Tbr: yucliu@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763226Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Patrick Monette <pmonette@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#689986}
-
Maksim Moskvitin authored
We are going to persist sync_pb::NigoriLocalData using blocking writes with ImportantFileWriter. To simplify initialization of NigoriSyncBridgeImpl for testing and testing of persistence itself, we add new interface to wrap file-related logic. Bug: 922900 Change-Id: I09d608ec45d6f4d94068f5c52ee93af24fe70da1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731946 Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#689985}
-
Charlie Harrison authored
Bug: 975411, 975641 Change-Id: I2de34b8a0d9e2f9acc4bea4538eafc94276eed06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763195 Auto-Submit: Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Commit-Queue: Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#689984}
-
Tommy Li authored
ZeroSuggestProvider / RemoteSuggestionsService likely will not need custom endpoint support anymore, so remove it from the code. Bug: 995393 Change-Id: Ifa0ad89ac8d71679cdc6c0563790f7600ba9f5af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761063Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#689983}
-
Raymond Toy authored
WebAudio legacy code often does something like: DCHECK(foo); if (!foo) return; The style guide says the if/return should be removed; DCHECK failures should not be handled. Part 4 of N: Update a few more files and for the most obvious cases where we can remove the if/return. Bug: 957654 Change-Id: I85c8c87e02b319ea1fa95768b7297500d36a0d6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762763 Commit-Queue: Raymond Toy <rtoy@chromium.org> Reviewed-by:Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#689982}
-
Jeroen Dhollander authored
Previously we used |std::shared_ptr| but a new pre-submit check blocks that meaning we can not create new code using |AssistantInteractionModelObserver| until this API is modified to use |scoped_refptr|. This is required for crrev.com/c/17564278 Change-Id: Id5963917160dee2761a35cb933e02616cc823122 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1766451 Commit-Queue: Jeroen Dhollander <jeroendh@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
-
Bettina authored
The call to SecurityEventRecorder causes Chrome to throw a segmentation fault. Commenting out to be able to allow non-sync password protection to be available in dev/canary. Bug: 914410 Change-Id: I67c5deef7f206fac204b9fe459be2ac15dd958ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1765995 Commit-Queue: Bettina Dea <bdea@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#689980}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/65f775037b67..0f15d7373bf1 git log 65f775037b67..0f15d7373bf1 --date=short --no-merges --format='%ad %ae %s' 2019-08-23 reed@google.com optimize verts Created with: gclient setdep -r src/third_party/skia@0f15d7373bf1 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=egdaniel@google.com Bug: None Change-Id: Ic891e4ee3093cc97a609654c2c0f8f1b3be72dbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769010Reviewed-by:
-
Mason Freed authored
Prior to this CL, and after [1], the mask_type() field of the PictureLayer created by UpdateMaskLayer was not properly set. This meant that for large masks, the standard tiling logic kicked in and tiled the mask, which (after [1]) was not supported and resulted in a DCHECK and/or the mask not properly being applied. This fixes that bug. I also added a backdrop-filter/mask test with a large mask to ensure this works. [1] https://chromium.googlesource.com/chromium/src/+/310cae44aff889a75fc85ce5ec89d9341eccc665 Bug: 992782 Change-Id: Ibc461638abdeedd8ff9f4730a1e81f6442400bd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764679 Commit-Queue: Mason Freed <masonfreed@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Reviewed-by:
-
Toby Huang authored
MixinBasedInProcessBrowserTest is a lightweight descendant of InProcessBrowserTest (IPBT) that can be used as a base class whenever IPBT is used as a base class. I moved MixinBasedInProcessBrowserTest into chrome/base/test/ and out of the chromeos namespace to match IPBT. This change would enable a wider scope of tests to use mixin functionality. Bug: 990542 Change-Id: I1f3510fb4726732a8e4f181d301d9bfb7c8075ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1747643Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Denis Kuznetsov <antrim@chromium.org> Reviewed-by:
-
Lucas Furukawa Gadani authored
This CL adds a new parser, as well as a fuzzer to the network service. In the future, it'll be used to parse incoming CSP headers to allow enforcing of frame-ancestors in the browser process. Bug: 759184 Change-Id: Idd6f1e73e8ed801e6add35105a0ad849eaeb0262 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1682265 Commit-Queue: Lucas Gadani <lfg@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#689976}
-
Andres Calderon Jaramillo authored
This CL adds the Renderer4.{Browser,Renderer}.RasterTaskSchedulingDelay UMAs which measure the wall time elapsed between creating a raster task in the client and being ready to issue raster work to the driver in the GPU process. The beginning timestamp is obtained by recording the creation time of a RasterBufferImpl in the renderer (which should practically coincide with the creation of the raster tasks). The end timestamp is obtained using a GL_COMMANDS_ISSUED_TIMESTAMP_CHROMIUM command buffer query. The motivation is to make sure that hardware accelerated image decodes do not make this part of the rendering pipeline regress. Therefore, these UMAs are only computed and recorded in Chrome OS and when OOP-R is enabled. Bug: 995155 Test: coverage for the new UMA. Change-Id: I51d4b2d87c07577ca5f710d94a15dac2e4312ce9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1753583 Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Reviewed-by:Brian White <bcwhite@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#689975}
-
Lei Zhang authored
CreatePrinterHandlerTaskRunner(), which was added in https://crrev.com/658397, used ifdefs to only handle the supported build configs. Add a #else case as a catch-all to conservatively handle the unsupported configs. Since it is only a couple lines of trivial code, doing this does not create much of a maintenance burden. Bug: 990727 Change-Id: I07bd21abaeffc8223e88b519c3891185d5d2be12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1765998Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#689974}
-
Alex Cooper authored
TBR=grt@chromium.org Change-Id: I7ccc19d5cf5d4956b534f7ca3ebd72bf3cb68b4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769043Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Commit-Queue: Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#689973}
-
Joe DeBlasio authored
This CL mostly reverts crrev/c/1717191, but includes updated strings. The interstitial now looks like this: https://storage.cloud.google.com/chromium-translation-screenshots/a0e10eb89867355fc98c930e468397e8dadf4f17 Bug: 996794 Change-Id: Ib5b85f16184bab7cbad955d07a75b648b6f34b7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1765661 Auto-Submit: Joe DeBlasio <jdeblasio@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Cr-Commit-Position: refs/heads/master@{#689972}
-
Tomasz Wiszkowski authored
Add metric counting how frequently - and what kind of suggestions our users delete. Bug: 991430 Change-Id: Iea6a65e08829149ac8607cfaee84e2c7652f9eee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1746759Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Ender <ender@google.com> Cr-Commit-Position: refs/heads/master@{#689971}
-
Darin Fisher authored
This is in preparation for fixing bug 989458. The main change is to make the dependencies between the various files no longer circular. This makes the code and state transitions a bit easier to follow. A bunch of types are extracted out of webrtc_logging_handler_host.h and into webrtc_log_uploader.h. This makes WebRtcLoggingHandlerHost more cleanly the "frontend" part of the logging system, and WebRtcLogUploader and its associated types as the lowest level "backend" part. WebRtcLogBuffer is extracted out into its own header file since it is needed at various levels and from places that don't need to depend on webrtc_log_uploader.h. Also cleans up some stale comments about code running on the IO thread that now only runs on the UI thread. Simplifies StartRtcDump method and hides WeakPtr capability of WebRtcLoggingHandlerHost. Cleans up a few other random small things. Bug: 989458 Change-Id: I997c04d535114801029f077357e975c95b0bd7e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762465 Commit-Queue: Darin Fisher <darin@chromium.org> Reviewed-by:
Tommi <tommi@chromium.org> Cr-Commit-Position: refs/heads/master@{#689970}
-
Jonah Chin authored
Due to using the actual constructed layoutObject font (which already has zoom applied) for font-sizes measured in ex and ch, we end up applying zoom twice. This problem was specific to the use of ex and ch measurements on fonts, and not on other html components. This patch involves factoring out a single zoom where ex and ch sizing is applied to a font. Bug: 408777 Change-Id: If9ae7e9efcca472ca7518b7c7d62537e6842bac9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752935 Commit-Queue: Jonah Chin <jochin@microsoft.com> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#689969}
-
Dana Fried authored
Label text was previously middle-aligned even in the multiline case, despite our text renderer being able to render all vertical alignments. This caused hover card titles to animate vertically and be cut off strangely during transitions between tabs with different numbers of title lines. This CL adds the ability to support vertical alignment for multiline labels, and then aligns the title label on the hover card to ALIGN_TOP so that during transitions from a hover card with one line to one with two title lines results in the first line of the title staying in place while the bottom line is revealed during the animation, which is far more visually pleasing. Because RenderText does not yet support vertical alignment for single- line text, DCHECK guards have been added (as they were previously added to prevent incompatibility between multiline and elision mode) and also TODO reminders to extend functionality to single-line in the future. Bug: 984963, 996905 Change-Id: Ibd2ef6a3c8502a272654b673f83893e06ac5fb53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764942 Auto-Submit: Dana Fried <dfried@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#689968}
-
