GitLab

They are failing with timeout on linux.

TBRing the most recent author

BUG=725455
TBR=shalamov
NOTRY=TRUE

Review-Url: https://codereview.chromium.org/2896253002
Cr-Commit-Position: refs/heads/master@{#473877}

This CL builds upon the previous refactorings to implement support for
the latest drafts (which is WGLC) of the Web Push Encryption scheme.

Support is not yet enabled for incoming messages - since the message
format changed slightly as well, a more trivial update to
GCMEncryptionProvider is necessary as well.

BUG=679789

Review-Url: https://codereview.chromium.org/2716443002
Cr-Commit-Position: refs/heads/master@{#473876}

BUG=569158
R=sdefresne@chromium.org
CC=thakis@chromium.org

Review-Url: https://codereview.chromium.org/2897013002
Cr-Commit-Position: refs/heads/master@{#473875}

Network traffic annotation tags are stored in url_request.

BUG=656607

Review-Url: https://codereview.chromium.org/2890293005
Cr-Commit-Position: refs/heads/master@{#473874}

There is a check in the tracker to ignore processes with a create-
time greater or equal than the current time in order to not mistake
a currently-running process that has reused a PID for an exited
one.

BUG=723060

Review-Url: https://codereview.chromium.org/2894933002
Cr-Commit-Position: refs/heads/master@{#473873}

Since |selection_start| is always before |selection_end|(L322),
 we don't need to switch back traversing.

Patch[1] introduced the backward traversal to support CSS Region.
Since, Blink doesn't support CSS Region, we can remove it safely.

[1] https://chromiumcodereview.appspot.com/23674007 [CSSRegions] Not possible to
clear the selection when mixing content from different FlowThreads

BUG=708453

Review-Url: https://codereview.chromium.org/2895193002
Cr-Commit-Position: refs/heads/master@{#473872}

In MultiProcess mode the WebView renderer process can crash without
bringing down the browser process.
Such a crash causes a minidump to be generated - with this CL that
minidump is handled (copied, later to be uploaded) quickly after the
renderer process crash instead of during the next WebView startup.

BUG=674145

Review-Url: https://codereview.chromium.org/2833893002
Cr-Commit-Position: refs/heads/master@{#473871}

It is failing and culprit is still unknown.

TBRing least ancient author of the test.

BUG=725470
NOTRY=TRUE
TBR=shinyak

Review-Url: https://codereview.chromium.org/2901803002
Cr-Commit-Position: refs/heads/master@{#473870}

The content/browser/crash/ component calls into the java-side of
CrashDumpManager from
components/crash/content/browser/crash_dump_manager_android.cc, since
WebView doesn't include that java file it throws an exception at that
point.
This CL Includes the content/browser/crash/ component into Android
WebView.

BUG=725207

Review-Url: https://codereview.chromium.org/2900793003
Cr-Commit-Position: refs/heads/master@{#473869}

-[BookmarkFolderCollectionView cellSizeForIndexPath:] can use the
current cell to compute its height when reloading. So when
BookmarkFolderCollectionView receives the notification to update the
SigninPromoView, the view has to be updated even if the section is
reloaded.

BUG=725040

Review-Url: https://codereview.chromium.org/2895173003
Cr-Commit-Position: refs/heads/master@{#473868}

This fixes the regression where real-world throttling regressed to
two-seconds task alignment instead of one-second alignment.
This patch also improves test coverage for background throttling.

BUG=722410

Review-Url: https://codereview.chromium.org/2896603002
Cr-Original-Commit-Position: refs/heads/master@{#473609}
Committed: https://chromium.googlesource.com/chromium/src/+/188fc72030f13187af5cff7e9802f3abebdea017
Review-Url: https://codereview.chromium.org/2896603002
Cr-Commit-Position: refs/heads/master@{#473867}

ExecuteSelectToMark() is changed to use SetSelection()
instead of SetSelectedRange().

BUG=721190

Review-Url: https://codereview.chromium.org/2898893002
Cr-Commit-Position: refs/heads/master@{#473866}

to unblock the tree

BUG=725455
TBR=device-dev@chromium.org
NOTRY=True

Review-Url: https://codereview.chromium.org/2898943002
Cr-Commit-Position: refs/heads/master@{#473865}

BUG=724710

Review-Url: https://codereview.chromium.org/2899863002
Cr-Commit-Position: refs/heads/master@{#473864}

BUG=661608

Review-Url: https://codereview.chromium.org/2899473003
Cr-Commit-Position: refs/heads/master@{#473863}

Updated the enum in proto to be according to the rules from
https://engdoc.corp.google.com/eng/doc/devguide/proto/index.md?cl=head

BUG=722371

Review-Url: https://codereview.chromium.org/2898683002
Cr-Commit-Position: refs/heads/master@{#473862}

Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/433b35c..7427e1c

$ git log 433b35c..7427e1c --date=short --no-merges --format=%ad %ae %s
2017-05-22 peah@webrtc.org Field trial support to whenever possible turn off the AGC and HPF
2017-05-22 deadbeef@webrtc.org Fixing potential AsyncInvoker deadlock that occurs for "reentrant" invocations.
2017-05-22 perkj@webrtc.org Replace AudioSendStream::Config with rtclog::StreamConfig.
2017-05-22 perkj@webrtc.org Replace AudioReceiveStream::Config with rtclog::StreamConfig.
2017-05-22 alessiob@webrtc.org This CL introduces a new APM sub-module named AGC2 that does not use the band split domain and only implements floating point operations (to avoid spectral leakage issues and unnecessary complexity).

TBR=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng
BUG=

Review-Url: https://codereview.chromium.org/2904473002
Cr-Commit-Position: refs/heads/master@{#473861}

Network traffic annotation is added to network request of:
chrome/browser/search/one_google_bar/one_google_bar_fetcher_impl.cc

BUG=656607

Review-Url: https://codereview.chromium.org/2900673002
Cr-Commit-Position: refs/heads/master@{#473860}

FontList::Derive(..) is slow (typically requiring IPC with the font
server), has unpredictable results with special UI fonts on Mac, and
encourages use of magic numbers like "-1".

Instead, use context and style constants from the Chrome typography
spec, where available. When an equivalent font is not available, use
ResourceBundle to avoid a behavior change in this CL.

BUG=721834

Review-Url: https://codereview.chromium.org/2899653002
Cr-Original-Commit-Position: refs/heads/master@{#473764}
Committed: https://chromium.googlesource.com/chromium/src/+/424d27cceaba0271bc21e9c9b48a39e4d5a2b21f
Review-Url: https://codereview.chromium.org/2899653002
Cr-Commit-Position: refs/heads/master@{#473859}

This change adds a counter to measure usages of only providing
CredentialRequestOptions.unmediated.

BUG=721399

Review-Url: https://codereview.chromium.org/2899763002
Cr-Commit-Position: refs/heads/master@{#473858}

Previously the buttons were very wide, but not high enough. Moreover, some were too close to each other.

Please see screenshots in the bug.

BUG=724080
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2893933002
Cr-Commit-Position: refs/heads/master@{#473857}

Removing the special case for fd > 1023 which can lead to audio glitches.

Code originally written by ossu@.

BUG=722720

Review-Url: https://codereview.chromium.org/2888403005
Cr-Commit-Position: refs/heads/master@{#473856}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/b75b7a46..51b8af19

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2898143002
Cr-Commit-Position: refs/heads/master@{#473855}

This patch removes StyleRareInheritedData.cpp, and moves all its contents to be
inline in StyleRareInheritedData.h

This is prework for generating StyleRareInheritedData.

BUG=628043

Review-Url: https://codereview.chromium.org/2885033006
Cr-Commit-Position: refs/heads/master@{#473854}

Currently we record number of suggestions per section on NTP opened
(CountOnNTPOpened). However, recently we needed to check how many times
the user sees only one section.

This CL adds a new metric SectionCountOnNTPOpened to record number of
visible sections on each NTP.

BUG=721276

Review-Url: https://codereview.chromium.org/2886723002
Cr-Commit-Position: refs/heads/master@{#473853}

Aliases like ios-reviews+clean and ios-reviews+showcase are already
covering my use case.

BUG=none
R=sdefresne@chromium.org

Review-Url: https://codereview.chromium.org/2897843003
Cr-Commit-Position: refs/heads/master@{#473852}

crrev.com/2676663006 removed SetWrapperReferenceTo.
Removing it from the idl definitions as it is not used anywhere.

BUG=

Review-Url: https://codereview.chromium.org/2897003002
Cr-Commit-Position: refs/heads/master@{#473851}

It is flaky.

TBRing the most recent author

TBR=dmazzoni
NOTRY=TRUE
BUG=725420

Review-Url: https://codereview.chromium.org/2904463002
Cr-Commit-Position: refs/heads/master@{#473850}

Bug: 724905
Change-Id: Ic813e70973ba9aef1c88278e51d4424547d245b8
Reviewed-on: https://chromium-review.googlesource.com/509409Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Commit-Queue: Sam McNally <sammc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#473849}

Remove the exclusion of beta and stable channels in
EnrollmentHandlerChromeOS.

BUG=668119

Review-Url: https://codereview.chromium.org/2899983002
Cr-Commit-Position: refs/heads/master@{#473848}

ExecuteDeleteToMark function is changed to use SetSelection instead of
SetSelectedRange.

BUG=721190

Review-Url: https://codereview.chromium.org/2900773002
Cr-Commit-Position: refs/heads/master@{#473847}

Element.styleSheets and ShadowRoot.styleSheets need to be made up-to-
date on access. We used to do a full active style update, but re-
collecting the stylesheet list should be enough, leaving the active
style dirty flags intact.

We introduce a dirty-flag for the stylesheet list in
StyleSheetCollection to avoid repeatedly re-collecting this list while
the active style is still dirty.

This coincidentally fixes issue 722826 since we do not collect
stylesheets in import shadow trees as part of the active style update,
but is now made up-to-date on request when accessing the styleSheets
collection on shadow roots inside import documents.

This fixes the performance issue 717506.

R=meade@chromium.org
BUG=717506,722826

Review-Url: https://codereview.chromium.org/2884993002
Cr-Commit-Position: refs/heads/master@{#473846}

This patch removes order dependent checks for EBorderStyle and replaces
them with checks that check that properties aren't equal to a certain
value.

BUG=684966

Review-Url: https://codereview.chromium.org/2896783002
Cr-Commit-Position: refs/heads/master@{#473845}

BUG=681523

Review-Url: https://codereview.chromium.org/2898903002
Cr-Commit-Position: refs/heads/master@{#473844}

The dialog should only be shown for cookies and not if just a cache
deletion is selected.

BUG=698692
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2897863003
Cr-Commit-Position: refs/heads/master@{#473843}

If the selection doesn't have focus, it shouldn't be the target
of the context menu.

For example, an _unfocused_ range selection should not be the
context menu's target (the focused element should be the target).

BUG=725005, 725022

Review-Url: https://codereview.chromium.org/2880313002
Cr-Commit-Position: refs/heads/master@{#473842}

I would like to have the error message itself but at least having the
name to look up would be a plus.

BUG=None
TEST=ran with migration to get:
[26113:26113:0522/140542.513399:ERROR:device_event_log_impl.cc(156)] [14:05:42.513] Login: homedir_methods.cc:414 HomedirMethods MountEx error (CryptohomeErrorCode): 29
[26113:26113:0522/140542.513532:ERROR:device_event_log_impl.cc(156)] [14:05:42.513] Login: cryptohome_authenticator.cc:909 Cryptohome failure: state(AuthState)=24, code(cryptohome::MountError)=128

Review-Url: https://codereview.chromium.org/2897813003
Cr-Commit-Position: refs/heads/master@{#473841}

There are LayoutText::AbsoluteRectsForRange() and AbsoluteQuadsForRange().
The former collects IntRect and the later collects FloatQuad
 through very similar algorithm.

The only difference between two is the former converts from FloatQuad,
 which is just the later collects, to IntRect with EnclosingBoundingBox().
Since we collects rects and unify all of them, it is OK to refactor
 from "UnifyIntRect(float_quads.Map(f => f.EnclosingBoundingBox()))"
 to "UnifyFloatRect(float_quads).EnclosingBoundingBox())".

BUG=

Review-Url: https://codereview.chromium.org/2904433002
Cr-Commit-Position: refs/heads/master@{#473840}

Revert of Remove uses of FontList::Derive*(..) in views payments dialogs. (patchset #4 id:60001 of https://codereview.chromium.org/2899653002/ )

Reason for revert:
Breaks compilation
see crbug.com/725407

Original issue's description:
> Remove uses of FontList::Derive*(..) in views payments dialogs.
>
> FontList::Derive(..) is slow (typically requiring IPC with the font
> server), has unpredictable results with special UI fonts on Mac, and
> encourages use of magic numbers like "-1".
>
> Instead, use context and style constants from the Chrome typography
> spec, where available. When an equivalent font is not available, use
> ResourceBundle to avoid a behavior change in this CL.
>
> BUG=721834
>
> Review-Url: https://codereview.chromium.org/2899653002
> Cr-Commit-Position: refs/heads/master@{#473764}
> Committed: https://chromium.googlesource.com/chromium/src/+/424d27cceaba0271bc21e9c9b48a39e4d5a2b21f

TBR=anthonyvd@chromium.org,pkasting@chromium.org,tapted@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=721834

Review-Url: https://codereview.chromium.org/2901763002
Cr-Commit-Position: refs/heads/master@{#473839}

Previously all MessageView had an own layer. And now, by http://crrev.com/2849523005, only non-popup MessageView, which is in the message center, has a layer.

But it causes a regression (http://crbug.com/722647) so this CL reverts that part.

This CL breaks swiping on popup but it'll be fixed soon by http://crrev.com/2873553002.

BUG=722647
TEST=manual (issue doesn't happen)

Review-Url: https://codereview.chromium.org/2880243003
Cr-Commit-Position: refs/heads/master@{#473838}