GitLab

BUG=417275

Review URL: https://codereview.chromium.org/660463002

git-svn-id: svn://svn.chromium.org/blink/trunk@183734 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Update the UI to display "Paused on promise rejection" status instead
of "Paused on exception" when appropriate.

R=pfeldman@chromium.org, yurys@chromium.org

Review URL: https://codereview.chromium.org/651533003

git-svn-id: svn://svn.chromium.org/blink/trunk@183733 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Only used in SVGTextRunRenderingContext::drawSVGGlyphs. Fold up and
simplify. Clean up some includes.

BUG=420022

Review URL: https://codereview.chromium.org/657553002

git-svn-id: svn://svn.chromium.org/blink/trunk@183732 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=420492
R=sigbjornf@opera.com

Review URL: https://codereview.chromium.org/656653003

git-svn-id: svn://svn.chromium.org/blink/trunk@183731 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Make sure DatabaseThread::m_openDatabaseSet has no backing store
when a database thread is terminated.
m_openDatabaseSet outlives a database thread, and its backing store
is allocated in the database thread.  So, we should unlink the
backing store before the thread termination.

* DatabaseThread::cleanupDatabaseThread
 It's possible m_openDatabaseSet.size() is zero and
 m_openDatabaseSet still has backing store in the following scenario:
  1. A web page opens a database.  m_openDatabaseSet has it.
  2. Chromium calls DatabaseTracker::closeDatabasesImmediately()
  3. It calls m_openDatabaseSet.remove().

* DatabaseThread::recordDatabaseOpen
  Don't add a Database object after termination request.
  I think this can't happen. But we change it just in case.

This CL has no tests. It's very hard to make an automated test for the
scenario.

BUG=423271

Review URL: https://codereview.chromium.org/657023003

git-svn-id: svn://svn.chromium.org/blink/trunk@183730 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=360466
TEST=added form-pseudo-valid-style.html layout test

Review URL: https://codereview.chromium.org/646543004

git-svn-id: svn://svn.chromium.org/blink/trunk@183729 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL removes member variables of PumpSession, as they are no longer used.
Since r183572, all asynchronous parsing uses background thread and these
state variables were only used for deprecated asynchronous main thread parsing.

BUG=421189

Review URL: https://codereview.chromium.org/657753002

git-svn-id: svn://svn.chromium.org/blink/trunk@183728 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=388375
TEST=n/a

Review URL: https://codereview.chromium.org/653813002

git-svn-id: svn://svn.chromium.org/blink/trunk@183727 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=183720

BUG=409503
TBR=tkent@chromium.org

Review URL: https://codereview.chromium.org/653333003

git-svn-id: svn://svn.chromium.org/blink/trunk@183726 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Since r183572, SynchronousMode is alywas ForceSynchronous, as all
asynchronous parsing now uses background thread.

This CL removes the enum and removes dead codes.

BUG=421289

Review URL: https://codereview.chromium.org/659713002

git-svn-id: svn://svn.chromium.org/blink/trunk@183725 bbb929c8-8fbe-4397-9dbb-9b2b20218538

NOTRY=true
BUG=417275

Review URL: https://codereview.chromium.org/596323002

git-svn-id: svn://svn.chromium.org/blink/trunk@183724 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=413249
TBR=loislo@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/658683002

git-svn-id: svn://svn.chromium.org/blink/trunk@183723 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=412737

Review URL: https://codereview.chromium.org/654923002

git-svn-id: svn://svn.chromium.org/blink/trunk@183722 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The NodeList hierarchy is accessed only by the main thread.
Given that NodeList is performance-sensitive in various benchmarks in blink_perf,
this CL explicitly marks the NodeList hierarchy MainThreadOnly.

BUG=420515

Review URL: https://codereview.chromium.org/646833003

git-svn-id: svn://svn.chromium.org/blink/trunk@183721 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Update some tests in fast/forms/suggestion-picker/ so that they use
openPicker() instead of openPickerWithMock().

BUG=409503

Review URL: https://codereview.chromium.org/633823003

git-svn-id: svn://svn.chromium.org/blink/trunk@183720 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=413249
TBR=loislo@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/650783004

git-svn-id: svn://svn.chromium.org/blink/trunk@183719 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Service Workers' Cache API lets authors to fully manage their content caches for offline use.
https://slightlyoff.github.io/ServiceWorker/spec/service_worker/#cache-objects
But Service Worker is planned to be shipped without this API for the first launch.
So we add its own runtime enabled feature.

BUG=423601

Review URL: https://codereview.chromium.org/657723002

git-svn-id: svn://svn.chromium.org/blink/trunk@183718 bbb929c8-8fbe-4397-9dbb-9b2b20218538

A [TypeChecking=interface] attribute has been checked already in its setter. 
If it is not nullable, just call toImpl instead of toImplWithTypeCheck to avoid 
redundant type check.

This change can improve performance and save power.

BUG=

Review URL: https://codereview.chromium.org/654473002

git-svn-id: svn://svn.chromium.org/blink/trunk@183717 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Fix bug in line layout where it was incorrectly assumed that trailing
spaces would always be measured with the simple font code path.

R=chrishtr@chromium.org
BUG=423274
TEST=fast/text/international/complex-text-trailing-space.html

Review URL: https://codereview.chromium.org/655073002

git-svn-id: svn://svn.chromium.org/blink/trunk@183716 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Since r183572, the flag is always true.
This CL removes the flag and dead codes referencing the flag.

BUG=421289

Review URL: https://codereview.chromium.org/657453003

git-svn-id: svn://svn.chromium.org/blink/trunk@183715 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=183710

BUG=409503
TBR=tkent@chromium.org

Review URL: https://codereview.chromium.org/654083004

git-svn-id: svn://svn.chromium.org/blink/trunk@183714 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Together with the Chromium-side patch, makes top controls work properly
under the virtual viewport mode of pinch zoom. The key changes on the
Blink side are to adjust both the PinchViewport and FrameView max scroll
bounds to account for the change in the top controls offset on the
compositor. Additionally, I changed these to make the same floating point
and snapping calculations as in the compositor to prevent losing pixel
fractions.

Chromium side: https://codereview.chromium.org/641873003/

Note, this was previously landed in 183639 and reverted in 183653 due
to failing tests on Mac bots.

BUG=364109

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183639

Review URL: https://codereview.chromium.org/643473002

git-svn-id: svn://svn.chromium.org/blink/trunk@183713 bbb929c8-8fbe-4397-9dbb-9b2b20218538

On Android, a premultiplied ImageBuffer source has RGBA pixels. Import
its bitmap for encoding in that form, rather than BGRA.

Covered by fast/canvas/canvas-toDataURL-webp.html

BUG=421454

Review URL: https://codereview.chromium.org/645333002

git-svn-id: svn://svn.chromium.org/blink/trunk@183712 bbb929c8-8fbe-4397-9dbb-9b2b20218538

My patch https://src.chromium.org/viewvc/blink?view=rev&revision=183623
wrongly assumed that the fullscreen element was on the main frame.  Use
the frame tracked by FullscreenController instead.

NOTRY=true
BUG=423457

Review URL: https://codereview.chromium.org/647343003

git-svn-id: svn://svn.chromium.org/blink/trunk@183711 bbb929c8-8fbe-4397-9dbb-9b2b20218538

If we switch openPicker() in date-suggestion-picker-key-operations.html, it
crashes in PageAnimator::serviceScriptedAnimations because Page is deleted in an
event handler. We need to protect the PageAnimator.

BUG=409503,421321

Review URL: https://codereview.chromium.org/637243002

git-svn-id: svn://svn.chromium.org/blink/trunk@183710 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=412088

Review URL: https://codereview.chromium.org/648423002

git-svn-id: svn://svn.chromium.org/blink/trunk@183709 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=358271
TEST=existing EME tests still pass + private tests

Review URL: https://codereview.chromium.org/621903003

git-svn-id: svn://svn.chromium.org/blink/trunk@183708 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=183698

BUG=396825
TBR=robhogan@gmail.com

Review URL: https://codereview.chromium.org/641053005

git-svn-id: svn://svn.chromium.org/blink/trunk@183707 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=183698

BUG=396825
TBR=robhogan@gmail.com

Review URL: https://codereview.chromium.org/654843006

git-svn-id: svn://svn.chromium.org/blink/trunk@183706 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The geometry is the same in both the stroke and the fill case, which means
it can be hoisted into the caller (paintDecoration). That leaves only some
fairly trivial code in paintDecorationWithStyle, so fold it up entirely.

BUG=420022

Review URL: https://codereview.chromium.org/654873002

git-svn-id: svn://svn.chromium.org/blink/trunk@183705 bbb929c8-8fbe-4397-9dbb-9b2b20218538

fillInternal() and strokeInternal() don't have those parameters.
CompositeOperator and WebBlendMode parameters exists due to
drawImageFromRect(), which is non-standard API and will maybe deprecated.
Give up the optimization for only drawImageFromRect(), because it's confused
why drawImageInternal() doesn't set current global composite before calling
drawVideo().

In addition, include some clean-up.
1. remove redundant "blink::".
2. merge fullCanvasCompositedFill() with fullCanvasCompositedStroke().

Review URL: https://codereview.chromium.org/645693004

git-svn-id: svn://svn.chromium.org/blink/trunk@183704 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Also clean up the code related to squashing in CompositedLayerMapping a little bit.

BUG=417994

Review URL: https://codereview.chromium.org/659493005

git-svn-id: svn://svn.chromium.org/blink/trunk@183703 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=183696

BUG=422050
TBR=cbiesinger@chromium.org

Review URL: https://codereview.chromium.org/656943002

git-svn-id: svn://svn.chromium.org/blink/trunk@183702 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=420651

Review URL: https://codereview.chromium.org/650893002

git-svn-id: svn://svn.chromium.org/blink/trunk@183701 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Combines setShouldDoFullPaintInvalidationWithReason() into
setShouldDoFullPaintInvalidation().

This is preparation to allow more paint invalidation reasons.

For now allow default value. In the future we may force every
setShouldDoFullPaintInvalidation to have a reason, when we can
remove the default value.

BUG=410465

Review URL: https://codereview.chromium.org/656643004

git-svn-id: svn://svn.chromium.org/blink/trunk@183700 bbb929c8-8fbe-4397-9dbb-9b2b20218538

After re-adding the extra hit-tests on GestureTap in crrev.com/429793004 the
scroll offset was being added twice to the synthesized mouse events. This went
unnoticed because the target had already been determined in earlier hit-tests
and so the event was dispatch to the proper target but with the wrong
coordinates. This CL fixes that to match the exact coordinates that native
mouse events would report.

BUG=418800

Review URL: https://codereview.chromium.org/641063003

git-svn-id: svn://svn.chromium.org/blink/trunk@183699 bbb929c8-8fbe-4397-9dbb-9b2b20218538

.. so just require a paint invalidation and ensure visual overflow gets recomputed.

There is an optimization that throttles paint invalidations on an element when
the children have just been laid out - now that we avoid this layout we want
to continue throttling these repaints. I will address this in a follow-up.

BUG=396825

Review URL: https://codereview.chromium.org/561303002

git-svn-id: svn://svn.chromium.org/blink/trunk@183698 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=eustas@chromium.org
BUG=413249

Review URL: https://codereview.chromium.org/650003003

git-svn-id: svn://svn.chromium.org/blink/trunk@183697 bbb929c8-8fbe-4397-9dbb-9b2b20218538

https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Mac10_9/12353/layout-test-results/results.html

TBR=eae@chromium.org
BUG=422050

Review URL: https://codereview.chromium.org/653943003

git-svn-id: svn://svn.chromium.org/blink/trunk@183696 bbb929c8-8fbe-4397-9dbb-9b2b20218538

With --site-per-process, some content_browsertests were crashing in the renderer while processing a ViewMsg_Resize, because they accessed localFrameRootTemporary()->frameView() without first checking whether localFrameRootTemporary() is valid.  localFrameRootTemporary() won't be valid if site A opens a popup to site B: when we initialize the opener frame/view in B's process, the opener will just have one remote top-level frame.  For an example, see RenderFrameHostManagerTest.DontSwapProcessWithOnlyTargetBlank.  In this case, the resizing message is sent as part of initializing the swapped-out view for the opener, and should be ok to ignore.

BUG=417518

Review URL: https://codereview.chromium.org/613043005

git-svn-id: svn://svn.chromium.org/blink/trunk@183695 bbb929c8-8fbe-4397-9dbb-9b2b20218538