- 28 May, 2020 40 commits
-
-
Ben Kelly authored
Bug: 1059802 Change-Id: I75965b55127c5ae9319b309d5adad62f6923a943 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219074Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Ben Kelly <wanderview@chromium.org> Cr-Commit-Position: refs/heads/master@{#772703}
-
David Van Cleve authored
To be in line with other new security-relevant Web Platform features, we only allow callers to execute Trust Tokens operations in secure contexts. Usually, WebIDL restricts functionality to secure contexts with the [SecureContext] extended attribute. This is how we initially implemented the restrictions on the three Trust Tokens interfaces (fetch, XHR, and iframe). However, this doesn't work for the fetch interface, because the [SecureContext] extended attribute doesn't work on dictionary members (like the `trustToken` member in request_init.idl); instead, it silently no-ops! This change: 1. removes the useless SecureContext attribute from RequestInit; 2. adds an explicit check that a Fetch request bearing Trust Tokens parameters is coming from a secure context, throwing a TypeError if not; and 3. for good measure, adds tests ensuring the XHR and iframe interfaces are only available in secure contexts, too. R=csharrison, yhirano Fixed: 1087200 Change-Id: If19f89251d9ab0ea16e8bb80216b5ef8d2f91b68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217855Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: David Van Cleve <davidvc@chromium.org> Cr-Commit-Position: refs/heads/master@{#772702}
-
Julie Jeongeun Kim authored
This CL moves printing::PrintHostMsg_DidPrintContent_Params to print.mojom to pass it to Mojo interfaces. This is a precursor CL to mojofy the preview UI messages. Bug: 1008939 Change-Id: I35449ebcf5ed89c9d1282997b6b10b2e674c78cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212110Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#772701}
-
gogerald authored
This CL also modifies the single tab switcher to explicitly selecting the current tab when clicking back button. Bug: 1085242 Change-Id: Ia2032d7e0f8a214d40f6554a5f2117be51b46c59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212483 Commit-Queue: Ganggui Tang <gogerald@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Auto-Submit: Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#772700}
-
Mike Klein authored
This moves where dither happens in CPU rendering to more closely match where it happens in GPU rendering. Bug: skia:10000 Change-Id: I184fd73599129596f3896ce716366f65fce60348 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219071 Commit-Queue: Mike Reed <reed@google.com> Auto-Submit: Mike Klein <mtklein@google.com> Reviewed-by:
Mike Reed <reed@google.com> Cr-Commit-Position: refs/heads/master@{#772699}
-
Olesia Marukhno authored
Add restarting the timer on user interaction. Bug: 1019129 Change-Id: I9c2fd0320761747cefbf5b0407ed6989ca804699 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214948 Commit-Queue: Olesia Marukhno <olesiamarukhno@google.com> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#772698}
-
Ehimare Okoyomon authored
Create PageInfoSubpageController and PageInfoSubpage for control of a specific section of the page info v2. Componentized the cookies section as an example. https://screenshot.googleplex.com/XnhMwuBkVzG.png Bug: 1077766 Change-Id: I7bf71c62859bcae7b2f24bd9509947c003a51c06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209070 Commit-Queue: Ehimare Okoyomon <eokoyomon@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#772697}
-
Annie Sullivan authored
Original CL: https://chromium-review.googlesource.com/c/chromium/src/+/2218908 The CL was reverted due to failures: https://chromium-swarm.appspot.com/task?id=4c70451b557f4a10 https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8879124242719394576/+/steps/browser_tests/0/logs/Deterministic_failure:_LayoutInstabilityTest.OOPIFSubframeWeighting__status_CRASH_/0 ../../chrome/browser/page_load_metrics/integration_tests/layout_instability_browsertest.cc:152: Failure Value of: cls_values[i].has_value() Actual: false Expected: true This looks like one of the scores in the loop isn't getting set correctly. I'm not sure which, so this CL also fixes the check of scores and is more explicit about which score is being checked. Bug: 943668 Change-Id: Icd0203fa8b6521b83605ab1c1210376c2f7a8356 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219112Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Annie Sullivan <sullivan@chromium.org> Cr-Commit-Position: refs/heads/master@{#772696}
-
Peter Wen authored
Now that r8 has been updated to remove unnecessary bridge methods and turbine is turned back on for all targets, and robolectric has been moved into android_deps, we no longer need this enable_turbine flag. Now we can assume that all non-prebuilt java targets have a turbine header. Bug: 1056299 Change-Id: Id3a1d77e572fcd5d231c61deb28b444603dc1a47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219670 Commit-Queue: Peter Wen <wnwen@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Peter Wen <wnwen@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#772695}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/4d9848cbcdb3..616e38c720de 2020-05-28 fancl@chromium.org auto-bisect: Fix commit range from end:start to start:end If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC rmhasan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1087355 Tbr: rmhasan@google.com Change-Id: I96cf44eb8d33085a9eef9a600c77ce4176aa81b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219917Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#772694}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/a5b927e19e44..fdd70eae3267 2020-05-28 lalitm@google.com ui: plumb tp metatracing into the UI If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I0658ee38cdf7d6bdd48e7b33cccf2dcee961de68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218742Reviewed-by:
-
David Jin authored
If the 'Cookies' file has not been migrated, then we try to migrate the 'Cookies' and 'Cookies-journal file to new location. However, the 'Cookies-journal' is being moved to same location as 'Cookies' and thus overwriting it and losing the cookies data. This issue arises when updating from WebView which doesn't have the 'incomplete' migration logic to a WebView version with the fixed migration logic. Bug: 1080828 Change-Id: I520de8e65c3a7c5290ccfdeff8cd69acffa80fe1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2190278Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#772692}
-
Alice Wang authored
This CL adds robolectric tests for the class AccountPickerMediator. Bug: 1081218 Change-Id: Ib2e984491978e6c701486a426ec3c9b13f7eab77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214956 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#772691}
-
Jan Wilken Dörrie authored
TBR=lukasza Bug: 1087392 Change-Id: Iab95de864a2c06f5311dda371a07d21d5770468d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218117Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#772690}
-
ckitagawa authored
This is a reland of crrev.com/c/2032024, but is built on a refactoring of the browser side storage of embedding tokens. So it is not a clean reland. Patchset 1 is as close to the original CL as possible. This change was originally reverted due to an interaction with bfcache where embedding tokens were not cached on the bfcache navigation. The specific scenario that needs to be addressed is Document A -> Document A -> Document B -> Document A Has Token -> No Token -> No Token nav cached -> Use cached nav The cached navigation failed validation as an embedding token was expected. The fix for this is to ignore embedding tokens on the cached navigations. Original Description: This change add embedding tokens to the main frame. This has the same behavior as embedding tokens for remote frames except it doesn't propagate the token to a parent. Behaviors - Add a token on first navigation. - Swap the token on any cross-process navigation. Bug: 1072422 Change-Id: Ic658e3cce3b311b97b3021fe2f006f2c893c10b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133884 Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#772689}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/5aefbb372568..70728ef8e71e 2020-05-28 ethannicholas@google.com Revert "Reland "Revert "SkSL function inlining""" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC westont@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: westont@google.com Change-Id: I3a6366975cba569cef60985a1fb263574543e0ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219918Reviewed-by:
-
Friedrich Horschig authored
Similar to the dropdown, this CL adds a G icon to account-stored passwords in the Manage Passwords Bubble. Since the store might be relevant for a11y users when they intend to delete a password, an accessibility text informs screen-reader users. Flag-guarding the icon row is not necessary since it is only shown if at least one password is account-stored. Without the flag enabled, no password can be account-stored. Note: the only test for this surface is currently disabled on bots due to flakiness. The test passes locally but debugging the flakiness exceeds the scope of this CL. Screenshot in the linked bug is identical to IDS_MANAGE_PASSWORDS_ACCOUNT_STORE_ICON_DESCRIPTION: https://storage.cloud.google.com/chromium-translation-screenshots/fa9d35ac7a358c49def0764514a910c300ccf368 Bug: 1086888 Change-Id: Ica42938001219391d49dd339f3f414f45b109d38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218071 Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#772687}
-
Denis Kuznetsov authored
Bug: 1084940, 1078294 Change-Id: I475453adce7fc98d96279434754cb3f09dac50e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218036 Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#772686}
-
Ben Kelly authored
Bug: 913107 Change-Id: I577f200311baff44c2986fcfa47a9e61c6ddb187 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219069Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Commit-Queue: Ben Kelly <wanderview@chromium.org> Cr-Commit-Position: refs/heads/master@{#772685}
-
Wez authored
Runner script targets included "${target}.archive_manifest" in their |data|, since it was a required input to the package "bundling" step. Now that the fuchsia SDK provided GN rules are used, this file is no longer a build nor runtime dependency of the runner scripts. Recent SDK builds have re-named it, causing the errant dependency to block SDK rolls. TBR=kmarshall Bug: 1087301 Change-Id: If99ed213c9bea95d042402d6b1326029d1dca169 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218116Reviewed-by:Wez <wez@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/696a03e075a6..cb29d3aed1ca 2020-05-28 janscheffler@chromium.org Keep frames blocked by the heavy ads intervention 2020-05-28 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I54c682f01dc7094bd922898aa14fa645f849b112 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219915Reviewed-by:
-
Olivier Robin authored
Adapt the openURL logic for UIWindowSceneDelegate. The new API allows to open multiple URLs in the same launch, but it is not clear to me how to trigger that, so I could not test it. Bug: 1069748 Change-Id: I97f61c7cb1af73d79e3b5f9f958049a6a9d7d178 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215051 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#772682}
-
Rune Lillesveen authored
Calling getComputedStyle(div, "::before") would trigger a fetch for the background-image url in: div::before { background-image: url(dont-fetch.png) } which should be unnecessary. Still, we couldn't simply check for PseudoElement being non-null since we need to fetch background images for ::first-line for which we have no PseudoElement. Bug: 1086142 Change-Id: I93d2b59f703f339c104a3735794d0e42287475fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218034 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by:Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#772681}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I69375af3b0e08786e1a309882ea9f8b467154b08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219781Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/a4d70a802cf7..8edfe6e6670e 2020-05-28 tommi@webrtc.org Remove unnecessary sequence checker. 2020-05-28 hbos@webrtc.org [Adaptation] Add cooldown mechanism to prevent spammy kUnderuse from QP If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I73675c16232d8e78c4056e609b692a91a569e6e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219914Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/b9529e3a6998..f7a7fb49cfe7 2020-05-28 angle-autoroll@skia-public.iam.gserviceaccount.com Roll glslang from 2b0eafb1de5b to e00d27c6d65b (2 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ynovikov@google.com Change-Id: Ica8f059302fb68f358b394640771da3627862df6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219909Reviewed-by:
-
Kevin Schoedel authored
WebContentController is a RenderWidgetHost::InputEventObserver in order to receive acks and generate gestures. RenderFrameCreated and RenderFrameDeleted have been used to manage this, deriving the RenderWidgetHost from the given RenderFrameHost. However, deletion of a RenderFrame does not actually imply deletion of the associated RenderWidget, so that should not be cause for unregistering the InputEventObserver. This does mean that we don't definitely know when a RenderWidgetHost goes away, but this is safe because ~WebContentController already checks its validity, and a deleted RenderWidgetHost certainly won't be calling any observers. Bug: b/151325287 Test: manual on device Change-Id: I5085d048dfd2f4ec240e7035d2c2e9d06e598f54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218764Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Kevin Schoedel <kpschoedel@chromium.org> Cr-Commit-Position: refs/heads/master@{#772677}
-
Mohamed Amir Yosef authored
This comment was written before LoginDatabase got a proper primary key field. Change-Id: I9802cd6576d462da91b98f87f347b5ed1cc41d94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220025Reviewed-by:
-
Bartek Nowierski authored
This code is currently unused, but is needed to evaluate performance impact of the CheckedPtr initiative. https://docs.google.com/document/d/1pnnOAIz_DMWDI4oIOFoMAqLnf_MZ2GsrJNb_dbQ3ZBg The current implementation is an expensive no-op. It offers no run-time verification of pointer correctness, but it performs work as if it did. It is expected to have similar performance characteristics to the designed CheckedPtr2. CHECKED_PTR2_PROTECTION_ENABLED and "TEST" comments show how the actual code would look like had all needed support been already implemented. Bug: 1073933 Change-Id: I4fc6a1a3b6701dcae9bb38ff3fa01fd6276812fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2162493 Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#772675}
-
Alex Ilin authored
The Gaia reauth page displayed in a modal dialog contains links to help pages. The dialog provides a WebContentsDelegate implementation for the contents it's hosting. This WebContentsDelegate should implement the AddNewContents method to allow opening the links. Bug: 1045515 Change-Id: Ib5a62296a085187a4f96d6d1be41ccbff839d52b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218269 Commit-Queue: Alex Ilin <alexilin@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#772674}
-
Michael Thiessen authored
The ordering of events is different for skipped tests and completed tests, so in order to support both skipped and completed tests reporting duration I had to modify the python result generation code. Now all tests report duration as a separate status after completion. Bug: 989569 Change-Id: I1a837bc2707a1517db6fdea91220aace7e1745d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218559Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ffb43685b117..4fb71e30e397 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jdoerrie@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1073377 Tbr: jdoerrie@google.com Change-Id: Ie005e0df1869a7d54aec60dde66e87fa8adc1197 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219911Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#772672}
-
Jan Wilken Dörrie authored
TBR=alancutter Bug: 1087382 Change-Id: I4777fab9196321e993688947e604b53f3afe3d4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218279Reviewed-by:
-
Jan Wilken Dörrie authored
TBR=mcnee Bug: 1087381 Change-Id: Ic9467c8425a05cb92270ec97e27447b7c44ec763 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219894Reviewed-by:
-
Jan Wilken Dörrie authored
This reverts commit 5416e508. Reason for revert: Likely culprit of Cast Audio Linux breakage: https://ci.chromium.org/p/chromium/builders/ci/Cast%20Audio%20Linux/75925 Original change's description: > base/allocator: Respect malloc() alignment guarantees in PartitionAlloc. > > Generally speaking, malloc() must return data suitably aligned for > std::max_align_t. In practice this means 16 bytes on 64 bit > architectures, whereas PartitionAlloc only provides 8 there. This is > problematic to use it as a malloc() replacement. > > This CL makes PartitionAlloc respect the alignment guarantees on 64 bit > architectures. > > Bug: 787153,998048 > Change-Id: I860f9d0439d59f8d494306452b8cdbff515c8300 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219498 > Commit-Queue: Benoit L <lizeb@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Takashi Sakamoto <tasak@google.com> > Cr-Commit-Position: refs/heads/master@{#772662} TBR=tasak@google.com,haraken@chromium.org,lizeb@chromium.org Change-Id: Ic3266b40748d22cb25d91ab041db79da42851f4f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 787153, 998048 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220085Reviewed-by:
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I946d8f382bcbbc9c71d90933c04d42c456984ec0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219179Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#772668}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/e00d27c6d65b..d0c9129d2f37 2020-05-28 shuizhuyuanluo@126.com fix warning unused parameter in release build (#2251) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,ynovikov@google.com Change-Id: Ia0a4102934da4ffbc785363c97b9eda8e0821f2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219912Reviewed-by:
-
Liviu Tinta authored
The tests in pointer_lock_browsertest.cc were flaky for 3 reasons: - requestPointerLock being asynchronous - mouse events being asynchronous - native mouse events interfering with tests during execution All the above were addressed in prior CLs. Bug: 766450 Change-Id: I30c9d3df7101be6ccd0686b051b83bfb0754300c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213103Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Liviu Tinta <liviutinta@chromium.org> Cr-Commit-Position: refs/heads/master@{#772666}
-
Jan Wilken Dörrie authored
This reverts commit 91eda9e8. Reason for revert: testImageSearch is flaky: https://crbug.com/1087333 Original change's description: > Fix image search from search activity > > SearchActivity did not handle image search data since image search need > post data, so the fix is add the post data into intent to pass to chrome. > > Bug: 1078773 > Change-Id: I04efdad0bba315508e0b05d3d9e444d8c1a5d955 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2187191 > Commit-Queue: Gang Wu <gangwu@chromium.org> > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Reviewed-by: Ender <ender@google.com> > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Cr-Commit-Position: refs/heads/master@{#772335} TBR=tedchoc@chromium.org,gangwu@chromium.org,rsesek@chromium.org,ender@google.com Change-Id: I7bce956c3e6ed21fce50f97a45bfd3bbe700473d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1078773, 1087333 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218074Reviewed-by:
-
Jan Wilken Dörrie authored
TBR=rch Bug: 1087378 Change-Id: I66e9fedd96223751fb369ca7e85d710b304226fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220045Reviewed-by:
-
