- 23 Jan, 2018 40 commits
-
-
Michael Thiessen authored
Daydream expects its icons to be in png format, and play store validation will fail if it doesn't find correctly formatted icons. This excludes '.dd.png' files from the automatic conversion to webp when building ChromeModern See b/72294258. TBR=dtrainor@chromium.org Bug: 802080 Change-Id: Icd55d5a08536697ec97c08701782c925165631c0 Reviewed-on: https://chromium-review.googlesource.com/881461Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#531335}
-
Marcin Simonides authored
With this change "gn check" no longer assumes all #include paths are relative to the source root. Instead it searches for the includes by checking each of the directories listed in include_dirs for the target. A number of new issues have been discovered. The trivial ones have been fixed, the larger and more complex ones have been reported and the related parts of the project have been excluded from the default gn check run. BUG=794926 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I39c17a7ac47dc024dd374c8891ce4911809195cb Reviewed-on: https://chromium-review.googlesource.com/827014 Commit-Queue: Brett Wilson <brettw@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
David Reveman <reveman@chromium.org> Reviewed-by:
Yuzhu Shen <yzshen@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Brett Wilson <brettw@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#531334}
-
Maks Orlovich authored
This makes it easy to see that we don't delete things again once an entry is conceptially unlinked by a Doom. This also fixes the recent SimpleCacheQueuedOpenOnDoomedEntry testcase to behave more causally consistently. Also adds a testcase that covers new path --- but doesn't demonstrate any fix. Bug: Change-Id: I88d797eb23e0206ce3164bc1642ff464f6ba69e8 Reviewed-on: https://chromium-review.googlesource.com/862229Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Commit-Queue: Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#531333}
-
sczs authored
In some cases the UI changes related to Fullscreen being disabled need to animate. AnimatedScopedFullscreenDisabler works just like ScopedFullscreenDisabler but increments the disabled counter inside an animation block. Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I79710443b8fa9d8137a03ce71035ccc9b077e1c6 Reviewed-on: https://chromium-review.googlesource.com/879568 Commit-Queue: Sergio Collazos <sczs@chromium.org> Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#531332}
-
Nate Chapin authored
This was regressed in https://chromium-review.googlesource.com/c/chromium/src/+/858257, which assumed that ImageResourceContents::Create() would never return nullptr. That would have been true if https://chromium-review.googlesource.com/c/chromium/src/+/860995 hadn't been reverted. Bug: 804829 Test: http/tests/navigation/image-css-load-in-subframe-unload-handler.html Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: If53103d79907d5a01111aead2fdc93ce3491b3d7 Reviewed-on: https://chromium-review.googlesource.com/881642Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#531331}
-
Ryan Landay authored
When an IME tries to set a composition immediately after a non-editable element inside an editable region, it's possible for the selection base to get stuck inside the non-editable region, in which case the attempt to replace the selection fails. The fix is to pass the kCanSkipOverEditingBoundary flag when we call MostForwardCaretPosition() on the selection base so we can find the actual editable region. Bug: 790777,801441 Change-Id: I1014901742671f6fbb153c7117eaa1b271a265f7 Reviewed-on: https://chromium-review.googlesource.com/879839 Commit-Queue: Ryan Landay <rlanday@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#531330}
-
Xiaohan Wang authored
- Restrict CdmService to only host library CDM. Previously CdmService is generic, but it's never used anywhere else, and that assumption has caused some unnecessary code complexity. - As such, also remove ENABLE_STANDALONE_CDM_SERVICE and replace it with ENABLE_LIBRARY_CDMS where applicable. - Remove the use of media::mojom::InterfaceFactory for the CdmService, and replace it with a dedicated media::mojom::CdmFactory. - Remove the use of MojoMediaClient in CdmService, and replace it with CdmService::Client. BUG=771791 Change-Id: I49e0fc4958b18e1b619e20ab4772245b256ab454 Reviewed-on: https://chromium-review.googlesource.com/852556 Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
John Rummell <jrummell@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#531329}
-
Aga Wronska authored
Separate logic for creating users list (small and extra small display style) into ScrollableUsersListView. ScrollableUsersListView: * is initialized with appropriate params in LockContentsView * adjusts its insets according to device orientation * provides functionality to draw gradient at the top and bottom of the background Bug: 792742 Change-Id: I1d6087f7332261044a2d896b328570da124b9eb2 Reviewed-on: https://chromium-review.googlesource.com/875150Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Commit-Queue: Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#531328}
-
Erik Chen authored
Bug: Change-Id: I455c0d38cf11742d1651f5986dc9be148504b45b Reviewed-on: https://chromium-review.googlesource.com/879332Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Commit-Queue: Albert J. Wong <ajwong@chromium.org> Cr-Commit-Position: refs/heads/master@{#531327}
-
Tom Sepez authored
make browser_main_loop.cc line 266 and 666 match each other. Change-Id: Id2d7c21b0f58afbb585971057b77e0983b4c04ae Reviewed-on: https://chromium-review.googlesource.com/879565Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#531326}
-
Daniel Bratell authored
In jumbo builds multiple cc files are compiled in the same translation unit and then they will all share the anonymous namespace which can cause collisions if variables have the same name. That was the case for two kFilteredMessageClasses variables. This renames them to: kExtensionFilteredMessageClasses kRenderFilteredMessageClasses This is a followup to an equivalent change done in //content https://chromium-review.googlesource.com/721279 Bug: 746957 Change-Id: I959600adcc81dbd6e405c25aa0272acefc0387d9 Reviewed-on: https://chromium-review.googlesource.com/878362Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#531325}
-
Daniel Bratell authored
In jumbo build experiments, two kNotificationPrefix variables ended up in the same translation unit and clashed. This patch gives those two variables unique names. Bug: 746957 Change-Id: I200e9cb47129a1f20b8edec91ff0ff432a3c22d9 Reviewed-on: https://chromium-review.googlesource.com/874072 Commit-Queue: Daniel Bratell <bratell@opera.com> Reviewed-by:
Drew Wilson <atwilson@chromium.org> Cr-Commit-Position: refs/heads/master@{#531324}
-
Ryan Landay authored
This CL makes two changes to the autocapitalize IDL behavior to match the new spec: https://html.spec.whatwg.org/multipage/interaction.html#autocapitalization - For elements with no autocapitalize attribute set, or which have the attribute set with an empty value (e.g. <input autocapitalize> or <input autocapitalize="">), return an empty string instead of "sentences". - All <input> elements will now have the same behavior. Email, URL, and password inputs will no longer be special-cased to always return "none". This CL also adds some test cases for this new behavior. Bug: 776618 Change-Id: I4027e81380d5ff7ea7da254b98cfa67b1d202b58 Reviewed-on: https://chromium-review.googlesource.com/872012 Commit-Queue: Ryan Landay <rlanday@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#531323}
-
Morten Stenshorne authored
A few were skipped for no reason. Some of them turned out to pass, while others fail. Then there were quite a few manual tests, and those we still need to skip. Made some (mostly minor) changes to some of the tests to make them pass. They were making invalid assumptions about fonts (glyphs with unexpected negative bearing, kerning, etc.) and line heights. One test was also assuming that painting the same glyph multiple times would produce the exact same result as painting it just once, but that's not necessarily true for anti-aliasing. It was pretty hard to figure out what floats-clear/floats-028-ref.xht was about (old IE bug fixed?), but I made the ref more similar to the test, so that we don't make assumptions about line height. Also updated expectations for LayoutNG, because it turned out that more more of these tests pass there. Bug: 711704, 711709, 711805, 711807 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I6e34e037852ef31cfe8d85688865823d6f9d2d0a Reviewed-on: https://chromium-review.googlesource.com/873310 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#531322}
-
Geoff Lang authored
TBR=zmo@chromium.org NOTRY=true BUG=602688 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ie6cb900f6b89a063323564fcbfb39b4458b3e025 Reviewed-on: https://chromium-review.googlesource.com/881822 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by:
Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#531321}
-
Marijn Kruisselbrink authored
Everything about these URLs is defined in the fileapi spec so it seems to make sense to have the implementation in the fileapi directory rather than in core/html. Bug: none Change-Id: Ic50ea770ef24e786f888a3a70cbea39b37e18736 Reviewed-on: https://chromium-review.googlesource.com/881305Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#531320}
-
Shimi Zhang authored
Vertical text (writing-mode: vertical-*) has different selection bounds. Roughly speaking, selection bounds will be horizontal with different orientation between start bound and end bound with this CSS. We didn't check this case before, selection handles didn't get marked correctly for dragging. This CL checked this case to fix this. Bug: 803320 Change-Id: Ibdf451331b652e40d716416321f01d87c951c678 Reviewed-on: https://chromium-review.googlesource.com/875370Reviewed-by:
Mohsen Izadi <mohsen@chromium.org> Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Cr-Commit-Position: refs/heads/master@{#531319}
-
Yuzhu Shen authored
This CL also typemaps content.mojom.URLLoaderFactoryBundle to std::unique_ptr<content::URLLoaderFactoryBundleInfo>. This is part of the effort to avoid using raw mojom::URLLoaderFactory pointers in renderers and also unify interface of URLLoaderFactory getters. Bug: 796425 Change-Id: Ia30cd253ec0c82624fbf466a70da489e4464b82f Reviewed-on: https://chromium-review.googlesource.com/877390 Commit-Queue: Yuzhu Shen <yzshen@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#531318}
-
Nick Harper authored
Change-Id: Ic08885239a5a5c2a1da7475c033ab80aa6f49ed4 Reviewed-on: https://chromium-review.googlesource.com/879404Reviewed-by:
Steven Valdez <svaldez@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#531317}
-
Alexey Kozyatinskiy authored
R=dgozman@chromium.org Bug: chromium:804845 Change-Id: I37ae5ec7e32954bd32cb8e58683e864cd76938c8 Reviewed-on: https://chromium-review.googlesource.com/881462Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#531316}
-
Michael Thiessen authored
This is a speculative fix for FYI bot crashes. Change-Id: I8cea6aa917eb32c93f8a0f1967eb630d8c2fca88 Reviewed-on: https://chromium-review.googlesource.com/881663Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#531315}
-
Lei Zhang authored
The code in pdf/ can be a GN component instead of a static_library. Add a PDF_EXPORT macro and set boundaries on what can be used from external callers. Change-Id: Ib855736f145c5708b8c62c7fd0e3622827bcc623 Reviewed-on: https://chromium-review.googlesource.com/879853Reviewed-by:
dsinclair <dsinclair@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#531314}
-
Sigurdur Asgeirsson authored
With these exclusions in place, the 64 bit sbox_integration_tests are at parity with the 32 bit tests. Bug: 783296 Change-Id: I75661decf5a74c4df96b9ba35097f020f09d9ffe Reviewed-on: https://chromium-review.googlesource.com/881544Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Reid Kleckner <rnk@chromium.org> Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#531313}
-
Lei Zhang authored
It was used for the Fedex cloud printing service. Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ic96c9ecd984a95eec5c0b3c3831c1f43cc1a3254 Reviewed-on: https://chromium-review.googlesource.com/880761Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#531312}
-
Christopher Grant authored
As per UX guidance, make the remaining close buttons face the user, such that when hovered, they appear to grow, rather than slide horizontally. BUG= R=vollick Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Id1c8b1794a274f63936d1485befb18fa9718129d Reviewed-on: https://chromium-review.googlesource.com/881524Reviewed-by:
Ian Vollick <vollick@chromium.org> Commit-Queue: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#531311}
-
Robert Sesek authored
Change-Id: I2e2787f099f7d101b66cd523b6ae9356e046fba9 Reviewed-on: https://chromium-review.googlesource.com/881204Reviewed-by:
Chris Palmer <palmer@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#531310}
-
dpapad authored
This is in preparation of removing paper-menu from third_party/polymer. Bug: 802912 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ic9ceb9d8d83a345f94f37a56eeac23cd20585b12 Reviewed-on: https://chromium-review.googlesource.com/876926Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#531309}
-
Sergey Ulanov authored
Previously GetPackageRoot() was calling base::FileExists(), which requires blocking IO, i.e. it DCHECKs on some threads. Updated the logic used to detect that the app is packaged to avoid blocking IO. Bug: 796779, 778467 Change-Id: I3ae8f5fefea182295a7fda4ff40964f21ba63e5c Reviewed-on: https://chromium-review.googlesource.com/876660 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#531308}
-
Rohit Rao authored
These tests were originally only run when the remote test server was in use, but that restriction was relaxed in https://chromium-review.googlesource.com/c/chromium/src/+/858289. The tests hang when run on iOS, so this CL disables them. BUG=804429 Change-Id: I73cabb162ffd9439b367793d003c0df00f1011af Reviewed-on: https://chromium-review.googlesource.com/879682Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#531307}
-
Shimi Zhang authored
This CL: 1) Moves DisplayAndroidObserver methods after class varialbes declaration. 2) Adds comment for the reason of a reflection call. Bug: None Change-Id: I73abe0d2cb0838c61a21aa7cb16e243963fadc0f Reviewed-on: https://chromium-review.googlesource.com/879730Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Cr-Commit-Position: refs/heads/master@{#531306}
-
Alexey Kozyatinskiy authored
Most of the time we use webgl error breakpoint to set breakpoint at webgl call which produces opengl warning or error. Asynchronous break at next JavaScript execution is not useful here. R=dgozman@chromium.org Bug: chromium:800835 Change-Id: Ief8670a22ceff51e6cb7b55f47a403a7f6a52959 Reviewed-on: https://chromium-review.googlesource.com/879073Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#531305}
-
Eric Roman authored
Change-Id: Ic585f97d93ca9bd87bd861155ed80b33e8950985 Reviewed-on: https://chromium-review.googlesource.com/881464Reviewed-by:
Chris Palmer <palmer@chromium.org> Commit-Queue: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#531304}
-
jonross authored
Upadte viz filters for new failures. TBR=kylechar@chromium.org TEST=viz_browser_tests, viz_content_browsertests Bug: 760181 Change-Id: I7240da12372b5ebaf6774f21d42cadfdebecfd31 Reviewed-on: https://chromium-review.googlesource.com/881306 Commit-Queue: Jonathan Ross <jonross@chromium.org> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#531303}
-
Anthony Vallee-Dubois authored
This CL removes the footer in the Payment Handler sheet, extends the web contents to the bottom of the dialog, and displays the current origin and page title in the header. Bug: 798846 Change-Id: I4093868bab4c132bfb2c1fe41a3c3592408fd4e5 Reviewed-on: https://chromium-review.googlesource.com/876516 Commit-Queue: anthonyvd <anthonyvd@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#531302}
-
Wenzhao Zang authored
A few differences with the current implementation: 1) Currently there're both |WallpaperManager::OnPolicySet| and |OnPolicyFetched|. |OnPolicySet| merely labels the wallpaper as POLICY type to prevent potential wallpaper changes. This results in a temporary inconsistency between the actual wallpaper and its type. In this version this method is deleted. (ie, if policy fetch never succeeds, WallpaperController won't know about the policy.) 2) Currently |OnPolicyCleared| only sets the type back to DEFAULT without deleting the policy wallpaper file. This doesn't result in visible bugs, but it's better to delete the files and explicitly calls SetDefaultWallpaper for this user. 3) The existing tests in wallpaper_manager_policy_browsertest.cc stay unchanged in this CL. But they may be moved to a different place later. Test: Verified on Admin console, no conflict with device policy. Bug: 779221, 800182 Change-Id: Ibb3fa38ddc19b095bfd684fe2fa6e500d7a580b4 Reviewed-on: https://chromium-review.googlesource.com/845262Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#531301}
-
Elly Fong-Jones authored
TBR=brucedawson@chromium.org Bug: 804452 Change-Id: I49e348b382ea3df249788b0d26c77b7b9f6afd45 Reviewed-on: https://chromium-review.googlesource.com/881241Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#531300}
-
dpapad authored
When zooming, right before the toolbar collapses to narrow mode, an unnecessary flashing horizontal scrollbar appears. Bug: 771096 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Iee36198f0e3719a84d7b33fd7a933493876ffe09 Reviewed-on: https://chromium-review.googlesource.com/879598Reviewed-by:
Scott Chen <scottchen@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#531299}
-
Andrew Grieve authored
No change in behavior expected. Main changes: * Use of upstream's linker_reloc_iterators.h & linker_sleb128.h. * Use #ifdefs to choose between 32 and 64 bit. Upstream linker: https://android.googlesource.com/platform/bionic/+/master/linker/linker.cpp TBR=digit Change-Id: I15c0fadadbfcd99dae4e334a205b69e875c4cce1 Reviewed-on: https://chromium-review.googlesource.com/879222Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#531298}
-
Joe Downing authored
TBR=ellyjones@chromium.org,zijiehe@chromium.org BUG=804897 Change-Id: I4b209737cc2124d93a6d370a9f6abf88719b36cc Reviewed-on: https://chromium-review.googlesource.com/881539Reviewed-by:
Joe Downing <joedow@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#531297}
-
Chris Nardi authored
After zooming, the calculated length of a value can sometimes be less than or equal to a LayoutUnit away from the true value. Because of this, a page can sometimes be in between two precise values of a media query. Use LayoutUnit::Epsilon to avoid this issue. Bug: 689096 Change-Id: Ibce686fb10e2dd0eaca142fadd65331ebe7b35a1 Reviewed-on: https://chromium-review.googlesource.com/879235Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#531296}
-