GitLab

Bug: 727873
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ieca4aab7371e7208d49c78795f8da076bd237838
Reviewed-on: https://chromium-review.googlesource.com/587991
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491632}

Removed OpenURLFromTab from the provider, as it’s not related to its
mission to produce search results.

Bug=712331

Review-Url: https://codereview.chromium.org/2947283002
Cr-Commit-Position: refs/heads/master@{#491631}

Followup to r490994.

Bug: 751412, 748068
Change-Id: Ia3c25f86e45fa67e1a6e01d9edfe79bd515ec3f4
Reviewed-on: https://chromium-review.googlesource.com/598660Reviewed-by: Mark Pearson <mpearson@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491630}

Changes:
Enable touch event in PageSwitcherButton.

BUG=750658

Change-Id: I293544abf5d90201687800d6d6d0451810dfaacd
Reviewed-on: https://chromium-review.googlesource.com/595127Reviewed-by: Yury Khmel <khmel@chromium.org>
Commit-Queue: Weidong Guo <weidongg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491629}

Apply feedback from UX team.
- Adopt 'Harmony motion' for small dialogue
- Make font-size smaller

Bug: 739091
Change-Id: I785820860227a9fa4584d5d816d3984c2062efdf
Reviewed-on: https://chromium-review.googlesource.com/597088Reviewed-by: Keishi Hattori <keishi@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491628}

QuitCurrentWhenIdleDeprecated can end up leaving the thread in an
unclear shutdown state and isn't really the right way to
shutdown. Converts to use RequestQuit().

BUG=none
TEST=covered by tests

Change-Id: I561a7e9a9615d759ceae44a7ad0e724a2d13d093
Reviewed-on: https://chromium-review.googlesource.com/592530
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491627}

Add LayoutThemeFuchsia theme stub to Blink.
The theme is necessary because no LayoutTheme* files are currently
built when is_fuchsia=true.

Bug: 750946
Change-Id: Iab9cdf66856164309882239e643c2006f200d669
Reviewed-on: https://chromium-review.googlesource.com/599248Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491626}

Changes this CL:
- Renames NewTabPromo::CreateSelfOwned to NewTabPromo::Create.
- Adds a NewTabPromo as a member variable of NewTabButton for the following reasons:
1. To make the promo more accessible in order to check visibility in browsertests.
2. To tie the NewTabPromo to the specific NewTabButton it is being shown by. 

Bug: 734132
Change-Id: I71993f0185d712b62ac98706b165b078c4bb574b
Reviewed-on: https://chromium-review.googlesource.com/594627
Commit-Queue: Christopher Benson <chrisbenson@google.com>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491625}

TBR=dimu@chromium.org

Change-Id: Iba7d341f33054f52c7421293fa454fc9ecde53ee
Reviewed-on: https://chromium-review.googlesource.com/599328Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491624}

BUG=751811
R=xhwang@chromium.org,mmoroz@chromium.org
TEST=local build of this fuzzer target produces a non-trivial seed corpus zip

Change-Id: I83d7bc24428200e8581db90714e69d94393d0bcf
Reviewed-on: https://chromium-review.googlesource.com/599013Reviewed-by: Max Moroz <mmoroz@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491623}

If a benchmark is disabled but still run as a step, FormatDisabled is
called on the output_formatter instead of Format. In the case of
json-test-results, this means that no json will be output by the test
(since there is no empty version of json-test-results).

BUG=chromium:751346

NOTRY=true  # This script is not run on trybot/CQ, hence should be safe to notry

Change-Id: I4f19eeab40c1b6976e0f6c92cd5b7fff8ee17e2e
Reviewed-on: https://chromium-review.googlesource.com/598729Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Ashley Enstad <ashleymarie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491622}

Changes:
1. Add TrayUpdate::ResetForTesting to reset everything in TrayUpdate
before testing to prevent effect from previous testing.

BUG=751236
TEST=TrayUpdateTest.*

Change-Id: I85e2641d50448d656b64592dd025efd481428594
Reviewed-on: https://chromium-review.googlesource.com/596523
Commit-Queue: Weidong Guo <weidongg@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491621}

focus.

This matches Polymer behavior and is preferential to the current focus
effect (blue rectangle).

Also get rid of the the focus rect for views::Slider, which already has
the glow effect when focused and hence needs no further changes.

Bug: 658783
Change-Id: Id9d5e3f1434b0d444154be933f0067f97aaaed33
Reviewed-on: https://chromium-review.googlesource.com/592494
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Valery Arkhangorodsky <varkha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491620}

This patch introduces |AdjustSelectionWithTrailingWhitespace()| as replacement
of |VisibleSelectionInFlatTree::AppendTrailingWhitespace()| to simplify
|VisibleSelectionTemplate| for improving code health.

Bug: 657237
Change-Id: Iaf5e0157c42ac5a16647da9616fc3bc67c9420f9
Reviewed-on: https://chromium-review.googlesource.com/597557Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491619}

Get rid of redundant call of SetIsDirectional() in SelectionController::SetNonDirectionalSelectionIfNeeded()

This patch gets rid of redundant call of |SetIsDirectional()| in
|SelectionController::SetNonDirectionalSelectionIfNeeded()|, because
 - We want to set non-directional selection as function name suggested
 - In |FrameSelection::SetSelection()|, we always set directional selection if
   |ShouldConsiderSelectionAsDirectional()| is true.

Bug: 740804
Change-Id: Ia474742aee16d13e124c41f4d7830614c35bd2f2
Reviewed-on: https://chromium-review.googlesource.com/595427Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491618}

WebUI preload JS handling is only done on main frame, so it
makes more sense to be moved from ChromeRenderViewObserver to
ChromeRenderFrameObserver where it can also access binding
registry.

Using Associated Interface since tests were failing / flaky
without it, showing errors such as:
* encountered javascript console error(s):
* Uncaught ReferenceError: runTest is not defined
Calls to this mojo method that preloads javascript libraries must
be executed prior to the call to run JS tests.

Bug: 577685
Change-Id: I431158867f60eb40824cbdf9db7d5d5681cbfe5b
Reviewed-on: https://chromium-review.googlesource.com/595019Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491617}

Phase 2 of the Accessibility Object Model makes each
AccessibleNode an EventTarget and allows developers to
register event handlers for accessibility-specific events.

Accessibility events go through a capturing and bubbling phase
just like DOM events, but in the accessibility tree.

In this change we just implement the "accessibleclick" event
and test that it works and how it interacts with DOM event
listeners.

Bug: 746524
Change-Id: Ia46bbe3e7dcdfedf173a7296613fb998487427a9
Reviewed-on: https://chromium-review.googlesource.com/577960
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Alice Boxhall <aboxhall@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491616}

TBR=wez@chromium.org

Bug: 751748, 738275
Change-Id: I775792a7441dca5fd90e410653cba4610115780a
Reviewed-on: https://chromium-review.googlesource.com/599187
Commit-Queue: Scott Graham <scottmg@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491615}

Changes:
Draw the separator between search box and search results only when
parent view's height is larger than search box height.

BUG=750951

Change-Id: I5ddd8b607c91b8a2272174157f0d232f18a0ee69
Reviewed-on: https://chromium-review.googlesource.com/595245Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Weidong Guo <weidongg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491614}

Previously, a notification content view wrongly detached the surface which is attaching to another view. That caused crbug.com/751355. This CL prevents that.

Bug: 751355
Change-Id: Ibaec4d7fd88f96e864634258d16e45fac9d2a945
Reviewed-on: https://chromium-review.googlesource.com/595312
Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org>
Reviewed-by: Yuichiro Hanada <yhanada@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491613}

This CL fixes a bug where HostFrameSinkManager will not drop the temporary
reference to a FrameSink that has been invalidated from HostFrameSinkManager.

This verifies that HostFrameSinkManager knows about the FrameSinkId of
the Surface created in OnSurfaceCreated. If it doesn't then HostFrameSinkManager
asks FrameSinkManager to drop the temporary reference.

Bug: 657959
Change-Id: Ia9b8eff0885fc0b56e9d866acd41860b11a0b3ba
Reviewed-on: https://chromium-review.googlesource.com/599001Reviewed-by: Ria Jiang <riajiang@chromium.org>
Commit-Queue: Fady Samuel <fsamuel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491612}

- Replacement NTLMv1 implementation.
- In preparation for new NTLMv2 implementation.
- Passes all unit tests and has the same behavior.
- Adds fuzzer for NtlmClient.
- Code is still not live.

BUG=chromium:22532
TEST=All unit tests pass.

Change-Id: Idae533312805d21d49943fd634d54af3a93a7c00
Reviewed-on: https://chromium-review.googlesource.com/598307
Commit-Queue: Zentaro Kavanagh <zentaro@google.com>
Reviewed-by: Asanka Herath <asanka@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491611}

Test: press braille cursor routing key one characer beyond the last character of the displayed text. See action applied to the end of the content such as selection.
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I50a6e5f1f1d708595ad52d026bf279267c96a233
Reviewed-on: https://chromium-review.googlesource.com/599108
Commit-Queue: David Tseng <dtseng@chromium.org>
Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491610}

Bug: 
Change-Id: Iff14def9c9e2e8920ce9b13f1ec17dc50d1a4a86
Reviewed-on: https://chromium-review.googlesource.com/596614
Commit-Queue: Joseph Arhar <jarhar@google.com>
Reviewed-by: Joe Downing <joedow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491609}

Bug: 748247
Change-Id: I7e3a45368e71e1b3cb038b16ec6639af13a1370c
Reviewed-on: https://chromium-review.googlesource.com/596771
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491608}

This changes BluetoothPairingUI to use the shared bluetooth-dialog
component instead of the (soon to be removed) options UI.

Bug: 748193
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I4061d81ce1fca9672236b45b50e3c3e8b4ee764c
Reviewed-on: https://chromium-review.googlesource.com/595137
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491607}

https://skia.googlesource.com/skia.git/+log/828930677138..f12d84275cfa

$ git log 828930677..f12d84275 --date=short --no-merges --format='%ad %ae %s'
2017-08-02 skia-deps-roller Roll skia/third_party/externals/angle2/ 8f276e255..6c58b0620 (2 commits)
2017-08-02 liyuqian Fix typo XPS to SVG
2017-08-02 stani Add a private API for writing the clip to the stencil
2017-08-02 ethannicholas Revert "Revert "support for 'half' types in sksl, plus general numeric type improvements""
2017-08-02 robertphillips Fix DeferredTextureImage test on Mac
2017-08-02 skia-deps-roller Roll skia/third_party/externals/angle2/ df7d7c9ec..8f276e255 (1 commit)
2017-08-02 brianosman Guard against D3D NaN/Infinity literals bug in color burn

Created with:
  roll-dep src/third_party/skia


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=liyuqian@chromium.org

Change-Id: I5b7df679f3a83d0e26a9352f2b763497276cbc1e
Reviewed-on: https://chromium-review.googlesource.com/599348Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491606}

This was accidentally introduced by https://codereview.chromium.org/2727093002.
It affects only LayoutViews for iframes that end up in the slow path for
paint invalidation, which is only for content under filter or multicolumn.

Bug: 750925
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I9a183e0151f584e299134ba3091c440a7d24f0d1
Reviewed-on: https://chromium-review.googlesource.com/599113
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491605}

TBR: chenwilliam@chromium.org,dgozman@chromium.org
Bug: 751906
Change-Id: Id75419de172220cecc02e9bba7ff2837583fadeb
Reviewed-on: https://chromium-review.googlesource.com/598748Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491604}

Changes on this CL
- Moved profile() declarations to virtual TabStripController class. 

Bug: 734132
Change-Id: I1a3b5ebb8aa75f40317aef88b25ff74454fc2778
Reviewed-on: https://chromium-review.googlesource.com/585355
Commit-Queue: Christopher Benson <chrisbenson@google.com>
Reviewed-by: Robert Liao <robliao@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491603}

This gathers the code relating to SourceId into a new file, and adds
a conversion method from other ID types.  External ID types aren't
converted when recieving IDs from other processes.

Change-Id: I3c65406457666f9d099d654a75db7e13a53590d7
Reviewed-on: https://chromium-review.googlesource.com/596725
Commit-Queue: Steven Holte <holte@chromium.org>
Reviewed-by: Oystein Eftevaag <oysteine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491602}

This removes the dependency on the system clock of the origin trial
token validator tests. All static functions in the TrialTokenValidator
namespace which validate tokens now take a base::Time argument which is used to
compare against the tokens provided.

BUG=672294
R=chasej@chromium.org,nhiroki@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_n5x_swarming_rel

Review-Url: https://codereview.chromium.org/2555333006
Cr-Commit-Position: refs/heads/master@{#491601}

Bug: 749014
Change-Id: Idfb6407a11af4307e68e6e6ebae7b21d1cf1958d
Reviewed-on: https://chromium-review.googlesource.com/599025
Commit-Queue: Bret Sepulveda <bsep@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491600}

In layer compositor and display compositor, only child ResourceProvider and
parent ResourceProvider are used. No grandparent ResourceProvider is being
used in real world except this unittests.

To align with the layer tree ResourceProvider and display ResourceProvider,
remove these grandparent related cases.

BUG=738190

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I31c4569885a2392d6925967d6db56ac9a3d78e58
Reviewed-on: https://chromium-review.googlesource.com/595115
Commit-Queue: Xing Xu <xing.xu@intel.com>
Reviewed-by: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491599}

changes:
(1) Enable launcher search result title tags, this will fix
crbug.com/751761.
(2) Update card background color to #FAFAFC, not #FFFFFF.
(3) update single line row (for omnibox non-url search result) and
double lines row specs for render text.

single line row specs: https://screenshot.googleplex.com/hBwCTmKNq4d
double lines row specs: https://screenshot.googleplex.com/9pSZ2p2BVdo

Test screenshot:
screenshot 1: https://screenshot.googleplex.com/KQRCUAF0EXS
screenshot 2: https://screenshot.googleplex.com/NxdAOS7GeMm

Test: tested with fullscreen app list flag
Bug: 750690, 751761
Change-Id: I4104d7b9056bfbc555ce2bb10867383157963c0a
Reviewed-on: https://chromium-review.googlesource.com/596851
Commit-Queue: Qiang(Joe) Xu <warx@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491598}

This CL fixes an extraneous gt (>) causing an error message to display
improperly. Also fixed a missing lt (<) in my search to see if the gt
mistake had been made elsewhere.

Bug: 751384
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I808aa2e811e72f39e781aa7232fd798514ef8f73
Reviewed-on: https://chromium-review.googlesource.com/599069Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Dave Schuyler <dschuyler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491597}

Added to the protobuf, and to the WebUi and V4store:
- Last update time per store.
- Number of checks to the database per store.

Bug: 734667
Change-Id: I24075cb9b926ff0d3c72ef9e97ea37035a46e144
Reviewed-on: https://chromium-review.googlesource.com/596692
Commit-Queue: Kamila Hasanbega <hkamila@google.com>
Reviewed-by: Jialiu Lin <jialiul@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491596}

Bug: 588114
Change-Id: I1a4c0da04a5d3b8353b7e3f80f128799bc159d4e
Reviewed-on: https://chromium-review.googlesource.com/549135
Commit-Queue: Luis Rabasa <erickzul@google.com>
Reviewed-by: Sidney San Martin <sdy@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491595}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/65e2bf234545..c8c5d6b714f8

$ git log 65e2bf234..c8c5d6b71 --date=short --no-merges --format='%ad %ae %s'
2017-08-02 benjhayden Add tooltip to dashboard chart-title's populateTestPicker button.

Created with:
  roll-dep src/third_party/catapult


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: Ib851ab3bea31be53912ced040cf0814d6e905ee8
Reviewed-on: https://chromium-review.googlesource.com/598694
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491594}

mojom::XXXPtr info(mojom::XXX::New());
==>
auto info = mojom::XXX::New();

BUG=728227

Change-Id: I583140baa7803a7628284ad16feec792e2d84634
Reviewed-on: https://chromium-review.googlesource.com/597506Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Han Leon <leon.han@intel.com>
Cr-Commit-Position: refs/heads/master@{#491593}