- 07 Jan, 2021 40 commits
-
-
Sammie Quon authored
These were put on hold because the accelerators were added while capture mode was still being built. Bug: none Test: added tests Change-Id: I213e483edf450464a26d6c547deeb0f665ab9dbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613355Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#841120}
-
cfredric authored
would also have been included due to SameSite rules. Bug: 1143756 Change-Id: I443a042e08ed0c091c65e55138c5ad0547a6f652 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611946Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Lily Chen <chlily@chromium.org> Commit-Queue: Chris Fredrickson <cfredric@chromium.org> Cr-Commit-Position: refs/heads/master@{#841119}
-
Wei Li authored
Merge SMALL_SHADOW and BIG_SHADOW types into one STANDARD_SHADOW type as they are essentially same. Rename NO_SHADOW to NO_SHADOW_LEGACY as it is only needed to support bubbles on the legacy Win7 platform. We would remove it when win7 is no longer supported. Thus rename to NO_ASSETS to NO_SHADOW. After this change, bubble border shadow types boil down to just two usable types: STANDARD_SHADOW and NO_SHADOW. They represent standard (MD style) shadow and no shadow cases respectively. Fixed: 940027 Change-Id: Icbd18ca0092175aa1e1f53cd511b6c8a5edbc9f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2591910Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#841118}
-
Ian Kilpatrick authored
From: https://github.com/w3c/csswg-drafts/issues/5713 Basically these tests stretch an image in one axis, and previously tested that the image should lose its aspect-ratio. When stretching in one axis, and when there is no size constraint in the other axis it should respect the aspect-ratio. Change-Id: Ic1374f50b4d561b3c38b94a4f60724f950e6513e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611567Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#841117}
-
Dale Curtis authored
We've disabled these on Windows and ChromeOS, so it's no surprise that we need to disable them on macOS as well. R=zmo Fixed: 1163111 Change-Id: I406e6ebd1d27da84964e46efb9582ce77f904dac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613560Reviewed-by:
Dan Sanders <sandersd@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#841116}
-
Peter Kvitek authored
This is a followup to http://crrev.com/c/2570447 that introduced extra check in OSCrypt::SetRawEncryptionKey() that is now removed. Bug: 1157539 Change-Id: I0d35502068958a93654565301d84ae04e4760272 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596873Reviewed-by:
Christos Froussios <cfroussios@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Peter Kvitek <kvitekp@chromium.org> Cr-Commit-Position: refs/heads/master@{#841115}
-
Owen Min authored
Enterprise.MachineLevelUserCloudPolicyEnrollment.* are now expired in June. Enterprise.CloudReporting* are set to expired in 1 year. Enterprise.CloudExtensionRequestUpdated expire date is bumped to Oct. Bug: 1160729, 1160730 Change-Id: I2c245f4a68e5c05a99a4255685eccb1e7ca253bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613464Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#841114}
-
cfredric authored
These metrics are only updated for excluded cookies, and their values are whether or not SameParty was the only reason for excluding the cookie. Bug: 1143756 Change-Id: Icc35c59d47269e89f8f37515a7a86d6dc33d0591 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611046Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/8bf25fa0..d1da011f Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I85e440bf284f23cf01907b6c0a1bc66a346cc16e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2614843Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#841112}
-
Joshua Pawlicki authored
As far as I can tell, the actual header is no longer used anywhere. This completes decoupling the flapper targets from the build tree, so they are removed. Bug: 1064651 Change-Id: I18996e13c3dbf9df097b3b964e2b0d2113cfef1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613324Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Anthony LaForge <laforge@chromium.org> Reviewed-by:
-
Richard Townsend authored
The synchronous HTMLDocumentParser mode was incorrectly dispatching preloads for text/plain documents by interpreting their contents as HTML. This CL extends the HTMLDocumentParser's constructor, adds a new enum to disable this behaviour, and a Web Platform Test to show that the unintended prefetching no longer happens. Bug: 1160665 Change-Id: I07902d58e3bc06ce6ecc07c341e997846d6e5a64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613008 Commit-Queue: Richard Townsend <richard.townsend@arm.com> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#841110}
-
ssid authored
The trace event data source is reset at the start of each test. By this time the test already created the task environment and could have active worker threads which try to add trace events. Move the destruction to the end of tests after the task environment shuts down. BUG=1137225 Change-Id: I54c477d7859161c24575bf9b2060f1eb723d699e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2603417Reviewed-by:
Eric Seckler <eseckler@chromium.org> Commit-Queue: ssid <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#841109}
-
Shengfa Lin authored
Use strip with preserve time option so that zipping the same ChromeDriver Linux binary does not generate a ZIP archive with different hash. Bug: chromedriver:3703 Change-Id: Ib978c491f7e398f0597a0dd9478408bdb60d3ec8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615100 Auto-Submit: Shengfa Lin <shengfa@google.com> Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#841108}
-
Connie Wan authored
This is a no-op for every non-test instance of AddToNewGroup except for here: https://source.chromium.org/chromium/chromium/src/+/master:chrome/browser/extensions/api/tabs/tabs_api.cc;l=1844 So the editor bubble is still auto-opened in almost every case of creating a new group, except when it happens via an extension. Bug: 1106846 Change-Id: Ide379350893a5a5bc31e2ee653ceacac6c42560e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613786Reviewed-by:
Charlene Yan <cyan@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Connie Wan <connily@chromium.org> Cr-Commit-Position: refs/heads/master@{#841107}
-
Yu Han authored
Prior to this CL, controls-refresh text input is missing its border. The fix is to make sure property text_field.has_border is passed to native theme. This property is only used by form controls-refresh so it has no impact on existing text input. Bug: 1155397 Change-Id: I3cacd4d9550e10388b15122d7ff94a32ffa5e39d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612495Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
-
Alex Ilin authored
TBR: ntfschr@chromium.org Bug: 1163744 Change-Id: Iccf511d117156c6e449d4334ffcbe6cfed1ba3b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615018Reviewed-by:
Alex Ilin <alexilin@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Auto-Submit: Alex Ilin <alexilin@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#841105}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/f88c00e45a2f..cbc14b10e623 2021-01-07 wl@gnu.org Fix ABI incompatibility. 2021-01-07 wl@gnu.org Fix typos from last commit. 2021-01-07 apodtele@gmail.com [dlg] Move the headers to include/dlg to simplify their use. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/freetype-chromium Please CC bungeman@google.com,drott@google.com,thestig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:win10-blink-rel;luci.chromium.try:win7-blink-rel Tbr: bungeman@google.com,drott@google.com,thestig@google.com Change-Id: I5006517af70651ff1410f9c21cad6f9101b7c5f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2614351Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
Ben Wagner <bungeman@chromium.org> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Ben Wagner <bungeman@chromium.org> Cr-Commit-Position: refs/heads/master@{#841104}
-
Xi Han authored
We disable StartSurfaceTest#testShow_SingleAsHomepage_BackButton__Instant_Return on Android o bots. The original CL description is: In this CL, we introduce a new flag "keepTab" for a Tab with launch type FROM_START_SURFACE. When this kind of Tab is selected from the carousel Tab switcher on the Start surface, or from grid tab switcher, the "keepTab" is set to be true. This guarantees the tab won't be auto deleted from the TabModel when the back button is tapped. More details see doc: https://docs.google.com/document/d/1mZXgQ0fi_b96vcwy1DkgWunl0FutkFwyt-7PrU-Pgjc/edit# Bug: 1155139,1163874 Change-Id: I2b0944c45a0273548d2da91a3def4db5c17f57e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2614798Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#841103}
-
Julie Jeongeun Kim authored
This CL fixes up the issue caused by [1]. [1] https://crrev.com/c/2569167 Bug: 1163898, 1008939 TBR: rbpotter@chromium.org Change-Id: Ibfb19bc8f9d59a31ecb32f164deba610b0a32744 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2614249 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/7c54d0e3efb6..ddb981175c35 2021-01-07 jacktfranklin@chromium.org Migrate component_docs/data_grid examples to TS files 2021-01-07 mathias@chromium.org Include .avif and .webp images in *.grd files 2021-01-07 tvanderlippe@chromium.org Enable no-implicit-coercion for all files 2021-01-07 tvanderlippe@chromium.org Enable no-implicit-coercion in front_end/ 2021-01-07 tvanderlippe@chromium.org Fix remaining no-implicit-coercion errors in front_end/ 2021-01-07 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. 2021-01-07 bmeurer@chromium.org [e2e] Disable another test to unblock the Chromium roll. 2021-01-07 patrick.brosset@microsoft.com Make sure rulers appear when needed 2021-01-07 tvanderlippe@chromium.org Fix no-implicit-coercion errors in front_end/ 2021-01-07 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2021-01-07 bmeurer@chromium.org [e2e] Temporarily disable test to unblock Chromium roll. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1082789,chromium:1144106,chromium:1159309,chromium:1161667,chromium:1161701 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I56f53f2ad0d050f7c2d9078ebf0f03a0332286e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2614134Reviewed-by:
-
Ben Pastene authored
crbug.com/968262 recently added sharding support to the Tast runner. This adds support to plumb down the shard parameters as specified from the chromium recipe down to the Tast runner. This also adds 2 shards to chrome_all_tast_tests across every builder to start with. Some bots could likely do with even more shards, but that'll be left for a follow-up. And remove a bit of copy-paste from tests. Bug: 968262 Change-Id: Ic3539a6f39c9daab4429b687e142565a8c98f288 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610963Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#841100}
-
Robbie Gibson authored
When smooth scrolling is enabled, the tab strip background is set to black to block out the web content behind the tab strip. However, the tab strip snapshot should always have a clear background because the web content is moved when using the snapshot. Ths CL overrides the background color of the tab strip to clear when taking the snapshot and resets it afterwards. Fixed: 1163919 Change-Id: I945183e10633442ccf4f49c05ef6ceae85f3af59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2614786Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#841099}
-
Robbie Gibson authored
Bug: 1123048 Change-Id: Ie24d51180a741fecf06e03da908cfb6042de087f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2614781Reviewed-by:
-
Peter Kasting authored
Bug: 1159562 Change-Id: If07c17aa6b0045f40b3942f7a70f819d32089dc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2614847 Commit-Queue: Peter Kasting <pkasting@chromium.org> Commit-Queue: Allen Bauer <kylixrd@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#841097}
-
Francois Doray authored
This CL removes unused background tracing category presets so we don't have to unnecessarily maintain them. This reduces technical debt. Bug: 1157487 Change-Id: I3d2c2eda3fa2ea730cf0cac46936733ea5f19862 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586105 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
ssid <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#841096}
-
Mingjing Zhang authored
Jank reporter now uses |vsync_interval| to determine the frame length increment threshold, instead of directly using the frame interval reported by the presentation feedback; the latter could be zero and cause erroneous jank reporting. Bug: 1154492 Change-Id: I616a77d85bf91436ebc0b6982a278c5763225993 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569794 Commit-Queue: Mingjing Zhang <mjzhang@chromium.org> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#841095}
-
Dave Tapuska authored
Move Unload to be a message on the FrameNavigationController. Messages on an associated mojo interface are dispatched against the main task runner so they aren't really frozen. So this method can move to be just a normal associated interface. The result of unload is dispatched to the AgentSchedulingGroupHost because we need to return the result and the FrameNavigationController is disconnected when RenderFrameImpl is destroyed so any callback on that won't be called. Other approaches were considered but deemed too difficult: 1) We can't simply Unbind() the FrameNavigationControl AssociatedReceiver since that doesn't work if there are already pending reply callbacks. 2) We can't use a unique_ptr to own the FrameNavigationControl AssociatedReceiver, since the AssociatedReceiver also needs to be paused. 3) Deferring deletion of the RenderFrameImpl would be undesirable (as the associated WebLocalFrame is already gone) 4) Reporting it through an interface passed to the Unload() method would add a non-trivial amount of complexity BUG=993189 Change-Id: I4f8a29c09b34596e2d5d8d2595a04306ccb1e569 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580002 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#841094}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/ccaf6dbd5c6e..5ff758df67da If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ie41b560b5f3aca0ba1051557c68415274b8c75a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2614840Reviewed-by:
-
Scott Violet authored
This makes TabRestore use the new backend code that results in a new file rather than truncating the existing file. BUG=648266 TEST=covered by tests Change-Id: I066b369ee039786cc416e275b7be1e22d5214dc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611908 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
David Bienvenu <davidbienvenu@chromium.org> Cr-Commit-Position: refs/heads/master@{#841092}
-
btolsch authored
These histograms have been unused for a while and are expiring so this change removes them instead of extending their expiration. Bug: 1160737 Change-Id: I757a067e33d7172be10a80b011123fa17d4658a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613510Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Commit-Queue: Brandon Tolsch <btolsch@chromium.org> Cr-Commit-Position: refs/heads/master@{#841091}
-
chromium-internal-autoroll authored
Release_Notes: http://go/help_app-x20/relnotes/Main/help_app_nightly_202101070600_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/BrzlGtpSjp8quKJlBN8pxLiY0XfrgeDpvKGKAovPBTIC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll Please CC help-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/174321021,b/175636948,b/176853210 Tbr: help-app@grotations.appspotmail.com Change-Id: Id2f5682dc771e68146b50aad8a999a211e1766e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2614765Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#841090}
-
Stephen McGruer authored
This is a reland of 3482d6ea (reverted in 672e131e), with the SVG changes backed out. Bug: 997202 Change-Id: Id1a63ce0c2fd63b288135de007aab30449508a6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611982 Auto-Submit: Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Kevin Ellis <kevers@chromium.org> Reviewed-by:
Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#841089}
-
Nicolas Ouellet-Payeur authored
In unit-tests, g_browser_process->profile_manager() can return null. When the DestroyProfileOnBrowserClose flag is enabled (via ScopedFeatureList, or fieldtrial_testing_config.json), ScopedProfileKeepAlive causes a crash. Add a guard in ScopedProfileKeepAlive(), so it's a no-op if there is no ProfileManager. Bug: 88586 Change-Id: Ife9f198da3d7dc69f8cf59bed80aca9c57517a6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2614859 Auto-Submit: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#841088}
-
Ulan Degenbaev authored
Bug: chromium:1085129 Change-Id: Ia0d1968c97542a7ed0455b61aaf2558e9c81272c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613024Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#841087}
-
Annie Sullivan authored
Bug: 1141739 Change-Id: Ia8fd23a17e85c8da88c8384c9f6ef43ddb992b95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2614408Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Annie Sullivan <sullivan@chromium.org> Cr-Commit-Position: refs/heads/master@{#841086}
-
Sam Maier authored
The existing errors are using protected visibility when they could be using package-private visibility. Bug: 1029038 Change-Id: Iec1da0fed876d2d2abc68414bdb7175aab02db95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602890Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Sam Maier <smaier@chromium.org> Auto-Submit: Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#841085}
-
Trent Begin authored
Screenshots should not be checked in to the codebase since they are uploaded to a gs bucket when the .png.sha1 files are created. Bug: none Change-Id: Ic2a2eb53b294957f5836837222ecdc9b341510f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612099 Auto-Submit: Trent Begin <tbegin@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#841084}
-
David Van Cleve authored
As part of rolling out the Trust Tokens config change to use a third-party origin trial instead of the current nonstandard origin trial configuration, we're moving the main experiment group to serve the all-operations-require-origin-trial parameter instead of only-issuance-requires-origin-trial. To make this experiment config change, we first need to update the field trial testing config to use the new parameter value. (This should be a no-op, since tests that care about this value currently set the parameter manually.) Bug: 1154714 Change-Id: Iefcc10d9abd93bf924d27a1d2910defc8d5015f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610993Reviewed-by:
Dan McArdle <dmcardle@chromium.org> Commit-Queue: Dan McArdle <dmcardle@chromium.org> Auto-Submit: David Van Cleve <davidvc@chromium.org> Cr-Commit-Position: refs/heads/master@{#841083}
-
Xiaocheng Hu authored
Since we are not going to use CSSKeyframesMemoryReduction, this patch removes all of its implementation. Bug: 1141814 Change-Id: If531461761974d236e6456cd5745356e0caecf11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2614839Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#841082}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/5ff758df67da..603d14ec2a26 2021-01-07 lalitm@google.com Merge "tp: stop using magic constants in tests" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I2ddc2900e7f65e25a7ccb9ca86c5323c68ddd072 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2614769Reviewed-by:
-
