GitLab

Print(symbol_group[2:4]) now works more nicely as well.

BUG=681694

Review-Url: https://codereview.chromium.org/2924343004
Cr-Commit-Position: refs/heads/master@{#478620}

BUG=

Review-Url: https://codereview.chromium.org/2936603002
Cr-Commit-Position: refs/heads/master@{#478619}

This CLs breaks retain cycles such as:
InfoBarView -> LabelLinkController ->
BeforeTranslateInfoBarController -> InfoBarView

BUG=732384

Review-Url: https://codereview.chromium.org/2933833002
Cr-Commit-Position: refs/heads/master@{#478618}

This reverts commit 0a8c2fcd.

Reason for revert: Prime suspect for Linux Test failure for {headless_browsertests, browser_side_navigation_headless_browsertests} in:

SimpleEventJsBindingsTest.RunAsyncTest
ExperimentalCommandJsBindingsTest.RunAsyncTest


Original change's description:
> Generate experimental domain commands, fix method case and stray whitespace.
> 
> An experimental class is now generated as well as the regular one, and is linked within 
> the main class.  Just like in the C++ bindings the experimental class contains everything.
> The class methods generated now start with a lowercase letter (same as in the protocol).
> Some stray white space has been removed from the template.
> 
> Bug: 
> Change-Id: I4e0d8e0f04990e9f635cab71fea18c1f21111754
> Reviewed-on: https://chromium-review.googlesource.com/529070
> Commit-Queue: Alex Clarke <alexclarke@chromium.org>
> Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#478601}

TBR=skyostil@chromium.org,alexclarke@chromium.org

No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 
Change-Id: I21a4e119fd4f0b568789c72608553f530a88adc5
Reviewed-on: https://chromium-review.googlesource.com/531304Reviewed-by: Samuel Huang <huangs@chromium.org>
Commit-Queue: Samuel Huang <huangs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478617}

This is about how we behave when NeedsPreferredWidthsRecalculation()
is true. This is a rather rare situation, and also an unfortunate one,
since min/max width calculation should be strictly bottom-up.

If we mark min/max widths of an object as dirty, we need to guarantee
that they're actually going to be recalculated. Otherwise, if the
object is left around with dirty min/max widths, it will block
subsequent min/max dirtying of any descendant. We also need to make
sure that if we mark min/max widths as dirty due to
NeedsPreferredWidthsRecalculation(), we also need to mark the min/max
widths of every child with the same issue as dirty, recursively, since
any layout change may have affected the min/max widths there too.

Documented NeedsPreferredWidthsRecalculation(). Added one test that
has been failing for ages, and one that started to fail because of the
bug referenced. Both pass now.

BUG=728548

Change-Id: I8b9325ba20a6da2329d28d21a6eca6bc1aa36c06
Reviewed-on: https://chromium-review.googlesource.com/527640Reviewed-by: Stefan Zager <szager@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@opera.com>
Cr-Commit-Position: refs/heads/master@{#478616}

https://skia.googlesource.com/skia.git/+log/f449ded72acf..5143f2f3763b

$ git log f449ded72..5143f2f37 --date=short --no-merges --format='%ad %ae %s'
2017-06-12 robertphillips Init fDevKLMMatrix in GrGLCubicEffect (possible valgrind fix)
2017-06-08 recipe-roller Roll recipe dependencies (nontrivial).
2017-06-11 update-skps Update SKP version
2017-06-10 reed remove unneeded methods
2017-06-10 reed remove unneeded SK_API
2017-06-10 reed SkXfermode no longer needs to e a flattenable

Created with:
  roll-dep src/third_party/skia


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=rmistry@chromium.org

Change-Id: I419c3450ef55198a74d06488504fc707c969e44a
Reviewed-on: https://chromium-review.googlesource.com/530964Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478615}

As a cleanup, this CL...

 - merges WebWorkerContentSettingsClient into WebContentSettingsClient,
 - renames WebWorkerContentSettingsClientProxy into
   WebWorkerContentSettingsClient, and
 - makes CreateWorkerContentSettingsClient() return std::unique_ptr instead of
   a rawptr w/ ownership.

Bug: 729500
Change-Id: Icc7b9f26f52f3312c16c36b356d2cf9c34b5a99a
Reviewed-on: https://chromium-review.googlesource.com/527763Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478614}

Merge internal change: 158527266

BUG=

Review-Url: https://codereview.chromium.org/2933613002
Cr-Commit-Position: refs/heads/master@{#478613}

This change sets the new default value for "clipping level min" to 70,
and dismantles the experiment.

BUG=672476

Review-Url: https://codereview.chromium.org/2928133002
Cr-Commit-Position: refs/heads/master@{#478612}

Don't hardcode HR as establishing a new formatting context.
Set overflow:hidden in the UA stylesheet instead. [1]
Also specify unicode-bidi:isolate [2]

Some heavy test expectation rebaselining is necessary, since making
HR overflow:hidden entails that it will now establish a PaintLayer.

[1] https://html.spec.whatwg.org/multipage/rendering.html#the-hr-element-2
[2] https://html.spec.whatwg.org/multipage/rendering.html#bidi-rendering

BUG=728499

Change-Id: I1734242d240cb236269b218283bcb16b4ca7c0e4
Reviewed-on: https://chromium-review.googlesource.com/521044
Commit-Queue: Morten Stenshorne <mstensho@opera.com>
Reviewed-by: Stefan Zager <szager@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478611}

User can change expose new files to another member or remove files that
was visible for other members in the Files app by these operations:
- Move files from a Team Drive to My Drive
- Move/Copy files from My Drive to a Team Drive
- Move/Copy files from a Team Drive to another Team Drive
- Move files from a Team Drive to Downloads
- Move/Copy files from Downloads to a Team Drive
We'll show a confirmation dialog box before executing such operation, so
that user can either choose to continue or cancel the operation after
knowing what will happen.

BUG=722324
TEST=manually tested by moving/copying files between different Team Drive/My Drive/Downloads
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2930443002
Cr-Commit-Position: refs/heads/master@{#478610}

This CL updates Blink's impl of #internal-module-script-graph-fetching-procedure
and #fetch-the-descendants-of-and-instantiate-a-module-script to match
recent spec change: https://github.com/whatwg/html/pull/2595 .

Tests: external/wpt/html/semantics/scripting-1/the-script-element/module/specifier-error.html
Bug: 727299, 594639
Change-Id: I022b3b380b408a6d5c75a59d161aea4fe2868f48
Reviewed-on: https://chromium-review.googlesource.com/528724
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478609}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/3a15e30f..4a77d640

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2934803002
Cr-Commit-Position: refs/heads/master@{#478608}

This is intended to be used in getUserMedia to implement spec-compliant
audio constraints processing.

BUG=657733

Change-Id: Ida1bc5561b16b0c5ac1628c19c71fb8f0b5a33fd
Reviewed-on: https://chromium-review.googlesource.com/517782
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478607}

This CL adds an interface for obtaining access tokens to the Identity
Service. The CL also partially ports the implementation of the
chrome.identity.getAuthToken() extension function to use it as a initial
client.

TBR=thakis

Go to chrome://extensions, enable developer mode, and inspect the background
page of the above app. At the JS console that that brings up, execute:
chrome.identity.getAuthToken((token) => {console.log(token);} )
Verify that a long alphanumeric string appears rather than an error being
reported.

Bug: 683124
Test: Install a Chrome extension with the identity permissions in its manifest.
Change-Id: I902dde8ff6d817575f07b0e3f1df1e35ed398891
Reviewed-on: https://chromium-review.googlesource.com/514047
Commit-Queue: Colin Blundell <blundell@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478606}

Add a @ScreenShooter.Directory annotation. This lets the user of
ScreenShooter set the directory names for the screen shots.

Change-Id: I64ef9183b0e46d5449bd90832e9bfba77c04abdf
Reviewed-on: https://chromium-review.googlesource.com/527158Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Commit-Queue: Anthony Berent <aberent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478605}

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2916253003
Cr-Commit-Position: refs/heads/master@{#478604}

When a new Earl Grey is launched in Showcase, the UI is reset with a new
collection. The close helper tests that it is returned to the home screen.
This allows the test to fail if it ends in a bad state (alert displayed...).
Before, if the test ended in a bad state, it would succeeded and the following
test would fail, making it hard to debug.

BUG=none

Change-Id: I4e65fb527fd25724c140f42193ab0ce53feeb1bd
Reviewed-on: https://chromium-review.googlesource.com/529105
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Louis Romero <lpromero@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478603}

Add metrics for the new Clear Browsing Data dialog on Android.
A histogram and actions are used to record which tab was used for a
deletion.
Time period changes are recorded as actions.
A bug is fixed where "ClearBrowsingData_DialogCreated" was recorded
twice because the new dialog creates two instances of
ClearBrowsingDataPreferences.

BUG=731120

Review-Url: https://codereview.chromium.org/2927063002
Cr-Commit-Position: refs/heads/master@{#478602}

An experimental class is now generated as well as the regular one, and is linked within 
the main class.  Just like in the C++ bindings the experimental class contains everything.
The class methods generated now start with a lowercase letter (same as in the protocol).
Some stray white space has been removed from the template.

Bug: 
Change-Id: I4e0d8e0f04990e9f635cab71fea18c1f21111754
Reviewed-on: https://chromium-review.googlesource.com/529070
Commit-Queue: Alex Clarke <alexclarke@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478601}

BUG=729633
TEST=VoiceOver

Review-Url: https://codereview.chromium.org/2931503002
Cr-Commit-Position: refs/heads/master@{#478600}

BUG=622743

Review-Url: https://codereview.chromium.org/2924013005
Cr-Commit-Position: refs/heads/master@{#478599}

BUG=722374

Review-Url: https://codereview.chromium.org/2891933002
Cr-Commit-Position: refs/heads/master@{#478598}

Prior to this CL, removing an Android resource wouldn't actually remove
it from the final APK.

This CL adds each resource to depfile_deps so that building after
removing an Android resource will work as expected (after a gn gen -
which is required when adding a resource as well).

Bug: 730099
Change-Id: I9429b61fa19c2c8e3d21df3e30119ba7c6bdec01
Reviewed-on: https://chromium-review.googlesource.com/527492Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Eric Stevenson <estevenson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478597}

This CL changes layouts of account rows to confrom to Material spec and bring
consistensy to the account lists.

Bug: 701221, 722910
Change-Id: Ie70304cb9c9254335bbe7aaa94ac5e7d9c2ff519
Reviewed-on: https://chromium-review.googlesource.com/527098Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478596}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/113a309a..3a15e30f

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2934753002
Cr-Commit-Position: refs/heads/master@{#478595}

Revert of Align `clear-site-data` syntax with the spec. (patchset #2 id:20001 of https://codereview.chromium.org/2929593002/ )

Reason for revert:
Despite passing all the bots, this apparently breaks `content_browsertests`: https://build.chromium.org/p/chromium.linux/buildstatus?builder=Linux%20Tests&number=57936. So, let's go fix that.

Original issue's description:
> Align `clear-site-data` syntax with the spec.
>
> We've shifted from an explicit JSON dictionary to a list of quoted
> strings (that can be parsed as JSON for forward-compatibility). That is,
> rather than `Clear-Site-Data: { "types": [ "cookies", "cache" ] }`,
> we'll use `Clear-Site-Data: "cookies", "cache"` to mean the same thing.
>
> Spec change in https://github.com/w3c/webappsec-clear-site-data/issues/27.
>
> BUG=607897
>
> Review-Url: https://codereview.chromium.org/2929593002
> Cr-Commit-Position: refs/heads/master@{#478585}
> Committed: https://chromium.googlesource.com/chromium/src/+/085b57ffe70b6cb90cd77b61585babcf59df3a95

TBR=msramek@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=607897

Review-Url: https://codereview.chromium.org/2933083002
Cr-Commit-Position: refs/heads/master@{#478594}

Rationale: I am the TL of benchmarking-dev@ (part of chrome-speed-ops@), and my
team currently takes ownership of running WebKit performance tests on the perf
waterfall (including sheriffing their perf regressions & breakages).

In term of code familiarity, I have made sizable
feature changes to the test framework in this directory (crbug.com/701059) & authored documentation for writing blink perf tests  (https://chromium.googlesource.com/chromium/src/+/master/third_party/WebKit/PerformanceTests/README.md)

To ensure that the perf tests in this directory have consistent quality, I
would want to become the owner of the directory.

In term of process, this means that I will be responsible for reviewing all the
commits in this folder. In longer term, I plan to grow other member of speed
benchmarking team to also become maintainers of this directory.

Review-Url: https://codereview.chromium.org/2928083002
Cr-Commit-Position: refs/heads/master@{#478593}

Make the WebRtcMediaStreamAdapter, which represent local streams,
use the WebRtcMediaStreamTrackMap and AdapterRef classes for the
handling of initializing, getting and uninitializing local tracks.

WebRtcMediaStreamTrackAdapter is updated to allow local tracks from
non-local sources (removed DCHECKs) which happens when redirecting
remote sources as local streams.

This is one step closer to decoupling streams and tracks.

The same thing will be done in a follow-up CL for the remote streams
case, RemoteMediaStreamImpl.

BUG=705901, 700916

Review-Url: https://codereview.chromium.org/2897603004
Cr-Commit-Position: refs/heads/master@{#478592}

It seems java isn't necesarially present on mac which is causing pain
for those trying to build all.

Bug: 
Change-Id: I9fb58ec63b3c0e06b4882473b1b116b947810a3e
Reviewed-on: https://chromium-review.googlesource.com/530944Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Commit-Queue: Alex Clarke <alexclarke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478591}

Intent to Ship: https://groups.google.com/a/chromium.org/d/msg/blink-dev/wu_fMIYkyaQ/85j16Cg6BAAJ

Bug: 731752, 680419
Change-Id: I250e03b2fb614a21a2b7eb1a27b7a11a746e6fc8
Reviewed-on: https://chromium-review.googlesource.com/529249
Commit-Queue: Mike West <mkwst@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478590}

Moving raw pointers does the same job as copying, but is more verbose and also
more confusing: e.g., is the supposed pointer meant to be a smart one?

This instance was flagged by the tool from
https://codereview.chromium.org/2919243002/.

BUG=729393

Review-Url: https://codereview.chromium.org/2927233003
Cr-Commit-Position: refs/heads/master@{#478589}

Network traffic annotation is added to network request of:
content/network/url_loader_impl.cc

BUG=656607
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2893233002
Cr-Commit-Position: refs/heads/master@{#478588}

The new-style notification should have two states: Collapsed(default) and Expanded.
To implement the feature, this CL does:
* Create NotificationHeaderView which is responsible to keeps app_icon, app_name, expand_button, settings_button, and close_button.
* When the expand_button is clicked, some view's visibility and message_view's line limit is modified to have "expanded" view.

For simplicity, I avoided dynamic creation/deletion of views on expanded state change. The expanded state only changes the existing view's property.
If it hit noticeable performance regression, I'll update the way to change the view.

BUG=728500,726242
TEST=manually tested expand/collapse function on following notifications using --enabled-new-style-notification
* A basic notification with one-line message (This doesn't have expand icon.)
* A basic notificatoin with two-line message
* A basic notification with two buttons
* A image notification

Review-Url: https://codereview.chromium.org/2925263003
Cr-Commit-Position: refs/heads/master@{#478587}

More code cleanup while reading the code.
Deja-vu?!

R=primiano@chromium.org

BUG=

Review-Url: https://codereview.chromium.org/2929673005
Cr-Commit-Position: refs/heads/master@{#478586}

We've shifted from an explicit JSON dictionary to a list of quoted
strings (that can be parsed as JSON for forward-compatibility). That is,
rather than `Clear-Site-Data: { "types": [ "cookies", "cache" ] }`,
we'll use `Clear-Site-Data: "cookies", "cache"` to mean the same thing.

Spec change in https://github.com/w3c/webappsec-clear-site-data/issues/27.

BUG=607897

Review-Url: https://codereview.chromium.org/2929593002
Cr-Commit-Position: refs/heads/master@{#478585}

BUG=730029

Review-Url: https://codereview.chromium.org/2923733003
Cr-Commit-Position: refs/heads/master@{#478584}

We just want to set a data property on the global object, without
triggering user-defined setters.

R=jochen@chromium.org
BUG=chromium:729993

Change-Id: Idd12d95282916c60f84cc0cbed9117be8d18bee4
Reviewed-on: https://chromium-review.googlesource.com/529125Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478583}

This CL removes a TODO that asked to use a proper value for
|pending_history_list_offset|. This TODO is 2 years old. According to
the DCHECK and the comments at the top of this function, no
history-navigation is expected to happens here. So the current value
(-1) is correct and the TODO can be removed.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2927023004
Cr-Commit-Position: refs/heads/master@{#478582}

Currently "less than X MB" and "less than 1 MB" are inserted into "Frees
up $1" this might not work correctly when being translated so this CL
adds three separate sentences with only a placeholder for "X MB".

BUG=725401

Review-Url: https://codereview.chromium.org/2935443003
Cr-Commit-Position: refs/heads/master@{#478581}