GitLab

This CL is in preparation for moving this code into its only remaining
consumer, which triggers a presubmit error that the code needs
formatting.

Bug: 729590
Change-Id: I64246c2cca6f44a4ce60573ff6283c0f0c4b6d72
Reviewed-on: https://chromium-review.googlesource.com/1004614Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Commit-Queue: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549459}

Previously, this only worked in browser windows. Now, it uses the button
provider to detect if the menu is open, in either browser or hosted app
windows.

Bug: 791399
Change-Id: I885a4979e729eaedbb647903209c54b63286da22
Reviewed-on: https://chromium-review.googlesource.com/991892
Commit-Queue: Matt Giuca <mgiuca@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549458}

Bug: webrtc:8982
Change-Id: I978e0a2544f6f71c250da9b0ec7aeb8e1a901bb9
Reviewed-on: https://chromium-review.googlesource.com/997336Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Commit-Queue: Jonas Olsson <jonasolsson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549457}

AtomicInline fragment use legacy_paint_offset which is the offset to its
parent, while others use paint_offset which is the offset to line_box.
The legacy_paint_offset is not correct when AtomicInline is child of an
inline element that has fixed border/margin/padding. It's not easy to
deal with nested situation by passing legacy_paint_offset.

In this solution, compute the legacy_paint_offset when paint AtomicInline:
legacy_paint_offset = paint_offset - offset from parent to linebox.

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_layout_ng;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Ie3bcfbbf3b9239c5c5e77504242aed40e553ea0e
Reviewed-on: https://chromium-review.googlesource.com/995313
Commit-Queue: cathie chen <cathiechen@tencent.com>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549456}

Currently, when we reify a value, we try to first reify it as a single
value. If that fails, we try reifying it as a list value. This code
was written with the incorrect assumption that only list-valued
properties are stored as CSSValueLists. This is not true, as many single
valued properties (such as grid-auto-flow) are stored as CSSValueLists.

This patch adds an additional check so that only properties that are
explicitly marked as list-valued are reified as list values.

Bug: 829881
Change-Id: I965e38355b9859a43fcb1b940f19237f9f07fdf6
Reviewed-on: https://chromium-review.googlesource.com/1002214Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549455}

Add myself to watchlists for browsing_data and site settings.

Change-Id: Ib24d1669f5daffd24d043dd23eb8d7f6c6a52af2
Reviewed-on: https://chromium-review.googlesource.com/1004694Reviewed-by: Ramin Halavati <rhalavati@chromium.org>
Commit-Queue: Christian Dullweber <dullweber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549454}

This CL adds the second chunk of elements to the animated vector
drawable that is displayed at the top of the sign-in screen. Video
of the resulting animation: https://crbug.com/814728#c22.

Animation repeating is now done in the code (thus changes in
SigninView.java), as there's no reliable way to repeat a set of
animations from XML (<set> tag ignores "android:repeatMode" attribute).

Bug: 814728
Change-Id: I034fbb6b9d27205998d7c4705d3321b4d16a65c4
Reviewed-on: https://chromium-review.googlesource.com/1000866Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549453}

Server response may contain useful error descriptions.

      "Server returned wrong response code: 403: Rate limit exceeded"

Bug: None
Test: Try opt-in with rate limited account and see:
Change-Id: I853a8767baab0a733901a5a956087261e979cd85
Reviewed-on: https://chromium-review.googlesource.com/987419Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Yury Khmel <khmel@chromium.org>
Commit-Queue: Shuhei Takahashi <nya@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549452}

CL:988375 fixed AXLayoutObject::CanIgnoreSpaceNextTo by accessing
LayoutText::First/LastTextBox() directly. Since these functions
will be gone in LayoutNG, this patch abstracts what it does and
hide InlineTextBox inside of LayoutText.

Actual implementation of these functions for LayoutNG will be
done after CL:986982 adds retrieval of NGInlineItem. It's
possible with NGOffsetMapping or NGPhysicalFragment, but
NGInlineItem would be better fit.

Bug: 821906, 636993, 830546
Change-Id: If590e8c01e59d58b0f77ba6b3f57e35e9c29acb3
Reviewed-on: https://chromium-review.googlesource.com/997912
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549451}

This change adds a list of abandoned devices to U2fRequest. This list
gets populated, when the request gives up on a device due to an error.
Devices in this list will not be considered when IterateDevice() is
called.

Bug: NONE
Change-Id: I6760b956f2fefa31631379c181224b888ee32902
Reviewed-on: https://chromium-review.googlesource.com/1001897
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549450}

This makes it easier to track down issues in specific areas of the
JSONParser.

Bug: 489301
Change-Id: I7946451edd2323cabc3fd31c9841a9c6834abd20
Reviewed-on: https://chromium-review.googlesource.com/1002815
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549449}

This is a reland of 52d81474

Original change's description:
> Actually check whether extension is in kiosk mode
> 
> Add the missing check for actually being in kiosk mode, but keep the
> autotest bail to simplify testing of the feature.
> 
> BUG=chromium:826568
> TEST=Ran autotest, verified that extension can't access edid.
> 
> Change-Id: I8f93e29d8d977b0977b3eb597ce2aae263b4e9b9
> Reviewed-on: https://chromium-review.googlesource.com/982619
> Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
> Commit-Queue: Felix Ekblom <felixe@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#548147}

Bug: chromium:826568
Change-Id: I4a005a804d1de6325fb145f62e7d1d778ee5b201
Reviewed-on: https://chromium-review.googlesource.com/997412
Commit-Queue: Felix Ekblom <felixe@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549448}

This patch adds some browser tests that verifies CORS checks for
requests initiated from local files.

Tests verify if;
 - HTTP request has an expected Origin header, 'null' for production mode,
   'file://' for test mode with --allow-file-access-from-files flag.
 - CORS check pass iff the server allow 'null' origin for production
    mode, 'file://' origin for the test mode.

These tests should be provided over file:// protocol, and need to modify
--allow-file-access-from-files flag. That requires exaggerated setup if
we want to have these tests in Blink layout tests, that's why these are
in browser tests here though relevant implementations are in Blink and
the network service.

Bug: 825567
Change-Id: I986a110f6cddc0349b83cb0ade16ef30581c6ce4
Reviewed-on: https://chromium-review.googlesource.com/987593Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549447}

CertUrl and validityUrl and request URL must be absolute.
https://github.com/WICG/webpackage/pull/170

Currently the validity of certUrl and validityUrl is checked in ParseSignature().
But there is no validity check of the request url.
And also there is no has_ref() check of all of them.

So this CL adds these checks:
 - is_valid() and !has_ref() for request URL.
 - !has_ref() check for certUrl and validityUrl.

Bug: 829932
Change-Id: I4502cb7cbb381e631292c8fd7a1ca998614f21b3
Reviewed-on: https://chromium-review.googlesource.com/1002338Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549446}

Group mLatestVersion and mMarketURL into VersionConfig to allow the flexibility
to return different version config in downstream.

Bug: b/77151591
Change-Id: Ie251a5f953a82a480ea19973b41fdeb8c687100e
Reviewed-on: https://chromium-review.googlesource.com/987836Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Commit-Queue: Shuo Weng <shuow@google.com>
Cr-Commit-Position: refs/heads/master@{#549445}

Since these files are not used by Blink, we can put them in
services/network/cors.

This will make it easier for CORSURLLoader to depend on
cors::PreflightController.

Bug: 803766
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Ibebe686a54e70872b33db06bf7ed72d653d4d1f6
Reviewed-on: https://chromium-review.googlesource.com/999692
Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549444}

With this change, alternate_version_generator now also updates
occurrences of the version number found in the .rdata section of PE
images. As a result, Chrome runs and thinks it is the altered version.

While at it, I also switched from using a custom MappedFile to the one
in base, which now supports r/w mappings.

BUG=461856
R=huangs@chromium.org

Change-Id: I4e5c3bbc71e73a05b541d12693e512a7ac1b3ecb
Reviewed-on: https://chromium-review.googlesource.com/1001896
Commit-Queue: Greg Thompson <grt@chromium.org>
Reviewed-by: Samuel Huang <huangs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549443}

This CL changes the ownership of base::Clock and base::TickClock from
injectee-owned to injecter-owned. Before this CL, these instances are
owned by the owner of the injectee or one of the injectees themselves.
That makes the ownership handling complex.

After this CL, the injectee of clocks never own the clock. Instead,
injecters owns a clock for testing, and a shared clock is used on the
production code.

Bug: 789079
Change-Id: Ifb724d96099e6324cfdb7fbf50a6a87cc69449f2
Reviewed-on: https://chromium-review.googlesource.com/989457Reviewed-by: David Roger <droger@chromium.org>
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549442}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/c366fc9e..86b145e5

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org

Change-Id: I858c7a08a20d2fa0853507c1da20f75100e231a5
Reviewed-on: https://chromium-review.googlesource.com/1004193Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549441}

Scheduler classes are being renamed as part of scheduler
architecture refactoring.

Bug: 826203
Change-Id: Ic9a74dd8ef8238c0d83dda03d3c9e5a6f505d85b
Reviewed-on: https://chromium-review.googlesource.com/994853
Commit-Queue: Yuta Kitamura <yutak@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549440}

For ServiceWorkerProviderHost:
* Remove IsHostToRunningServiceWorker(). This was a subtle function
since it was used mainly as !IsProviderForClient(), but it was
also false when the service worker was still starting up.
* Add IsProviderForServiceWorker() as an analogue to
IsProviderForClient().
* Improve documentation/terminology throughout for consistency
with ServiceWorkerProviderContext.

Change-Id: I69a0449aeda41f23f41bee767524aebf5ff9b1d2
TBR: kinuko
Reviewed-on: https://chromium-review.googlesource.com/1002216
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549439}

https://chromium.googlesource.com/catapult.git/+log/b5c70ce2580e..1bae362e7789

$ git log b5c70ce25..1bae362e7 --date=short --no-merges --format='%ad %ae %s'
2018-04-09 simonhatch HistogramSet - Merge by only a subset of tags.

Created with:
  roll-dep src/third_party/catapult


The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=sullivan@chromium.org

Change-Id: Ic0d3e1eaaedd22c46eade2ea5c780e496a214453
Reviewed-on: https://chromium-review.googlesource.com/1004007Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#549438}

'type' doesn't give much information. Use more informative name.

Bug: 770147

Change-Id: Iad53dfc11347c149f1d076cc5c326437df2f28c4
Reviewed-on: https://chromium-review.googlesource.com/989387
Commit-Queue: JunHo Seo <junho0924.seo@lge.com>
Reviewed-by: Hugo Holgersson <hugoh@vewd.com>
Reviewed-by: Stefan Zager <szager@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549437}

These files were renamed in crrev.com/c/986112, but they should have
"_impl" in the back. This patch corrects those names.

Bug: 826203
Change-Id: Ib4cf5e51f1e5cd8d517486a0e1fb177bb30d8f78
Reviewed-on: https://chromium-review.googlesource.com/994504
Commit-Queue: Yuta Kitamura <yutak@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549436}

Bug: none
Test: none
Change-Id: Iefdc0ad2f75590e077b5599b4f6e2984f89747d3
Reviewed-on: https://chromium-review.googlesource.com/940769
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549435}

'loading.desktop.network_service' fails randomly when uploading
json results, e.g.
https://ci.chromium.org/buildbot/chromium.perf.fyi/Mojo%20Linux%20Perf/5265

It seems that we might miss some charts in certain conditions.
e.g. We don't have 'timeToInteractive_std' when all values are None.

This CL handled the case by only doing diff on common charts / points
between control and enabled chartjson result.

Bug: 827442
Change-Id: Ibb1b9004d48bdfc2fa017c4acf57c989ae15c17f
Reviewed-on: https://chromium-review.googlesource.com/1003520Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Commit-Queue: Chong Zhang <chongz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549434}

Moves browser-window-specific functionality from AppMenuButton into new
subclass BrowserAppMenuButton, and made AppMenuButton a base class of
HostedAppButtonContainer::AppMenuButton.

BrowserViewButtonProvider now provides an AppMenuButton, rather than a
generic MenuButton, allowing code that is common to browser and hosted
app windows to interact with the app menu (e.g., detecting whether it is
open, and closing it). This will be used in a future CL to fix the code
that hides the zoom bubble if the menu is open so that it works in
hosted app windows.

Tbr: nyquist@chromium.org
Bug: 791399
Change-Id: I2bce579b2c220cd70c0a02e95f270e0f3d13ba8d
Reviewed-on: https://chromium-review.googlesource.com/983252
Commit-Queue: Matt Giuca <mgiuca@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549433}

A chrome extension has implicit host permissions to its own origin (chrome-
extension://extension_id/). This allows the extension to monitor and modify
requests to any of its own resources using the WebRequest API.

However, this allows an extension with DNR to also possibly/mistakenly block or
redirect its own background page. This is not a problem for the WebRequest API
since it is (generally) the background page which does the blocking in case of
the WebRequest API.

To fix, simply whitelist all resources on the chrome-extension scheme as far as
DNR is concerned.

BUG=829225

Change-Id: I022f137f1fde20276de22f0f8529aa4f1c9a53db
Reviewed-on: https://chromium-review.googlesource.com/1000770Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549432}

In the Files App Settings menu, the storage indicator should be clickable
and link to the Settings -> Device -> "Storage management" UI.

Bug: 680347
Test: Manually tested
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I3703b2d94852a3011e7e6d91b2afe010400795b5
Reviewed-on: https://chromium-review.googlesource.com/999240
Commit-Queue: Alexey Baskakov <loyso@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Naoki Fukino <fukino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549431}

This optimize especially for the following simple case:
<div style="overflow: hidden">
  ABC
</div>
which seems quite common in real web pages.

This CL saves OverflowClip node and Save/ClipRect/Restore operations
when the contents don't overflow.

Performance results:
CT: (https://ct.skia.org/results/cluster-telemetry/tasks/chromium_perf_runs/wangxianzhu-20180409001618/html/index.html)
 record_time: -2.7%
 paint_op_count: -2%
 painter_memory_usage: -0.7%

rasterize_and_record_micro.top_25 (https://pinpoint-dot-chromeperf.appspot.com/job/113ce7b4c40000):
 record_time: -4.5%
 paint_op_count: -2.4%
 painter_memory_usage: -1.8%

Bug: 803867
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Ia12e0182cb2b712013dca3e2cb9805d2d65cd7df
Reviewed-on: https://chromium-review.googlesource.com/1001752
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549430}

For:
<div style="transform: translateX(10px)">
  <div>A</div>
  <div style="overflow: hidden">B</div>
  <div>C</div>
</div>
previously we emitted the following paint operations:
  Save
    Transform
    Draw A
  Restore
  Save
    Transform
    ClipRect
    Draw B
  Restore
  Save
    Transform
    Draw C
  Restore

With this CL, we emit the following paint operations:
  Save
    Transform
    Draw A
    Save
      ClipRect
      Draw B
    Restore
    Draw C
  Restore
by reusing transform state across clip state which has the same
transform.

CT result: https://ct.skia.org/results/cluster-telemetry/tasks/chromium_perf_runs/wangxianzhu-20180406052047/html/index.html
This CL reduces paint_op_count by 2.6%.

Bug: 803867
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Id0d41b98ffd35440f4a608856650f7109362d425
Reviewed-on: https://chromium-review.googlesource.com/999095
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Tien-Ren Chen <trchen@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549429}

This CL:
 - Changes the AdDelayThrottle lifetime so it is always created, in
   an enabled or dryrun state
 - Adds an enum histogram for the product of {isAd, isSecure} in
   the destructor.
 - Fixes a bug where syncXHRs were breaking due to us not
   properly handling DetachFromCurrentSequence(). Added a
   browser test for that case.

Bug: 829042
Change-Id: Ib4bc572f1edce2c975b72f4a6d128c65b6acd2bc
Reviewed-on: https://chromium-review.googlesource.com/998537
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Gayane Petrosyan <gayane@chromium.org>
Reviewed-by: Josh Karlin <jkarlin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549428}

Bug: 829722
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I372a6f71ff768fdcc5b113b86617db5b92b10e1c
Reviewed-on: https://chromium-review.googlesource.com/998979Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549427}

This CL updates the minor text color to increase the contrast ratio to 4.5
where previously it was only 2.4.

Before:
https://bugs.chromium.org/p/chromium/issues/attachment?aid=333305&signed_aid=nJkKAfQZwVySGN2WxDNekw==&inline=1

After:
https://bugs.chromium.org/p/chromium/issues/attachment?aid=333570&signed_aid=czXiHkbVYr98gGQf_RowuQ==&inline=1

Bug: 823197
Change-Id: I45a52eb1cf3782202d348a7617557ffc1ba6b139
Reviewed-on: https://chromium-review.googlesource.com/999275
Commit-Queue: Alan Cutter <alancutter@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549426}

With this change, the code now only lives on the UI thread.

Bug: 825242, 777915
Change-Id: I3330347910559bb464a693a412182930415cb639
Reviewed-on: https://chromium-review.googlesource.com/998526
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Nate Fischer <ntfschr@chromium.org>
Reviewed-by: Jialiu Lin <jialiul@chromium.org>
Reviewed-by: Luke Z <lpz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549425}

When you use multiple fingers to drag the keyboard around, the events
for these get sent to the event filter sequentially. Check for a
pointer ID (which is unique per touch point) and include it in the
active drag descriptor. Ignore non-matching pointer events.

Bug: 802992
Change-Id: I5a3948719e5c103ee1aa618afc3fe36939567326
Reviewed-on: https://chromium-review.googlesource.com/979739Reviewed-by: Yuichiro Hanada <yhanada@chromium.org>
Commit-Queue: Blake O'Hare <blakeo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549424}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/02ef76b018ac..871e7778ef8b

$ git log 02ef76b01..871e7778e --date=short --no-merges --format='%ad %ae %s'
2018-03-28 pprabhu gerrit: Add 'private' subcommand.
2018-04-09 dgarrett cros tryjob: Remove --waterfall option.
2018-04-09 cmtice [clang-tidy builder] Change board from 'kahlee' to 'grunt'.
2018-04-05 mxt Revert "remove whirlwind-no-vmtest-pre-cq from default set"
2018-04-06 xzhou Update tss group test to add bootlockboxd to tss.
2018-04-06 dgarrett cbuildbot_launch: RunCbuildbot -> Cbuildbot.

Created with:
  roll-dep src/third_party/chromite
BUG=chromium:None,chromium:752342,chromium:830691,chromium:829055,chromium:None


The AutoRoll server is located here: https://chromite-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: Iad8d29ecd5f47e06ce4867453d3ba4a4606d835c
Reviewed-on: https://chromium-review.googlesource.com/1004003
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#549423}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/6bd23308..c366fc9e

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org

Change-Id: I18185cfb20c8da9a084b7f372baeb35e0af764dd
Reviewed-on: https://chromium-review.googlesource.com/1003652Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549422}

Split the RWHVCocoa showLookUpDictionaryOverlayInternal,
showLookUpDictionaryOverlayFromRange, and
showLookUpDictionaryOverlayAtPoint into browser-side and AppShim-side
components.

Remove RenderWidgetHostViewMacDictionaryHelper, because it ends up
having no effect. It is used to specify a target NSView on which to
draw the dictionary overlay, but it is only used for the PDF plugin,
which is incapable of drawing the dictionary overlay (because it
can't look up the point in the view at which it is supposed to be
drawn).

This should be a cut-and-paste with no functional effects.

Bug: 821651
Change-Id: Ie443bdc76a5e0b28d2f6595fcff0601f8ce4a228
Reviewed-on: https://chromium-review.googlesource.com/1000765
Commit-Queue: ccameron <ccameron@chromium.org>
Reviewed-by: ccameron <ccameron@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549421}

This CL refactors browsertests in browser_non_client_frame_view_ash_browsertest.cc.

The HostedAppNonClientFrameViewAshTest test is split up into smaller tests for
theme color, content setting icons and browser action icons.

The BrowserNonClientFrameViewAshTest tests reduce their boiler plate code with
a GetFrameViewAsh() helper function.

Bug: 822146
Change-Id: I2fc50086f50d719873cf8b18fb044c2d63f1e8c8
Reviewed-on: https://chromium-review.googlesource.com/994912
Commit-Queue: Alan Cutter <alancutter@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: calamity <calamity@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549420}