- 11 Sep, 2018 40 commits
-
-
Christian Biesinger authored
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I2c47b2a941163b30b3a37bd9ef2c08c9b9ccd2ed Reviewed-on: https://chromium-review.googlesource.com/1212382Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#590472}
-
Will Harris authored
../../ui/base/test/ui_controls_internal_win.cc(204,9): warning: implicit conversion loses integer precision: 'WPARAM' (aka 'unsigned long long') to 'UINT' (aka 'unsigned int') [-Wshorten-64-to-32] w_param, reinterpret_cast<MOUSEHOOKSTRUCT*>(l_param)); ^~~~~~~ ../../ui/base/test/ui_controls_internal_win.cc(405,25): warning: implicit conversion loses integer precision: 'std::vector<tagINPUT, std::allocator<tagINPUT> >::size_type' (aka 'unsigned long long') to 'UINT' (aka 'unsigned int') [-Wshorten-64-to-32] if (::SendInput(input.size(), input.data(), sizeof(INPUT)) != input.size()) ~~ ~~~~~~^~~~~~ ../../ui/base/test/ui_controls_internal_win.cc(520,25): warning: implicit conversion loses integer precision: 'std::vector<tagINPUT, std::allocator<tagINPUT> >::size_type' (aka 'unsigned long long') to 'UINT' (aka 'unsigned int') [-Wshorten-64-to-32] if (::SendInput(input.size(), input.data(), sizeof(INPUT)) != input.size()) ~~ ~~~~~~^~~~~~ BUG=879657 Change-Id: Iea866217701ef4b9f67b63a58a6ab6a35a88b1a8 Reviewed-on: https://chromium-review.googlesource.com/1217848 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#590471}
-
Doug Arnett authored
Creates HostFilter which wraps a host suffix BloomFilter and adds logic for checking a set of host suffixes for a url against the BloomFilter. Also, adds IsBlacklisted() api support to PreviewsHints and PreviewsOptimizationGuide. Coming next will be populating this blacklist from Cacao Configuration proto and tests at the guide level. Bug: 864640 Change-Id: Idd8facf0d4718f1e9bd41f4d24ef03691cfb9590 Reviewed-on: https://chromium-review.googlesource.com/1216716 Commit-Queue: Doug Arnett <dougarnett@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#590470}
-
Ted Choc authored
BUG=800033 Change-Id: Id64a04b6f46ec54ce4ec0a6a6a29de74e398b37a Reviewed-on: https://chromium-review.googlesource.com/1220190Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#590469}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/fb18639804e7..e6146bd7be6f git log fb18639804e7..e6146bd7be6f --date=short --no-merges --format='%ad %ae %s' 2018-09-11 jvanverth@google.com Fix float overflow in shadow tessellator 2018-09-11 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 0d0fb43f34ee..2da04538b4ff (2 commits) 2018-09-11 fmalita@chromium.org Reland: add SkPath::shrinkToFit 2018-09-11 bsalomon@google.com Make GrAAConvexTessellator bail on paths that map to inf/nan in device space. Created with: gclient setdep -r src/third_party/skia@e6146bd7be6f The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:882609 TBR=caryclark@chromium.org Change-Id: I0db5cee64e208a6b6bc158ce8f82ebc97b0166c5 Reviewed-on: https://chromium-review.googlesource.com/1220233Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#590468}
-
David Black authored
By adding a parent container to |footer_|, we will reserve the same amount of layout space whether or not that view is visible. This is because the parent container uses a FillLayout which does not factor visibility in when measuring. Bug: b:113871610 Change-Id: I4810368f5de3af4c3b8152e080acf7c2249304fc Reviewed-on: https://chromium-review.googlesource.com/1219899Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#590467}
-
Fady Samuel authored
Delete some dead code in / around RenderWidgetHostImpl::SubmitCompositorFrame. Bug: none Change-Id: If4666e6213946340bd0bdadefe733160a945ae0c Reviewed-on: https://chromium-review.googlesource.com/1220481Reviewed-by:
Saman Sami <samans@chromium.org> Commit-Queue: Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#590466}
-
Xi Cheng authored
We deliberately leave out the process phase metadata information in the StackSample encoding in this CL. Implementing that metadata support will need to be done differently to make it extensible to general metadata. We will implement it using follow-up CLs. The old CallStackProfileBuilder using the legacy Sample encoding is renamed to LegacyCallStackProfileBuilder. Related files are renamed accordingly too. Note that the old CallStackProfileBuilder is still used in production. Bug: 851163, 804942 Change-Id: I235bd8cc839de4e663f1d4bd49aa24485649692a Reviewed-on: https://chromium-review.googlesource.com/1205896Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Siddhartha S <ssid@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Alexei Filippov <alph@chromium.org> Reviewed-by:
Mike Wittman <wittman@chromium.org> Commit-Queue: Xi Cheng <chengx@chromium.org> Cr-Commit-Position: refs/heads/master@{#590465}
-
Lei Zhang authored
Change-Id: If8bd9653c8ebaffa2d2bd50fad1c1f0a412a5c88 Reviewed-on: https://chromium-review.googlesource.com/1215052Reviewed-by:
Miguel Casas <mcasas@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#590464}
-
Christopher Cameron authored
Pass the "is widget top level" parameter at BridgedNativeWidgetImpl init rather than querying it from the NativeWidgetMac. Remove the NativeWidgetMac member and accessor from BridgedNativeWidgetImpl. Move NativeWidgetMac::GetBridge[Host]ImplForNativeWindow to BridgedNativeWidget[Host]Impl::GetFromNativeWindow (since there's no reason to require going through NativeWidgetMac). Change-Id: I1ed0753acc21dc45e8ed8fbe893b83e30c6abe34 Reviewed-on: https://chromium-review.googlesource.com/1217516 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#590463}
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/56e273293a3c..ddda0b5b8a96 git log 56e273293a3c..ddda0b5b8a96 --date=short --no-merges --format='%ad %ae %s' 2018-09-11 nodir@google.com Fetch current Gerrit CL info in tryserver Created with: gclient setdep -r src/third_party/depot_tools@ddda0b5b8a96 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:694348 TBR=agable@chromium.org Change-Id: Ib6ddaf771ff7ed802afe88d5f67b875ed4698ca2 Reviewed-on: https://chromium-review.googlesource.com/1220427Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#590462}
-
Zhiqiang Zhang authored
This CL migrates the MediaNotification into a separate CafNotificationController class, to handle all the notification logic. Bug: 711860 Change-Id: Ib01cd61f9e84a925a122a5f01161336d801caade Reviewed-on: https://chromium-review.googlesource.com/1217752 Commit-Queue: Zhiqiang Zhang <zqzhang@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#590461}
-
Katie D authored
This was introduced in https://chromium-review.googlesource.com/1136842. Bug: 882868,882923 Change-Id: I507ffe0d35dfe568276971ca1b6775fcc150896b Reviewed-on: https://chromium-review.googlesource.com/1219930 Commit-Queue: Katie Dektar <katie@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#590460}
-
Will Harris authored
../../services/service_manager/tests/lifecycle/lifecycle_unittest.cc(329,28): warning: implicit conversion loses integer precision: 'size_t' (aka 'unsigned long long') to 'int' [-Wshorten-64-to-32] base::BarrierClosure(instance_count, loop.QuitClosure()); ~~~~ ^~~~~~~~~~~~~~ ../../services/service_manager/tests/lifecycle/lifecycle_unittest.cc(365,28): warning: implicit conversion loses integer precision: 'size_t' (aka 'unsigned long long') to 'int' [-Wshorten-64-to-32] base::BarrierClosure(instance_count, loop.QuitClosure()); ~~~~ ../../mojo/public/cpp/platform/tests/platform_handle_unittest.cc(108,61): warning: implicit conversion loses integer precision: 'std::basic_string<char, std::char_traits<char>, std::allocator<char> >::size_type' (aka 'unsigned long long') to 'int' [-Wshorten-64-to-32] test_file.WriteAtCurrentPos(kTestData.data(), kTestData.size()); ~~~~~~~~~~~~~~~~~ ~~~~~~~~~~^~~~~~ ../../mojo/public/cpp/platform/tests/platform_handle_unittest.cc(130,40): warning: implicit conversion loses integer precision: 'std::vector<char, std::allocator<char> >::size_type' (aka 'unsigned long long') to 'int' [-Wshorten-64-to-32] file.Read(0, buffer.data(), buffer.size()); ~~~~ ~~~~~~~^~~~~~ BUG=879657 Change-Id: Icddec5f4ba2e5e0365fe4e70268730ef4e5aa99d Reviewed-on: https://chromium-review.googlesource.com/1220471Reviewed-by:Ken Rockot <rockot@chromium.org> Commit-Queue: Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#590459}
-
Annie Sullivan authored
Change-Id: I90ab7c395012cedcccd48b54423b75a5b7a3906d Reviewed-on: https://chromium-review.googlesource.com/1213550Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Commit-Queue: Annie Sullivan <sullivan@chromium.org> Cr-Commit-Position: refs/heads/master@{#590458}
-
Kurt Horimoto authored
Bug: none Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: If45349c095ecc2044d5987d954c25604d3aadc0e Reviewed-on: https://chromium-review.googlesource.com/1167607 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#590457}
-
Eugene But authored
Updated test case to verify more WebState and NavigationManager properties. Bug: 877671 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: If05a25202b8433e7633015f7da73f9cc4d9d8e64 Reviewed-on: https://chromium-review.googlesource.com/1218282Reviewed-by:
Danyao Wang <danyao@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#590456}
-
sebsg authored
Change-Id: I48f30252eb920a4e9a89291a79e1ff612cb72595 Reviewed-on: https://chromium-review.googlesource.com/1220566Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#590455}
-
Aldo Culquicondor authored
Extract platform independent code from the GvrSchedulerDelegate for reusability and testing. Bug: 875291 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Iaa90b42ea7e81995c32344c9da083c96bdc55a71 Reviewed-on: https://chromium-review.googlesource.com/1195711 Commit-Queue: Aldo Culquicondor <acondor@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#590454}
-
Harley Li authored
Set the minimum height of storage panel's key-value table so that the preview panel down below won't obscure it when dragged upward, confusing the users. Screenshot: https://imgur.com/a/VhC4X7x Bug: 865091 Change-Id: I152f9082f6dd1646a1e8eaeb4d9111b181546553 Reviewed-on: https://chromium-review.googlesource.com/1220477 Commit-Queue: Haihong Li (Harley) <hhli@chromium.org> Reviewed-by:
Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#590453}
-
Eric Aleshire authored
This action performs the actual autofilling of the form, by selecting a specific element in an autofillable form, then tapping on the autofill suggestion. The profile data used to autofill is hardcoded in this file for now. uwyiming@ may have plans to move this profile data into the test recipe in the future, but for now this is sufficient. Additionally, I move some shared code between the click and autofill actions to a base class. I tested this action using a recipe I wrote against Walmart's shop page. Bug: 881096 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I9629a11da48a3910c1765f455491456005aada75 Reviewed-on: https://chromium-review.googlesource.com/1208141 Commit-Queue: ericale <ericale@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Eric Noyau <noyau@chromium.org> Cr-Commit-Position: refs/heads/master@{#590452}
-
Ian Clelland authored
This queues a report through the Reporting API whenever VR or XR device access are requested in a frame in which the 'vr' feature is not allowed according to feature policy. Bug: 867471 Cq-Include-Trybots: luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I5e0256c799f986e30b1f3746ef0fce1b6d9f93eb Reviewed-on: https://chromium-review.googlesource.com/1195438Reviewed-by:
Brandon Jones <bajones@chromium.org> Commit-Queue: Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#590451}
-
wutao authored
The last line of sytled_label does not have enough space for customized line height. This patch fixes this bug. Bug: b/114129692 Test: StyledLabelTest.LineHeight Change-Id: I2a218b244983043d9f23d413fe33acefb5ac890f Reviewed-on: https://chromium-review.googlesource.com/1217068 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#590450}
-
W. James MacLean authored
This CHECK was inserted for debugging purposes, but it's fine to convert it to a NOTREACHED to avoid crashing Android SI users in the wild. Bug: 877092 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I35791a7af641c2425935aa095a16faf44c8cfa20 Reviewed-on: https://chromium-review.googlesource.com/1220100 Commit-Queue: James MacLean <wjmaclean@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#590449}
-
Kevin McNee authored
In WebViewImpl, we initialize something called |cachedZoom| which is never used. This is presumably supposed to be |cachedZoomFactor|. We give this a more descriptive name and initialize it with the correct value. We also explicitly initialize |userAgentOverride|. Bug: None Change-Id: Id506c12b5b53502b44fcea575b96803a584ac31b Reviewed-on: https://chromium-review.googlesource.com/1219905Reviewed-by:
James MacLean <wjmaclean@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#590448}
-
Xi Cheng authored
Change-Id: Icc77d7f903bf29fb79fee5270e97098208ad154c Reviewed-on: https://chromium-review.googlesource.com/1219970Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Xi Cheng <chengx@chromium.org> Cr-Commit-Position: refs/heads/master@{#590447}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 91dfc811. With Chromium commits locally applied on WPT: d3406a52 "Add more WPT tests for mixed-content check in workers/worklets (2/2)" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/24554 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lukebjerring No-Export: true Change-Id: Ic3c86c431478bd7ddb070bb1f3ce283106349175 Reviewed-on: https://chromium-review.googlesource.com/1219988 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#590446}
-
Kurt Horimoto authored
Now that there is a single FullscreenControllerObserver function for all fullscreen-driven animations, we can remove duplicated code and consolidate setup to a single function. Bug: none Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I25a0b7f9797f2a62f79317f9f1ec8121da5dbf5c Reviewed-on: https://chromium-review.googlesource.com/1053179 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#590445}
-
Ryan Daum authored
Adds a facility to stop touch events from being processed by all event handlers and rewriters while the screen is off. CastTouchEventGate is installed by the window manager as the first event rewriter in the chain. When it is eanbled it will discard all touch events, but notify registered observers that it has done so, so the device can be woken up and touch event processing restored. Bug: internal b/109894724 Test: unit test and manual on device Change-Id: I82cf69d3d02f476256b28e2c3994b264fa31fc91 Reviewed-on: https://chromium-review.googlesource.com/1220166Reviewed-by:
Alex Sakhartchouk <alexst@chromium.org> Reviewed-by:
Kevin Schoedel <kpschoedel@chromium.org> Commit-Queue: Ryan Daum <rdaum@chromium.org> Cr-Commit-Position: refs/heads/master@{#590444}
-
Xianzhu Wang authored
Bug: 882973,882974,882975 Change-Id: If63c4f260a11360f2044dc94a14fea20c2133ac4 Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees Reviewed-on: https://chromium-review.googlesource.com/1220467Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#590443}
-
danakj authored
This reverts commit 7c4f701b. Reason for revert: This is asserting on bots, something is wrong. Original change's description: > Make ClientResourceProvider::ReceiveReturnsFromParent() be O(N+MlogM) > > Currently this methods works as O(N*M), where > N = size of imported_resources_ in the provider > M = number of resources being received by the provider > > That is because each received element is removed individually from the > imported_resources_ set, and each removal will cost O(N). > > Instead, sort the incoming resources, then walk through the two > sets of resources in parallel, which is O(N+M). During this walk, > replace resources to be removed from imported_resources_ with resources > that we are keeping as we walk, which is O(1). Then erase the empty space > created by this process at the end of the loop, which is O(N). This > makes the complexity O(2N+M) = O(N+M). > > This is similar to the std::remove_if() algorithm, except that we have > to write it ourselves to avoid O(M) work at each step, and instead walk > the received resources in parallel. > > We also sort the returned M resources as a prelude, to ensure we can do > the walk in parallel. This costs O(MlogM), making the whole thing > O(N+MlogM). > > Similarly, for ClientResourceProvider::ReleaseAllExportedResources() > stop removing elements individually. In this case we can use > base::EraseIf to iterate through the set, act on each element, and > return true if it should be erased. > > R=piman@chromium.org > > Bug: 881295 > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel > Change-Id: I94522eb07e2f09b20a10d8f254faa63fd2ab9d0e > Reviewed-on: https://chromium-review.googlesource.com/1211908 > Commit-Queue: danakj <danakj@chromium.org> > Reviewed-by: Antoine Labour <piman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#590347} TBR=danakj@chromium.org,piman@chromium.org Change-Id: I37c9b08ad6cb2d18aeee224f4c282e22612bb1d4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 881295 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/1219996Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#590442}
-
Victor Costan authored
This CL updates the chromium_logger.h implementation with the changes in https://github.com/google/leveldb/commit/7b945f200339aa47c24788d3ee9910c09c513843. The CL also does minor cleanup in the Chromium port code. Change-Id: I6ec4a464963bd0011ee01ea9879fda5d8836418e Reviewed-on: https://chromium-review.googlesource.com/1205639Reviewed-by:
Chris Mumford <cmumford@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#590441}
-
Lan Wei authored
We have an issue that Windows virtual Keyboard appears whenever a text area is selected with the mouse or keyboard. Since we decide to only show the virtual keyboard when the input type is touch. Bug: 871756 Change-Id: Ia804afad907341ed478409d223b67f09c6b7f8f3 Reviewed-on: https://chromium-review.googlesource.com/1194406Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Keigo Oka <oka@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#590440}
-
Hiroshige Hayashizaki authored
To expose FetchClientSettingsObject in FetchContext in https://chromium-review.googlesource.com/1200042, this CL moves FetchClientSettingsObject to platform/. Bug: 880027 Change-Id: I71c9eac42fc561e58742398cfa229b21c31662c7 Reviewed-on: https://chromium-review.googlesource.com/1198889 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#590439}
-
Marijn Kruisselbrink authored
This takes a somewhat hacky approach to return an async iterator from getEntries(), but at least it makes for await work on it. Also adds create option to getFile and getDirectory to be able to create new entries. Bug: 872465 Change-Id: I297c89c917bc86dfc2b3bbcf2d501ff5e59a85d7 Reviewed-on: https://chromium-review.googlesource.com/1197904 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#590438}
-
Ryan Cui authored
Increase shard count used for the debug and msan/asan builders to prevent the tests from timing out. Repurposes shards previously used for mash_browser_tests, as crrev.com/c/1175222 reduced the number of tests running as part of that suite to just 1. Also sets the timeout for tests back to 1800. It was bumped up to 3600 by crrev.com/c/1217124. Bug: 874090 Change-Id: Ia2b0ea4d3264e240dadde04f8ff049ff9a8b5735 Reviewed-on: https://chromium-review.googlesource.com/1217124Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Ryan Cui <rcui@chromium.org> Cr-Commit-Position: refs/heads/master@{#590437}
-
Carlos IL authored
Change-Id: I22a1596e41c499f2330ce3e8bacc8dc7c99ae7bd Reviewed-on: https://chromium-review.googlesource.com/1220476Reviewed-by:
Adrienne Porter Felt <felt@chromium.org> Commit-Queue: Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#590436}
-
Luna Lu authored
TBR: iclelland@chromium.org Bug: 874629 Change-Id: Ia5346b73344bf33dd1446591b85acf0d6a608e9b Reviewed-on: https://chromium-review.googlesource.com/1220091 Commit-Queue: Luna Lu <loonybear@chromium.org> Reviewed-by:
Luna Lu <loonybear@chromium.org> Cr-Commit-Position: refs/heads/master@{#590435}
-
Joe Downing authored
This change is a result of our discussions with the privacy folks. The old behavior was to center the disconnect window along the x-axis and dock it just above the taskbar. The change is to now position the dialog near the center of the y-axis as well to maximize the chances of a local user seeing the disconnect window before it auto-hides. This change also fixes a bug where I was setting the position after animating the window so it would appear to jump when being reshown. BUG=882926 Change-Id: I3e923937f10f24c3e719f311380a98b77644e866 Reviewed-on: https://chromium-review.googlesource.com/1220029Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#590434}
-
Karan Bhatia authored
Currently on Mac, when the blocked action bubble is shown for an extension in the app menu, it is shown over the app menu and it's not possible to interact with the bubble. Fix this by closing the app menu if needed before showing the bubble. Tested with both Cocoa and Views browser windows. BUG=880875 Change-Id: I3ab9b1136f01ca1cf5dd13fd51831f05072c8437 Reviewed-on: https://chromium-review.googlesource.com/1211964Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#590433}
-