- 14 Feb, 2020 40 commits
-
-
nancy authored
BUG=1016159 Change-Id: I066b6e1273ffab397b917043363db19a66ac6802 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049994Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#741614}
-
John Rummell authored
Due to problems on some bots failing to start PulseAudio and causing Chrome startup to hang, disabling audio output for media browser tests on Linux to avoid the hang. Bug: 986021,1023029,1026849,1035472,1049467 Test: modified browser_tests pass locally Change-Id: I29a996ee627bc4a5b93e5b8d6227dd7801998d11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056760Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#741613}
-
Piotr Bialecki authored
Continuation of work started in https://crrev.com/c/2055587 ARCore session needs to be able to update its plane information in a way that is independent of whether plane detection is configured. This is needed to enable creating anchors out of hit test results, while still avoiding more costly step of extracting complete plane data from ARCore if it is not needed. Notable changes: - Only ArCorePlaneManager::Update() is non-const - all other public methods can be made const. - The Update() needs to be called in each frame if the ARCore session supports plane detection (note: this is distinct from WebXR's notion of plane detection, see code comments). - Minor change - ForEachArCorePlane now accepts the list over which it's supposed to iterate instead of relying on member variable. Step 2/3(?) - preparing for creating anchors from hit test results. Change-Id: I87a187947a5ff7638b805d99ed5e44de03263b72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057092Reviewed-by:
Klaus Weidner <klausw@chromium.org> Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Cr-Commit-Position: refs/heads/master@{#741612}
-
Tricia Crichton authored
r1924789 added a retry loop while waiting for DevTools messages. This spammed users' logs with uninformative timeout reports. This CL suppresses those log messages and correctly reports the command timeout value when appropriate. Bug: chromedriver:3332 Change-Id: I4b123ccdb58fcdaa1364327a687cd624508d0f1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2052193Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Tricia Crichton <triciac@chromium.org> Cr-Commit-Position: refs/heads/master@{#741611}
-
Scott Violet authored
This makes it so the runner passes --run-web-tests when running weblayer tests. The renderer then turns on test only features if this flag is present. content_shell also uses --run-web-tests, which is why I'm using the same here. BUG=1049426 TEST=none Change-Id: If7882840a6f805677189c13dd99ac099cad952b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055562Reviewed-by:
Clark DuVall <cduvall@chromium.org> Reviewed-by:
Andrew Luo <aluo@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#741610}
-
Charlie Hu authored
This CL separates DocumentPolicyFeature enum from FeaturePolicyFeature enum, which makes DocumentPolicy and FeaturePolicy independent to each other. Previous test on document policy and feature policy coexist is removed. Follow-up CL will replace all usage of migrated features, i.e. font display and unoptimized-lossless-images so that current wpt tests on document policy still pass. Bug: 993790 Change-Id: I730b95efd013c25d97c2d24dd777e12b7b38bbb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028666 Commit-Queue: Charlie Hu <chenleihu@google.com> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#741609}
-
David Tseng authored
The panel runs in a separate page context than the background page, so some js objects like UserAnnotationHandler or ChromeVoxState, which are initialized by the Background class, are never initialized. This leads to indirect bugs from directly required classes such as Output which directly depend on ChromeVoxState or UserAnnotationHandler. For a fix, this change initializes these singletons. Note the divergent styles in which they do so due to the way they were initially written. For reference, not doing this initialization causes errors like: TypeError: Cannot read property 'enabled' of undefined at Function.getAnnotationForNode (chrome-extension://mndnfokpggljbaajbnioimlmbfngpief/chromeVoxPanelScript.js:1113:101) at Output.<anonymous> (chrome-extension://mndnfokpggljbaajbnioimlmbfngpief/chromeVoxPanelScript.js:1190:489) at Array.forEach (<anonymous>) at Output.format_ (chrome-extension://mndnfokpggljbaajbnioimlmbfngpief/chromeVoxPanelScript.js:1182:8) at Output.node_ (chrome-extension://mndnfokpggljbaajbnioimlmbfngpief/chromeVoxPanelScript.js:1263:30) at Output.<anonymous> (chrome-extension://mndnfokpggljbaajbnioimlmbfngpief/chromeVoxPanelScript.js:1243:6) at Output.range_ (chrome-extension://mndnfokpggljbaajbnioimlmbfngpief/chromeVoxPanelScript.js:1247:228) at Output.render_ (chrome-extension://mndnfokpggljbaajbnioimlmbfngpief/chromeVoxPanelScript.js:1179:83) at Output.withSpeech (chrome-extension://mndnfokpggljbaajbnioimlmbfngpief/chromeVoxPanelScript.js:1140:104) at PanelNodeMenu.findMoreNodes_ (chrome-extension://mndnfokpggljbaajbnioimlmbfngpief/chromeVoxPanelScript.js:1436:118) Change-Id: Id867f585dededc77a56f0332aba8ea1bd4ebb06a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055415 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#741608}
-
Etienne Bergeron authored
Accept the src_func and src_file for the ScopedAllow events. Follow-up on this CL: https://chromium-review.googlesource.com/c/chromium/src/+/2031440 R=gab@chromium.org, oysteine@chromium.org Bug: 1047794 Change-Id: I0d00ad7121dbc9e7d464fe3b2c915951b77f0699 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057287Reviewed-by:
oysteine <oysteine@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#741607}
-
Etienne Bergeron authored
On Windows, ShapeRuns(...) is shaping the text by trying: PrimaryFont GetFontFallback(...) : using DWrite GetFontFallbacks(...) : using registry keys (Font Linking) The GetFontFallbacks function is deprecated and should be remove. There is still a long tail of cases that succeed only with the use of that mechanism. This CL is making these cases to be reported as a crash to be analyzed before removing the code. The goal is to avoid breaking the text rendering even for a small population. R=robliao@chromium.org Bug: 995789 Change-Id: I381753ed3985779cd34dae58a34f523c2f215c9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049126Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#741606}
-
Vasiliy Telezhnikov authored
This CL limits the use of shortcut for recreating SkSurfaceCharacterization to resize case. If anything else was changed we will request new characterization from gpu thread. For mergability this change keeps the old code on Linux. This CL also adds ForceReshapeOnNextDraw() to viz::Display so platforms can force reshape in cases if something changed outside of size and formats. WebView uses it to force reshape and get new characterization in case of fbo id changed between zero and non-zero. Bug: 1052115, 1051527 Change-Id: I2ec4a7d2ca5c6dc6cdf896a679ada26f5be2a9e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055348Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#741605}
-
Sigurdur Asgeirsson authored
This will surface these values in a structured way on the crash backend, obviating the need for a debugger. Bug: 1003391 Change-Id: Ib8c1868babd4b3c01600bcb05d861a1f15875478 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055543 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#741604}
-
Matt Wolenetz authored
These 3 metrics' data will hopefully help us reduce the frequency of fuzzing timeouts. Earlier data showed good promise. Reactivating these (which had just expired a few days ago) to resume data collection to assist eventual improvement (via https://crbug.com/907268). BUG=1037604,907268 Change-Id: I0e97abb39b0106c57898a12f1ba71724265e4fe5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051166Reviewed-by:
Dan Sanders <sandersd@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Cr-Commit-Position: refs/heads/master@{#741603}
-
Nick Diego Yamane authored
After crrev.com/c/2022280, logic for coalescing XEvents has been moved to ui::X11Window [1], there are cases where translating coalesced XEvent results in ET_UNKNOWN events. Before migrating away from PlatformEvent based ui::*Event ctors to XEvent translation helper functions, handling such cases was a matter of checking its ::type() value, now translation functions return nullptr instead, so update this checking accordingly. [1] https://crrev.com/c/2022280/18/ui/base/x/x11_window.cc#b1196 R=thomasanderson@chromium.org Bug: 1052293, 1052301 Test: Run with ozone/x11 backend, scroll, browser should not crashed Change-Id: Icf415ce72e679f39598f9d72ad098d56217e21da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057072 Commit-Queue: Scott Violet <sky@chromium.org> Auto-Submit: Nick Yamane <nickdiego@igalia.com> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#741602}
-
Nic Champagne Williamson authored
Currently, the HOVERED and PRESSED states of toolbar buttons will return the same as the default normal state. However, when a theme is applied that sets a different COLOR_TOOLBAR_BUTTON_ICON value, these default HOVERED and PRESSED states are wrong. This change makes the HOVERED and PRESSED states return the current normal state, rather than the default. Bug: 1050960 Change-Id: Id46cd5e711625070737344d3d34f9540fba7d9e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050827 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#741601}
-
Victor Costan authored
This CL removes the feature flag gating IndexedDB large value wrapping. The feature will be rolled out using Chrome's standard waterfall release model. Bug: 844782 Change-Id: Ie33675293a1c592c8731ab380ae9c55674ee6ae4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056863 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Auto-Submit: Victor Costan <pwnall@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#741600}
-
Nick Harper authored
ProofVerifierChromium will reject certificates that don't chain to a known root unless the hostname matches one specified in --origin_to_force_quic_on. That flag also allows a wildcard "*" to force QUIC on for all origins, but that wasn't handled in ProofVerifierChromium. Now it is. Change-Id: I9576bcfbb14aac8956a81731d35190062e469b23 Bug: b/144497826 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2048034Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#741599}
-
Elly Fong-Jones authored
* In PlatformVerificationDialog, a lambda now wraps all three callbacks to pass the needed response codes, and the overrides are removed * In ToastDialogView, the dismiss callback is used directly as the DialogDelegate close callback, and the ::Close override is removed * In EchoDialogView, the listener is used directly as a receiver for the success callbacks. The contract of the listener is "it receives zero or more calls to OnMoreInfoLinkClicked, then exactly one call to either OnCancel or OnAccept", which fits neatly into the DialogDelegate model, since the cancel/accept callbacks can only be run when the dialog is already closing (and therefore no more button presses can be delivered). * In RequestPinView, a dead override of ::Cancel is removed; the default ::Cancel just returns true already. Bug: 1011446 Change-Id: I5b7489799327d497f9e6f948620a0e0918680d5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2044133Reviewed-by:
Peter Boström <pbos@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#741598}
-
Alex Gough authored
Bug: 1052442 Change-Id: I51a9476de93f1401b2de902834849fb031fe7b24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057629 Commit-Queue: Alex Gough <ajgo@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#741597}
-
David Schinazi authored
This histogram is no longer used anywhere, we just forgot to mark it as obsolete when its usage was removed with this CL: https://chromium-review.googlesource.com/c/chromium/src/+/1277929 Bug: 815241 Change-Id: I38bb63d4396f900e86f3353ff97637fb711f155a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055688 Commit-Queue: David Schinazi <dschinazi@chromium.org> Auto-Submit: David Schinazi <dschinazi@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#741596}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/2fd618192985..71b3dd56da8d git log 2fd618192985..71b3dd56da8d --date=short --first-parent --format='%ad %ae %s' 2020-02-14 cwallez@chromium.org Fix clean CMake builds Created with: gclient setdep -r src/third_party/dawn@71b3dd56da8d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I4a259be22b7abdf77f251814c651b4a297d57ee3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057486Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#741595}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/9478dbffef45..8f64176566f7 git log 9478dbffef45..8f64176566f7 --date=short --first-parent --format='%ad %ae %s' 2020-02-14 nuskos@google.com Merge "Add trigger packets to the slices table." 2020-02-14 treehugger-gerrit@google.com Merge "shmem: Require memfd in in-tree android builds" 2020-02-14 treehugger-gerrit@google.com Merge "Switch to using variadic parameters rather then a int input." Created with: gclient setdep -r src/third_party/perfetto@8f64176566f7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ib7133307ef832c95b7b8941e2b40cfa53831b7fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057489Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#741594}
-
Becca Hughes authored
We were using GURL/url::Origin in different places for storing origins which meant some had a trailing / and some did not. This resulted in duplicates. BUG=1051204 Change-Id: I098e42358ec42904125bd2f62b399c43c319d983 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051293 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#741593}
-
Sammie Quon authored
And rearranged the setters/getters to match the order as well. Test: none Bug: none Change-Id: Ia0fe3548895d1741398b36985e88eb23a2d3bac7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057585Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#741592}
-
Yulun Wu authored
Change-Id: Ia857192db462c08121220b205071757f763c2d7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057288Reviewed-by:
Manu Cornet <manucornet@chromium.org> Commit-Queue: Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#741591}
-
Erik Chen authored
Change-Id: I160bba87701cb16d012aff495bcc63fd08c76b47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057632 Auto-Submit: Erik Chen <erikchen@chromium.org> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#741590}
-
David Black authored
Improves readability of UMA dashboard. Bug: b:144875278 Change-Id: Id5493c5d0060e4fca7b2956ab87fa5c1775ce4e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055995Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#741589}
-
Ionel Popescu authored
This change adds drop shadow to popups for FormControlsRefresh by using the [NSWindow hasShadow] property. Since the Mac window shadow also has its own border, the HTML provided border for the popups [1] is changed to be transparent to avoid having a weird UI. [1]: https://chromium-review.googlesource.com/c/chromium/src/+/2036250 Bug: 1000898 Change-Id: Iadf89e7a122614b6dba95b745be2af79476da98d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2052264 Commit-Queue: Ionel Popescu <iopopesc@microsoft.com> Reviewed-by:
ccameron <ccameron@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#741588}
-
Wez authored
Fix several BUILD.gn rules which have |deps| on FIDL APIs, but which expose headers which #include the fidl.h bindings for those APIs. Such dependencies in source_set()s, libraries, etc, need to use |public_deps| otherwise their dependents do not inherit the FIDL API's include paths correctly. We seem to have been getting away with this, but it proved to be a problem for the GN SDK transition. Bug: 1050703 Change-Id: I4e16a27d2169ec9c693d359e9ee742efc043dc8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056549 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Auto-Submit: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#741587}
-
Ahmed Mehfooz authored
StackedNotificationBarIcon. Issue 100% reproducible without the fix. With the fix the crash does not happen. Confirmed over 3 runs for each case. Bug: 1050685 Change-Id: Id3e5f7204f7f124a1d258b2f45864b451ff6647a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055846Reviewed-by:
Tim Song <tengs@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Cr-Commit-Position: refs/heads/master@{#741586}
-
Sylvain Defresne authored
https://chromium.googlesource.com/external/github.com/material-components/material-components-ios.git/+log/866cee927378..adb2011e9efd $ git log 866cee927..adb2011e9 --date=short --no-merges --format='%ad %ae %s' 2020-02-12 56741989+copybara-service[bot] [FlexibleHeader] Added property for minimumHeaderViewHeight (#9649) 2020-02-12 randallli manual edit of changelog 2020-02-12 yarneo fix snapshot tests for CI (#9698) 2020-02-12 randallli modified version number to 104.0.0 2020-02-12 randallli Revert "Bumped version number to 103.2.0." 2020-02-12 randallli Hand-modified CHANGELOG.md API diff. 2020-02-12 bryanoltman [TextFields] Update snapshot goldens (#9691) 2020-02-11 randallli Hand-modified CHANGELOG.md API diff. 2020-02-11 randallli Hand-modified CHANGELOG.md API diff. 2020-02-11 randallli Bumped version number to 103.2.0. 2020-02-11 randallli Hand-modified CHANGELOG.md API diff. 2020-02-11 randallli Automatic changelog preparation for release. 2020-02-11 bryanoltman [Buttons] Delete deprecated MDCFloatingActionButtonThemer (#9662) 2020-02-11 randallli add deps on availability for a bunch of components (#9679) 2020-02-11 randallli [Availability] add Availability build file (#9678) 2020-02-10 rsmoore [CODEOWNERS] Remove romoore@ (#9660) 2020-02-10 randallli [private] Update snapshot tests. (#9666) 2020-02-07 no-reply Internal Change 2020-02-07 no-reply [Material][Availability] Migrates Buttons to MDCAvailability. 2020-02-07 no-reply [Material][Availability] Migrates the Banner to MDCAvailability. 2020-02-07 galiak [Dialogs] Update comments describing private margin properties. 2020-02-07 featherless [ButtonBar] Assign the UIBarButtonItem's tintColor to the button's text color. 2020-02-07 galiak [Dialogs] Update comments describing private margin properties. 2020-02-07 featherless [FlexibleHeader] Resolve precision warning due to use of floating point. 2020-02-07 no-reply [Material][Availability] Migrates elevation to MDCAvailability. 2020-02-07 andrewoverton Add Swift-friendlier names to TextControl text fields 2020-02-07 featherless [Availability] Add an umbrella header. 2020-02-07 featherless [FlexibleHeader] Add missing self-> within a block. 2020-02-07 no-reply [Material][Availability] Migrates Feature Hightlight to MDCAvailability. 2020-02-07 galiak Renaming "custom" category to "customize". 2020-02-07 galiak Renaming "custom" category to "customize". Created with: roll-dep src/ios/third_party/material_components_ios/src Bug: 1051926 Change-Id: I849814fabc76b655909a91889cafe7913c97e6a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057285Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#741585}
-
Javier Ernesto Flores Robles authored
Abstract ConfirmationAlertViewController from PasswordBreachViewController to be reused in the credential provider extension. Create shared dynamic_type_util to share PreferredFontForTextStyleWithMaxCategory. Create ios/chrome/common/ui/... to have a common folder for shared UI. Create ios/chrome/common/ui/util/... to have a common folder for shared util UI. This follows the convention in ios/c/b/... Bug: 1045453, 1045452, 1045448 Change-Id: I0fc661f6a83fe80b312eb5e32611c76d3b43c901 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055552 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#741584}
-
Li Lin authored
QuickAnswers.SelectedContent.Length is recorded to learn about users usage pattern. Bug: 1051751 Test: Manual Change-Id: Iba7c9ecf605cf39cc7d65864eb54d9ff6ef12be3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053288 Commit-Queue: Li Lin <llin@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#741583}
-
Eugene But authored
This callback is called when back/forward buttons visibility state is changed. This does not provide any useful signals for finding steps to repro. Bug: 1046223 Change-Id: Ia93bd11ee1d444de2b9525d5f4781b524184b60e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057117 Commit-Queue: Eugene But <eugenebut@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Auto-Submit: Eugene But <eugenebut@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#741582}
-
Greg Guterman authored
Important: Land together with https://crrev.com/c/2040570 In an effort to achieve the replacement of masternames with buckets (https://crbug.com/914522), we need an interim solution where master and bucket configs co-exist, while we migrate downstream code over to use the bucket side. I'm planning on adding 'project' and 'bucket' into the source side spec in waterfall.pyl Because I'm adding it at the master level, it means all masters have to be constrained to 1 bucket. Luckily, only one master currently has builders in two different buckets: chromium.fyi belongs to both chromium.goma and chromium.ci buckets. Therefore, as a prerequisite to adding this new bucket config, this CL splits chromium.goma.fyi off from chromium.fyi. Also removes some builders that weren't removed from the corresponding mb_config_bucket.pyl file in previous commits to mb_config.pyl. Also merges consoles/chromium.fyi.goma.star into consoles/chromium.goma.fyi.star because we can't find a reason for them to be separate. Change-Id: Iba12ad30c050b67396577165779768ad2f196f7e Bug: 1049220 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2039597 Commit-Queue: Gregory Guterman <guterman@google.com> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#741581}
-
haozhe authored
The correct css_animation and css_transition composite order require to walk the tree which is slow and causing a perf issue. Perf Job link: https://pinpoint-dot-chromeperf.appspot.com/job/125ecb68620000 https://pinpoint-dot-chromeperf.appspot.com/job/17471fd0620000 Bug: 1047316 Change-Id: I85e2446bab351ccbef989ae1a9cb62e8434ff236 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032716 Commit-Queue: Hao Sheng <haozhes@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#741580}
-
Alexander Timin authored
This config has dummy URLs and dummy memory limit and is used to test the config parsing logic. The testing of the feature in question is provided by the buildbots: https://ci.chromium.org/p/chromium/builders/ci/android-bfcache-debug https://ci.chromium.org/p/chromium/builders/ci/linux-bfcache-debug R=asvitkine@chromium.org Change-Id: Ie4a2af2196e9a8e104a3616c0a9f6fedaa86a46c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057267 Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#741579}
-
Sammie Quon authored
This is so we can share the code with CompositorAnimationRunner and some classes which record their own smoothness, such as AppsGridView. Creates a Recorder class which computes smoothness that can be used in mentioned classes. Test: run existing tests Bug: 1051490 Change-Id: Ic562fbb74bcd74c7554277a8167aaaa8fbf4a51b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053123 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#741578}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a710b74a3690..c663845357d0 Created with: gclient setdep -r src-internal@c663845357d0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1049646 Tbr: jbudorick@google.com Change-Id: Ib99aa0f760a1a6b028508d980af3ad6b91432757 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057488Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#741577}
-
Vasilii Sukhanov authored
That question came up during security review. We should enforce HSTS at least for the password leak check API. However, it's benificial to enforce it for all possible APIs. Bug: 1049177 Change-Id: Ieacb6675c195c89606cc3a8d956bdfa855b8b64f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057125 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Reviewed-by:
Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#741576}
-
Matt Jones authored
TBR: asvitkine@chromium.org, vincb@chromium.org Bug: 1052440 Change-Id: Ia4cb7f08876b46f6597185937aaefedbcf2975b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056745 Commit-Queue: Matthew Jones <mdjones@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Auto-Submit: Matthew Jones <mdjones@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#741575}
-