GitLab

The problem with Youtube page in oopif is that the Body element of the
iframe is vertically scrollable by a few pixels (ClampScrollOffset doesn't
shirnk the vertical scroll delta to zero) but
UserInputScrollable(kVerticalScrollbar) is false for its scrollablearea.

This cl uses the latter function in addition to ClampScrollOffset to
calculate the clamped scroll delta in ScrollManager::CanScroll.

Bug: 809621
Test: SitePerProcessBrowserTest.ScrollBubblingFromOOPIFWithBodyOverflowHidden
Change-Id: Id7c722331bc4e65cf4808aa7bb18b3cbf3f71808
Reviewed-on: https://chromium-review.googlesource.com/905473Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Commit-Queue: Sahel Sharifymoghaddam <sahel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539496}

Bug: 803191
Change-Id: I04053d35036e05014c0ff8a670b774a7be5cb96c
Reviewed-on: https://chromium-review.googlesource.com/939584Reviewed-by: Thiemo Nagel <tnagel@chromium.org>
Commit-Queue: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539495}

This will help in writing tests for CWVTranslationController.

Bug: 770983
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I8f0b67e14872e654fcf276f0fba20dab4289b6b9
Reviewed-on: https://chromium-review.googlesource.com/939045
Commit-Queue: John Wu <jzw@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539494}

Add support of OOPIF (out-of-process iFrame) to ChromeDriver

Change-Id: I0b936b21597d8970656029c3110bfe0f61ae9aa8
Reviewed-on: https://chromium-review.googlesource.com/934145
Commit-Queue: John Chen <johnchen@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539493}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/efc0f3d4..687fceb2

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org

Change-Id: If94d30c7437cf4ed518c3084927e014614faaaf5
Reviewed-on: https://chromium-review.googlesource.com/938596Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539492}

We should never show the Ad block UI when devtools is the cause of the
activation. This CL does that by using suppress_notification for
forced activation. This messes up some logging, so we handle that by
adding a new histogram at the //content layer.

Bug: 812348
Change-Id: I16ae72cbb3342183a2067f2ad1698758425cd160
Reviewed-on: https://chromium-review.googlesource.com/919315
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Shivani Sharma <shivanisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539491}

Bug: none
Change-Id: Ie877b9c71a1851c5f663ecb3ef194391aa6bd9be
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Reviewed-on: https://chromium-review.googlesource.com/939173
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Elodie Banel <lod@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539490}

Bug: 812647
Test: manually tested bug 812647 with ChromeVox
Change-Id: I9110c0d9e301dad9315cfbcdb9572a1c91c90a16
Reviewed-on: https://chromium-review.googlesource.com/938753
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539489}

https://chromium.googlesource.com/catapult.git/+log/38e8eedc7bb6..47ca0db0bd96

$ git log 38e8eedc7..47ca0db0b --date=short --no-merges --format='%ad %ae %s'
2018-02-26 charliea Reland: Roll the new BattOr firmware and battor agent to the latest version
2018-02-26 nednguyen [Telemetry] Cap the limit of trace size in TimelineBasedMeasurement to 400 MiB
2018-02-26 charliea Fix remaining reference to bad host/arch strings in BattOr wrapper
2018-02-23 wvw Add clock state support
2018-02-23 wvw Add clk_set_rate support

Created with:
  roll-dep src/third_party/catapult


The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=sullivan@chromium.org

Change-Id: Ia5e66c2348dd7c8dd9487451fca60c3643534749
Reviewed-on: https://chromium-review.googlesource.com/938364
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#539488}

https://chromium.googlesource.com/media_router.git/+log/8c27673ed823..270eb6c464d5

$ git log 8c27673ed..270eb6c46 --date=short --no-merges --format='%ad %ae %s'
2018-02-26 mfoltz Changed default values of MR compile-time constants.
2018-02-23 mfoltz Made logging settings easier for developers to discover.
2018-02-23 mfoltz Added device discovery via Slarti.

Created with:
  roll-dep src/chrome/browser/resources/media_router/extension/src

Change-Id: If6a3633e4a8702e46527a39b30215a9373d4019a
Reviewed-on: https://chromium-review.googlesource.com/938565
Commit-Queue: mark a. foltz <mfoltz@chromium.org>
Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539487}

NewReports are being made classes, intended to be initialized only by a
CrashReportDatabase (which is a friend). This makes mocking
PrepareNewCrashReport and FinishedWritingCrashReport awkward, but a
real CrashReportDatabase shouldn't be prohibitively heavyweight.

Bug: crashpad:206
Change-Id: I085cacfc4fd4b3e51578973c9795a5a25c1c14dc
Reviewed-on: https://chromium-review.googlesource.com/937982
Commit-Queue: Joshua Peraza <jperaza@chromium.org>
Reviewed-by: Sigurður Ásgeirsson <siggi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539486}

This CL introduces no functional changes, and only verifies
the current behavior of client hints when only the
Accept-CH header is specified in the response headers.

Browser tests and Blink tests are added for cases where the origin has
specified only the Accept-CH header in the response headers. The tests
ensure that currently client hints are attached even if the origin
does not have permission to run JavaScript. Additionally, the tests
also ensure that the client hints are attached for third-party origins.

The next CL will modify these behaviors, and prevent attaching of
client hints when origin does not have permission to run scripts.
The next CL would also prevent attaching of client hints to
third-party origins. The tests added in this CL would be updated
to match that behavior in the next CL.

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I90d992cd456e62f36924243972430012639efde9
Bug: 816661
Reviewed-on: https://chromium-review.googlesource.com/938541
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539485}

This overload is no longer used. All callers use the overload that
calls base::GetFieldTrialParams() directly.

Bug: 810049
Change-Id: I0cde22bd6701b8b698b90aa7b39a10666fe7d32f
Reviewed-on: https://chromium-review.googlesource.com/909296Reviewed-by: Gayane Petrosyan <gayane@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Commit-Queue: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539484}

https://skia.googlesource.com/skia.git/+log/c657fa6d44d3..db1e5c6474c1

$ git log c657fa6d4..db1e5c647 --date=short --no-merges --format='%ad %ae %s'
2018-02-27 kjlubick Port 3 API fuzzers to be oss-fuzz friendly
2018-02-27 angle-skia-autoroll Roll skia/third_party/externals/angle2/ 6ae51611c..06a87ec83 (3 commits)
2018-02-27 angle-skia-autoroll Roll skia/third_party/externals/angle2/ b52fac03f..6ae51611c (1 commit)
2018-02-26 bsalomon Suppress CopySurface test on Nexus 7

Created with:
  roll-dep src/third_party/skia


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=benjaminwagner@chromium.org

Change-Id: I82764f84cf4d3d59e232caaedfd22c8d072c461f
Reviewed-on: https://chromium-review.googlesource.com/939441
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#539483}

This CL adds the new assets to be used for the UI refresh and use them.

Bug: 807284
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I6cd1d1132a4552296fdefbcd488652a7cfd59ca2
Reviewed-on: https://chromium-review.googlesource.com/939394
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539482}

Since the SynchronousCompositorProxy (base class of SynchronousCompositorMojo)
holds onto a reference to the InputHandlerProxy it must be destroyed
before the InputHandlerProxy is destroyed.

BUG=816538

Change-Id: I990b5a427970b28219464267de41a28b1fabb5d0
Reviewed-on: https://chromium-review.googlesource.com/938485
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539481}

a patch[1] which is to fix jumbo build error was merged.
but g_instance_for_testing still keep in memory_dump_manager.cc.
that variable name looks like generic name which is some potential
to make same issue.
so it should be rename in order to void the same problem.

[1]https://chromium-review.googlesource.com/938821

Bug: 775547
Change-Id: Id7f3fc30a8118fb6f24f0e920ab530f44a27fa82
Reviewed-on: https://chromium-review.googlesource.com/938803Reviewed-by: Primiano Tucci <primiano@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539480}

This CL adds an occlusion state to allow delegates to be notified when
a window goest from hidden <-> occluded.

Bug: 668690
Change-Id: I3b16a699ab5d8e6050332e5146007766b0c3949f
Reviewed-on: https://chromium-review.googlesource.com/927205Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539479}

Bug:816647
Change-Id: Icbf574609b6aa1be953c5388407e5a8d4f587808

TBR=rockot@chromium.org

Change-Id: Icbf574609b6aa1be953c5388407e5a8d4f587808
Reviewed-on: https://chromium-review.googlesource.com/938368Reviewed-by: Mohammad Reza Zakerinasab <zakerinasab@chromium.org>
Commit-Queue: Mohammad Reza Zakerinasab <zakerinasab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539478}

When one or more programs that injects code into Chrome are detected,
this subpage displays a list of actions that the user can take to either
remove those programs or follow a link to upgrade or learn more.

This card is only active if the ModuleDatabase and the
ProblematicProgramsWarning features are enabled.

Bug: 717696
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ibaff081d0f424080b2dba31cf6c5f2aaeab62214
Reviewed-on: https://chromium-review.googlesource.com/924522
Commit-Queue: Patrick Monette <pmonette@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539477}

BUILD.gn file changes will be made in a follow-up.

TBR=jam@chromium.org,mek@chromium.org,jbroman@chromium.org

Bug: 809983
Change-Id: I19a8a1bd5d9126328cb6e7f478fd92eb44150434
Reviewed-on: https://chromium-review.googlesource.com/939206Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Commit-Queue: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539476}

Since ClearBrowsingDataCommand is no longer used (removed by
http://crrev.com/c/934501), there is no need to support the
deprecated -chromeExecuteCommand:.

Remove it and all the legacy support (GenericChromeCommand,
old #import, ...).

Bug: 738881
Change-Id: I004e548733550824aca4e9f5d0609e7172d2da1a
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Reviewed-on: https://chromium-review.googlesource.com/934270
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539475}

An installing service worker can call importScripts('dupe.js');
importScripts('dupe.js');. The first call should install the script, and
the second call should read the installed script. This CL implements
that. We detect if the script is already installed, and if so we use
a simple URLLoader that reads the installed script.

This fixes WPT test import-scripts-resource-map.https.html.

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I30c7532cedffaad3d62b12239ab230a0708bb49c
Bug: 814583
Reviewed-on: https://chromium-review.googlesource.com/934024
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539474}

The PushMessagingManager currently maintains its own subscription cache
in the Service Worker database, keeping track of the subscriptions it
thinks are valid. This means that the PushMessagingManager assumes that
the subscription is valid.

There are cases where the underlying push service, in our case Google
Cloud Messaging implemented through our GCM Driver, invalidates a
subscription. We need to find out about that when it happens, so change
the PushMessagingManager to *always* attempt to create a subscription,
upon which we rely on the push service client to return the same
information given the same input.

The GCM Driver has its own cache, so in the vast majority of cases these
calls won't hit the server. They will, however, on occasion.

Bug: 799483
Change-Id: I715c6f2eb8296b4512b6b7e9e31734ce9f254744
Reviewed-on: https://chromium-review.googlesource.com/932401
Commit-Queue: Peter Beverloo <peter@chromium.org>
Reviewed-by: Anita Woodruff <awdf@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539473}

The various callers of
BrowserNonClientFrameView::UpdateProfileIndicatorIcon() had
mostly-duplicated logic every where, which merited a refactor
in order to unify the common code in one place.

BUG=815031

Change-Id: I3ea46d9b0fca3eed4d491b5d5bf1da9289bd4c8e
Reviewed-on: https://chromium-review.googlesource.com/935882
Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539472}

BUG=723764

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I7284ca9ec0d291f51e13b9724d1e02aaedda870f
Reviewed-on: https://chromium-review.googlesource.com/936363
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Shenghua Zhang <shenghuazhang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539471}

This CL moves a TRACE_COUNTER1() counting input_buffers_.size()
from its current position to next to |input_buffers_| actions
(i.e. where it grows or shrinks).

It also renames s/GetInputBuffer_Locked/GetCurrInputBuffer_Locked/
to better reflect what the method does.

Cosmetic changes:
- removes .get() on checks for |curr_input_buffer_|
(bc unique_ptr<> has an operator boolean()).
- Removes unnecessary curly brackets.
- Removes superfluous comments.
- Escapes some variable names in comments.

TEST= simplechrome w/ crosvideos and v_d_a_unittests on soraka

Bug: 717265
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I5b3d51fd1509f8d0ce87487a44d6c7a77b4a253b
Reviewed-on: https://chromium-review.googlesource.com/934403
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539470}

This CL adds support for the "back" and "forward" buttons (located on the side
of many mice) to the Linux and Windows hosts. macOS does not seem to have very
consistent support for these (the documentation only states that mouse buttons
beyond the standard three should be passed to the CGPostMouseEvent function
"in USB device order", which is driver-specific) so I haven't included support
for macOS in this CL.

Note that for this to work, Chrome's --enable-features="ExtendedMouseButtons"
flag must be used, at least until the feature is enabled by default.

Change-Id: I1a890c590b26da8c5f11185a2be68a22c7f06ec2
Reviewed-on: https://chromium-review.googlesource.com/938754Reviewed-by: Joe Downing <joedow@chromium.org>
Commit-Queue: Jamie Walch <jamiewalch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539469}

Bug:816646
Change-Id: I9793d98d321fa3e5685d275f2e7d4c7d98fd1ddb

TBR=arthursonzogni@chromium.org

Change-Id: I9793d98d321fa3e5685d275f2e7d4c7d98fd1ddb
Reviewed-on: https://chromium-review.googlesource.com/938365Reviewed-by: Mohammad Reza Zakerinasab <zakerinasab@chromium.org>
Commit-Queue: Mohammad Reza Zakerinasab <zakerinasab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539468}

BrowsingDataRemovalController is just a thin wrapper around
BrowsingDataRemover. As BrowsingDataRemover is a KeyedService
there is no need for the wrapper anymore.

Convert BrowsingDataRemovalController unit tests to instead
test BrowsingDataRemoverImpl (and fix a potential use after
free of a TaskRunner in the tests).

Bug: none
Change-Id: I59b0da2198f6c0375977436c6bfebc37398d7cf2
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Reviewed-on: https://chromium-review.googlesource.com/934502
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539467}

Instead of WindowPortMus and WindowPortLocal managing the FrameSinkId of
a Window separately, manage it in Window itself.

BUG=none

Change-Id: I9fea68af4cc8b2c185fd1ff26e5be5d965b3ab90
Reviewed-on: https://chromium-review.googlesource.com/930663Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539466}

This CL adds tests for:
* Partial write (insufficient disk space to export)
* Export should be offered only if there are passwords
* Export Passwords menu item opens the export dialog.
* The Try Again button restarts the export
* The start and error dialogs are dismissible.

Bug: 815137
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ib8d971ac8eda5824ea80c397bd13a26a36a66277
Reviewed-on: https://chromium-review.googlesource.com/934823
Commit-Queue: Christos Froussios <cfroussios@chromium.org>
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Reviewed-by: Vaclav Brozek <vabr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539465}

* Uses early-return style to avoid code reaching to end even if
  fonts are found in early stages, primarily for the readability.
* Uses AtomicString(const UChar*) ctor instead of wcslen(). These
  are the only place that use wcslen in WebKit/ directory.

Bug: 561873
Change-Id: If403eafaa57a9f00eddf053bb8c6fb1d1343a4a2
Reviewed-on: https://chromium-review.googlesource.com/938687Reviewed-by: Dominik Röttsches <drott@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539464}

Makes the names of a couple of functions clearer.

Change-Id: I8c7923f62b691b3cf93642e54f4afd8cb257c01f
Reviewed-on: https://chromium-review.googlesource.com/937924Reviewed-by: Shivani Sharma <shivanisha@chromium.org>
Commit-Queue: Josh Karlin <jkarlin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539463}

Bug: 813905
Change-Id: I7a0954620c62c7553397bdd13250f598589afb33
Reviewed-on: https://chromium-review.googlesource.com/928504Reviewed-by: Tommy Steimel <steimel@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539462}

BUG=696454, 802007

Change-Id: I32982c6c34a24f67cfbb7c8fe07b943efaf90822
Reviewed-on: https://chromium-review.googlesource.com/924373
Commit-Queue: Avi Drissman <avi@chromium.org>
Reviewed-by: Emily Stark <estark@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539461}

Much like for geometry attributes - of which these are a subset. Also
push the InvalidationGuard into the invalidation function.

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Ib9254d8ad930ef132c8074a7636eb57f18ae22d5
Reviewed-on: https://chromium-review.googlesource.com/932122
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539460}

This takes a url to an icon, and downloads it, in memory. It's not
currently storing it in disk, or resizing it, or even allowing selection
from a list of icons. This functionality will be added later.

And a unit test to verify expected behavior.

Bug: 813564
Change-Id: Ia00945d4f0c5f2b4bccd2fb03dcf289b265af110
Reviewed-on: https://chromium-review.googlesource.com/932121
Commit-Queue: Mugdha Lakhani <nator@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539459}

No change to logic.

Bug: None
Change-Id: I3eb4fc82108488ba87b40323e0afa643d9e96e86
Reviewed-on: https://chromium-review.googlesource.com/939003Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539458}

This update is required for work that is underway related to management
of Chrome browsers for enterprise users.

The google_update_idl.idl file was originally provided by the Google
Update team. It has been modified as described in the README.chromium
file in this CL.

The change was tested with Chrome-branded builds with target_cpu set to
"x86" and "x64". I followed these steps to make sure that this change
does not break Chrome updates.

1. Manully set the version of Chrome in src/chrome/VERSION to a version
   prior to that which is currently served on the Dev channel.
2. Compile with is_chrome_branded=true and target_cpu set to one of
   "x86" or "x64".
3. Install the build as a Dev-channel Chrome using setup.exe on a 64-bit
   Win10 machine.
4. Navigate to chrome://help and make sure that the update process works
   as expected.

Bug: 796270
Change-Id: I6962b8874a7e825d41834860de0eb0fe92f5a6e3
Reviewed-on: https://chromium-review.googlesource.com/924474
Commit-Queue: Ali Tofigh <alito@chromium.org>
Reviewed-by: Will Harris <wfh@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539457}