- 09 Apr, 2019 40 commits
-
-
Andreea Costinas authored
This CL is based on comments on CL:1470751. It - moves initialization code from gtest SetUp() to constructors. See https://github.com/google/googletest/blob/master/googletest/docs/faq.md - moves FakeSessionManagerClient PODs initialization from constructor initialization list to header. Bug: none Change-Id: If83c75cba304c0bbdc87b78102312ad31548366f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1543549 Commit-Queue: Andreea-Elena Costinas <acostinas@google.com> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Cr-Commit-Position: refs/heads/master@{#649038}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/397220b4e542..5f0fbbe4639b Created with: gclient setdep -r src-internal@5f0fbbe4639b The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=huangs@chromium.org,battre@chromium.org,collinbaker@chromium.org,tasak@chromium.org Change-Id: I921963049b9c7cec83ef067649aa10cd9b1cd4cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559770Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649037}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/8ec122ba..78334315 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I2f96d47c2a6ef2064fd93e40602cd0210b54a126 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559445Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649036}
-
Oleg Davydov authored
There was a path in ExtensionDownloader code, where failure was silently ignored: bad URL for CRX in ExtensionDownloader::FetchUpdatedExtension. Also there was a problem in kiosk app managed tests: they checked only app data fetching from chrome web store, but wrongly considered extension downloading failure as app data fetching failure. Bug: 938265 Change-Id: Iccd59cf10bd92767bee2c35e142ab590001fa8a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1558232 Commit-Queue: Oleg Davydov <burunduk@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#649035}
-
Raphael Kubo da Costa authored
Adjust to changes in coding style and renames that have happened over the years. TBR=haraken Change-Id: I9ceef9ad75d255eed856c53ee27a94d4730b4287 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559171Reviewed-by:
Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#649034}
-
Mikel Astiz authored
We leverage ModelTypeStore's built-in functionality to run logic in the backend sequence, via ModelTypeStore::ReadAllDataAndPreprocess(). As detailed in the linked bug, this avoid UI jank of ~100 ms at the 95th percentile and 500 ms at the 99th. Bug: 902203 Change-Id: I86a9709c63d4fa0f402120fc05d73540ea43b7cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559313Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#649033}
-
Takashi Sakamoto authored
This reverts commit 5d60b670. Reason for revert: this patch causes webui_polymer1_browser_tests failure on Linux Chromium OS ASan LSan Tests: https://ci.chromium.org/p/chromium/builders/ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/32626 E.g. [ RUN ] ContextMenu2/FilesAppBrowserTest.Test/checkDeleteDisabledForReadOnlyFolder_DriveFs [FATAL:pref_service.cc(137)] Check failed: (sequence_checker_).CalledOnValidSequence(). #5 0x555945f0598c in PrefService::GetBoolean(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) const ./../../components/prefs/pref_service.cc:137:3 #6 0x555938160f41 in chromeos::AccessibilityManager::IsSpokenFeedbackEnabled() const ./../../chrome/browser/chromeos/accessibility/accessibility_manager.cc:502:44 #7 0x55593816d6a9 in chromeos::AccessibilityManager::UpdateChromeOSAccessibilityHistograms() ./../../chrome/browser/chromeos/accessibility/accessibility_manager.cc:1174:3 Original change's description: > Compute image description histograms on the right thread. > > The code to compute image description histograms was > hitting a DCHECK because it was running on the wrong > thread. I temporarily disabled that code, this change > re-enables it and fixes the underlying issue. > > I noticed that we had code to compute accessibility > histograms that were split by platform - on some platforms > we were running the code on the UI thread, on other platforms > on a separate thread. > > To solve this, I changed the code so that we can update > histograms on either thread on any platform. > > Bug: 940805 > Change-Id: I6967ed58810f75f61e2b91a2e00a778de76d4960 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1551803 > Reviewed-by: Katie Dektar <katie@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#648795} TBR=dmazzoni@chromium.org,jam@chromium.org,katie@chromium.org Change-Id: Ia256fd7be70574be2218ba7ad78ce94496575ca1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 940805 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559413Reviewed-by:
Takashi Sakamoto <tasak@google.com> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#649032}
-
Mikel Astiz authored
Trivially rename the class in accordance to more modern naming conventions, in particular SyncEngineImpl. Bug: 950852 Change-Id: Iea1761ef3866bcf25e1373e6bb3a83a2fac29fdf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559312Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#649031}
-
Dominic Battre authored
Disable the test on Mac and Win7. https://chromium-review.googlesource.com/c/chromium/src/+/1506005 labeled the test as timing out. Somebody has removed that label but the test is still / again flaky. TBR=luoe@chromium.org,petewil@chromium.org Bug: 938884 Change-Id: I44dd36e29f5adf4a31445963125499e8253497f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559071Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#649030}
-
Hirokazu Honda authored
Bug: None Test: build chrome and some video tests for kevin and octopus Change-Id: Id2b1290b086a1d5d9191b28efb17455f626c2243 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1556820Reviewed-by:
David Staessens <dstaessens@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#649029}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/915457567ea8..397220b4e542 Created with: gclient setdep -r src-internal@397220b4e542 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=huangs@chromium.org,battre@chromium.org,collinbaker@chromium.org,tasak@chromium.org Change-Id: I55ddd9d63adfc90d4fc64dafb52c58d769dcfc28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559443Reviewed-by:
-
Ken Rockot authored
This is a reland of a095e3b2 PS2 is the fix, PS1 the original CL. This was just some uninitialized padding bytes in a control message. Original change's description: > [mojo] Shared message ordering for C++ bindings > > Implements support for the [ShareMessageOrder] attribute on mojom method > parameters and struct fields. If the field or parameter is a > pending_receiver or pending_remote type (or a container of one of those > types), its handle will be attached to the encompassing serialized > message with the new MOJO_APPEND_MESSAGE_DATA_HANDLE_FLAG_SPLICE flag > set, meaning that interface pipe will begin to share message ordering > with the sending pipe after message transmission. > > This support should be sufficient to fully replace usage of associated > interfaces while eliminating all bindings-layer encoding and routing > support for multiplexed pipes. > > See bug for design doc link. > > Bug: 941809 > Change-Id: I5629497705e4e747f9d63ef8198091d7917a41a4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548611 > Commit-Queue: Ken Rockot <rockot@google.com> > Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org> > Cr-Commit-Position: refs/heads/master@{#648747} Bug: 941809 Change-Id: Ief79131f13e4a8b08232aafb100c466b8750fc29 TBR: oksamyt@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559256Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#649027}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Idc3f40f1a99f789caa77178be4982acb6719b54b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559442Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649026}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/af08f15d..8ec122ba Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I419716bcb8fc5407826ac98650009c93185dcbc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559571Reviewed-by:
-
Nico Weber authored
The -Xclang is an implementation detail of clang, so we try not to use it. However, it used to be the only way to pass some gcc-style flags to clang-cl. Now that clang-cl has an explicit /clang: flag for passing gcc-style driver-level flags to gcc, stop using -Xclang in this context. No intended behavior change. Bug: none Change-Id: Ia14ca4aa2ac3a878db441f731fc60c765512b04f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1558350 Auto-Submit: Nico Weber <thakis@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#649024}
-
Ramin Halavati authored
A new API function is added to tell if an incognito profile is in use in any window, including devtools windows. Bug: 949505 Change-Id: If53db5b9218d450677abf7a5e8b7d9d93b06397b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554481Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#649023}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8bdc4cc9a594..915457567ea8 Created with: gclient setdep -r src-internal@915457567ea8 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=huangs@chromium.org,battre@chromium.org,collinbaker@chromium.org,tasak@chromium.org Change-Id: Id1fbcaf898da89423d31bd0c5c90926725a4414e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559198Reviewed-by:
-
yoshiki iguchi authored
Previously, OnSlideChanged was not called when the notification went back to the origin position after the animation ends, but when the animation starts. So we had the detection code in SlideHelper.Update() and there was a bug of no control buttons (crr crbug.com/949436). This CL refactors the CL and makes it called at the correct timing (just after animation is finished) and the correct |in_progress| status. Also this CL adds some tests of SlideOutController. Bug: 949436 Test: manual (did the steps on the bug, and observed as expected) Change-Id: I0fdc7b6173ef2ad415ce981b482b65f319b948d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1552209Reviewed-by:
Tim Song <tengs@chromium.org> Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org> Cr-Commit-Position: refs/heads/master@{#649021}
-
Gyuyoung Kim authored
As a step to acheive OnionSoup's goal, this CL merges WTFThreadData into Threading. Major changes are as below, - Rename WTFThreadData class to Threading class. - Rename WtfThreadData() function to WtfThreading() function. - Remove wtf_thread_data.h/cc files. - Remove empty namespace in std_lib_extras.h Bug: 950131 Change-Id: Ib120a3dc61fcb4559740db85cf4075e828bec1f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1558836Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#649020}
-
Findit authored
This reverts commit eb570246. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 648952 as the culprit for flakes in the build cycles as shown on: https://analysis.chromium.org/p/chromium/flake-portal/analysis/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vZWI1NzAyNDYyZGYxMzVhZTA4M2RjYmRjY2IyOGM4NGE4OGMyY2JhOQw Sample Failed Build: https://ci.chromium.org/buildbot/chromium.memory/Linux%20MSan%20Tests/16077 Sample Failed Step: browser_tests Sample Flaky Test: SitePerProcessPrintBrowserTest.PrintNupNoMargins Original change's description: > Make NupPrintingTestDelegate issue unique document cookies. > > In case NupPrintingTestDelegate::GetPrintParams() gets called twice, the > two calls should have unique document cookies. Otherwise many parts of > the printing subsystem will get confused by two requests with the same > cookie. > > Add tests that call GetPrintParams() twice by setting the page to have > no margin, as described on the bug. > > BUG=944516 > > Change-Id: I155585bdac86ddfd7f5b75538626fae1ca001621 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1556474 > Reviewed-by: Rebekah Potter <rbpotter@chromium.org> > Commit-Queue: Lei Zhang <thestig@chromium.org> > Cr-Commit-Position: refs/heads/master@{#648952} No-Presubmit: true No-Tree-Checks: true No-Try: true BUG=944516 Change-Id: Id7644783af93b4a168e76b4cbf25951c2a41c5f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559404 Cr-Commit-Position: refs/heads/master@{#649019}
-
Dan Beam authored
R=rbpotter@chromium.org BUG=none Change-Id: I3d79c5cf3a2be3a1ef39a7f310a8eb0e8243493b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559653 Commit-Queue: Dan Beam <dbeam@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Auto-Submit: Dan Beam <dbeam@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#649018}
-
Dan Beam authored
R=rbpotter@chromium.org BUG=926883 Change-Id: I8f889180c3ca82b00428d1e5f601cf212801cd10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559652 Commit-Queue: Dan Beam <dbeam@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Auto-Submit: Dan Beam <dbeam@chromium.org> Reviewed-by:
-
Tao Bai authored
As ContentCapture could be stopped at anytime, the assumption of ContentCaptureManager's availability doesn't hold now. Bug: 947639 Change-Id: I098557490d2a11c310f289e9d415312a57f72184 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559452Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#649016}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/21f59eba3910..8bdc4cc9a594 Created with: gclient setdep -r src-internal@8bdc4cc9a594 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=huangs@chromium.org,battre@chromium.org,collinbaker@chromium.org,tasak@chromium.org Change-Id: I6225f06d7508f2a36073a78f6b2b92b2bf6d4b3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559441Reviewed-by:
-
Luciano Pacheco authored
Bug: 778674 Change-Id: I8ff9e8fcbdf264ce026db1d8579bb3f797eb98a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1558551 Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#649014}
-
Dan Beam authored
Screenshot: https://imgur.com/a/VmY3To6 R=rbpotter@chromium.org BUG=926883 Change-Id: I88a72da81ed3b2bc2b5e38c372b0a6132394c870 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559651 Commit-Queue: Dan Beam <dbeam@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Auto-Submit: Dan Beam <dbeam@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/90dd5c15..af08f15d Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I63dd87d372b7bfced2e3004d2e699f564df23096 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559457Reviewed-by:
-
Dan Beam authored
Screenshot: https://imgur.com/a/EpvYOpP R=rbpotter@chromium.org BUG=926883 Change-Id: I18d72dbdbf7e7e62f757d7cd44cbc07645c99e37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559650 Commit-Queue: Dan Beam <dbeam@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Auto-Submit: Dan Beam <dbeam@chromium.org> Reviewed-by:
-
Sadrul Chowdhury authored
This reverts commit 3ed314eb. Reason for revert: crrev.com/c/1559170 should fix benchmark failures. If the benchmarks continue to fail, then crrev.com/c/1559170 and crrev.com/c/1553594 should both be reverted. Original change's description: > Disable failing rendering benchmarks > > Disable benchmarks rendering.desktop and rendering.mobile, as all tests > in both benchmarks have been failing consistently on all bots over the > last few days. > > NOTRY=true > TBR=crouleau@chromium.org > CC=sadrul@chromium.org, vmiura@chromium.org > > Bug: 950710 > Change-Id: Ibd2df6b0770f4205fbb95dc8a81a93bc63bc13bc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559159 > Reviewed-by: John Chen <johnchen@chromium.org> > Commit-Queue: John Chen <johnchen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#648909} TBR=crouleau@chromium.org,johnchen@chromium.org Change-Id: Iaab2acad32ebc5c85254f75f6840ea29ad80285f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 950710 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559655 Auto-Submit: Sadrul Chowdhury <sadrul@google.com> Commit-Queue: John Chen <johnchen@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#649010}
-
Noel Gordon authored
This to remove support for running in node-js, and other code run-time environments we're not using, to reduce the a.out.js size some more. Before % ls -las a.out* 36 -rw-r--r-- 1 user group 35465 Apr 9 13:14 a.out.js 60 -rw-r--r-- 1 user group 57474 Apr 9 13:14 a.out.wasm After % ls -las a.out* 36 -rw-r--r-- 1 user group 33650 Apr 9 13:11 a.out.js 60 -rw-r--r-- 1 user group 57474 Apr 9 13:11 a.out.wasm Bug: 935285 Change-Id: Ibefc29db48230d8267d1cd14bb6981cfc653a1e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559514Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
-
dstockwell authored
Bug: 939102 Change-Id: I3bff11dcc1d7242e122e2571c84f1aac636db3ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1556856 Commit-Queue: dstockwell <dstockwell@chromium.org> Reviewed-by:
-
Josh Karlin authored
The PrettyPrintNode method is gone, and can be replaced by PrettyPrintXml with the only difference being that the XML gets alphabetized. That doesn't seem to affect the files in question. Bug: 945354 Change-Id: Ia066dc72c71afcd86d00cd84ef6ca254eb049acb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559121 Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#649007}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/a7440a2273f3..82418c821689 git log a7440a2273f3..82418c821689 --date=short --no-merges --format='%ad %ae %s' 2019-04-09 syoussefi@chromium.org Add support for updating glslang_validator binary from Linux. Created with: gclient setdep -r src/third_party/angle@82418c821689 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: Icc698606dc89453a3f10c63841a52df8311698d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559439Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/1fb046306b9e..224e075bba5b git log 1fb046306b9e..224e075bba5b --date=short --no-merges --format='%ad %ae %s' 2019-04-09 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@224e075bba5b The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: Ib91a72f1c4af3245c1e40f41f8d4e4fcf2d8cc1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559193Reviewed-by:
-
Krishna Govind authored
TBR=meacer@chromium.org Change-Id: I8073667a2ef3cea167bc4ccd7340f3ab7c77fae7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559456 Commit-Queue: Krishna Govind <govind@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#649004}
-
cjamcl@google.com authored
Changelog: https://github.com/googlechrome/lighthouse/compare/v4.2.0...9790337f9873710c3fd38bafdec819337c8367be Relevant LH build changes: https://github.com/GoogleChrome/lighthouse/pull/7421 https://github.com/GoogleChrome/lighthouse/pull/7567 Bug: 772558 Change-Id: I50296da5059d6f90fbd69346691529a5feff15ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1510732 Commit-Queue: Connor Clark <cjamcl@google.com> Reviewed-by:
Paul Irish <paulirish@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#649003}
-
Esmael El-Moslimany authored
The clear all handler from MOJO is invoked each time search is used. Instead of showing a toast when MOJO clear all is invoked, show the toast in the clear all button click handler in the toolbar. Bug: 948651 Change-Id: Ib5f1773bda8d5ffc6abe01a1e0b6f2b26450abf9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1549196 Commit-Queue: Dan Beam <dbeam@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#649002}
-
Tim Song authored
In fullscreen mode (F4), ChromeOS blocks all notifications by default (see ash::FullscreenNotificationBlocker). We need to set a flag to allow certain important notifications to be seen. TEST=manual BUG=923300 Change-Id: I2840b4a9cc10038c0e131b04679a1388e8bcf074 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504954Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#649001}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c0eaf0c733e8..21f59eba3910 Created with: gclient setdep -r src-internal@21f59eba3910 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=huangs@chromium.org,battre@chromium.org,collinbaker@chromium.org,tasak@chromium.org Change-Id: I771f3e7c379e1bc4d060aa8cfb64f6e23ff7b03b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559570Reviewed-by:
-
Dan Beam authored
Screenshots: https://imgur.com/a/Hsh6bKh R=rbpotter@chromium.org BUG=926883 Change-Id: Ic8ce8345e620fe569a6789686e1234e825d1a604 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559437 Auto-Submit: Dan Beam <dbeam@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
-
