GitLab

Screenshot after fix: https://imgur.com/a/0C7ZNai

This CL adds padding for the sync-confirmation title so the text doesn't
go right up to the edge, since that looks pretty broken.

Bug: 868090
Change-Id: I7d842068860abe9886c2cfe77af1ca1f48440b85
Reviewed-on: https://chromium-review.googlesource.com/1153555Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Scott Chen <scottchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579120}

This adds the referrer, extra http headers and the upload data stream
to the sub request

Bug: 110888390
Test: None
Change-Id: I66c18e8671ea61dd6078ec871da0b19f72c12589
Reviewed-on: https://chromium-review.googlesource.com/1134035Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Commit-Queue: Albert Chaulk <achaulk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579119}

Bug: 867077
Change-Id: Icad4a62735d3be6579b3c6476bbbb65ad1843ec8
Reviewed-on: https://chromium-review.googlesource.com/1150939Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579118}

> Logs a new filtering result - if the survey already existed
> Logs if a download was requested or not as a histogram
  This is logged downstream

Bug: 842692
Change-Id: Ifc4a2e9ff3a1e334a6983bf7e1a68038ff58d710
Reviewed-on: https://chromium-review.googlesource.com/1057446Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Commit-Queue: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579117}

This patch splits ups the four major components of lifecycle updates:
- Style and layout
- Compositing
- PrePaint
- Paint

into separate functions, named similarly to indicate that they are a
part of lifecycle updates.

It also separates various checks and state set up to be in a wrapper
function around UpdateLifecyclePhasesInternal to ensure that the
lifecycle updates themselves are easy to follow.

Also adds comments throughout.

R=chrishtr@chromium.org

Change-Id: I5fb23bd48757866bdb42e49b6d35fa99fa9f8d41
Reviewed-on: https://chromium-review.googlesource.com/1136882
Commit-Queue: vmpstr <vmpstr@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579116}

Tests now wait for the webRequest listeners to be set up, and the
correct render_frame_id is now used in WebRequestInfo.

The reason tests need to wait for listeners to be set up with the
network service is that requests need to be proxied through
WebRequestProxyingURLLoaderFactory for web request listeners to be
called. Since this proxy is in the browser process, we only set it
up when necessary for performance reasons. This means that if there
are no web request listeners set up, we do not proxy requests, but
when the first listener is set up we then reset all
URLLoaderFactories, which causes them to be recreated with the
proxy. Because of this, there is a behavior difference in the
network service, where code like:

  chrome.webRequest.foo.addListener(...);
  sendSomeRequest(...);

will no longer work with network service. This should probably be
fine since this is a very rare occurrence. For more discussion on
this, see crbug.com/784576#c19.

Bug: 721414
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: I92fb4a02b14641886624a726301acc9e95f53533
Reviewed-on: https://chromium-review.googlesource.com/1149407Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579115}

Bug: 868828,827242
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I13199db914192ab81bbe6fd34b086b58fa275fa4
Reviewed-on: https://chromium-review.googlesource.com/1155005Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Commit-Queue: Saman Sami <samans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579114}

Oops hadn't saved file locally before "git cl upload -c" for last patch
set @ https://chromium-review.googlesource.com/c/chromium/src/+/1153458

TBR=kylechar@chromium.org

Bug: None
Change-Id: I4466d287a80f4472b61da2017c28c01ff31c4dbb
Reviewed-on: https://chromium-review.googlesource.com/1155250Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579113}

Another regression in GCC build caused by the introduction of wtf_size_t on
WTF::Vector in the commit 9d0fd86c "Introduce wtf_size_t which is typedef
for uint32_t".

In this case, it failed because the WTF::CrossThreadCopier structs for vector
were still using size_ instead of wtf_size_t.

Bug: 819294
Change-Id: I62811a58218696f5c3bd409132b44954ff682a40
Reviewed-on: https://chromium-review.googlesource.com/1155110Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579112}

(FullscreenSecureOrigin + FullscreenInsecureOrigin) / PageVisits = 1.78%

Bug: 864196
Change-Id: I88e313288e5d960ba8bc93cef4b45b8a2e6af8ac
Reviewed-on: https://chromium-review.googlesource.com/1151652Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Bryan McQuade <bmcquade@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Yao Xiao <yaoxia@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579111}

When the native share menu was an experiment, we needed to replace the
Email Page Location menu item at runtime if the experiment was enabled.

It's now been enabled for a while, so this change removes the Email
Page Location menu item entirely and creates the Share menu item as
part of the initial menu creation.

Also removes the experiment infrastructure for share menu.

Bug: 770804
Change-Id: If5f17c213ffb185b461ee4e766423c647cb43e18
Reviewed-on: https://chromium-review.googlesource.com/1152007
Commit-Queue: Leonard Grey <lgrey@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579110}

This classifier is superseded by server-side classifiers. Since
the generation logic in the renderer process is going to be refactored
and simplified, that the good time to remove it.

Bug: 866444, 621442
Change-Id: I813d53fda594956813fc8cd83567712e34331cfb
Reviewed-on: https://chromium-review.googlesource.com/1146724
Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579109}

They've bitrotten quite a bit :(

Bug: 853040,824539
Change-Id: I5127a984e7a92a7fc74cd57b9f5945f3abe7c5f6
Reviewed-on: https://chromium-review.googlesource.com/1120431Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579108}

This patch excludes SelfPaintingLayer fragments, such as
'visibility: hidden', from ContentsInkOverflow, by following
the logic in LayoutBox::AddOverflowFromChild.

Seems to fix 10 tests. 2 layer dump rebaselines are no longer
needed, but
compositing/iframes/floating-self-painting-frame.html
starts failing. Somehow we fail to invalidate the self
painting layer created by iframe.

Bug: 635619
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I09ab9a5fa2c062acf4d5cd37225e5c8f756ad04b
Reviewed-on: https://chromium-review.googlesource.com/1155029Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579107}

https://chromium.googlesource.com/catapult.git/+log/dd9e5b9c8c10..0f2c4fec1272


git log dd9e5b9c8c10..0f2c4fec1272 --date=short --no-merges --format='%ad %ae %s'
2018-07-30 dtu@chromium.org [pinpoint] Rename "Values" to "Get results".
2018-07-30 wangge@google.com Add new flag '--compatibility-mode' to Run Benchmark in Compatibility Mode


Created with:
  gclient setdep -r src/third_party/catapult@0f2c4fec1272

The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:866881
TBR=sullivan@chromium.org

Change-Id: I9c8ba6acf9bc368320880b603b4453953a0f033d
Reviewed-on: https://chromium-review.googlesource.com/1155227Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#579106}

Track whether form submits have user gestures when opening external
applications.

BUG=839751

Change-Id: I2b3689bc3eded951641ecab80ed2e3f363ff2abb
Reviewed-on: https://chromium-review.googlesource.com/1153771Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Troy Hildebrandt <thildebr@chromium.org>
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579105}

This broke as of b29640a7 ("[ozone/wayland/drm] Implement gbm bo
wrapper in common.").

Bug: 866564
Test: compile
Change-Id: Id85dbb719e39b61f11cb756bbb7212d8bfdf88b3
Reviewed-on: https://chromium-review.googlesource.com/1151457Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Commit-Queue: Michael Spang <spang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579104}

https://skia.googlesource.com/skia.git/+log/c06b8a4e0ca3..62501c12c83e


git log c06b8a4e0ca3..62501c12c83e --date=short --no-merges --format='%ad %ae %s'
2018-07-30 brianosman@google.com Remove unused 'create_flutter_test_images' tool
2018-07-30 herb@google.com Combine GPU drawing routines into one large routine
2018-07-30 fmalita@chromium.org [sksg] Fix image filter quality handling
2018-07-30 skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll skia/third_party/skcms 779b8c7799f3..c663954a7567 (1 commits)
2018-07-30 brianosman@google.com Add 'u' to zoom stats display on high DPI devices
2018-07-30 skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll skia/third_party/skcms 6b7ef53d3298..779b8c7799f3 (1 commits)
2018-07-30 bsalomon@google.com Introduce enum class for texture type.
2018-07-30 herb@google.com Make a glyphrun version of DrawBmpPosTextAsPaths
2018-07-30 herb@google.com Make SkInternalAtlasTextTarget use glyph runs
2018-07-30 skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll skia/third_party/skcms 51fba282d9a0..6b7ef53d3298 (1 commits)
2018-07-30 skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll skia/third_party/skcms 23e7777f421d..51fba282d9a0 (1 commits)


Created with:
  gclient setdep -r src/third_party/skia@62501c12c83e

The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=scroggo@chromium.org

Change-Id: If8b9200e3040acf6e3e13336f76f1798c4ab80ea
Reviewed-on: https://chromium-review.googlesource.com/1155168Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#579103}

When closing the last incognito tab, the incognito TabGridMediator's
TabModel is reset to nil as the incognito BrowserState is being
destroyed.  This can occur by tapping the close button and new tab
button at the same time, or simply by tapping the new tab button when
a tab is closed by JavaScript.  Simultaneous button tapping was disabled
by crrev.com/c/1150634.  This CL adds an extra safeguard to prevent the
creation of WebStates with a nil BrowserState.

Bug: 838961
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Iae669290bb9d8079861d488e46cd59495dc809fb
Reviewed-on: https://chromium-review.googlesource.com/1152454Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579102}

Chrome assigns a download Id to each new download.
This ID was retrieved from the history DB on start up, and then
keep on incrementing.
For in-progress DB work, download will only be stored to history DB
once they finish.
As a result, the history DB don't have all the Ids on startup.
This CL lets the DownloadManagerImpl to get all Ids from both
history DB and In-progress downloads.
And use the largest Id to issueing out new Ids for new downloads.
This allows in-progress downloads to have their own IDs without
reporting them to history DB.

BUG=842245

Change-Id: Ia5130f02b0e32e09ba4395a6bfa10dfd5adafc82
Reviewed-on: https://chromium-review.googlesource.com/1144311
Commit-Queue: Min Qin <qinmin@chromium.org>
Reviewed-by: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579101}

This reverts commit 9d5b1986.

Reason for revert: Didn't fix the crashes

Original change's description:
> Revert BridgedNativeWidget compositor recycling
> 
> We've previously disabled this, but now try reverting all of the code
> back to the way it was prior to compositor recycling being possible.
> 
> TBR=lgrey (revert of files from https://crrev.com/574738)
> 
> Bug: 863817
> Change-Id: I1b933e17c523fb14860284f06631cb2af0c4bf98
> Reviewed-on: https://chromium-review.googlesource.com/1152548
> Reviewed-by: ccameron <ccameron@chromium.org>
> Commit-Queue: ccameron <ccameron@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#578522}

TBR=ccameron@chromium.org,lgrey@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 863817
Change-Id: I66f78ab5d216b7a29719005c2117cecfa71a8c2a
Reviewed-on: https://chromium-review.googlesource.com/1155051Reviewed-by: ccameron <ccameron@chromium.org>
Commit-Queue: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579100}

Bug: 868253
Change-Id: Ib79fe6b36e3bfb06bc44d050d154c1ad23cf1585
Reviewed-on: https://chromium-review.googlesource.com/1153469Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Commit-Queue: Nate Chapin <japhet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579099}

https://android.googlesource.com/platform/external/perfetto.git/+log/7e4b89eab724..296b43d7e177


git log 7e4b89eab724..296b43d7e177 --date=short --no-merges --format='%ad %ae %s'
2018-07-30 hjd@google.com perfetto-ui: Fix half pixel offset in TimeAxis


Created with:
  gclient setdep -r src/third_party/perfetto@296b43d7e177

The AutoRoll server is located here: https://perfetto-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=perfetto-bugs@google.com

Change-Id: I544c81f24a8b570454c02fcab70b2678aaac6bec
Reviewed-on: https://chromium-review.googlesource.com/1155009
Reviewed-by: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#579098}

Bug: 852872
Change-Id: Id8211211920db4ee977ea0dfd665b0c571ccd224
Reviewed-on: https://chromium-review.googlesource.com/1147090
Commit-Queue: Dan H <harringtond@chromium.org>
Reviewed-by: Shakti Sahu <shaktisahu@chromium.org>
Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579097}

SitePerProcessHitTestBrowserTest.TouchpadPinchOverOOPIF is being
reported as flaky on Windows.

Bug: chromium:868308, chromium:833380
TBR: kenrb@chromium.org
Change-Id: I83142d0d777bbe51773eaba0ab1d191a4af0cbc5
Reviewed-on: https://chromium-review.googlesource.com/1155165Reviewed-by: Kevin McNee <mcnee@chromium.org>
Commit-Queue: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579096}

Fixes code and corresponding text.

Tested change interactively using the repro steps on the bug.

Bug: 868486
Change-Id: Id81cbddf28242b6c4efe5c50595fdb393d59d5b1
Reviewed-on: https://chromium-review.googlesource.com/1154432
Commit-Queue: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579095}

Currently, when a user selects multiple lines of text, right clicks, and
selects "Look Up", the yellow overlay appears on the last line of the
selected text but with the text of the first line of the selected text.

WebSubstringUtil::GetBaselinePoint() was modified to call
FirstRectForRange() instead of ComputeTextRect(). FirstRectForRange()
returns the IntRect for the first line of text which is needed to get
the baseline point of the first line of text.

WebViewTest.WebSubstringUtilBaselinePoint was added to test that the
baseline point does not change when multiple lines of text are selected
compared to a single line of text.

Bug: 819864
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: Iec0bac8d45baf2142ea5e826ebdfd7d997e7f584
Reviewed-on: https://chromium-review.googlesource.com/1103448
Commit-Queue: Tessa Nijssen <tnijssen@google.com>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Sarah Chan <spqchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579094}

Added functionality for editing the title and URL of a custom link. If
the new URL already exists as a custom link, the edit is not applied.

Bug: 851293, 856394
Change-Id: I8a5351644370b6f91ef4376e7b336dce6831acbd
Reviewed-on: https://chromium-review.googlesource.com/1152495
Commit-Queue: Kristi Park <kristipark@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Reviewed-by: Will Harris <wfh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579093}

A CL adding new headers without corresponding GN changes is likely
wrong.

Bug: 661774
Change-Id: I11da5615b36ebc7b9f60490beb3a39874bd74ac2
Reviewed-on: https://chromium-review.googlesource.com/1152126
Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579092}

Bug: None
Change-Id: Idc9656daa337ffc73466a66a60965a1b7420079c
Reviewed-on: https://chromium-review.googlesource.com/1153429Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Commit-Queue: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579091}

This reverts commit 0f6c2c59.

Reason for revert: crash on OnFocusTabScoreAdjustmentTimeout

Bug: 869037

Original change's description:
> Set oom_score_adj of chrome processes directly
> 
> Setting oom_score_adj directly is faster and doesn't have to involve
> debugd when ARC++ is disabled.
> 
> Bug: 868249
> Change-Id: Ifeda6cd1d393c85f373928aafadd4ec3d3941a92
> Reviewed-on: https://chromium-review.googlesource.com/1152751
> Reviewed-by: Cheng-Yu Lee <cylee@chromium.org>
> Commit-Queue: Vovo Yang <vovoy@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#578987}

TBR=cylee@chromium.org,vovoy@chromium.org

Change-Id: Iafc37f22743479ba558fcc520bd24e7a30bcc693
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 868249
Reviewed-on: https://chromium-review.googlesource.com/1155327Reviewed-by: Jun Mukai <mukai@chromium.org>
Commit-Queue: Vovo Yang <vovoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579090}

ErrorRetryStateMachine is meant to manage the displaying of error pages
when a navigation fails and retrying the original URL when user
navigates back to an error page. SSL interstitial and other errors that
do not load error page (e.g. canceled navigation) should not modify an
item's ErrorRetryStateMachine to avoid trigger the error retry logic
when user navigates back to such an item.

Bug: 837210
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I8dfd11821dfb8cb9ee6f10820b88499c915d1994
Reviewed-on: https://chromium-review.googlesource.com/1151949
Commit-Queue: Danyao Wang <danyao@chromium.org>
Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579089}

With this change, no caching headers are sent for icons, which is a
default of in-memory caching.

Bug: 868432
Test: None
Change-Id: I8dedb6a33035dd7e6cf32479921c0e6180e9ad03
Reviewed-on: https://chromium-review.googlesource.com/1154362Reviewed-by: Kristi Park <kristipark@chromium.org>
Commit-Queue: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579088}

R=cmasso@chromium.org

Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ib54d1eb04f8f7f6103eb3f3be3afc910445f160c
Reviewed-on: https://chromium-review.googlesource.com/1155260Reviewed-by: Krishna Govind <govind@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579087}

Passing pinpoint job here:
https://pinpoint-dot-chromeperf.appspot.com/job/16e3abd5a40000

Bug: 673775
Change-Id: I98cb4f3099b25512e0dc36c3adbc6f8b890fe46d
Reviewed-on: https://chromium-review.googlesource.com/1143596
Commit-Queue: Timothy Dresser <tdresser@chromium.org>
Reviewed-by: Charlie Andrews <charliea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579086}

Turns this:

separator = {
  <std::__1::__basic_string_common<true>> = {<No data fields>},
  members of std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >:
  static __short_mask = 1,
  static __long_mask = 1,
  __r_ = {
    <std::__1::__compressed_pair_elem<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >::__rep, 0, false>> = {
      __value_ = {
        {
          __l = {
            __cap_ = 2108420,
            __size_ = 0,
            __data_ = 0x0
          },
          __s = {
            {
              __size_ = 4 '\004',
              __lx = 4 '\004'
            },
            __data_ = ", ", '\000' <repeats 20 times>
          },
          __r = {
            __words = {[0] = 2108420, [1] = 0, [2] = 0}
          }
        }
      }
    },
    <std::__1::__compressed_pair_elem<std::__1::allocator<char>, 1, true>> = {
      <std::__1::allocator<char>> = {<No data fields>}, <No data fields>}, <No data fields>},
  static npos = 18446744073709551615
}

Into this:

separator = ", "

BUG=866697
R=thakis
CC=leszeks

Change-Id: I4b35799c6023743b5876aa89a2448b8f841c7751
Reviewed-on: https://chromium-review.googlesource.com/1152087Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579085}

Disabling test on linux.

BUG=868956
TBR=qyearsley@chromium.org,jeffcarp@chromium.org,dpranke@chromium.org,tkent@chromium.org
NOTRY=true

Change-Id: I7b1639a1dc94ff139b696633209fb72e75f92338
Reviewed-on: https://chromium-review.googlesource.com/1155103
Commit-Queue: Roger Tawa <rogerta@chromium.org>
Reviewed-by: Roger Tawa <rogerta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579084}

This CL adds the class MessageLoopObserver, which forwards events from the UI
and IO thread message loop task runners to the responsiveness Watcher and
Calculator.

Bug: 859155
Change-Id: Ie492f1fbc26940007cb303bdc5cdbdb59d887c19
Reviewed-on: https://chromium-review.googlesource.com/1149042
Commit-Queue: Erik Chen <erikchen@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579083}

This CL does a few things:
1. Updates the PerfBenchmark to pull the fieldtrial config from
   chrome_root, if it is specified instead of using the location of
   the python file itself as reference.

2. Make FixupTargetOS public, so tests can reliably compute the
   platform that variations code expects.

3. Alter the actual test to pull variations params from a test file,
   so we can actually expect the exact arguments added to extra_args.

Bug: 844863
Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi
Change-Id: Ia2a0b77246de6362321bd36eabc13f840d7b5c1b
Reviewed-on: https://chromium-review.googlesource.com/1151447
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579082}

Adds a missing data entry to the chrome_test_ar_java target that was
causing the bot that runs the test to fail due to being unable to find
the ArCore APK.

TBR=agrieve@chromium.org

Bug: 851020
Change-Id: Ib96b57fe46a7e2ef73501d98deb5eacaa71cead3
Reviewed-on: https://chromium-review.googlesource.com/1155155Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579081}