GitLab

BUG=20413
TEST=none

Review URL: http://codereview.chromium.org/194047

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25676 0039d316-1c4b-4281-b951-d872f2087c98

BUG=21321

TEST=None

Review URL: http://codereview.chromium.org/197048

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25673 0039d316-1c4b-4281-b951-d872f2087c98

It appears that Nvidia's libGL.so is overriding dlopen/dlsym with
versions that don't fully function. So far, all the users reporting
this have been running Gentoo, but it might just be that they have
up-to-date drivers. The report[1] suggests that all drivers >= 180
have this issue.

[1] http://www.nvnews.net/vbulletin/showthread.php?t=132259

BUG=16800
http://codereview.chromium.org/201055


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25671 0039d316-1c4b-4281-b951-d872f2087c98

BUG=21295

TEST=None

Review URL: http://codereview.chromium.org/200044

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25670 0039d316-1c4b-4281-b951-d872f2087c98

Also, merge in http://codereview.chromium.org/174367 (original author: vandebo@chromium.org), which is the downstream half of r48168.

BUG=4360
BUG=21228
BUG=18792
TEST=none
TBR=eroman


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25669 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/200048

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25667 0039d316-1c4b-4281-b951-d872f2087c98

This makes some plugins happy.  As described in the file comments,
this approach is also used by nspluginwrapper.

Review URL: http://codereview.chromium.org/202012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25665 0039d316-1c4b-4281-b951-d872f2087c98

The rendering of repaint areas is still different from upstream due to differences in repaint logic.

R=jparent
TEST=none
BUG=8630

Review URL: http://codereview.chromium.org/196047

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25663 0039d316-1c4b-4281-b951-d872f2087c98

Pretty-up the blocked popup view by sharing code from the status bubble. Blocked Popup view is now themed as well.
BUG=20815
TEST=popup blocking and status bubble still work.
Review URL: http://codereview.chromium.org/196043

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25662 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=Run the FocusManager unit tests

Review URL: http://codereview.chromium.org/200020


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25660 0039d316-1c4b-4281-b951-d872f2087c98

TEST=Try installing and/or loading some extensions, and toggling between enable and disable in the management UI (chrome://extensions).
BUG=12122

Review URL: http://codereview.chromium.org/199018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25659 0039d316-1c4b-4281-b951-d872f2087c98

- verify main object is a dictionary
- verify load key is present and points to a bool
- verify all key values are dictionaries
- verify all key values have (correct) delta/var keys
- verify all keys are in correct format (a/b/c/d)

BUG=18597
TEST=verify unit tests catches these errors
Review URL: http://codereview.chromium.org/194032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25656 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=None
TBR=gregoryd

Review URL: http://codereview.chromium.org/196045

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25655 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=None
TBR=sgk

Review URL: http://codereview.chromium.org/195027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25654 0039d316-1c4b-4281-b951-d872f2087c98

the URL that I shouldn't have (it won't be needed at some point, but it
is now).

BUG=21198
TEST=Select a URL and drag to the tab strip. Make sure you get the
     drop target and you can drop the text to create a new tab. Do the
     same with www.google.com, you shouldn't get a drop target.

Review URL: http://codereview.chromium.org/202010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25653 0039d316-1c4b-4281-b951-d872f2087c98

Adjusting installer_util_strings to attempt to avoid incredibuild
mysterious failure.

BUG=None
TEST=None
TBR=gregoryd

Review URL: http://codereview.chromium.org/200046

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25652 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/200031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25650 0039d316-1c4b-4281-b951-d872f2087c98

get deleted anyway by jam's pending media player plugin changes.

I also disabled the DefaultPluginParsingTest as it fails when we remove these stub functions. However
this is also getting deleted in jam's media player change.

TBR=amit, jam(FYI)

Review URL: http://codereview.chromium.org/201051

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25648 0039d316-1c4b-4281-b951-d872f2087c98

IDR_THEME_TOOLBAR is a generated blank image of the bg[SELECTED] color,
which will be drawn by default on GtkWidgets. Uploading an image of
said color to the X server on each expose and then asking it to tile the
image across the widget is silly; stop doing it.

Also sets clip rectangles correctly in a few places where we were using GdkGC
instead of skia.

Review URL: http://codereview.chromium.org/196044

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25647 0039d316-1c4b-4281-b951-d872f2087c98

* Complete the 'contextID' to 'hostID' renaming since that terminology is now used in webcore ResourceRequest.

This patch depends on a corresponding webkit change in the chromium port.https://bugs.webkit.org/show_bug.cgi?id=28960

Review URL: http://codereview.chromium.org/201026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25646 0039d316-1c4b-4281-b951-d872f2087c98

Fix a suppression and remove one that duplicates it.
Widen a suppression
Add a bunch of new suppressions.

BUG=11333,21137,21279,21280,20580,21286
TEST=More green on the Mac valgrind bots.

Review URL: http://codereview.chromium.org/197043

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25645 0039d316-1c4b-4281-b951-d872f2087c98

* Uses the awesome ChromeUILocalizer infrastructure.
* Also solves the issue of hard coded prodcut names.

BUG=19160,19651,19176
TEST=First run dialog + it's progress dialog should now say "Chromium" instead of "Google Chrome".

Review URL: http://codereview.chromium.org/199035

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25644 0039d316-1c4b-4281-b951-d872f2087c98

BUG=19483
TEST=none

Review URL: http://codereview.chromium.org/193033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25643 0039d316-1c4b-4281-b951-d872f2087c98

Fix compile error in serializer.cc
Don't force rebuild of idl files.
Review URL: http://codereview.chromium.org/195023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25642 0039d316-1c4b-4281-b951-d872f2087c98

Update a bunch of test_expectations for xmlhttprequest tests with data from layout test dashboard.  This addresses the cases of unnessary expecations, either tests that have expectations but have passed the last 200 runs or tests that have an extra expectation from the past 200 runs.

TEST=running through layout test try servers
BUG=
Review URL: http://codereview.chromium.org/197033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25640 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/201046

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25639 0039d316-1c4b-4281-b951-d872f2087c98

The histograms will be more accurate after this change.

TEST=none
BUG=20335

Review URL: http://codereview.chromium.org/192038

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25638 0039d316-1c4b-4281-b951-d872f2087c98

BUG=http://code.google.com/p/chromium/issues/detail?id=14654, http://code.google.com/p/chromium/issues/detail?id=20985
TEST=LayoutTests/fast/events/drag-dropeffect.html, LayoutTests/editing/pasteboard/files-during-page-drags.html

Review URL: http://codereview.chromium.org/192040

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25636 0039d316-1c4b-4281-b951-d872f2087c98

support explicit positioning of the tooltip as windows does. That'll
have to be added later.

BUG=none
TEST=make sure tooltips still work correctly on windows

Review URL: http://codereview.chromium.org/197031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25635 0039d316-1c4b-4281-b951-d872f2087c98

R=agl

Review URL: http://codereview.chromium.org/200033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25634 0039d316-1c4b-4281-b951-d872f2087c98

How do you guys feel about trying this pach for a few days?

The idea is to have devs that run their own build to help us test
wether or not we are having serious errors.

I'll monitor the crash server to see if we get crashes here

BUG=11908
TEST=none


Review URL: http://codereview.chromium.org/195020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25633 0039d316-1c4b-4281-b951-d872f2087c98

DefaultNPObject can derive from bases other than NPObject, allowing concrete NPObjects to choose their own NPObject subclass.
DefaultNPObject does not rely on virtual functions. See change to NPGetClass in np_class.h.

Removed count() from MockNPObject because I discovered gmock checks that no mock objects exist after a test completes anyway.

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/196032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25632 0039d316-1c4b-4281-b951-d872f2087c98

Don't call PR_GetErrorText because it is deprecated.  Just
print the error code returned by PR_GetError.

Pass NULL to NSS_NoDB_Init.  (The argument is ignored.)

R=ukai
BUG=20787,20819
TEST=Chromium should work on Red Hat Enterprise Linux and CentOS that
have libnss3.so version 3.12.4.1 but libsoftokn3.so 3.11.4, which does
not support the sql: database format we're using.
Review URL: http://codereview.chromium.org/201036

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25630 0039d316-1c4b-4281-b951-d872f2087c98

This allows the HTML5 DataTransfer effectAllowed and dropEffect properties to be set correctly in JS handlers, as per the HTML5 spec.
(The drag-dropeffect test isn't in WebKit yet -- it's part of a separate WebKit patch that's been in review for weeks.)
R=darin,pink
BUG=http://code.google.com/p/chromium/issues/detail?id=14654, http://code.google.com/p/chromium/issues/detail?id=20985
TEST=LayoutTests/fast/events/drag-dropeffect.html, LayoutTests/editing/pasteboard/files-during-page-drags.html
Review URL: http://codereview.chromium.org/174364

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25629 0039d316-1c4b-4281-b951-d872f2087c98

TEST=none
BUG=none
Review URL: http://codereview.chromium.org/197041

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25628 0039d316-1c4b-4281-b951-d872f2087c98

Trouble was seen in r25602, r25601 and r25574 et. al. on the waterfall.

Review URL: http://codereview.chromium.org/199045

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25627 0039d316-1c4b-4281-b951-d872f2087c98

BUG=21277
TEST=none
R=thomasvl


Review URL: http://codereview.chromium.org/200043

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25626 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
TBR=eroman


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25625 0039d316-1c4b-4281-b951-d872f2087c98

This time really properly.

TEST=none
http://crbug.com/20347

Review URL: http://codereview.chromium.org/196019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25624 0039d316-1c4b-4281-b951-d872f2087c98

added infrastructure to better support events and cleaned up callback testing.

Review URL: http://codereview.chromium.org/192028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25623 0039d316-1c4b-4281-b951-d872f2087c98