- 01 Dec, 2017 40 commits
-
-
David Benjamin authored
https://boringssl.googlesource.com/boringssl/+log/fc9c67599d9bdeb2e0467085133b81a8e28f77a4..48eaa28a124e702edf373e212011cb283f0f0161 BUG=none Change-Id: I4e722641068bb53d07ad06c634657d79960faab8 Reviewed-on: https://chromium-review.googlesource.com/803840 Commit-Queue: David Benjamin <davidben@chromium.org> Commit-Queue: Steven Valdez <svaldez@chromium.org> Reviewed-by:
Steven Valdez <svaldez@chromium.org> Cr-Commit-Position: refs/heads/master@{#521060}
-
Artur Khachatryan authored
Bug: chromedriver:2105 Change-Id: I7a4274ae6f670d39071809a34e66fbac09001fba Reviewed-on: https://chromium-review.googlesource.com/803631Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#521059}
-
James Cook authored
This debugging/presentation feature was tied to Ctrl-Alt-P. Usage is very low per UMA metrics. We suspect most usage was from users mistakenly hitting it when pressing Ctrl-P to print. Since it was tied to a pref the user could get stuck in this state. It also didn't work at the login screen and would turn on and off when switching multiprofile users. This feature is useful for debugging, recording videos of touch bugs, and for projecting demos. UI review suggested moving it to about:flags alongside the other touch debug flags. * Remove the pref and add cleanup code to wipe the existing value. * Remove the accelerator key. * Add --show-taps. The name is inspired by the Android OS developer option that does the same thing. TBR=rockot@chromium.org Bug: 786115 Test: existing ash_unittests Change-Id: I07579bff6ab3dd16ec5c14347df1a047b1aa935c Reviewed-on: https://chromium-review.googlesource.com/802075 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#521058}
-
Aga Wronska authored
Consume fixed storage disk events in StorageMonitorChromeos. Only observe stateful partition, because it is relevant for users. Bug: 420633 Change-Id: Ia235b8f60b94c396c90da856bc68e3a61b2292dd Reviewed-on: https://chromium-review.googlesource.com/786649 Commit-Queue: Aga Wronska <agawronska@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Toni Barzic <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#521057}
-
Joshua Bell authored
The [SecureContext] extended attribute now applies correctly to interfaces, so make sure that the StorageManager interface is not exposed in non-secure contexts, not just the `navigator.storage` entry point. Bug: 726510 Change-Id: Ie141aa4e29e261f1107af292f74f8063370c3748 Reviewed-on: https://chromium-review.googlesource.com/802676Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#521056}
-
Alexander Alekseev authored
This is an update to https://chromium-review.googlesource.com/783707 that ensures that blocking GetCollectStatsConsent is used only on a blocking thread. Bug: 782641 Change-Id: I5629e00616f1ab24b4a63f1c3433f683370c3239 Reviewed-on: https://chromium-review.googlesource.com/802764 Commit-Queue: Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#521055}
-
https://chromium-review.googlesource.com/c/chromium/src/+/801350Peter Kasting authored
BUG=none TEST=none Change-Id: If31621b94082b463ec2d90f7f8d59f11e6052bed Reviewed-on: https://chromium-review.googlesource.com/802975Reviewed-by:
Kevin Bailey <krb@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#521054}
-
rbpotter authored
PAGE_DONE is not useful on non-Windows platforms. Stop dispatching the event in these cases. Bug: None Change-Id: I317b8d7ecd265c8386d474316685bcfb7113061c Reviewed-on: https://chromium-review.googlesource.com/802822 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#521053}
-
Sky Malice authored
FieldTrials should be recorded through sync when an event logger client registers a dependency, their dependent event is recorded, and the trial is finalized. All trials are recorded whenever the FieldTrial event is emitted, which should be on a change or period, but no more. Feature [and params] exist but may never actually change. Because FieldTrials (and other imminent types) are not tied to navigations, reworked the ShouldRecordEvent() check to be more permissive, but also enforce presence (or lack) of navigation id. Bug: 719038 Change-Id: Ib62a18949dde41d194935347768b3fef0d2623d6 Reviewed-on: https://chromium-review.googlesource.com/764408 Commit-Queue: Sky Malice <skym@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Cr-Commit-Position: refs/heads/master@{#521052}
-
Tom Sepez authored
Distinguish between the permission errors the broker process fabricates vs. organically ocurring EPERM from a syscall. Use block-scope rather than unique_ptrs to force broker destruction. Fix a dubious use of ScopedFD(). ScopeFD's only legal bad FD value is -1, which co-incidentally happens to be -EPERM. So don't apply this where we know the file is invalid, since other negative values cause a CHECK(). Convert some ASSERTS to EXPECTS, to avoid crashes. Change-Id: I822e15e1ff386687627ba27c8f9fff158c10f316 Reviewed-on: https://chromium-review.googlesource.com/797919 Commit-Queue: Tom Sepez <tsepez@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#521051}
-
Sergey Ulanov authored
It is possible to set fixed sample rate in cast_shell on Linux with --alsa-fixed-output-sample-rate, but it wasn't possible on Fuchsia. Added --audio-output-sample-rate, which allows to set fixed sample rate on both platforms. For backward compatibility kept the old ALSA-specific flag, but it's marked as deprecated now. Bug: 772488 Change-Id: I0f980f09b432768ff9bb51191a9b1ec31e89274f Reviewed-on: https://chromium-review.googlesource.com/798066Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#521050}
-
Christopher Grant authored
This change migrates the omnibox sizing, layout, text and colors to match UX spec. Things like rounded corners are still missing. Also, fix the UI testapp. BUG= R=bshe Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I96bc91c8c80d070dd3e09275d35eb61774468559 Reviewed-on: https://chromium-review.googlesource.com/801954Reviewed-by:
Biao She <bshe@chromium.org> Commit-Queue: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#521049}
-
Jay Civelli authored
Adding a bound accessor to service_manager::Connector so clients that require a fresh (unbound) connector can check that. Bug: None Change-Id: I555e32b71d7259713544f6283c8868827409382c Reviewed-on: https://chromium-review.googlesource.com/803907Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Jay Civelli <jcivelli@chromium.org> Cr-Commit-Position: refs/heads/master@{#521048}
-
Min Qin authored
The current logic uses ResourceDispatcherHostDelegate. This doesn't work when network service is enabled. This CL rewrites the logic using ContentBrowserClient, so test can work with and without network service enabled BUG=715630 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I109a7f3fafe6a7d81a98ef39f2b828e7e0551cf0 Reviewed-on: https://chromium-review.googlesource.com/801370Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#521047}
-
Justin Cohen authored
Bug: 784510 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I3ca7d45d6c5cf04aa97a787b106a2529daa8e421 Reviewed-on: https://chromium-review.googlesource.com/788450 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#521046}
-
Peter Kotwicz authored
Personally, I no longer feel confident to review code in ash/wm BUG=None Change-Id: I5258309ba7171eb34ad3a3b9b78ca2bb6cdc71f2 Reviewed-on: https://chromium-review.googlesource.com/783800Reviewed-by:
Valery Arkhangorodsky <varkha@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#521045}
-
Luis Hector Chavez authored
This change adds arc::WaitForInstanceReady(), so that tests that manually invoke SetInstance() can wait until the instance has been fully connected in a safe, race-free way. Bug: 782895 Test: git cl try Change-Id: I4480ab78401bb145ba99fa60a1417b2c8c6af94d Reviewed-on: https://chromium-review.googlesource.com/802191 Commit-Queue: Luis Hector Chavez <lhchavez@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#521044}
-
Joy Ming authored
There was a bug that it was not possible to cancel a notification after the download was paused. This is because in API < 21, calling stopForeground(false) would make the notification continue to be classified as on-going and therefore undismissable, which is what was happening in the pause case. This CL fixes this problem by inducing a flicker that dissociates the notification from the foreground service in the case that the Android version is API < 21. Bug: 788080 Change-Id: I9c8776d245425b0fe78aaccf7e75fcfb6e57f039 Reviewed-on: https://chromium-review.googlesource.com/802078Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Joy Ming <jming@chromium.org> Cr-Commit-Position: refs/heads/master@{#521043}
-
Philip Rogers authored
This test now matches the non-RLS expectations except for extra scrolling layers. Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_root_layer_scrolls Change-Id: I7eef36da8f1d7bbf04d1c9a3c0e9f6010579b814 Reviewed-on: https://chromium-review.googlesource.com/804204 Commit-Queue: Philip Rogers <pdr@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Reviewed-by:
Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#521042}
-
Patrick Monette authored
Bug: 624061 Change-Id: I743121dc676720fd92bae8e27a9c1d7e305e54f9 Reviewed-on: https://chromium-review.googlesource.com/755523 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#521041}
-
David Trainor authored
BUG=773403 Change-Id: Ie6eb72cb6b83321c3ca2094645bab8340879da9d Reviewed-on: https://chromium-review.googlesource.com/798217Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#521040}
-
Andrew Grieve authored
Should have no change in behavior. Explicitly generating the IDs on the root node makes it clear at what point they are generated, and from what tree state. It also makes it clear that IDs are assigned only once. Before this change, there was a cache to ensure IDs were generated only once, but it's not great to rely on a cache for semantics. Change-Id: I24898c740709231e14e28dbd39e32d45945ddcec Reviewed-on: https://chromium-review.googlesource.com/803754 Commit-Queue: agrieve <agrieve@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#521039}
-
Mathieu Perreault authored
Bug: 789711 Change-Id: Iae6bc67ba67f8f9e492bd065a8d75903b7cf92a9 Reviewed-on: https://chromium-review.googlesource.com/801457 Commit-Queue: Mathieu Perreault <mathp@chromium.org> Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Cr-Commit-Position: refs/heads/master@{#521038}
-
Philip Rogers authored
This patch adds platform-specific expectations to this passing test. Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_root_layer_scrolls Change-Id: I985ce12ac1aafa21eaefa7836422e051df3e07f4 Reviewed-on: https://chromium-review.googlesource.com/803659 Commit-Queue: Philip Rogers <pdr@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Reviewed-by:
Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#521037}
-
Michael Spang authored
Add a tracing agent and matching service so that tracing on Cast devices can collect kernel traces. The implementation is based on the CrOS tracing agent and debugd service. This is very barebones at the moment (service only depends on //base) to keep the size down. We don't have dbus, although we might be able to use mojo to manage the socket. BUG=786091 Change-Id: I76157157506628004d812db3f452a486b2962845 Reviewed-on: https://chromium-review.googlesource.com/775557Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
dsinclair <dsinclair@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Reviewed-by:
Alex Sakhartchouk <alexst@chromium.org> Commit-Queue: Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#521036}
-
Erik Luo authored
Migrate the easily migratable tests in styles-1. Bug: 667560 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I1e73e502bbd637585d7cc34eaebac73a5cf21094 Reviewed-on: https://chromium-review.googlesource.com/802542Reviewed-by:
Will Chen <chenwilliam@chromium.org> Commit-Queue: Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#521035}
-
John Abd-El-Malek authored
This was originally added in 440645 using a resource throttle. Since resource throttles don't work with the network service (as net runs out of process), instead do this in the same ContentBrowserClient callback which is used to add extra headers for prerendering requests. Also convert a few prefetch tests for this to use the new URLLoaderInterceptor so that they pass with the network service. Bug: 769401 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I993912ff991dda33c0fb58ae8e38f88fd16ee4ac Reviewed-on: https://chromium-review.googlesource.com/802996Reviewed-by:
Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#521034}
-
Gheorghe Comanici authored
Bug: 697624, 787940 Change-Id: I13768958722eef31361336b504efe9e93b84c054 Reviewed-on: https://chromium-review.googlesource.com/798192Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Gheorghe Comanici <gcomanici@chromium.org> Cr-Commit-Position: refs/heads/master@{#521033}
-
Jonathan authored
Newly added SitePerProcessInternalsBrowserTest doesn't work under Viz. So I'm disabling it on the FYI bots which run viz_content_browsertests TBR=kylechar@chromium.org TEST=SitePerProcessInternalsBrowserTest Bug: 760181 Change-Id: I714080f41f7f5c45811348c8da0a28631c272a35 Reviewed-on: https://chromium-review.googlesource.com/803801Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#521032}
-
Mike Lawther authored
After an email thread to community@ it was decided to be specific about who is intended to abide by the code of conduct. Change-Id: I3efc1b8a569effd8cbd1b964d9b247fea5ce5a80 Reviewed-on: https://chromium-review.googlesource.com/799710Reviewed-by:
Rachel Blum <groby@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Brett Wilson <brettw@chromium.org> Commit-Queue: Mike Lawther <mikelawther@chromium.org> Cr-Commit-Position: refs/heads/master@{#521031}
-
Christopher Cameron authored
GpuSurfaceTracker has been removed from all other desktop platforms (in crrev.com/389975) and is not used on Mac. Remove it. Include Mac in GPU_SURFACE_HANDLE_IS_ACCELERATED_WINDOW with other desktop platforms. Define gfx::AcceleratedWidget to be uint64_t instead of NSView*. It never actually was NSView*, but was rather a sequence number used to look up a ui::AcceleratedWidgetMac. Fix a number of locations that were dangerously mixing NSView* and gfx::AcceleratedWidget (now that they are incompatible types, this is a compile error). Bug: 772576 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I29212236627c512ed6a7fe55a8cf3e613e4e593a Reviewed-on: https://chromium-review.googlesource.com/792295 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#521030}
-
Sadrul Habib Chowdhury authored
If mus is not hosting viz, then it does not need to provide the connector to ozone. BUG=786453 Change-Id: I6053ca45f7338c3fa2a08ea27845f7da33117b03 Reviewed-on: https://chromium-review.googlesource.com/803838Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#521029}
-
mrefaat authored
The library Motion Animator for Objective-C is a new dependency of the Material Components for iOS. Library description: This library provides APIs that turn Motion Interchange motion specifications into animations. Bug: 785248 Change-Id: I22cbe863f6887c1098d3d33d481dc8788ef0d121 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/801978Reviewed-by:
Peter Lee <pkl@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Reviewed-by:
Louis Romero <lpromero@chromium.org> Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Cr-Commit-Position: refs/heads/master@{#521028}
-
edchin authored
Bug: 790925 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I088f7463061937cf9925284f5270568485ee0278 Reviewed-on: https://chromium-review.googlesource.com/802761 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#521027}
-
David Tseng authored
Currently, line ranges use a slightly different output path when they - have start/end on the same node - cover the node's text i.e. are not index -1 (node index) This change makes it so that we don't consider the range less than a node or use the |subNode| output path if the range surrounds the entire node's text. Test: navigate by lines (Search+up/down) over checkboxes. Output should be the same as Search+Left/Right. chromevox_tests --gtest_filter=Background*.* cover caret navigation and ensuring they still work. Bug: 784693 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I0404e11e326116e21afc2c9131a2ceeedf21e37c Reviewed-on: https://chromium-review.googlesource.com/798370Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#521026}
-
Chris Watkins authored
See the bugs and cxx post for justification and details: https://groups.google.com/a/chromium.org/forum/#!topic/cxx/RkOHzIK6Tq8 This change was done using clang-tidy as described here: https://chromium.googlesource.com/chromium/src/+/lkcr/docs/clang_tidy.md In some cases the the tool leaves behind a string of commas where it replaced a member initializer list (https://bugs.llvm.org/show_bug.cgi?id=35051). They were cleaned up with: git diff --name-only | \ xargs sed -E -i 's/(^\s*|\)\s*):[ ,]*= default/\1 = default/' BUG=778959,778957 This CL was uploaded by git cl split. R=birenroy@chromium.org Change-Id: If7a88154bf5c630dee56754cc5f800979328d7a3 Reviewed-on: https://chromium-review.googlesource.com/799593Reviewed-by:
Bence Béky <bnc@chromium.org> Commit-Queue: Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#521025}
-
Avi Drissman authored
BUG=789515 TBR=alexis.menard@intel.com Change-Id: Ic5ad0bc6247ec7548887962f6d204b63da150fc6 Reviewed-on: https://chromium-review.googlesource.com/803855 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#521024}
-
Qiang Xu authored
changes: Before operating HandleMoveWindowToDisplay, check if active window is in window cycle list. If not, no-op. Bug: 786633 Test: emulator tests and added test coverage Change-Id: I0fe06b4cac375f413b7edb4726a4a4d35536c59e Reviewed-on: https://chromium-review.googlesource.com/792512 Commit-Queue: Qiang(Joe) Xu <warx@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#521023}
-
Alice Boxhall authored
See https://chromium-review.googlesource.com/c/chromium/src/+/668309 TBR=pfeldman Bug: 514674 Change-Id: I9fae947065b657e4ae3ff8e3cb0c5b8633208b91 Reviewed-on: https://chromium-review.googlesource.com/802663 Commit-Queue: Alice Boxhall <aboxhall@chromium.org> Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Cr-Commit-Position: refs/heads/master@{#521022}
-
Bret Sepulveda authored
When a LabelButton changes its label from a longer to a shorter string it would not decrease in size. This patch removes that code and cleans up the tests and related code. Bug: 790808 Change-Id: I6fce4b3ecf3335c2a9d31bc2a3ac73e18f1e92a8 Reviewed-on: https://chromium-review.googlesource.com/798323 Commit-Queue: Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#521021}
-