GitLab

https://android.googlesource.com/platform/external/perfetto.git/+log/f73d91573493..71a18f6f4b01

git log f73d91573493..71a18f6f4b01 --date=short --no-merges --format='%ad %ae %s'
2019-10-16 bhamrick@google.com Merge "trace_processor: Bounds checks for reading Fuchsia record data"
2019-10-16 treehugger-gerrit@google.com Merge "Reland "processor: Move TimestampedTracePiece into its own header""

Created with:
  gclient setdep -r src/third_party/perfetto@71a18f6f4b01

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=perfetto-bugs@google.com

Bug: None
Change-Id: I4a561bf2f3b74d9a451b178acc112876bf0b7337
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864817Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#706631}

This is a test for regression introduced by
https://chromium-review.googlesource.com/c/chromium/src/+/1856929

Change-Id: I833a24ceb7b316f432033f3bf721084a708dfd64
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863850
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Johannes Henkel <johannes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706630}

https://webrtc.googlesource.com/src.git/+log/64444bc865d2..562a37f926dd

git log 64444bc865d2..562a37f926dd --date=short --no-merges --format='%ad %ae %s'
2019-10-16 danilchap@webrtc.org Increase timeout in test-only helper SendTask back to infinity
2019-10-16 phoglund@webrtc.org Remove the fileutils hack for good.

Created with:
  gclient setdep -r src/third_party/webrtc@562a37f926dd

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=webrtc-chromium-sheriffs-robots@google.com

Bug: chromium:None
Change-Id: Ia0ee3c28f4bcfca84c687501e96c93eb0f7ac2e4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864818Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#706629}

Previously, the paused_ flag was used to signal that the animation was
in a paused state.  This flag is not part of the spec and is being
phased out.  Instead, we look for pending pause or play tasks and
whether there is a start time to determine if the animation is paused in
alignment with the spec.

Note that fixing play state calculation entailed fixing the handling of
setting a zero playback rate.  Previously, setting the playback rate to
zero would clear the start time; however, this has the unwanted side
effect of forced the animation into the paused state, which is not to
spec.  A running or finished animation should have a start time (if not
a pending change) even if the playback rate is zero.

https://drafts.csswg.org/web-animations/#play-states

Bug: 960944

Change-Id: I1fd43315d3b1c42b22302bf730c450a03836861a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862258
Commit-Queue: Kevin Ellis <kevers@chromium.org>
Reviewed-by: Majid Valipour <majidvp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706628}

We want to to allow relations such as labelled-by and described-by
to reference elements that are inert.

There seems to be precedent for a node having a child with a parent
other than itself (see ax_node_object.cc:2447). With this in mind,
when a node node is being cleared, it should only clear its child's
parent pointer if it points to itself(the parent currently
clearing its children).

Example:
node a: children = { b, c }, parent = null
node b: children = { c }, parent = a
node c: children = { g, h, i }, parent = a

In this case, node c is both a child of the a (the root) and b.
If we clear node b, we should not disconnect node c, from a.

The tree would look like this:
a
|____
|   |
b   c
    |________
    |   |   |
    g   h   i

Where node b would have indirect_children = {c}

Patchset 1 reverts the mitigation that was checked in here:
commit 5ef90f37
https://chromium-review.googlesource.com/c/chromium/src/+/1814460

Bug: 996992
Change-Id: I9b9cbc10aea473270178f15f283a1bacfa71b971
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838473
Commit-Queue: Jacques Newman <janewman@microsoft.com>
Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706627}

Screenshot: https://bugs.chromium.org/p/chromium/issues/detail?id=986998#c8

Bug: 986998
Change-Id: Ie9755d7820f8743a03ee6664e7bb70667e3bced9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865012
Commit-Queue: Kayce Basques <kayce@google.com>
Commit-Queue: Yang Guo <yangguo@chromium.org>
Auto-Submit: Kayce Basques <kayce@google.com>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706626}

This reverts commit 4ba7eb3a.

Reason for revert: spec revert for
  crbug.com/1014952
  crbug.com/1015014
  crbug.com/1015013
  crbug.com/1014951

Original change's description:
> Resubmit: Lower priority of processes hosting exclusively ads.
>
> This change adds a variable to ChildProcessPriorityLauncher to
> indicate whether the associated process is only used to run tasks for
> ad frames (low priority frames).  That variable is then used by the
> RenderProcessHost to background the frame in those cases.  Notification
> happens in the RenderProcessHost via new UpdateFrameWithPriority.
>
> Note: Identification of ad frames is done as per the AdTagging project.
> Frames that have been marked as ads remain ads, and thus the
> RenderProcessHost will remain low priority if the frame is navigated
> to any other non-ad URL within the same process (same domain).
>
> Currently this is behind a feature which is off by default.
> We will be experimenting with this to determine its impact on
> both ads and in the browser as a whole.
>
> TBR=dcheng@chromium.org,gab@chromium.org,pbos@chromium.org,jkarlin@chromium.org
>
> Bug: 979234
> Change-Id: I1acd1b8de7e66f8b2c47564df5e708f9b41f72a6
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855680
> Commit-Queue: Eric Robinson <ericrobinson@chromium.org>
> Reviewed-by: Alexander Timin <altimin@chromium.org>
> Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#706049}

TBR=alexmos@chromium.org,altimin@chromium.org,ericrobinson@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 979234,1014951,1014952,1015013,1015014
Change-Id: Ib719e3f70371b7941d0b27f9bc171594149dd24e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864618
Commit-Queue: John Budorick <jbudorick@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706625}

Cast may run two media services, one in browser process with CMA media
pipeline, the other in gpu process with GPU VDA:

1. Introduce a new media service "media_renderer", which is used and
implemented on Cast. It's the same media service as before, we only use
it to create media::Renderer and media::ContentDecryptionModule.

2. Change Cast's default media service host to "gpu", so that
DefaultRenderer could use MojoVideoDecoder for v4l2 decoder.

3. Cast runs "media_renderer" service in browser process, to replace the
old "media" service.

Merge-With: eureka-internal/316201
Bug: internal b/138261332
Test: YT, GPM
Change-Id: I08ea092b8b94115b3a7e642f8d188d67ef3884e3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815719
Commit-Queue: Yuchen Liu <yucliu@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Sean Topping <seantopping@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706624}

BUG=1009248

Change-Id: I0aca18b0a9cf6fc3dc72b4ec0cf1f33451279acf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863062Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Nancy Wang <nancylingwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706623}

Builds started failing because //base was only depended on
implicitly.

TBR=googleo

Change-Id: I1b020d169cf092cbd1e6050a9512a3c818c24bb1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865474Reviewed-by: Darren Shen <shend@chromium.org>
Reviewed-by: Jonathan Metzman <metzman@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Auto-Submit: Jonathan Metzman <metzman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706622}

So it won't lost connection due to timeout, but will still be closed if
the sender side crashes or send invalid message.

Meanwhile, fix a bug in the unittests that causes socket not destroyed
on the sequence by specifically calling Stop.

Bug: internal: 142752569
Bug: internal: 142443304
Test: On device and unittests.
Change-Id: I9a75d9727cf7abb3f0acc146b1028edfb3afb45a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865532Reviewed-by: Kenneth MacKay <kmackay@chromium.org>
Reviewed-by: Yuchen Liu <yucliu@chromium.org>
Commit-Queue: Kehuang Li <kehuangli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706621}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e5cc32d92cbf..15bcceb9eaa2


Created with:
  gclient setdep -r src-internal@15bcceb9eaa2

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=jbudorick@google.com

Bug: chromium:None,chromium:None,chromium:None
Change-Id: I1da4f885425a0e9c6dc0c16ec7b09afa3486f0c0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864813Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#706620}

Adds a small fuzzer for AutocompleteInput, an input classifier
and state structure.

Change-Id: Ib73721b44a9ef6ca15e978fcea210e56fd40be30
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862346
Commit-Queue: Kevin Bailey <krb@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Reviewed-by: Max Moroz <mmoroz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706619}

Replace NOTIFICATION_PROFILE_CREATED/DESTROYED with ProfileObserver.

Bug: 268984
Change-Id: I77921a45a79d8bdee9e3a6fc786b5ac6e8c9ee38
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852412
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706618}

This allows BaseSuggestionViewProcessor to create refine icon on behalf of
the actual view processor.

Bug: 982818
Change-Id: I4424ec9d2e5d1f2fd25f1bc3ce0795076d998852
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856901
Commit-Queue: Ender <ender@google.com>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Patrick Noland <pnoland@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706617}

This reverts commit 315b3895.

Reason for revert: new tests fail on linux-chromeos-rel: https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-rel/30281

Original change's description:
> In tablet mode, tap on overview background should go to home screen.
> 
> Clamshell mode behavior will remain the same, i.e., tapping on the
> overview background will return to its previous state, it can either be
> in-app or home screen.
> 
> Bug: 997885
> Change-Id: I82624e44024e273a343c20e3707cb1d97e31d594
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864026
> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
> Commit-Queue: Xiaoqian Dai <xdai@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#706548}

TBR=xiyuan@chromium.org,xdai@chromium.org

Change-Id: I6a9b5666e168dab72d4192036c44d093388c4225
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 997885
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865556Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706616}

Shill is not providing a type for VPN IP Configs so we need to set it
to IPv4 so that OncMojo.getIPConfigForType() finds it correctly.

Bug: 1011557
Change-Id: I13431e0c1a352cf2456832fa97ad0d088c61667b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865470Reviewed-by: Toni Baržić <tbarzic@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706615}

The whole point of srcjar_deps is that the path to the .srcjar doesn't
need to be known by the caller :P.

No behavior change.

Change-Id: If5f0e7649605d979081152478ca6c76c42e9ed8c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856821
Auto-Submit: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706614}

This will allow NVDA and JAWS to enter app mode automatically.

Bug: 867081
Change-Id: Ib7bc6a417d452a7e63f8a9b644713a5570d37a69
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855179Reviewed-by: Dan Beam <dbeam@chromium.org>
Reviewed-by: Cait Phillips <caitkp@chromium.org>
Commit-Queue: Hector Carmona <hcarmona@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706613}

Without this, removing an animated view from a widget would stall the animation;
this could leave its state incorrect, e.g. if it was later re-added.  This can
affect the omnibox with an upcoming patch I'm writing.

This was introduced by http://crrev.com/657587 ; before that, AnimationRunner
did not exist, and removing a view from a widget would have no effect on
animations.

Bug: none
Change-Id: Iae457306a3a3f68e42772009a24d34dd65d4a144
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857191
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706612}

Bug: 1010919

Change-Id: I08894264b7e219178602d3ea1d2ee00fb851381f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854528
Commit-Queue: Yulun Wu <yulunwu@chromium.org>
Auto-Submit: Yulun Wu <yulunwu@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: Toni Baržić <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706611}

We've seen unusual statistics when we try to implicitly rely on the lack
of an AudioCodec and VideoCodec to imply HLS support. So instead
explicitly signal when we're using the MediaPlayerRenderer.

This merely helps us differentiate watch time from MediaPlayer, it does
not track HLS watch time directly.

TEST=play hls, observe MediaPlayer in UKM fields.
R=sandersd

Change-Id: I7167504436af62a54eb4ebb20a02732e1f65a5d4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863858
Auto-Submit: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706610}

The policy was previously named TabLifecyclesEnabled and its
name/description said that it controlled throttling, freezing and
proactive discarding. It actually never controlled throttling and we
decided to abandon the proactive discarding feature.

Therefore, the name and description are changed to indicate that it
controls tab freezing only. Also, the "future" tag is removed since
we plan to ship tab freezing in M79.

Bug: 844426
Change-Id: I6fdab954aa9d1c9fb5a63217ccda7b869726fc93
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863382
Commit-Queue: François Doray <fdoray@chromium.org>
Reviewed-by: Owen Min <zmin@chromium.org>
Reviewed-by: Sébastien Marchand <sebmarchand@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706609}

* Tint the toolbar menu button properly.
* When rotation happens, update the position of selection editor
  PopupWindow instead of re-showing it.
* Calculate the dialog position instead of using getGlobalVisibleRect
  which doesn't deterministically happen early enough when rotating.
* Pull out positioning-related logics from TabSelectionEditorLayout
  to TabSelectionEditorMediator and add tests.

Bug: 1011269, 1011271
Change-Id: Iff3b5d993030f7798981b5ff5d945b28a2655188
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846246
Commit-Queue: Yue Zhang <yuezhanggg@chromium.org>
Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Reviewed-by: Mei Liang <meiliang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706608}

https://screenshot.googleplex.com/T546MRqLTua

Bug: 1010764
Change-Id: I2ab54c4a8c36980fb8f5307714b274b5284cb8ea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863638Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Reviewed-by: Daniel Rubery <drubery@chromium.org>
Commit-Queue: Bettina Dea <bdea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706607}

 - Increased the threshold to make it easier for users to
   drag the launcher from closed state to peeking state, so it's
   more tolerant in distinguishing between the intentions of the
   users.
 - Reduced the lower limit for the snapping thresholds for dragging
   the app list from shelf, so now peeking mode is set at a lower
   height.
 - Changed the downfling default resulting state to be peeking
   instead of closed, so that if the user end the drag with a
   downfling unintentionally, the launcher doesn't closes.

Bug: 956173
Change-Id: I2cf8373b292518c8e1eaa3f9ee77b36db956f294
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860109
Commit-Queue: Ana Salazar <anasalazar@chromium.org>
Reviewed-by: Manu Cornet <manucornet@chromium.org>
Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706606}

https://chromium.googlesource.com/catapult.git/+log/fc9cfb00f341..c9f13b8d903d

git log fc9cfb00f341..c9f13b8d903d --date=short --no-merges --format='%ad %ae %s'
2019-10-16 bpastene@chromium.org telemetry: Disable TestBrowserCreation.testCreateBrowserTwice on Chrome OS.

Created with:
  gclient setdep -r src/third_party/catapult@c9f13b8d903d

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/catapult-autoroll
Please CC oysteine@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=oysteine@google.com

Bug: chromium:1014115
Change-Id: I44a8efdf81c55bcc76237b50bc56793adc7c7a14
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864814Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#706605}

This change builds off of
https://chromium-review.googlesource.com/c/chromium/src/+/1729554
to allow the context menu key press inside a datagrid to add an
'Edit "<colName>" option that starts at
the first editable column instead of the center column
that is shown when using the mouse to right click on a dataGrid cell.
This fixes the issue where the editing context menu would always show
"Edit <middle Column>" due to how the event would assume the target
is the visible center of the datagrid.

Before: https://imgur.com/QE7VAKf

After: https://imgur.com/a/iiKI2dk

Bug: 963183
Change-Id: I20468e895a5df0cba368ad7ff954e34de17ac0e3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752769
Commit-Queue: Brandon Goddard <brgoddar@microsoft.com>
Reviewed-by: Lorne Mitchell <lomitch@microsoft.com>
Reviewed-by: Jeff Fisher <jeffish@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#706604}

This change adds 2 context menu entries for the IndexedDB datagrid
to allow for expanding and collapsing the value objects from the keyboard.

Note: This change does not currently work with the contextMenuKey
due to an existing issue where contextMenuKey on
the data grid will not target the selected
node, but on whichever row happens to be in the center
of the currently visible section of data grid. This issue will be
resolved with this change:
https://chromium-review.googlesource.com/c/chromium/src/+/1729554


Before: https://imgur.com/8Iz96jv

After: https://imgur.com/UwSUVOh

Bug: 963183
Change-Id: Iefb563dc744b524d3282b62141a9da12230e9911
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725990Reviewed-by: Lorne Mitchell <lomitch@microsoft.com>
Commit-Queue: Brandon Goddard <brgoddar@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#706603}

This reverts commit 63bc6538.

Reason for revert: Still breaks UDPSocketTest.
See https://bugs.chromium.org/p/chromium/issues/detail?id=1014916 for context.

Original change's description:
> Roll Fuchsia SDK from 889950275648 to 889942972119
> 
> If this roll has caused a breakage, revert this CL and stop the roller
> using the controls here:
> https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll
> Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human
> is aware of the problem.
> 
> To report a problem with the AutoRoller itself, please file a bug:
> https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
> 
> Documentation for the AutoRoller is here:
> https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
> 
> CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
> TBR=cr-fuchsia+bot@chromium.org
> 
> Change-Id: Id87590c9ae2e3dddf858cfb5886ce359245409a6
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865033
> Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
> Cr-Commit-Position: refs/heads/master@{#706544}

TBR=chromium-autoroll@skia-public.iam.gserviceaccount.com,cr-fuchsia+bot@chromium.org

Change-Id: Iac0b3d0ceabe372b443d8a1897726073243051f7
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865544Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706602}

Currently, the MediaNotificationView uses insets for the artwork based
on the message center width. This works for ChromeOS (which uses
message center to show the MediaNotificationView), but not for the
Global Media Controls, which uses its own width. This CL fixes this
issue by letting users of MediaNotificationView specify the width of
the notification.

Bug: 1011178
Change-Id: I267266a154b0bbd4e78ec4fec52734d32c2c9ebf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864417
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706601}

This change adds a context menu entry for the links that appear
in the 'Functions' column in Heavy (bottom-up) and Top Down views in
the Memory Allocation Sample and Javascript CPU Profiler tools.

This allows the keyboard users to access these links with the context
menu key.

Note that this change is dependent on
https://chromium-review.googlesource.com/c/chromium/src/+/1729554
for the context menu key in the DataGrid to target the
currently selected node.

Before: https://imgur.com/ErkPbIc

After: https://imgur.com/a3R3rDB
Bug: 963183
Change-Id: I3d5068b0efff0c31a46aeb6ee11ff5feb85bc58b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832479Reviewed-by: Lorne Mitchell <lomitch@microsoft.com>
Commit-Queue: Brandon Goddard <brgoddar@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#706600}

This change removes custom Refinable icon from AnswerSuggestions
in favor of base suggestion view.

Change-Id: If460ec749cfd3786388b0423da2f61c805ec0c6f
Doc: http://doc/1aL_UcW1gdeSLqNzuJZlQPBqMG0XAwVaoa05UTyVulp8
Bug: 982818
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848391
Commit-Queue: Ender <ender@google.com>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Brandon Wylie <wylieb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706599}

While out-of-range tags are already rejected, tags which don't make sense for
one or the other aren't currently handled gracefully. Instead of using the default
case, we should explicitly deal with each enumerator.

Bug: 1012581
Change-Id: I3aebb0a42bca66670ad6db65e514f74a6bd32530
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865609
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Auto-Submit: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706598}

Moves resources used in chrome://sync-internals out of
components_resources.grd into its own GRD file. Also move these
resources into the Dev UI Dynamic Feature Module (DFM) to save binary
size on Chrome for Android.

Update iOS dependency to include the new resource target.

Original reason for revert: https://crbug.com/1013522

Relanding because a separate infrastructure issue was fixed:
https://crrev.com/c/1864411

Tbr: huangs@chromium.org,dbeam@chromium.org,blundell@chromium.org,treib@chromium.org
Bug: 927131, 1013522
Change-Id: I00f86462db5ac3cb397ee98e2e25bae41e69bbda
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864564Reviewed-by: Samuel Huang <huangs@chromium.org>
Reviewed-by: Peter Wen <wnwen@chromium.org>
Commit-Queue: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706597}

This CL removes a thread check in
WebDocumentSubresourceFilterImpl::BuilderImpl::Build() that is called during
WorkerFetchContext creation.

When the check was added, Build() was supposed to be called from the worker
thread. However, PaintWorklet, which is a kind of workers but runs on the main
thread, was implemented and broke the assumption. It should be safe to run it on
the main thread, so this CL removes the check.

This CL also adds tests for subresource filter for worklets to check the change.

Bug: 887269, 1011208
Change-Id: Ieaa0ed4adb80523ec72af5916781c8593de28c85
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1242730Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706596}

* The interpolation factor is constant so it can be lifted out of the
  loop.
* Computation of the read_position only needs to be done once, and
  read_index1 can just be incremented in the loop
* Cache write_index_ into a local
* Change some doubles to floats

Using spotify.github.io/web-audio-bench, without this CL we have:

TEST	                μs	MIN	Q1	MEDIAN	Q3	MAX
Baseline		397	390	397	397	397	407
Delay-default		943	882	935	943	953	980
Delay-0.1		930	913	913	930	957	967
DelayAutomation-a-rate	1007	988	993	1007	1025	1032
DelayAutomation-k-rate	925	912	918	925	962	973

With thie CL:

Baseline		393	323	383	393	393	400
Delay-default		213	210	212	213	253	278
Delay-0.1		235	232	233	235	283	343
DelayAutomation-a-rate	1043	1038	1040	1043	1043	1053
DelayAutomation-k-rate	245	238	243	245	285	313

The optimized version takes about 1/4 the time now.

Bug: 1012198
Change-Id: I0de8f0980e9006241293dc97682d812af485bba1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1861036Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Reviewed-by: Andrew MacPherson <andrew.macpherson@soundtrap.com>
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706595}

Bug: 790372
Change-Id: I27a30346a8a94feb6d92f35b97bbdd63d3a03eba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865591
Auto-Submit: Garrett Beaty <gbeaty@chromium.org>
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706594}

Annotate fields and methods that require synchronization with @GuardedBy

Change-Id: I6f8fc772de470783459d458e5906e6ac18e48dd2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863852Reviewed-by: Ender <ender@google.com>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Ender <ender@google.com>
Commit-Queue: bttk <bttk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706593}

Because there are no ways to check console warnings from JavaScript.

Bug: 990561
Change-Id: I5f3827c4383e35c74521148aa2e3b912b52a5f13
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1843507
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Domenic Denicola <domenic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706592}