GitLab

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/e942bee..0278197

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=joshualitt@google.com

Commits in this roll:
0278197 jvanverth@google.com Run noise shader separately in imagefiltersclipped
374b2f7 joshualitt@chromium.org rename BitmapTextBlob and move it to its own file
4ec1ac6 caryclark@google.com make xfermode* portable
9b8d358 borenet@google.com Skip imagefiltersclipped GM on Galaxy S4

Review URL: https://codereview.chromium.org/1238293003

Cr-Commit-Position: refs/heads/master@{#339674}

[ This is the password_manager equivalent of https://crrev.com/d8ec87b3f93ecf173005fd6020e3f8d3774af128 ]

BUG=None

Review URL: https://codereview.chromium.org/1248473002

Cr-Commit-Position: refs/heads/master@{#339673}

This reverts my previous change (https://codereview.chromium.org/1232703006),
which fixed the double character insertion in the mandoline omnibox, but
broke all text entry in the html_viewer. The correct change was to make
sure we're using an InputMethodMandoline.

In https://codereview.chromium.org/1155013005/, InputMethodMandoline
appears to have been removed by accident while removing
InputMethodEventFilter. However, at least on Linux, we need to *not* use
InputMethodAuraLinux, which operates on a stream of X11 events, instead
of a stream of events that is designed to look like Windows events on
all platforms.

We don't see these problems on Windows because InputMethodWin is already
expecting a stream of events that looks like what Windows natively sends.

BUG=none

Review URL: https://codereview.chromium.org/1234623004

Cr-Commit-Position: refs/heads/master@{#339672}

Review URL: https://codereview.chromium.org/1238043005

Cr-Commit-Position: refs/heads/master@{#339671}

Add a test to make sure we do not crash and bookmarks are
restored to the proper subfolder when undoing the removal of a
folder with multiple subfolders.

BUG=474123

Review URL: https://codereview.chromium.org/1229063002

Cr-Commit-Position: refs/heads/master@{#339670}

This reverts https://codereview.chromium.org/1240893004/ , it broke
building remoting in the gyp build (see comment on the review).

TBR=brettw@chromium.org

Review URL: https://codereview.chromium.org/1249723002.

Cr-Commit-Position: refs/heads/master@{#339669}

Revert of Fix ProcessUtilTest.GetTerminationStatusCrash on Android L+ (patchset #2 id:20001 of https://codereview.chromium.org/1241333002/)

Reason for revert:
This patch broke the mips builder for Android

../../third_party/lss/linux_syscall_support.h:121:21: fatal error: sgidefs.h: No
such file or directory
 #include <sgidefs.h>

Original issue's description:
> Fix ProcessUtilTest.GetTerminationStatusCrash on Android L+
>
> On Android L+, signal and sigaction symbols are provided by libsigchain
> that override the system's versions. There is a bug in these functions
> where they essentially ignore requests to install SIG_DFL. This causes
> ProcessUtilTest.GetTerminationStatusCrash to fail (as
> CrashingChildProcess goes into infinite loop instead of crashing).
>
> Workaround this issue by explicitly performing a syscall to
> __NR_rt_sigaction to install SIG_DFL on Android, as breakpad does
> (see https://breakpad.appspot.com/1804002/).
>
> BUG=512255
> TEST=ProcessUtilTest.GetTerminationStatusCrash
>
> Committed: https://crrev.com/31510fe3e2d3b1f3123f391db52372b2506c46ca
> Cr-Commit-Position: refs/heads/master@{#339584}

TBR=thakis@chromium.org,primiano@chromium.org,cullinan@amazon.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=512255

Review URL: https://codereview.chromium.org/1247023002

Cr-Commit-Position: refs/heads/master@{#339668}

This CL parses the report-uri attribute on HPKP headers and stores them
in TransportSecurityPersister.

This is CL #1.
CL #2: crrev.com/1212973002 (add net::CertificateReportSender)
CL #3: crrev.com/1212613004 (add net::TransportSecurityReporter)
CL #4: crrev.com/1213783005 (send HPKP reports)

BUG=445793

Review URL: https://codereview.chromium.org/1211363005

Cr-Commit-Position: refs/heads/master@{#339667}

Reland of NaCl cleanup: Split out irt_interfaces.cc from irt_ppapi.cc (patchset #1 id:1 of https://codereview.chromium.org/1249473003/)

Reason for reland:
The size increase was caused by a Skia DEPS roll (https://codereview.chromium.org/1245793002/), not by this change.

Original issue's description:
> Revert of NaCl cleanup: Split out irt_interfaces.cc from irt_ppapi.cc (patchset #1 id:1 of https://codereview.chromium.org/1244533006/)
>
> Reason for revert:
> Regressed Linux sizes - 4.5% is a bit of a hit to take to bump sizes. If you're absolutely sure this is acceptable, update sizes as well.
>
> Original issue's description:
> > NaCl cleanup: Split out irt_interfaces.cc from irt_ppapi.cc
> >
> > The intention here is that irt_interfaces.{cc,h} should list the NaCl
> > IRT interfaces that we implement in Chromium but that other files
> > (like irt_ppapi.cc) should implement them.  This matches how the files
> > are organised in native_client/src/untrusted/irt/.
> >
> > This is in preparation for copying the PNaCl translator IRT interfaces
> > to the Chromium side.  That will add a couple more interfaces to
> > irt_interfaces.cc (rather than to irt_ppapi.cc).
> >
> > BUG=302078
> > TEST=NaCl tests in browser_tests
> >
> > Committed: https://crrev.com/5e662010c1f7881970de6de19bcbd50f2726ea00
> > Cr-Commit-Position: refs/heads/master@{#339508}
>
> TBR=jvoung@chromium.org,bbudge@chromium.org,mseaborn@chromium.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=302078
>
> Committed: https://crrev.com/db9f0a6b277a39d2f2b70d99e17801a18a6d79a6
> Cr-Commit-Position: refs/heads/master@{#339559}

BUG=302078
TBR=jvoung@chromium.org

Review URL: https://codereview.chromium.org/1245893002

Cr-Commit-Position: refs/heads/master@{#339666}

https://chromium.googlesource.com/external/trace-viewer.git/+log/4f30209abd53c699c937519f39ce41888f93507b..800a465d254e442aec32ab581b032a60a1f068fe

TBR=dsinclair

Review URL: https://codereview.chromium.org/1242733004

Cr-Commit-Position: refs/heads/master@{#339665}

It appears to have no usage or tests.

Review URL: https://codereview.chromium.org/1244013002

Cr-Commit-Position: refs/heads/master@{#339664}

Adds manifest data for content shell. The result matches the GYP build.

Attaches a default manifest to all tests in the GN build. The GYP build's tests have manifests that specify elevation only. In GN it also specifies Windows and common control compat that matches what we ship with Chrome.

Moved the common control compat files that were duplicated to a shared place in build/win, update cloud_print and remoting which had their own copies to use this shared one.

BUG=510612

Review URL: https://codereview.chromium.org/1240893004

Cr-Commit-Position: refs/heads/master@{#339663}

BUG=444764

Review URL: https://codereview.chromium.org/873313006

Cr-Commit-Position: refs/heads/master@{#339662}

s/BASE_PREFS/URL_MATCHER

BUG=None
R=battre@chromium.org

Review URL: https://codereview.chromium.org/1245923003

Cr-Commit-Position: refs/heads/master@{#339661}

Review URL: https://codereview.chromium.org/1245193003

Cr-Commit-Position: refs/heads/master@{#339660}

+ It is now consistent with newer versions of OS X.
  - the copy is Look Up “Foo” instead of Look Up In Dictionary.
  - It will not display when right clicking a link.
  - The item now appears first in the context menu.
BUG=
TEST=Right click a word on a web page, and see that it says "Look Up “<WORD>”

Review URL: https://codereview.chromium.org/1244723003

Cr-Commit-Position: refs/heads/master@{#339659}

This patch improves the way that GuestViewManager tracks the destruction of GuestView embedders. A RenderProcessHostObserver is now used instead of a WebContentsObserver.

There were two main problems with the existing method that are now fixed:
1) The WebContentsObserver would only notify if an embedder crashed, and did nothingwhen it closed normally. (this led to the WebView in the chrome sign-in page not getting cleaned up properly when navigating away from that page)
2) The WebContentsObserver was created in GuestViewBase, so it would not even exist if a GuestView's embedder crashed before its GuestViewBase instance was created.

BUG=355360

Review URL: https://codereview.chromium.org/1232603002

Cr-Commit-Position: refs/heads/master@{#339658}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/1340039..e942bee

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=joshualitt@google.com

Commits in this roll:
e942bee mtklein@google.com Revert of 565 support for SIMD xfermodes (patchset #3 id:40001 of https://codereview.chromium.org/1245673002/)

Committed: https://crrev.com/e7d090a0a3187d21532d343331217b8518d0a75e
Cr-Commit-Position: refs/heads/master@{#339646}

Review URL: https://codereview.chromium.org/1246943003

Cr-Commit-Position: refs/heads/master@{#339657}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/991dee4..c7d4690

TBR=gavinp@chromium.org,yhirano@chromium.org

Review URL: https://codereview.chromium.org/1245963002

Cr-Commit-Position: refs/heads/master@{#339656}

I'm moving to a new project.

BUG=none
TEST=none

Review URL: https://codereview.chromium.org/1250453002

Cr-Commit-Position: refs/heads/master@{#339655}

Now that tasks posted to the message loop are routed through the
scheduler, there's no need for the scheduler to listen for task observer
notifications from the message loop or coalesce them into a mostly
consistent stream of notifications to downstream observers.

BUG=444764

Review URL: https://codereview.chromium.org/1250613002

Cr-Commit-Position: refs/heads/master@{#339654}

Changes of include paths under chrome/browser/chromeos/extensions
are purely mechanical and therefore I am using tbr for them.
TBR=kalman@chromium.org

BUG=257943, 498951

Review URL: https://codereview.chromium.org/1243853002

Cr-Commit-Position: refs/heads/master@{#339653}

Remove this flag, since the Blink-side update for this has
landed and rolled into Chrome.

R=chrishtr
BUG=skia:4089

Review URL: https://codereview.chromium.org/1246803003

Cr-Commit-Position: refs/heads/master@{#339652}

that indicates the extension has local changes that still need to be synced.
It's set when something changes before sync is ready, and cleared once the extension state has been synced.

This should handle all conflicts between sync and local state reasonably well, and as a bonus allows us to get rid of the (weird and not-really-working) PendingEnables class.

BUG=509990

Review URL: https://codereview.chromium.org/1240573012

Cr-Commit-Position: refs/heads/master@{#339651}

The ripple effect is behind the 'top-chrome-md' experimental switch.

BUG=505587

Review URL: https://codereview.chromium.org/1242573005

Cr-Commit-Position: refs/heads/master@{#339650}

Revert of Roll src/third_party/skia 1340039:e942bee (patchset #1 id:1 of https://codereview.chromium.org/1246943003/)

Reason for revert:
Still hit sizes check (nacl_helper-text) with same increase, reverting CL.

Original issue's description:
> Roll src/third_party/skia 1340039:e942bee
>
> Summary of changes available at:
> https://chromium.googlesource.com/skia/+log/1340039..e942bee
>
> CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
> TBR=joshualitt@google.com
>
> Commits in this roll:
> e942bee mtklein@google.com Revert of 565 support for SIMD xfermodes (patchset #3 id:40001 of https://codereview.chromium.org/1245673002/)
>
> Committed: https://crrev.com/e7d090a0a3187d21532d343331217b8518d0a75e
> Cr-Commit-Position: refs/heads/master@{#339646}

TBR=joshualitt@google.com,skia-deps-roller@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/1243073003

Cr-Commit-Position: refs/heads/master@{#339649}

As part of the plan to rationalize Origins across Blink and its embedder,
we're dropping 'blink::WebSerializedOrigin' in favor of
'blink::WebSecurityOrigin' (which can serialize itself just fine).

Patch 1 (Chromium): https://codereview.chromium.org/1244563002
Patch 2 (Blink): https://codereview.chromium.org/1240083002
Patch 3 (Blink): https://codereview.chromium.org/1244703002
Patch 4 (Chromium): https://codereview.chromium.org/1229783005
Patch 5 (Chromium): https://codereview.chromium.org/1247723004/
Patch 6 (Blink): https://codereview.chromium.org/1231643010
Patch 7 (Chromium): This patch.

BUG=508896
R=jochen@chromium.org

Review URL: https://codereview.chromium.org/1246943002

Cr-Commit-Position: refs/heads/master@{#339648}

Before making app & devtools windows visible through chrome.windows.*
we want to make sure the tab id of the devtools is stripped from the
tab object returned to javascript so devtools cannot be manipulated
through the chrome.tabs.* API.

BUG=394341

Review URL: https://codereview.chromium.org/1239643004

Cr-Commit-Position: refs/heads/master@{#339647}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/1340039..e942bee

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=joshualitt@google.com

Commits in this roll:
e942bee mtklein@google.com Revert of 565 support for SIMD xfermodes (patchset #3 id:40001 of https://codereview.chromium.org/1245673002/)

Review URL: https://codereview.chromium.org/1246943003

Cr-Commit-Position: refs/heads/master@{#339646}

Revert of relnote: Protect against a QUIC crash bug but logging a DFATAL and (patchset #1 id:1 of https://codereview.chromium.org/1246793002/)

Reason for revert:
The test added in this patch is crashing on Chrome OS.

See crbug.com/512417

Original issue's description:
> relnote: Protect against a QUIC crash bug but logging a DFATAL and
> closing the connection instead when a packet cannot be serialized.
>
> This could help fixing Chromium BUG=479880.
>
> Merge internal change: 98506577
>
> R=rch@chromium.org
>
> Committed: https://crrev.com/0a2dccc01366309f1e55a9b86141137bb649c631
> Cr-Commit-Position: refs/heads/master@{#339532}

TBR=rch@chromium.org,rtenneti@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/1248683002

Cr-Commit-Position: refs/heads/master@{#339645}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/b1769c0..991dee4

TBR=gavinp@chromium.org,yhirano@chromium.org

Review URL: https://codereview.chromium.org/1251453002

Cr-Commit-Position: refs/heads/master@{#339644}

     rlz::RLZTracker::GetAccessPointRLZ(rlz::RLZTracker::ChromeOmnibox(),
     ~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~
                      GetAccessPointRlz

BUG=511570

Review URL: https://codereview.chromium.org/1249643002

Cr-Commit-Position: refs/heads/master@{#339643}

This flag causes the CFI instrumentation to print an error message to
stderr when a check fails, rather than terminating the process.

BUG=457523
R=thakis@chromium.org

Review URL: https://codereview.chromium.org/1231793002

Cr-Commit-Position: refs/heads/master@{#339642}

Revert of Base: Make TimeDelta constructors deal with overflow. (patchset #2 id:20001 of https://codereview.chromium.org/1229853004/)

Reason for revert:
Reverting CL: it seems to cause regression in number of static initializers.
For details see https://code.google.com/p/chromium/issues/detail?id=512348

Original issue's description:
> Base: Make TimeDelta constructors deal with overflow.
>
> BUG=466445
>
> Committed: https://crrev.com/15462e858ebf34721e28a023b0b670c2011183ac
> Cr-Commit-Position: refs/heads/master@{#339605}

TBR=thakis@chromium.org,rvargas@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=466445

Review URL: https://codereview.chromium.org/1250453004

Cr-Commit-Position: refs/heads/master@{#339641}

RLZTrackerDelegate implementation on iOS need to listen to events from
any OmniboxEditModel (all other clients of the same events on iOS also
do not care about which OmniboxEditModel sends them).

Introduce OmniboxEditModelObserverRelay to allow N:M forwarding. This
class will be informed of events sent by all OmniboxEditModel and will
forward them to all interested observers.

BUG=511570,371536

Review URL: https://codereview.chromium.org/1245683002

Cr-Commit-Position: refs/heads/master@{#339640}

Add new class ManagedBookmarkService into //components/bookmarks/managed
responsible for managed and supervised bookmarks creation and policy
enforcement.

BookmarkClient delegates policy decisions to ManagedBookmarkService (and
use sane default if there is no ManagedBookmarkService instance). Remove
all direct access to ChromeBookmarkClient and instead direct queries to
ManagedBookmarkService.

Move prefs registration to a static method of BookmarkModel so that iOS
can reuse it.

BUG=383583,359565

Review URL: https://codereview.chromium.org/1233673002

Cr-Commit-Position: refs/heads/master@{#339639}

Add explicit comment describing why the linker JNI code still uses
GetStringUTFChars() and cannot use ConvertJavaStringToUTF8().

BUG=508876

Review URL: https://codereview.chromium.org/1246633002

Cr-Commit-Position: refs/heads/master@{#339638}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/a6ae14e..1340039

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=joshualitt@google.com

Commits in this roll:
1340039 rileya@chromium.org Add Rec709 YUV color space support to GrYUVtoRGBEffect.
6531c36 caryclark@google.com Generate platform specific fontmgr gm.
973ae86 emmaleer@google.com removing png_read_end from SkPngScanlineDecoder
85693c1 caryclark@google.com make stroketext textblob* texteffects tileimagefilter gm portable
942930d mtklein@chromium.org 565 support for SIMD xfermodes
1accc4c robertphillips@google.com Fix textureDomain/bleed prevention in msaa

Review URL: https://codereview.chromium.org/1245123002

Cr-Commit-Position: refs/heads/master@{#339637}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/0232b3b..b1769c0

TBR=gavinp@chromium.org,yhirano@chromium.org

Review URL: https://codereview.chromium.org/1250563002

Cr-Commit-Position: refs/heads/master@{#339636}

This results in incorrect context menu positioning in pdf in webview or
  webview inside appview.

If a guest A is nested within an embedder B, which in turn is nested inside
  an embedder C, then we used to add offset twice to calculate the bounds of A
  because BrowserPluginGuest::GetScreenCoordinates would add:
    1. offset of C from A and
    2. offset of B from A.
This CL removes step #2.
From logs, it seems to be there from the beginning of appview implementation.

BUG=507223
Test=Load a PDF inside <webview> and check context menu inside the PDF.
Easier to test with the browser sample:
https://github.com/GoogleChrome/chrome-app-samples/tree/master/samples/webview-samples/browser
You should observe the context menu is shown in the right place instead of
it being shifted.

Review URL: https://codereview.chromium.org/1237343002

Cr-Commit-Position: refs/heads/master@{#339635}