- 13 Jun, 2018 40 commits
-
-
Nicholas Verne authored
This relands commit 9ec0dfc9. In viz_browser_tests and mash_browser_tests it is possible for RunLoop::RunUntilIdle to return in a test while there are still pending tasks (on another task runner). We delay the test's continuation until the appropriate condition on FakeConciergeClient is satisfied. Bug: 851253 Change-Id: Iab1ade58607efae9ca7666666e0f77210d5973c1 Reviewed-on: https://chromium-review.googlesource.com/1096587Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Timothy Loh <timloh@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Commit-Queue: Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#566757}
-
Dominic Battre authored
This CL disables password requirements fetching from gstatic unless the user syncs browsing history without a custom passphrase. NOTRY=true Bug: 846694 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: If500c349d4fcbc94c3fe8b6c74aec1f9a2403420 Reviewed-on: https://chromium-review.googlesource.com/1097411 Commit-Queue: Dominic Battré <battre@chromium.org> Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#566756}
-
DongJun Kim authored
Chromium build with GCC, it had -Wmisleading-indentation warning in ax_menu_list_popup.cc after commit [1]. It looks unintended and we adds missing braces from previous patch-set. Also this patch includes clean-up as removing redundant function calls. [1] https://chromium-review.googlesource.com/c/chromium/src/+/769674 Bug: 849614 Change-Id: I45051847e116bc055dd8ba954bd9a0730d7188df Reviewed-on: https://chromium-review.googlesource.com/1090698 Commit-Queue: DongJun Kim <djmix.kim@samsung.com> Reviewed-by:
Katie Dektar <katie@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#566755}
-
Yuki Shiino authored
As a preparation to move ExceptionState into platform/, moves ExceptionMessages into platform/. This should be the last dependency of ExceptionState to core/. NOPRESUBMIT=true Bug: 849607 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_slimming_paint_v2;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I3d66e9ee6cce7ff2df138e2ab975b7fad3f733d3 Reviewed-on: https://chromium-review.googlesource.com/1097236 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#566754}
-
Dominic Battre authored
This CL introduces two features that are purely meant as kill switches until the feature have proven stable: - PasswordGenerationRequirements controlls whether Chrome attempts to generate passwords that meet the requirements of a website. If enabled, Chrome will use the requirements from Autofill server responses to generate passwords. - PasswordGenerationRequirementsDomainOverrides builds on top of that. If set an extra request will be sent to gstatic.com to fetch requirements for the main frame domain for which the password will be generated. These are separated into different features for to allow for disabling only the second part in case it should turn out to create problems (not expected). On top of that, three field trial parameters are defined: - PasswordGenerationRequirements/version - PasswordGenerationRequirements/prefix_length - PasswordGenerationRequirements/timeout The first two parameters control the file name that will be downloaded from gstatic. These are meant to stay in Chrome unless we decide to kill the service. They are used to scale the service: If few overrides are necessary, they all fit into one file that can be downloaded on demand. If more overrides become necessary, we may want to split that into multiple files. The prefix_length indicates the hash prefix lengh used for sharding data into files. The version parameter allows two things: 1) gradual rollouts to a new version while measuring that nothing breaks. 2) ensuring an atomic switch to a new prefix_length (e.g. version 1 might have a prefix length of 0, version 2 might have a prefix length of 4 -> the version parameter ensures that files are fetched from a directory that contains prefixes of the corresponding length). The purpose of the timeout parameter is to see whether a 5 second timeout works. We may remove that parameter if it turns out to be non-necessary. But we may also increase it from the server if necessary. Bug: 846694 Change-Id: I451b45b04eecfac609cb2400bb5281839578c628 Reviewed-on: https://chromium-review.googlesource.com/1097317 Commit-Queue: Dominic Battré <battre@chromium.org> Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Reviewed-by:
-
Alexandre Courbot authored
DMA-BUF support in VideoFrame was suffering from several issues: * The number of DMA-BUF FDs provided to back a frame was assumed to be equal to the number of planes of the format of the frame. This is not always correct, since several planes can be backed by the same buffer, * FDs were always duplicated when creating a new VideoFrame - there was no option to make it take ownership of the passed FDs. * The class' public interface was taking FDs as ints instead of the more secure ScopedFD. This patch fixes these issues by doing the following: * Make VideoFrame::WrapExternalDmabufs() take a vector of ScopedFDs instead of a vector of integers, make it take ownership of the passed FDs, and make it accept a smaller number of FDs than there are planes in the frame's format, * Turn VideoFrame::DmabufFd() into VideoFrame::DmabufFds(), which returns all the FDs associated to a frame. * Introduce the media::DuplicateFDs() function which can be used by callers to explicitly duplicate a vector of FDs (a rather common thing to do). * Update users of VideoFrame::WrapExternalDmabufs() (concentrated in media/gpu/v4l2) to make use of this updated interface. BUG=850375 BUG=b:73752373 TEST=Tested VDA unittest and video playback on Hana (decoder + IP), and VEA unittest and resulting video playback on pit (IP + encoder). Change-Id: I9318fb3be82e3ff50c13c17dfd5faf8f4b5fd419 Reviewed-on: https://chromium-review.googlesource.com/1090416 Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Pawel Osciak <posciak@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#566752}
-
Yutaka Hirano authored
This CL adds redirect logic to CORSURLLoader. There are some TODOs and I'll address them later. Bug: 736308 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I8db4eccb6c5bb453882f6a469d4185487848773a Reviewed-on: https://chromium-review.googlesource.com/1088715Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#566751}
-
Balazs Engedy authored
This allows AuthenticatorImpl to first create the delegate and ask it if the WebContents has focus, and only then triggering the request dialog (which may steal the focus), so as to avoid race conditions around focus checking at request start. The CL also fixes fake FidoDiscoveries to use weak pointers so as to support being immediately destroyed after the discovery is started. Bug: 849323, 851593 Change-Id: Iae4ac25dc39b527e5481836e4522a6f4da7e31ba Reviewed-on: https://chromium-review.googlesource.com/1095619 Commit-Queue: Balazs Engedy <engedy@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#566750}
-
Yuki Shiino authored
This reverts commit 377243e0. Reason for revert: SitePerProcessTextInputManagerTest.TrackTextSelectionForAllFrames is failing on Mac-10.12. https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.12%20Tests/13719 Findit has 93% confident with this CL, and nothing else looks suspiciou so far (although this one doesn't look suspicious to me, neither). https://findit-for-me.appspot.com/waterfall/build-failure?url=https://build.chromium.org/p/chromium.mac/builders/Mac10.12%20Tests/builds/13719 Let me give it a try to revert this one to see whether the revert fixes the issue or not. Please land this again, if this is irrelevant at all. Original change's description: > Move main scrolling coordinator update after PrePaint > > The main scrolling coordinator update, ScrollingCoordinator:: > UpdateAfterCompositingChangeIfNeeded, does not depend on the PrePaint > phase and can be moved after PrePaint. This change will make it easier > to compare the new PaintTouchActionRects update > (ScrollingCoordinator::UpdateTouchActionRects) to the current update > (ScrollingCoordinator::UpdateAfterCompositingChangeIfNeeded). > > This patch also renames UpdateAfterCompositingChangeIfNeeded to > UpdateAfterPrePaint and adds a comment describing what it does. > > Bug: 851513 > Change-Id: Idbcd515708a33d6955deb513808874b38d731c4f > Reviewed-on: https://chromium-review.googlesource.com/1096297 > Reviewed-by: Robert Flack <flackr@chromium.org> > Commit-Queue: Philip Rogers <pdr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#566542} TBR=flackr@chromium.org,pdr@chromium.org,xidachen@chromium.org Change-Id: Ic1839d7e51752fd2b5f974b958dadd2b98f2569c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 851513 Reviewed-on: https://chromium-review.googlesource.com/1098815Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#566749}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/efd99cc92817..7deacf4833dc git log efd99cc92817..7deacf4833dc --date=short --no-merges --format='%ad %ae %s' 2018-06-12 jvanverth@google.com More shadow tessellation cleanup. Created with: gclient setdep -r src/third_party/skia@7deacf4833dc The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=csmartdalton@chromium.org Change-Id: I29227ed013756bbe4960422ebbe8b2b95a876828 Reviewed-on: https://chromium-review.googlesource.com/1098239Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#566748}
-
Yutaka Hirano authored
ErrorParameter holds a reference to a stale object. Let's stop doing that. Bug: 851419 Change-Id: I0c91acce7afaceeecdb368f5592417d4a39d8174 Reviewed-on: https://chromium-review.googlesource.com/1098646Reviewed-by:
-
Darren Shen authored
This is used to hide ongoing work to update the virtual keyboard UI. Bug: 851847 Change-Id: I13001c8812a68341cd9a330958dc4b42dda9abfd Reviewed-on: https://chromium-review.googlesource.com/1096799 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#566746}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/3f7f40e7..a0f86882 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: Ic6a276cf133342b130fe2fc865baae96d81181f3 Reviewed-on: https://chromium-review.googlesource.com/1098615Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#566745}
-
Cathy Li authored
This will later be used to fetch resources for the UI. Bug: 852075 Change-Id: I58fa78a458c9cd329d55d7b4042c15b7f721aa97 Reviewed-on: https://chromium-review.googlesource.com/1095691Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Cathy Li <chili@chromium.org> Cr-Commit-Position: refs/heads/master@{#566744}
-
Findit authored
This reverts commit bf746c55. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 566724 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2JmNzQ2YzU1YWRmNDlkMmYyMmNjMzA4MTg1YTE2ZDEyYzRlMTViMDQM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.linux/Linux%20Tests%20%28dbg%29%281%29/72596 Sample Failed Step: not_site_per_process_browser_tests Original change's description: > paint timing: Use presentation-time instead of swap-time. > > The presentation-time from gpu gives a more correct view of what the > user experiences, rather than the swap-time in the renderer process. > So switch to using the presentation-time to measure the various > paint-time metrics. > > The various paint-time metrics in telemetry tests (loading benchmark) > will go up after this change, but it is expected, and it is not a > regression. Results on various platforms with this change: > > Win 7: https://pinpoint-dot-chromeperf.appspot.com/job/14d09714240000 > Win 10: https://pinpoint-dot-chromeperf.appspot.com/job/149921e4240000 > Mac low-end: https://pinpoint-dot-chromeperf.appspot.com/job/12eeeba5240000 > Android one: https://pinpoint-dot-chromeperf.appspot.com/job/16ab13e9240000 > Android N5x: https://pinpoint-dot-chromeperf.appspot.com/job/12d45da5240000 > > BUG=811961 > > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 > Change-Id: I70a86eb85e84670942fe3fe6341926b5bc6255b9 > Reviewed-on: https://chromium-review.googlesource.com/1050693 > Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> > Reviewed-by: Antoine Labour <piman@chromium.org> > Reviewed-by: Timothy Dresser <tdresser@chromium.org> > Reviewed-by: Brian Anderson <brianderson@chromium.org> > Cr-Commit-Position: refs/heads/master@{#566724} No-Presubmit: true No-Tree-Checks: true No-Try: true BUG=811961 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ia66f54dd90c3010d1103c7ddc657e2765f67a1e3 Reviewed-on: https://chromium-review.googlesource.com/1098775 Cr-Commit-Position: refs/heads/master@{#566743}
-
Koji Ishii authored
This patch forces legacy fallback for -webkit-box and -webkit-inline-box. Bug: 635619 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I15c35df5e71c03a2df6b466e2ba2197f48d5e588 Reviewed-on: https://chromium-review.googlesource.com/1089591 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#566742}
-
Keishi Hattori authored
Add new IncrementalV8FollowupGC. It is a incremental marking enabled version of PreciseGC. Bug: 757440 Change-Id: I1b480eac30936a8ad9b56a88b2191b0d417a61e7 Reviewed-on: https://chromium-review.googlesource.com/1096798 Commit-Queue: Keishi Hattori <keishi@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
-
Darren Shen authored
There are some keyboard settings that enable the virtual keyboard (e.g. SetTouchKeyboardEnabled, SetAccessibilityKeyboardEnabled). When changing these settings, the code must also Enable/Disable KeyboardController. This is done every time in the real code so that we maintain an invariant that KeyboardController is enabled iff one of those settings is on. In KeyboardControllerUnittest however, we Enable KeyboardController in SetUp, but we don't update the corresponding settings there. Instead we instantiate some helper classes that turns on those settings in each test case. This is weird, as we'll always need to instantiate that class to maintain the invariant, so we might as well do it in SetUp. We get rid of the scoped helper classes and just turn on the setting in SetUp. Bug: 849995 Change-Id: I7d7b1bd751cb8894ff2d7a2554b6ae1f8db77bf9 Reviewed-on: https://chromium-review.googlesource.com/1098647Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#566740}
-
Wez authored
Update RTCPeerConnectionHandler to check explicitly that the configured |task_runner_| is the sequence that is is invoked on, rather than using a separate ThreadChecker. Bug: 851378 Change-Id: Ib0e4a7f12e12c1e3b92a435244808d177f86cbf2 Reviewed-on: https://chromium-review.googlesource.com/1096277Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#566739}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/11376cfc6fe9..c27a6612dbae git log 11376cfc6fe9..c27a6612dbae --date=short --no-merges --format='%ad %ae %s' 2018-06-13 ahassani@chromium.org paygen: Remove au-generator.zip Created with: gclient setdep -r src/third_party/chromite@c27a6612dbae The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:808495 TBR=chrome-os-gardeners@chromium.org Change-Id: I5cd621b2dcccf248570fdd215ec497a277003059 Reviewed-on: https://chromium-review.googlesource.com/1098238Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#566738}
-
Hajime Hoshi authored
Now we're trying not to depend on event's target when dispatch an event asyncly in EventQueueImpl since event target is set also when actual dispatching, and setting the target before dispatching should be redundant. In the current situation, there is no consistent rule whether event target is set before dispatching or not. However, there is no other way to inform what is the target for the given event at EventQueueImpl::EnqueueEvent. In the usecase of EventQueue in ContentSecurityPolicy, there is no need to cancel events actively. Then, just posting tasks for events and dispatching them or canceling them when execution context is not present are enough. Instead of EventQueueImpl, this CL introduces EventTarget:: EnqueueAsyncEvent. Design Doc: https://docs.google.com/document/d/1BBtBPTarOF4NeVKSWZe3XaDHo4yTGhdlqYm35yVzPs4/edit# Bug: 846618 Change-Id: I33e67390762cba233ce31634238d4fd477b8d8da Reviewed-on: https://chromium-review.googlesource.com/1090591 Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by:
-
edchin authored
This CL refactors duplicate logic into a helper method. Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I83dcd77667a25821d8bac524be16647517bb83c4 Reviewed-on: https://chromium-review.googlesource.com/1094476 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#566736}
-
Hajime Hoshi authored
This CL is a pure refactoring. There is no usage of IPCTaskRunner from non-main threads. Change-Id: I74063e7f8cdd4562262eebfea4f9d12d594bae8d Reviewed-on: https://chromium-review.googlesource.com/1096934Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#566735}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/9614a313b836..241d0c16c0d3 git log 9614a313b836..241d0c16c0d3 --date=short --no-merges --format='%ad %ae %s' 2018-06-13 qingsi@google.com Remove ContinualGatheringPolicy::GATHER_CONTINUALLY_AND_RECOVER. 2018-06-13 shampson@webrtc.org Updated PeerConnection integration test to fix race condition. 2018-06-13 buildbot@webrtc.org Roll chromium_revision ef538e31..9df92afb (566490:566630) 2018-06-12 qingsi@google.com Refactor the regathering of candidates in P2PTransportChannel. 2018-06-12 zhihuang@webrtc.org Add a flag to actively reset the SRTP parameters 2018-06-12 danilchap@webrtc.org Reland "Use absl::optional instead or rtc::Optional" 2018-06-12 buildbot@webrtc.org Roll chromium_revision ffaf1e2b..ef538e31 (565764:566490) 2018-06-12 orphis@webrtc.org Add HeaderExtensions to RtpParameters 2018-06-12 alexnarest@webrtc.org Enable send side audio TWCC only if WebRTC-Audio-ForceNoTWCC is not enabled. 2018-06-12 mbonadei@webrtc.org Explicitly setting use_lld=false on MSVC bots. 2018-06-12 peterhanspers@webrtc.org Metal renderer does not handle i420 frames correctly. 2018-06-12 andersc@webrtc.org Make rtc_software_fallback_wrappers target visible. 2018-06-12 phensman@webrtc.org Release ADM after passing it to PCF in AppRTC 2018-06-12 kwiberg@webrtc.org LogMessage::UpdateMinLogSeverity: Don't ignore all but the last stream 2018-06-12 philipel@webrtc.org Don't update internal state of the FrameBuffer2 when an undecodable frame is inserted. 2018-06-12 jonasolsson@webrtc.org Remove stringstreams from p2p/ 2018-06-12 jonasolsson@webrtc.org remove unused UNSHIPPED trace macros 2018-06-12 sakal@webrtc.org Delay the creation of the platform thread in TestAudioDeviceModule. Created with: gclient setdep -r src/third_party/webrtc@241d0c16c0d3 The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG=chromium:None,chromium:None,chromium:None,chromium:None,chromium:835958,chromium:None,chromium:None,chromium:844313,chromium:b/79961243 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I7b4bcb1330e3b4206e7a0d20aa3bb776e04949b2 Reviewed-on: https://chromium-review.googlesource.com/1098237Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#566734}
-
edchin authored
A crash will occur when an scrolled offscreen cell is updated. This is because UICollectionView's |-cellForItemAtIndexPath:| returns nil if the cell is offscreen. This CL adds a unittest that fails without the fix, which is also in this CL. The fix is to skip cell configuration if the cell is nil. Bug: 851352 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Iccdb53e3a67b58f225a09ce32ac70f48d42431ef Reviewed-on: https://chromium-review.googlesource.com/1094210Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
-
Joel Hockey authored
* Add Quick View test for downloads and crostini. * Update waitForElement to support searching elements within nested shadow roots. Bug: 845830 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I7b8f2ebd29eddfb3aa453aa5db0cd75aadec0650 Reviewed-on: https://chromium-review.googlesource.com/1090517 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#566732}
-
Matt Falkenhagen authored
The linked bug is marked Fixed, and ServiceWorkerContainer is not exposed to workers. Bug: 413518 Change-Id: I435044364801a9cc02307f929d36a7fcbc87d9a8 Reviewed-on: https://chromium-review.googlesource.com/1098430 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#566731}
-
Adam Rice authored
The M68 branch has a non-working implementation of the enable-websocket-auth-connection-reuse flag. In order to avoid the confusion of having a flag that works in some versions and not in others, temporarily remove the flag from about:flags. Once the flag has been disabled in the M68 branch it will be re-enabled for M69 by reverting this CL. BUG=423609 Change-Id: Id17ac18e13effcfd5bd946dc1fe0f1c70df96539 Reviewed-on: https://chromium-review.googlesource.com/1090700 Commit-Queue: Adam Rice <ricea@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#566730}
-
Yoichi Osato authored
This patch converts the test to reftest since that test just confirms repaint after load. Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Bug: 708452 Change-Id: Iffc00614c617a64c5f185029014f1d43734fbbca Reviewed-on: https://chromium-review.googlesource.com/1092610 Commit-Queue: Yoichi Osato <yoichio@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#566729}
-
Stuart Langley authored
Some cleanup work for components/drive/ briging it in line with recomended practices/c++ modernization. - clang tidy modernize-make-unique. - Fix up headers. This CL introduces NO logic changes. Bug: 841659 Change-Id: I9b8e1dfbacee96c4411abd304c8faf0feb24e118 Reviewed-on: https://chromium-review.googlesource.com/1093334 Commit-Queue: Stuart Langley <slangley@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#566728}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e73d7d84d770..efd99cc92817 git log e73d7d84d770..efd99cc92817 --date=short --no-merges --format='%ad %ae %s' 2018-06-12 caryclark@skia.org clean up SkPicture include Created with: gclient setdep -r src/third_party/skia@efd99cc92817 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=csmartdalton@chromium.org Change-Id: I56c3ce7048b7b9456042030d73150345856f65db Reviewed-on: https://chromium-review.googlesource.com/1098236Reviewed-by:
-
Matt Falkenhagen authored
The function had a public helper function that didn't add much value. We were duplicating checks like !provider_ and the flow of data was more complicated. It's hard to read the diff so the changes are: * Removed RegisterServiceWorkerImpl. * Removed duplicate if (!provider_) check. * Removed |raw_script_url|, it's unneeded indirection. * Unified the preparation of |script_url|, |pattern_url|, and |update_via_cache| to just before they are used. Change-Id: Icef9dd5b26f4009fbf69d62ad918066be2c0733c Reviewed-on: https://chromium-review.googlesource.com/1098425 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
-
Tetsui Ohkubo authored
Design doc: http://go/cros-qs-restyling TEST=ash_unittests,browser_tests BUG=842079 Change-Id: Ia9eaac6e494fc8ec1b35aaedd9ebf9814890ec57 Reviewed-on: https://chromium-review.googlesource.com/1088458 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#566725}
-
Sadrul Habib Chowdhury authored
The presentation-time from gpu gives a more correct view of what the user experiences, rather than the swap-time in the renderer process. So switch to using the presentation-time to measure the various paint-time metrics. The various paint-time metrics in telemetry tests (loading benchmark) will go up after this change, but it is expected, and it is not a regression. Results on various platforms with this change: Win 7: https://pinpoint-dot-chromeperf.appspot.com/job/14d09714240000 Win 10: https://pinpoint-dot-chromeperf.appspot.com/job/149921e4240000 Mac low-end: https://pinpoint-dot-chromeperf.appspot.com/job/12eeeba5240000 Android one: https://pinpoint-dot-chromeperf.appspot.com/job/16ab13e9240000 Android N5x: https://pinpoint-dot-chromeperf.appspot.com/job/12d45da5240000 BUG=811961 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I70a86eb85e84670942fe3fe6341926b5bc6255b9 Reviewed-on: https://chromium-review.googlesource.com/1050693 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Reviewed-by:
Brian Anderson <brianderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#566724}
-
Sunny authored
According to xhr spec[1], no CRLF normalize operation need to be performed when invoking FormData methods, so all normalization call is removed in this commit. But in form sepc[2], when appending data from form controls to FormData, both name and value should be normalized. New methods |FormData::AppendFromElement| will perform the normalize operation. [1] https://xhr.spec.whatwg.org/#dom-formdata-append [2] https://html.spec.whatwg.org/multipage/form-control-infrastructure.html#append-an-entry BUG=798030 Change-Id: If90a8e500705013c2935e5290624d4414dd32a72 Reviewed-on: https://chromium-review.googlesource.com/1091238Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#566723}
-
Hiroki Nakagawa authored
This CL mechanically renames SettingsObject to FetchClientSettingsObjectSnapshot, and revises the class level comments of the class. This change is a part of the Modulator cleanup project. See the design doc for details: https://docs.google.com/document/d/1R0VgKZtrBL9hAq8SgCVuDOv-2vzB15M9HDwzdad0J6k/edit#heading=h.5rwrtojwiu5c Bug: 845285 Change-Id: I0359d650e97a5972b2cdc5a39c223b50f2e42afc TBR: haraken@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1090592 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#566722}
-
Ben Chan authored
CL:857742 and CL:857743 added the support for APN authentication method specified in the mobile operator database in shill. CL:1081764 updated shill to respect the authentication method in the user-specified APN property. This CL adds the ONC translation of the APN authentication property, so that a follow-up CL can update the settings UI to allow specifying the APN authentication for the user-specified APN. BUG=b:68680371 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I7e110a3a4841f8ec2ee725cdc799999b51a45746 Reviewed-on: https://chromium-review.googlesource.com/1096430 Commit-Queue: Ben Chan <benchan@chromium.org> Reviewed-by:
-
Patti authored
Site settings's All Sites back end was updated in r562730 to group sites by their eTLD+1. This patch updates the front end to match. Clicking on an eTLD+1 group will expand the list to show all relevant origins under it, and clicking one of those origins retains the previous behavior where it will navigate to Site Details. Similarly sites that have no eTLD+1 group will retain existing behavior. Bug: 835712 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I075a1befd49211d0a3b29820ea3aa71887f9dd0e Reviewed-on: https://chromium-review.googlesource.com/1088274 Commit-Queue: Patti <patricialor@chromium.org> Reviewed-by:
Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#566720}
-
Joel Hockey authored
This makes them available in the save-as dialog. Bug: 845088 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I37dbb73a8de6a115e70a3bc8549b0e4351086bb6 Reviewed-on: https://chromium-review.googlesource.com/1098421Reviewed-by:
Naoki Fukino <fukino@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#566719}
-
Tetsui Ohkubo authored
It fixes FirstRunUIBrowserTest when UnifiedSystemTray is enabled. The test is regressed by interactive_ui_tests fix https://crrev.com/c/1096718. We only have to set initial focus when system tray bubble is activated. This is a flag flip blocker of chrome://flags/#enable-system-tray-unified. TEST=FirstRunUIBrowserTest.EscapeCancelsTutorial BUG=847104 Change-Id: Iccb8ea92724fffc787a649e1a4fdac36507f3b71 Reviewed-on: https://chromium-review.googlesource.com/1098419 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Cr-Commit-Position: refs/heads/master@{#566718}
-
