GitLab

Windows expects back slash instead of forward slash in paths. Python
subprocess.call does not convert slashes automatically.

BUG=NONE
R=zmo

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I76d8d4b973127102b42a4a02f59b09993383aabb
Reviewed-on: https://chromium-review.googlesource.com/956548Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541918}

The "OmniboxCombinedSpeculativeServiceWorker" study has long expired and
the "OmniboxSpeculativeServiceWorkerStartOnQueryInput" feature has
been enabled by default in r541744.

Bug: 732681
Change-Id: I08175813d67ed834eba31c080e5071248fb4a49e
Reviewed-on: https://chromium-review.googlesource.com/954891Reviewed-by: Mark Pearson <mpearson@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541917}

After an option-enter navigation we should be displaying the URL.

I'm a little nervous about changing this logic, but I've tried every
kind of search and navigation I can think of and they all seem to still
work correctly.

Bug: 410707
Change-Id: I0d30ce7e23d6b98e4c99857e5b8226364398b758
Reviewed-on: https://chromium-review.googlesource.com/935672Reviewed-by: Trent Apted <tapted@chromium.org>
Commit-Queue: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541916}

App push-install log uploads are authenticated with the user's
DMToken. It makes no sense to collect logs for any other users
(e.g. kiosks, public sessions) as we would be unable to upload
them anyway.

Plus, trying to instantiate the logging framework in kiosk
sessions leads to crashes as some singletons come up in an
unexpected order.

Bug: 811398
Test: Manual
Change-Id: I827f3cd85accb423ac61bc5f6450753e9c6418cf
Reviewed-on: https://chromium-review.googlesource.com/952904Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Commit-Queue: Bartosz Fabianowski <bartfab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541915}

The Chromevox instructions are a relative link. All the other links
I added last were backwards.

NOTRY=true

Bug: none
Change-Id: Iec684256f0d8ced7061aded6f3562ba0fde0be6f
Reviewed-on: https://chromium-review.googlesource.com/956500Reviewed-by: David Tseng <dtseng@chromium.org>
Commit-Queue: Katie Dektar <katie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541914}

Maybe third time's the charm. This patch is a minor refactoring of the
URL bar margin logic in LocationBarLayout. It separates the calculation
of the margin into a separate method to be overridden by the
phone-specific LocationBarPhone. This way both the phone and tablet
versions are happy, tests all pass, and everything looks as it should.

The hope is that we can consolidate the layouts a little more in the
near future.

Bug: 816432,816376,819991
Change-Id: I4f8c18eae4f8d19c72e035a8aeae4ffb54b97400
Reviewed-on: https://chromium-review.googlesource.com/956013
Commit-Queue: Troy Hildebrandt <thildebr@chromium.org>
Reviewed-by: Maria Khomenko <mariakhomenko@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541913}

This change removes two setters for the fullscreen manager and the
tab model selector as they can be accessed in init from
ChromeActivity. The height ratios of the sheet are now also referenced
by their respective state.

BUG=814528

Change-Id: I5a58a2ff367c7ad567d6b88b7bb8a3920632a57c
Reviewed-on: https://chromium-review.googlesource.com/956342Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541912}

PrintToSkPicture currently uses a custom image serializer, but there is no
corresponding custom deserializer in Skia -> we cannot deserialize these
images.

The historical reason for using a custom serializer is support for
--skip-reencoding-on-skp-capture.  This flag was added in
https://crrev.com/1710553002, but is no longer used.

The simplest fix for image serialization is to remove the custom proc
and allow Skia to handle it instead.

BUG=820142

Change-Id: Id19851811e23dd828b5fea7248874740cfda8dea
Reviewed-on: https://chromium-review.googlesource.com/956025Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Leon Scroggins <scroggo@chromium.org>
Commit-Queue: Florin Malita <fmalita@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541911}

Enable always-retransmittable-packet-on-wire behavior for QuicChromiumClientSessions with migrate_session_early(_v2) enabled.

Change-Id: I007592fc9247dcbdee38cb964a0205576ec45de5
Reviewed-on: https://chromium-review.googlesource.com/953205
Commit-Queue: Yixin Wang <wangyix@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Reviewed-by: Zhongyi Shi <zhongyi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541910}

This UIViewPropertyAnimator subclass records whether animations have
been added and early returns before attempting to start an animator that
has no animation blocks.  This is necessary because the default
implementations of |-startAnimation| and |-startAnimationAfterDelay:|
throw exceptions if there are no animations.

This CL also updates FullscreenAnimator to be optional, as there is no
guarantee that FullscreenControllerObservers will add animation blocks
to FullscreenAnimators.

Bug: 819623
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I1e73a7163f5bd9b82cf4ff693b290464ecec63cd
Reviewed-on: https://chromium-review.googlesource.com/953793Reviewed-by: edchin <edchin@chromium.org>
Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541909}

Proposing dcastagna@ to join the //media/gpu OWNERS.

The file is sorted alphabetically.

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ia96664905ec5cfbcd3879bcb7006b15db0ae6aeb
Reviewed-on: https://chromium-review.googlesource.com/956287Reviewed-by: Dan Sanders <sandersd@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541908}

This experiment ended a while ago, removing unused code and metrics

Bug: 704117
Change-Id: I1149ef5efedf9e989fe957e4d7884a1296c64bc9
Reviewed-on: https://chromium-review.googlesource.com/955781Reviewed-by: Bryan McQuade <bmcquade@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541907}

Bug: chromium:817110
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Id2ccbca1f9ddc2f1073fd0532eb06fd335b98f0a
Reviewed-on: https://chromium-review.googlesource.com/956034Reviewed-by: Brandon Jones <bajones@chromium.org>
Commit-Queue: Yuqian Li <liyuqian@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541906}

Expose request body data to WebRequest listeners when Network Service is
enabled.

Bug: 721414
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I21d4a1baabd4f842a9af6a7442b070c4932b1b44
Reviewed-on: https://chromium-review.googlesource.com/954002
Commit-Queue: Ken Rockot <rockot@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541905}

This allows the user to manually opt into using Windows native
notifications instead of Chrome's version of the notifications.

Note: This flag is ignored on versions of Windows old enough
not to support native notifications.

Bug: 734095, 516147
Change-Id: Ic5475e6fa13e29207a5d417efc996f16fdf997db
Reviewed-on: https://chromium-review.googlesource.com/955244
Commit-Queue: Peter Beverloo <peter@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541904}

The crash happens because contextForPendingNavigationWithURL returns
null navigation context and receiving code expected a valid context
object. Navigation context only exists for main frame navigations
and will be null for iframes.

This CL updates the code to avoid dereferencing context pointer for
iframe navigations.

Bug: 801161
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ibd530f56ad1efc10a6f498118d63895c74b04b07
Reviewed-on: https://chromium-review.googlesource.com/953178Reviewed-by: Peter Lee <pkl@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541903}

Bug: 820110
Change-Id: I6402e7f40405a4c3a8cfa55a1aacedc3b7920912
Reviewed-on: https://chromium-review.googlesource.com/956095Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541902}

Bug: 734095
Change-Id: Ib77b7a86351151cdb109fe86bbff291b1519f6c9
Reviewed-on: https://chromium-review.googlesource.com/953082
Commit-Queue: Xi Cheng <chengx@chromium.org>
Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541901}

This reverts commit 3364152a.

Reason for revert: Broke the Android ARM64 builder (https://uberchromegw.corp.google.com/i/chromium.android/builders/Android%20arm64%20Builder%20%28dbg%29/builds/28515) for some unknown reason.

Original change's description:
> [TTS] reland mojo-ify ShowUnhandleTapUIIfNeeded.
> 
> Replaces the whole call chain for ShowUnhandledTapUIIfNeeded
> between Blink and Chrome/WebView with Mojo messaging.
> 
> Removes the Blink WebTappedInfo class in favor of a new UnhandledTapInfo
> that sends a Mojo construct of the same name to the Browser which
> has a service installed via a RenderHostFrame observer.
> 
> All functionality should remain unchanged.
> 
> NEW CODE:
> The CSTabHelper now creates an UnhandledTapWebContentsObserver that
> connects the Mojo service via UnhandledTapNotifierImpl.  That Impl
> calls back through Java to the CSTabHelper to the CSManager to notify
> that a Tap has occurred.  The CSTabHelper ignores these notifications
> when CS is disabled.
> 
> The mojo message is only sent to the browser if the tap is unhandled
> and the other required conditions are met.
> 
> UPDATED TESTS:
> Test notification is now done through mojo messaging, so we now only
> know if the tap was unhandled, not whether the page changed or other
> details about why the tap was unhandled.
> 
> Updated the test page by adding nodes that do not trigger, and removed
> the mousemove handler since it's unrelated to tap handling.
> 
> BUG=754862
> 
> TBR=dcheng@chromium, yfriedman@chromium.org, kinuko@chromium.org
> 
> Original CL:
> 
> Reviewed-on: https://chromium-review.googlesource.com/841544
> Reviewed-by: Yoichi Osato <yoichio@chromium.org>
> Reviewed-by: Theresa <twellington@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
> Reviewed-on: https://chromium-review.googlesource.com/952679
> Commit-Queue: Donn Denman <donnd@chromium.org>
> Cr-Original-Commit-Position: refs/heads/master@{#541569}
> Change-Id: I4da1704fe17fae6fe06d8a6167fbf9bc75a01303
> Reviewed-on: https://chromium-review.googlesource.com/956086
> Reviewed-by: Donn Denman <donnd@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#541879}

TBR=dcheng@chromium.org,kinuko@chromium.org,yfriedman@chromium.org,donnd@chromium.org,yoichio@chromium.org,twellington@chromium.org,dcheng@chromium

Change-Id: Ib49a16a10903e0b2ba52cf0e32e4f1883888b7b3
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 754862
Reviewed-on: https://chromium-review.googlesource.com/956356Reviewed-by: Donn Denman <donnd@chromium.org>
Commit-Queue: Donn Denman <donnd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541900}

And fix up NTP tests.

BUG=803095

Change-Id: I0b757c79ba6f0fe1b8a06cd7d4eaa700297b30ed
Reviewed-on: https://chromium-review.googlesource.com/949090Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Commit-Queue: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541899}

This tool scans for any screenshots (png only) associated with grd files and uploads them to Google Cloud Storage using upload_to_google_storage.py.

upload_to_google_storage.py is a tool that maintains content addressed files. It stores files with their sha1 hashes as filenames.

The storage bucket name used in the tool is tentative.

For details, see the design doc at http://go/chrome-translation-screenshots#heading=h.cyt0azox2105

Change-Id: Ide06aa679489a65887df9c58948c8adde12d3eba
Bug: 814901
Reviewed-on: https://chromium-review.googlesource.com/922686
Commit-Queue: Mustafa Emre Acer <meacer@chromium.org>
Reviewed-by: anthonyvd <anthonyvd@chromium.org>
Reviewed-by: Aaron Gable <agable@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541898}

https://pdfium.googlesource.com/pdfium.git/+log/507fb4ed09d5..a724cb2df9f7

$ git log 507fb4ed0..a724cb2df --date=short --no-merges --format='%ad %ae %s'
2018-03-08 hnakashima Move GetPopupPos from CFWL_Widget to subclasses that call it.
2018-03-08 dsinclair Remove unused constructor
2018-03-08 dsinclair Cleanup CPDF_SimpleParser
2018-03-08 dsinclair CPDF_InterForm::ResetForm always returns true

Created with:
  roll-dep src/third_party/pdfium


The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: Idc5571d6124b9bee5b698abfd1a82c9f7117daaf
Reviewed-on: https://chromium-review.googlesource.com/955898
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#541897}

The concept of "working set" is specific to the Windows memory model.
  * Windows-only files were modified to directly invoke the Windows API.
  * os_metrics_linux.cc was modified to use RSS instead [which is what they really
  wanted].
  * Two iOS files were incorrectly using GetWorkingSetSize() to return a
  task's "resident_size" as a rough measurement for total memory usage. This is
  inaccurate, since it includes reusable memory [used extensively by libMalloc
  for freeing objects]. This CL changes those two files to directly invoke the
  relevant mach APIs, and to subtract out reusable memory.
  * Remoting was using GetWorkingSetSize on all platforms, but the concept is
  only well defined on Windows.
  * MemoryCoordinator was calling GetWorkingSetSize from dead code. The dead
  code was removed.

Bug: 819289
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I720e18ab483a9995982762cbd5ae1d045adfaa74
TBR: sky@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/953723
Commit-Queue: Erik Chen <erikchen@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Joe Downing <joedow@chromium.org>
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541896}

The bulk of this change is to revert commit
0b15dad9. It isn't a direct revert due
to a number of things.
  - The ScopedComPtr interface that was widely used in the old patch no
    longer exists.
  - A number of interfaces change slightly (ImeTextSpans)
  - unsigned/signed compiler warnings

This code was abandoned a few years ago and removed from the repository
because it only worked in the Windows 8 Metro Mode of Chrome. Once that
mode was removed the supporting IME code was removed as well. The code
in its current form is functional but has issues which will be addressed
in follow up patches. It is desirable to move to TSF since there are
additional APIs that work via this API. Like text writing.

Functionality common to both input methods are placed in
InputMethodWinBase. InputMethodWin will be renamed to InputMethodWinImm32
in a followup patch.

This feature is currently disabled but can be enabled via
--enable-features=TSFImeSupport. No functionality changes are expected
with the Imm32 implementation.

Inputing text using Pinyin seems to work; as well as disabling DLL
injection (crbug.com/557798) allows the IME to work correctly with TSF.

There is some broken support with this change in that keydown/up messages,
arrow keys in the omnibox are not delivered. I intend to fix these in
followup changes being that this change is intended to make a previously
reverted change available under a command line flag.

BUG=657623

Change-Id: I89eb1a7ba6b9f95525df6fa83be5d923a03323b2
Reviewed-on: https://chromium-review.googlesource.com/916534
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Shu Chen <shuchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541895}

https://chromium.googlesource.com/angle/angle.git/+log/5242d5bf74d3..19fa1c6f8852

$ git log 5242d5bf7..19fa1c6f8 --date=short --no-merges --format='%ad %ae %s'
2018-03-08 jmadill Return an Error from Framebuffer::syncState.
2018-03-08 jmadill Vulkan: Use RenderTargetCache in FramebufferVk.

Created with:
  roll-dep src/third_party/angle


The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=ynovikov@chromium.org

Change-Id: I00a6a1214c19650755b302ce9c307ccc8302a886
Reviewed-on: https://chromium-review.googlesource.com/955900
Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#541894}

Bug: 819135
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I239dab7a7ee1c9394f73e2dc51b411ed7c708305
Reviewed-on: https://chromium-review.googlesource.com/954331Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541893}

Final step 5 of cleaning up the provider API for MailtoHandlerProvider.

Bug: 813821
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ie454be3b22237a493f943869287b283e1bfe5227
Reviewed-on: https://chromium-review.googlesource.com/956237Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Peter Lee <pkl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541892}

This updates device, extensions and one new one in components.

Targets go from foo_features to foo_buildflags
And similarly the header now has buildflags in the name.

BUG=814485
TEST=covered by build
TBR=dcheng@chromium.org

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I8f935cf88795b11a57728da10e830ffd88ce4885
Reviewed-on: https://chromium-review.googlesource.com/956006
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541891}

As fix attempt to the test flakes has been landed in crrev.com/c/946848,
this patch re-enables the test to see if the fix works.

Bug: 814845
Change-Id: I2a9e0d98a172fc0cac7c0e87cc302acab04dc325
Reviewed-on: https://chromium-review.googlesource.com/942470Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541890}

Using wpt-import in Chromium f6009cbd.
With Chromium commits locally applied on WPT:
14350ac7 "[PE] Don't truncate table cell's padding"


Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/13486

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
domenic@chromium.org, ricea@chromium.org:
  external/wpt/streams
rouslan@chromium.org, mathp@chromium.org:
  external/wpt/payment-request

TBR=robertma

No-Export: true
Change-Id: I033e56672564886214422c5a25725ef3e0254b5b
Reviewed-on: https://chromium-review.googlesource.com/956024
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541889}

Fix errorprone NarrowingCompoundAssignment warnings and make
sure it is treated as error after this CL.

http://errorprone.info/bugpattern/NarrowingCompoundAssignment

Bug: 801268

Change-Id: Ief55318e789176288962359566d708af51c7c890
Reviewed-on: https://chromium-review.googlesource.com/953181Reviewed-by: Peter Wen <wnwen@chromium.org>
Reviewed-by: Joe Downing <joedow@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Rob Buis <rob.buis@samsung.com>
Cr-Commit-Position: refs/heads/master@{#541888}

Crash dumps contain sensitive data.

Bug: b/74372631
Test: kill -SEGV cast_shell and check for successful upload

Change-Id: I2c3877477bd652708838124ae43d1e24766e8edf
Reviewed-on: https://chromium-review.googlesource.com/955342
Commit-Queue: Michael Spang <spang@chromium.org>
Reviewed-by: Stephen Lanham <slan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541887}

changes:
Enable the feature by default. Also fix the bug that window cannot be
moved. display::CreateDisplayIdList is sorting using the first 8 bits,
pass that comparator to std::upper_bound too.

TBR=stevenjb@chromium.org

Bug: 778438
Test: tested on device.
Change-Id: Ic8b9df780f99f0466805f8857e2cb0414a163999
Reviewed-on: https://chromium-review.googlesource.com/954361
Commit-Queue: Qiang Xu <warx@google.com>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: Qiang Xu <warx@google.com>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541886}

This scripts lives in depot_tools.

Bug: 759146
Change-Id: I3877d3b53ef2f91b34cebb61b04e6f285a006ae7
Reviewed-on: https://chromium-review.googlesource.com/911428
Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
Reviewed-by: Lutz Justen <ljusten@chromium.org>
Reviewed-by: Sasha Morrissey <sashab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541885}

Bug: 773295
Change-Id: Id129cea8341c14bd8da4b5374034423223f03859
Reviewed-on: https://chromium-review.googlesource.com/884063
Commit-Queue: Mark Pilgrim <pilgrim@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541884}

We missed this line when we add the tail processing change. Let's add
it back in.

Bug: 731518
Change-Id: Id90cade41f311309ef60f049094478de0ad4c19e
Reviewed-on: https://chromium-review.googlesource.com/956318Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Commit-Queue: Hongchan Choi <hongchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541883}

This should speed up the wall time of these browser tests significantly
h/t to jkarlin for discovering this issue.

Bug: 819721
Change-Id: I5368234cd3ea729eb262af22233df496e1368c4b
Reviewed-on: https://chromium-review.googlesource.com/953803Reviewed-by: Josh Karlin <jkarlin@chromium.org>
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541882}

BUG=714018

Change-Id: Ic6fa05a2ebd6ca21bd1b2a349a58f7a419a3465d
Reviewed-on: https://chromium-review.googlesource.com/952991Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541881}

Bug: 817779
Change-Id: I42fc05273e682c82b280b0cad051a129c2dd892b
Reviewed-on: https://chromium-review.googlesource.com/954705
Commit-Queue: Benjamin Pastene <bpastene@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541880}

Replaces the whole call chain for ShowUnhandledTapUIIfNeeded
between Blink and Chrome/WebView with Mojo messaging.

Removes the Blink WebTappedInfo class in favor of a new UnhandledTapInfo
that sends a Mojo construct of the same name to the Browser which
has a service installed via a RenderHostFrame observer.

All functionality should remain unchanged.

NEW CODE:
The CSTabHelper now creates an UnhandledTapWebContentsObserver that
connects the Mojo service via UnhandledTapNotifierImpl.  That Impl
calls back through Java to the CSTabHelper to the CSManager to notify
that a Tap has occurred.  The CSTabHelper ignores these notifications
when CS is disabled.

The mojo message is only sent to the browser if the tap is unhandled
and the other required conditions are met.

UPDATED TESTS:
Test notification is now done through mojo messaging, so we now only
know if the tap was unhandled, not whether the page changed or other
details about why the tap was unhandled.

Updated the test page by adding nodes that do not trigger, and removed
the mousemove handler since it's unrelated to tap handling.

BUG=754862

TBR=dcheng@chromium, yfriedman@chromium.org, kinuko@chromium.org

Original CL:

Reviewed-on: https://chromium-review.googlesource.com/841544Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/952679
Commit-Queue: Donn Denman <donnd@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#541569}
Change-Id: I4da1704fe17fae6fe06d8a6167fbf9bc75a01303
Reviewed-on: https://chromium-review.googlesource.com/956086Reviewed-by: Donn Denman <donnd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541879}