- 06 Dec, 2019 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/fe18a43d590a..6b52dc21e166 git log fe18a43d590a..6b52dc21e166 --date=short --first-parent --format='%ad %ae %s' 2019-12-06 jyasskin@google.com Default to origin's default branch instead of always origin/master. Created with: gclient setdep -r src/third_party/depot_tools@6b52dc21e166 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1023031 Tbr: agable@chromium.org Change-Id: Id096878bf58f5cb701c4ceaaeec737eff415cee0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955848Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#722580}
-
Brian Sheedy authored
Adds support for base::win::GetVersion() returning either 5 or 6 on Windows 10, which are valid return values but currently unhandled, which has been causing flaky test failures. Bug: 1007013 Change-Id: I40217ff610cb9071c2504352e8a99b234f3c1fa5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954216 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#722579}
-
Antonio Gomes authored
As part of this CL: - WebRTCPeerConnectionHandler became RTCPeerConnectionHandlerPlatform - WebRTCPeerConnectionHandlerClient became RTCPeerConnectionHandlerClient - MockWebRTCPeerConnectionHandler became MockRTCPeerConnectionHandlerPlatform BUG=919392, 787254 Change-Id: Id5737142323fb611a177b3ca6d0a79c21bd91c39 R=guidou@chromium.org, haraken@chromium.org Change-Id: I1b26bf3946791df4fcac71594f2acb34a040774e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1953383 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#722578}
-
Steven Bennetts authored
Prior to using mojo for network configuration, when creating a new configuration for a visible network, the GUID of the visible network would be provided so that it was preserved. Some UI depends on this (e.g. OOBE flow) and generally it is less confusing for logging, debugging, etc. This restores that behavior by providing an optional guid property in the mojo ConfigProperties and translating it to ONC. Bug: 1009406 Change-Id: Ia6fc22afa16b514a767dc97274bc216f28112ab8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951558Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#722577}
-
Samuel Huang authored
This CL moves 83.5 kB of "long tail" resources to the Developer WebUI Dynamic Feature Module (DevUI DFM), for 17 chrome:// pages whose resources were in browser_resources.pak. These pages and their associated resource prefixes are: accessibility (IDR_ACCESSIBILITY_*) components (IDR_COMPONENTS_*) device-log (IDR_DEVICE_LOG_UI_*) domain-reliability-internals (IDR_DOMAIN_RELIABILITY_INTERNALS_*) download-internals (IDR_DOWNLOAD_INTERNALS_*) interventions-internals (IDR_INTERVENTIONS_INTERNALS_*) local-state (IDR_LOCAL_STATE_*) media-engagement (IDR_MEDIA_ENGAGEMENT_*) memory-internals (IDR_MEMORY_INTERNALS_*) notifications-internals (IDR_NOTIFICATIONS_INTERNALS_*) predictors (IDR_PREDICTORS_*) sandbox (IDR_SANDBOX_INTERNALS_*) site-engagement (IDR_SITE_ENGAGEMENT_*) snippets-internals (IDR_SNIPPETS_INTERNALS_* | IDR_FEED_INTERNALS_*) supervised-user-internals (IDR_SUPERVISED_USER_INTERNALS_*) translate-internals (IDR_TRANSLATE_INTERNALS_*) ukm (IDR_UKM_INTERNALS_*) Note that chrome://snippets-internals has 2 prefixes, corresponding to {SnippetsInternalsUI, FeedInternalsUI}. Also, some DevUI pages in browser_resources.pak are not moved, because they are new and can be handled later (need IsWebUiHostInDevUiDfm() change), or are not used by Android. These resources are moved to new file dev_ui_browser_resources.pak, which then feeds into dev_ui_resources.pak. 18 WebUI .cc files have their resource include headers updated. Bug: 927131 Change-Id: Ideaf57e2997b4621d7ffdfea8c126bf78688c322 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954458Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#722576}
-
Peng Huang authored
Bug: 1020626 Change-Id: I70860caa686d221c3346eaaa018f9304c04a6f5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955864 Commit-Queue: Peng Huang <penghuang@chromium.org> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Auto-Submit: Peng Huang <penghuang@chromium.org> Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#722575}
-
Lei Zhang authored
Bug: 659750 Change-Id: I78a775072dc1bde8c7db0bfaddd39ae6c55d432c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954542Reviewed-by:
James MacLean <wjmaclean@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#722574}
-
Tommy Li authored
This is a reland of ebc60412 Original change's description: > [omnibox] Fix ZeroSuggestProvider duplicate classifications bug > > The below CL introduces a bug, where ZeroSuggestProvider can create > a match with duplicate text classifications. This triggers a DCHECK > as described in the linked bug. > > https://chromium-review.googlesource.com/c/chromium/src/+/1947765 > > This CL fixes it and adds a test. > > Bug: 1030741 > Change-Id: If59fbd320d720e2a7ff8d2f66d9ee92e11bb9a68 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951557 > Commit-Queue: Tommy Li <tommycli@chromium.org> > Reviewed-by: manuk hovanesian <manukh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#722497} Bug: 1030741 Change-Id: Ic169c05bfc953da56b161beb677e454ad0b2d437 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955787Reviewed-by:
manuk hovanesian <manukh@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#722573}
-
Maksim Sisov authored
This CL 1) extracts ShellObjectFactory into a separate file and keeps the same creation and initialization logic of wrappers of shell objects, 2) extends ShellPopupWrapper and ShellSurfaceWrapper interfaces by adding Initialize method so that it is more convenient to initialize XdgPopupWrapperImpl XdgSurfaceWrapperImpl and let them handle initialization based on the available xdg-shell version, 3) makes WaylandWindow use the extracted ShellObjectFactory, 4) makes InitializeStable and InitializeV6 methods of XDGWrapper objects be private members. The decision on which one to call is made in the main Initialize method now. 5) reconsiders the logging whether we need to keep pointers to some objects or not. Bug: 1028919 Change-Id: I87fd5fc0d0b35222f26c460c9174da6053dc320e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1953708Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#722572}
-
Manas Verma authored
This reverts commit 69671ce5. Reason for revert: Tested in Canary, and the flow stops immediately after authentication. Will try to debug this, and possibly just go ahead with the long term solution right away. Original change's description: > [Autofill Auth] Adding capability to disable WebAuthn UI from Autofill > > Providing an option to disable WebAuthn UI from InternalAuthenticatorImpl. > > By disabling WebAuthn UI, modal dialogs will stop conflicting between the two > components and this will give Autofill full control over the user experience. > > Bug: 949269 > Change-Id: Ibf88cdb0f014c022371546df54d10e2c9eb7bc24 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948916 > Commit-Queue: Manas Verma <manasverma@google.com> > Reviewed-by: Martin Kreichgauer <martinkr@google.com> > Reviewed-by: Jared Saul <jsaul@google.com> > Reviewed-by: sebsg <sebsg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#722230} TBR=sebsg@chromium.org,jsaul@google.com,martinkr@google.com,manasverma@google.com Change-Id: Iab4507114f3e19e59acddd49ea89244ee7390048 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 949269 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955910Reviewed-by:
Manas Verma <manasverma@google.com> Commit-Queue: Manas Verma <manasverma@google.com> Cr-Commit-Position: refs/heads/master@{#722571}
-
Mila Green authored
Bug: 1027181 Change-Id: Ia370f73f7b6c88428b0a4665fd7bfef02d7dc05d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929411 Commit-Queue: Mila Green <milagreen@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#722570}
-
Jimmy Gong authored
- CupsPrintersList is deprecated in favor of CupsSavedPrinters and CupsNearbyPrinters. Bug: 1005905 Test: Browser tests Change-Id: I3ff1c0cc276e7f846c8b99232478a6cb38d28f5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1938068Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Commit-Queue: jimmy gong <jimmyxgong@chromium.org> Cr-Commit-Position: refs/heads/master@{#722569}
-
Roman Sorokin authored
* Updated according to specs * Removed all manual paper-ripple calculations * Use flex layout for the pin pad TEST=checked for oobe, settings, security pin, multiprofile screen Bug: 1023394 Change-Id: I85978a0d98a2026283af23ae5fcedae68338a085 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950520Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#722568}
-
Oystein Eftevaag authored
BUG=1029465 TBR=crouleau@chromium.org NOTRY=true Change-Id: I123c11915e286e99c001fbf6802b889603c63037 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954732Reviewed-by:
oysteine <oysteine@chromium.org> Commit-Queue: oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#722567}
-
Etienne Bergeron authored
This CL is adding a pre-computed array of indices between text_ and layout_text_. The array contains pair of indices: <text_ offset, layout_text_ offset> Both sequence are ordered (e.g. text_ offsets and layout_offsets_). Previously, a scan 0(n) was made to find the offset (e.g. rank) of the codepoint within the text. There are an assumption that both codepoints had the same offset. Unfortunately, this is not working correctly with text eliding. The current implementation is 0(lg n). This CL is a step towards having a correct support for text eliding and removing the display_text_ phase by integrating it into the layout_text_. The goal is to allow a mismatch between the amount of codepoint in text_ and display_text_. Bug: 1025561 Change-Id: I76a2343b46589f5e9260da0cc60ff6af4ccd8e81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1945277 Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#722566}
-
llin@chromium.org authored
Bug: b/144317438 Test: unit tests Change-Id: Ibd447281a78e05c75a6bd1a681dea12a00c2b8dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954270Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Li Lin <llin@chromium.org> Cr-Commit-Position: refs/heads/master@{#722565}
-
Peter Thatcher authored
Preparing to implement WebCodecs (https://www.chromestatus.com/feature/5669293909868544). Also add an impl of VideoFrame and a skeleton class of VideoDecoder. Bug: 897297 Change-Id: I722ef891c10795e815ce0772b6f1be3afc563d6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946940 Commit-Queue: Peter Thatcher <pthatcher@google.com> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#722564}
-
Kehuang Li authored
Input stream needs to release itself from AudioManager by calling ReleaseInputStream after closing, but CastAudioInputStream didn't, and thus will not be able to create new streams after open/close 16 times. Bug: internal: 144114606 Test: Compile. Change-Id: Ic2ee3e8e5110bee3597380620f06e48731786199 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954450Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Commit-Queue: Kehuang Li <kehuangli@chromium.org> Cr-Commit-Position: refs/heads/master@{#722563}
-
inglorion authored
Sometimes, build or test failures occur in ThinLTO builds that do not occur in non-LTO builds. This change adds some hints on debugging such failures to the Clang sheriffing documentation. R=hans,rnk,thakis Change-Id: Id14456ca4fbae72daa57524dc7119ba520aca988 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955067 Commit-Queue: Bob Haarman <inglorion@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#722562}
-
Elly Fong-Jones authored
These metrics are (per hcarmona@, owner) unused and expired a few milestones ago. Remove the code that gathers them as a first step towards deleting BubbleUi. Bug: 496955 Change-Id: Icd1437093a081b50ee6f03f196259d9056c6204d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1953393Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#722561}
-
Maksim Sisov authored
It must be non-tooltip that closes children windows. Bug: 1028046 Change-Id: I9b5212873cb2c1a4179a28e915edd5fe84b29c5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954483Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#722560}
-
Sebastien authored
Extracted Catalog and HighlightedGames specific logic into their own store instances. The Service class will be in charge of the overall flow, but the specific business logic and caching will reside in these stores. Typical code flow to help reviewers: Client-> GamesServiceImpl->GetHighlightedGame HighlightedGamesStore->SetPendingCallback GamesServiceImpl->UpdateStores CatalogStore->UpdateCatalogAsync GamesServiceImpl->OnCatalogReceived -- Kickoff all feature stores - (i.e. HighlightedGamesStore->ProcessAsync) - These will call their pending callbacks (UI is waiting). GamesServiceImpl->DoneUpdating Bug: 1018201 Change-Id: I6d0625f841fcfa8462d5555c58408405dc352ab5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944268 Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#722559}
-
Matthew Mourgos authored
Bug: 1024636 Change-Id: I3c85ff89dfe152451e29c554a6646811e87b36a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951427Reviewed-by:
Manu Cornet <manucornet@chromium.org> Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Cr-Commit-Position: refs/heads/master@{#722558}
-
inglorion authored
This adds a script which can be used to transform linker command lines that use thin archives into invocations that use the object files referred to from those thin archives. This can be used to debug linker issues, particularly in ThinLTO builds. BUG=877722 R=hans,rnk Change-Id: Ibdebd1c92c85122f7705d68fa9ac46abfe6f3d13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954537Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Bob Haarman <inglorion@chromium.org> Auto-Submit: Bob Haarman <inglorion@chromium.org> Cr-Commit-Position: refs/heads/master@{#722557}
-
Yao Xiao authored
What: UseCounters kThirdPartyServiceWorker/kThirdPartySharedWorker/ kThirdPartyBroadcastChannel considers a frame to be third-party if its origin differs from the top frame. Change it to be based on eTLD+1 comparison instead. Why: eTLD+1 is the more natural delimitation between same-site and not, as it's what is used by cookies and site isolation. Bug: 976866 Change-Id: Ib95881f3aad95af183540869f92ce6f739b4de45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951562 Commit-Queue: Yao Xiao <yaoxia@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#722556}
-
Robbie McElrath authored
This adds restrictions to //aw/gpu and ensures only //aw/browser can depend on network_service.h. Other than these tweaks, the DEPS files were in pretty good shape as-is and already enforced the main rules. Bug: 934152 Change-Id: Id532610dd125e142a7796caeb605a1e50b2287a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954543Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#722555}
-
James Cook authored
Chrome OS SplitSettingsSync has a separate control for syncing OS data types that isn't controlled by the browser's sync-the-feature. Change ModelType::ARC_PACKAGE to run when the transport layer is enabled. Add a check for pref kOsSyncFeatureEnabled so the type is controlled by the OS sync consent. Bug: 1013466 Test: updated sync_integration_tests Change-Id: Ia3b05dde436412c74fe05d8ad40c5053755acdcc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954725 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#722554}
-
Natalie Chouinard authored
Following the naming conventions decided in go/clank-preferences-refactor, this change replaces the "Preferences" suffix with "Settings". Bug: 1030446 Change-Id: I98a2f2b218b29283e9337a45654794bab262e429 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1952031Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#722553}
-
llin@chromium.org authored
Bug: b/144316700 Test: unit tests Change-Id: I00b079c0a66842b48c7afaca3251b15789502cbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1952285Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Li Lin <llin@chromium.org> Cr-Commit-Position: refs/heads/master@{#722552}
-
Jason Chase authored
Configure WebComponents V0 as a "deprecation" trial, and allow it to be enabled in insecure contexts. This does not automatically enable the trial for insecure contexts, rather makes it possible if an appropriate trial token is provided. The origin trials registration process must first issue a token for an insecure origin, which isn't supported yet. For more context, see https://groups.google.com/a/chromium.org/forum/#!topic/blink-api-owners-discuss/HFOi0lmgonY/discussion Bug: 1027546 Change-Id: Iec184f3ba54feb53b7b40b8b8e113b4011b6bbc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1953323 Commit-Queue: Jason Chase <chasej@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#722551}
-
Ahmed Fakhry authored
The active window with applied orientation lock, may move between internal and external displays back and forth (e.g. via keyboard shortcut Search+Alt+M). In this case, the internal display's orientation lock should be refreshed. BUG=1026398 TEST=Added new test. Change-Id: Id0af3726961818cd03579089119c3107190a5e73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951807 Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#722550}
-
Mason Freed authored
With HTML Imports disabled by default, there were no warnings given if a <link rel=import> gets parsed. To aid developers in detecting WCv0 features being used, a warning is now given. Bug: 911943 Change-Id: Ia4be98eae10f8041b3633347ee5336362fea7e6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955791 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#722549}
-
Dale Curtis authored
The element's networkState is used to determine if an element can be GC'd, but it is not reliable prior to readyState kHaveMetadata due to possible side channel attacks for non-media resources. There are three fixes in this patch: 1. Checking src= attribute was unnecessary. Should just trust the response from IsMediaDataCorsSameOrigin() which will either have a WebMediaPlayer and thus a src or will return false. 2. Once the element reaches the kHaveMetadata state it must ensure its networkState matches the WebMediaPlayer's. 3. Don't use |network_state_| but instead the WebMediaPlayer's when checking HasPendingActivity(). The first resolves incorrect state considerations when <source> is used instead of src=. The second ensures the element's network state is properly reflected once metadata is reached. The third ensures that even non-media elements will be GC'd properly. BUG=1025012 TEST=new unittest Change-Id: Idf62093d3ea4833311e6aaefe041e2f073fb8622 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931377Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#722548}
-
Ted Choc authored
BUG= Change-Id: I6ef4f5f9652027844c57e76535577b16cd7b9bbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955174 Commit-Queue: Ted Choc <tedchoc@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#722547}
-
Philip Rogers authored
This patch plumbs the will-change: transform hint to cc::Layer if it is a compositing reason on the immediate transform node. Bug: 1031165 Change-Id: Ifc27d303d48fa957c8f0b4860058dfffabf70262 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1953340Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#722546}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c87235c08e05..981821ef9bd1 Created with: gclient setdep -r src-internal@981821ef9bd1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I1bec8a6f6a718ef83e71289f7bc48e4ed3a4ea40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955795Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#722545}
-
David Bokan authored
This is redundant and confusing with current_native_scrolling_element. This CL replaces uses of current_native_scrolling_node by using current_native_scrolling_element. However, I believe the functionality isn't necessary at all. A future CL will refactor the code to not rely on setting this value at all. Bug: 1016229 Change-Id: I92e915093907b7fe48fbed34c8fa8c961f733441 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1952829Reviewed-by:
Majid Valipour <majidvp@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#722544}
-
Mark Schillaci authored
This CL adds a new test case for a html structure with a link that has a nested structure. This adds the expected outputs for auralinux and blink, and updates some README files to be more descriptive and to update them to be in-line with current test names. Added a basic nested structure for <a href> links for future test case. Added test case for the nested structure a link html. Generated expected results for new nested structure <a href> tests. Ran code formatter to complete checklist before raising CL. Updated README to fix typo and incorrect command, added more info. Updated tests.md readme to fix same typo as in unit_test readme file. R=dmazzoni Bug: 1018555 Change-Id: Ibdea155e586d7b4c00fa31b86d6209f1f63b0195 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951781Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Mark Schillaci <mschillaci@google.com> Cr-Commit-Position: refs/heads/master@{#722543}
-
Darin Fisher authored
Avoids a UAF by disconnecting the mojo::Receiver and mojo::Remote from the pre-finalizer. Bug: 1016574 Change-Id: Icdbba0e7798a93318df9931b4f1fe9004b6b8501 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1952085Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Darin Fisher <darin@chromium.org> Cr-Commit-Position: refs/heads/master@{#722542}
-
Caleb Raitto authored
This link never pointed to the correct destination. Change-Id: I99f95d13fb336b5306dd745f66a7cc23f80de2a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955327Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#722541}
-