- 08 Jun, 2020 40 commits
-
-
Corentin Wallez authored
Bug: 1069302 Change-Id: Ib8c2e8c3f38ccaf1699f7f368b34f39c1be41d90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225406Reviewed-by:
Austin Eng <enga@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#776110}
-
Peter Wen authored
Since android_lint is only run for android_apk and android_app_bundle targets, there is no longer a need for a project-wide override. Targets that specify their own lint suppressions file can specify it as a gn variable when they use the android_apk or android_app_bundle templates. Also support embedders passing their own lint_suppressions_dep if their lint suppressions file is generated. See: https://crrev.com/c/2232580 Passed through the necessary args so that embedders using chrome_public_apk can easily pass in lint_suppressions_* variables. Bug: 1082743 Change-Id: Idcb2f40d1fa529398a6f942e1c0687608c5dffb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235463 Commit-Queue: Peter Wen <wnwen@chromium.org> Auto-Submit: Peter Wen <wnwen@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#776109}
-
Juan Pablo de Lima authored
$ can be defined differently depending on this file's execution and cannot guarantee consistency. Bug: 1083145, b:157634877 Change-Id: I3b5d0577f7abaf6f58a3c6715e93537456ec8414 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235932 Commit-Queue: Juan Pablo De Lima <jpdelima@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#776108}
-
Becca Hughes authored
Disables Media Feeds on Android because they are desktop only and caused a large binary size regression. BUG=1070720 Change-Id: If7afe1f62524d84b93951c1dc8bf4c955c5128a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231701Reviewed-by:
Tommy Steimel <steimel@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#776107}
-
David Bertoni authored
The DownloadExtensionTest_Download_UnsafeHeaders test was disabled for flakiness on Windows. It passed 3000 iterations on the bots without any issues. See run results here: https://ci.chromium.org/p/chromium/builders/try/win10_chromium_x64_rel_ng/575382 https://ci.chromium.org/p/chromium/builders/try/win_chromium_dbg_ng/3267 Bug: 248438 Change-Id: Ide364a95ee8818f413b81fe82a992c28a02bb61a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227389Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#776106}
-
Evan Stade authored
Bug: 1007826 Change-Id: I5f12d7453fd7a5f8c3ea7bb756a6f735ec7759aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225789 Commit-Queue: Joe Downing <joedow@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#776105}
-
Aya ElAttar authored
Added another PolicyMap::Set to override the old one to switch from passing value as unique_ptr to base::Value. Bug: 1092469 Change-Id: I3b87af2302ce7009e73d910d59bef1c9d4931fc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235792 Commit-Queue: Aya Elsayed <ayaelattar@google.com> Auto-Submit: Aya Elsayed <ayaelattar@google.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#776104}
-
Antonio Gomes authored
... instead of WebMediaStreamTracker. This is part of the effort to reduce the needless use of public Blink APIs (wrappers) within renderer/modules. Note that an explicit conversion to WebMediaStreamTrack is added because the call crosses the Blink API boundary. BUG=704136 R=guidou@chromium.org Change-Id: I1d9d5473bab5d1e0254b1992c248d1c517c8c2df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236034 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#776103}
-
Joshua Pawlicki authored
Background: there are two extension updaters in Chrome: the update_client updater (new) and the extension_downloader client (old). Prior to this change, changing the extension updater URL would effectively disable the update_client-based updater and the extension_downloader client would take over. This makes it impossible to use the update_client updater with non-prod or local copies of CWS. A user/attacker with control over Chrome's command line can redirect the extension update check to a server of their choice. Furthermore, CUP is disabled for this transaction (because the target server presumably does not have the pinned CUP private key). This is not expected to have any tangible security impact, because: 1 - Prior to this change, the extension_downloader updater would still redirect the request, and extension_downloader doesn't use CUP anyways. 2 - Activating this feature requires attacker presence on-disk or a confused user. 3 - A MITM attacker must also compromise TLS to subvert the update check. 4 - The updater will still only accept properly-signed CRX files as update payloads, even if an attack establishes control of the update check. Bug: 1077122 Fixed: 1077122 Change-Id: I4a9169f2741900906bfa63da40196aa0f887e70a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2180862 Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#776102}
-
Jian Li authored
Bug: none Change-Id: Ia397468378c7a94d04024fb3f444995c1003efea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2234548Reviewed-by:
Dan H <harringtond@chromium.org> Commit-Queue: Jian Li <jianli@chromium.org> Cr-Commit-Position: refs/heads/master@{#776101}
-
Alexander Dunaev authored
This CL introduces the unified drag image support, so any Ozone platform that can provide absolute coordinates during the drag can use it. Bug: 1014860 Change-Id: I2abb6bf6ce5851611c0163a4f41ba9bc50b9eadc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2195245 Commit-Queue: Alexander Dunaev <adunaev@igalia.com> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#776100}
-
Ben Wagner authored
Skia is moving the code about to make it easier to manage. There should be no functional changes. Change-Id: I4f7284fa278638ad05f1fd4772a0abc12ddd4f83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232883Reviewed-by:
Mike Klein <mtklein@google.com> Commit-Queue: Ben Wagner <bungeman@chromium.org> Cr-Commit-Position: refs/heads/master@{#776099}
-
Christian Dullweber authored
The views appear in the order they are defined in this list. The list doesn't quite match the UI, so it looks a bit weird if many items fade in. Change-Id: Ibcc1325af5e5a83107c4d3dc7b494accc4955f58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235813 Auto-Submit: Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#776098}
-
David Bertoni authored
The DownloadExtensionTest_AcceptDanger test was disabled on MAc for flakiness, but passed 3000 iterations on the bots. The test remains disabled on debug builds, where it still times out occasionally. Bug: 180759 Change-Id: I354d24e3f07406ead9e64a49da968d0e0efea60f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229460 Commit-Queue: David Bertoni <dbertoni@chromium.org> Reviewed-by:
-
Martin Kreichgauer authored
Bug: 1087158 Change-Id: Id8bcbe5d4e806264521ffaffddb3457b075102d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229336Reviewed-by:
Nina Satragno <nsatragno@chromium.org> Commit-Queue: Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#776096}
-
Nina Satragno authored
Deflake AuthenticatorDialogTest.InvokeUi_inline_bio_enrollment. If the timer fired between the dialog being destroyed and the test being destroyed, we had a use-after-free of the raw pointer to the model. Solve this by using a WeakPtr. Additionally, if the current step changed by e.g. a user running the test interactively, we hit a DCHECK on OnSampleCollected since the current step was no longer inline bio enrollment. Fix this by checking the current step before running the callback. This fix is okay since the main point of this test is to run interactively to try the UI and as a basic sanity check. Fixed: 1092314 Change-Id: I5cec125de3a921df8b7e7a44d5cb1feedf634f4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235979 Commit-Queue: Nina Satragno <nsatragno@chromium.org> Commit-Queue: Martin Kreichgauer <martinkr@google.com> Auto-Submit: Nina Satragno <nsatragno@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#776095}
-
Elly Fong-Jones authored
This change: 1) Introduces a convenience method on WidgetDelegate: SetHasWindowSizeControls(), which sets whether a window has maximize, minimize, and resize controls. 2) Removes many overrides of CanMaximize, CanMinimize, and CanResize, replacing them with uses of explicit setters 3) Removes two now-unnecessary WidgetDelegate subclasses :) Bug: 1075649 Change-Id: Ib8b4fea3080627b8292c784d932b742ce7dd9682 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228988 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#776094}
-
Daniel Rubery authored
This CL changes the word GetThreatTypeStringForInterstitial to match the discussed strings. Fixed: 1088075 Change-Id: Ic512b40aa6fcc8c928617c56e793e00f7f3d008a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233197Reviewed-by:
Carlos IL <carlosil@chromium.org> Reviewed-by:
Marc-André Decoste <mad@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#776093}
-
Sigurdur Asgeirsson authored
This is a followup to http://crrev.com/c/2231265, where I missed Chris' comment on this staleness in the PageNode declaration. Change-Id: I9e678a3f9f27c5b9afc5357985b59f8d947a9b4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236012 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#776092}
-
Liviu Tinta authored
When mouse is locked there is a separate code path for wheel events. This patch attempts to unify the two paths. Bug: 1063722 Change-Id: I80d92a5a08757cd579ff9278923cfff79a282680 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233760 Commit-Queue: Liviu Tinta <liviutinta@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium bb1cd875. With Chromium commits locally applied on WPT: 9c24e63c "Check for first frame in CreateImageBitmap" 101c532f "[css-lists] Fix list image gradient with dynamic zoom" a8a28083 "[Security][Coop] Browsing context switch reporting WPT" c72a3e27 "Mark some idlharness.html tests as timeout=long" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=foolip@google.com No-Export: true Change-Id: Ibdd2e64fa5e882ad40748b8589220f86a0be6331 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235873Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#776090}
-
Theresa Wellington authored
This reverts commit 8d0c0625. Reason for revert: Caused crash PS 1 -> 3 includes some updates needed to accommodate changes in https://chromium-review.googlesource.com/c/chromium/src/+/2230422. Original change's description: > Android: Use ActivityTabTabObserver in FulscreenManager > > This CL replaces TabModelSelectorTabModelObserver with > ActivityTabTabObserver for keeping the current tab up to date. > > Bug: 966272 > Change-Id: I817bdd27cc09b1848574f833820c4d219b0a8b81 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215762 > Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> > Reviewed-by: Theresa <twellington@chromium.org> > Cr-Commit-Position: refs/heads/master@{#774953} TBR=twellington@chromium.org,mdjones@chromium.org,jinsukkim@chromium.org Bug: 966272, 1092390 Change-Id: I07a2b3edaba1f1a9f14713731b916770b1cd575b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236093Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#776089}
-
Samuel Huang authored
With the addition of ToGNString(pretty=True) (crrev.com/c/2231505), .info files can be pretty printed. Since .info files are committed into upstream and downstream repos, so we'll need to regenerate these files, and commit them (with multiple CLs). However, during Android Chrome build aar.py is called with the flag --assert-file-info to ensure .aar files are consistent with existing .info files, by regenerating .info data, followed by direct string comparisons. To facilitate migration, this CL weakens --assert-file-info by removing all whitespaces before comparison. This is temporary; the CL will be reverted once migration completes. Bug: 1074446 Change-Id: I1633410267190a5c59b72bd52f58c86e6210463f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235973Reviewed-by:
-
Peng Huang authored
Bug: 1092445 Change-Id: I72ee95f2614e140841317873e26fb247222e5c21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236033Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#776087}
-
Abigail Klein authored
Introduce a reply to the OnTranscription function of the live caption mojom interface. The reply is a boolean of success which denotes whether the browser successfully received, routed, and set the transcription result. If there was not success, because the caption bubble was closed, the browser was closed, or the associated web contents did not match an existing browser with a caption bubble, then the OnTranscription mojo function returns false, causing speech recognition to stop. Bug: 1055150 Change-Id: I8c8e0b443c8c90afa78e85e81e3ca7cda8a49920 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225878Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Katie Dektar <katie@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Commit-Queue: Abigail Klein <abigailbklein@google.com> Cr-Commit-Position: refs/heads/master@{#776086}
-
Francois Doray authored
In https://crrev.com/c/2171976, we forgot to check if the IntensiveWakeUpThrottling feature was enabled in the code. This CL adds the check and a test to prevent this from happening again. Bug: 1075553 Change-Id: I5c669a62ce56aa32c08d57d0929c6e52aa0f05c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233016 Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
-
Olesia Marukhno authored
Fix spacing between icon and text. Fix icon jumping to the right and back while animating. Make chip focusable. Fix browser crash on a tab close when chip is opened. Fix ink drop happening after click with opened bubble. Fix issues with on click doesn't opening chip (after long hover or after clicking away) Bug: 1019129 Change-Id: I0f48fbec87609a2d5b4992162c4c7346d154bd43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230470 Commit-Queue: Olesia Marukhno <olesiamarukhno@google.com> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#776084}
-
Dan Zhang authored
https://quiche.googlesource.com/quiche.git/+log/1a5d09ce1b89..8212c45924e3 $ git log 1a5d09ce1..8212c4592 --date=short --no-merges --format='%ad %ae %s' 2020-06-05 renjietang Remove Mocking of QuicSession::OnZeroRttRejected() because the implementation is now available. 2020-06-05 vasilvv Rename QuicheNullOpt to QUICHE_NULLOPT 2020-06-05 fayang Automated g4 rollback of changelist 314796960. 2020-06-05 nharper Remove no-op code in tlsserverhandshaker, not flag protected Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src update flags R=dschinazi@chromium.org Change-Id: I0c01638f846841bacf25c42e00eaccb3ad7dc6cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232771 Commit-Queue: Dan Zhang <danzh@chromium.org> Auto-Submit: Dan Zhang <danzh@chromium.org> Reviewed-by:
David Schinazi <dschinazi@chromium.org> Cr-Commit-Position: refs/heads/master@{#776083}
-
Henrique Nakashima authored
Bug: 1090033 Change-Id: I7304f61d3d20a48b00bcef3618c64ffbce21a002 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231557Reviewed-by:
-
Caitlin Fischer authored
The status quo test relies on a series of UI helpers to clear browsing history. The re-enabled test doesn't use UI helpers; it relies on an EG2 helper for clearing the history. Also, removes a bunch of unused includes and using declarations. Bug: 866598 Change-Id: I9de2b9ffdd303df0f2c2073788cd4ea3a59e398f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208914 Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#776081}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ib4e96b8f188db1280a389b9afe8ef7ccc1e9c4f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2234715Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#776080}
-
Adam Langley authored
PublicKey is now just a constant-once-created struct, it doesn't need accessors, which are a hang-over from its prior life as an interface. Also, this works around a crazy-making Android bug (b/158406273). Change-Id: I91338c07cc6b57db36b82c2e3bb1339d0d57340d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2234543 Commit-Queue: Martin Kreichgauer <martinkr@google.com> Auto-Submit: Adam Langley <agl@chromium.org> Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I6e5155235e1914016ac38f85ca4255d642043834 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235639Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/6e659e960945..00a96f2c994c 2020-06-08 fmalita@chromium.org [skrive] Initial parser plumbing 2020-06-08 egdaniel@google.com No longer move queue index of VkImage back to initial state on release. 2020-06-08 herb@google.com calculate text color closer to use 2020-06-08 michaelludwig@google.com Handle color and stencil clears in GrClearOp 2020-06-08 herb@google.com Remove unused fColor from GrTextBlob If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bungeman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: bungeman@google.com Change-Id: Ia03ae2cf3683752f6734f1189001c54b4afb55b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235952Reviewed-by:
-
Philip Rogers authored
This patch removes redundant checks from LayoutBox::LayerTypeRequired: 1) LayoutObject::HasTransformRelatedProperty has been removed because a call to ComputedStyle::HasTransformRelatedProperty is already included in IsStackingContext. The LayoutObject and ComputedStyle functions are not equal (e.g., for LayoutInline), but they are equal for LayoutBox. 2) LayoutObject::HasReflection has been removed because it is included in LayoutObject::CreatesGroup. 3) ComputedStyle::ShouldCompositeForCurrentAnimations has been removed because it is included in LayoutObject::IsStackingContext. A stale comment from 2015 about hasAutoZIndex has also been removed, since this is now in IsStackingContext. "IsPositioned() || IsStackingContext" has been replaced with a call to IsStacked(). Bug: 1068596 Change-Id: Ifb05c4ff5536011ccff6271277d6eaba6a230554 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2234123Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#776076}
-
Benoit Lize authored
Bug: 1029320 Change-Id: I450c862befb0cad619e1849bcd124c6058f98813 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235618Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#776075}
-
Dave Tapuska authored
This is a precursor to moving input handling into blink. Expose the switches and features that will be read in blink from blink. BUG=1073560 Change-Id: I492dabe30b307fc3288160e17952dc3c1a0b14f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232804Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#776074}
-
Xi Han authored
In this CL, we introduce an additional state in InflationObserver: onInflationComplete. This event happens between onPreInflationStartup and onPostInflationStartup, thus provides a way to split the implementation of onPostInflationStartup into two methods. In RootUiCoordinatior, the ToolbarManger is created in onInflationComplete, and ChromeTabbedActivity calls showOverview() after RootUiCoordinatior#onInflationComplete but before initializing other components in onPostInflationStartup. Thus, ToolbarManager setups an OverviewModeObserver and won't lose any early events that an overview is shown or overview mode is changed. Bug: 1077022 Change-Id: I6bc8b96906a9519a928c6490bec0ca158b3d6241 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2181667Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Ender <ender@google.com> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#776073}
-
Sebastien Lalancette authored
The logic it added (adding a Cancel button) was moved to ActionSheetCoordinator. Moving that logic also allows cleaning-up duplicate logic for adding a cancel button. Added unit tests to cover the new logic in ActionSheetCoordinator. Change-Id: I2e0871d1be885e09f472729a5f342659eaa6e192 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220069 Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#776072}
-
Mario Sanchez Prada authored
This CL migrates these two legacy IPC messages out of frame_messages.h and view_messages.h to LocalFrameHost and {Local,Remote}MainFrameHost mojo interfaces from Blink. Normally, we would have migrated the two messages in separate CLs, but I'm doing it in one CL to simplify the process since that way we can remove RenderViewImpl::DidFocus() in one go, which I think makes the patch clearer and cleaner. An important part of this CL is the introduction of a mojo interface named RemoteMainFrameHost, needed because in some cases the renderer will make sure that the Focus() request gets initiated from the topmost frame (e.g. see DOMWindow::focus()), and such frame would be a remote frame in the case of OOPIFs. So, the ViewHostMsg_Focus IPC method has been migrated both into the pre-existing LocalMainFrameHost interface and into the newly added RemoteMainFrameHost interface, and Blink will make sure to route the message through the correct channel depending on whether the renderer's main frame is a LocalFrame or a RemoteFrame. Another subtlety of this CL is that we need to still keep the call to web_view_->Client()->DidFocus() from ChromeClientImpl being always run whenever Frame::FocusPage() is called for testing purposes, so that the override of WebViewClient::DidFocus() in ViewCreatingWebViewClient will still work after this migration. Last, this CL also renames RenderFrameHostDelegate::DidCallFocus() into DidCallFocusOnPage() to make it clearer that what that method reports is that a given frame has called focus() over a page, and not that such frame got focused. Bug: 1047461, 1083393 Change-Id: Ie6bf56fbcf9c689c88597e3f83098c5b7d2f2513 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224858Reviewed-by:Aaron Colwell <acolwell@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#776071}
-
