- 09 Dec, 2016 36 commits
-
-
mek authored
This revision contains a fix to the "bind_hostname" functionality that makes it possible to use that, rather than incorrectly overriding the "host" config to an ip-address. This fixes {{host}} and things like {{domains[www]}} substitutions for tests when run with wptserve. BUG=618616 Review-Url: https://codereview.chromium.org/2563823002 Cr-Commit-Position: refs/heads/master@{#437430}
-
piman authored
BUG=None CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2541843004 Cr-Commit-Position: refs/heads/master@{#437429}
-
qyearsley authored
Reason: the path_delimiter is different between gtest results and layout tests; in https://sites.google.com/a/chromium.org/dev/developers/the-json-test-results-format it has been suggested for some time that path_delimiter should be required. BUG=672361 Review-Url: https://codereview.chromium.org/2559983003 Cr-Commit-Position: refs/heads/master@{#437428}
-
khmel authored
There is new requirement for buttons in Arc OOBE OptIn page. Skip and Agree buttons must be grayed until ToS is loaded. Once ToS is loaded both are enabled and 'Agree' button has the focus. This also moves focus to 'Retry' button in case of ToS loading failure. TEST=Manually on device. BUG=672145 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2565573002 Cr-Commit-Position: refs/heads/master@{#437427}
-
ssid authored
The sqlite memory usage was being reported under "sqlite" column. After this CL the sql databases opened by DOM storage will be shown under the "dom_storage" column. This is done by adding an ownership edge (implemented in sql::Connection::ReportMemoryUsage). BUG=605785 Review-Url: https://codereview.chromium.org/2548063002 Cr-Commit-Position: refs/heads/master@{#437426}
-
qyearsley authored
Context: See http://crrev.com/2557593006. Review-Url: https://codereview.chromium.org/2556723007 Cr-Commit-Position: refs/heads/master@{#437425}
-
eroman authored
BUG=671799 Review-Url: https://codereview.chromium.org/2559593002 Cr-Commit-Position: refs/heads/master@{#437424}
-
mstensho authored
BUG=670846 Review-Url: https://codereview.chromium.org/2560073002 Cr-Commit-Position: refs/heads/master@{#437423}
-
changwan authored
Since ImeThread and its ThreadedInputConnection implementation are rolled out to stable, there is no need to keep ReplicaInputConnection and related logics in renderer. Note that this just removes dead code and is purely mechanical. Polish up around ChangeSource will be handled in a separate CL. BUG=662279 Review-Url: https://codereview.chromium.org/2553923002 Cr-Commit-Position: refs/heads/master@{#437422}
-
reed authored
skia cl https://skia-review.googlesource.com/c/5718/ BUG= Review-Url: https://codereview.chromium.org/2564643002 Cr-Commit-Position: refs/heads/master@{#437421}
-
catapult-deps-roller authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/3838eb5d96b7..0b7222ff3002 $ git log 3838eb5d9..0b7222ff3 --date=short --no-merges --format='%ad %ae %s' 2016-12-08 rnephew [Devil] Add bus and device logging when failing to reset USB. 2016-12-08 benjhayden Add histogram-set-json-format.md. 2016-12-08 aiolos Remove unused reference_build from Chrome binaries. 2016-12-08 lpy [Trace Viewer] Add support for V8 IC statistics. BUG=672480 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=catapult-sheriff@chromium.org Review-Url: https://codereview.chromium.org/2552973006 Cr-Commit-Position: refs/heads/master@{#437420}
-
mdjones authored
This change replaces the concept of sizing flags, which control both viewport size and browser controls behavior, with mutually exclusive modes: - ALWAYS_FULLSCREEN - ALWAYS_SHOWING_BROWSER_CONTROLS - DYNAMIC_BROWSER_CONTROLS - USE_PREVIOUS_BROWSER_CONTROLS_STATE Permanent android browser controls state can be changed by overriding two functions in the layout class: - forceShowBrowserControlsAndroidView() - forceHideBrowserControlsAndroidView() These modes and functions reduce the amount of research that needs to be done to understand how a particular layout is going to behave. BUG=670459 Review-Url: https://codereview.chromium.org/2549503004 Cr-Commit-Position: refs/heads/master@{#437419}
-
dschuff authored
Previously, Shutdown would kill the loader by closing the SRPC command channel. After SRPC removal, it became a no-op. But this caused a deadlock in some cases where surfaway or embed element removal would cause the PNaCl translator to block waiting to join the translation thread while the translator nexe was waiting for more data. This change makes the original shutdown sequence work as intended by making ServiceRuntime::Shutdown() close the trusted plugin IPC channel, which causes the service runtime to immediately exit. 1. This pokes a sort of arbitrary hole in the PPBNaClPrivate interface but that interface is vestigial anyway. 2. Even aside from PPBNaClPrvate, there is a lot that could be simplified or refactored about shutdown post-SRPC, but this is a minimal change to fix the deadlock that users are experiencing, so we can get it on a branch. R=bbudge BUG=645688 Review-Url: https://codereview.chromium.org/2556983003 Cr-Commit-Position: refs/heads/master@{#437418}
-
pdfium-deps-roller authored
https://pdfium.googlesource.com/pdfium.git/+log/53ed03d9d865..94afac986c9d $ git log 53ed03d9d..94afac986 --date=short --no-merges --format='%ad %ae %s' 2016-12-08 tsepez Replace CFX_WideStringCArray with std::vector. 2016-12-08 dsinclair Change layout item in CFWL_Widget type from void 2016-12-08 dsinclair Cleanup CFWL_Widget code to return CFX_RectFs where appropriate Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls TBR=dsinclair@chromium.org Review-Url: https://codereview.chromium.org/2558173005 Cr-Commit-Position: refs/heads/master@{#437417}
-
jschuh authored
Remove a bad comment left behind from crrev.com/437342 TBR=scottmg R=scottmg NOTRY=true Review-Url: https://codereview.chromium.org/2562643005 Cr-Commit-Position: refs/heads/master@{#437416}
-
rune authored
Added pseudoStateChanged calls for those pseudos where we already did so for :valid and :invalid. R=tkent@chromium.org BUG=671745 Review-Url: https://codereview.chromium.org/2556423002 Cr-Commit-Position: refs/heads/master@{#437415}
-
stevenjb authored
This is already fixed in MD Settings, but somehow the fix never made it to Options. BUG=671376 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2562783002 Cr-Commit-Position: refs/heads/master@{#437414}
-
robertogden authored
BUG=669956 Review-Url: https://codereview.chromium.org/2559113005 Cr-Commit-Position: refs/heads/master@{#437413}
-
nparker authored
[Other modes are V3Only (or Control) and V4Hybrid.] V4Only mode is when Chrome uses only PVer4 implementation for all SafeBrowsing operations. V3Only (or Control): When Chrome uses the existing PVer3 implementation for all SafeBrowsing operations. V4Hybrid: When Chrome uses PVer4 implementation for some SafeBrowsing operations. Namely, CheckBrowseUrl. For details, see https://docs.google.com/document/d/1fA3tvcTRtYOV5dNMst45OE6RXTr_cCtNsZijhB6bGL0/edit#heading=h.c2drkrmajbam This is 98% vakh's CL. BUG=543161 patch from issue 2533993004 at patchset 140001 (http://crrev.com/2533993004#ps140001) Review-Url: https://codereview.chromium.org/2561053002 Cr-Commit-Position: refs/heads/master@{#437412}
-
pavely authored
This change enforces the check in ModelTypeWorker::AdjustCommitProto ensuring that id is set to valid string. R=maxbogue@chromium.org BUG=672100 step Review-Url: https://codereview.chromium.org/2562673003 Cr-Commit-Position: refs/heads/master@{#437411}
-
wangxianzhu authored
These benchmarks were added in https://codereview.chromium.org/2557483002/. They will live for about 1 month until we enable SlimmingPaintInvalidation by default. The benchmarks are also enabled on fyi perf bots in crrev.com/2562753002. BUG=646176 Review-Url: https://codereview.chromium.org/2559643005 Cr-Commit-Position: refs/heads/master@{#437410}
-
rch authored
Review-Url: https://codereview.chromium.org/2566473002 Cr-Commit-Position: refs/heads/master@{#437409}
-
jamescook authored
Ash only ships on Chrome OS, so simplify our BUILD.gn files by removing all the is_win and is_chromeos conditionals. TODO: ash/resources/BUILD.gn. Right now chrome/browser/ui has a dependency on ash resources for aura builds on all platforms. BUG=666776 TEST=bots Review-Url: https://codereview.chromium.org/2559713003 Cr-Commit-Position: refs/heads/master@{#437408}
-
xiyuan authored
SessionController serves as an interface to maintain a session info cache in ash. SessionControllerClient runs on the other side where session manager code runs (chrome) and update SessionController with session info. They are targeted to replace SessionStateDelegate to use in both mash and classic ash. BUG=648964,496761 Review-Url: https://codereview.chromium.org/2545723003 Cr-Commit-Position: refs/heads/master@{#437407}
-
tyoshino authored
The patch https://codereview.chromium.org/2284473002/ was basically a refactoring change, but it also included a change that it started using the InterfaceProvider instance of the LocalFrame of the associated Document if any. However, in a service worker, the LocalFrame returns the empty provider obtained by calling InterfaceProvider::getEmptyInterfaceProvider(). This is because the WebEmbeddedWorkerImpl used for service workers doesn't override the WebFrameClient::interfaceProvider() method which returns nullptr by default while one on the WebSharedWorkerImpl and RenderFrameImpl returns an effective InterfaceProvider instance. This patch fixes the issue by changing the code to use the InterfaceProvider of the LocalFrame only when it's not the empty provider. R=falken@chromium.org TBR=yhirano@chromium.org BUG=671588 Review-Url: https://codereview.chromium.org/2564493002 Cr-Commit-Position: refs/heads/master@{#437406}
-
dtseng authored
Static text nodes > 1500 characters should not be visited during object navigation. Rather, ChromeVox should descend into their inline textboxes. This makes users who want to navigate large text documents loaded into Chrome by either line or object not encounter issues. BUG=671448 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2557713003 Cr-Commit-Position: refs/heads/master@{#437405}
-
azurewei authored
Use keyboard + ChromeVox to operate on opt-in IME menu, the current behavior is: 1) Use 'Tab' key to switch the focused items 2) When the item is focused, ChromeVox will speak '{IME name} Chreck box {Checked/ Not checked}'. 3) Use 'Enter' key to selected the focused item, system will switch IME and close the opt-in IME menu. This CL adds more support the to current behavior: 1) 2) keeps the same. 3) Use 'Enter' key to selected the focused item, system will switch IME and focuses to the new selected IME with spoken feedback '{IME name} Chreck box Checked'. Since the ImeListView will create new items when getting IME refreshing event, we need to save the item selected by 'Enter' key and focuses to it when the view is updated. BUG=642423 TEST=Verified on local build. Review-Url: https://codereview.chromium.org/2560793002 Cr-Commit-Position: refs/heads/master@{#437404}
-
sgurun authored
It seems method implementation does not exist but method is not declared as pure virtual. Review-Url: https://codereview.chromium.org/2564693002 Cr-Commit-Position: refs/heads/master@{#437403}
-
ajuma authored
GLRenderer::CanPassBeDrawnDirectly checks if a pass' only quad is positioned at (0, 0) in pass space, but this doesn't guarantee that the quad will be positioned at the top left corner of the pass' texture, since the pass' own texture isn't necessarily positioned at (0, 0) in pass space. In this situation, using the quad's texture in place of the pass's texture results in incorrect positioning of the quad's contents. To fix this, this CL adds a check that the quad rect matches the pass' output rect. BUG=671773 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2558393002 Cr-Commit-Position: refs/heads/master@{#437402}
-
lukasza authored
Before this CL, we tried to keep renaming |begin| -> |Begin| (and similarily for |end|, |rbegin|, |rend|) if the return type contained "iterator" in the typename. Unfortunately this meant that some undesired renamed were still happening (see the bug for more details). After this CL we will unconditionally avoid renaming |begin| (and |end|, |rbegin|, |rend|). We can do this rename where needed manually, after the "big rename" is done and sticks. BUG=672353 Review-Url: https://codereview.chromium.org/2564663002 Cr-Commit-Position: refs/heads/master@{#437401}
-
dcastagna authored
So far the only client using linux-buffer-params interface has only been wayland_motion_client that allocates only RGB buffers. A new wayland test client that uses linux-buffer-params and produces YUV formats is in the works. This CL adds NV12 to linux-buffer-params. It additionally removes the check that the fds coming from wayland are valid, since wayland guarantees that already. BUG= Review-Url: https://codereview.chromium.org/2543633005 Cr-Commit-Position: refs/heads/master@{#437400}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/9dc864b2..46bd8103 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2566543002 Cr-Commit-Position: refs/heads/master@{#437399}
-
yizhou.jiang authored
Add entries for windows, chromeos, and linux mesa in gpu_driver_bug_list. Generate shaders according to different gl contexts. BUG=634519 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2548363002 Cr-Commit-Position: refs/heads/master@{#437398}
-
wangxianzhu authored
The timer and slider may be different causing flakiness. Mask out the timer and slider. BUG=667953 NOTRY=true TBR=qinmin@chromium.org Review-Url: https://codereview.chromium.org/2555373005 Cr-Commit-Position: refs/heads/master@{#437397}
-
tbansal authored
Add default estimates for different connection types in the network quality estimator (NQE). Putting the estimates in the src code itself makes them accessible for Cronet embedders, and simplies the field trial configs. Additionally, RTT and throughput observers are notified of the default observations as soon as they are added CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester BUG=638304 Review-Url: https://codereview.chromium.org/2481373004 Cr-Commit-Position: refs/heads/master@{#437396}
-
alancutter authored
Fix Revert of Make InvalidatableInterpolation's InterpolationTypes decided at effect application time The revert in https://codereview.chromium.org/2567453002/ was not successful at fixing the compile. This is due to old file deletions being added back again with old content resulting in continued compile failures. This patch fixes up the replaced file to be more compile friendly. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=671904 TBR=scottmg@chromium.org Review-Url: https://codereview.chromium.org/2559393002 Cr-Commit-Position: refs/heads/master@{#437395}
-
- 08 Dec, 2016 4 commits
-
-
meade authored
This prevents naming conflicts in the blink namespace, which could have unexpected results. Review-Url: https://codereview.chromium.org/2552893006 Cr-Commit-Position: refs/heads/master@{#437394}
-
alancutter authored
Revert of Make InvalidatableInterpolation's InterpolationTypes decided at effect application time (patchset #3 id:40001 of https://codereview.chromium.org/2555923003/ ) Reason for revert: Broke the mac compile bot: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac%20Builder%20%28dbg%29/builds/180366/steps/compile/logs/stdio Original issue's description: > Make InvalidatableInterpolation's InterpolationTypes decided at effect application time > > This patch replaces PropertyInterpolationTypesMapping with CSS and SVG > InterpolationTypesMap classes that are provided to InvalidatableInterpolation > objects via the InterpolationEnvironment. > > InvalidatableInterpolations are no longer provided with the list of > InterpolationTypes at construction, now they retrieve the list at effect > application time during applyStack(). > > This is in preparation for supporting smooth animation of registered > custom properties. > > BUG=671904 > > Committed: https://crrev.com/3ac8b90fcbda4c6e3ef484140751cd0341b31c48 > Cr-Commit-Position: refs/heads/master@{#437381} TBR=ericwilligers@chromium.org,timloh@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=671904 Review-Url: https://codereview.chromium.org/2567453002 Cr-Commit-Position: refs/heads/master@{#437393}
-
tommycli authored
BUG=669853 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2555373003 Cr-Commit-Position: refs/heads/master@{#437392}
-
reveman authored
This adds the ability to use service side window decorations for shell surfaces. XDG shell surfaces require client side decorations like before but wl_shell_surfaces are now using service side decorations. The surface bounds logic has been improved to support a client view that is not at the origin of the widget and resize logic is now working correctly when interactive resize is not initiated by the client. BUG= TEST=exo_unittests Review-Url: https://codereview.chromium.org/2548653005 Cr-Commit-Position: refs/heads/master@{#437391}
-