GitLab

They are PasswordManager.PasswordDropdownShown and
PasswordManager.PasswordDropdownItemSelected. The data can be useful for other
platforms.

Bug: 967497
Change-Id: Id834e8096ecf321440a6fde2c4a3bca064e09e32
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634870
Commit-Queue: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664373}

If the omnibox is showing in tab switcher mode, fade out the tab
switcher toolbar when the url bar gains focus. Ideally, this would
be done on text change (!isEmpty) but the TopToolbarCoordinator
has no observer for text changes.

R=yusufo@chromium.org

Bug: 967961
Change-Id: I962f51d3247bf2cc936343988e2ff497b5a74fd4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635352Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Commit-Queue: Matt Simmons <mattsimmons@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664372}

BEST_EFFORT tasks will not run until after startup and only if there is no
critical work pending.

This patch should not change the current behaviour. Please double check
whether the task being posted via BrowserThread::PostAfterStartupTask
really cares about being run after startup or just wants to run after
any critical work was completed. If you are fine with it just running
after critical work has completed LGTM and keep on with your life. If
that is not the case let me know and please explain your reasoning in a
comment.

More details:
https://docs.google.com/document/d/1P8PV1qX2cOR2WRFD6v9CjygJkE_mftCtJ7BoqQHCKZI

This CL was uploaded by git cl split.

R=isherman@chromium.org

Bug: 887407
Change-Id: Ifa246b5010783a683b041675dcd5422783bac3c0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631703Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Ilya Sherman <isherman@chromium.org>
Auto-Submit: Carlos Caballero <carlscab@google.com>
Cr-Commit-Position: refs/heads/master@{#664371}

overview: Avoid ending overview because of window activation change while an overview item is being dragged

The present CL aims to address a problem similar to [1]. [2] addresses
[1] by modifying OverviewSession:OnWindowActivating() to avoid ending
overview while there exists a window in a dragged state. That solution
is fine for workflows where a window is dragged from the top in tablet
mode, but there is a similar problem (possibly introduced by [3], which
I have reverted but would like to reland) involving overview item
dragging, which is handled by OverviewWindowDragController and does not
put any window in a dragged state.

[1] https://crbug.com/955814
[2] https://chromium-review.googlesource.com/c/chromium/src/+/1626542
[3] https://chromium-review.googlesource.com/c/chromium/src/+/1627562

Bug: 961170, 967196
Change-Id: I059127b88b343ea56a995bd7b815d5f434877064
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1633109Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Commit-Queue: Avery Musbach <amusbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664370}

We have a "unit_tests" source set there, so these tests don't need to
live in the global //chrome/test/BUILD.gn

Bug: none
Change-Id: I28c5c7b996255e0da3541ebdbf9b6b3d293dca14
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627761
Commit-Queue: James Cook <jamescook@chromium.org>
Auto-Submit: James Cook <jamescook@chromium.org>
Reviewed-by: Nicholas Verne <nverne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664369}

The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
TBR=cr-fuchsia+bot@chromium.org

Change-Id: Icfa8f2f11d7ab04b7c3ead3619e18151a4b6b919
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634962Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#664368}

Bug: 957675
Change-Id: I6bcfb1d3f2a1f455cc57cb1e476a4af2183a7aec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1622731Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Mike Wittman <wittman@chromium.org>
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664367}

Change-Id: I04677ceeb68a54e01e0c01bb1e1d27fe5788bb76
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635200Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Reviewed-by: Mustaq Ahmed <mustaq@chromium.org>
Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664366}

Stream textures need to be able to replace the service ID of a
TexturePassthrough object and then force the texture to be rebound in
the command decoder.

BUG=967410

Change-Id: Ice0fee56e7617952d164c6662282ae1c43254bb1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1630977Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664365}

In getTabThumbnailWithCallback() with forceUpdate == true,
cacheTabThumbnail() should be called after the callback of
nativeGetTabThumbnailWithCallback(). Otherwise there is no guarantee
the callback of cacheTabThumbnail() would be run after the callback
of nativeGetTabThumbnailWithCallback().

Bug: 965891
Change-Id: Ia8cf42f4942d569e4b646820063460a297160d9f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1629808Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664364}

Previously, when user shares a file using WST, we read the file into
bytes, and construct the post data as a kBytes DataElement. When the
file is big, chromium spend a long time parsing and auditing the
kBytes DataElement.

This CL speeds up the WST launch time by using the file's content
provider uri to construct a kFile DataElement. Because a kFile
DataElement only contains metadata (file path etc), the parsing and
auditing is much faster.

Bug: 931193
Change-Id: Ic842cbe729f1381c8e0afbbc330c7e08db9c87ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1629288
Commit-Queue: Henry Jian <hzjian@google.com>
Reviewed-by: Peter Kotwicz <pkotwicz@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664363}

Take in changes to improve variable font interpolation internal
precision #54371 as well as fixes for fuzzer issues.

Contains fixes for variable font rendering issues discovered in previous
roll attempts (#56409, #56404, #56374).

https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/fbbcf5036740..f37083edf0ef

$ git log fbbcf5036..f37083edf --date=short --no-merges --format='%ad %ae %s'
2019-05-29 bungeman [truetype] Fix copy-and-paste error (#56409).
2019-05-29 wl [truetype] Fix 32bit builds (#56404).
2019-05-29 wl Silence gcc 7's fall-through warnings in `switch' blocks.
2019-05-26 bungeman * src/truetype/ttgload.c (TT_Process_Simple_Glyph): Improve accuracy.
2019-05-25 ramakrishnan.nikhil * src/sfnt/sfobjs.h: Minor.
2019-05-23 wl [truetype] Draw glyphs without deltas in variation font (#56374).
2019-05-21 wl src/truetype/ttinterp.c: Give order of operations for some instructions.
2019-05-21 wl * src/truetype/ttinterp.c (opcode_name): Improve mnemonics.
2019-05-21 wl ttinterp.c: Improve documentation of engine compensation.
2019-05-20 apodtele Rendering considerations.
2019-05-16 wl [truetype] Actually scale varied CVT values.
2019-05-16 wl [truetype] Use 26.6 format for storing unscaled CVT values.
2019-05-16 wl * src/truetype/ttgload.c (load_truetype_glyph): Init `unrounded'.
2019-05-16 wl [truetype] Avoid code duplication.
2019-05-13 wl * vms_make.com: Updated.  Handle `bzip2' directory, too.
2019-05-13 wl * src/psaux/psfont.c (cf2_font_setup): Fix compiler warning.
2019-05-12 wl [truetype] Doh.  Fix last commit to make it work.
2019-05-11 wl [truetype] Increase precision of font variation (#54371).
2019-05-09 wl * src/truetype/ttgload.c (TT_Process_Simple_Glyph): Minor.
2019-05-08 apodtele [smooth] Faster fractions.
2019-05-07 apodtele * src/raster/ftraster.c (Draw_Sweep): Unbreak.
2019-05-07 apodtele * src/raster/ftraster.c: Clean-ups.
2019-05-07 wl * src/truetype/ttgxvar.c: More use of `FT_fdot14ToFixed'.
2019-05-04 apodtele * src/smooth/ftgrays.c (gray_render_line): Small shortcut.
2019-05-04 wl Various clang 8.0 static analyzer fixes.
2019-05-03 apodtele Miscellaneous macro updates.
2019-05-02 apodtele Tweak LCD filtering.
2019-05-02 wl * vms_make.com: Updated (#56253).
2019-04-29 apodtele [smooth] Simplify cubic Bézier flattening.
2019-04-26 apodtele [smooth] Bithacks and cosmetics.
2019-04-25 apodtele Optimize Bézier bisections.
2019-04-23 apodtele Clarify docs.
2019-04-23 wl * src/sfnt/ttcmap.c (tt_cmap12_next): Remove dead code.
2019-04-23 wl [base] Fix thinko in previous commit.
2019-04-22 wl * src/base/ftbitmap.c (FT_Bitmap_Blend): Check target pitch.
2019-04-22 wl Fix return value of `FT_Set_Named_Instance' (#56186).
2019-04-19 wl Typo.
2019-04-17 wl [pcf] Fix handling of undefined glyph (#56067).
2019-04-15 gongminmin * CMakeLists.txt: Avoid rewriting of unchanged configuration files.
2019-04-15 JonathanG * src/tools/apinames.c (main): Fix error message.
2019-04-14 wl Minor.
2019-04-12 wl Split off ChangeLog.29.
2019-04-11 apodtele [smooth] Fix segfault in direct mode (#56092).
2019-04-09 wl Minor.
2019-04-06 wl * src/sfnt/ttcmap.c (tt_get_glyph_name): Pacify compiler (#56061).
2019-04-06 wl For distribution, replace `.tar.bz2' with `.tar.xz' bundles.
2019-04-06 anntzer.lee Make `glyph_name' parameter to `FT_Get_Name_Index' a `const'.
2019-03-31 prince.cherusker [cff] Fix boundary checks.
2019-03-21 wl Improve link.
2019-03-20 wl [autofit] Fix Mongolian blue zone characters.
2019-03-19 wl [autofit] Add support for Mongolian script.

Created with:
  roll-dep src/third_party/freetype/src
R=bungeman@chromium.org,drott@chromium.org

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_msan_rel_ng

PDFium-Issue: pdfium:1295
Bug: 856023, 962932
Change-Id: I784df3df220c83aa5a2d3874d709eb299cb30c58
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634731
Commit-Queue: Dominik Röttsches <drott@chromium.org>
Reviewed-by: Ben Wagner <bungeman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664362}

This is a follow up of crrev.com/c/1518518. In this CL both
window_performance_test.cc and dom_timer_test.cc are migrated to a mock
task runner. These two migrations involve changes in some other files
basically the ones that make use of performance.now().

Bug: 919383
Change-Id: I95aeae8442850ce20889bcbc7b7fe6309df21eb7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1590101Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Nicolás Peña Moreno <npm@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Sergio Villar <svillar@igalia.com>
Cr-Commit-Position: refs/heads/master@{#664361}

This CL is the first step towards adding Element Timing text support. It
creates a skeleton TextElementTiming class which gets called from
TextPaintTimingDetector. In order for this to work, a lot of checks for
the FirstContentfulPaintPlusPlus flag need to be augmented to include a
check for the ElementTiming flag, which right now requires an
ExecutionContext since it is under OriginTrial.

In addition, TextPaintTimingDetector now needs to know whether
LargestTextPaint is being recorded: when that is not the case, we do not
want to keep updating the ordered set of records, nor keep updating LCP.
In order to do this effectively, a flag is used in both
TextPaintTimingDetector and in and in TextRecordsManager. The flag in
TextPaintTimingDetector is used to set the flag in the records manager
after the next call to UpdateCandidate occurs (so any pending text
entries are still processed).

Part 2 will involve adding the content to OnTextNodesPainted() plus some
unit tests and layout tests to ensure correctness. Since part 1 should
not produce any change in behavior other than computing unused
information when ElementTiming is enabled but FCPPlusPlus is disabled,
no tests are needed.

Bug: 942033
Change-Id: Id198f717d4235d2dc8a2a16fd637a56d7e9cace2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627969
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Reviewed-by: Steve Kobes <skobes@chromium.org>
Reviewed-by: Liquan (Max) Gu <maxlg@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664360}

This cl validates a few more bits which were missing in the original
validation cl:
https://chromium-review.googlesource.com/c/chromium/src/+/1611640

Bug: 962998
Change-Id: Ie905914eca9f75dcdc856e258ccbfd235b04bdc7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631709
Commit-Queue: Sahel Sharify <sahel@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664359}

Bug: 955567
Change-Id: I09e6c053620e8b07eaf16d7ea534276309e98dec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1630131Reviewed-by: Brandon Jones <bajones@chromium.org>
Commit-Queue: Jinho Bang <jinho.bang@samsung.com>
Cr-Commit-Position: refs/heads/master@{#664358}

GridTabSwitcherMediatorUnitTest.java has Features.DisableFeatures
annotated, but without JUnitProcessor specified. The tests didn't
fail because the calling path happened to be gated by
ChromeFeatureList.isInitialized().

This CL adds JUnitProcessor, and also mocks the cached flags.

Bug: 967686
Change-Id: I7fdaee8455c7e956ca8c1dc601c5fc0b3af26f2f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1630541
Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664357}

Remove Ash's separate registration of root windows for SPM.
Remove UAF and root window determination workarounds for SPM.

Bug: 958471
Test: No ui_devtools regressions
Change-Id: I55fe07b83731c3832e803078eb75526972534958
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631904Reviewed-by: Leonard Grey <lgrey@chromium.org>
Commit-Queue: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664356}

When I looked at this code I convinced myself it's not used
on multiple threads. I'm wrong there. As we only care about
crashes on the main thread, this makes CrashIdHelper only
work on the main thread.

BUG=967947
TEST=none

Change-Id: Ic8e4c81012e31cff1f0ef771789a504de95d876b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1633550Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664355}

This CL adds kkhorimoto@ (author of code) and michaeldo@ (reviewer) as
OWNERS for OverlayService.  Both OWNERS have been committers for over
6 months, and already own the model layer of the code at
ios/chrome/browser/overlays/.

Bug: 941745
Change-Id: Id6c6ddca8109963b8459fd41e122cae82a7438b3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635353
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Mike Dougherty <michaeldo@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Auto-Submit: Kurt Horimoto <kkhorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664354}

Notable changes:
 - Add -[ChromeEarlGrey executeJavaScript:] that returns result as id
   and induces assert on timeout or JS exception
 - Add -[ChromeEarlGreyAppInterface executeJavaScript:error:] that
   returns result as id or error via out argument
 - Update credential_manager_egtest.mm, block_popups_egtest.mm and
   window_open_by_dom_egtest.mm to use new API.

Bug: 922813
Change-Id: I58ab246eb67eedcc3b3724515350da959e1cea09
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1633289Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664353}

Having Tab Groups implies Grid Tab Switcher, and all callers of
isGridTabSwitcherEnabled() do check for isTabGroupsAndroidEnabled()
as well.

This CL makes isTabGroupsAndroidEnabled() checking included in
isGridTabSwitcherEnabled().

Bug: 934557
Change-Id: I1882d1b6d35fa9c40b5311fb622d2e4db0e52924
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631763Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664352}

In this change:
- Added "User" category to Sync and Services preference. The category is
  gated by identity-disc flag.
  Mocks: http://slides/1dckRy0Dm5-fOQebZvZyL6CBm2DWCKYppkuOinEORDR4#slide=id.g5615bd983f_0_157
  Screenshot: http://screen/d0uaYAhJ016

- Implemented workaround for crbug.com/963077. The effect of the bug is
  following:
  - Visiting settings causes download of larger profile image.
  - Toolbar's ProfileDataCache receives notification and caches this
    larger image.
  - When user returns to NTP, larger profile image is displayed in
    identity disc.
  The workaround is to remember image size that was requested for Identity disc
  and only update toolbar when image with correct size is received.


BUG=958982
R=twellington@chromium.org

Change-Id: I564f51958bfd473cba30a44baa94f58af1e420d9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612856
Commit-Queue: Pavel Yatsuk <pavely@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664351}

Persist the number of sync attempts in the registration metadata. This
is needed because the number of attempts are determined on browser
start-up (if a finch trial is running), and it needs to be consistently
applied across browser restarts.

This CL also introduces a new max attempt parameter, which is applied if
the registration's origin has granted notification permission. This will
allow us to increase the number of retries for the registration, without
affecting a user's privacy. The max attempts is not immediately increased
because according to the privacy team this will significantly extend
the capabilities of a malicious website, since they could just fail
the sync event and get a bunch more retries to execute their code,
potentially without the user's knowledge. The notification permission
is used as a proxy, since if the notification permission is present,
having more sync attempts would not increase the ability of a malicious
website to randomly execute code. This can be achieved by sending push
messages, which would wake up the browser / Service Worker.

Bug: 963487
Change-Id: Ia061ec30e5bcba893a9e7cc0209296ba5d7ce713
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635649
Auto-Submit: Rayan Kanso <rayankans@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Commit-Queue: Rayan Kanso <rayankans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664350}

In preparation for implementing permission prompts we'll need to keep
track of which frame any particular handle is associated with. Also
adds a common base class to the file/directory handle implementations,
as there is going to be more functionality shared between the two.

Bug: 878585
Change-Id: I07cd8273f1ae41a8f1eb95fc7d8fbfeb3311cf72
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625809Reviewed-by: Victor Costan <pwnall@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Auto-Submit: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664349}

Currently when Launcher with Embedded Assistant Ui is closing, some time
(clicking outside the Launcher), the Ui will go back to previous state
page, e.g. search result page. This will cause flashing of the ui.

Bug: 966642
Test: Manual
Change-Id: I28f7f2575f678b26be6cf269032348519367543c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625843Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Commit-Queue: Tao Wu <wutao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664348}

This disables all client hints for third parties by default, except for
the simplified UA hint. Feature Policy can then be used to delegate
specific hints. Currently, only the hints which were previously being
sent to third parties on Android are available for delagation. A follow-
up CL adds the remaining ones.

Bug: 968201
Change-Id: Idea42e814078592f3bdaec67bd931a99cfaea046
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1567927
Commit-Queue: Ian Clelland <iclelland@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Yoav Weiss <yoavweiss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664347}

RemoteViews#apply doesn't use the overriden configuration of the Context
passed into it. It instead creates a Context of remote app with default
Configuration. Because of this Custom Tabs bottom bar always follows
system settings. If COLOR_SCHEME_DARK or COLOR_SCHEME_LIGHT is set in
the intent, the bottom bar should instead follow this setting along with
the rest of the UI.

To fix this I suggest doing RemoteViews#apply manually: first inflate
the View just like RemoteViews#apply does, but with overridden
Configuration, then use RemoteViews#reapply to apply the Actions.

Bug: 966402
Change-Id: I8a89a4ee21baf5a759c4aabf0c7725430d609dc2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626864Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Reviewed-by: Becky Zhou <huayinz@chromium.org>
Commit-Queue: Pavel Shmakov <pshmakov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664346}

Hashes for search suggestions should be exactly 4 alphanumeric bytes,
this is explicitly enforced in searchbox_extension but in
search_suggest_service the byte array must be truncated to a length of
4 as the length is lost when passed through via IPC.
Previously the check was that they were *up to* 4 bytes, but this
isn't strict enough. Also remove usage of the banned std::to_string.

Bug: 965715
Change-Id: I687496ccaf225118a8f7b07bbaa2913bba19e6b7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632716
Commit-Queue: Kyle Milka <kmilka@chromium.org>
Reviewed-by: Gayane Petrosyan <gayane@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664345}

In change https://crrev.com/0daefdcf34ba9a8c21ab907b2159c5652169a45b
caused a dcheck failure occasionally because of an implicit open of a
document inside an implicit close while running the
wpt/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/abort-while-navigating.window.html
wpt test.

See: https://chromium-swarm.appspot.com/task?id=44fb7387f8411e10
for the failure.

https://chromium-review.googlesource.com/c/chromium/src/+/1628499
reverted the original code so this is a reland of some of that code.

Because of the complexity of that value use a simpler
approach and use the Frame::IsLoading attribute instead which doesn't
exhibit these cycles.

BUG=907125

Change-Id: Ifb805cf8ab90b6a228f47d88cb2ee872d9a21239
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626956
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664344}

Bug: 932078
Change-Id: I0fc05317b42cc305b0836d27458211c611e8a10c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632164
Commit-Queue: Balazs Engedy <engedy@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664343}

Using the CrashReportDatabase interface is more robust against changing
database implementations than accessing crash reports directly.

Change-Id: I6ef699a4a98d772364ff2c5f2de118a5fecc978a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1633315Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Joshua Peraza <jperaza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664342}

This CL enables all Vulkan viz_unittests except for video tests but
excludes configuration that failed in my previous attempt. As the fixes
roll in, I will enable more configurations.

Bug: 960795
Change-Id: Iddb7b7728a65622f4669672eff90d242d7f378f6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635550Reviewed-by: Jonathan Backer <backer@chromium.org>
Commit-Queue: Saman Sami <samans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664341}

On Linux, create semaphore and get fd from it are expensive, so this CL will not do it,
if it is not necessary.

Bug: 968103
Change-Id: I8c80d55c42145fb424e83482bf17969fdfc270d1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634712Reviewed-by: Jonathan Backer <backer@chromium.org>
Commit-Queue: Peng Huang <penghuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664340}

check_includes is disabled for this target. I couldn't enable it
(there are issues to resolve in //chrome/test/BUILD.gn) but this
improves the situation.

Bug: none
Change-Id: I84a5c2fe9ca7ffa35114c2a0fd2ce0be750103a7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632551Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664339}

This patch updates chrome://inspect#devices to use the friendly (user-given)
name of the Cast device, which will allow developers to distinguish multiple
devices of the same model/type.

Bug: 658204
Change-Id: I34d1e31a2203f58ae948687f991ac68e5d14bb32
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606183Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Commit-Queue: mark a. foltz <mfoltz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664338}

https://skia.googlesource.com/skia.git/+log/29e013deb476..d0d66fb8be4b


git log 29e013deb476..d0d66fb8be4b --date=short --no-merges --format='%ad %ae %s'
2019-05-29 egdaniel@google.com Remove call to copy in GrcontextPriv read/write pixel calls.


Created with:
  gclient setdep -r src/third_party/skia@d0d66fb8be4b

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=kjlubick@google.com

Change-Id: Ib379faa8820d7dbc8c16599fa621fdec89e41736
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634556Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#664337}

Fix bug introduced in crrev.com/c/1451843

BUG=966822

Change-Id: I6c71fa45d953baf769f86678c225a02d2a860478
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1629724
Commit-Queue: Avi Drissman <avi@chromium.org>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664336}

Change-Id: I89f90fc6b8942afde5121b13fecc8f351691000c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1629335
Commit-Queue: Alexei Filippov <alph@chromium.org>
Reviewed-by: Mike Wittman <wittman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664335}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/dc0353f46e1f..d15049dacabe


git log dc0353f46e1f..d15049dacabe --date=short --no-merges --format='%ad %ae %s'
2019-05-29 derat@chromium.org chromeos_config: Drop chrome_login Tast test attribute.


Created with:
  gclient setdep -r src/third_party/chromite@d15049dacabe

The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel
TBR=chrome-os-gardeners@google.com

Change-Id: I1d362044c566ff487c6ff47622c0326afc47722b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634415Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#664334}