GitLab

Review URL: http://codereview.chromium.org/115869

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17117 0039d316-1c4b-4281-b951-d872f2087c98

Custom start urls and default search options widgets aren't hooked up.
Home page settings work, but are overridden by the linux start page settings.
Default browser checking/setting functions are not implemented, so the option
isn't useful yet.

Refactors some common code out of browser/views/options/options_page_view.*
into browser/options_page_base.{cc,h}

BUG=11507

Patch by Matt Mueller (mattm@google.com).

Review URL: http://codereview.chromium.org/113967


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17115 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/113965

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17113 0039d316-1c4b-4281-b951-d872f2087c98

Split off Windows bits into NativeTextfieldWin class obscured behind NativeTextfieldWrapper interface.

The APIs aren't perfectly tidy yet but this is a good first pass.

BUG=none
TEST=make sure you can still edit text fields, run the view unit tests.

Review URL: http://codereview.chromium.org/113940

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17112 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/115876

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17111 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/115852

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17110 0039d316-1c4b-4281-b951-d872f2087c98

_views.foo.

BUG=none
TEST=none
TBR=brettw

Review URL: http://codereview.chromium.org/115875

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17109 0039d316-1c4b-4281-b951-d872f2087c98

TEST=none
BUG=none
Review URL: http://codereview.chromium.org/115873

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17108 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/115874

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17107 0039d316-1c4b-4281-b951-d872f2087c98

BUG=12299
TEST=1) right click/save as on some image. Clicking on the download item's filename area should launch it in some image viewer (assuming xdg-open works for you---as it happens, ubuntu broke xdg-open for desktops that are not gnome, kde, or xfce). 2) Download a large file. Click on the download item before it is finished. The text should change to "opening in..." and the checkbox in the dropdown menu should show as checked. 3) completed downloads should have the "open when finished" menu item replaced by the "open" menu item. Selecting that should also open the download.
Review URL: http://codereview.chromium.org/112064

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17106 0039d316-1c4b-4281-b951-d872f2087c98

or when the file is detected to be changed externally.

Review URL: http://codereview.chromium.org/114055

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17105 0039d316-1c4b-4281-b951-d872f2087c98

This involves implementing GoogleUpdateSettings::[GS]etCollectStatsConsent, and a whole lot of refactoring.

BUG=none
TEST=delete config dir, run official Linux build, don't enable crash reporting, crash browser -> no crash reporting.
Review URL: http://codereview.chromium.org/115808

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17104 0039d316-1c4b-4281-b951-d872f2087c98

other gtk popups (e.g., gtkmenu).  Always allow Esc to close the
popup so a hung renderer doesn't require mouse usage.

Review URL: http://codereview.chromium.org/113959


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17103 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/112063

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17102 0039d316-1c4b-4281-b951-d872f2087c98

ported.

BUG=none
TEST=none
TBR=brettw

Review URL: http://codereview.chromium.org/113963

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17101 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/115872

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17098 0039d316-1c4b-4281-b951-d872f2087c98

BUG=http://crbug.com/12550
TEST=as described in bug report

Review URL: http://codereview.chromium.org/113960

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17097 0039d316-1c4b-4281-b951-d872f2087c98

This is useful for getting general build version information, such as needed
for Linux packaging.

Review URL: http://codereview.chromium.org/115842


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17096 0039d316-1c4b-4281-b951-d872f2087c98

This introduces a hybrid GtkBin/GtkFixed container which exposes a signal to absolutely position widgets. This also fixes the current flickering issues with the status bubble.

http://crbug.com/11635
TEST=Goto a site with a long list of links (I used reddit.com) and move the mouse cursor up and down the list quickly. There shouldn't be flickering in the top left corner.

Review URL: http://codereview.chromium.org/115835

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17095 0039d316-1c4b-4281-b951-d872f2087c98

BUG=12684
Review URL: http://codereview.chromium.org/113958

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17094 0039d316-1c4b-4281-b951-d872f2087c98

Make automation proxy objects to ref_counted. That allows to process async notifications directly in channel background thread. Add support for listener-less ChannelProxy.
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/113722

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17093 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/113955

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17092 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/113957

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17090 0039d316-1c4b-4281-b951-d872f2087c98

Also, on linux, assume the user denies every download which we would have prompted him with.

BUG=12709
TEST=windows is still carpet-bombing resilient and linux can download from the same page more than once.
Review URL: http://codereview.chromium.org/113925

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17089 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=We should run those scripts with and without the optional arguments :-)


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17088 0039d316-1c4b-4281-b951-d872f2087c98

The CPP logic on the log dir seems to have been wrong since last year.  Changed so debug writes next to the executable, and release writes to userdata dir.  It was the reverse.
Drop two paths that aren't used any more.

BUG=12834
TEST=run app, make sure we don't create a log file inside the MacOS folder.
Review URL: http://codereview.chromium.org/115868

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17087 0039d316-1c4b-4281-b951-d872f2087c98

svn:ignore the new gyp-generated files.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/115867

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17085 0039d316-1c4b-4281-b951-d872f2087c98

TEST=SeekableBufferTest.*
Updating media::SeekableBuffer and unit tests to meet
code style standards.

Review URL: http://codereview.chromium.org/114042

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17084 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17082 0039d316-1c4b-4281-b951-d872f2087c98

Do endian swapping for the identifier in dump_syms.
Fill in the pdb_file_name (debug_file) field for modules.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/113943

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17081 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/113954

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17080 0039d316-1c4b-4281-b951-d872f2087c98

BUG=8317
TEST=make sure we don't create a dictionary directory within the app.
Review URL: http://codereview.chromium.org/115863

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17079 0039d316-1c4b-4281-b951-d872f2087c98

Not sure what is causing the crasher.
Hopefully after this clean-up we'll get a different stack-trace that might help.

BUG=10699
TEST=Make sure alert/confirm boxes work properly. make sure a background tab that shows a (delayed) alert box  works. Same with a background browser.
     
Review URL: http://codereview.chromium.org/113932

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17078 0039d316-1c4b-4281-b951-d872f2087c98

BUG=12413
TEST=Focus the omnibox. Press Shift-Ctrl-Delete, the Clear Browsing Data dialog should show.
     Make sure cut/copy/paste shortcuts still work as expected (Ctrl/x, Ctrl/c, Ctrl/v, Shift/Delete, Shift/Insert).
Review URL: http://codereview.chromium.org/113872

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17077 0039d316-1c4b-4281-b951-d872f2087c98

side.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/114054

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17076 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/115864

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17075 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/113953

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17074 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/113951

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17073 0039d316-1c4b-4281-b951-d872f2087c98

Now data for each profiling session is collected separately (previously they were accumulated in a single profile).

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/113950

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17072 0039d316-1c4b-4281-b951-d872f2087c98

Use CERT_PKIXVerifyCert() with CRL to verify certificate.
With OCSP, CERT_PKIXVerifyCert() failed with
SEC_ERROR_INVALID_ARGS.

Increase stack size.  It was not enough size if we use
CERT_PKIXVerifyCert() on some sites. For example,
https://www.google.com/ works, but https://bugs.webkit.org/
or https://www.thawte.com/ would die by SIGSEGV.  This is
because pkix_List_Destroy() routine destroys PKIX_List
recursively, so if there are some long PKIX_Lists, it
consumes stack a lot and dies by stack overflow.

Note that X509Certificate::Verify isn't used in SSLClientSocketNSS yet.

BUG=10911
TEST=net_unittests passes

Review URL: http://codereview.chromium.org/113578

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17071 0039d316-1c4b-4281-b951-d872f2087c98