- 10 Dec, 2020 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/3c56ca23d926..32e1d74200bc 2020-12-10 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Id8a61b48f5891acea2fc9db00502813e4a703e1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582968Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#835553}
-
Carlos IL authored
Bug: 1061611 Change-Id: I3498e5c4c13657d573128c081f1a80097610792d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583137 Auto-Submit: Carlos IL <carlosil@chromium.org> Commit-Queue: Emily Stark <estark@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#835552}
-
Thomas Guilbert authored
This CL mirrors the changes landed in acbd2eae, and exposes VideoEncoder to workers. The changes in this CL rely on the conclusions from the previous CL. Notably, there is a need for a synchronous wait when getting the GPU factories due to some threading issues, and there is no support for logging from workers. Bug: 1094169 Change-Id: I2da6cdb2afd7b80e342268cbbfcb00fea64ad37f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578002 Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Eugene Zemtsov <eugene@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#835551}
-
Stefan Zager authored
Change-Id: I4febb376c13fe82fe2ffcb3efc2dc4a315665b1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583185Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#835550}
-
Mitsuru Oshima authored
Let the client (callee) should handle empty case instead. Bug: 1156889 Test: updated the test cases. Change-Id: Iccea2a70784fdd4280f41ec07732ec5993831282 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580228 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#835549}
-
Kyle Williams authored
This cl fixes minor issues with tests and defines a good way to test CfM Chromim Services. Bug:b:175079076 Test:'autoninja -C out/Default/ chrome/test:unit_tests chromeos:chromeos_unittests && xvfb-run ./out/Default/unit_tests --gtest_filter=CfmBrowserServiceTest.* && ./out/Default/chromeos_unittests --dbus-stub --gtest_filter=CfmHotlineClientTest.*' Change-Id: I3193e611818af08060f305d37799c9b79d97e2b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577733 Commit-Queue: Kyle Williams <kdgwill@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
-
edchin authored
This removes these flags and cleans up unused codepaths: * AddWebContentDropInteraction * DragAndDrop Both flags have been launched 100% in Finch and enabled by default TOT. Bug: 1101363, 1099646 Change-Id: I654dc96a8f41b4e9b013be0108989aa657b3b635 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581033Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#835547}
-
Yuta Hijikata authored
The change is mostly mechanical replacing defined(OS_CHROMEOS) with BUILDFLAG(IS_CHROMEOS_ASH) and GN variable is_chromeos with is_chromeos_ash with some special cases (For those cases please refer to http://go/lacros-macros). The patch is made in preparation to switching lacros build from target_os=linux to target_os=chromeos. This will prevent lacros from changing behaviour after the switch. Bug: 1052397 Change-Id: I54158a0001b9c7d7f29d879b20f05e9b4b4e9260 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580923Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Yuta Hijikata <ythjkt@chromium.org> Cr-Commit-Position: refs/heads/master@{#835546}
-
Yuta Hijikata authored
The change is mostly mechanical replacing defined(OS_CHROMEOS) with BUILDFLAG(IS_CHROMEOS_ASH) and GN variable is_chromeos with is_chromeos_ash with some special cases (For those cases please refer to http://go/lacros-macros). The patch is made in preparation to switching lacros build from target_os=linux to target_os=chromeos. This will prevent lacros from changing behaviour after the switch. Bug: 1052397 Change-Id: I67ce28e4f8863d9247e57e03b771fb3f6bf7f5d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565042 Commit-Queue: Yuta Hijikata <ythjkt@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#835545}
-
Francois Doray authored
The thread handle should be used instead of the thread id for thread manipulations. It is available immediately after thread creation, unlike the thread id which is available only after the main function is entered. Also, on Windows, the thread handle remains valid after the thread has exited. This is a prerequisite to remove the wait after compositor thread initialization https://source.chromium.org/chromium/chromium/src/+/master:third_party/blink/renderer/platform/scheduler/common/thread.cc;l=96;drc=5b1ca7b1087e13d963bc4058d9406a838fb7f9ca Bug: 1080709 Change-Id: Ia0b72aa1b3a86454cffa774131944db87ced0843 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578172Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#835544}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=lakpamarthy@chromium.org Change-Id: I644f551c9634679d466ee86890f908d5a95407fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583702Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#835543}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/26392d8577ab..a6fc821995dc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC meredithl@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: meredithl@google.com Change-Id: I8048acca66782ea69a58d52851b5f38ef9f0fe75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583542Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#835542}
-
Ce Chen authored
The variant to be launched: http://screenshot/6pp7qvc8gfMGyxm Bug: 925072 Change-Id: I931f6a2432466d1b3692773256634aaad12d14dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578505Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Ce Chen <cch@chromium.org> Cr-Commit-Position: refs/heads/master@{#835541}
-
Satoshi Niwa authored
https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/642f74bf3abe..11ce1d136747 $ git log 642f74bf3..11ce1d136 --date=short --no-merges --format='%ad %ae %s' 2020-11-11 hardikgoyal cryptohome: add AuthSession and unguessable token to identify it 2020-11-25 niwa cryptohome: Implement SetProjectId() 2020-05-29 xzhou system_api: add security key challenge response messages. Created with: roll-dep src/third_party/cros_system_api Change-Id: I23eba9ae7490a19446261e5fc53892eb4802356d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583582 Commit-Queue: Satoshi Niwa <niwa@chromium.org> Commit-Queue: Ryo Hashimoto <hashimoto@chromium.org> Auto-Submit: Satoshi Niwa <niwa@chromium.org> Reviewed-by:
-
Kent Tamura authored
* AXLayoutObject::ComputeAccessibilityIsIgnored() and LayoutObject::IsListMarkerForSummary() Skip LayoutObjects for summary::marker. The owner <details> already exposes open/closed information, and TextAlternative for disclosure-open and disclosure-closed are helpless. Test changes: * nth-pseudo.html Update expected numbers because now the UA stylesheet contains first-of-type. * offset-parent-does-not-leak-ua-shadow.html Use DETAILS instead of SUMMARY because SUMMARY doesn't have a UA shadow tree any longer. * details-clone.html It tested if UA shadow elements were cloned. But the shadow elements are not created after this CL. The test is converted to a pixel test to check if cloned details/summary elements have identical appearance. * details-marker-style.html Add a comment about unsupported properties. Bug: 590014 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng_disabled Change-Id: I2eda05da1af100b43ce624bfd464513b16af8c32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577115Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#835539}
-
Kyle Horimoto authored
This CL fixes an issue which can be caused when multiple concurrent Nearby Connection requests are requested by SecureChannel. When a connection disconnects, we check to see if there are any more active connections; if so, we shut down the process. Before this CL, we'd return early if that was the case. However, this means that if there were 1 attempt ongoing and 1 queued, then the queued attempt would never get to move forward after the first attempt disconnected (due to the early return). This CL fixes the issue by simply checking to see if there is another request which should be tried after the first one fails. This CL also adds a regression test which fails without the fix. Bug: 1156162 Change-Id: I914ba7ce5ec47ba107228b19641d849ffabf04ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583116 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: James Vecore <vecore@google.com> Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#835538}
-
Josh Nohle authored
By default, sort the multi-device setup drop-down list by the potential host phones' last activity time. These values are returned from the CryptAuth server for phones that have already adopted DeviceSync v2. Note: Some old phones that are not using DeviceSync v2 will not have this information. Those phones will be displayed after the phones with a last activity time, and they will be sorted in the same way as before this flag was enabled. Bug: 923594 Change-Id: Ib915d1814a2932bf06cd32d9dfdb3be335a520ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583216 Commit-Queue: Josh Nohle <nohle@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Auto-Submit: Josh Nohle <nohle@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#835537}
-
Rachel Carpenter authored
This CL points help app in app search to the new sandboxed LSS. Design doc: go/lss-sandboxing Implementation plan: go/lss-sandboxing-impl Bug: b/174514210 Change-Id: Ia3f3b442372d371bce57e199a64352f308894ae5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576234 Commit-Queue: Rachel Carpenter <carpenterr@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Reviewed-by:
Thanh Nguyen <thanhdng@chromium.org> Cr-Commit-Position: refs/heads/master@{#835536}
-
Dale Curtis authored
This implements AV1 hardware decoding according to the DXVA2 spec: https://www.microsoft.com/en-us/download/details.aspx?id=101577 Bug: 1115846 Test: Manual check of many streams. Passes all AV1 CQ tests. Change-Id: Ic920484af92fa56fd0422f8d989692be7118cfb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495791 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Reviewed-by:
James Zern <jzern@google.com> Cr-Commit-Position: refs/heads/master@{#835535}
-
Mila Green authored
Bug: 1151106 Change-Id: I032321a96a06da9e80bef50b8ef76ef4525d2fc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580906Reviewed-by:
Sorin Jianu <sorin@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Mila Green <milagreen@chromium.org> Cr-Commit-Position: refs/heads/master@{#835534}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/dd9c4208af2e..81356f4bf38c 2020-12-10 delphij@google.com DO NOT MERGE - Merge Android R QPR1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: chromium:172690556 Tbr: perfetto-bugs@google.com Change-Id: I9fae442447d8bcde3813e1aec08574dff2a47888 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583545Reviewed-by:
-
Matt Menke authored
CrossOriginEmbedderPolicyReporter calls into NetworkContext's reporting API. Reporting information can be used to track users across sites, so needs to be keyed on NetworkIsolationKey. This CL adds a NetworkIsolationKey to its constructor, and plumbs the right NetworkIsolationKey through. ServiceWorker/SharedWorkers currently use a NetworkIsolationKey as if they were top frame loads, but once they're sharded by top frame origin, that will need to change. Bug: 1143453 Change-Id: I8acbe720a17d7e2d4ff013bd277f9810c09f9c90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578164 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#835532}
-
Andrey Kosyakov authored
This is a refinement of previous fix for issue 1149042, that also takes care of another problem. The check that forces full frames is now moved downstream to the CompositorFrameSinkSupport, where we're able to use a more adequate criteria for whether full frame is needed. Drive-by: discard pending output requests after an externally-driven frame is done. Bug: 1149042, b/173651870 Change-Id: I26cd851315c3d9059403ef96f9a9bb5f21dfaafd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557734 Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#835531}
-
Haiyang Pan authored
on the android, linux, win10, mac, iOS, chromeos platforms. This follows the CL crrev.com/c/2580166. The existing CI configs on android, linux, and win10 are removed as well. (The CI test config on android will be removed via reverting crrev.com/c/2454729) Bug: 1099916 Change-Id: I02bd3280486de170a1c8ffcd2d2f0dc6b03e3adb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583105 Commit-Queue: Haiyang Pan <hypan@google.com> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#835530}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1607515179-f1c33f017a68d1555043f7e4b5e6f959b5d2d5d2.profdata to chrome-linux-master-1607558393-7b448dadc25433e8ca3294be917bb2299ab3dcfb.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I92cc68f2458e59557bf81ca68aa272e69674a89b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583544Reviewed-by:
-
Yi Gu authored
This reverts commit 7f95bc55. Reason for revert: Updating the backend in chrome://flags reliably leads to crash. Reverted locally and the crash was gone. Original change's description: > [WebOTP] Use a feature with variations instead of a multi value switch > > This allows WebOTP backend to be configured via finch trial infra. > > > Bug: 1153880 > Change-Id: I645171b4635595a48091ff3f40a63839321cf5ab > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2564007 > Commit-Queue: Majid Valipour <majidvp@chromium.org> > Reviewed-by: Nasko Oskov <nasko@chromium.org> > Reviewed-by: Yi Gu <yigu@chromium.org> > Reviewed-by: Majid Valipour <majidvp@chromium.org> > Cr-Commit-Position: refs/heads/master@{#835511} TBR=nasko@chromium.org,majidvp@chromium.org,yigu@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: I10dc087b539041f42781525e30f527846a708203 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1153880 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583117Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#835528}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/627f4a6b8dc3..dd9c4208af2e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I64053deb55f08f4ab88e02e9d14497de10ee1b86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583110Reviewed-by:
-
Jason Lin authored
VmCameraMicManager displays camera and mic notifications based on VMs' media capture state. And CameraMicTrayItemView is meant to follow VmCameraMicManager and displays camera and mic indicators on the systray. CL 2576232 changes the notifications behavior such that when a VM is accessing both camera and mic, only a camera icon notification is displayed. In this case, we don't want CameraMicTrayItemView to display the mic indicator unless a mic icon notification is also displayed. To fix this issue, this CL lets CameraMicTrayItemView follows the notification state (via VmCameraMicManager::IsNotificationActive()) instead of the device state (via VmCameraMicManager::IsDeviceActive()). bug: b/167491603 Change-Id: I514f7be204d74cc43ac67d12bc2ce7215bf50cb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581180 Commit-Queue: Jason Lin <lxj@google.com> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1607536746-da55b5a139e52763d98214355eab95e70f45f788.profdata to chrome-mac-master-1607558393-ecfec5cb12c3793b6b05707a914c348608cba34b.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ib3f9e36ef30a13b82d3904e01f28d6ec2bb1a27e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582949Reviewed-by:
-
Kenton Lam authored
Updated and added new enum value to prepare for implementation of system emoji picker. This emoji picker will be used when a physical keyboard is connected. Existing code records this metric in Google3, we are adding a new emoji picker in Chrome OS and will use this metric to compare usage of the two. Adding the additional enum entry now as metric is about to expire, implementation to follow. Bug: 1153740 Change-Id: I4c97873f70caa4f7fb355d089ead72ded3abccb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580660 Commit-Queue: Kenton Lam <kentonlam@google.com> Reviewed-by:
Caitlin Fischer <caitlinfischer@google.com> Reviewed-by:
John Palmer <jopalmer@chromium.org> Cr-Commit-Position: refs/heads/master@{#835524}
-
Clark DuVall authored
The histogram files had ContextCreateTime, but Java had CreateContextTime. Oops. Bug: 1150600 Change-Id: I6eac406e7d29bc46809623696bc0c7007212ebfb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583136 Commit-Queue: Clark DuVall <cduvall@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Clark DuVall <cduvall@chromium.org> Reviewed-by:
-
Yu-Hsuan Hsu authored
Add two new CRAS_CLIENT_TYPE: CRAS_CLIENT_TYPE_LACROS and CRAS_CLIENT_TYPE_PLUGIN. BUG=b:167941044 Change-Id: If68c7b7429e0b6082bdc1ed5fd2571bf64c7dc48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573263Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Yu-Hsuan Hsu <yuhsuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#835522}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/ba2b567f001f..d5e21940e048 2020-12-10 dberris@chromium.org chromeperf: Increase parallelism by 1.5x If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC wenbinzhang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1156554 Tbr: wenbinzhang@google.com Change-Id: I0048c1a9247e6e340deb0a3e67fdef729cda748d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582951Reviewed-by:
-
Matt Reynolds authored
If script does not maintain a reference to a HIDDevice object, it may be garbage collected even if there is an open connection to the device with an input report event listener. This CL makes HIDDevice ActiveScriptWrappable so it can prevent itself from being GCed if the device is open and an event listener is registered. Bug: 1156239 Change-Id: Ia2d394e66f9e52efc871bdb639e003ed6bb27254 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576793Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Cr-Commit-Position: refs/heads/master@{#835520}
-
Anupam Snigdha authored
When selection positions span across contexts with different editability regions, the block formatting command tries to split the nodes and perform indenting by copying over content to start position from where the end position is. This leads to a crash while verifying node split output in |RangeForParagraphSplittingTextNodesIfNeeded|. Fix is to check whether the start and end positions are inside the same editable region or not and if they don't share the same editable context, then just bail out. Bug: 996134 Change-Id: I298ae6c8b0c631620266e3f201c0f3c8849d3300 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582866 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
-
edchin authored
This was originally created in Nov 2018 in this CL: https://chromium-review.googlesource.com/c/1351787 This metric is no longer being used and has already expired since M73. Per go/histogram-expiry-guidelines: "If the histogram is not in use now, but might be useful in the far future, remove it." Change-Id: I2af72cca6842323a4ec9eb37b20dc8cdcdd27f65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580917 Auto-Submit: edchin <edchin@chromium.org> Reviewed-by:
Weilun Shi <sweilun@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#835518}
-
Mason Freed authored
The previous bar had a 100% width, which made the right edge visible if the window was scrolled. With this implementation, the control is the first row in the table, so the width is max-content. (Simply making <body> max-width doesn't work, because then when trying to line-wrap, the table is too wide and doesn't wrap anything.) Fixed: 1154219 Change-Id: I8d35eb632c59f7dc8c8e8c76c3575018669d82da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582636 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
-
Travis Skare authored
Linux-only for now, one showed on Android in the past but not as frequently. Bug: 1157241,1157239 TBR: mlamouri@google.com Change-Id: Ibf33f33a207cf3276907e8abadab1d224dc8baa6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583156Reviewed-by:
Travis Skare <skare@chromium.org> Commit-Queue: Travis Skare <skare@chromium.org> Cr-Commit-Position: refs/heads/master@{#835516}
-
Mason Freed authored
This CL primarily replaces CreateV0ShadowRootForTesting() with AttachShadowRootInternal(ShadowRootType::kOpen) in one place: core/editing/testing/editing_test_base.cc. That is the base class for many derived editing tests, which then needed to be updated, mostly by replacing <content> elements with <slot> elements, and updating the slot selection attributes accordingly. Some tests, notably ones that do Flat Tree traversal and then look for particular nodes in the flat tree, fail when this change is made. These are (or should be) test-only failures, as the only change being made is to switch from Shadow DOM v0 to (supported) Shadow DOM v1 in the test. It is likely that these tests just need to be updated to look for the <slot> elements in the flat tree, instead of expecting fully-replaced <content> elements. A separate bug (crbug.com/1157146) tracks the 6 tests that were disabled in this CL: EditingUtilitiesTest.NextNodeIndex EditingUtilitiesTest.firstEditablePositionAfterPositionInRoot EditingUtilitiesTest.lastEditablePositionBeforePositionInRoot EditingUtilitiesTest.tableElementJustBefore PositionTest.NodeAsRangeLastNodeShadow StyledMarkupSerializerTest.AcrossShadow Bug: 966758,937746,1157146 Change-Id: Idc49a66068850c8f80fd3d4ba405e60352553782 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581200 Auto-Submit: Mason Freed <masonfreed@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by: -
Frank Tang authored
https://chromium.googlesource.com/chromium/deps/icu.git/+log/8bb622..5c3a0b9 TBR=jshin@chromium.org Bug: v8:10447 Change-Id: I715e375e6778a4ff038aedb3e35404e1a7ff91dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582536Reviewed-by:
Frank Tang <ftang@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#835514}
-
