GitLab

Bug: 1051748
Change-Id: I6bbef3ef50930048984593270fbe39a59a6d61f3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053167Reviewed-by: Shrek Shao <shrekshao@google.com>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Auto-Submit: David Manouchehri <david@davidmanouchehri.com>
Cr-Commit-Position: refs/heads/master@{#742401}

Bug: 1026378
Test: gn check android build
Change-Id: Ibfe5dde9bba59e4219d244c780130f873336c713
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063210
Auto-Submit: Simeon Anfinrud <sanfin@chromium.org>
Reviewed-by: Luke Halliwell (slow) <halliwell@chromium.org>
Commit-Queue: Simeon Anfinrud <sanfin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742400}

TBR=rsleevi@chromium.org

Change-Id: I96865f0c093432cad4171be8f485cc06de5740d7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2058926Reviewed-by: Nick Harper <nharper@chromium.org>
Reviewed-by: Ryan Sleevi <rsleevi@chromium.org>
Commit-Queue: Nick Harper <nharper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742399}

This CL is part of the post-launch cleanup. The purpose is to remove
all the code that was necessary to conditionally enable/disable
favicons and other decorations for Omnibox suggestions.

Bug: 1051551
Change-Id: I2ef67c8e6fdd8be0aa7f6256e20d84763c6ba4d6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049834Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Brandon Wylie <wylieb@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: Ender <ender@google.com>
Cr-Commit-Position: refs/heads/master@{#742398}

BUG=1023913

Change-Id: Ibfcc2411221e05e0318c4924173792df0b41d72a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031761
Commit-Queue: Avi Drissman <avi@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742397}

This CL introduces a new Chrome feature and flag to control the
number of presented Omnibox suggestions to show as many suggestions
as the list can contain without making the list scrollable.

The adaptive suggestion count will still honor the platform limit
offering no fewer suggestions that were offered before.

Bug: 1050813
Change-Id: Icc139adea0885499f07524b3641c37f759718cb2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2048411
Commit-Queue: Ender <ender@google.com>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Reviewed-by: Patrick Noland <pnoland@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742396}

We couldn't do this initially due to https://crbug.com/1005726,
which is now resolved. Currently, we bounce the CIPD package through
a git repo which is tedious and error-prone.

src-internal/DEPS was updated in crrev.com/i/2543523 to add the CIPD
checkout at components/media_app_ui/resources/pkg (previously this was
the "app" subfolder of the "app" checkout location of the git repo).

This is "Step 3" of the migration in the linked bug.

Step 4 is remove the git repo (../resources/app) from src-internal/DEPS.

Bug: 1051776
Change-Id: I9608ea7e40b9601ca8919689efad6bf6eb6dce30
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061568Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742395}

Bug: 1046181
Change-Id: Ib732d475ecb33830a9e0be81a3b65b1d4e344a87
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019479
Commit-Queue: bttk <bttk@chromium.org>
Reviewed-by: Ender <ender@google.com>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742394}

Changes the text used to describe Contextual Search when the longpress
activation experiment is in force.  In this experiment we use longpress
instead of Tap. This CL changes the term from "longpress" to the
correct term to use externally: "Press & hold".

Also update the legacy description of how to use the feature that shows
in the Settings preferences on how to refine the search to use the new
and improved wording.

Followed https://g.co/chrome/translation to add screenshot sha1 hashes.

BUG=957451

Change-Id: I6e98965b55a936107b9fffefebaad3bef5ed86c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2058007Reviewed-by: Donn Denman <donnd@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Commit-Queue: Donn Denman <donnd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742393}

BUG=1016159

Change-Id: I7470f9fc89c1ff16eeb1f360b5ce4e1b631f0c8d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2060355Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Nancy Wang <nancylingwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742392}

UX requirement to have theming enabled irrespective of blur
enable / disable.

Bug: 1049199
Change-Id: I6b7af77d12e75ed252d9c644577b9f4316eca76e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062680Reviewed-by: Matthew Mourgos <mmourgos@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742391}

Bug: 1046181
Change-Id: I5f25fbc03a8f7feab5c76ac85b748bf04669f7c2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018253
Commit-Queue: bttk <bttk@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Ender <ender@google.com>
Cr-Commit-Position: refs/heads/master@{#742390}

This change fixes origin parsing when there are dashes in the domain.
I've also verified that there are no other characters that are
expected in domains that should have been allowed.

Bug: 1053351
Change-Id: I00fdb54cecd9719295fb195a36121ddaa1dea528
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062871
Commit-Queue: Victor Costan <pwnall@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742389}

TerminalSource which extends URLDataSource
but not WebUIDataSource can benefit from
using i18n substitutions via GetReplacements.

Substitute $i18n{themeColor} into terminal *.html

Currently we set page theme after a page loads
after we fetch prefs.  This causes flickering of the
frame and page bg since the page is first set to
the default theme from app manifest.

In order to render correctly from the start,
we will fetch the theme from prefs and substitute
it into terminal.html for meta theme and
css background.

Bug: 1033339
Change-Id: I1820e1f271f1a51a7b8aafb6e6de65d4bd3d153b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2059352Reviewed-by: Camille Lamy <clamy@chromium.org>
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742388}

Bug: 1046181
Change-Id: I58390007cfdc98199a21e2e07df31d7c575b8185
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019477
Commit-Queue: bttk <bttk@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Ender <ender@google.com>
Cr-Commit-Position: refs/heads/master@{#742387}

Bug: 1046181
Change-Id: Id7fc35bcf0891380e1ed3851cfb88791d213f679
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024080
Commit-Queue: bttk <bttk@chromium.org>
Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
Reviewed-by: Sky Malice <skym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742386}

Bug: 710376
Change-Id: Ie3a7daded109f1f943b20b5f92c1eb07ca9ca6a6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057823Reviewed-by: Ian Vollick <vollick@chromium.org>
Reviewed-by: Alexander Cooper <alcooper@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742385}

DesktopCapturer is not a pure virtual interface, meaning that wrapping
implementations such as DesktopAndCursorConditionalComposer need to be
updated whenever a new method is added--the compiler will not give an
error in this case. This was the cause of the multi-monitor breakage
for relative pointer mode.

Change-Id: I5a37a0e1fc47bf72cf9ccc7810c9e17d0a418237
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063412
Commit-Queue: Jamie Walch <jamiewalch@chromium.org>
Commit-Queue: Gary Kacmarcik <garykac@chromium.org>
Auto-Submit: Jamie Walch <jamiewalch@chromium.org>
Reviewed-by: Gary Kacmarcik <garykac@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742384}

Bug: None
Change-Id: I5cb0478252d0cd52c23c9e10274f72dae5b48474
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2059050Reviewed-by: Ian Vollick <vollick@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742383}

Also modify ChromeLauncherController::LaunchApp to use AppService to
launch apps, and remove LaunchApp function from LauncherControllerHelper.

BUG=1016159

Change-Id: Idf863b32fa703c2f03e79042525bec14cc15fec2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056892Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Nancy Wang <nancylingwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742382}

- Add a debug option flag to show update notification right away.
- Also enable helpful/unhelpful buttons.

Change-Id: I878e337e9a2bf8aed1859553ab9a2fc29ec4de2c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049044Reviewed-by: Xing Liu <xingliu@chromium.org>
Commit-Queue: Hesen Zhang <hesen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742381}

Bug: 1030357
Change-Id: I1debca25f15b7b3ee4e8f8e51da7c4f43a949006
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040920
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742380}

This change moves out ConfiguredProxyResolutionService::Request into its
own file and renames it to ProxyResolutionRequest. This will be
necessary later on when we create a second version of the
ConfiguredProxyResolutionService under a base ProxyResolutionService
that relies completely on system APIs. In that second version, we will
also want to track the status of a proxy resolution request.

This change is intended to introduce zero functional changes. It is a
pure refactor change.

Bug: 1032820
Change-Id: I1f6192dc13289bb703ad2ea5ed3065e67c928fcd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2045147
Commit-Queue: Nicolas Arciniega <niarci@microsoft.com>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742379}

These proguard rules match the old android support libraries. They
should match the new AndroidX libraries. I think we could get a bug
similar to crbug/1052855 without this change.

Per yfriedman suggestion, keep both rules for now, then remove later.

Bug: 896775
Change-Id: I9b38e20683e1fcf78224acef732c9342717b73d7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063255
Commit-Queue: benjamin joyce <bjoyce@google.com>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742378}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/f3d47a2e..0b2347be

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I501feaadaf548149ac6059e4b1c48d2f165884be
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062032Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#742377}

Bug: 1047750
Change-Id: Id526464fe3dc5062105e969ac0885b62549eaa72
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062904
Commit-Queue: Charlene Yan <cyan@chromium.org>
Reviewed-by: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742376}

https://webrtc.googlesource.com/src.git/+log/18c617989b21..1282babe6621

git log 18c617989b21..1282babe6621 --date=short --first-parent --format='%ad %ae %s'
2020-02-18 daniel.l@hpcnt.com Fix tests in RTCMetalVideoView.
2020-02-18 trevor.axiom@gmail.com Reland "Reland "Reland "Reland "Implemented screen enumeration and selection for desktop capture under X11 using the X Resize and Rotate extension version 1.5.""""
2020-02-18 minyue@webrtc.org Pass absolute capture time from WebRtcVoiceEngine to ACM.
2020-02-18 danilchap@webrtc.org Allow sending DependencyDescriptor rtp header extension in call
2020-02-18 danilchap@webrtc.org Replace DataSize and DataRate factories with newer versions
2020-02-18 saza@webrtc.org Add aecdump experiment strings for injected custom processors
2020-02-18 fabianbergmark@google.com Support passing the ADM to the ADMWrapper.
2020-02-18 handellm@webrtc.org Ship GenericDescriptor00 by default.
2020-02-18 philipel@webrtc.org Save custom parameters provided by the SdpVideoFormat when requesting an encoder switch.
2020-02-18 danilchap@webrtc.org in call RtpVideoSenderTests rely on simulated time
2020-02-18 eshr@google.com Remove ResourceAdaptationModule::OnMaybeEncodeFrame
2020-02-18 oseg@google.com Use absl::c_any_of instead of a manual for-loop to finding an active encoding
2020-02-18 asapersson@webrtc.org StreamSynchronizationTest: rename and make some variables const.
2020-02-17 phoglund@google.com Reland "Whitespace change to kick bots"

Created with:
  gclient setdep -r src/third_party/webrtc@1282babe6621

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: chromium:1029452,chromium:396091
Tbr: webrtc-chromium-sheriffs-robots@google.com
Change-Id: I81fead694a0daaa580a2379adfdb61af5e91f67e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062783Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#742375}

This reverts commit b6fe8aaa.

Original change's description:
> Revert "Reland "Remove Deprecated ScopedBstr to BSTR Implicit Conversion Operator""
> 
> This reverts commit abb98639.
> 
> Reason for revert: Breaks on Chrome Branded Builds
> https://ci.chromium.org/p/chrome/builders/ci/win64-builder-perf/155240
> 
> [5963/14947] CXX obj/chrome/browser/browser/browser_dm_token_storage_win.obj
> FAILED: obj/chrome/browser/browser/browser_dm_token_storage_win.obj
> c:\b\s\w\ir\cache\goma\client\gomacc.exe ..\..\third_party\llvm-build\Release+Asserts\bin\clang-cl.e...(too long)
> ../../chrome/browser/policy/browser_dm_token_storage_win.cc(89,39): error: no viable conversion from 'base::win::ScopedBstr' to 'BSTR' (aka 'wchar_t *')
> hr = app_bundle->createInstalledApp(base::win::ScopedBstr(app_guid));
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> gen\google_update/google_update_idl.h(3500,29): note: passing argument to parameter 'app_id' here
> /* [in] */ BSTR app_id) = 0;
> ^
> 
> Original change's description:
> > Reland "Remove Deprecated ScopedBstr to BSTR Implicit Conversion Operator"
> > 
> > This is a reland of afb89420
> > 
> > Original change's description:
> > > Remove Deprecated ScopedBstr to BSTR Implicit Conversion Operator
> > >
> > > BUG=1034666
> > >
> > > Change-Id: I678af5925603de6f983e3d12da6832c0661f293c
> > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042194
> > > Auto-Submit: Robert Liao <robliao@chromium.org>
> > > Commit-Queue: Will Harris <wfh@chromium.org>
> > > Reviewed-by: Will Harris <wfh@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#739275}
> > 
> > Relanding http://crbug.com/739275
> > 
> > Bug: 1034666
> > TBR: wfh@chromium.org
> > Change-Id: I62a2d46993f107b18f758fec01af1828c48a3656
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043859
> > Reviewed-by: Robert Liao <robliao@chromium.org>
> > Commit-Queue: Robert Liao <robliao@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#739534}
> 
> TBR=robliao@chromium.org,wfh@chromium.org
> 
> Change-Id: Ie50ca4b64bdd258637c5ba93c484196187624d67
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 1034666
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2044767
> Reviewed-by: Robert Liao <robliao@chromium.org>
> Commit-Queue: Robert Liao <robliao@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#739569}

TBR=robliao@chromium.org,wfh@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1034666
Change-Id: I4691946e642b973e55562ceabb33189defa8b688
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049030
Commit-Queue: Robert Liao <robliao@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Reviewed-by: Will Harris <wfh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742374}

SimplifyHttpsIndicator has been default enabled for a while, and the
flag expired in M-76. This removes the feature and flag, and the logic
for the disabled path.

This also simplifies how the display and accessibility text are
generated now that there are fewer edge cases to handle, removing the
SecureChipText struct in favor of separating the logic of
GetSecureDisplayText() and GetSecureAccessibilityText(). Accessibility
text now defaults to the display text, except for specific hard-coded
exceptions (i.e., SECURE and EV_SECURE states won't have display text,
so GetSecureAccessibilityText() specifies their accessibility text).

Change-Id: Ifd8002f0e8383c25ff905c0c94c90f499acaa654
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057730
Commit-Queue: Christopher Thompson <cthomp@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742373}

When VoiceOver is enabled, triggering the voice search UI begins reading
the accessibility elements on the screen.  There is not a good way to
check when VoiceOver has stopped speaking, so voice search cannot simply
wait for VoiceOver to stop before recording.  Moreover, removing the
accessibility features for the other views in the voice search UI is
also not a solution, as VoiceOver users would be stuck on the voice
search screen.  The long-term solution to this issue is to update the
voice search feature to ignore audio that is emitted from the device,
but this fix is not yet built.

Instead, this CL disables voice search while VoiceOver is enabled.
Visually-impaired users can still use other iOS accessibility features
to dictate queries into the omnibox, so this does not negatively
affect the ability of these users to search.

VoiceSearchAvailability was created to implement this feature.  It is
an observable helper object that uses VoiceOver notifications and
VoiceSearchProvider::IsVoiceSearchEnabled() to determine whether voice
search should be enabled.  The NTP and keyboard accessory view were
updated to use VoiceSearchAvailability to optionally disable the
microphone button.

Bug: 998524
Change-Id: I8789a9a05542bdc659f8d98d0f1c90de3dc3ecb1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2005903
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Auto-Submit: Kurt Horimoto <kkhorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742372}

Removed the use of NativeTheme::GetInstanceForNativeUI() from
SendTabToSelfBubbleDeviceButton.
This change allows the button icon to track native theme changes
through it's Widget's NativeTheme.

Bug: None
Change-Id: I45bb71e50c9158360534a59593be0079d88be9e0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2044058
Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742371}

Bug: 846909, 1045732
Change-Id: Ia7a8251effb8bb27c52b378bbc91c301ace1fb28
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042437Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Ryan Sleevi <rsleevi@chromium.org>
Auto-Submit: Matt Mueller <mattm@chromium.org>
Commit-Queue: Matt Mueller <mattm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742370}

1. create one_off_colors.xml exclusively for one-off colors
2. update presubmit warning description

Bug: 775198
Change-Id: I9129c32ea58e4d35543d7f6cc152252048c1a685
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057448
Commit-Queue: Lijin Shen <lazzzis@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742369}

We're ready to launch this, so let's enable the flag.

Bug: 959679
Change-Id: I265b4969ff65897dc634bda3a95cae2705be5f20
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056193Reviewed-by: Jia Meng <jiameng@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Tony Yeoman <tby@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742368}

The unit test is not testing anything (it both early outs on copying
files and also uses the same source and destination directory when
checking if files have been copied).  This is also very deprecated.
Rather than keeping this working[*] and updating the test to not
be broken, instead remove this functionality that is incredibly
deprecated.

A followup will be to remove the functions in IndexedDBContext that
this is the only user of.

[*] alternate approach:
https://chromium-review.googlesource.com/c/chromium/src/+/2020533

Bug: 747589, 1015214, 302577
Change-Id: I7ac05f966c02be39fcd05788b1e562efae214825
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2048032Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Ben Wells <benwells@chromium.org>
Commit-Queue: enne <enne@chromium.org>
Auto-Submit: enne <enne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742367}

This reverts commit 562af1be.

Reason for revert: Failing test was disabled since it should run with autoupgrades disabled, will investigate and fix why InitAndDisableFeatures is not doing that separately

Original change's description:
> Revert "Enable passive mixed content warning by default"
>
> This reverts commit 0a37869a.
>
> Reason for revert: Causing failure of DidChangeVisibleSecurityStateTestWithAutoupgradesDisabled.DidChangeVisibleSecurityStateObserver in browser_tests on linux-chromeos-chrome
> Example failure: https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/3194
>
> Original change's description:
> > Enable passive mixed content warning by default
> >
> > Sets the feature to enabled by default and removes the config from
> > fieldtrial_testing_config.json in preparation for launch.
> >
> > Bug: 1025276
> > Change-Id: Iffcdd2153491de25b7038a609776255bbdacf2ac
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053024
> > Commit-Queue: Carlos IL <carlosil@chromium.org>
> > Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
> > Reviewed-by: Emily Stark <estark@chromium.org>
> > Auto-Submit: Carlos IL <carlosil@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#741506}
>
> TBR=rkaplow@chromium.org,estark@chromium.org,carlosil@chromium.org
>
> # Not skipping CQ checks because original CL landed > 1 day ago.
>
> Bug: 1025276
> Change-Id: I20e9dc38d83036c7b17d91de24c23ebae3049de9
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2058970
> Reviewed-by: Bret Sepulveda <bsep@chromium.org>
> Commit-Queue: Bret Sepulveda <bsep@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#741860}

TBR=rkaplow@chromium.org,estark@chromium.org,bsep@chromium.org,carlosil@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1025276
Change-Id: I9e2043fc150b9225bc32537b0cee669f1836802a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062671
Commit-Queue: Carlos IL <carlosil@chromium.org>
Reviewed-by: Emily Stark <estark@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742366}

//aw/test:libstandalonelibwebviewchromium and //aw/browser/gfx:gfx
depend on //aw/public headers but don't explicitly declare the
dependency. See the comments in crrev.com/c/1764341 for more context.

Test: autoninja -C out/aw webview_instrumentation_apk
Test: gn check out/aw
Bug: 934152
Change-Id: I0d437f7a6dc34a3ff42b3daf9ed7d41bab8a1c59
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055692
Commit-Queue: Robbie McElrath <rmcelrath@chromium.org>
Reviewed-by: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742365}

Currently when an user changes the system accent color on Mac, that
color is going to be used as the focus ring.

This CL changes the used focus ring color by taking just the RGB values
from the accent color. A custom alpha value of 128 is used in order to
avoid having a color too light which affects accessibility.

Bug: 1051391
Change-Id: I8416739ca42ef8deeeca5faf932d6dd9e0fed26a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057865Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Mason Freed <masonfreed@chromium.org>
Commit-Queue: Ionel Popescu <iopopesc@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#742364}

Per discussion in crrev.com/c/2055362, it's generally not safe to use
gRPC outside Chrome Remote Desktop, especially in Chrome. This CL adds
a note to the BUILD.gn file to encourage people to discuss this with
Chrome security team before they decide to use gRPC.

Change-Id: I9218059a977d5aea785cd70621f7ab2c428ecc0b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062920
Auto-Submit: Yuwei Huang <yuweih@chromium.org>
Commit-Queue: Joe Downing <joedow@chromium.org>
Reviewed-by: Joe Downing <joedow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742363}

This is in preparation for porting these tests to Polymer 3.

Bug: 1026426
Change-Id: I16aa1e85c882431b99a4bbd95393b62a216542a0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056576Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742362}