- 24 Nov, 2020 40 commits
-
-
Yi Gu authored
The test is very flaky on linux tsan: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=unit_tests%20(with%20patch)&tests=SignedExchangePageLoadMetricsObserverTest.WithSignedExchangeBackground TBR=ksakamoto@chromium.org Bug: 1082135 Change-Id: I48c41234e3d46fdb51f724f6a07dee2b743cb51a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558164Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#830596}
-
Anthony Cui authored
Bug: 1151492 Change-Id: I8e205b8eb39fb7ce54cec9373834980344252f92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556658Reviewed-by:
Megan Jablonski <megjablon@chromium.org> Commit-Queue: Anthony Cui <cuianthony@chromium.org> Cr-Commit-Position: refs/heads/master@{#830595}
-
arthursonzogni authored
The normal navigation code path is in the browser process. However, some edge cases were using an alternative path: CommitSyncNavigation. Not using the normal code path is a problem. Over time, we removed all of them (except one): [MHTML document]: https://chromium-review.googlesource.com/c/chromium/src/+/1547521 [srcdoc] https://chromium-review.googlesource.com/c/chromium/src/+/1547522 [blank] https://chromium-review.googlesource.com/c/chromium/src/+/1543258 One remained: the "fake" navigation to commit the "fake" initial empty document. This patch simply rename it, to make it more explicit what this is about. Bug: 936696 Change-Id: Ie44c879abe64b8a71902fb68693895e6cbfb1878 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551125 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#830594}
-
Scott Lee authored
Please find the context at https://crbug.com/1148921#c3. R=robertma@chromium.org CC=chanli@chromium.org,nodir@chromium.org Change-Id: I2b037dd6c3fdc4d0e4adb322d5f3bc1fcee100ab Bug: 1148921 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553532 Commit-Queue: Scott Lee <ddoman@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Reviewed-by:
Chan Li <chanli@chromium.org> Cr-Commit-Position: refs/heads/master@{#830593}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/c4685cb937df..4c3d711704c1 2020-11-24 pfaffe@chromium.org [TS] Heap Snapshots: Type-check all the things 2020-11-24 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-11-24 janscheffler@chromium.org [Storage] Only delete first party cookies by default 2020-11-24 changhaohan@chromium.org Fix css-shadow-swatch re-register issue 2020-11-24 tvanderlippe@chromium.org Replace remaining title property setters with Tooltip.install 2020-11-24 jacktfranklin@chromium.org Revert "[Loc] Migrate changes tool to localization V2" 2020-11-24 janscheffler@chromium.org [Recorder] Add support for iframes 2020-11-24 pfaffe@chromium.org [TS] Heap Snapshots: Refactor Grid Nodes 2020-11-24 pfaffe@chromium.org [TS] Heap Snapshots: Refactor ComparatorConfigs 2020-11-24 janscheffler@chromium.org [Cookies] Add option to show url decoded cookies 2020-11-24 kimanh@chromium.org [ts] Typescript-ify TimelineModel.js 2020-11-24 yangguo@chromium.org Remove bogus hidden visibility in profile selector 2020-11-24 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. 2020-11-24 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-11-23 andoli@chromium.org Revert "Migrate elements/ extensions of type 'view'" 2020-11-23 chrche@microsoft.com [Loc] Migrate changes tool to localization V2 2020-11-23 janscheffler@chromium.org [DataGrid] Fix creation node 2020-11-23 tvanderlippe@chromium.org Replace title property setter with Tooltip install invocation 2020-11-23 jacktfranklin@chromium.org [Dark Mode] New colours for Breadcrumbs 2020-11-23 vidorteg@microsoft.com Fixes i18n logs show on unit tests. 2020-11-23 andoli@chromium.org Migrate elements/ extensions of type 'view' 2020-11-23 andoli@chromium.org Adds experiments compatibility to new extension registration system If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1012337,chromium:1122511,chromium:1134103,chromium:1136655,chromium:1149302,chromium:1150762,chromium:1151805,chromium:1152362,chromium:997625 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I129074e9307401c7b598a02f1c5ad09e07ddcaa8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556766Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#830592}
-
Oleh Lamzin authored
Replace "system" by "device", because we use both "system" and "device" in the policy description which is confusing. Bug: b:174061781 Change-Id: Idaecbd4c5fe88070e2eee31944a70304104ee51f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557503Reviewed-by:
Pavol Marko <pmarko@chromium.org> Commit-Queue: Oleh Lamzin <lamzin@google.com> Cr-Commit-Position: refs/heads/master@{#830591}
-
Maria Kazinova authored
Moved the check to the point where submission is actually detected in order to have more meaningful Finch data. Bug: 1152433 Change-Id: Ic436fb00307098866dca1aefd27dcd92ae43ad6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556682Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Maria Kazinova <kazinova@google.com> Cr-Commit-Position: refs/heads/master@{#830590}
-
Roman Sorokin authored
In case new renamed policy has lower priority (for example it's the enterprise default value) and the old policy is set -- the old value should be used. Also modified a policy->pref mapping test. The issue was introduced in crrev.com/c/2507771 Bug: 1151109, 1138572 Change-Id: I3fae90729a8aad1fbc946017b1f7a5134b727826 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2555058 Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#830589}
-
Yi Gu authored
Test is also flaky on win: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=browser_tests%20(with%20patch)&tests=MediaFeedsBrowserTest.ResetMediaFeed_WebContentsDestroyed TBR=beccahughes@chromium.org Bug: 1124983 Change-Id: I66798e3fc1fbee904b22389f6f60c8cec5058e65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558161Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#830588}
-
Yi Gu authored
The test has been very flaky recently: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=browser_tests%20(with%20patch)&tests=MediaGalleriesGalleryWatchApiTest.RemoveListenerAndModifyGallery TBR=dbertoni@chromium.org Bug: 1150017 Change-Id: Ie5167d6db5477348b22d36d3e6198a7a3863b6db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557916Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#830587}
-
yjliu authored
This flag has been renamed from |can_use_backdrop_filter_cache| (for quads) and |can_use_cached_backdrop_filter_result| (for render surfaces) so that it would be more generic for use of other optimization purposes in the compositing and aggregating stages in the rendering pipeline. The name change caused the flag to take the opposite meaning, as logically if a quad intersects damage under, the backdrop filter cache on it should not be used. All relevant test cases have been updated accordingly. Bug: 1142892 Change-Id: I3ff19051f91d4b111ffedec2b544151c203f1c17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556338 Auto-Submit: Jun Liu <yjliu@chromium.org> Commit-Queue: weiliangc <weiliangc@chromium.org> Reviewed-by:
weiliangc <weiliangc@chromium.org> Cr-Commit-Position: refs/heads/master@{#830586}
-
Yi Gu authored
Per #2 from the linked bug, this could also be related to crbug.com/1138060. TBR=bsheedy@chromium.org Bug: 1149237 Change-Id: I753dfe6f364f93d9dd01314357cbb6ee8c67924d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557906Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#830585}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/3df719619f0a..68ac3b9ec3ca 2020-11-24 brianosman@google.com Revert "Move GL's SkSL::Compiler to the GPU (like all other backends)" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC adlai@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: adlai@google.com Change-Id: I3735638bc2d05e69397fb432a73801eaf3c09d5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557911Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#830584}
-
Yunke Zhou authored
Bug: 1133745 Change-Id: Iaf52caf6640151723c74aadbf6641504d7210089 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557082 Commit-Queue: Yunke Zhou <yunkez@google.com> Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#830583}
-
Justin Donnelly authored
Change-Id: Ib8c3ca64d59175dd85f393acfe35c7806783da95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2555472Reviewed-by:
manuk hovanesian <manukh@chromium.org> Commit-Queue: Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#830582}
-
Rahul Goyal authored
Changed "base::android::ConvertUTF8ToJavaString" to "ConvertUTF8ToJavaString" in ui_controller_android.cc, as a followup of https://crrev.com/c/2532079 Bug: b/171963823 Change-Id: Ib3dab63e863c99a1d6f1ae6d4d808ede63689d88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551126Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Commit-Queue: Rahul Goyal <goyalrahul@google.com> Cr-Commit-Position: refs/heads/master@{#830581}
-
Colin Blundell authored
This CL renames the OverrideUrlLoadingResult enum to OverrideUrlLoadingResultType in preparation for introducing an OverrideUrlLoadingResult object that will package this enum together with other state about the result of an invocation of ExternalNavigationHandler.shouldOverrideUrlLoading(). Bug: 1145983 Change-Id: Ife1effecdf44dde5bb6fb3f9afe840d280e9c2a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556960Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#830580}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/784170929fae..185795f02ceb 2020-11-24 miu@chromium.org Fix supported_address_families DCHECK in ServiceInstance ctor. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: I0754f5efae8b25c3be06437c9ca0047565fe7ec0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557907Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#830579}
-
Ehimare Okoyomon authored
Make strikethrough thickness relative to icon size and introduce a bias to shift the line to only one side of the transparent line, in order to match mocks. Screenshot: crbug.com/1077766#c106 Bug: 1077766 Change-Id: I0a4730d8aba05b6f266da1b0ba53dba254cc4000 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552861 Commit-Queue: Ehimare Okoyomon <eokoyomon@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#830578}
-
Yi Gu authored
The test http/tests/inspector-protocol/service-worker/network-extrainfo-main-request.js has been flaky for a while: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=blink_web_tests%20(with%20patch)&tests=http/tests/inspector-protocol/service-worker/network-extrainfo-main-request.js TBR=shimazu@chromium.org NOTRY=True Bug: 1087242 Change-Id: I6e2ee8020f2e67f0ca4f271929bad68776d5672f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558160Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#830577}
-
Alice Wang authored
This CL renames accountId to accountEmail to have consistent name for account email variable. Bug: 1131344 Change-Id: Id58ad100883473d136a9c6ccb3530cce138d0eab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2554600Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#830576}
-
Nektarios Paisios authored
Clarifies the meaning of a document object and the names of methods that navigate to the boundaries of the whole content In the accessibility codebase, the word "document" has a confusing meaning. For a start, our definition of a "document" erroneously included an object with an ARIA role="document" even though what we really meant by the definition was the root of a web area. Our definition is not even compatible with what HTML considers to be the document object. Secondly, the method names in AXPosition that are used to navigate to the start / end of the whole content, such as the start / end of the whole webpage or PDF, were confusingly using the same "document" nomenclature. AX-Relnotes: n/a. R=dmazzoni@chromium.org, aleventhal@chromium.org Bug: 1049261 Change-Id: I06a5383bd6cfbfa9a51f96547d02b83a3ac210a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538175 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#830575}
-
Yi Gu authored
This test has been very flaky: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=chrome_public_test_apk%20(with%20patch)&tests=org.chromium.chrome.browser.omnibox.suggestions.mostvisited.MostVisitedTilesTest#keyboardNavigation_highlightingNextTileUpdatesUrlBarText TBR=ender@google.com Bug: 1152246 Change-Id: I2a7fc32342a8394fad75db05368e4a5b62382308 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557904Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#830574}
-
Yi Gu authored
The test has been flaky on CrOS. See linked bugs for details. TBR=josiahk@google.com Bug: 1150753 Change-Id: I6941f47c7951a4a93e94529675e370edcaa2a9ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557914Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#830573}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/47a03e8743c9..3f77eb468fc4 2020-11-24 dmorilha@twilio.com fixing build for when HAVE_WEBRTC_VIDEO is not defined 2020-11-24 landrey@webrtc.org Fix authentication error while polling for upload results If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: If71039cb3a5bf20b4f9aa84f1d10d716e4e3fb12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557902Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#830572}
-
Renato Silva authored
Use the HTMLImports polyfill in OOBE to remove the dependence on HTML imports until everything can be fully migrated to JS modules/Polymer3. Bug: 1111387 Change-Id: I3c760bdc5d41f57e44927363d47a5a193edd7c34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522072 Commit-Queue: Renato Silva <rrsilva@google.com> Auto-Submit: Renato Silva <rrsilva@google.com> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#830571}
-
Ewann authored
This CL refactors EG2 tests related to the open in toolbar. The toolbar and the display of the activity view is now tested on a PDF file and a PNG image. It also Tests that the open in bar is correctly displayed when a compatible URL is loaded and tapping on the web view makes it appear or disappear. Bug: 1124310, 1146303, 1135805 Change-Id: I57f962a31a7e34a02ae37fb72bf649abb6fb74fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532004 Commit-Queue: Ewann Pellé <ewannpv@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#830570}
-
Thomas Tellier authored
There is no GAIA instance in the secondary login screen, leading to crashes each time a GAIA dialog is asked. This CL disables these requests. Bug: 1150357 Change-Id: If04f61fd07e461afc28e44ce77ecaa798afeed27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552395 Commit-Queue: Thomas Tellier <tellier@google.com> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#830569}
-
Tina Wang authored
IncognitoModeAvailability enterprise policy specifies whether the user may open pages in Incognito mode in Google Chrome. When the policy is unset or set to 0(available), pages may be opened in Incognito mode. When the policy is set to 1(disabled), pages may not be opened in Incognito mode. When the policy is set to 2(forced), pages may be opened ONLY in Incognito mode. Bug: 1148825 Change-Id: Ia3c4b619289c537b05d565d8c3302c8790df87db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553149Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Tina Wang <tinazwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#830568}
-
Nicolás Peña Moreno authored
The current link is a go link, which only works on @google account whereas most perf sheriffs will be working from @chromium accounts, so using a direct link is better. Change-Id: I3a277a67733b6af06aa19c42e61a22e502cce936 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422188Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#830567}
-
Jan Wilken Dörrie authored
This change fixes the vertical alignment of the weak password explainer in the Weak Password Check on Desktop. Screenshots are in the linked bug: https://crbug.com/1151866#c2 Bug: 1151866 Change-Id: I0272c1e1f96a2a31ffdf7db0b9da8817913c197a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556683Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#830566}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1606165050-a3d889677a06d0e206b82027c298bfd0cf0af279.profdata to chrome-win64-master-1606196878-8e98c60eb2828a7469f5671822f6024fb48eb0e5.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I98e30e55b08beb711e41ba57b1e638c64796ec9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557777Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#830565}
-
Mikhail Khokhlov authored
Monitors the radio state every second while Chrome is in foreground to count the number of times the radio woke up from dormant state. This metric will be used to estimate the approximate power cost of waking the radio up depending on the signal strength. Running a check every second can potentially be expensive, so adding this under a feature flag. Bug: b/167544787 Change-Id: Ia523f1894f4debb53cbb6dcbd436d6c7e555d1a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2484800 Commit-Queue: Mikhail Khokhlov <khokhlov@google.com> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#830564}
-
Yi Gu authored
The two tests have been flaky according to FindIt. Please see linked bug for details. TBR=andypaicu@chromium.org Bug: 1150676 Change-Id: I5812ca6afa0e04449396a3caa1bd1138aadd421c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557908Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#830563}
-
Andrey Zaytsev authored
Bug: 1070620, 1078782 Change-Id: Id0dcd9491446ea8acdd5c752409dff4394c2ad5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557080 Auto-Submit: Andrey Zaytsev <andzaytsev@google.com> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Sean Harrison <harrisonsean@chromium.org> Commit-Queue: Martin Šrámek <msramek@chromium.org> Commit-Queue: Andrey Zaytsev <andzaytsev@google.com> Cr-Commit-Position: refs/heads/master@{#830562}
-
Guido Urdaneta authored
SubresourceFilterBrowserTest.DisallowedSubframeURLBlockedOnActivatedURL has been flaking repeatedly on Windows bots. Bug: 1152429 Change-Id: Ie1f1d5ccd2570d8d804869c8a15fdf2bed7ed42d TBR: blundell@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557081Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#830561}
-
Camille Lamy authored
Change-Id: Ic9f9e2aee6f6546b410eb654b1b5dfaaab4724e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556684Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Camille Lamy <clamy@chromium.org> Cr-Commit-Position: refs/heads/master@{#830560}
-
Swapnil authored
Many force installed extensions fail to install inside SandboxedUnpacker with error UNPACKER_CLIENT_FAILED error. We report a string that gives details about this error. We want to report this error detail through event based reporting. This CL is a pre work that reports detailed error to InstallStageTracker. Bug: b/173099675 Change-Id: I541ed65b209073bb9434db75567e94e955b4c64c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532082Reviewed-by:
Oleg Davydov <burunduk@chromium.org> Reviewed-by:
Saurabh Nijhara <snijhara@google.com> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Swapnil Gupta <swapnilgupta@google.com> Cr-Commit-Position: refs/heads/master@{#830559}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1606196878-31a6a989939947bbb9b6b52f3528a70f37f5b2e2.profdata to chrome-mac-master-1606218923-39c9d0a9fc77b1c3938c028a8199ea0790d9dbca.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I906d01766cb3c56d189d3cc672880ac07a976294 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557903Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#830558}
-
Greg Thompson authored
On Windows, ImportantFileWriter boosts its thread's priority for the moment it calls ::ReplaceFileW in the hopes that this will improve its chances of beating other processes (e.g., A/V scanners) that will try to open the files it needs. This change preserves the last error code coming out of a failure of ::ReplaceFileW for use in logging and metrics reporting. BUG=1145235 R=jdoerrie@chromium.org Change-Id: I1e275698c5c39fa7cfa97d6b3bf48e2023a8763f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556841 Commit-Queue: Greg Thompson <grt@chromium.org> Auto-Submit: Greg Thompson <grt@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#830557}
-