- 31 May, 2019 40 commits
-
-
Adithya Srinivasan authored
Portals can be activated in response to scroll events like overscroll and we want users to be able to continue scrolling after activation without tapping the screen again. This CL dispatches touch events targeted at the new ContentView after activation, which mirror where the pointers were before activation. Design doc: https://docs.google.com/document/d/12EsIEQIJAzh4-3aNQNhxoQ8Z7ayrSodmWbo06R9PbAQ/edit?usp=sharing Bug: 914376 Change-Id: I1ade7ac3da7451de14b38dd66056178cdcab7631 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1622906 Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#665179}
-
Chris Harrelson authored
This avoids even more complicated code in GraphicsLayerUpdater. I don't think the performance will be a big problem in the short term, and longer-term CAP obsoletes this code. Bug: 968488 Change-Id: Id88ee31b47449ce752b004dd911b3918d035fc9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636858 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#665178}
-
Suman Nelson Kancherla authored
Bug: 969024 Change-Id: I1af3edd08def4792c2162313eb5d98a55897a730 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637655 Commit-Queue: Suman Kancherla <sumankancherla@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#665177}
-
Alex Chau authored
- message_id is already provided by IncomingMessage - sent_time is already provided by FCM, can be added to IncomingMessage Bug: 966028 Change-Id: Ia6247f262659f0748ffaa4c81d61757dbf84c54b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636052 Auto-Submit: Alex Chau <alexchau@chromium.org> Commit-Queue: Peter Beverloo <peter@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#665176}
-
Leszek Swirski authored
When a ScriptResource receives a datapipe for the response body, it starts watching that datapipe for data. Previously, watching the data pipe meant calling ArmOrNotify on a mojo SimpleWatcher. If there is no data, then this arms the watcher to trigger a callback once data arrives; if there is data then it posts a task onto the loading task runner to trigger the callback "immediately". Unfortunately, script streaming can only be started in this callback. This means that if the data pipe already has enough data in its buffer to start streaming by the time the ScriptResource receives it (which appears to often be the case), we "waste" some time on task posting overheads, and potentially are blocked from starting streaming by other activity on the main thread. Locally I've seen latencies of >100ms between receiving a datapipe that has enough data to stream, and actually starting streaming it (with preload streaming enabled). So, when the data pipe is first received, if there is data in its buffer already we now immediately synchronously call its callback. Bug: 865098 Bug: 945321 Change-Id: I140975b92bf80febf59edaad3e19670b3bc5e529 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631374Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#665175}
-
Elly Fong-Jones authored
Also bump the milestone to provide more time to discuss the path forward for this feature. TBR=omrilio@chromium.org Bug: None Change-Id: I59907936b8a36dc919a485566a208269d90d0b31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638662Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#665174}
-
Sven Zheng authored
Add the pixel_browser_tests target to waterfall. This is an experimental target that do pixel testing. The test result relies on Skia Gold server so we want to isolate the target. The test can pass locally now and I need to see how it behaves on bots. Design doc(Internal): https://docs.google.com/document/d/1Mz72RHWyQKsT6jynrDNGbCaTKQIy_77qMjRM5gpsr_w/edit?usp=sharing Design doc(Public): https://docs.google.com/document/d/1uvXp0AKfemJ9e1TXM1nH3UTcVlDKISK2jFd_g2gstX0/edit?usp=sharing Bug: chromium:958242 Change-Id: Ifcef0e94e924ca7c98c4909a42f9e54d87041ff0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1623226 Commit-Queue: Sven Zheng <svenzheng@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#665173}
-
Giovanni Panaro authored
Increased the left padding on the Status Bubble from 3 to 5 and the right padding from 1 to 5. This way the URL looks less cramped. Bug: 959890 Change-Id: I08eb80a057d0ea00096fb28c06f5a93654894f79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1598028Reviewed-by:
-
Evan Stade authored
TBR=tsepez@chromium.org Bug: 958206 Change-Id: I66b1924d9ab0d49047a7ee3fe8d1b696b74ed726 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637865Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#665171}
-
Yusuke Sato authored
This fixes a problem introduced in CL:1592713. Without this fix, 'storage-android-running-changed' is sent to JS only when either of the following happens: - AllowJavascript() is called. - ARC is fully started. - ARC shuts down. However, storage-android-running-changed's listener on the JS side is registered only after AllowJavascript() is called. Because of this, if the Settings app is launched in the following way, |androidRunning_| variable in storage.js remains false and the 'Android storage' link never shows up. 1. Sign in. 2. ARC is fully started. 3. Settings app is launched. |androidRunning_| variable is false at this point. 4. AllowJavascript() is called. 5. 'storage-android-running-changed' is sent to JS, BUT there's no listener. 6. The user moves to Devices > Storage management. 7. storage-android-running-changed's listener is registered. 8. The JS sends 'updateStorageInfo' to the C++ side, but the C++ handler doesn't fire storage-android-running-changed. This CL changes the C++ handler code so that HandleUpdateStorageInfo() fires storage-android-running-changed with the up to date ARC status. The C++ handler used to do that, but CL:1592713 removed it by mistake. This CL restores the code. BUG=968580 Change-Id: If1d0a6d1597bffcb37b82c1e4c44746c4c201106 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637038 Commit-Queue: Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#665170}
-
Ben Pastene authored
This reverts commit ad780388. Reason for revert: "No tests matched by pattern(s) ..." eg: https://chromium-swarm.appspot.com/task?id=4527b399d8f02d10 And it didn't fail the task >.< Original change's description: > Skip 'dep:chrome_internal' Tast tests if we're not building w/ is_chrome_branded. > > So that no dep:chrome_internal tests are ran if they don't have the > needed internal bits. > > Bug: 947531 > Change-Id: I060734d2fe05c878d16f2c6a63815bd0abbb554c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637644 > Reviewed-by: Dan Erat <derat@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Commit-Queue: Ben Pastene <bpastene@chromium.org> > Cr-Commit-Position: refs/heads/master@{#665158} TBR=derat@chromium.org,dpranke@chromium.org,nya@chromium.org,bpastene@chromium.org Change-Id: I87ec89cfa30237e543f2f3e1830eb7f2b284bd83 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 947531 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638290Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#665169}
-
Xiaoqian Dai authored
When we requeste a tab's mobile version site, we overwrite the user agent's OS to Android OS so that the site can use its mobile version layout. In this CL, when overwriting the user agent - Update the Android version from Android 4.0.3 to Android 9 - Add "Chrome tablet" into its OS string - Change product name from "Chrome" to "Chrome Mobile" to increase the likelihood of sites adopting the user agent and displaying the mobile version sites. Bug: 953577 Change-Id: Ib72bd7abb1fa05dbcf9861b1d4d7ff8552c1f01d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637649 Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium f06b81d4. With Chromium commits locally applied on WPT: e90c6ef0 "NG/DL: Implement size containment (and display lock) for NG fieldset algo" abf2ac5e "webrtc wpt: avoid race conditions" 1bbbd106 "Add feature policy for client hints, used for third-party subresources." ab94a58b "Add the remaining Client Hints to Feature Policy." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: I137979642321ae8c6e8374dcb22d118b92c5b816 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638190Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#665167}
-
Sam Maier authored
Bug: 855796 Change-Id: If28592206e8eb5f985600b9932b81885a3baa01d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634802Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#665166}
-
Owen Min authored
Add code 413 Payload too large. This error is returned when the request is too large, usually caused by report uploading requests. Add this error so that we could publish metrics and setup retry logic based on it. Any exist error handling code treat the new error same as DM_STATUS_HTTP_STATUS_ERROR so there is no behavior change. Bug: 959398 Change-Id: Id4e1c1a82558bc56d870cc247f88e343ef38a9ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632533Reviewed-by:
Aga Wronska <agawronska@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#665165}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e90041ab4516..0817a0661743 Created with: gclient setdep -r src-internal@0817a0661743 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome BUG=chromium:790671,chromium:790669,chromium:790667,chromium:790665,chromium:790663,chromium:790662 TBR=melandory@google.com,hiroshige@google.com,mlamouri@google.com,loyso@google.com Change-Id: Id932cd57a61a0b9c2289a568733041458d85adab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638347Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#665164}
-
Carlos Caballero authored
MessageLoop will go away, eventually. ScopedTaskEnvironment will per default start a ThreadPool, which should be fine in most of the cases. If you belive your test needs to make sure that no ThreadPool runs let me know and I will update the patch. BUG=891670 This CL was uploaded by git cl split. R=tbansal@chromium.org Change-Id: Ie838d9dd2023eae0874ab0e79b2db1c682e07c57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635515Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Auto-Submit: Carlos Caballero <carlscab@google.com> Cr-Commit-Position: refs/heads/master@{#665163}
-
Elly Fong-Jones authored
Bug: None Change-Id: I849081ba93afa98227350759af1191e01bfc6246 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637053 Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org> Commit-Queue: Aaron Gable <agable@chromium.org> Cr-Commit-Position: refs/heads/master@{#665162}
-
Victor Vasiliev authored
R=rch@chromium.org Change-Id: I9860fcc880bc1c8a4ceaf94c80dddef69ce383aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637665Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Victor Vasiliev <vasilvv@chromium.org> Cr-Commit-Position: refs/heads/master@{#665161}
-
Lan Wei authored
In order to run the web-platform-tests automatically, we will use testdriver Action API in all the wpt to simulate inputs. Here we are changing some pointerevent input tests which have touch scroll actions. This is the seventh CL that changes part of the pointerevent input tests. Bug: 606367 Change-Id: If83fe7b4490e88fa113b06bdcc9e07af7f734149 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1622456Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#665160}
-
Jun Mukai authored
This reverts commit 43a59d74. Reason for revert: TabletModeControllerTest.InitializedWhileTabletModeSwitchOn is failing (or very flaky); see crbug.com/969070 Original change's description: > Mash cleanup: replace tablet_mode.mojom with C++ interface. > > This doesn't re-use TabletModeObserver, instead introducing > TabletModeToggleObserver (equivalent to old mojom::TabletModeClient), > because TabletModeObserver has other methods that don't seem like they > should be exposed as part of the public API. > > TBR=tsepez@chromium.org > > Bug: 958220 > Change-Id: I741578995ecc698777d9496c1dc6e5fd851d1478 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613564 > Reviewed-by: Evan Stade <estade@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Commit-Queue: Evan Stade <estade@chromium.org> > Cr-Commit-Position: refs/heads/master@{#664983} TBR=sky@chromium.org,dcheng@chromium.org,estade@chromium.org,tsepez@chromium.org Change-Id: Ib59cf7a279f09b26170ba5fcbd8488b9483f5f45 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 958220, 969070 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638682Reviewed-by:
Jun Mukai <mukai@chromium.org> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#665159}
-
Ben Pastene authored
So that no dep:chrome_internal tests are ran if they don't have the needed internal bits. Bug: 947531 Change-Id: I060734d2fe05c878d16f2c6a63815bd0abbb554c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637644Reviewed-by:
Dan Erat <derat@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#665158}
-
Christopher Cameron authored
Search-and-replace of the following: - views::BridgeFactoryHost -> remote_cocoa::ApplicationHost - remote_cocoa::BridgeFactoryImpl -> remote_cocoa::ApplicationBridge - remote_cocoa::mojom::BridgeFactory -> remote_cocoa::mojom::Application Also move views::BridgeFactoryHost from ui/views/cocoa to components/remote_cocoa/browser (because it should be accessible outside of views). Follow-on patches will move some of the Cocoa-centric methods from chrome::mojom::AppShim to remote_cocoa::mojom::Application (in fact, the chrome::mojom::AppShim interface is likely to be merged into remote_cocoa::mojom::Application in its entirety). R=ellyjones R=dominickn (mojo) TBR=avi (content/ entrails ownership) Bug: 958255 Change-Id: I6abec5bf5419dcf1b3cdbb9b7076a566c8af63cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635142 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:Dominick Ng <dominickn@chromium.org> Reviewed-by:
-
Lily Chen authored
This CL attempts to fix flakes in http/tests/security/cookies/base* tests due to recently added SameSite cookie deprecation messages. Bug: 966576 Change-Id: I71fc70225a4860555c90cc173ae2147faa731841 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637587Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Commit-Queue: Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#665156}
-
Victor Costan authored
Change-Id: I89e9c90a2a965dab70d27f6e23c47c4783ecd638 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637242 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Auto-Submit: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#665155}
-
Ben Pastene authored
There's some test configs under that dir that impact how the trybot runs. Change-Id: If3750624c8239130ca9916f796f8bf56a722bb92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638679 Commit-Queue: Ben Pastene <bpastene@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Auto-Submit: Ben Pastene <bpastene@chromium.org> Reviewed-by:
-
Ken Rockot authored
Also touches a few API edges in clients of the service where convenience seemed to outweigh churn. Bug: 955171 Change-Id: Ie6344c341c062606760fa9d333b95b620bf10e34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636722Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#665153}
-
Robert Liao authored
The code reextracted the same data from IDR_* strings as was specified already in the input struct. BUG=642920 Change-Id: Ie140919a5c30a8f1671cf737cf61ee65aa0c7d24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636678Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#665152}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/f99d7ad5c045..7919b877c3c1 git log f99d7ad5c045..7919b877c3c1 --date=short --no-merges --format='%ad %ae %s' 2019-05-31 dsinclair@chromium.org Close opened file handles. (#2644) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@7919b877c3c1 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel;luci.chromium.try:win_angle_deqp_rel_ng TBR=radial-bots+chrome-roll@google.com,cwallez@google.com Change-Id: I051dce2ab76ae53125a033a0844e11f7092972f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638484Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#665151}
-
dalyk authored
This change is a precursor to a follow-up change where secure and insecure cache lookups will occur separately. Secure lookups and insecure lookups are now separated into separate DnsTasks and cannot be combined in a result. This change also prevents SECURE mode from falling back to ProcTask. Bug: 878582 Change-Id: I7f5b1f5bcb1c205575c7c28bb066c55678fea466 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529731 Commit-Queue: Katharine Daly <dalyk@google.com> Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Reviewed-by:
Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#665150}
-
Henrique Grandinetti authored
This CL adds a method to the login data dispatcher that shows the parent access widget and uses it to only allow parents to change the clock when there is a child signed in or a child is a device owner. Bug: 921145 Change-Id: Ifd83760f8b9000576570f85c895d34c76c4c8bb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1621392Reviewed-by:
-
Ian Kilpatrick authored
I don't believe(?) there is actually a way to set the opacity on a viewport. (Either with the @viewport rule, or the style fixup[1]). This removes one of the unittests, and removes the logic which was reading the opacity from the viewport. [1] https://cs.chromium.org/chromium/src/third_party/blink/renderer/core/dom/document.cc?q=viewport_style&sq=package:chromium&dr=C&l=2122 Bug: 813068 Change-Id: I29d1b45c848c3ddca48a04523ec358094e97755b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637044Reviewed-by:
Aran Gilman <gilmanmh@google.com> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#665148}
-
Xiaohan Wang authored
CDM_10 CDM has been supported and shipped by default for a year and CDM_9 usage is very low. This CL removes CDM_9 interface support. Bug: 799219 Test: Tests updaetd. Change-Id: Icdc7f467ed977346734a1114b78b1261cbbfd0d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628837Reviewed-by:
John Rummell <jrummell@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#665147}
-
danakj authored
The ServiceManagerContext is set up after starting the browser threads, and the BatteryMetrics uses it on creation, so it should not be created before. This was working because ContentMain() creates a ServiceManagerContext and passes it to BrowserMain() in the StartupDataImpl. However Android browser tests do not do so (and doing so induces flakiness in the NestedMessagePumpAndroid), so this exposed a crash in these tests. R=jam@chromium.org Bug: 961849 Change-Id: I54b535b040ad3c10985b087aed0410ff0c731196 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637682 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
-
liberato@chromium.org authored
This CL allows out-of-order codec output buffer releases. Previously, discarding buffer n would release without rendering buffers 0..n-1 as well. However, in the case where a previous buffer had been selected for display, it might not have been used by the time the later release shows up. In that case, it would be dropped, then be unable to promote it for drawing later. This CL also changes MediaCodecBridge to allow out-of-order presentation timestamps. Originally, it discarded earlier ones to avoid a problem with spurious zero timestamps during seek. However, that also prevents it from processing edit lists correctly. Bug: 967892, 966512 Change-Id: I22246e49a5e0644957f6b644ccdf8a8d694259c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637612 Commit-Queue: Frank Liberato <liberato@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#665145}
-
Maks Orlovich authored
This reverts commit e102db8b. Reason for reland: Test fixed w/o NetworkService Also incorporates a follow up fix to dealing with network service reconnect. Original change's description: > Revert "RestrictedCookieManager: report activity to ContentBrowserClient" > > This reverts commit b128ac8e. > > Reason for revert: Some cookie tests failing on linux-chromeos-dbg > > The following tests are failing consistently when the network service is disabled (aka the non_network_service_browser_tests task)" > CookieSettingsTest.AllowCookiesUsingExceptions/1 > CookieSettingsTest.AllowCookiesUsingExceptions/3 > CookieSettingsTest.BlockCookiesUsingExceptions/1 > CookieSettingsTest.BlockCookiesUsingExceptions/3 > > Failure output: > ../../chrome/browser/content_settings/content_settings_browsertest.cc:390: Failure > Expected equality of these values: > 1u > Which is: 1 > blocked->GetCookieCount() > Which is: 0 > > Failing build: https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/12530 > > Original change's description: > > RestrictedCookieManager: report activity to ContentBrowserClient > > > > ...So that things done via async cookie-store API show up in used/blocked > > cookies GUI. > > > > This is done via NetworkContextClient, with some existing reporting via > > NetworkServiceClient converted to it, as in case of service worker it's > > not associated with process + routing ID pair. > > > > This now invokes ContentBrowserClient::OnCookie{sRead,Change} on IO, > > not UI, thread. > > > > Bug:958923 > > > > Change-Id: I7d1832ad30f57c67ea292481444a5e6ca07657df > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577493 > > Reviewed-by: Tom Sepez <tsepez@chromium.org> > > Reviewed-by: Matt Falkenhagen <falken@chromium.org> > > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > > Reviewed-by: Martin Šrámek <msramek@chromium.org> > > Commit-Queue: Maks Orlovich <morlovich@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#662253} > > TBR=falken@chromium.org,jam@chromium.org,tsepez@chromium.org,msramek@chromium.org,pwnall@chromium.org,mkwst@chromium.org,morlovich@chromium.org > > Change-Id: I4e587a04252b135a48f5e0d09414f62df65f9278 > Bug: 958923 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626207 > Commit-Queue: Timothy Loh <timloh@chromium.org> > Reviewed-by: Timothy Loh <timloh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#662541} Change-Id: Id6a4b2923f61f033b2ee9867fcbb7f741431438f Bug: 958923 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625906Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
-
danakj authored
The strict mode prevents NativeBrowserTestActivity from reading and writing files. We want browser tests to be able to do so. Insert StrictMode disablers as close as possible in test targets to where files are read or written. Example 1: 05-30 14:28:31.154 6733 6733 D StrictMode: at java.io.File.getTotalSpace(File.java:1669) ... 05-30 14:28:31.154 6733 6733 D StrictMode: at org.chromium.native_test.NativeBrowserTestActivity.deletePrivateDataDirectory(NativeBrowserTestActivity.java:86) 05-30 14:28:31.154 6733 6733 D StrictMode: at org.chromium.native_test.NativeBrowserTestActivity.onStart(NativeBrowserTestActivity.java:52) Example 2: 05-30 14:28:31.154 6733 6733 D StrictMode: at java.io.File.listFiles(File.java:1137) ... 05-30 14:28:31.154 6733 6733 D StrictMode: at org.chromium.native_test.NativeBrowserTestActivity.deletePrivateDataDirectory(NativeBrowserTestActivity.java:87) 05-30 14:28:31.154 6733 6733 D StrictMode: at org.chromium.native_test.NativeBrowserTestActivity.onStart(NativeBrowserTestActivity.java:52) Example 3: 05-30 14:28:31.155 6733 6733 D StrictMode: at dalvik.system.DexPathList.findLibrary(DexPathList.java:480) ... 05-30 14:28:31.155 6733 6733 D StrictMode: at org.chromium.base.library_loader.LibraryLoader.ensureInitialized(LibraryLoader.java:196) 05-30 14:28:31.155 6733 6733 D StrictMode: at org.chromium.content_shell.browsertests.ContentShellBrowserTestActivity.initializeBrowserProcess(ContentShellBrowserTestActivity.java:37) R=mheikal@chromium.org Bug: 961849 Change-Id: Iaacc6c76b56c4cd1d65e7ae348c359ab036d5610 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637532Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
-
Nate Chapin authored
These experiments have been rotting for several months. We may want to see about pushing an API like this in the future, but not soon enough to justify its continued existence in the repo. Some similar non-worker task-scheduling experiments were using the WorkerTaskQueue runtime enabled feature. Rename that flag to ScriptedTaskQueue to better described the remaining uses. Bug: 879306, 898050, 928819, 966950, 967066 Change-Id: Ib69898585fb7e31c78c7738e3bb02ede3834e959 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636224Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
-
Lan Wei authored
virtual/android/fullscreen/api/document-exit-fullscreen-vs-request.html is flaky on chromium.linux bots, because of recent change of user activation is consumed for fullscreen, disable it for now, we will fix once we confirm this change will be accepted. https://analysis.chromium.org/p/chromium/flake-portal/analysis/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vNzZjYTRlMDhjYzJiYWJlZWI2YzlmOGMwYWU2MjFjYzYxNTdmMTcwMgw Bug: 852645 Change-Id: Idd8799adf603f45c2e6c1de94cef8824c7de83c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636820Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#665141}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/94d5e05157f0..bc30e72cb429 git log 94d5e05157f0..bc30e72cb429 --date=short --no-merges --format='%ad %ae %s' 2019-05-31 jmadill@chromium.org Vulkan: Recycle command pools with vkResetCommandPool. Created with: gclient setdep -r src/third_party/angle@bc30e72cb429 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@google.com Change-Id: I747427be420452661704484229642f7d3e244a20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638506Reviewed-by:
-
