Commits · 545c7449e8b9d13860c1dbaca4c1d7dc143aad5f · eriksson monteiro / tangled

13 Nov, 2017 40 commits

Revert "In new-tab-Chrome-Home put the logo inside the RecyclerView." · 545c7449

Michael van Ouwerkerk authored Nov 13, 2017

This reverts commit 2518c6f4.

Reason for revert: RecyclerView crash as reported in
https://bugs.chromium.org/p/chromium/issues/detail?id=784238

Original change's description:
> In new-tab-Chrome-Home put the logo inside the RecyclerView.
> 
> Bug: 781163
> Change-Id: Id0957afdf125feeefb6dbfa36c9b3754552c735f
> Reviewed-on: https://chromium-review.googlesource.com/759002
> Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
> Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#515591}

TBR=bauerb@chromium.org,mvanouwerkerk@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 781163
Change-Id: I2850621a04dad0feb00f778d3ffe8374177294dd
Reviewed-on: https://chromium-review.googlesource.com/765807Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515936}

545c7449

Remove test cases under media/track/opera/interfaces/TextTrack/ · bd90c10d

Sriram authored Nov 13, 2017

Removing the following test cases infavor of the web platform tests
in html/semantics/embedded-content/media-elements/interfaces/TextTrack/

1. addCue.html
2. constants.html
3. cues.html
4. kind.html
5. label.html
6. language.html
7. mode.html
8. oncuechange.html
9. removeCue.html

Bug: 782555
Change-Id: Id06d6c0908993e5628f9b16069ff291bc29d21f6
Reviewed-on: https://chromium-review.googlesource.com/765868Reviewed-by: Fredrik Söderquist <fs@opera.com>
Commit-Queue: srirama chandra sekhar <srirama.m@samsung.com>
Cr-Commit-Position: refs/heads/master@{#515935}

bd90c10d

Add unified dromaeo benchmark · 59119ec1

Ned Nguyen authored Nov 13, 2017

Bug: 777664
Change-Id: Ib3341ab65ea528c8036115ff947bbe1f36b5c3bd
Reviewed-on: https://chromium-review.googlesource.com/765101Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#515934}

59119ec1

memory-infra: include computation of shared memory footprint as part of infra service output · c5fab709

Lalit Maganti authored Nov 13, 2017

This CL achieves the long present goal to compute the shared memory footprint
of each process in Chrome. It does this by utilising earlier work to perform
the computation and adds it to the existing struct of metrics reported
by the memory-infra service.

For more context, see https://goo.gl/3kPb9S

Bug: 781782
Change-Id: I6b9603e54ddd76e84fcb4898eb38d6be5c0c233f
Reviewed-on: https://chromium-review.googlesource.com/757139
Commit-Queue: Lalit Maganti <lalitm@chromium.org>
Reviewed-by: Erik Chen <erikchen@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Greg Kerr <kerrnel@chromium.org>
Reviewed-by: Primiano Tucci <primiano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515933}

c5fab709

Reland "Reland "Serialize MediaStreamTrack.stop() with getUserMedia()"" · 26387bf1

Guido Urdaneta authored Nov 13, 2017

This CL runs requests on the same task where they are issued if possible,
which is more similar to the way MST.stop() used to run.
If this is not enough to make the failing racy test pass, the only solution
is to disable the test on the bots where it fails.

Reusing haraken@ lgtm for the Blink part.

TBR=haraken@chromium.org

This is a reland of 7c8e8e13
Original change's description:
> Reland "Serialize MediaStreamTrack.stop() with getUserMedia()"
>
> This is a reland of a58c8bd6
> Original change's description:
> > Serialize MediaStreamTrack.stop() with getUserMedia()
> >
> > When multiple getUserMedia and stop() requests are active concurrently,
> > getUserMedia() sometimes fails with TrackStartError.
> > The reason is that the underlying video capture subsystem does not keep
> > a count of how many sources have opened a video device.
> > It can happen that a stop request stops video capture while a
> > getUserMedia() request is being processed, with the result being that
> > the video device is closed before getUserMedia() starts the new video
> > track, resulting in an error.
> >
> > One solution to this problem is to make sure that stop requests and
> > getUserMedia() requests cannot run concurrently, which is the approach
> > followed by this CL.
> >
> > This CL basically moves handling of MediaStramTrack.stop() from
> > MediaStreamCenter to UserMediaClient, and puts stop() requests in the
> > same queue used for getUserMedia() and applyConstraints() requests.
> >
> >
> > Bug: 778039
> > Change-Id: Id7e0ee38e40265fd599dc6dd0712f0b667d2e1a5
> > Reviewed-on: https://chromium-review.googlesource.com/751981
> > Reviewed-by: Kentaro Hara <haraken@chromium.org>
> > Reviewed-by: Henrik Boström <hbos@chromium.org>
> > Commit-Queue: Guido Urdaneta <guidou@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#515494}
>
> TBR=haraken@chromium.org
>
> Bug: 778039
> Change-Id: I461e3c98f3d6471cc218d48501d22c6c0a8b03e9
> Reviewed-on: https://chromium-review.googlesource.com/763636
> Commit-Queue: Guido Urdaneta <guidou@chromium.org>
> Reviewed-by: Guido Urdaneta <guidou@chromium.org>
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Reviewed-by: Henrik Boström <hbos@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#515836}

Bug: 778039
Change-Id: Idd2e1c95952b9c924037beaca987344093751009
Reviewed-on: https://chromium-review.googlesource.com/765657Reviewed-by: Henrik Boström <hbos@chromium.org>
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515932}

26387bf1

Revert "Use autolayout in LocationBarView" · 93cd0fae

Stepan Khapugin authored Nov 13, 2017

This reverts commit 46e29e03 (breaks ios tests).

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> Use autolayout in LocationBarView
> 
> Uses autolayout in LocationBarView to position the omnibox textfield.
> 
> Bug: 
> Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet
> Change-Id: If9f0f9ec65624785617bb3820d56509845f97e5e
> Reviewed-on: https://chromium-review.googlesource.com/709215
> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
> Reviewed-by: Rohit Rao (ping after 24h) <rohitrao@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#515911}

TBR=rohitrao@chromium.org,stkhapugin@chromium.org

Change-Id: I3a935b9525fb504af1e41314ef3d5b9f7aefa697
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet
Reviewed-on: https://chromium-review.googlesource.com/766047Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515931}

93cd0fae

Remove a UMA histogram for measuring DetachableResourceHandler duration · 4b2e8564

Yutaka Hirano authored Nov 13, 2017

Bug: 709910,759934
Change-Id: I265d4c376a9fb68e577c1b1412564a614b48fc91
Reviewed-on: https://chromium-review.googlesource.com/757988Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Takeshi Yoshino <tyoshino@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515930}

4b2e8564

Consent auditor prototype · 0d86260a

Martin Sramek authored Nov 13, 2017

This is a prototype of the consent auditor component.

This CL only lays out the component and adds the functionality to
record local consent plus tests.

The functionality to record consents in the user's Google account,
and any callsites, will come in subsequent CLs.

See the design doc for background:
https://docs.google.com/document/d/1Iu040VPbAPdulCpvbnOu1HLh0nXNJfuNMAEckdwmHWQ/

Bug: 781765
Change-Id: I1aef65249afe98c20db7aa692a7c3a007069e56b
Reviewed-on: https://chromium-review.googlesource.com/731423
Commit-Queue: Martin Šrámek <msramek@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Reviewed-by: Sky Malice <skym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515929}

0d86260a

[Signin][Android] Inline ProfileDataCache creation in AccountSigninView · a8e690d9

Boris Sazonov authored Nov 13, 2017

This CL inlines ProfileDataCache creation into AccountSigninView instead
of passing it to init methods. It simplifies both logic and interface of
AccountSigninView.

Bug: 783344
Change-Id: I39efcfd30f624907ddef7d9adbdeec0f916985a1
Reviewed-on: https://chromium-review.googlesource.com/761576Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515928}

a8e690d9

[Android] Restrict notification intent foreground flag to O+ · f9b078d0

Anita Woodruff authored Nov 13, 2017

- Only set the FLAG_RECEIVER_FOREGROUND flag on notification clicks
and closes when the sdk version is >= O.

Bug: 764437
Change-Id: I8a51f7cc7db670700ced543848c4bda092bf2248
Reviewed-on: https://chromium-review.googlesource.com/764148Reviewed-by: Peter Beverloo <peter@chromium.org>
Commit-Queue: Anita Woodruff <awdf@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515927}

f9b078d0

Remove media/track/opera/track/track-element test cases · 6a17fba2

Sriram authored Nov 13, 2017

Removing cloneNode.html and src-clear-cues.html infavor of the
existing web platform tests:
  html/semantics/embedded-content/media-elements/track/track-element/
    cloneNode.html
    src-clear-cues.html

Bug: 782555
Change-Id: Ibd98d32bb744ba16de51fa42210ff9492d8ef4a3
Reviewed-on: https://chromium-review.googlesource.com/765633Reviewed-by: Fredrik Söderquist <fs@opera.com>
Commit-Queue: srirama chandra sekhar <srirama.m@samsung.com>
Cr-Commit-Position: refs/heads/master@{#515926}

6a17fba2

Avoid track 'load' race in a few media/track/ tests · 0b5b9a51

Fredrik Söderquist authored Nov 13, 2017

In media/track/, the following tests seemed to exhibit the same timeout
behavior as track-kind.html:

  track-default-attribute.html
  track-load-error-readyState.html
  track-load-from-element-readyState.html

The default track could finish loading before the event handler was
added. Move the external <script>s earlier (to within <head>) and attach
event handlers before </video>.

Bug: 782095
Change-Id: I103e6d24a20f8b164a38a9014eae98528a6caf92
Reviewed-on: https://chromium-review.googlesource.com/757012
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Reviewed-by: srirama chandra sekhar <srirama.m@samsung.com>
Cr-Commit-Position: refs/heads/master@{#515925}

0b5b9a51

Users guide added for Network Traffic Annotations. · 2e7ffe4f

Ramin Halavati authored Nov 13, 2017

A users guide is added to docs/ for network traffic annotations.
Annotations proto file's comments are updated.

Bug: 656607
Change-Id: I524d0017a9b74c618b6f7088583706eab2bf0fcc
Reviewed-on: https://chromium-review.googlesource.com/753085Reviewed-by: Martin Šrámek <msramek@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515924}

2e7ffe4f

Revert "Enable render throttling for OOPIFs" · 584f5ac2

Colin Blundell authored Nov 13, 2017

This reverts commit 5abd7bfc.

Reason for revert: Suspected of causing PointerLockBrowserTest flake as detailed on crbug.com/784236.

Original change's description:
> Enable render throttling for OOPIFs
> 
> Throttle OOPIFs when they are off screen or clipped. This adds a
> VisibilityObserver to RemoteFrames with LocalFrame parents, and
> sends an update across processes to the OOPIF when throttling status
> should change.
> 
> This also fixes ScreenOrientation browser tests which has some
> flakiness in OOPIF tests that appears when this patch is applied.
> 
> Bug: 761478
> Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation
> Change-Id: I9bfb57058e534e796c23e238664a66a142be3c4a
> Reviewed-on: https://chromium-review.googlesource.com/719601
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
> Reviewed-by: Stefan Zager <szager@chromium.org>
> Commit-Queue: Ken Buchanan <kenrb@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#515875}

TBR=dcheng@chromium.org,kenrb@chromium.org,szager@chromium.org,alexmos@chromium.org

Change-Id: If713f93ff75ef4ea45853052fa05c3095f13e8aa
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 761478
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation
Reviewed-on: https://chromium-review.googlesource.com/765847Reviewed-by: Colin Blundell <blundell@chromium.org>
Commit-Queue: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515923}

584f5ac2

Rename SuspendableObject to PausableObject in comments and consts · 500392eb

Hajime Hoshi authored Nov 13, 2017

TBR=hajimehoshi@chromium.org

Bug: 780378
Change-Id: Ie3ced9c5c0a1914d9fa329d36209634d2ae55383
Reviewed-on: https://chromium-review.googlesource.com/763269Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515922}

500392eb

Inherit popup permission to incognito mode · bec18d37

Christian Dullweber authored Nov 13, 2017

This changes the popup permission to be inherited to incognito profiles.
While other content settings are not inherited due to security or privacy
concerns, inheriting sites allowed to show popups is save.

Bug: 762349
Change-Id: Ia31f6cea46edf8c705302ee4a414a40a8321756e
Reviewed-on: https://chromium-review.googlesource.com/672547Reviewed-by: Raymes Khoury <raymes@chromium.org>
Commit-Queue: Christian Dullweber <dullweber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515921}

bec18d37

service worker: Add a namespace in service_worker_database.cc for Jumbo · fe8d90c5

Matt Falkenhagen authored Nov 13, 2017

This is a follow up to https://chromium-review.googlesource.com/c/chromium/src/+/758869,
which added "ServiceWorker" to some of the constants. That approach seems misleading
since it looks like "ServiceWorkerKey" is a type of key on the same level as a "RegKey"
or "ResKey". Really we want to add "ServiceWorker" to all the constants, which we
can accomplish by making a namespace.

Bug: 746953
Change-Id: I61dffdaecffbeb088906f67907fdc47f0f81a5e1
Reviewed-on: https://chromium-review.googlesource.com/765556Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515920}

fe8d90c5

Explicitly reset preferred lang and text track state in media/track · 4e1293d3

Fredrik Söderquist authored Nov 13, 2017

Add cleanup handlers that resets "user preferred languages" and "text
track kind user preference", or just reset them outright, to see if this
has any bearing on the problem (works locally.)

Bug: 664844
Change-Id: I6237ace717fbaf6f5203d8a051950763547e191f
Reviewed-on: https://chromium-review.googlesource.com/757102Reviewed-by: srirama chandra sekhar <srirama.m@samsung.com>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#515919}

4e1293d3

[sensors] Check shared buffer mapping for PlatformSensorFusion · ea61b184

Mikhail Pozdnyakov authored Nov 13, 2017

This patch adds the missing DCHECK(mapping) to the PlatformSensorFusion::Factory
constructor, and fixes implementation of FakePlatformSensorProvider::GetMapping()
which otherwise caused the assertion hit on some test cases.

Change-Id: I6bd2d17c66bcc2bfed766a3a3cbc0ca7c5c846f9
Reviewed-on: https://chromium-review.googlesource.com/765487Reviewed-by: Alexander Shalamov <alexander.shalamov@intel.com>
Commit-Queue: Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com>
Cr-Commit-Position: refs/heads/master@{#515918}

ea61b184

Rewrite getUseMedia calls to use promises. · 674733a3

Patrik Höglund authored Nov 13, 2017

This removes many uses of waitForVideo() etc. and makes the
control flow of the test clearer. Instead of having the
all-events-occurred handler magically calling reportTestSuccess,
it's laid out explicitly in each test.

Bug: chromium:777857
Change-Id: I034d8950f764df607069b3e4b5ce6baeb46eab9b
Reviewed-on: https://chromium-review.googlesource.com/758848
Commit-Queue: Patrik Höglund <phoglund@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515917}

674733a3

Use scoped_refptr in blink::WebString · 19f35e26

tzik authored Nov 13, 2017

WebString no longer needs to use WebPrivatePtr.
This CL replaces it with scoped_refptr for cleaner impls.

Bug: 781741
Change-Id: Icacecc2e2a35b59c1d16780625643844b76cbbfb
Reviewed-on: https://chromium-review.googlesource.com/762971
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515916}

19f35e26

Remove dead left/right frame code in FormInputAccessoryView. · add28426

Elodie Banel authored Nov 13, 2017

Follow up to https://chromium-review.googlesource.com/c/chromium/src/+/721325

Bug: none
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I9caba1853bb8df851ceea954da9a222b82d6f3f3
Reviewed-on: https://chromium-review.googlesource.com/758653Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Commit-Queue: Elodie Banel <lod@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515915}

add28426

WPT tests for MediaStream.onaddtrack firing for remote tracks. · fd687b32

Henrik Boström authored Nov 13, 2017

Test added and passed.

Bug: 774303
Change-Id: I5b8d9a5494aacf8dad3b014788f5c9b5b4ca1f5d
Reviewed-on: https://chromium-review.googlesource.com/734332
Commit-Queue: Henrik Boström <hbos@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515914}

fd687b32

Enable ChildThreadImpl to refer ChildScheduler for IPC task runner · fe11b13e

Hajime Hoshi authored Nov 13, 2017

Now ChildThreadImpl needs to pass an IPC listener task runner to create
IPC::SyncChannel, but ChildThreadImpl can't refer schedulers. This CL
enables ChildThreadImpl to refer ChildScheduler by adding ChildScheduler
::IPCListenerTaskRunner function. Now the implementation
(RendererScheduler::IPCListenerTaskRunner) just returns base::
ThreadTaskRunnerHandle::Get().

This CL is just a preparation for flexible scheduling, and doesn't
change any behavior so far.

Bug: 780785
Change-Id: I46965cab95ca6f98dee56299df9ebea1462886d8
Reviewed-on: https://chromium-review.googlesource.com/760336Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515913}

fe11b13e

[LayoutNG] Update the inline position after overflow/rewind · bcea8bf5

Koji Ishii authored Nov 13, 2017

The line position after NGLineBreaker broke the line was rarely
used that HandleOverflow() and Rewind() did not update it.

CL:742041 started using the line position as the inline size of
the line to determine the layout opportunity. This patch updates
the line position on overflow/rewind cases.

Bug: 636993
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: Ic8799f310ca43efaa372d36ee6cd64b6796bf4fe
Reviewed-on: https://chromium-review.googlesource.com/750442Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515912}

bcea8bf5

Use autolayout in LocationBarView · 46e29e03

stkhapugin@chromium.org authored Nov 13, 2017

Uses autolayout in LocationBarView to position the omnibox textfield.

Bug: 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: If9f0f9ec65624785617bb3820d56509845f97e5e
Reviewed-on: https://chromium-review.googlesource.com/709215
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: Rohit Rao (ping after 24h) <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515911}

46e29e03

Null dereference in AXMenuList::DidUpdateActiveOption · f2357fd6

deejay authored Nov 13, 2017

This fixes a Null-dereference READ error in AXMenuList.

It can get a issue while adding children
in AXObject::UpdateChildrenIfNecessary.
We check HasChildren() before accessing children to fix it.

Bug: 780931
Change-Id: Ia8442643a7ba06114453084d8208d25393dab865
Reviewed-on: https://chromium-review.googlesource.com/753167
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515910}

f2357fd6

Add COMPONENT directive to os_crypt's OWNERS · d847a88c

Vaclav Brozek authored Nov 13, 2017

This adds a COMPONENT directive to //components/os_crypt/OWNERS, which
points to the right crbug.com component for os_crypt. The COMPONENT
directive has been added to OWNERS files recently (an example is
//components/password_manager/OWNERS) and is useful for developers
when filing bugs about known code locations. It is especially useful
for os_crypt, because neither the crbug.com component name nor its
description mentions "os_crypt", so it might be hard to find just by a
query in crbug.com.

Bug: None
Change-Id: I56f1f8289db573118f41a622d09e69aed3029e42
Reviewed-on: https://chromium-review.googlesource.com/765450Reviewed-by: Christos Froussios <cfroussios@chromium.org>
Commit-Queue: Vaclav Brozek <vabr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515909}

d847a88c

Prevent crash on ArcApplicationNotifierController on shutdown · 967c6b4b

yoshiki iguchi authored Nov 13, 2017

The clean-up code touched a profile after the profiles were destroyed. This
patch fixes this issue.

Bug: 783538
Test: none
Change-Id: If010a424e0fbcac2188eb5546c1e4917214dcbc2
Reviewed-on: https://chromium-review.googlesource.com/765635Reviewed-by: Daichi Hirono <hirono@chromium.org>
Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515908}

967c6b4b

Mark typedcssom/stylevalue-normalization/normalize-ident.html as failing on multiple builders. · a450ecc3

Takashi SAKAMOTO authored Nov 13, 2017

BUG=784278
TBR=dgozman

Change-Id: I79da59f309e7915b80f14cb882679f3788a245e3
Reviewed-on: https://chromium-review.googlesource.com/765640Reviewed-by: Takashi Sakamoto <tasak@google.com>
Commit-Queue: Takashi Sakamoto <tasak@google.com>
Cr-Commit-Position: refs/heads/master@{#515907}

a450ecc3

Hide MessageCenter asynchronously after the last notification is gone · e3c9d6e3

yoshiki iguchi authored Nov 13, 2017

We should not change the visibility of the message center during the notifications are being iterated. This patch makes the code of changing visibility executed asynchronously.

Bug: 782384
Change-Id: I36233312fdd5b3690b9c2e40597e51d8f16128e7
Reviewed-on: https://chromium-review.googlesource.com/762910
Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org>
Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515906}

e3c9d6e3

Reland "Run network service trybot when its test filters are modified." · 8ccd2b0b

John Abd-El-Malek authored Nov 13, 2017

This is a reland of 4470f02c. The webkit_lint fix had landed in r515892
Original change's description:
> Run network service trybot when its test filters are modified.
>
> Change-Id: I5d28f3512047871e436341f01b9bfd6e0baa2b8e
> Reviewed-on: https://chromium-review.googlesource.com/765575
> Reviewed-by: Ken Rockot <rockot@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#515890}

Change-Id: I73bd0931b2a1ef25db790dde6fa7e8e2fc4458ac
Reviewed-on: https://chromium-review.googlesource.com/765644Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515905}

8ccd2b0b

Fix links to servification.md. · ed64a6ad

Eric Roman authored Nov 13, 2017

Change-Id: I33ff7de2b8957516ce8d8b8dc0143264c8a2df69
Reviewed-on: https://chromium-review.googlesource.com/764519Reviewed-by: Colin Blundell <blundell@chromium.org>
Commit-Queue: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515904}

ed64a6ad

Roll src/third_party/catapult/ 388187b97..f4c21da08 (1 commit) · 8de9a4b2

catapult-deps-roller@chromium.org authored Nov 13, 2017

https://chromium.googlesource.com/catapult.git/+log/388187b9746c..f4c21da08850

$ git log 388187b97..f4c21da08 --date=short --no-merges --format='%ad %ae %s'
2017-11-10 benjhayden Fix more references to results2.

Created with:
  roll-dep src/third_party/catapult


The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: I6a0dfb2430652f6b98701e2c7f54a7a83e5f327d
Reviewed-on: https://chromium-review.googlesource.com/765216
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515903}

8de9a4b2

Fix TlsHandshakerTest.HandshakeWithAsyncProofVerifier · de002edb

Nick Harper authored Nov 13, 2017

Bug: b/69008819
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I2d7c9c77f19964227ba46c4e2c54b01c8124f346
Reviewed-on: https://chromium-review.googlesource.com/764795
Commit-Queue: Nick Harper <nharper@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515902}

de002edb

[jumbo] avoid ForwardRequest symbol clash · d80630e0

Mostyn Bramley-Moore authored Nov 13, 2017

content/browser/renderer_host/render_process_host_impl.cc also has a
ForwardRequest function in the anonymous namespace, which can collide
with the function in content/browser/renderer_interface_binders.cc

TBR=jam@chromium.org

Bug: 779444,746953
Change-Id: Iaa2c9f22ff0945b4a35fef689f2b60896d048fea
Reviewed-on: https://chromium-review.googlesource.com/765489
Commit-Queue: Mostyn Bramley-Moore <mostynb@vewd.com>
Reviewed-by: Sam McNally <sammc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515901}

d80630e0

Profile Chooser: Show ink drop highlight when buttons are focused. · 5226572e

Patti authored Nov 13, 2017

r515443 swapped out the custom higlighting in the Profile Chooser for ink drops
instead. However, this introduced a regression where the buttons would no longer
highlight on focus. Fix by turning on highlight on focus mode for ink drops.

Bug: 784235
Change-Id: Ib45cbbc82644279496bbab42e97406de96b4db7c
Reviewed-on: https://chromium-review.googlesource.com/765612
Commit-Queue: Trent Apted <tapted@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515900}

5226572e

Roll src/third_party/catapult/ aee17a9d0..388187b97 (1 commit) · b0230536

catapult-deps-roller@chromium.org authored Nov 13, 2017

https://chromium.googlesource.com/catapult.git/+log/aee17a9d0e6d..388187b9746c

$ git log aee17a9d0..388187b97 --date=short --no-merges --format='%ad %ae %s'
2017-11-10 benjhayden Move makeTestModel out of the global namespace in webview_startup_metric_test.

Created with:
  roll-dep src/third_party/catapult


The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: I74b33b34d0b574803ca09a74b8dc85972bdd4446
Reviewed-on: https://chromium-review.googlesource.com/764993
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515899}

b0230536

Move some sources shared across different test targets to test_support · 4a96be8a

Timothy Loh authored Nov 13, 2017

Bug: 783587
Change-Id: I4ffd2a49e0b8f4ae93074b867b079b9562ecf80e
Reviewed-on: https://chromium-review.googlesource.com/765609Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Timothy Loh <timloh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515898}

4a96be8a

Move ResourceRequestCompletionStatus to services/network/public/cpp · 8f988530

Takashi Toyoshima authored Nov 13, 2017

This patch moves content::ResourceRequestCompletionStatus from
content/public/common/ to services/network/public/cpp, and renames
it to URLLoaderStatus so to be consistent with mojom mapped type name.

TBR: jam@chromium.org, mkwst@chromium.org
Bug: 736308, 748491
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I7608eba2a3c0419b1cbc1cf08313ac71eeb2e9c3
Reviewed-on: https://chromium-review.googlesource.com/756822
Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Ben Wells <benwells@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515897}

8f988530