- 14 May, 2018 40 commits
-
-
Darren Shen authored
Just replacing NULLs with nullptrs. TBR as it is trivial. TBR=yhanada@chromium.org Change-Id: I498b81a926ec8cbd342735223f2c5e47624cb725 Reviewed-on: https://chromium-review.googlesource.com/1056453Reviewed-by:
Darren Shen <shend@chromium.org> Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#558242}
-
Han Leon authored
We reverted the original CL https://chromium-review.googlesource.com/c/chromium/src/+/981898 by https://chromium-review.googlesource.com/c/chromium/src/+/1041050 because we wanted to solve the crash in bug 838397 immediately at the time, but after that we have landed its real fix https://chromium-review.googlesource.com/c/chromium/src/+/1036498, so now we can reland this one. The only change from the original CL is that we do not re-enable the test ServiceWorkerLazyBackgroundTest#EventsAfterRestart in this CL, because it proved that this CL cannot really solve it, we need further investigation on it (tracker issue: 834200). BUG=745327,834183 TBR=shimazu,falken,kinuko Change-Id: Id5dedfc914b1526af2ea510ef890b768456982cf Reviewed-on: https://chromium-review.googlesource.com/1056796Reviewed-by:
Han Leon <leon.han@intel.com> Commit-Queue: Han Leon <leon.han@intel.com> Cr-Commit-Position: refs/heads/master@{#558241}
-
Matt Falkenhagen authored
I suspect the linked crash bug is due to ServiceWorkerProviderHost or ServiceWorkerHandle being deleted twice. Bug: 838410 Change-Id: I695978c0d7fdbe96ac0eb411bc6cac80854c2079 Reviewed-on: https://chromium-review.googlesource.com/1056782Reviewed-by:
-
Hajime Hoshi authored
The task runner is used at HandlePendingEventsAndPromises, and I think an unthorttled task runner is not necessary here. Note that the original task runner before kUnthrottled was the default timer task runner, which has gone. Related CLs: - https://chromium-review.googlesource.com/c/chromium/src/+/822931 Use the content's kUnthrottled task runner instead of the default timer task runner for FontFaceSet. - https://chromium-review.googlesource.com/c/chromium/src/+/928186 Remove the defualt timer task runner. We plan to eliminate kUnthrottled, kUnspecedTimer and kUnspecedLoading and replace them with appropriate kInternal* task types. Task type guideline: https://bit.ly/2vMAsQ4 Bug: 836410 Change-Id: I40fb6bd63ee657b68d86f952d6517254ffbf4b51 Reviewed-on: https://chromium-review.googlesource.com/1055031Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#558239}
-
Chromium WPT Sync authored
Using wpt-import in Chromium e9455026. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/17600 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: jsbell@chromium.org: external/wpt/resources TBR=markdittmer No-Export: true Change-Id: I8cdc2a65d0e01d3ab179b6ba154c0c286938ecc7 Reviewed-on: https://chromium-review.googlesource.com/1056331 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#558238}
-
Yuki Shiino authored
Change-Id: I00c7a48e7b978bf2a7d34d0deeb0c345b6e7f651 Reviewed-on: https://chromium-review.googlesource.com/1056899Reviewed-by:
Hayato Ito <hayato@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#558237}
-
Mirko Bonadei authored
Reason for revert: Breaks a WebRTC video test (speculative revert). Bug: libyuv:798, webrtc:9263 Change-Id: I1edcc8cde1f1ccf74b1b780faac9aace53750099 Reviewed-on: https://chromium-review.googlesource.com/1057087 Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Reviewed-by:
Patrik Höglund <phoglund@chromium.org> Cr-Commit-Position: refs/heads/master@{#558236}
-
Colin Blundell authored
The GCMAccountTracker and AccountTracker classes listen for the GoogleSigninSucceeded/GoogleSignedOut callbacks indirectly via ProfileIdentityProvider. Their unittests cause these callbacks to fire via calls to FakeIdentityProvider::{LogIn, LogOut}. These classes are also used on ChromeOS, where the callbacks will never fire (ChromeOS does not use SigninManager, which fires the callbacks). The structure of these unittests presents a challenge to refactoring the production code to depend on SigninManager directly: the SigninManagerBase test infrastructure, which is all that can be used on ChromeOS, rightfully has no mechanism for firing the callbacks. This CL rationalizes these tests for ChromeOS via: - Commenting out the tests that actually exercise the callbacks firing - Changing the rest of the tests to simply set the primary account info *without* causing the callbacks to fire - Renaming utility functions as relevant to make the structure clear Making this change paves the way for a followup change that ports these classes (and their tests) to depend directly on SigninManager. Bug: 809923 Change-Id: Ia6c067d845f7bbb7bd78928ac163bda2fdd77a20 Reviewed-on: https://chromium-review.googlesource.com/1042391Reviewed-by:Peter Beverloo <peter@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#558235}
-
Esmael El-Moslimany authored
Bug: 841509 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Idf57751875b2ffe762476b33f9b0af66f3ea76c8 Reviewed-on: https://chromium-review.googlesource.com/1054609Reviewed-by:
calamity <calamity@chromium.org> Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#558234}
-
Christian Dullweber authored
Change HistoryServiceObservers to use the new OnUrlsDeleted method for predictors and favicon_cache. Bug: 839798 Change-Id: Ibcf4d48eabe3649282c2246be73e8a8d263dc98d Reviewed-on: https://chromium-review.googlesource.com/1051888Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Alexandr Ilin <alexilin@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#558233}
-
Christian Dullweber authored
Change HistoryServiceObservers to use the new OnUrlsDeleted method. Bug: 839798 Change-Id: Ia5e01bcf60a43d7b1112f69f816a06e9ae1e51ab Reviewed-on: https://chromium-review.googlesource.com/1051767Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#558232}
-
Kent Tamura authored
Mark virtual/video-surface-layer/media/controls/modern/doubletap-to-jump-forwards-too-short.html flaky. TBR=steimel@chromium.org NOTRY=true Bug: 831720 Change-Id: I4c57a348bc782c74a26b1fd3a8f224b1a29004f0 Reviewed-on: https://chromium-review.googlesource.com/1056909Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#558231}
-
Mirko Bonadei authored
Abseil requires some warning suppressions that should not be propagated to other projects. Starting from this CL Abseil headers will be included using -isystem instead of -I. Bug: webrtc:8821 Change-Id: I54e0a9d4d9d7122e8fca91d61227f87160f0b373 Reviewed-on: https://chromium-review.googlesource.com/1026650 Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#558230}
-
arthursonzogni authored
This is similar to a previous CL: https://chromium-review.googlesource.com/c/chromium/src/+/1051908 All of these tests are using: window.onload = setTimeout([...], 0); The issue is that setTimeout is executed immediately instead of on load. Bug: 831155 Change-Id: I913b8c04de5d583ef87c91dfc23d4ba8be8ba642 Reviewed-on: https://chromium-review.googlesource.com/1055391Reviewed-by:
Nate Chapin <japhet@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#558229}
-
Kent Tamura authored
* normaliza_and_sort_includes(): - Fix the normalization. The output directory is now "gen/third_party/blink/", not "gen/blink/". - produce repo-root-relative paths instead of blink-relative paths. Bug: 830255, 842413 Change-Id: Ia99af5830f3cc67cb25e3e26ff24d0941f38effa Reviewed-on: https://chromium-review.googlesource.com/1056967 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#558228}
-
Mirko Bonadei authored
Chromium already has dynamic_annotations in //base/third_party and the Abseil version causes ODR violations and macros conflicts. On top of that, the Abseil version wants to include a NaCL header but the build environment does not configure the correct include path. Since NaCL doesn't need dynamic_annotations (see [1]) and they are also deprecated from Chromium (see [2]), this CL renames all the functions and the macros defined by the Abseil copy and confines the usage of Abseil's dynamic_annotations to Abseil itself (using GN visibility). When Abseil will be rolled into Chromium's third_party, a script will take care of renaming everything. [1] - https://cs.chromium.org/chromium/src/base/third_party/dynamic_annotations/BUILD.gn?l=6&rcl=b3c2f366fdcdbe3388b3fda45ae475d4e66dfa88 [2] - https://cs.chromium.org/chromium/src/base/third_party/dynamic_annotations/README.chromium?l=6&rcl=6ef06b461ccae125f8c8d6e33dde10c550ff3780 Bug: webrtc:8821 Change-Id: I83a4b6caafc30e457cf67fa21eaea9d071a9eecf Reviewed-on: https://chromium-review.googlesource.com/1049628Reviewed-by:
-
Yuta Kitamura authored
All overridden implementations of ThreadScheduler's interfaces are no-op, so they can be removed without breaking any functionalities. WebMainThreadScheduler's interfaces actually have some implementation. However, they are not used by any production code, and only a few tests depend on them. There functions are perhaps the remnants of past refactoring. Since nobody seems to rely on them currently, they can be removed entirely. Bug: 826203 Change-Id: Ic8efe0afe09270c080bc7706287937a6da354ae1 Reviewed-on: https://chromium-review.googlesource.com/1055142Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Reviewed-by:
-
Noel Gordon authored
Enabled in RELEASE, now re-enable in DEBUG/ASAN. Note MSAN is TIMEOUT so keep it disabled there. OpenAudioFiles/FileManagerBrowserTest.Test/1 TIMEOUT (3 in a row). Bug: 836254 Change-Id: I80e32f126d1e5594a863dc170cec399fb46afa12 Reviewed-on: https://chromium-review.googlesource.com/1056897 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Sasha Morrissey <sashab@chromium.org> Cr-Commit-Position: refs/heads/master@{#558225}
-
Matt Falkenhagen authored
This reverts commit 66a6b0b0. Reason for revert: This was a diagnostic for a crash bug that has been fixed, so it's no longer needed. Original change's description: > service worker: Add detailed bad message error message for Register. > > We are getting crash reports about "kBadMessageImproperOrigins" from > the Register message, so emit a more detailed message to help > debugging. > > These message are compact since there are only 256 characters > available for bad message error messages. > > Bug: 831255 > Change-Id: I932a78a625c92ffca626bb5b5dcb1128ecc623c0 > Reviewed-on: https://chromium-review.googlesource.com/1004892 > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Tsuyoshi Horo <horo@chromium.org> > Commit-Queue: Matt Falkenhagen <falken@chromium.org> > Cr-Commit-Position: refs/heads/master@{#549850} TBR=falken@chromium.org,horo@chromium.org,kinuko@chromium.org,shimazu@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 831255 Change-Id: Iea458ed43df35e63af83f8db99b03effd8276783 Reviewed-on: https://chromium-review.googlesource.com/1057027Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#558224}
-
Matt Falkenhagen authored
The test was disabled because Chrome didn't implement updateViaCache and the expected default behavior, but that has been enabled as an experimental feature for a while. Also, delete the corresponding version in http/tests, which used cache-control headers to workaround the lack of updateViaCache/expected behavior. Bug: 675540 Change-Id: Id95750c5c3a6d4c4d86d307bbce4477b9ee53df1 Reviewed-on: https://chromium-review.googlesource.com/1056755Reviewed-by:
-
Gauthier Ambard authored
This CL tries to fix the EG test for the TabSwitcher by making sure the incognito card of the TabSwitcher is interactable before trying to swipe it. Bug: 842082 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I25aa176aa63f1d228b2604d0b8b9f58f20297cad Reviewed-on: https://chromium-review.googlesource.com/1055388Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#558222}
-
Gauthier Ambard authored
This CL disable a sync EG test failing almost consistently on iPhone simulator iOS 10 and which is flaky on other configuration. As all the other tests of this test suite are disabled, I am disabling it instead of marking it as flaky, as there is probably something wrong with the whole test suite. Bug: 821490 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I5bada13c540bc3d95c2082109d3e9299b873cc39 Reviewed-on: https://chromium-review.googlesource.com/1054233Reviewed-by:
-
Timothy Loh authored
This reverts commit 738768f5. Reason for revert: Times out on MSAN https://ci.chromium.org/buildbot/chromium.memory/Linux%20ChromiumOS%20MSan%20Tests/7143 Original change's description: > Re-enable OpenAudioFiles/FileManagerBrowserTest > > Enabled in RELEASE, now re-enable this test in DEBUG/MSAN/ASAN. > > Bug: 836254 > Change-Id: Ie6ca28f923dcf70be407c8782985195874f47758 > Reviewed-on: https://chromium-review.googlesource.com/1056748 > Reviewed-by: Stuart Langley <slangley@chromium.org> > Commit-Queue: Noel Gordon <noel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#558168} TBR=noel@chromium.org,fukino@chromium.org,slangley@chromium.org Change-Id: Ib066688090f770c251b333db4446d92f52951a0e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 836254 Reviewed-on: https://chromium-review.googlesource.com/1056657Reviewed-by:
Timothy Loh <timloh@chromium.org> Commit-Queue: Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#558220}
-
Hayato Ito authored
Keep track of failing tests in media/controls for IncrementalShadowDOM. Bug: 776656 Change-Id: Ib0f09da71bdc49935875b2d0814336ea64b90d31 Reviewed-on: https://chromium-review.googlesource.com/1056750 Commit-Queue: Hayato Ito <hayato@chromium.org> Reviewed-by:
Takayoshi Kochi <kochi@chromium.org> Cr-Commit-Position: refs/heads/master@{#558219}
-
Noel Gordon authored
Document these tests, and change test names to match. Bug: 836254 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I156a6d5823e86d94b48b5706e3be9ba2c07562e0 Reviewed-on: https://chromium-review.googlesource.com/1056656Reviewed-by:
-
Noel Gordon authored
When you "create" a folder, it is "new". Ditch the "new" in these test names, make "CreateFolder" the common sub-string. The first test does some sort of selection before calling CreateFolder so prefix "select" in that test's name. No-Presubmit: true Bug: 836254 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ie559508c6688d0493ef0866635e35a1944e11cbc Reviewed-on: https://chromium-review.googlesource.com/1056450 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
-
Noel Gordon authored
The names of these tests is above and beyond. Provide a commomn prefix and shorten these names to something more sensible. Bug: 836254 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I6a903c3fd8fbe91654b4c6fdf67e8f0474bc24e2 Reviewed-on: https://chromium-review.googlesource.com/1056777Reviewed-by:
Luciano Pacheco (SYD) <lucmult@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#558216}
-
Timothy Loh authored
This reverts commit 6d0559c0. Reason for revert: Breaks ImageBitmapTest.AvoidGPUReadback on MSAN, e.g. https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium.memory%2FLinux_MSan_Tests%2F9783%2F%2B%2Frecipes%2Fsteps%2Fwebkit_unit_tests%2F0%2Flogs%2FImageBitmapTest.AvoidGPUReadback%2F0 Original change's description: > Use Skia's new simplified read/write pixels code paths > > Bug: 826819 > Change-Id: Ia6eaca75fe43f9d9ec94f8fe644a44e8e7436675 > Reviewed-on: https://chromium-review.googlesource.com/1054520 > Reviewed-by: Robert Phillips <robertphillips@google.com> > Commit-Queue: Brian Salomon <bsalomon@chromium.org> > Cr-Commit-Position: refs/heads/master@{#557943} TBR=bsalomon@chromium.org,robertphillips@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 826819 Change-Id: Ia4dca1186fbb79569672fbf5cdabd9657c702762 Reviewed-on: https://chromium-review.googlesource.com/1056847Reviewed-by:
-
Hajime Hoshi authored
The task runner is used at HandlePendingEventsAndPromises, and I think an unthorttled task runner is not necessary here. WebGLSync: The unthrottled task runenr was introduced at https://chromium-review.googlesource.com/c/chromium/src/+/906402 WebGLQuery and WebGLTimerQueryExt: The unthrottled task runner was introduced at https://codereview.chromium.org/2341043002 We plan to eliminate kUnthrottled, kUnspecedTimer and kUnspecedLoading and replace them with appropriate kInternal* task types. Task type guideline: https://bit.ly/2vMAsQ4 Bug: 836410 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I2cc48425aaef973432f8bdee6fbb111b0e9a9188 Reviewed-on: https://chromium-review.googlesource.com/1055369Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
-
Sam McNally authored
When a user does not have team drives enabled, DriveFS does not create a team_drives directory. If the team drives flag is enabled, file manager attempts to resolve the path to /team_drives within the mount, failing when DriveFS is enabled. Treat a missing /team_drives directory the same as when the team drives flag is disabled and leave teamDriveDisplayRoot_ set to null. Bug: 829274 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: If66fadd3a0e41ac420d43de144b89b489ffde1d6 Reviewed-on: https://chromium-review.googlesource.com/1056933Reviewed-by:
-
Noel Gordon authored
What it says on the tin, plus minor test comment updates. Bug: 836254 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Iefe801b3167629271826d457cf7b92473c902638 Reviewed-on: https://chromium-review.googlesource.com/1056774Reviewed-by:
-
Noel Gordon authored
Document the test, change test names to have a common prefix. Bug: 836254 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Id2304840000c7fbe69caa281e31f9f79d0cd1e0a Reviewed-on: https://chromium-review.googlesource.com/1056753Reviewed-by:
-
Noel Gordon authored
Use the same prefix for gear tests. Change test names for consistency with the rest of the integration test JS files. Bug: 836254 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I6348927f9df141e86fdccf484afae5d432c9b316 Reviewed-on: https://chromium-review.googlesource.com/1056651Reviewed-by:
-
Mike Wasserman authored
Make a shared helper for getting the window type from properties. Apply properties to the window like the old WindowTreeClient. Bug: 837695 Change-Id: Icfe1efcddb52b2c3ef9d3ed218e02c105885e230 Reviewed-on: https://chromium-review.googlesource.com/1056349 Commit-Queue: Michael Wasserman <msw@chromium.org> Reviewed-by:
-
Koji Ishii authored
Following bot results are included. 5407 5409 TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I9a4b34b49b723b49b4f3153141153fd0205497b2 Reviewed-on: https://chromium-review.googlesource.com/1056907 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#558208}
-
Hitoshi Yoshida authored
Some bindings code generator code depend on the paths of output directories to generate their contents. This CL changes the directory to output temporary files to test, and makes it possible to remove test-only hacks in code generators. Bug: 830255 Change-Id: I67b80489fcb3752679770cb56fa5c442c657b181 Reviewed-on: https://chromium-review.googlesource.com/1056778Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#558207}
-
Ramin Halavati authored
A minor bug in processing safe list in traffic annotation auditor is fixed. Bug: 690323 Change-Id: I76f6d023f88106bf69b6c5546142afb52e8e37c5 Reviewed-on: https://chromium-review.googlesource.com/1054877 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Georges Khalil <georgesak@chromium.org> Cr-Commit-Position: refs/heads/master@{#558206}
-
afdo-chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 The AutoRoll server is located here: https://afdo-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I516955bcf67b5c21b789efad2c90c046c70127ce Reviewed-on: https://chromium-review.googlesource.com/1056794 Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#558205}
-
Yutaka Hirano authored
Bug: 570946 Change-Id: Iba0dd0c5af2d44a8baff9c4e5764fb9a624f719c Reviewed-on: https://chromium-review.googlesource.com/1056929Reviewed-by:
Adam Rice <ricea@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#558204}
-
Hajime Hoshi authored
kInternalAnimation was introduced by replacing kUnspecedTimer, which is now kInternalDefault [1]. As we defined the task type guideline [2], the default behavior task runners should use kInternalDefault. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1009448 [2] https://bit.ly/2vMAsQ4, BUG: 836410 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ib5788929dce6331fc8deee8d93df9b351f6d83ca Reviewed-on: https://chromium-review.googlesource.com/1055353Reviewed-by:
-
