GitLab

Previously, |getIconResId| returned 36dp |text| icon, when it was
supposed to return |file| icon. This CL fixes this.

Bug:726611

Change-Id: I8763d313185ae6bdc2854a776f831b4900e7310b
Reviewed-on: https://chromium-review.googlesource.com/517062Reviewed-by: Min Qin <qinmin@chromium.org>
Reviewed-by: Theresa Wellington <twellington@chromium.org>
Commit-Queue: vitaliii <vitaliii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476223}

The devices that have FRE enabled shouldn't be allowed to powerwash. This
CL makes the keyboard shortcut for powerwash available only if the device
doesn't have FRE enabled.

BUG=724332
TEST=Manually tested for FRE enabled and FRE disabled functionality.

Review-Url: https://codereview.chromium.org/2898003002
Cr-Commit-Position: refs/heads/master@{#476222}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/de3ade508f3f..861d4a174136

$ git log de3ade508..861d4a174 --date=short --no-merges --format='%ad %ae %s'
2017-05-31 benjhayden Add HistogramSet.createHistogram() syntactic sugar.

Created with:
  roll-dep src/third_party/catapult


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: Ifb7e85f46b6d3e3b28934be63bff20f90ed1a12b
Reviewed-on: https://chromium-review.googlesource.com/520847
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476221}

This CL moves the Composition marker-specific functionality of DocumentMarker
into a new CompositionMarker subclass (similar to TextMatchMarker). I will do
the same for Spelling and Grammar markers in future CLs.

BUG=707867
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2908643002
Cr-Commit-Position: refs/heads/master@{#476220}

Remove code in LayoutTable and LayoutTableSection for computing outer
borders. Use cells' cached collapsed borders instead.

This is mostly a pure refactoring, except it affects some corner cases:
- Previously collapsed borders for colgroup were not included in table's
  border. See changes to results of
  paint/invalidation/table/cached-change-border-color.html.
- Previously when the row and the table were in different inline
  direction and the the width of some collapsed border was in odd
  number, the distribution of the 1 pixel into half outer and inner
  borders was inconsistent. Now we always give the 1 pixel in the
  same way defined in LayoutTableCell::CollapsedBOrderHalfXXX().
  See changes to results of fast/table/border-collapsing/002.html.

Change-Id: I74e6d9173e5d46933fa7456cb713c370e9e7d464
Reviewed-on: https://chromium-review.googlesource.com/515606
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: David Grogan <dgrogan@chromium.org>
Reviewed-by: Walter Korman <wkorman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476219}

BUG=728488
TBR=mathp@chromium.org

Review-Url: https://codereview.chromium.org/2919593006
Cr-Commit-Position: refs/heads/master@{#476218}

I forgot to update this when renaming FrameView to LocalFrameView in
https://chromium-review.googlesource.com/c/516862/

Bug: 637460
Change-Id: I71e6b770746a58cde6e726fe6356c627c5b8d419
Reviewed-on: https://chromium-review.googlesource.com/520825Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476217}

We're adding DISALLOW_COPY_AND_ASSIGN to CompositionMarker in
https://codereview.chromium.org/2908643002 and to SpellingMarker and
GrammarMarker in https://codereview.chromium.org/2911723002, so we should add
it to TextMatchMarker as well for consistency.

BUG=707867

Review-Url: https://codereview.chromium.org/2916753003
Cr-Commit-Position: refs/heads/master@{#476216}

This patch removes the use of PassRefPtr in ComputedStyle where a
PassRefPtr is returned by a function.

BUG=494719

Review-Url: https://codereview.chromium.org/2912043002
Cr-Commit-Position: refs/heads/master@{#476215}

Network traffic annotation is added to network requests of
google_apis/gaia/gaia_oauth_client.cc
google_apis/gaia/oauth2_access_token_fetcher_impl.cc

BUG=656607

Review-Url: https://codereview.chromium.org/2796293003
Cr-Commit-Position: refs/heads/master@{#476214}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/3692957d..908a6304

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2916023002
Cr-Commit-Position: refs/heads/master@{#476213}

https://drafts.csswg.org/css-tables-3/#repeated-headers has been updated since
we first implemented them. Respect the new rules such as only repeating headers
if they fit on at most a quarter of the page. We also need to repeat headers
even if only part of a row fits on the page - respecting this rule requires us
to reintroduce allowing nested repeated headers, something that both Edge and
FF do and which is now supported by the spec.

BUG=720620, 675904

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2882043002
Cr-Commit-Position: refs/heads/master@{#476212}

This change is based on the discussion on a chormium-dev
thread titled "ScopedAllowIO ban isn't preventing usage,
it's just annoying people" where jam@ mentioned "Excluding
test files seems like a good change to me."

TEST=tested locally by adding ScopedAllowIO to a random browser test file with and without this change

Review-Url: https://codereview.chromium.org/2911153002
Cr-Commit-Position: refs/heads/master@{#476211}

BUG=727566
TEST=none
TBR=nharper,mattm

Change-Id: I2cc60aa1b3a15d4eb6a3c027a49e5b487dadb4c2
Reviewed-on: https://chromium-review.googlesource.com/520668Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476210}

R=scottmg@chromium.org
BUG=706592, 707029

Review-Url: https://codereview.chromium.org/2913263003
Cr-Commit-Position: refs/heads/master@{#476209}

Previously landed in r474253 but was still flaky. After attempting
various things, it seems impossible to guarantee the behaviour of
interactive_test_utils:: ClickOnView() on Mac when the target window is
inactive. BrowserActionInteractiveTest is just using ClickOnView to
activate the parent browser window anyway so, on mac, do that
explicitly.

Original message: These were never brought up since they were added in
r229777 (2013). How they are disabled is subtle:
BrowserActionInteractiveTest::ShouldRunPopupTest() returns false on Mac
and the test passes.

The linked bug indicates an error that an existing test extension
repros. This CL brings up the test harness (without changing non-test
code) since the tests may yet be flaky on Mac.

The original problem was,
  // TODO(justinlin): Browser window do not become active on Mac even when
  // Activate() is called on them. Enable when/if it's possible to fix.

Resolve this by invoking BringBrowserWindowToFront(browser()) at the
start of the test on mac and explicitly waiting for the popup window to
be reported as active by the OS.

BUG=428044, 726132

Review-Url: https://codereview.chromium.org/2908983002
Cr-Commit-Position: refs/heads/master@{#476208}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/e6ad06342efb..de3ade508f3f

$ git log e6ad06342..de3ade508 --date=short --no-merges --format='%ad %ae %s'
2017-05-31 bpastene Revert of devil: Add physical port num to device_status.py (patchset #2 id:20001 of https://codereview.chromium.org/2914063002/ )
2017-05-31 sullivan Fix exception in presubmit when a change has not been uploaded.
2017-05-31 dtu [pinpoint] Rename isolated to isolate.
2017-05-31 bpastene devil: Add physical port num to device_status.py
2017-05-31 rnephew [Telemetry] Add ability to disable stories on android webview.

Created with:
  roll-dep src/third_party/catapult
BUG=719093,719093,713222


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: Ie60a7867d795a9b1dd42c9abc256f471a38783da
Reviewed-on: https://chromium-review.googlesource.com/520691
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476207}

This CL makes ScriptLoader use the Modulator of the context document
instead of the element document.
This is consistent with classic scripts for which we use context
document's ScriptController for execution.

BUG=721070

Change-Id: Ib5388e28e91d16b196bb579ee171ac8e0f48ddcc
Reviewed-on: https://chromium-review.googlesource.com/517766
Commit-Queue: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Takayoshi Kochi <kochi@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476206}

With the introduction of wm_public_export.h by commit 3b086a00:
("ui: extract ui/wm/public from aura target"), it now makes sense
to have a more specific name for this export file.

BUG=654078, 308710

Change-Id: I5ebbb50b09a7129b1ac23d1b0da877171551f3d3
Reviewed-on: https://chromium-review.googlesource.com/520762Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Thiago Farina <tfarina@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476205}

This change adds third_party/openvr so we can target OpenVR on desktop.

As said in README.chromium, this is a copy of files from the OpenVR git repository.

BUG=644793

Review-Url: https://codereview.chromium.org/2754253003
Cr-Commit-Position: refs/heads/master@{#476204}

When issuing raster invalidation, try to pair clients' old visual
rects and new visual rects. If paint invalidation reason is
kIncremental, issue raster invalidation for the difference between
the old visual rect and new visual rect.

BUG=644358

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I0b4058a24b868b541b222e579ab093f6b6498631
Reviewed-on: https://chromium-review.googlesource.com/513589
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Chris harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476203}

BUG=636993
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng

Review-Url: https://codereview.chromium.org/2912273002
Cr-Commit-Position: refs/heads/master@{#476202}

This patch wires up the correct message text for modal permission
prompts in the PermissionRequestManager code-path.

BUG=606138

Review-Url: https://codereview.chromium.org/2897223002
Cr-Commit-Position: refs/heads/master@{#476201}

Original tests are flaky because they rely on unwarranted order how
Chrome issues network requests.

New test does not check expectations in an expected order, but
just check if cache control flag is expected one for each resource.

BUG=726364, 728060

Change-Id: Idb2367a259f22779581ac59b0c0017cd1256f3b9
Reviewed-on: https://chromium-review.googlesource.com/519283Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476200}

https://pdfium.googlesource.com/pdfium.git/+log/9c6b37c469e3..5be0b291bce2

$ git log 9c6b37c46..5be0b291b --date=short --no-merges --format='%ad %ae %s'
2017-05-31 wileyrr Add public #defines for line cap and line join values.

Created with:
  roll-dep src/third_party/pdfium


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


TBR=dsinclair@chromium.org

Change-Id: Icb4fd033da77edbaf82f7a4732dd196f7fa5d751
Reviewed-on: https://chromium-review.googlesource.com/520667
Reviewed-by: <pdfium-deps-roller@chromium.org>
Commit-Queue: <pdfium-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476199}

NaClIPCAdapter has a ref count and a NaClDesc retains the reference to
it, and an IPC::Channel has a raw pointer to the NaClIPCAdapter as a
IPC::Listener without retaining a reference.

When NaClDesc releases NaClIPCAdapter and it's being destroyed, it
schedules a task to destroy the channel. However, there's a gap between
the NaClIPCAdapter destruction and the channel destruction, and a chance
for the channel to call OnChannelError on NaClIPCAdapter, that causes
an UAF.

After this CL, NaClDesc closes the channel before it releases NaClIPCAdapter.

BUG=719942
TBR=dschuff@chromium.org

Review-Url: https://codereview.chromium.org/2876493002
Cr-Commit-Position: refs/heads/master@{#476198}

BUG=717442
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2914773002
Cr-Commit-Position: refs/heads/master@{#476197}

When an Element is set as the root scroller, it's overflow clipping
rect may differ from its border box. This is done so that hiding the
URL bar doesn't change the contents in any way but does reveal
overflowing content. Currently, this is done by returning the viewport
size from LayoutBox::OverflowClipRect.

IFrames work somewhat differently than other LayoutBoxes as they don't
just have a simple overflow clip. This patch adds a special case for
when the root scroller is an iframe. In that case, we set the iframe
to be in non-LayoutSizeFixedToFrameSize mode which is the mode the
main Frame currently operates in. We then ensure that the FrameRect and
LayoutSize are kept in sync with its parent Frame.

Bug: 505516
Change-Id: I9625da4c49cf5db478c60787f0fdb78116a92200
Reviewed-on: https://chromium-review.googlesource.com/518426
Commit-Queue: David Bokan <bokan@chromium.org>
Reviewed-by: Steve Kobes <skobes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476196}

BUG=727566
TEST=none
TBR=nharper,mattm

Change-Id: I4755bcab5dda2c908b420b9db933351b2c1e9a56
Reviewed-on: https://chromium-review.googlesource.com/520732Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476195}

BUG=727989
TBR=sky@chromium.org

Review-Url: https://codereview.chromium.org/2919703002
Cr-Commit-Position: refs/heads/master@{#476194}

is invoked instead of relying on comments.

BUG=716563

Review-Url: https://codereview.chromium.org/2914853002
Cr-Commit-Position: refs/heads/master@{#476193}

Previously, NotifyError was called before delegate_ was assigned to
which meant that the delegate was not notified of any errors.

Review-Url: https://codereview.chromium.org/2918663002
Cr-Commit-Position: refs/heads/master@{#476192}

Remove duplicates from translate_manager_unittest and translate_ui_delegate_unittest.

BUG=727436

Review-Url: https://codereview.chromium.org/2906233004
Cr-Commit-Position: refs/heads/master@{#476191}

Also enable media_blink_tests on Android bots to prevent this from
happening again.

Note that platform Opus is only supported on Android L and above.
Therefore some tests may fail on older devices (e.g. KitKat). This
difference isn't really interesting to KeySystemConfigSelectorTest
though.

In a future CL, I will fix the test further to make it work on older
devices.

BUG=727783
TEST=Fixes existing tests and enable tests on more bots.

Change-Id: I93becd70216575122e149bd89fb77e4d506d332f
Reviewed-on: https://chromium-review.googlesource.com/518626Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Benjamin Pastene <bpastene@chromium.org>
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476190}

Review-Url: https://codereview.chromium.org/2921523002
Cr-Commit-Position: refs/heads/master@{#476189}

https: //chromium.googlesource.com/chromium/src/+/master/styleguide/c++/c++.md#Unnamed-namespaces
Review-Url: https://codereview.chromium.org/2909543003
Cr-Commit-Position: refs/heads/master@{#476188}

This change removes the static method interface from CSSVariableResolver.
Users of the class now need to instantiate an instance of it to use its
functionality.
This change is in preparation for making variable resolution co-recursive
with registered custom property animation application. The object interface
is required to be able to persist variable resolution state throughout the
recursion.

This patch introduces no changes in behaviour.

BUG=671904

Review-Url: https://codereview.chromium.org/2878853002
Cr-Commit-Position: refs/heads/master@{#476187}

This enum is only used by TextMatch markers and should be defined in
TextMatchMarker.

BUG=707867
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2907643004
Cr-Commit-Position: refs/heads/master@{#476186}

renamed TaskRunner::RunsTasksOnCurrentThread() to
TaskRunner::RunsTasksInCurrentSequence() in //net

BUG=665062
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2894863002
Cr-Commit-Position: refs/heads/master@{#476185}

https://codereview.chromium.org/2897833002 unintentionally broke WebMidi for
insecure origins. This CL fixes that and adds a test.

BUG=727699

Review-Url: https://codereview.chromium.org/2914963002
Cr-Commit-Position: refs/heads/master@{#476184}