- 05 Dec, 2017 40 commits
-
-
Paul Jensen authored
NetworkHandles should be supported in Lollipop and newer releases. Change-Id: Ia19095b883926daf97456d81201a3e8d93859467 Reviewed-on: https://chromium-review.googlesource.com/809224 Commit-Queue: Paul Jensen <pauljensen@chromium.org> Reviewed-by:
Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#521814}
-
Scott Violet authored
Previously the code queried TestScreen. This is problematic as content_browsertests uses TestScreen, which *always* returns a display id of 2000. When mus gets the event the event is then dropped (because it doesn't know about 2000). This changes EventInjector to query WindowTreeHost and has WindowTreeHostMus override GetDisplayId() to return the real display id. BUG=786453 TEST=none Change-Id: I01b9ce9096a0a3e7d6ca9cf85706afb0213035a7 Reviewed-on: https://chromium-review.googlesource.com/809493Reviewed-by:
Elliot Glaysher <erg@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#521813}
-
Dale Curtis authored
This has been unnecessary in the past with YouTube VP9 encodings, but for some reason other VP9 encoding types show artifacts if the configuration change is not processed. BUG=729600 TEST=no more artifacts on http://dashjs.eb.epiclabs.io/ Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Id91f112ff8a1f1877cade3e8a86af39b05ff80a0 Reviewed-on: https://chromium-review.googlesource.com/802629 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#521812}
-
Nate Fischer authored
This removes the final use of BuildInfo.isAtLeastO from chromium code. This was previously blocked on robolectric not supporting O (but this has since been resolved by crbug.com/729135). Bug: 783418 Test: ninja chrome_junit_tests Change-Id: Ib7d4af9ff74912ccadfa3c9cae57553f3a217e94 Reviewed-on: https://chromium-review.googlesource.com/806745Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#521811}
-
Chromium WPT Sync authored
Using wpt-import in Chromium a3ce2d31. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/6949 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=qyearsley No-Export: true Change-Id: I1855fb7a5a8fdc38751eea78ed990db382a84f5f Reviewed-on: https://chromium-review.googlesource.com/809188 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#521810}
-
Hiroshige Hayashizaki authored
This CL only adds |const| to SecurityOrigin and thus doesn't change the behavior. This CL replaces most of - WebPrivatePtr<SecurityOrigin> -> WebPrivatePtr<const SecurityOrigin> - scoped_refptr<SecurityOrigin> -> scoped_refptr<const SecurityOrigin> - SecurityOrigin* -> const SecurityOrigin* - SecurityOrigin& -> const SecurityOrigin& Most of the modifications are done mechanically by PCRE: s/(WebPrivatePtr<|scoped_refptr<|((?<!const)\s+)|\(|^)((::)?blink::)?SecurityOrigin([&\*>])/$1const $3SecurityOrigin$5/g The following SecurityOrigin references remain non-const: - SecurityContext::security_origin_ - SecurityContext::GetMutableSecurityOrigin() - ExecutionContext::GetMutableSecurityOrigin() - Document::UpdateSecurityOrigin() - RemoteSecurityContext::SetReplicatedOrigin() - SecurityOrigin::IsolatedCopy() - Some local variables - Some methods in unit tests (For isolated world SecurityOrigin for XHRs) - IsolatedWorldSecurityOriginMap - XMLHttpRequest()::isolated_world_security_origin_ - XMLHttpRequest::XMLHttpRequest() - XMLHttpRequest::GetMutableSecurityOrigin() - DOMWrapperWorld::IsolatedWorldSecurityOrigin() - DOMWrapperWorld::SetIsolatedWorldSecurityOrigin() (For blob SecurityOrigins) - BlobURLOriginMap - SecurityOrigin::Create.*() - URLRegistry::RegisterURL() - BlobRegistry::RegisterPublicBlobURL() - URLSecurityOriginMap::GetOrigin() Bug: 779730 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ie4a1a5cc2add20c1c1b9d0d6d5dff9ea9ec46240 Reviewed-on: https://chromium-review.googlesource.com/744586 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#521809}
-
Lei Zhang authored
Also rewrite some if-else statements without if (!cond). Change-Id: If70a32a7baa5d2e70480831646ebf46eea8b8993 Reviewed-on: https://chromium-review.googlesource.com/804833Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#521808}
-
Thoren Paulson authored
Before, we weren't packaging localized pak files with the Android cast shell, and ResourceBundle wasn't looking in the APK assets for these pak files. Bug: internal b/70031131 Test: CQ and tried it out with an Android build Change-Id: I65adbaf552dfce6be62c4c4035d221f42b330c4d Reviewed-on: https://chromium-review.googlesource.com/807406Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Thoren Paulson <thoren@chromium.org> Cr-Commit-Position: refs/heads/master@{#521807}
-
Vladimir Levin authored
This patch ensures that we initialize all font creation params before reading them and abort creating a typeface if the reader is invalid. R=enne@chromium.org, ericrk@chromium.org Bug: 785675 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I7baabeb460c9cb06026c8a82989c7c6f7e970f8f Reviewed-on: https://chromium-review.googlesource.com/808748Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#521806}
-
Xiaohan Wang authored
This makes it much easier to analyse CDM crashes. Tested with --enable-crash-reporter-for-testing, which will upload a crash report and print a crash ID to stdout. Then confirmed that we have the CDM version in the crash report. See crash ID 27c2f5df78d977e227 for an example crash. BUG=788937 Change-Id: Ifa565f0d01a78cfef2329704ea3bc3feb9a5723a Reviewed-on: https://chromium-review.googlesource.com/792258 Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#521805}
-
Ryan Landay authored
This test is intermittently failing. Based on the screenshots from the failing try bots, it appears the issue is that the test is tapping at the beginning of "hello world" instead of at the end. I'm unable to reproduce the problem locally, but my best guess as to why this is happening is that we're not waiting to make sure the text has actually been committed before attempting to find the bounds of the span element that's supposed to be after the text, so I'm adding this check (which we also have in testDeleteWordMarkedWithSpellingMarker()). Bug: 789954 Change-Id: I06b85282057c361adc9da3f6ee289870ecf0c164 Reviewed-on: https://chromium-review.googlesource.com/802187Reviewed-by:
Changwan Ryu <changwan@chromium.org> Commit-Queue: Ryan Landay <rlanday@chromium.org> Cr-Commit-Position: refs/heads/master@{#521804}
-
Daniel Bratell authored
There were code in ui/views that didn't know about the class property type specialization for gfx::Insets* and Views* so they got the default template implementation. In jumbo builds the compiler noticed that there was code using the default implementation before the specialization appeared and it triggered a compilation error. The fix is to declare the specialization so that all code uses it. Bug: 773275 Change-Id: Ifa925a2002ba930af16dc6940a04b2a480721438 Reviewed-on: https://chromium-review.googlesource.com/786190Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
David Reveman <reveman@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#521803}
-
bsheedy authored
Refactors waitOnJavaScriptStep to be more strict. The behavior should be identical to the old implementation except: 1. Attempting to use waitOnJavaScriptStep without the proper JavaScript code to do so results in a failure. 2. JavaScript test failures that occur while waiting for a step are caught and reported immediately instead of whenever Java calls endTest. Bug: Change-Id: I2ce955f31c6c90355400f42b2f66c5ff4b042538 Reviewed-on: https://chromium-review.googlesource.com/809386Reviewed-by:
agrieve <agrieve@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#521802}
-
Randy Smith authored
Bug: 721395 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I8a2cd64bc04c33fa984af3ebff7d053738f5ccd4 Reviewed-on: https://chromium-review.googlesource.com/806355Reviewed-by:
Helen Li <xunjieli@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Randy Smith <rdsmith@chromium.org> Cr-Commit-Position: refs/heads/master@{#521801}
-
Christian Fremerey authored
This is a reland of 1e2e99ef The reason for the revert was a Webkit layout test failing with this CL. With https://chromium-review.googlesource.com/c/chromium/src/+/806442 landed to fix that test, this CL should now be able to reland without modification. Original change's description: > Enable video capture service by default on platforms where it is rolling > out with M61. > > Bug: 721812 > Change-Id: I1de0f625a1fb106e2dea664675e94267e66fc2fd > Reviewed-on: https://chromium-review.googlesource.com/719416 > Commit-Queue: Christian Fremerey <chfremer@chromium.org> > Reviewed-by: Emircan Uysaler <emircan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#517761} TBR=emircan@chromium.org Bug: 721812 Change-Id: If69cdb660b0b97a28084b6bd0610234d5abb232f Reviewed-on: https://chromium-review.googlesource.com/809530Reviewed-by:
Christian Fremerey <chfremer@chromium.org> Commit-Queue: Christian Fremerey <chfremer@chromium.org> Cr-Commit-Position: refs/heads/master@{#521800}
-
Jungshik Shin authored
IDS_EXTENSION_PROMPT_RATING_ACCESSIBLE_TEXT is compliant to the ICU message format spec (so, the unittest passes), but it's rejected by the translation infra's ICU msg syntax checker because it has additional constraints on the ICU syntax: A plural selector should be at the outer most level. Rewrite it to work with the translation infra. Bug: 791716 Test: browser_test --gtest_filter=Extensi*.RatingsSectionA11y Change-Id: Id88bad4554b106acebe20064fab8870e03a44843 Reviewed-on: https://chromium-review.googlesource.com/807353 Commit-Queue: Jungshik Shin <jshin@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#521799}
-
webrtc-autoroll@chromium.org authored
https://webrtc.googlesource.com/src.git/+log/83d27683a83d..c3da1e61bccf $ git log 83d27683a..c3da1e61b --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG=None,None,None,None,None,None,None,None,None,None,None,None,None,None,None,None,None,None,None The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I442acc10a3cf7a445c3cf847ae34a6661ae7174c Reviewed-on: https://chromium-review.googlesource.com/809326Reviewed-by:
WebRTC Roll Bot <webrtc-autoroll@chromium.org> Commit-Queue: WebRTC Roll Bot <webrtc-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#521798}
-
Luna Lu authored
Bug: 761003 Change-Id: If6404fb5ee6866777ccd2bfacce1f7d235fdd17b Reviewed-on: https://chromium-review.googlesource.com/794047 Commit-Queue: Luna Lu <loonybear@chromium.org> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#521797}
-
Igor Eremeev authored
Change 'deps' to 'data_deps' in order for this helper executable to appear in 'gn desc runtime_deps' list. It is needed to satisfy test isolation requirements. Besides, this is just a right thing to do since compilation does not depend on this target. R=thestig@chromium.org,mark@chromium.org Bug: Change-Id: I5d14e58ce66d2415c59d96d90439d987bbe3a92c Reviewed-on: https://chromium-review.googlesource.com/806216Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#521796}
-
Joy Ming authored
There was a bug with a Strict Mode violation during the NotificationManager.notify call in DownloadNotificationService2 due to Samsung Knox. This CL fixes that by disabling Strict Mode during that specific call. Bug: 789134 Change-Id: Ie1ba03c1cbef942df2c832529ca85323f73dd2be Reviewed-on: https://chromium-review.googlesource.com/804966Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Joy Ming <jming@chromium.org> Cr-Commit-Position: refs/heads/master@{#521795}
-
Peng Huang authored
This CL implements GLSurface PresentationCallback for Ozone DRM. The Ozone DRM gets time for page flippings from the kernel DRM driver, and use this timestamp to invoke PresentationCallback for GLSurface::SwapBufferAsync, etc. Bug: 776877 Change-Id: I8eeb9713c8d37253f55b869b47d944cfdcd58bc1 Reviewed-on: https://chromium-review.googlesource.com/801795Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#521794}
-
David Tseng authored
- EditableTextBase's state transitions that detect insertions are unreliable: 1. when typing quickly, Chrome can and does combine events. type the keys 1, 2, 3 quickly and you might get value/text changes for "1", "12", and "123"; or you might get value changes for "1", "123". The latter is really bad and triggers the insertion (with length > 1) state erroniously. 2. the source of the insertion is unclear. It might have been from a paste, programmatic splicing. 3. It is impossible to reconstruct what part of the text actually got inserted. Trivial example: 'aaa', 'aaaaaaaa'. Unknown whether the entire value was replaced, or just a substring. In this change, we will turn off insertion announcements, which were being triggered in many undesirable code paths. Instead, we will: - listen to clipboard events for cut, copy, paste (and remove the previous copy command) - fixes the regression introduced by splitting text field into several subroles. Set selection wasn't working. Test: type a lot with various typing echo settings and cut/copy/paste. Bug: 791157 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ida442aa0656c1d66e489c6064f8959ccb7177b46 Reviewed-on: https://chromium-review.googlesource.com/804535 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#521793}
-
Eugene But authored
This is first refactoring CL for PassKit implementation based on ios/web Download API. Service CL: http://crrev.com/c/801916 UI CL: http://crrev.com/c/794302 Design doc: https://goto.google.com/ios-chrome-passkit Bug: 787943 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Id5d3f42da40a9ee0da2c8532d646334e6af29917 Reviewed-on: https://chromium-review.googlesource.com/802080Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Gregory Chatzinoff <gchatz@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#521792}
-
Benjamin Pastene authored
Will enable on bots by either: - adding option to testing spec - adding option to all isolated tests via mb - adding option to cmdline in recipe Leaning towards option 3 atm. R=jbudorick@chromium.org Bug: 790936 Change-Id: Ieb9e0e8237e691887e383578f1860cd77e03e5cb Reviewed-on: https://chromium-review.googlesource.com/804914Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Benjamin Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#521791}
-
Guido Urdaneta authored
The constraints processing algorithm operates on data coming directly from Blink, and it may happen that a future change accesses a string or some other data that is allowed to be accessed only from the main thread. So far no such bug has been found for device capture, but one was recently discovered for screen capture. See http://crbug.com/791992. The original motivation to run constraints processing on the worker thread was to avoid blocking the main thread in case the algorithm took too long to run, but in practice we have not observed significant performance issues. Bug: 792106 Change-Id: I5fa6f9e1b107e680cb4a5b544488fe7f2d8bfb0d Reviewed-on: https://chromium-review.googlesource.com/809011Reviewed-by:
Henrik Boström <hbos@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#521790}
-
Shenghua Zhang authored
This is a reland of 30ff548c Original change's description: > [iOS] Re-enable test 'testNetworkConnection' in device_check_egtest.mm > > Since we are beginning to run external URL test again, and labs now has > wifi. We need to re-enable the wifi checker test for swarming_cron use. > > Bug: 763582 > Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs > Change-Id: I261b46c63c63160bfae49590fae9248f5d8ffdab > Reviewed-on: https://chromium-review.googlesource.com/794341 > Reviewed-by: Sergey Berezin <sergeyberezin@chromium.org> > Reviewed-by: Yuke Liao <liaoyuke@chromium.org> > Commit-Queue: Shenghua Zhang <shenghuazhang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#519867} Bug: 763582 Change-Id: I2bdf2a0903cf2f6c7307341f8570f80abf394ea5 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/809406Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Shenghua Zhang <shenghuazhang@chromium.org> Cr-Commit-Position: refs/heads/master@{#521789}
-
Albert J. Wong authored
This moves the file local query functions that were implementing an ad-hoc "package protection" style API into the PartitionPage public API. After this, I think the functions are finally organized enough that these classes can start being detangled into separate files. See related bug for more details on methodology. Bug: 787153 Change-Id: I4997fd73e1779c9ed4f9ded9aa8a4c94c0eb7d1e Reviewed-on: https://chromium-review.googlesource.com/792090 Commit-Queue: Albert J. Wong <ajwong@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#521788}
-
Francois Doray authored
This method simulates occlusion of the CocoaTestHelperWindow (return value of occlusionState and posting NSWindowDidChangeOcclusionStateNotification). Bug: 668690 Change-Id: Ie6acab5d9ec2032dac92e8941b754fb42d45f7db Reviewed-on: https://chromium-review.googlesource.com/802134 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Sidney San Martín <sdy@chromium.org> Cr-Commit-Position: refs/heads/master@{#521787}
-
Fredrik Söderquist authored
Per coding style: https: //google.github.io/styleguide/cppguide.html#Implicit_Conversions Change-Id: Ic7a05422e72b3e445236b054d887b5467f79ab6c Reviewed-on: https://chromium-review.googlesource.com/809010Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#521786}
-
Maksim Sisov authored
X11 header files are infamous for creating macros with common names such as None, True, False, Status, Bool, ... Use a wrapper header ui/gfx/x/x11.h to simplify our work. Bug: 782184 Change-Id: I25a14236e6d4490a04dee49430929898d4ec124c Reviewed-on: https://chromium-review.googlesource.com/809124Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#521785}
-
Ojan Vafai authored
This reverts commit e62d46f6. Reason for revert: Broke webkit_unit_tests NGInlineFragmentTraversalTest.AncestorsOf NGInlineFragmentTraversalTest.InclusiveDescendantsOf NGInlineFragmentTraversalTest.SelfFragmentsOf NGInlineFragmentTraversalTest.DescendantsOf NGInlineFragmentTraversalTest.InclusiveAncestorsOf https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linux%20Trusty/builds/36811 https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Win%20x64%20Builder%20%28dbg%29/builds/115915 https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Win%20x64%20Builder/builds/123017 Original change's description: > [LayoutNG] Introduce NGInlineFragmentTraversal in place of NGInlineFragmentIterator > > This patch introduces a utility class NGInlineFragmentTraversal, so that we can > conveniently retrieve: > - ancestors of a given physical fragment in a container > - descendants of a given physical fragment > - physical fragments in a container with the given layout object > > The utility class supersedes the existing NGInlineFragmentIterator class. Follow > up patches will convert clients of NGInlineFragmentIterator to use the traversal > class instead. > > Bug: 636993 > Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng > Change-Id: I7f3f553df18291df50f60075ab84294dd394d86c > Reviewed-on: https://chromium-review.googlesource.com/807758 > Reviewed-by: Koji Ishii <kojii@chromium.org> > Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#521758} TBR=yosin@chromium.org,eae@chromium.org,yoichio@chromium.org,kojii@chromium.org,xiaochengh@chromium.org Change-Id: Ia4713823a0d0436698e40d452731760353d4c161 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 636993 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Reviewed-on: https://chromium-review.googlesource.com/809388Reviewed-by:
Ojan Vafai <ojan@chromium.org> Commit-Queue: Ojan Vafai <ojan@chromium.org> Cr-Commit-Position: refs/heads/master@{#521784}
-
Kenneth Russell authored
BUG=792139 TBR=jmadill@chromium.org, ynovikov@chromium.org NOTRY=true Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I9b719ae88776e69f8e50a05829283e2750184f3a Reviewed-on: https://chromium-review.googlesource.com/809496 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#521783}
-
Devlin Cronin authored
Now that we create a new V8 object when parsing an argument to V8 (see crrev.com/37b1fa8a), we don't need to do all the double-checking for validity and script throwing errors in messaging_util::ParseMessageOptions. Instead, we can just know that the value is safe to use. Update messaging_util::ParseMessageOptions and all its callsites to be simpler. Additionally, set the prototype of the parsed object in ArgumentSpec to null to avoid tricky getters/setters on the Object.prototype, which could be hit if the argument was missing an optional property. Bug: 653596 Change-Id: I3f53a3973d9c5a833799248b50832b55bac2792c Reviewed-on: https://chromium-review.googlesource.com/794451 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#521782}
-
Min Qin authored
On Android, regular utility process is sandboxed, and won't be able to access network. This CL parses the sandbox type from the commandline, and make the process a privileged process if the sandbox type is network. BUG=715630 Change-Id: I5ed3edcf45de13aba838f7bbf3e0faf5e39568fb Reviewed-on: https://chromium-review.googlesource.com/807152Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#521781}
-
Vladimir Levin authored
R=kbr@chromium.org Change-Id: I52a8430a9cd50f85da4cae49a2e784c51a63f601 Reviewed-on: https://chromium-review.googlesource.com/809534Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#521780}
-
David Tseng authored
In ARC++, particularly notifications, we want to allow navigation to continue outside of the root. notifications (each of which is within its own root). Test: alt+shift+n; search+right. Verify trversal through all Bug: 778070 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Id1493a7bfd7d3757328d5f0e4067d885ab85bd18 Reviewed-on: https://chromium-review.googlesource.com/806756Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#521779}
-
Lei Tian authored
Recently all copy related items' change from png to vector drawable, this makes TintedDrawable.constructTintedDrawable fail to render the icon because VectorDrawable does not extend TintedDrawable. Also since ApiCompatibilityUtils.getDrawable cannot render vector drawable on pre-L devices, change to use AppCompatResources.getDrawable to render icon for context menu. Bug: 791780 Change-Id: I35dead93f8ab5d89da49ef32180bebb644effc78 Reviewed-on: https://chromium-review.googlesource.com/807344 Commit-Queue: Lei Tian <ltian@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#521778}
-
proberge authored
Some extensions make a request to "/" which confuses the extension content verifier and causes it to mark the extension as corrupted. Bug: 791929 Change-Id: Id594bd714048d33ddcf88fa86b26ce0a7696503c Reviewed-on: https://chromium-review.googlesource.com/809225 Commit-Queue: proberge <proberge@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#521777}
-
Alexei Svitkine authored
IsUsingSecondaryPassphrase() shouldn't be called if sync service isn't initialized, according to its docs. BUG=792104 Change-Id: I6320d7cfed2dfe924ef99f2d5d87c6579347bd9a Reviewed-on: https://chromium-review.googlesource.com/809190Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#521776}
-
Andrew Grieve authored
And some minor clean-up. No behavior change. Change-Id: Ia80a0c2a673e7a500267b591d857ba32ff8e53b9 Reviewed-on: https://chromium-review.googlesource.com/809226Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#521775}
-