GitLab

In L apps are able to extend itself under the navigation bar. Yet this
feature is not needed in enhanced bookmarks, and it caused a UI bug with
snackbar.

BUG=508873

Review URL: https://codereview.chromium.org/1250853005

Cr-Commit-Position: refs/heads/master@{#339800}

Introduce a queue in TabDelegate for creating multiple Tabs in a row.
This prevents triggering some issue in Android's ActivityManager that
causes it to throw away the tasks for Activities after it launches them,
which in turn causes Android to destroy our Activities.

BUG=498920

Review URL: https://codereview.chromium.org/1229853006

Cr-Commit-Position: refs/heads/master@{#339799}

Hooks up the allocator shim on Windows. The GN build uses the Windows heap like GYP does.

This makes tcmalloc actually compile on Windows if you manually request it, although it doesn't actually seem to work correctly. I added an assert noting this if you try to set the flag on Windows. Note that this is never run by default on GYP and we may never want it.

This sets the ALLOCATOR_SHIM for the one media file that uses it.

Review URL: https://codereview.chromium.org/1246083005

Cr-Commit-Position: refs/heads/master@{#339798}

direct_dependent_configs is the deprecated name for public_configs,
and public_configs is already handled.

gn-dev thread:
https://groups.google.com/a/chromium.org/d/topic/gn-dev/h9N85MIx_Bk/discussion

BUG=None
TEST=gn gen out-gn/Debug
R=brettw@chromium.org

Review URL: https://codereview.chromium.org/1246183002

Cr-Commit-Position: refs/heads/master@{#339797}

BUG=None
R=bengr@chromium.org

Review URL: https://codereview.chromium.org/1244923002

Cr-Commit-Position: refs/heads/master@{#339796}

Previously, this member was assigned ad-hoc during initialization of a
RenderWidget. Since there are different initialization paths for
different kinds of RenderWidgets, this led to some strange-looking code:
for example, the initialization of a frame widget would double-assign
CompositorDependencies.

BUG=none
TBR=mkwst@chromium.org

Review URL: https://codereview.chromium.org/1245863003

Cr-Commit-Position: refs/heads/master@{#339795}

closing the connection instead when a packet cannot be serialized.

This could help fixing Chromium BUG=479880. Will land after
https://codereview.chromium.org/1247563002/ is committed.

Merge internal change: 98506577
R=rch@chromium.org
BUG=479880,512446

Review URL: https://codereview.chromium.org/1246093003

Cr-Commit-Position: refs/heads/master@{#339794}

The browser compositor contents and renderer contents are each put into separate
layers which are aggregated together by a Display.

BUG=449319

Review URL: https://codereview.chromium.org/1147193005

Cr-Commit-Position: refs/heads/master@{#339793}

On iOS, |root.children| was undefined for IDR_NET_ERROR_HTML webui,
which prevented the further conversion of i18n nodes.

BUG=512085

Review URL: https://codereview.chromium.org/1246633007

Cr-Commit-Position: refs/heads/master@{#339792}

Follow-on CL from https://codereview.chromium.org/1226643002

BUG=511859
TEST=browser_tests --gtest_filter=SupervisedUserBrowserCreatorTest.StartupSupervisedUserProfile

Review URL: https://codereview.chromium.org/1247063007

Cr-Commit-Position: refs/heads/master@{#339791}

Also add BaseDevice, BatteryDevice, GlucoseDevice and HeartRateDevice

Three sided patch because we need to change the reference to MultiDeviceAdapter in blink:

 [1] This patch.
 [2] http://crrev.com/1232123010
 [3] http://crrev.com/1244603002

Design doc: https://docs.google.com/document/d/1_QsBzcc84SwF7oaBWbO8rBzn39MISQ3w-6QM9hk0L3E/edit#

BUG=499552

Review URL: https://codereview.chromium.org/1230023010

Cr-Commit-Position: refs/heads/master@{#339790}

BUG=505040

Review URL: https://codereview.chromium.org/1247163002

Cr-Commit-Position: refs/heads/master@{#339789}

BUG=

Review URL: https://codereview.chromium.org/1244783006

Cr-Commit-Position: refs/heads/master@{#339788}

RTCVideoDecoder allocates SHM buffers up to kMaxNumSharedMemorySegments,
using the currently requested size. However, if, after allocating
kMaxNumSharedMemorySegments, an input buffer arrives with a size larger
than the previously allocated, we will never allocate any more buffers
to fit the new size, and will not decode anymore, waiting forever for
new SHM buffers

Separately, we allow 300 input buffers to be pended and expect to be able
to catch up later on. However, if we are already 300 buffers behind, it is
very unlikely that we ever would. Moreover, it's better for user
experience to just catch up as fast as possible, dropping pending buffers.

This modifies SHM buffer allocation to always allocate a fixed number of
buffers, based on the currently requested size. If larger buffers are
needed later on, we wait for all SHM buffers to be returned and reallocate
with the new size.

Also, allow only 8 pending buffers. This, together with 16 decode buffers,
should be a deep enough pipeline.

BUG=496349
TEST=apprtc, large Hangouts

Review URL: https://codereview.chromium.org/1236663003

Cr-Commit-Position: refs/heads/master@{#339787}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/db0b1e7..10b371c

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=joshualitt@google.com

Commits in this roll:
10b371c hendrikw@chromium.org ANGLE deps roll
b7069e9 bungeman@google.com Compile with VS2015.
7a787b4 ericrk@chromium.org Revert of Bilinear optimization for 1D convolution. (patchset #5 id:200001 of https://codereview.chromium.org/1216623003/)
cd94d73 hendrikw@chromium.org Revert of skia: ANGLE deps roll (patchset #1 id:1 of https://codereview.chromium.org/1244843003/)

Review URL: https://codereview.chromium.org/1248683003

Cr-Commit-Position: refs/heads/master@{#339786}

WebLayerTreeViewImpl needs to destroy LayerTreeHost early on as
otherwise it's possible for the compositor thread to be accessing
WebLayerTreeViewImpl while WebLayerTreeViewImpl is part way through
the destructor and in a bad state.

BUG=none
TEST=none
R=fsamuel@chromium.org

Review URL: https://codereview.chromium.org/1247803006

Cr-Commit-Position: refs/heads/master@{#339785}

All libraries and example now build with the ARM glibc
toolchain.  No tests are run yet.

CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_nacl_sdk;tryserver.chromium.mac:mac_nacl_sdk;tryserver.chromium.win:win_nacl_sdk
BUG=505885

Review URL: https://codereview.chromium.org/1243823002

Cr-Commit-Position: refs/heads/master@{#339784}

When the quota database is asked for the least recently used origin for
eviction it should not return any origins that have been granted the
durable storage permission.

Note that there is no easy way for a user to set this permission yet.
That is coming in https://codereview.chromium.org/1164073005/ and
https://codereview.chromium.org/1154573005/

BUG=482814

Review URL: https://codereview.chromium.org/1229933007

Cr-Commit-Position: refs/heads/master@{#339783}

Before this patch, there is no way to know result of purging stale resources.

BUG=n/a

Review URL: https://codereview.chromium.org/1232923003

Cr-Commit-Position: refs/heads/master@{#339782}

In a previous CL top level group markers were converted to using
chromium traces:

https://codereview.chromium.org/780653007/

The initial thought was that we would standardize on a single trace
type. This is a transitional step which moves the debug marker
manager to be set in the chromium traces, and also makes the group
marker calls mimic the chromium trace calls. Eventually the group
marker calls should be deprecated.

R=sievers@chromium.org, vmiura@chromium.org
BUG=242999, 503166
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review URL: https://codereview.chromium.org/1132283003

Cr-Commit-Position: refs/heads/master@{#339781}

ServiceFactory is an interface used to create media services. Services created
in one factory instance are isolated from services created in another factory
instance. This is used in Chromium to isolate media services for different
RenderFrames.

BUG=510653
TEST=Plays the same EME test page in 2 tabs.

Review URL: https://codereview.chromium.org/1230313010

Cr-Commit-Position: refs/heads/master@{#339780}

BUG=512105
TEST=Manually tested by checking about://tracing and about://histograms.

Review URL: https://codereview.chromium.org/1241263002

Cr-Commit-Position: refs/heads/master@{#339779}

Previously GN's runtime deps computation would only count a target once, but
this ignores the fact that whether a target is a data dependency or a regular
one affects how it's added.

This patch revisits a target if it's depended on in a data dependency
even if it's already been seen as a regular dependency.

Enhance the runtime deps documentation.

Review URL: https://codereview.chromium.org/1250883002

Cr-Commit-Position: refs/heads/master@{#339778}

Revert of Call EnsureWebKitInitialized() before registering extensions (patchset #3 id:40001 of https://codereview.chromium.org/1182083006/)

Reason for revert:
This seems the cause of many crashes

Original issue's description:
> Call EnsureWebKitInitialized() before registering extensions
>
> Blink needs to be initialized before registering an extension because:
> - WebScriptController::registerExtension() allocates an WTF::Vector on the first
>   call.
> - WTF::Vector uses PartitionAlloc.
> - PartitionAlloc's partitions needs to be initialized before allocating memory.
>   Blink initialization does the job.
>
> Before this CL, partitions are initialized lazily but lazy initialization
> doesn't provide proper histogram function, which might be the cause of missing
> report for PartitionAlloc.CommittedSize UMA.
>
> BUG=501171
>
> Committed: https://crrev.com/0d244fa5e106b3d146655a2c623539a3e1900831
> Cr-Commit-Position: refs/heads/master@{#339200}

TBR=jochen@chromium.org,haraken@chromium.org,kalman@chromium.org,kinuko@chromium.org,paulmeyer@chromium.org,sievers@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=501171

Review URL: https://codereview.chromium.org/1244243003

Cr-Commit-Position: refs/heads/master@{#339777}

BUG=490430
R=ortuno@chromium.org

Review URL: https://codereview.chromium.org/1241283003

Cr-Commit-Position: refs/heads/master@{#339776}

BUG=45650

Review URL: https://codereview.chromium.org/1224283006

Cr-Commit-Position: refs/heads/master@{#339775}

In low delay mode, we'll start playback when we have any frame. If we accumulate
frames earlier than the start time, we'll start playing that frame prematurely.
Instead, drop those frames immediately. Playback will start when we start to
have frames on or later than the start time.

BUG=512145
TEST=Updated the unittest to cover this case.

Review URL: https://codereview.chromium.org/1246033008

Cr-Commit-Position: refs/heads/master@{#339774}

This was broken by my recent change to enable arm-glibc.

CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_nacl_sdk

Review URL: https://codereview.chromium.org/1246133002

Cr-Commit-Position: refs/heads/master@{#339773}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/49d3837a..b2dfa5cd

Please follow these instructions for assigning/CC'ing issues:
https://code.google.com/p/v8-wiki/wiki/TriagingIssues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review URL: https://codereview.chromium.org/1250853003

Cr-Commit-Position: refs/heads/master@{#339772}

CronetSampleActivity is modified to use the new async APIs instead of
the deprecated old APIs.

R=xunjieli@chromium.org
BUG=

Review URL: https://codereview.chromium.org/1221513002

Cr-Commit-Position: refs/heads/master@{#339771}

This client informs embedders when a
BrowsingDataPartition becomes synchronized.

BUG=480654

Review URL: https://codereview.chromium.org/1247143002

Cr-Commit-Position: refs/heads/master@{#339770}

BUG=505430

Review URL: https://codereview.chromium.org/1245233002

Cr-Commit-Position: refs/heads/master@{#339769}

BUG=475714

Review URL: https://codereview.chromium.org/1250443002

Cr-Commit-Position: refs/heads/master@{#339768}

The problem was that the UI expected that CONTEXT_KEY_KEYBOARD_STATE key
observer is called before CONTEXT_KEY_KEYBOARD_PINCODE observer. In fact, the
order of notifications was never defined. It have changed at some point, which
lead to regression.

BUG=507896
TEST=OobeWebUITest.HIDDetectionScreenTest browser test

Review URL: https://codereview.chromium.org/1243983002

Cr-Commit-Position: refs/heads/master@{#339767}

Switch RenderFrameHostManager to use RenderProcessHostObserver, remove NOTIFICATION_RENDERER_PROCESS_CLOSING.

BUG=170921
TEST=everything still works

Review URL: https://codereview.chromium.org/1245903004

Cr-Commit-Position: refs/heads/master@{#339766}

This is a warning about signed vs. unsigned values in a comparison.  The code in
question was added entirely by a previous patch, so this simply modifies that
patch, and the results of applying it.

Adding an "(unsigned)" C-style cast is a somewhat ugly fix to one location, but
the alternative would be a potentially-vast change to the APIs in question to
change int to unsigned throughout the transitive closure of places that touch
this.  I didn't seriously investigate doing this.

BUG=398202
TEST=none

Review URL: https://codereview.chromium.org/1248763003

Cr-Commit-Position: refs/heads/master@{#339765}

The existing string refers to a checkbox but the iOS ui uses a switch
component that doesn't look like a checkbox. The CL to actually use this
string is still under development but I'd like to get this in the
translation queue.

BUG=484806

Review URL: https://codereview.chromium.org/1233313010

Cr-Commit-Position: refs/heads/master@{#339764}

A race condition is suspected in which the first setNeedsLayout call happens between a layout and a paint for a webview plugin. This change ensures that setNeedsLayout... is called on the plugin's container at initialization, which occurs during the correct document lifecycle position.

TBR=bauerb@chromium.org,tommycli@chromium.org
BUG=493375

Review URL: https://codereview.chromium.org/1244113003

Cr-Commit-Position: refs/heads/master@{#339763}

For some content (e.g. HLS live streams), attempting to seek will get the
media player stuck in an error state. In
https://codereview.chromium.org/22605013, this was addressed by preventing
seeks if the duration of the video is negative. However, with
https://codereview.chromium.org/617743004, a -1 returned by the Android
MediaPlayer will be converted to media::kInfiniteDuration().

This CL utilizes two seek booleans derived from the Android MediaPlayer to
determine if a seek should be allowed.

BUG=510641
TEST=MediaPlayerBridgeTest.*

Review URL: https://codereview.chromium.org/1234483003

Cr-Commit-Position: refs/heads/master@{#339762}

This makes the behavior match native platforms.

BUG=376384
TEST=On linux - press Alt+F, then Up Arrow key, then Enter.
     Expected: The last item "Exit" was selected and invoked, quitting Chrome.

Review URL: https://codereview.chromium.org/1230163004

Cr-Commit-Position: refs/heads/master@{#339761}