- 12 Nov, 2018 40 commits
-
-
Steve Anton authored
This allows P2PQuicTransportConfig to be constructed on the main thread and passed to the WebRTC worker thread where the P2PQuicTransport is constructed. This reduces the amount of boilerplate code needed to construct the object in a cross-threaded manner as more parameters are added to the config. Bug: 874296 Change-Id: I3ae2f09b1c53e7b12f804c2c526d3dad29b323ff Reviewed-on: https://chromium-review.googlesource.com/c/1330845 Commit-Queue: Steve Anton <steveanton@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#607335}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/d1eeca86af6e..0cf6ee7f1acb git log d1eeca86af6e..0cf6ee7f1acb --date=short --no-merges --format='%ad %ae %s' 2018-11-12 sergiyb@chromium.org Remove ensure_logs_on_timeout flag Created with: gclient setdep -r src/third_party/catapult@0cf6ee7f1acb The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:899721 TBR=sullivan@chromium.org Change-Id: I0871d6194c30a3642d746b76f00855628a45c000 Reviewed-on: https://chromium-review.googlesource.com/c/1331580Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#607334}
-
Weidong Guo authored
The folder name becomes invisible because parent view's layer is set not drawn [1]. This CL sets folder header view's own layer to fix the issue. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1302413 Bug: 902920 Change-Id: Ib32d3c55d8e044693f81e8bfae7547b989c1c80d Reviewed-on: https://chromium-review.googlesource.com/c/1330762Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Weidong Guo <weidongg@chromium.org> Cr-Commit-Position: refs/heads/master@{#607333}
-
Tien Mai authored
When starting Chrome under the Winlogon desktop, run the gpu process in an alternate desktop instead of the winlogon desktop since the low integrity gpu process does not have access to the winlogon desktop. This fix allows the GCPW to run chrome on the Windows logon screen. Bug: 898754 Change-Id: I8a1b6d3056377b5012fa3916289da02b86b70468 Reviewed-on: https://chromium-review.googlesource.com/c/1312307Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Tien Mai <tienmai@chromium.org> Cr-Commit-Position: refs/heads/master@{#607332}
-
Charlie Harrison authored
Image models are not 1:1 with content settings. This CL replaces per-tab storage from TSCS to a new per-WebContents container, ContentSettingImageModelState, which contains information that is 1:1 with image models. This allows us to remove custom logic for image models that aren't backed by a single content setting. The new behavior works like this: 1. Per-tab state is stored in ContentSettingImageModelState 2. ShouldRunAnimation / SetAnimationHasRun updates the state 3. State is additionally updated when an image is hidden (3) entails a bunch of changes to UpdateFromWebContents, namely, making it return a boolean for whether the update triggered visibility. The benefit of this CL is that all of the logic to control animation of image models come from ContentSettingImageModel. This CL has no intended user-facing behavior change. Bug: 900645 Change-Id: I99c36a8184a0e04e6356e58fbc93a5aed3f03127 Reviewed-on: https://chromium-review.googlesource.com/c/1310674Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#607331}
-
Michael Spang authored
When using vulkan, there is no per-frame Present() call to the window's scenic session. We need to make sure to call present after a size update to commit the new size. Bug: 861853 Test: run_content_shell --ozone-platform=scenic --disable-gpu --enable-vulkan Change-Id: I7d2788ae6ff641908a10a02d837bea223af6a1ca Reviewed-on: https://chromium-review.googlesource.com/c/1330291 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#607330}
-
Dave Tapuska authored
The feature has long since been stable (since M64) and doesn't seem to be a need for this flag. BUG=788936 Change-Id: I666390b869289c328acb4a2daa5bf4154e1702c0 Reviewed-on: https://chromium-review.googlesource.com/c/1324143Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#607329}
-
Tarun Bansal authored
Currently, the render process sends the statistics of only the anchor elements that are in the viewport to the browser. This CL changes it to also include the anchor elements whose target URL is one digit different from the document URL. Note that there is still a limit of 40 on the count of anchor elements that are sent from the render to the browser process. Change-Id: I4083e3605095a44700cc2178615713ede6e0dde2 Bug: 850624 TBR: ryansturm@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/1329848 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#607328}
-
Wez authored
Previously we were incorrectly attempting to use the "host" portion of the URI, rather than treating the whole "content" as the app-Id. Bug: 893229 Change-Id: I5c95a828a28834449292b1cfec70a9974f3efef4 Reviewed-on: https://chromium-review.googlesource.com/c/1331169 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#607327}
-
Ted Choc authored
This CL: https://chromium.googlesource.com/chromium/src/+/e9d6060f509e6a7b3a4f0bd944b1303a783f4a94 fixed an issue where suggestions were triggered on URL de-focus, but it broke zero suggest because we trigger zero suggest on focus before the animation completes. To address this, this introduces a tri-state of allowed suggestion visibility. When focusing, we can request suggestions but they won't be shown until the animation is complete. When de-focusing, we disallow any suggestions being shown. BUG=904367 Change-Id: I0a1b166158bc08bcc1f8d94b4fe15c6f4e663b02 Reviewed-on: https://chromium-review.googlesource.com/c/1331574Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#607326}
-
Elly Fong-Jones authored
As of 10.14, the API that SendGlobalKeyEventsAndWait() uses to post global events causes a user prompt to appear, which is an obvious non-starter in test scenarios, so disable that test for now, and add a DCHECK in SendGlobalKeyEventsAndWait() to ensure that it is not called on 10.14. Bug: 892177,904403 Change-Id: Ida0429d7e9914942f354690ecb657803240756ae Reviewed-on: https://chromium-review.googlesource.com/c/1331135Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#607325}
-
Charlie Harrison authored
Bug: 632514 Change-Id: Ie05f723119aca8611fd46ff3466d5b292004e104 Reviewed-on: https://chromium-review.googlesource.com/c/1329863 Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#607324}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/d608c792b594..ff9427fb8a90 git log d608c792b594..ff9427fb8a90 --date=short --no-merges --format='%ad %ae %s' 2018-11-12 lalitm@google.com Merge "trace_processor: prevent window table from allowing zero duration tables" 2018-11-12 hjd@google.com Merge "perfetto-ui: Avoid setting window_dur to 0ns" Created with: gclient setdep -r src/third_party/perfetto@ff9427fb8a90 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: If4c516056c567dd08800de39982f9df1aea3a2b2 Reviewed-on: https://chromium-review.googlesource.com/c/1331608Reviewed-by:
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Id11e90f4422b220f4c9a8806249fd9d526ddd48c Reviewed-on: https://chromium-review.googlesource.com/c/1331572 Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
-
Christian Biesinger authored
When enabling printing, we re-attach the layout objects, and so we need to update the various layout object variables before accessing them. R=ikilpatrick@chromium.org Change-Id: I770621242d5c29762081a25b2699ffb46320597c Reviewed-on: https://chromium-review.googlesource.com/c/1331607 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#607321}
-
Scott Violet authored
This way telemetry only includes the time from ash, not the initial hop from browser to ash. BUG=759163 TEST=none Change-Id: I65f514d6bee3346a7b828b431300e5cf3277d521 Reviewed-on: https://chromium-review.googlesource.com/c/1327416Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#607320}
-
Brian Sheedy authored
This reverts commit f6b72e6c. Reason for revert: Still causing https://crbug.com/903402 Original change's description: > Reland: Marks the document object as busy while it is still loading > > Changes in the reland compared to the original patch: > Switched to using GetRoot instead of Root() which might prevent the use of an uninitialized root object. > > Original description: > Screen readers want to have a reliable way to know whether a document is still loading so as to ignore events coming from it. > The current change can be made irrespective to whether we will mark the document as loaded when HTML parsing has started or when the "interactive" readyState has been entered. > > R=dmazzoni@chromium.org, aleventhal@chromium.org > > Bug: 897177, 903402 > Change-Id: I681883999918ffdd32fc11d2f691b659c7e91149 > Reviewed-on: https://chromium-review.googlesource.com/c/1327745 > Commit-Queue: Nektarios Paisios <nektar@chromium.org> > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#607017} TBR=dmazzoni@chromium.org,nektar@chromium.org,aleventhal@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 897177, 903402 Change-Id: I18b4bae20db26dc26934abb08e97df0b8a151465 Reviewed-on: https://chromium-review.googlesource.com/c/1331145Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#607319}
-
yileili authored
Bug: b:118193766 Test: Manual Change-Id: Ia0cd58e42761b35b9f7281344266505074d59936 Reviewed-on: https://chromium-review.googlesource.com/c/1321956 Commit-Queue: Yilei Li <yileili@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#607318}
-
Madeleine Barowsky authored
The Play Store page contains many WebP images (lossy for movie covers and lossless for Google-created vector art), which is an image rendering category that is currently not well covered. Bug: 878390 Change-Id: I7298c3e077497e40506a1f6528318a80e5df0221 Reviewed-on: https://chromium-review.googlesource.com/c/1309115 Commit-Queue: Madeleine Barowsky <mbarowsky@chromium.org> Reviewed-by:
Emily Hanley <eyaich@chromium.org> Cr-Commit-Position: refs/heads/master@{#607317}
-
Peter Boström authored
Instead of skipping to the new load-progress value as it arrives, interpolate to it. This results in a smoother animation as the load-progress callbacks can be fairly sparse (and jump from 20% to 80% for instance). Drives animations off of the same timer that is used for the throbbing state. This will hopefully address a performance regression as the throbbing timer, progress fade-out animation and favicon fade-in animation were all scheduling separate high-frequency repainting of the tab icon. Bug: chromium:903827, chromium:903147, chromium:902475, chromium:901751 progress Change-Id: Iad2a24d94206d5871a5cacc5e56d072161407940 Reviewed-on: https://chromium-review.googlesource.com/c/1330345 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#607316}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/48f63f90f6f3..03d1a5ed6cc8 git log 48f63f90f6f3..03d1a5ed6cc8 --date=short --no-merges --format='%ad %ae %s' 2018-11-12 jmadill@chromium.org Vulkan: Use global buffer barriers. Created with: gclient setdep -r src/third_party/angle@03d1a5ed6cc8 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I58fdbdc51db4c3b24e0b8554d699607cba25de57 Reviewed-on: https://chromium-review.googlesource.com/c/1331570Reviewed-by:
-
Michael Spang authored
This is necessary in order to be able to call FIDL interfaces from the GPU thread. Bug: 861853 Test: run_content_shell --ozone-platform=scenic --disable-gpu --enable-vulkan Change-Id: I1f7b0f2957a810745a83ce1cf36327467e6ea448 Reviewed-on: https://chromium-review.googlesource.com/c/1330290 Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by:
-
Jao-ke Chin-Lee authored
TBR=martiniss@chromium.org Bug: 790286,790294,790309 Change-Id: I507b1c98aa2aca9e723db051cc59c0b51ebfb5ad Reviewed-on: https://chromium-review.googlesource.com/c/1331614Reviewed-by:
Jao-ke Chin-Lee <jchinlee@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Jao-ke Chin-Lee <jchinlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#607313}
-
Lambros Lambrou authored
Plan-B is deprecated, but some non-trivial work is needed to update to Unified Plan. Specifying Plan-B explicitly will keep things working when WebRTC changes the default to Unified Plan. Bug: 903012 Change-Id: I3afc86c87f79af068f93af384cc20229293be5c5 Reviewed-on: https://chromium-review.googlesource.com/c/1327546Reviewed-by:
Joe Downing <joedow@chromium.org> Commit-Queue: Lambros Lambrou <lambroslambrou@chromium.org> Cr-Commit-Position: refs/heads/master@{#607312}
-
Justin Cohen authored
Hide the NTP immediately when load an HTTP auth page from the NTP. |dialogPresenter| should only run when the webState->GetView() is visible. Bug: 826369 Change-Id: Ic154a4fdd4d52a2ddfec27de3ee80d85dd88cb18 Reviewed-on: https://chromium-review.googlesource.com/c/1323808Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#607311}
-
Findit authored
This reverts commit 6c1f4453. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 607302 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzZjMWY0NDUzYjQ1NjdlYmFlNjljYTlmNDJmZDY2MDJlMDZkMWIxZGMM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.chromiumos/Linux%20ChromiumOS%20Full/109736 Sample Failed Step: compile Original change's description: > CryptAuth: Remove unused ConnectionFinder. > > Bug: 899324 > Test: none > Change-Id: I30f07136ac7c3ed3ac49b678e5f45d250fcbe65f > Reviewed-on: https://chromium-review.googlesource.com/c/1331573 > Reviewed-by: Jeremy Klein <jlklein@chromium.org> > Commit-Queue: James Hawkins <jhawkins@chromium.org> > Cr-Commit-Position: refs/heads/master@{#607302} Change-Id: I0c821dda827a0daf2a144b60718e370c459abd6f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 899324 Reviewed-on: https://chromium-review.googlesource.com/c/1331948 Cr-Commit-Position: refs/heads/master@{#607310}
-
Maks Orlovich authored
Previously they would straight up fail. With this cache, such fetches with specified content-length will "merely" be serialized and re-fetched. (Which is what we did in <= M63). Bug: 890973 Change-Id: I1d718cb83caced15d7ea44633a056a3fae0ac936 Reviewed-on: https://chromium-review.googlesource.com/c/1280792Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Shivani Sharma <shivanisha@chromium.org> Commit-Queue: Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#607309}
-
John Budorick authored
Tbr: justincohen@chromium.org Bug: 903674 No-Try: true Change-Id: Icc14807608fbd7eac94a129a6c0a6b41b187d34d Reviewed-on: https://chromium-review.googlesource.com/c/1331828 Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by:
-
Anne Lim authored
Clears all strikes in a profile's StrikeDatabase when Autofill data is wiped out from Chrome Settings in iOS (chrome://settings -> Clear Browsing Data -> Advanced -> Autofill Form Data). Bug: 884817 Change-Id: Ic5065176f58d3785b9636c32df150801f583bb7d Reviewed-on: https://chromium-review.googlesource.com/c/1323795Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Commit-Queue: Anne Lim <annelim@google.com> Cr-Commit-Position: refs/heads/master@{#607307}
-
Maks Orlovich authored
This reverts commit 1e3d315d. Reason for revert: Coalescing looks to have helped, no longer need debugging machinery. Bug: 896880 Original change's description: > SQLitePersistentCookieStore: Attempt to diagnose occasional heavy memory consumption > > From leak reports, it seems like sometimes the pending operations queue > just keeps growing and growing, but we still don't know why... so > DumpWithoutCrashing (once per backend lifetime) if it seems ridiculously > long. > > Thanks to mef@ for the idea. > > Bug: 809199 > Change-Id: Ia949be30e50ddcd6f800c4c26268966b6e298bc0 > Reviewed-on: https://chromium-review.googlesource.com/1210367 > Commit-Queue: Maks Orlovich <morlovich@chromium.org> > Reviewed-by: Victor Costan <pwnall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#589236} Bug: 809199 Change-Id: I1ea0cce2ab6987a3b4afb752a5fa2d463be4c9f0 Reviewed-on: https://chromium-review.googlesource.com/c/1329345Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#607306}
-
Chris Harrelson authored
This is because the ContentsOpaque property of a cc::Layer can depend on alpha. Bug: 896716 Change-Id: Ica063db2860e0a6ba2bc9ffdf45b5cca06e26e84 Reviewed-on: https://chromium-review.googlesource.com/c/1327158 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#607305}
-
Antoine Labour authored
We can't bind 2 GLImage to the same textures, and it wouldn't work anyway. Ensure we don't attempt to create an EGLImage in that case as it will break if e.g. the image is in UNBOUND state. Bug: 882513 Change-Id: Iea52d25771a43205a6250b0d354593af98676a86 Reviewed-on: https://chromium-review.googlesource.com/c/1330765Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#607304}
-
Doug Arnett authored
Also drops extra/legacy server preview call for server LoFi (just use use LitePage check for Flywheel CPAT based previews) and drops is_server_preview parm from ShouldAllow* method. Also ignores case of blacklist not being loaded if flagged to ignore blacklist. Change-Id: I5995a13180a06c592ad5d02a49e54e875faade31 Reviewed-on: https://chromium-review.googlesource.com/c/1331415Reviewed-by:
-
James Hawkins authored
Bug: 899324 Test: none Change-Id: I30f07136ac7c3ed3ac49b678e5f45d250fcbe65f Reviewed-on: https://chromium-review.googlesource.com/c/1331573Reviewed-by:
Jeremy Klein <jlklein@chromium.org> Commit-Queue: James Hawkins <jhawkins@chromium.org> Cr-Commit-Position: refs/heads/master@{#607302}
-
Lily Chen authored
This reverts commit 8a9302e2. Reason for revert: Causing flaky crashes in external/wpt/webusb/idlharness.https.any.worker.html Original change's description: > Add reprioritization to SSLConnectJobs > > This change allows the priority of an SSLConnectJob to be changed. If > the reprioritization occurs while the job is establishing its underlying > connection, the priority change is also passed down to the lower-level > socket pool. > > Bug: 166689 > Change-Id: I87d1e536846443901cc628423f4615c3ffa7542a > Reviewed-on: https://chromium-review.googlesource.com/c/1327423 > Commit-Queue: Lily Chen <chlily@chromium.org> > Reviewed-by: Matt Menke <mmenke@chromium.org> > Cr-Commit-Position: refs/heads/master@{#606876} TBR=mmenke@chromium.org,chlily@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 166689, 904345 Change-Id: I6458798e11d210258f2a26330548f1ca33eb6c90 Reviewed-on: https://chromium-review.googlesource.com/c/1331139Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#607301}
-
Scott Violet authored
Specifically ash::mojom::UserInfo. I'm going to need this to have ash call into wallpaper code, which needs the gaia account. BUG=756085 TEST=none Change-Id: I9a9c1970bd3cd28ce36cca3d5ff919225dee8084 Reviewed-on: https://chromium-review.googlesource.com/c/1328564Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#607300}
-
Weidong Guo authored
Changes: Change the color of the folder title to be Grey 700. Bug: 901286 Change-Id: Ie2e4603a6b248976fbdb114533e1c6e90485bd01 Reviewed-on: https://chromium-review.googlesource.com/c/1330833Reviewed-by:
-
Philip Rogers authored
This patch removes the paint offset parameter for RecordHitTestData which is now baked into the paint_rect parameter. Change-Id: Idecbde110b50db2d62e3cec720861a1f39aecd88 Reviewed-on: https://chromium-review.googlesource.com/c/1329855 Commit-Queue: Philip Rogers <pdr@chromium.org> Reviewed-by:
Xianda Sun <sunxd@chromium.org> Cr-Commit-Position: refs/heads/master@{#607298}
-
Takumi Fujimoto authored
If a sink is DISCONNECTING, change the icon to a throbber and change the status text to "Disconnecting...", but don't grey out the title text. If a sink is AVAILABLE but does not support the selected source, change the status text to "Source not supported". The hashes for the screenshots are per the instructions here: https://docs.google.com/document/d/1nwYWDny20icMSpLUuV_LgrlbWKrYpbXOERUIZNH636o/edit And the screenshots are uploaded here: https://storage.googleapis.com/chromium-translation-screenshots/7f85b1d7787495adf8153366ecc39cdd43762144 https://storage.googleapis.com/chromium-translation-screenshots/7f3bb4aeb5b577e98ab1415b31f967311af8747a Bug: 902493, 899998, 883392 Change-Id: Ib556de3e5407500a63c729c7bd02001572fa91e8 Reviewed-on: https://chromium-review.googlesource.com/c/1325070Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#607297}
-
Tommy C. Li authored
For Query in Omnibox, we want to avoid the URL flicker while the page is navigating and the TLS security state has not been initialized. This currently works on Android implementation by toggling a boolean flag on navigation and TLS state update. However, this duplicates a piece of state that's already authoritatively stored within the VisibleSecurityState. This CL: 1. Exposes an IsSecurityInfoInitialized() method on LocationBarModel 2. Updates the security_state::SecurityInfo struct to add a connection_info_initialized flag that's already present in security_state::VisibleSecurityState. 3. Updates LocationBarModelDelegate to provide a general GetSecurityInfo method. Planned followup work: 1. Make Query in Omnibox actually use the IsSecurityInfoInitialized flag. 2. Use LocationBarModelDelegate::GetSecurityInfo to remove some now-redundant methods such as FailsBillingCheck and FailsMalwareCheck. Bug: 874592 Change-Id: I648b30859ec40bb741de1c31378e0a6cd8baeeaa Reviewed-on: https://chromium-review.googlesource.com/c/1324879Reviewed-by:Adrienne Porter Felt <felt@chromium.org> Reviewed-by:
Christopher Thompson <cthomp@chromium.org> Reviewed-by:
-
