- 03 Dec, 2019 40 commits
-
-
Michael Crouse authored
This change updates the store in stages to ensure only one store update in flight at a time. It prioritizes storing the model features first and then stores the prediction models once that update is complete. Bug: 1001194 Change-Id: Ic2d0ccaf64b49ca934590e6b7d0051668e155016 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1938192Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Commit-Queue: Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/master@{#721238}
-
Finnur Thorarinsson authored
Adhere better to UX mocks: - Make Zoom button appear on first selection (and stay after that). - Remove selection border on full screen images. Other changes: - Evict full-screen cache on leaving full-screen. The cache takes up quite a bit of space and is not likely to be as useful after leaving full-screen mode. - Disable Zoom button while animations are taking place. Avoids starting animations twice in a row. Bug: 1029056, 656015 Change-Id: Idb58508c4f0ca691e2247ccd024b88f5d16f0eec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948894 Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#721237}
-
Dana Fried authored
It improves but does not completely fix support for height-for-width calculations, allowing views to exceed preferred size in more cases where a custom flex rule or height-for-width relationship is present, especially in places where there is a vertical layout with horizontal stretch alignment. We have also added a specific regression test case for the bug in question, which has example code showing how to make the requested case work with the existing infrastructure. Bug: 1012119 Change-Id: I88380771aacfea29e750dd5033f1fa11e9eb999a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940714Reviewed-by:
Collin Baker <collinbaker@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#721236}
-
Ahmed Fakhry authored
Histogram is added to report the state of the Auto NL notification as a result of the user's interaction with it. BUG=1026871 Change-Id: I52f7da9d7d65dcdd19a08a1e38144242c4c2a6bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946856Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#721235}
-
Takumi Fujimoto authored
Disabling for flakiness. TBR=thestig Bug: 1030368 Change-Id: I0dc5f22acf376b23e54988ec01ea5e6527da5a1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949032Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#721234}
-
Christopher Cameron authored
This prevented --enable-features=Metal from working TBR=zmo Change-Id: Ief8f46cfe4789942e773dbb250799e5ed5af69cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948915Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#721233}
-
Chris Lu authored
- Add "Show Original" button in Infobar Translate Modal, separating the revert action from the "Translate" action button. This new button will be enabled if the TranslateStep is AFTER_TRANSLATE. A new InfobarTranslateModalDelegate method is added and implemented in the coordinator. - The "Never Translate Language" and "Never Translate Site" buttons will be enabled only if the TranslateStep is BEFORE_TRANSLATE to remove these options when a Translate has finished. - TranslateStep property is added to mediator so that it can check the current state to send the consumer the right button enable prefs. - |translateInfoBarDelegate| in InfobarTranslateCoordinator is renamed to translateInfobarDelegate to set the right precedent. Bug: 1014959 Change-Id: I75c59124431d89963830176bb9866a4bf80e98b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919829 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#721232}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/efedd6739684..e99f60bbee4f git log efedd6739684..e99f60bbee4f --date=short --first-parent --format='%ad %ae %s' 2019-12-03 rharrison@google.com Convert spvc return codes to their own enum (#923) Created with: gclient setdep -r src/third_party/shaderc/src@e99f60bbee4f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: radial-bots+chrome-roll@google.com Change-Id: I9522dad904fccd6a453f6a86a66fc40b97d77260 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949169Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#721231}
-
Sammie Quon authored
Ran locally and seems fixed. I think the cause was base::RunLOops which used to be needed for changing tablet mode, but thats no longer the case so they just messed up some other waits. Bug: 1027899, 1027800 Change-Id: Icf6cfd70e0e2ef826a3767a20a7bca75f31aacd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947165Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#721230}
-
Geoff Lang authored
Validate that the OpenGL query extensions are present before calling the entry points in gl(Begin|End|Gen|Delete)Queries. Some operations like glGenQueries are no-oped because the command decoder still emulates some query types without native support. BUG=1026911 Change-Id: I09f88aa0f7cc5be3812595892cb1c1c76900ce81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929432Reviewed-by:
James Darpinian <jdarpinian@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#721229}
-
Dominique Fauteux-Chapleau authored
The browser test is updated to observe the core directly since it now gets disconnected by unenrollment. Also, refactor browser_dm_token_storag* classes by moving the post task function to the base class and the subclass now only provide the store function binding. Bug: 1020301, 1020299 Change-Id: I98a62c90fcb8e7ca30dc733bd2b19fb6632e9ec9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940575 Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Reviewed-by:
Tien Mai <tienmai@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#721228}
-
Dave Tapuska authored
Remove document-access feature policy. Change feature policy to an iframe attribute since feature policies inherit and it really doesn't give us the characteristics we wish for. Explainer: https://github.com/dtapuska/documentaccess BUG=961448 Change-Id: Iee24cbd3dff53bd94153104bce250e3f9a947639 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926788Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#721227}
-
Jeff Yoon authored
To support the number of combinations required by iOS, this introduces matrix compound test suites, such that swarming dimension sets can be utilized to be applied to each test under the referenced basic test suite. Dimension sets defined in both basic and compound are to be merged via dictionary_merge(). Also moving the flattening call after composite and matrix test suites have been unpacked, to remove the list type check and to only loop on the given test suite type, instead of the combined sum of basic + composite + matrix. Change-Id: I92de3c245a9e765f5324ecc90beef0a166781153 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913609 Commit-Queue: Jeff Yoon <jeffyoon@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org> Cr-Commit-Position: refs/heads/master@{#721226}
-
Dana Fried authored
Tab titles were doing an invalid size computation that resulted in a change in tab title not being reflected in tab size or layout. Bug: 1030112 Change-Id: I1e17c14429dbcc2704ed89417fc9e39032f39dea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949040 Commit-Queue: Dana Fried <dfried@chromium.org> Auto-Submit: Dana Fried <dfried@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#721225}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/d006a8572a47..0a9b289bcbd1 git log d006a8572a47..0a9b289bcbd1 --date=short --first-parent --format='%ad %ae %s' 2019-12-03 perezju@chromium.org [Telemetry] Repleace perezju's TODOs with bug numbers Created with: gclient setdep -r src/third_party/catapult@0a9b289bcbd1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1029008 Tbr: sadrul@google.com Change-Id: I4cd7681a9e4e8d813a4faebb813fadd94e082114 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949444Reviewed-by:
-
Ken Rockot authored
This is a mostly mechanical move of some legacy DOM storage support code into the Storage Service, severing some trivial Content dependencies along the way. Bug: 1000959 Change-Id: Ia9e1764a8f6a77c0b08048700f0e9f3f0a92de8f Tbr: halliwell@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944321 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Chris Mumford <cmumford@google.com> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#721223}
-
Sebastien Marchand authored
We don't need these anymore now that we're using the notification permission bit to decide whether or not a tab can be frozen. Bug: 1026874 Change-Id: I5c5e97ee0c8d7825e8ace52587dab511d5d07a28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939935 Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#721222}
-
llin@chromium.org authored
The library loads and parse result into a quick answer result which will be used to render on the UI. One result parser is added to parse unit conversion result. More result parsers will be added in follow up CLs. The implementation of text classifier is in progress. Mock the classifier with a simple regex solution for demo purpose. Will replace with text classifier call. Bug: b/144314551 Test: Manual Change-Id: I7c6658d3c246e064e4d5676b6511ecabc3b1643b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912800Reviewed-by:
Max Moroz <mmoroz@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Li Lin <llin@chromium.org> Cr-Commit-Position: refs/heads/master@{#721221}
-
Thomas Guilbert authored
This CL adds the interfaces and callbacks necessary to expose the video.requestAnimationFrame() API to Javascript. The changes are guarded by a runtime enabled flag (VideoRequestAnimationFrame). Bug: 1012063 Change-Id: I03ed6eb47a875522748a54423bb8d163f33ea27b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904872Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#721220}
-
Takumi Fujimoto authored
Disabled for flaky failures. TBR=rockot@google.com Bug: 1030435 Change-Id: I1a1935eaf0bb35c2109c6ff74fc1f1c5ab133581 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948917 Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Reviewed-by:
-
Garrett Beaty authored
All branch CI builders have been moved to be scheduled once per day. As we get capacity and get the builds into a good state, we will move them to be continuously triggered. Bug: 1024641, 922150 Change-Id: Ie066240907dd581175c94cbca431e5a6bf37deb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948050Reviewed-by:
-
David Tseng authored
In Google Calendar, the "rooms" tab of a new invite triggers a flood of events (location changes, and attribute changes). The dynamic room dropdown appears to continually be updating itself resulting in thousands of events per second. This change: - minimizes the js <-> C++ calls by pushing event listener state to C++ from js - if there's no event listener for a given event, don't incur the cost of sending it to js - in ChromeVox, create a new class, RangeAutomationHandler, which installs event listeners scoped as much as possible, to ChromeVox's currentrange. This ignores events on other parts of the tree. Test: manually on Google Calendar. Change-Id: I4172f504915665dbe7d0a88df11aefceb36439b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947643 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#721217}
-
Chris Mumford authored
Switched to base::RepeatingClosure as well as switching base::BindOnce to WTF::Bind as base::Bind* is banned in Blink. Bug: 1007835 Change-Id: I6b6b6d028671ea2e50dd60e8cfc8048803aafd2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949114Reviewed-by:
-
Chris Mumford authored
Jumbo builds are deprecated, so simplifying code by renaming RunClosure4 to the more commonly used RunClosure. Additionally removed a base::Closure in the VideoTrackRecorderTest.ReleasesFrame test. Bug: 1007835 Change-Id: Ibab8fda2bc3c717774d1657d3752acab94d2601d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949067Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Chris Mumford <cmumford@google.com> Cr-Commit-Position: refs/heads/master@{#721215}
-
Michael Ludwig authored
Bug: 973696 Change-Id: I3e0750a60890da45681d4a50c1ec383e429243df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947358 Commit-Queue: Michael Ludwig <michaelludwig@google.com> Reviewed-by:
weiliangc <weiliangc@chromium.org> Cr-Commit-Position: refs/heads/master@{#721214}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 6b2bb4b5. With Chromium commits locally applied on WPT: 500a74f5 "Add a runtime flag to enforce strict MIME type checks for workers." a2a91a99 "Allow another touch start happen when there are active touch points" 85b61e6b "[resource-timing] Ensure workerStart is protected by TAO" a75430aa "Fix appcache tests." a50e7e60 "Move `Sec-Fetch-User` to SetSecFetchMetadataHeaders." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: I50e421d9afd09d0b455a4371e0a0bb75d4e25671 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947984Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#721213}
-
Michael Spang authored
This is a reland of f93bc96d Original change's description: > views: Assert toolkit_views=true in BUILD.gn > > Now that Chromecast Linux enables this, all builds that link //ui/views > are enabling this in GN. Add an assert so that accidental dependencies > are diagnosed by "gn gen". > > Bug: 1021770 > > Change-Id: I681645e97f69c22ee0410c1dba95319fddef7038 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898622 > Commit-Queue: Michael Spang <spang@chromium.org> > Reviewed-by: Robert Liao <robliao@chromium.org> > Cr-Commit-Position: refs/heads/master@{#715524} Bug: 1021770 TBR: robliao@chromium.org Change-Id: I6ce35ae59265a1ccc866256d1730a8d07fb88496 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934430Reviewed-by:
Michael Spang <spang@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#721212}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/98b58ad3de71..8a0f76d3749e git log 98b58ad3de71..8a0f76d3749e --date=short --first-parent --format='%ad %ae %s' 2019-12-03 tsepez@chromium.org Remove CFXJSE_Value::SetDate() and IsDate() 2019-12-03 tsepez@chromium.org Take vectors from partition in CFX_BmpDecompressor 2019-12-03 tsepez@chromium.org Take buffers from the partition in CPDF_Creator 2019-12-03 tsepez@chromium.org Avoid RetainPtr<Retainable>::As<CFX_TextUserData>() calls. 2019-12-03 tsepez@chromium.org Test FormCalc Encode() function. Created with: gclient setdep -r src/third_party/pdfium@8a0f76d3749e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: Ifc1fcf545369440e3ff2590df084aa9323ce136e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949181Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/be3109961d3d..240afdb1c43a git log be3109961d3d..240afdb1c43a --date=short --first-parent --format='%ad %ae %s' 2019-12-03 vadimsh@chromium.org [cipd] Update client 2.2.20 => 2.3.1. Created with: gclient setdep -r src/third_party/depot_tools@240afdb1c43a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: I29b726976d6af24e63c7619334c202ac954e2e0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949176Reviewed-by:
-
Hesen Zhang authored
- After several attempts of prototyping, we've figured out for this feature we need to build a keyedservice to keep some intermediate runnables, instead of directly hooking it up to ChromeActivity in Android side. - This CL setup UpdateNotificationService with empty implementation. Bug: 1013685 Change-Id: Iad1a973c6c8f10c4d4a08347e444f1a3221c6638 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946462Reviewed-by:
Xing Liu <xingliu@chromium.org> Reviewed-by:
Hesen Zhang <hesen@chromium.org> Commit-Queue: Hesen Zhang <hesen@chromium.org> Cr-Commit-Position: refs/heads/master@{#721209}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/969df2b3a21c..be5c13567227 git log 969df2b3a21c..be5c13567227 --date=short --first-parent --format='%ad %ae %s' 2019-12-03 rharrison@chromium.org Refactor code to have rudimentary support for using SPVC Created with: gclient setdep -r src/third_party/dawn@be5c13567227 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: Iad7605495377cf51ab1fbacd2efd91813dc19726 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949170Reviewed-by:
-
Collin Baker authored
Fixed: 1010247 Change-Id: Ic2efa71b563a339e5c9f23a76bbfbb8be5c9762a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948092 Auto-Submit: Collin Baker <collinbaker@chromium.org> Reviewed-by:
-
Joe Downing authored
With the Webapp gone, I am updating some build rules to be less webapp specific. Change-Id: I420aa95f9a87095008b5c39ef552db786b2301f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947985Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#721206}
-
Thomas Anderson authored
This is a reland of abf93b0b Reason for reland: Should be fixed for realz (hopefully) now that [1] has landed. [1] https://chromium.googlesource.com/chromium/src.git/+/5cc50bc375d289623ed0c290c3429c70e32a88d9 Original change's description: > Revert "Revert PowerSaveBlockerLinux [2/4]" > > This reverts commit bbfce899. > > Reason for revert: Issue should be fixed after https://chromium-review.googlesource.com/c/chromium/src/+/1937507/ lands > > Original change's description: > > Revert PowerSaveBlockerLinux [2/4] > > > > and the subsequent PowerSaveBlockerLinux [3/4] and PowerSaveBlockerLinux [4/4] patches > > > > This reverts commit 2fdeba1b. ("Rewrite PowerSaveBlockerLinux [2/4]") > > This reverts commit 38fdf074. ("Rewrite PowerSaveBlockerLinux [3/4]") > > This reverts commit 3bc463b4. ("Rewrite PowerSaveBlockerLinux [4/4]") > > > > The patch caused timeouts in WakeLockTest.ChangeType() and other tests in the services_unittests on > > Linux Tests (dbg). More details in crbug/1027852. > > > > TBR=thomasanderson@chromium.org > > > > Bug: 1013812,1027852 > > Change-Id: I7688c72f9d9d6c12ff3731f3abde6a05508cfbeb > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932357 > > Commit-Queue: Tim Schumann <tschumann@chromium.org> > > Reviewed-by: Tim Schumann <tschumann@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#718447} > > TBR=thomasanderson@chromium.org,tschumann@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 1013812, 1027852 > Change-Id: I84a6681cc8ec347587d38f0f5f38ed628e624274 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937509 > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> > Reviewed-by: Tim Schumann <tschumann@chromium.org> > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> > Cr-Commit-Position: refs/heads/master@{#720760} TBR=tschumann@chromium.org Bug: 1013812, 1027852 Change-Id: I4e18be4df7824a93769b8a13cc5455b8640e48c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949232Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#721205}
-
Brian Sheedy authored
Rolls the goldctl version to pick up recent changes, including the ability for goldctl to provide diffs for local testing. Also updates the GPU Gold code in order to provide the now-required --crs and --cis arguments when running on trybots. TBR=ynovikov@chromium.org Bug: 1030349 Change-Id: I3a3bd880a8c754441ff2f343ebb49eb610b5c7b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949082Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#721204}
-
Stephen Nusko authored
protozero event. This is the first full protozero typed event (!!). As part of this we need to add some dependencies on tracing to access the macros as well as protozero writing. This improves the output trace size when enabled because we no longer need to write out the JSON dictionary including field names. And decreasing tracing CPU overhead when this category is enabled by 8% (6%-10% at 95% CI) [1] This should also improve memory usage while tracing since we will not be emitting large dynamically allocated JSON dictionaries. [1] https://docs.google.com/spreadsheets/d/1dxtQ72hl_aRA4lWp45u0SsGysZ1YR155oE83pUd5Iso/edit?usp=sharing TBR=nuskos@google.com Change-Id: I0ac53b850cbce78d893ff26a204280bc8d627c4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944357 Commit-Queue: Stephen Nusko <nuskos@chromium.org> Reviewed-by:
Stephen Nusko <nuskos@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
enne <enne@chromium.org> Auto-Submit: Stephen Nusko <nuskos@chromium.org> Cr-Commit-Position: refs/heads/master@{#721203}
-
Connie Wan authored
Created TabGroupViews, which manages most of the tab group's visual calculations and updates. TabStrip still paints the views, but it no longer keeps low-level maps to each individual view. TabGroupUnderline can now use TabGroupViews for the bulk of its visual calculations. In the future, TabGroupHighlight will take a similar approach. Change-Id: I894dc03375cb29b42b80bd1273587a41131f1b22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925336 Commit-Queue: Connie Wan <connily@chromium.org> Reviewed-by:
Taylor Bergquist <tbergquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#721202}
-
Yann Dago authored
Bug: 1012920 Change-Id: Ifccd4d4eab21ba21d0e7984add2b26757e5cbec8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929450Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Yann Dago <ydago@chromium.org> Cr-Commit-Position: refs/heads/master@{#721201}
-
Takumi Fujimoto authored
This reverts commit 53550932. Reason for revert: This CL seems to have broken compile on the android_arm64-builder-perf bot: https://ci.chromium.org/p/chrome/builders/ci/android_arm64-builder-perf/135203 Original change's description: > [Payments] remove stubs for Clank dependencies > > This cl removes stubs from PaymentApp and PaymentInstrument classes as > well as payment_handler_host.mojom > > This should get landed after the dependnet Clank cl gets merged: > https://chrome-internal-review.googlesource.com/c/clank/internal/apps/+/2255260 > > Bug: 984694 > Change-Id: I03972ab75d7c4f33b644ebf77a9ef2618ef07921 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946457 > Reviewed-by: Ken Buchanan <kenrb@chromium.org> > Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org> > Commit-Queue: Sahel Sharify <sahel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#721089} TBR=kenrb@chromium.org,rouslan@chromium.org,sahel@chromium.org Change-Id: Iff10dbae61e31d32312bf8a4ca947b00ed003fae No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 984694 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948919Reviewed-by:
-
Devlin Cronin authored
Add a DCHECK that the Browser object the ExtensionViewHost is creating the view for is associated with the same profile as the ExtensionViewHost itself. Bug: None Change-Id: I2be3c2bcc5a3faaa309dd3250d5ecaac76b5ab9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940588Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#721199}
-
