Commits · 548fb14f8bdd686b8b2749abb08108b13e9f2491 · eriksson monteiro / tangled

13 Mar, 2011 8 commits

* WebProcess/WebCoreSupport/mac/WebDragClientMac.mm: · 548fb14f

darin@apple.com authored Mar 13, 2011

(WebKit::WebDragClient::startDrag): Fixed typo in a comment.



git-svn-id: svn://svn.chromium.org/blink/trunk@80955 bbb929c8-8fbe-4397-9dbb-9b2b20218538

548fb14f

r80743 updated the main baseline due to a jsc change. · 4a4769a7

levin@chromium.org authored Mar 13, 2011

chromium isn't affected by the change.

* platform/chromium/fast/js/regexp-caching-expected.txt: Added.
chromium already had a specific baseline for this but it was in chromium-win,
so I moved this result to the more general chromium direction.
* platform/chromium-win/fast/js/regexp-caching-expected.txt: Removed.

git-svn-id: svn://svn.chromium.org/blink/trunk@80954 bbb929c8-8fbe-4397-9dbb-9b2b20218538

4a4769a7

Remove bad test_expectation updates. · 88391066

levin@chromium.org authored Mar 13, 2011

I fixed both of these already:
  http://trac.webkit.org/changeset/80911
  http://trac.webkit.org/changeset/80904
so it is unclear why they were added.

* platform/chromium/test_expectations.txt:

git-svn-id: svn://svn.chromium.org/blink/trunk@80953 bbb929c8-8fbe-4397-9dbb-9b2b20218538

88391066

2011-03-12 Darin Adler <darin@apple.com> · 8f12c58f

darin@apple.com authored Mar 13, 2011

        Reviewed by Dan Bernstein.

        REGRESSION (r76474): IntegerArray hash hashes only 1/4 of the array
        https://bugs.webkit.org/show_bug.cgi?id=56258

        No tests because the wrong hashing is mostly harmless. The only symptom
        we have seen is an occasional assertion in debug builds about the size
        not being a multiple of two. But a worse hash is worse for performance too.

        * platform/cf/BinaryPropertyList.cpp:
        (WebCore::IntegerArrayHash::hash): Pass in the size in bytes rather
        than the number of array entries.


git-svn-id: svn://svn.chromium.org/blink/trunk@80952 bbb929c8-8fbe-4397-9dbb-9b2b20218538

8f12c58f

Not reviewed. · 7d7a56dc

cwzwarich@webkit.org authored Mar 13, 2011

Fix the build with newer GCCs and remove some extra whitespae.

* bindings/js/SerializedScriptValue.cpp:
(WebCore::uint8_t):


git-svn-id: svn://svn.chromium.org/blink/trunk@80951 bbb929c8-8fbe-4397-9dbb-9b2b20218538

7d7a56dc

Rubber-stamped by Oliver Hunt. · c234e475

cwzwarich@webkit.org authored Mar 13, 2011

Removed unused ARMv5 code. The ARMv5 case now falls under the general
unaligned accessed case.

* bindings/js/SerializedScriptValue.cpp:
(WebCore::CloneDeserializer::readLittleEndian):
(WebCore::CloneDeserializer::readString):


git-svn-id: svn://svn.chromium.org/blink/trunk@80950 bbb929c8-8fbe-4397-9dbb-9b2b20218538

c234e475

Reviewed by Oliver Hunt. · 5bf63c34

cwzwarich@webkit.org authored Mar 13, 2011

WebCore fails to build with Clang on ARM
https://bugs.webkit.org/show_bug.cgi?id=56257

Add an explicit instantiation of writeLittleEndian for uint8_t and move it to
namespace scope, since explicit specializations are not allowed at class scope.

* bindings/js/SerializedScriptValue.cpp:
(WebCore::writeLittleEndian):


git-svn-id: svn://svn.chromium.org/blink/trunk@80949 bbb929c8-8fbe-4397-9dbb-9b2b20218538

5bf63c34

2011-03-11 Darin Adler <darin@apple.com> · caf9248c

darin@apple.com authored Mar 13, 2011

        Reviewed by Sam Weinig.

        Dragging image to desktop gives webloc instead of image file in WebKit2
        https://bugs.webkit.org/show_bug.cgi?id=56193

        * WebCore.exp.in: Added some additional exports. Re-sorted.
2011-03-11  Darin Adler  <darin@apple.com>

        Reviewed by Sam Weinig.

        Dragging image to desktop gives webloc instead of image file in WebKit2
        https://bugs.webkit.org/show_bug.cgi?id=56193

        * WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:
        (WebKit::convertImageToBitmap): Added. Factored out from startDrag to
        make the startDrag code clearer.
        (WebKit::WebDragClient::startDrag): Streamlined code a bit.
        (WebKit::cachedImage): Added. Helper for function below.
        (WebKit::arrayForURLsWithTitles): Added. Helper for function below.
        (WebKit::WebDragClient::declareAndWriteDragImage): Added code to handle file
        promises and removed a log of uneeded code.
        (-[WKPasteboardFilePromiseOwner copyDropDirectory]): Added.
        (promisedDataClient): Added.
        (-[WKPasteboardOwner clearImage]): Added.
        (-[WKPasteboardOwner initWithImage:]): Added.
        (-[WKPasteboardOwner dealloc]): Added.
        (-[WKPasteboardOwner finalize]): Added.
        (-[WKPasteboardOwner pasteboard:provideDataForType:]): Added.
        (-[WKPasteboardOwner pasteboardChangedOwner:]): Added.
        (matchesExtensionOrEquivalent): Added.
        (-[WKPasteboardOwner namesOfPromisedFilesDroppedAtDestination:]): Added.
        Much of the new code above came from the WebKit1 drag code.

        * WebProcess/WebPage/WebPage.cpp:
        (WebKit::WebPage::dragEnded): Added call to Mac-only platformDragEnded.
        * WebProcess/WebPage/WebPage.h: Added Mac-only platformDragEnded and m_dragSource.
        * WebProcess/WebPage/mac/WebPageMac.mm:
        (WebKit::WebPage::setDragSource): Added.
        (WebKit::WebPage::platformDragEnded): Added.


git-svn-id: svn://svn.chromium.org/blink/trunk@80948 bbb929c8-8fbe-4397-9dbb-9b2b20218538

caf9248c

12 Mar, 2011 32 commits

<rdar://problem/8995822 > Build DumpRenderTree perl support only for the architectures · 37fa9f1e

mitz@apple.com authored Mar 12, 2011

DumpRenderTree is being built for.

Reviewed by Mark Rowe.

* DumpRenderTree/mac/PerlSupport/Makefile:



git-svn-id: svn://svn.chromium.org/blink/trunk@80947 bbb929c8-8fbe-4397-9dbb-9b2b20218538

37fa9f1e

Fix the 32-bit build. · 9eea7d4b

mrowe@apple.com authored Mar 12, 2011

Source/WebKit/mac:

* Carbon/CarbonWindowAdapter.mm:
(-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]): Use a more appropriate format specifier.
(-[CarbonWindowAdapter _carbonWindowClass]): Ditto.

Source/WebKit2:

This involves hacking around some HIToolbox headers that do things of dubious correctness,
and fixing the usual CGRect vs NSRect issues.

* UIProcess/mac/WKFullScreenWindowController.mm:
(-[WKFullScreenWindowController enterFullScreen:]): NSRect is not CGRect.
* WebProcess/FullScreen/mac/WebFullScreenManagerMac.mm:
(WebKit::WebFullScreenManagerMac::beginExitFullScreenAnimation): Ditto.

git-svn-id: svn://svn.chromium.org/blink/trunk@80946 bbb929c8-8fbe-4397-9dbb-9b2b20218538

9eea7d4b

* WebProcess/WebPage/WebFrame.cpp: · eccbfd32

andersca@apple.com authored Mar 12, 2011

(WebKit::WebFrame::url):
Get the URL from the loader, not from the document.

Reviewed by Sam Weinig.

(WebKit::WebFrame::suggestedFilenameForResourceWithURL):
Return the correct suggested filename for the main resource.

(WebKit::WebFrame::mimeTypeForResourceWithURL):
Return the correct mime type for the main resource.



git-svn-id: svn://svn.chromium.org/blink/trunk@80945 bbb929c8-8fbe-4397-9dbb-9b2b20218538

eccbfd32

Suggested by Mark Rowe. · 433cdb1a

mitz@apple.com authored Mar 12, 2011

* DumpRenderTree/mac/Configurations/Base.xcconfig: Leave C++ exceptions enabled
as they were before r80915.



git-svn-id: svn://svn.chromium.org/blink/trunk@80944 bbb929c8-8fbe-4397-9dbb-9b2b20218538

433cdb1a

2011-03-12 Anders Carlsson <andersca@apple.com> · 11947c47

andersca@apple.com authored Mar 12, 2011

        Reviewed by Sam Weinig.

        Should be able to download a PDF to the Downloads folder
        https://bugs.webkit.org/show_bug.cgi?id=56256

        * UIProcess/API/C/WKPage.h:
        Add WKPageSaveDataToFileInDownloadsFolderCallback to the UI client.

        * UIProcess/API/mac/PDFViewController.h:
        * UIProcess/API/mac/PDFViewController.mm:
        (-[WKPDFView _applyPDFPreferences]):
        (-[WKPDFView _updatePreferences:]):
        Use new PDFViewController::page getter.

        (-[WKPDFView PDFViewSavePDFToDownloadFolder:]):
        Call PDFViewController::savePDFToDownloadsFolder.

        (WebKit::releaseCFData):
        (WebKit::PDFViewController::savePDFToDownloadsFolder):
        Create a WebData that wraps the CFData, then pass it along to
        WebPageProxy::saveDataToFileInDownloadsFolder.

        * UIProcess/WebPageProxy.cpp:
        (WebKit::WebPageProxy::saveDataToFileInDownloadsFolder):
        Call WebUIClient::saveDataToFileInDownloadsFolder.

        (WebKit::WebUIClient::saveDataToFileInDownloadsFolder):
        * UIProcess/WebUIClient.h:
        Call the UI client callback function.
2011-03-12  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Should be able to download a PDF to the Downloads folder
        https://bugs.webkit.org/show_bug.cgi?id=56256

        * MiniBrowser/mac/BrowserWindowController.m:
        (-[BrowserWindowController awakeFromNib]):
        * WebKitTestRunner/TestController.cpp:
        (WTR::TestController::createOtherPage):
        (WTR::TestController::initialize):
        Update for API changes.


git-svn-id: svn://svn.chromium.org/blink/trunk@80943 bbb929c8-8fbe-4397-9dbb-9b2b20218538

11947c47

2011-03-12 Anders Carlsson <andersca@apple.com> · ac117046

andersca@apple.com authored Mar 12, 2011

        Reviewed by Sam Weinig.

        WebData should be able to wrap already existing data
        https://bugs.webkit.org/show_bug.cgi?id=56254

        * Shared/WebData.h:
        (WebKit::WebData::createWithoutCopying):
        (WebKit::WebData::create):
        (WebKit::WebData::~WebData):
        (WebKit::WebData::bytes):
        (WebKit::WebData::size):
        (WebKit::WebData::WebData):
        (WebKit::WebData::fastFreeBytes):


git-svn-id: svn://svn.chromium.org/blink/trunk@80942 bbb929c8-8fbe-4397-9dbb-9b2b20218538

ac117046

2011-03-12 Jer Noble <jer.noble@apple.com> · 96b54de2

jer.noble@apple.com authored Mar 12, 2011

        Reviewed by Eric Carlson.

        WebKit2: Initialize the WebFullScreenManagerProxy with a WKView
        https://bugs.webkit.org/show_bug.cgi?id=56250

        * UIProcess/API/mac/WKView.mm:
        (-[WKView initWithFrame:contextRef:pageGroupRef:]): Call fullScreenManager()->setView(self).

git-svn-id: svn://svn.chromium.org/blink/trunk@80941 bbb929c8-8fbe-4397-9dbb-9b2b20218538

96b54de2

2011-03-12 Ilya Tikhonovsky <loislo@chromium.org> · bc7f1a56

loislo@chromium.org authored Mar 12, 2011

        Unreviewed. Update chromium expectations.

        * platform/chromium/test_expectations.txt:



git-svn-id: svn://svn.chromium.org/blink/trunk@80940 bbb929c8-8fbe-4397-9dbb-9b2b20218538

bc7f1a56

2011-03-12 Ilya Tikhonovsky <loislo@chromium.org> · 7df08ce4

loislo@chromium.org authored Mar 12, 2011

        Unreviewed. Update chromium test expectations.

        * platform/chromium/test_expectations.txt:




git-svn-id: svn://svn.chromium.org/blink/trunk@80939 bbb929c8-8fbe-4397-9dbb-9b2b20218538

7df08ce4

2011-03-12 Sheriff Bot <webkit.review.bot@gmail.com> · 8d4e1e89

loislo@chromium.org authored Mar 12, 2011

        Unreviewed, rolling out r80919.
        http://trac.webkit.org/changeset/80919
        https://bugs.webkit.org/show_bug.cgi?id=56251

        all windows bots failed to compile this change (Requested by
        loislo on #webkit).

        * JavaScriptCore.xcodeproj/project.pbxproj:
        * bytecode/StructureStubInfo.cpp:
        * interpreter/Register.h:
        (JSC::Register::withInt):
        (JSC::Register::withCallee):
        (JSC::Register::operator=):
        (JSC::Register::i):
        (JSC::Register::activation):
        (JSC::Register::function):
        (JSC::Register::propertyNameIterator):
        (JSC::Register::scopeChain):
        * jit/JIT.h:
        * jit/JITCall.cpp:
        (JSC::JIT::compileOpCallInitializeCallFrame):
        (JSC::JIT::compileOpCallVarargs):
        (JSC::JIT::compileOpCall):
        * jit/JITCall32_64.cpp:
        (JSC::JIT::compileOpCallInitializeCallFrame):
        (JSC::JIT::compileOpCallVarargs):
        (JSC::JIT::compileOpCall):
        (JSC::JIT::compileOpCallSlowCase):
        * jit/JITInlineMethods.h:
        (JSC::JIT::emitPutToCallFrameHeader):
        * jit/JITOpcodes.cpp:
        (JSC::JIT::privateCompileCTINativeCall):
        (JSC::JIT::emit_op_get_pnames):
        (JSC::JIT::emit_op_next_pname):
        (JSC::JIT::emit_op_load_varargs):
        (JSC::JIT::emitSlow_op_load_varargs):
        * jit/JITOpcodes32_64.cpp:
        (JSC::JIT::privateCompileCTINativeCall):
        (JSC::JIT::emit_op_get_pnames):
        (JSC::JIT::emit_op_next_pname):
        * jit/JSInterfaceJIT.h:
        (JSC::JSInterfaceJIT::payloadFor):
        * jit/SpecializedThunkJIT.h:
        (JSC::SpecializedThunkJIT::returnJSValue):
        (JSC::SpecializedThunkJIT::returnDouble):
        (JSC::SpecializedThunkJIT::returnInt32):
        (JSC::SpecializedThunkJIT::returnJSCell):
        * runtime/ArgList.cpp:
        * runtime/DateConversion.cpp:
        * runtime/GCActivityCallbackCF.cpp:
        * runtime/Identifier.cpp:
        * runtime/JSActivation.h:
        (JSC::asActivation):
        * runtime/JSLock.cpp:
        * runtime/JSNumberCell.cpp:
        * runtime/JSObject.h:
        * runtime/JSPropertyNameIterator.h:
        * runtime/JSValue.h:
        * runtime/JSZombie.cpp:
        * runtime/MarkedBlock.cpp:
        * runtime/MarkedSpace.cpp:
        * runtime/PropertyNameArray.cpp:
        * runtime/ScopeChain.h:
        (JSC::ExecState::globalThisValue):
        * wtf/DateMath.cpp:
2011-03-12  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r80919.
        http://trac.webkit.org/changeset/80919
        https://bugs.webkit.org/show_bug.cgi?id=56251

        all windows bots failed to compile this change (Requested by
        loislo on #webkit).

        * bridge/c/c_class.cpp:
        * bridge/c/c_runtime.cpp:
        * bridge/jni/JavaMethod.cpp:
        * plugins/PluginViewNone.cpp:

git-svn-id: svn://svn.chromium.org/blink/trunk@80938 bbb929c8-8fbe-4397-9dbb-9b2b20218538

8d4e1e89

2011-03-12 Patrick Gansterer <paroga@webkit.org> · a280c104

paroga@webkit.org authored Mar 12, 2011

        Unreviewed WinCE build fix for r80900.

        * CMakeListsWinCE.txt: Removed IconDatabaseNone.cpp.

git-svn-id: svn://svn.chromium.org/blink/trunk@80937 bbb929c8-8fbe-4397-9dbb-9b2b20218538

a280c104

2011-03-12 Andras Becsi <abecsi@webkit.org> · cda0e1cc

abecsi@webkit.org authored Mar 12, 2011

        Unreviewed typo fix.

        No new tests needed.

        * WebCore.pro: Fix typo in header name.

git-svn-id: svn://svn.chromium.org/blink/trunk@80936 bbb929c8-8fbe-4397-9dbb-9b2b20218538

cda0e1cc

2011-03-12 Ilya Tikhonovsky <loislo@chromium.org> · 56edeb96

loislo@chromium.org authored Mar 12, 2011

        Unreviewed. Update chromium test expectations.

        * platform/chromium/test_expectations.txt:




git-svn-id: svn://svn.chromium.org/blink/trunk@80935 bbb929c8-8fbe-4397-9dbb-9b2b20218538

56edeb96

2011-03-12 Pavel Feldman <pfeldman@chromium.org> · d2a997b6

pfeldman@chromium.org authored Mar 12, 2011

        Not reviewed: Inspect Element action regression fix.

        * inspector/front-end/inspector.js:
        (WebInspector.inspect):


git-svn-id: svn://svn.chromium.org/blink/trunk@80934 bbb929c8-8fbe-4397-9dbb-9b2b20218538

d2a997b6

2011-03-12 Ilya Tikhonovsky <loislo@chromium.org> · e4f9f510

loislo@chromium.org authored Mar 12, 2011

        Unreviewed. One line fix for inspector/dom-breakpoints.html

        * inspector/front-end/BreakpointManager.js:
        (WebInspector.DOMBreakpointView.prototype.populateStatusMessageElement.decorateNode):




git-svn-id: svn://svn.chromium.org/blink/trunk@80933 bbb929c8-8fbe-4397-9dbb-9b2b20218538

e4f9f510

2011-03-12 Ilya Tikhonovsky <loislo@chromium.org> · 6ac44bb2

loislo@chromium.org authored Mar 12, 2011

        Unreviewed build fix.

        Almost all inspector tests are crashing after r80928.

        * inspector/front-end/inspector.js:




git-svn-id: svn://svn.chromium.org/blink/trunk@80932 bbb929c8-8fbe-4397-9dbb-9b2b20218538

6ac44bb2

2011-03-11 Pavel Feldman <pfeldman@chromium.org> · 16c67e25

pfeldman@chromium.org authored Mar 12, 2011

        Reviewed by Yury Semikhatsky.

        Web Inspector: follow up to error reporting, fixing multiple regressions.
        https://bugs.webkit.org/show_bug.cgi?id=56243

        * inspector/elements/elements-panel-search.html:
2011-03-11  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: follow up to error reporting, fixing multiple regressions.
        https://bugs.webkit.org/show_bug.cgi?id=56243

        * inspector/InjectedScript.cpp:
        (WebCore::InjectedScript::setPropertyValue):
        * inspector/InjectedScript.h:
        * inspector/Inspector.idl:
        * inspector/InspectorDOMAgent.cpp:
        (WebCore::InspectorDOMAgent::getChildNodes):
        (WebCore::InspectorDOMAgent::getOuterHTML):
        (WebCore::InspectorDOMAgent::getEventListenersForNode):
        * inspector/InspectorDOMAgent.h:
        * inspector/InspectorRuntimeAgent.cpp:
        (WebCore::InspectorRuntimeAgent::setPropertyValue):
        * inspector/InspectorRuntimeAgent.h:
        * inspector/front-end/DOMAgent.js:
        (WebInspector.DOMNode.prototype.setNodeName):
        (WebInspector.DOMNode.prototype.setNodeValue):
        (WebInspector.DOMNode.prototype.getChildNodes):
        (WebInspector.DOMNode.prototype.getOuterHTML):
        (WebInspector.DOMNode.prototype.setOuterHTML):
        (WebInspector.DOMNode.prototype.removeNode):
        (WebInspector.DOMNode.prototype.copyNode):
        (WebInspector.DOMAgent.prototype.pushNodeToFrontend):
        (WebInspector.DOMAgent.prototype.pushNodeByPathToFrontend):
        (WebInspector.EventListeners.getEventListenersForNode):
        * inspector/front-end/DOMStorage.js:
        (WebInspector.DOMStorage.prototype.getEntries):
        (WebInspector.DOMStorage.prototype.setItem):
        (WebInspector.DOMStorage.prototype.removeItem):
        * inspector/front-end/DOMStorageItemsView.js:
        (WebInspector.DOMStorageItemsView.prototype.update):
        (WebInspector.DOMStorageItemsView.prototype._showDOMStorageEntries):
        * inspector/front-end/ElementsTreeOutline.js:
        (WebInspector.ElementsTreeElement.prototype._createTooltipForNode.setTooltip):
        (WebInspector.ElementsTreeElement.prototype.updateChildren):
        ():
        * inspector/front-end/EventListenersSidebarPane.js:
        (WebInspector.EventListenersSidebarPane.prototype.update.callback):
        (WebInspector.EventListenersSidebarPane.prototype.update):
        * inspector/front-end/ObjectPropertiesSection.js:
        (WebInspector.ObjectPropertyTreeElement.prototype.applyExpression.callback):
        (WebInspector.ObjectPropertyTreeElement.prototype.applyExpression):
        * inspector/front-end/PropertiesSidebarPane.js:
        (WebInspector.PropertiesSidebarPane.prototype.update.nodeResolved):
        * inspector/front-end/RemoteObject.js:
        (WebInspector.RemoteObject.prototype.setPropertyValue):
        (WebInspector.RemoteObject.prototype.evaluate):
        * inspector/front-end/inspector.js:

git-svn-id: svn://svn.chromium.org/blink/trunk@80931 bbb929c8-8fbe-4397-9dbb-9b2b20218538

16c67e25

Unreviewed build fix. · ecf0ac52

jer.noble@apple.com authored Mar 12, 2011

Fix GTK+ builds by wrapping sections of full screen code in USE(ACCELERATED_COMPOSITING)
checks.

* dom/Document.cpp:
(WebCore::Document::webkitWillEnterFullScreenForElement):
(WebCore::Document::webkitDidEnterFullScreenForElement):
(WebCore::Document::webkitWillExitFullScreenForElement):
(WebCore::Document::webkitDidExitFullScreenForElement):

git-svn-id: svn://svn.chromium.org/blink/trunk@80930 bbb929c8-8fbe-4397-9dbb-9b2b20218538

ecf0ac52

2011-03-12 Ryuan Choi <ryuan.choi@samsung.com> · 163de04e

commit-queue@webkit.org authored Mar 12, 2011

        Unreviewed build fix.

        [EFL] Fix build break because of several reason.
        https://bugs.webkit.org/show_bug.cgi?id=56244

        * CMakeLists.txt: Add missing files.
        * platform/posix/FileSystemPOSIX.cpp: Add PLATFORM(EFL).
2011-03-12  Ryuan Choi  <ryuan.choi@samsung.com>

        Unreviewed build fix.

        [EFL] Fix build break because of several reason.
        https://bugs.webkit.org/show_bug.cgi?id=56244

        * ewk/ewk_settings.cpp:
        (ewk_settings_icon_database_path_set):

git-svn-id: svn://svn.chromium.org/blink/trunk@80929 bbb929c8-8fbe-4397-9dbb-9b2b20218538

163de04e

2011-03-11 Yury Semikhatsky <yurys@chromium.org> · 2a013d51

yurys@chromium.org authored Mar 12, 2011

        Reviewed by Pavel Feldman.

        Web Inspector: move profiler related methods from inspector agent to profiler agent
        https://bugs.webkit.org/show_bug.cgi?id=56204

        * inspector/Inspector.idl:
        * inspector/InspectorAgent.cpp:
        (WebCore::InspectorAgent::InspectorAgent):
        (WebCore::InspectorAgent::restoreInspectorStateFromCookie):
        (WebCore::InspectorAgent::setFrontend):
        (WebCore::InspectorAgent::disconnectFrontend):
        (WebCore::InspectorAgent::populateScriptObjects):
        (WebCore::InspectorAgent::showProfilesPanel):
        * inspector/InspectorAgent.h:
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::enableProfiler):
        (WebCore::InspectorController::disableProfiler):
        (WebCore::InspectorController::profilerEnabled):
        (WebCore::InspectorController::startUserInitiatedProfiling):
        (WebCore::InspectorController::stopUserInitiatedProfiling):
        (WebCore::InspectorController::isRecordingUserInitiatedProfile):
        * inspector/InspectorInstrumentation.cpp:
        (WebCore::InspectorInstrumentation::profilerEnabledImpl):
        * inspector/InspectorProfilerAgent.cpp:
        (WebCore::InspectorProfilerAgent::create):
        (WebCore::InspectorProfilerAgent::InspectorProfilerAgent):
        (WebCore::InspectorProfilerAgent::enable):
        (WebCore::InspectorProfilerAgent::disable):
        (WebCore::InspectorProfilerAgent::setFrontend):
        (WebCore::InspectorProfilerAgent::clearFrontend):
        (WebCore::InspectorProfilerAgent::restore):
        (WebCore::InspectorProfilerAgent::restoreEnablement):
        (WebCore::InspectorProfilerAgent::startUserInitiatedProfiling):
        (WebCore::InspectorProfilerAgent::stopUserInitiatedProfiling):
        * inspector/InspectorProfilerAgent.h:
        (WebCore::InspectorProfilerAgent::start):
        (WebCore::InspectorProfilerAgent::stop):
        * inspector/front-end/ProfileView.js:
        (WebInspector.CPUProfileType.prototype.buttonClicked):
        * inspector/front-end/ProfilesPanel.js:
        (WebInspector.ProfilesPanel):
        (WebInspector.ProfilesPanel.prototype._registerProfileType):
        (WebInspector.ProfilesPanel.prototype._toggleProfiling):
        * inspector/front-end/inspector.js:
        (WebInspector._createPanels):

git-svn-id: svn://svn.chromium.org/blink/trunk@80928 bbb929c8-8fbe-4397-9dbb-9b2b20218538

2a013d51

2011-03-11 Anton D'Auria <adauria@apple.com> · 9a09687f

commit-queue@webkit.org authored Mar 12, 2011

        Reviewed by Brady Eidson.

        Adding StorageTracker tests to skip lists of platforms that don't support it.
        https://bugs.webkit.org/show_bug.cgi?id=51878

        * platform/gtk/Skipped:
        * platform/qt/Skipped:
        * platform/win/Skipped:

git-svn-id: svn://svn.chromium.org/blink/trunk@80927 bbb929c8-8fbe-4397-9dbb-9b2b20218538

9a09687f

2011-03-11 Jer Noble <jer.noble@apple.com> · b081236a

jer.noble@apple.com authored Mar 12, 2011

        Reviewed by Anders Carlsson.

        WebCore::Document should notify ChromeClient when the full screen renderer's backing changes.
        https://bugs.webkit.org/show_bug.cgi?id=56226

        * dom/Document.cpp:
        (WebCore::Document::webkitWillEnterFullScreenForElement): Call setRootFullScreenLayer().
        (WebCore::Document::webkitDidEnterFullScreenForElement): Ditto.
        (WebCore::Document::webkitWillExitFullScreenForElement): Ditto.
        (WebCore::Document::webkitDidExitFullScreenForElement): Ditto.
        (WebCore::Document::setFullScreenRendererSize): Layout after setting the renderer's size.

git-svn-id: svn://svn.chromium.org/blink/trunk@80926 bbb929c8-8fbe-4397-9dbb-9b2b20218538

b081236a

2011-03-11 Jer Noble <jer.noble@apple.com> · 169ed869

jer.noble@apple.com authored Mar 12, 2011

        Reviewed by Anders Carlsson.

        Add full screen animation code to WebFullScreenManager.
        https://bugs.webkit.org/show_bug.cgi?id=56220

        * WebProcess/FullScreen/WebFullScreenManager.cpp: .
        (WebKit::WebFullScreenManager::~WebFullScreenManager): Added.
        (WebKit::WebFullScreenManager::exitFullScreenForElement): Remove ASSERTs.
        (WebKit::WebFullScreenManager::willEnterFullScreen): Set the full screen renderer's background color.
        (WebKit::WebFullScreenManager::didEnterFullScreen): Ditto.
        (WebKit::WebFullScreenManager::willExitFullScreen): Ditto.
        (WebKit::WebFullScreenManager::didExitFullScreen): Ditto.
        * WebProcess/FullScreen/WebFullScreenManager.h: Make a few functions pure virtual to be implemented in a
            concrete subclass.
        * WebProcess/FullScreen/mac/WebFullScreenManagerMac.h: Added.
        * WebProcess/FullScreen/mac/WebFullScreenManagerMac.mm: Added.
        (-[WebFullScreenManagerAnimationListener initWithManager:WebKit::began:finished:]): Listener for CAAnimations.
        (-[WebFullScreenManagerAnimationListener animationDidStart:]): Added.
        (-[WebFullScreenManagerAnimationListener animationDidStop:finished:]): Added.
        (-[WebFullScreenManagerAnimationListener invalidate]): Added.
        (WebKit::WebFullScreenManager::create): Now creates a WebFullScreenManagerMac.
        (WebKit::WebFullScreenManagerMac::create): Added.
        (WebKit::WebFullScreenManagerMac::WebFullScreenManagerMac): Added.
        (WebKit::WebFullScreenManagerMac::~WebFullScreenManagerMac): Added.
        (WebKit::WebFullScreenManagerMac::setRootFullScreenLayer): Set up the remote layer host.
        (WebKit::WebFullScreenManagerMac::beginEnterFullScreenAnimation): Create a CATransform3D
            which will animate the full screen renderer from its initial position to its final one.
        (WebKit::WebFullScreenManagerMac::beginExitFullScreenAnimation): Ditto.

git-svn-id: svn://svn.chromium.org/blink/trunk@80925 bbb929c8-8fbe-4397-9dbb-9b2b20218538

169ed869

2011-03-11 Jer Noble <jer.noble@apple.com> · 48762dae

jer.noble@apple.com authored Mar 12, 2011

        Reviewed by Anders Carlsson.

        Add full screen animation code to WebFullScreenManager.
        https://bugs.webkit.org/show_bug.cgi?id=56220

        * WebProcess/FullScreen/WebFullScreenManager.cpp: .
        (WebKit::WebFullScreenManager::~WebFullScreenManager): Added.
        (WebKit::WebFullScreenManager::exitFullScreenForElement): Remove ASSERTs.
        (WebKit::WebFullScreenManager::willEnterFullScreen): Set the full screen renderer's background color.
        (WebKit::WebFullScreenManager::didEnterFullScreen): Ditto.
        (WebKit::WebFullScreenManager::willExitFullScreen): Ditto.
        (WebKit::WebFullScreenManager::didExitFullScreen): Ditto.
        * WebProcess/FullScreen/WebFullScreenManager.h: Make a few functions pure virtual to be implemented in a
            concrete subclass.
        * WebProcess/FullScreen/mac/WebFullScreenManagerMac.h: Added.
        * WebProcess/FullScreen/mac/WebFullScreenManagerMac.mm: Added.
        (-[WebFullScreenManagerAnimationListener initWithManager:WebKit::began:finished:]): Listener for CAAnimations.
        (-[WebFullScreenManagerAnimationListener animationDidStart:]): Added.
        (-[WebFullScreenManagerAnimationListener animationDidStop:finished:]): Added.
        (-[WebFullScreenManagerAnimationListener invalidate]): Added.
        (WebKit::WebFullScreenManager::create): Now creates a WebFullScreenManagerMac.
        (WebKit::WebFullScreenManagerMac::create): Added.
        (WebKit::WebFullScreenManagerMac::WebFullScreenManagerMac): Added.
        (WebKit::WebFullScreenManagerMac::~WebFullScreenManagerMac): Added.
        (WebKit::WebFullScreenManagerMac::setRootFullScreenLayer): Set up the remote layer host.
        (WebKit::WebFullScreenManagerMac::beginEnterFullScreenAnimation): Create a CATransform3D
            which will animate the full screen renderer from its initial position to its final one.
        (WebKit::WebFullScreenManagerMac::beginExitFullScreenAnimation): Ditto.

git-svn-id: svn://svn.chromium.org/blink/trunk@80924 bbb929c8-8fbe-4397-9dbb-9b2b20218538

48762dae

2011-03-11 Jer Noble <jer.noble@apple.com> · 42df3182

jer.noble@apple.com authored Mar 12, 2011

        Reviewed by Anders Carlsson.

        Add full screen animation code to WebFullScreenManager.
        https://bugs.webkit.org/show_bug.cgi?id=56220

        * WebProcess/FullScreen/WebFullScreenManager.cpp: .
        (WebKit::WebFullScreenManager::~WebFullScreenManager): Added.
        (WebKit::WebFullScreenManager::exitFullScreenForElement): Remove ASSERTs.
        (WebKit::WebFullScreenManager::willEnterFullScreen): Set the full screen renderer's background color.
        (WebKit::WebFullScreenManager::didEnterFullScreen): Ditto.
        (WebKit::WebFullScreenManager::willExitFullScreen): Ditto.
        (WebKit::WebFullScreenManager::didExitFullScreen): Ditto.
        * WebProcess/FullScreen/WebFullScreenManager.h: Make a few functions pure virtual to be implemented in a
            concrete subclass.
        * WebProcess/FullScreen/mac/WebFullScreenManagerMac.h: Added.
        * WebProcess/FullScreen/mac/WebFullScreenManagerMac.mm: Added.
        (-[WebFullScreenManagerAnimationListener initWithManager:WebKit::began:finished:]): Listener for CAAnimations.
        (-[WebFullScreenManagerAnimationListener animationDidStart:]): Added.
        (-[WebFullScreenManagerAnimationListener animationDidStop:finished:]): Added.
        (-[WebFullScreenManagerAnimationListener invalidate]): Added.
        (WebKit::WebFullScreenManager::create): Now creates a WebFullScreenManagerMac.
        (WebKit::WebFullScreenManagerMac::create): Added.
        (WebKit::WebFullScreenManagerMac::WebFullScreenManagerMac): Added.
        (WebKit::WebFullScreenManagerMac::~WebFullScreenManagerMac): Added.
        (WebKit::WebFullScreenManagerMac::setRootFullScreenLayer): Set up the remote layer host.
        (WebKit::WebFullScreenManagerMac::beginEnterFullScreenAnimation): Create a CATransform3D
            which will animate the full screen renderer from its initial position to its final one.
        (WebKit::WebFullScreenManagerMac::beginExitFullScreenAnimation): Ditto.

git-svn-id: svn://svn.chromium.org/blink/trunk@80923 bbb929c8-8fbe-4397-9dbb-9b2b20218538

42df3182

2011-03-11 Jer Noble <jer.noble@apple.com> · 15c749a0

jer.noble@apple.com authored Mar 12, 2011

        Reviewed by Anders Carlsson.

        WebCore::Document should notify ChromeClient when the full screen renderer's backing changes.
        https://bugs.webkit.org/show_bug.cgi?id=56226

        * dom/Document.cpp:
        (WebCore::Document::webkitWillEnterFullScreenForElement): Call setRootFullScreenLayer().
        (WebCore::Document::webkitDidEnterFullScreenForElement): Ditto.
        (WebCore::Document::webkitWillExitFullScreenForElement): Ditto.
        (WebCore::Document::webkitDidExitFullScreenForElement): Ditto.
        (WebCore::Document::setFullScreenRendererSize): Layout after setting the renderer's size.
2011-03-11  Jer Noble  <jer.noble@apple.com>

        Reviewed by Anders Carlsson.

        Add full screen animation code to WebFullScreenManager.
        https://bugs.webkit.org/show_bug.cgi?id=56220

        * WebProcess/FullScreen/WebFullScreenManager.cpp: .
        (WebKit::WebFullScreenManager::~WebFullScreenManager): Added.
        (WebKit::WebFullScreenManager::exitFullScreenForElement): Remove ASSERTs.
        (WebKit::WebFullScreenManager::willEnterFullScreen): Set the full screen renderer's background color.
        (WebKit::WebFullScreenManager::didEnterFullScreen): Ditto.
        (WebKit::WebFullScreenManager::willExitFullScreen): Ditto.
        (WebKit::WebFullScreenManager::didExitFullScreen): Ditto.
        * WebProcess/FullScreen/WebFullScreenManager.h: Make a few functions pure virtual to be implemented in a
            concrete subclass.
        * WebProcess/FullScreen/mac/WebFullScreenManagerMac.h: Added.
        * WebProcess/FullScreen/mac/WebFullScreenManagerMac.mm: Added.
        (-[WebFullScreenManagerAnimationListener initWithManager:WebKit::began:finished:]): Listener for CAAnimations.
        (-[WebFullScreenManagerAnimationListener animationDidStart:]): Added.
        (-[WebFullScreenManagerAnimationListener animationDidStop:finished:]): Added.
        (-[WebFullScreenManagerAnimationListener invalidate]): Added.
        (WebKit::WebFullScreenManager::create): Now creates a WebFullScreenManagerMac.
        (WebKit::WebFullScreenManagerMac::create): Added.
        (WebKit::WebFullScreenManagerMac::WebFullScreenManagerMac): Added.
        (WebKit::WebFullScreenManagerMac::~WebFullScreenManagerMac): Added.
        (WebKit::WebFullScreenManagerMac::setRootFullScreenLayer): Set up the remote layer host.
        (WebKit::WebFullScreenManagerMac::beginEnterFullScreenAnimation): Create a CATransform3D
            which will animate the full screen renderer from its initial position to its final one.
        (WebKit::WebFullScreenManagerMac::beginExitFullScreenAnimation): Ditto.

git-svn-id: svn://svn.chromium.org/blink/trunk@80922 bbb929c8-8fbe-4397-9dbb-9b2b20218538

15c749a0

Support encoding /decoding WebData in usermessages · a5d01157

alice.liu@apple.com authored Mar 12, 2011

https://bugs.webkit.org/show_bug.cgi?id=56158

Reviewed by Sam Weinig.

Added encoding/decoding for APIObject::TypeData
* Shared/UserMessageCoders.h:
(WebKit::UserMessageEncoder::baseEncode):
(WebKit::UserMessageDecoder::baseDecode):



git-svn-id: svn://svn.chromium.org/blink/trunk@80921 bbb929c8-8fbe-4397-9dbb-9b2b20218538

a5d01157

Add api for "remove" to WKMutableDictionary · 20eb50ca

alice.liu@apple.com authored Mar 12, 2011

https://bugs.webkit.org/show_bug.cgi?id=56157

Reviewed by Sam Weinig.

* Shared/API/c/WKMutableDictionary.cpp:
(WKDictionaryRemoveItem): Added; call remove on MutableDictionary impl.
* Shared/API/c/WKMutableDictionary.h:
* Shared/MutableDictionary.cpp:
(WebKit::MutableDictionary::remove): Added; call remove on the underlying hashmap.
* Shared/MutableDictionary.h:



git-svn-id: svn://svn.chromium.org/blink/trunk@80920 bbb929c8-8fbe-4397-9dbb-9b2b20218538

20eb50ca

2011-03-11 Oliver Hunt <oliver@apple.com> · 22b1d4fa

oliver@apple.com authored Mar 12, 2011

        Reviewed by Gavin Barraclough.

        Ensure all values are correctly tagged in the registerfile
        https://bugs.webkit.org/show_bug.cgi?id=56214

        This patch makes sure that all JSCell pointers written to
        the registerfile are correctly tagged as JSCells, and replaces
        raw int usage with the immediate representation.

        For performance, register pressure, and general saneness reasons
        I've added abstractions for reading and writing the tag
        and payload of integer registers directly for the JSVALUE64
        encoding.

        * interpreter/Register.h:
        (JSC::Register::withInt):
        (JSC::Register::withCallee):
        (JSC::Register::operator=):
        (JSC::Register::i):
        (JSC::Register::activation):
        (JSC::Register::function):
        (JSC::Register::propertyNameIterator):
        (JSC::Register::scopeChain):
        * jit/JIT.h:
        * jit/JITCall.cpp:
        (JSC::JIT::compileOpCallInitializeCallFrame):
        (JSC::JIT::compileOpCallVarargs):
        (JSC::JIT::compileOpCall):
        * jit/JITCall32_64.cpp:
        (JSC::JIT::compileOpCallInitializeCallFrame):
        (JSC::JIT::compileOpCallVarargs):
        (JSC::JIT::compileOpCall):
        (JSC::JIT::compileOpCallSlowCase):
        * jit/JITInlineMethods.h:
        (JSC::JIT::emitPutToCallFrameHeader):
        (JSC::JIT::emitPutCellToCallFrameHeader):
        (JSC::JIT::emitPutIntToCallFrameHeader):
        * jit/JITOpcodes.cpp:
        (JSC::JIT::privateCompileCTINativeCall):
        (JSC::JIT::emit_op_get_pnames):
        (JSC::JIT::emit_op_next_pname):
        (JSC::JIT::emit_op_load_varargs):
        (JSC::JIT::emitSlow_op_load_varargs):
        * jit/JITOpcodes32_64.cpp:
        (JSC::JIT::privateCompileCTINativeCall):
        (JSC::JIT::emit_op_get_pnames):
        (JSC::JIT::emit_op_next_pname):
        * jit/JSInterfaceJIT.h:
        (JSC::JSInterfaceJIT::intPayloadFor):
        (JSC::JSInterfaceJIT::intTagFor):
        * jit/SpecializedThunkJIT.h:
        (JSC::SpecializedThunkJIT::returnJSValue):
        (JSC::SpecializedThunkJIT::returnDouble):
        (JSC::SpecializedThunkJIT::returnInt32):
        (JSC::SpecializedThunkJIT::returnJSCell):
2011-03-11  Oliver Hunt  <oliver@apple.com>

        Reviewed by Gavin Barraclough.

        Ensure all values are correctly tagged in the registerfile
        https://bugs.webkit.org/show_bug.cgi?id=56214

        Make sure everything builds still.

        * bridge/c/c_class.cpp:
        * bridge/c/c_runtime.cpp:
        * bridge/jni/JavaMethod.cpp:
        * plugins/PluginViewNone.cpp:

git-svn-id: svn://svn.chromium.org/blink/trunk@80919 bbb929c8-8fbe-4397-9dbb-9b2b20218538

22b1d4fa

Fix the 32-bit build. · bebcd00c

mrowe@apple.com authored Mar 12, 2011

* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
(WebCore::MediaPlayerPrivateAVFoundation::MediaPlayerPrivateAVFoundation):

git-svn-id: svn://svn.chromium.org/blink/trunk@80918 bbb929c8-8fbe-4397-9dbb-9b2b20218538

bebcd00c

2011-03-11 Sheriff Bot <webkit.review.bot@gmail.com> · 6278b7ca

rniwa@webkit.org authored Mar 12, 2011

        Unreviewed, rolling out r80899 and r80912.
        http://trac.webkit.org/changeset/80899
        http://trac.webkit.org/changeset/80912
        https://bugs.webkit.org/show_bug.cgi?id=56236

        Caused animation tests to crash on Snow Leopard WebKit2
        (Requested by rniwa on #webkit).

        * Shared/ShareableBitmap.cpp:
        (WebKit::ShareableBitmap::create):
        (WebKit::ShareableBitmap::createShareable):
        (WebKit::ShareableBitmap::resize):
        * Shared/ShareableBitmap.h:
        (WebKit::ShareableBitmap::numBytesForSize):
        (WebKit::ShareableBitmap::sizeInBytes):
        * UIProcess/DrawingAreaProxyImpl.cpp:
        (WebKit::DrawingAreaProxyImpl::update):
        * WebKit2.xcodeproj/project.pbxproj:
        * WebProcess/WebPage/DrawingArea.h:
        (WebKit::DrawingArea::didUpdate):
        * WebProcess/WebPage/DrawingArea.messages.in:
        * WebProcess/WebPage/DrawingAreaImpl.cpp:
        (WebKit::DrawingAreaImpl::~DrawingAreaImpl):
        (WebKit::DrawingAreaImpl::sendDidUpdateBackingStoreState):
        (WebKit::DrawingAreaImpl::didUpdate):
        (WebKit::DrawingAreaImpl::exitAcceleratedCompositingMode):
        (WebKit::DrawingAreaImpl::display):
        * WebProcess/WebPage/DrawingAreaImpl.h:
        * WebProcess/WebPage/SharedMemoryCache.cpp: Removed.
        * WebProcess/WebPage/SharedMemoryCache.h: Removed.
        * win/WebKit2.vcproj:


git-svn-id: svn://svn.chromium.org/blink/trunk@80917 bbb929c8-8fbe-4397-9dbb-9b2b20218538

6278b7ca

<rdar://problem/9124537 > Crashes during layout tests due to overrelease of AVFoundation objects. · 3757446e

mrowe@apple.com authored Mar 12, 2011

Rubber-stamped by Eric Carlsson.

* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::createContextVideoRenderer):
(WebCore::MediaPlayerPrivateAVFoundationObjC::setAsset):

git-svn-id: svn://svn.chromium.org/blink/trunk@80916 bbb929c8-8fbe-4397-9dbb-9b2b20218538

3757446e