- 16 Oct, 2020 40 commits
-
-
Greg Thompson authored
BUG=None Change-Id: I61815af5d9779b8379001421c46b8fe1f14d396b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461324 Commit-Queue: Greg Thompson <grt@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#817998}
-
dpapad authored
Bug: 1132403 Change-Id: I690822d909ed5c86bcb1b9c6652bfc9dd61cf3e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2479142 Commit-Queue: John Lee <johntlee@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by:
John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#817997}
-
Yuke Liao authored
The goal is to speed-up the compilation and linkinng on linux-lacros-rel to as to offset the extra overhead of enabling 'also_build_ash_chrome' gn arg. Bug: 1129223 Change-Id: I7313fc22cc0115a33c8b4c0325655dae26a1c249 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477611Reviewed-by:
Erik Staab <estaab@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#817996}
-
Rebekah Potter authored
This reverts commit 593dfd4d. Reason for revert: Collided with history generate grd CL, CQ did not re-run. Original change's description: > WebUI: Add support for resource_path_rewrites to generate_grd > > Support more general resource path rewrites by adding the option to > pass such rewrites from the caller in the form: > "original_file_path|resource_path_for_grd" > Leverage this to rename rollup files, and remove the special-case logic > that was used for this purpose originally. > > Bug: 1132403 > Change-Id: Icffa7d85497ab000044fed1ebcd9542cb5b869bc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476623 > Reviewed-by: dpapad <dpapad@chromium.org> > Commit-Queue: Rebekah Potter <rbpotter@chromium.org> > Cr-Commit-Position: refs/heads/master@{#817961} TBR=dpapad@chromium.org,rbpotter@chromium.org Change-Id: Iabdc7d8cc3cb45704330e3ba9b79e3ac585446d5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1132403 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481063Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#817995}
-
Omar Morsi authored
Before this CL, ScopedTestSystemNSSKeySlotMixin used ScopedTestNSSDB which used a temp. directory to save the database data. This temp. directory will be deleted after browser pre-tests (tests that start with PRE_). This CL changes ScopedTestSystemNSSKeySlotMixin such that it opens a software slot in the user data directory which is not deleted after browser pre-tests so to allow tests using system slot to simulate browser restarts. Bug: 1136437, 1127284, 1113115 Change-Id: Ie61a6a7f594b996236b709e2db765a240e7b8800 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460730Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Commit-Queue: Omar Morsi <omorsi@google.com> Cr-Commit-Position: refs/heads/master@{#817994}
-
Maksim Sisov authored
These no longer fail (were fixed at some point). Bug: 1084472 Change-Id: I45dd6e907056825a0bb8788dad7d74fc6446dd2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445154Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com> Auto-Submit: Maksim Sisov (GMT+3) <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#817993}
-
Martin Kreichgauer authored
AuthTokenRequester is a helper class that attempts to obtain a PinUvAuthToken from a FidoAuthenticator. It has a Delegate that collects PINs, updates the UI and receives the result. Follow-up CLs will integrate AuthTokenRequester into FidoRequestHandler implementations and replace the token request logic there. Change-Id: Ie189dab3a02fb1a118e128bb7589461ba5c5fad3 Bug: 1139111 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469404Reviewed-by:
Nina Satragno <nsatragno@chromium.org> Commit-Queue: Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#817992}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1602795589-2bd353ec3fee304a6bd3887aca77b7d3fb1210e3.profdata to chrome-win32-master-1602838722-3d3847c86317a9aa85069273b7be64c1533b4e7a.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Idfac5d1a8893a7ecdba9333cff7b6f12ea9fcf4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2478891Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#817991}
-
Jérôme Lebel authored
This reverts commit b2a6b60d. Since this patch is introducing a bug, I need to revert this patch: * sign-in * open the settings * open the account list * open the add SSO account view * cancel the SSO add account view Result: the user can't do sign-out anymore. Original change's description: > [iOS] Dismiss views on top of Settings UI after authentication. > > Currently the sign out UI is dismissed conditionally when the > authentication flow is complete. Remove the conditional since we expect > the sign out UI every time authentication completes. > > Bug: 1125631 > Change-Id: Ide9805e5490377f9ec3cf5d3625622ab08e876a4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472005 > Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> > Reviewed-by: Jérôme Lebel <jlebel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#817863} TBR=jlebel@chromium.org,fernandex@chromium.org Change-Id: I40270d09662e2ccd5d24b8915d540cb5cd28ae49 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1125631 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480824Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#817990}
-
Abigail Klein authored
settings subpage. To do this, move the component updater observer logic to the captions handler. Introduce a new ChromeOS-specific captions handler which will observe the SODA download from the DLC service (to be implemented in a follow-up). AX-Relnotes: N/A (feature not launched yet) Bug: 1055150, 1111002 Change-Id: I1f752836a1310f8eab44ae5fa31ca34060fb8147 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473446 Commit-Queue: Abigail Klein <abigailbklein@google.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#817989}
-
Alice Wang authored
This CL adds metric for the dismissal button in the web sign-in bottom sheet. Bug: 1139309 Change-Id: Idc381b3a79c77aa471b9b1a0b19bcc8fb731a4ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2479426Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#817988}
-
Mitsuru Oshima authored
This is a preparation to add GradientMask[1] support. [1] https://docs.google.com/document/d/1AXgfk66ROEr225roqAuPxrqWNsnDh91lHCQJ_cw8RrI/edit# Bug: 1039003 Change-Id: Ib452c83e3408a1cbdcfb743e0a5ce819258f5ff3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459429Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#817987}
-
Donn Denman authored
Updates the IPH param settings in the testing config file to add the Translations IPH and move the IPH parameters for Longpress into their own experiment. This reflects the Finch config layout we are planning, which gets around the limitation of having an IPH for each experiment when they are both active. BUG=1121867,1086724,1120080 Change-Id: I5d9758845bef2f84ac5a245c1b6967a1bcf7b908 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477427Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Donn Denman <donnd@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Auto-Submit: Donn Denman <donnd@chromium.org> Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#817986}
-
Scott Violet authored
Prior to this patch, if the top-view was configured to only expand at top, then on page load the top-view would not be shown. During a load if current_browser_controls_visibility_constraint_ is BOTH, then cc is called with current and constraints of BOTH. cc doesn't do anything in this case. As we need to ensure the top-view is shown in this scenario this changes the code to supply SHOWN. This code path is only hit if top-view is configured to only-expand-at-top, as when only-expand-at-top is false, current_browser_controls_visibility_constraint_ is set to SHOWN. I experimented with fixing in cc, but cc has no notion of page loading. So, this fix is better done in WebLayer. BUG=1135964 TEST=BrowserControlsTest Change-Id: I7834ade5cd80de6946af0c2f917fb0ea1996e1f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476725 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#817985}
-
Xing Liu authored
IsReadListBookmark only checks the URL, which creates a problem that other bookmark source may have the same URL. Instead, this should check the in memory tree. Also print an error log for a legacy NOTREACHED() in bookmark_bridge.cc, since reading list eventually may be able to delete but not editable. Bug: 1139133 Change-Id: I58d2cbb6e2cd43c94670e2b707f5b4dd6fdd3128 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476750Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#817984}
-
manukh authored
- Omnibox.DocumentSuggest.Requests - Omnibox.DocumentSuggest.ResultCount We're still running experiments post-enterprise launch and will want to keep an eye on metrics for consumer launch as well. Bug: 1138296 Change-Id: I47004fce1dd132ba5a8e2070db47efe28986a90b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476535Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#817983}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/04bd4d8e4ece..a23231ea7d91 2020-10-16 cwallez@chromium.org MetalSurface: correctly handle the window resizing. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: Idb6ca255905d38af154876d037454c5c36e9a095 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480382Reviewed-by:
-
Wez authored
Change-Id: Ie11606d71cd35269cce836407d9a302f45602f2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2479368 Auto-Submit: Wez <wez@chromium.org> Commit-Queue: David Dorwin <ddorwin@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#817981}
-
Xing Liu authored
We have deprecated K, DisableIf can be removed in BookmarkTest. Bug: 807807 Change-Id: I405bed68d1568211affd2ee4f293d019df5dade9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2478142Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#817980}
-
Adam Langley authored
onDestroy is called some time after an Activity is dismissed (i.e. "stopped") in Android terms. But I think caBLE operations should be suspended immediately when the Activity is dismissed. BUG=1002262 Change-Id: Idcc09daa17cd2ad691bd26a24c3f4af1ea1a1a6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477518Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Commit-Queue: Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#817979}
-
Fredrik Söderqvist authored
This makes sure that the requests for the cursor resources has been issued before the following loadImages(...) call. Bug: 1137716, 1138589 Change-Id: I691360327c0d4f70f8eb50fdae224ab53dcc6111 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2479523 Commit-Queue: Stephen Chenney <schenney@chromium.org> Auto-Submit: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#817978}
-
Aaron Krajeski authored
It used to be the case that all small canvases were rendered in software. This was changed to improve performance, simplify code and improve testing. Unfortunately it caused a ton of crashes for webview devices. crbug.com/994310 A kludge was introduced to prevent these crashes for webview devices only: https://chromium-review.googlesource.com/c/chromium/src/+/1800346 Now that more than a year has gone by and there's been a lot of movement in all the relevant codebases (skia, webview, canvas, oop-r, etc.) it's worth seeing if this spike in crashes still happens. To remove this kludge would allow us to finally clear up the code path and greatly simplify testing. Bug: 1136603 Change-Id: Idca3844ee13f064adf8043ebcdc43808c6588f24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463328 Commit-Queue: Aaron Krajeski <aaronhk@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#817977}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/db0288d747ae..7db7139f4032 2020-10-16 bsalomon@google.com Revert "Revert "Move all YUVA image creation in GMs into sk_gpu_test::LazyYUVImage."" 2020-10-16 tdenniston@google.com Reland "Add subset of W3C test suite to SVG corpus" 2020-10-16 bsalomon@google.com Revert "Move all YUVA image creation in GMs into sk_gpu_test::LazyYUVImage." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC robertphillips@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: robertphillips@google.com Change-Id: Ie1c0116fca5c584ce8169a7e85f4c895e739ef87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480403Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/711de82cd1ce..a667f878b15c 2020-10-16 kwiberg@webrtc.org Polish the "Using Abseil in WebRTC" docs 2020-10-16 danilchap@webrtc.org In VP9 wrapper fill information required to produce Dependency Descriptor If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I42722705e199ab16e03eddb20ea26c3792feb876 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480542Reviewed-by:
-
Hung Vu authored
This CL handles how users' choices will be recorded if the location suggestion dialog is triggered. Bug: 1136234 Change-Id: I8118fc1ccd6fb64d3509cae2173cd3190bb98a7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473357Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Reviewed-by:
Weilun Shi <sweilun@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Hung Vu <vuhung@google.com> Cr-Commit-Position: refs/heads/master@{#817974}
-
Greg Thompson authored
base/win/registry.h includes more than it uses. These files were inadvertently relying on that fact. This CL adds missing includes so that registry.h can be cleaned up. BUG=None This CL was uploaded by git cl split. R=gab@chromium.org Change-Id: I1ed6961a801d4c1a15b322003c35bf45735db8d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2475054 Commit-Queue: Robert Liao <robliao@chromium.org> Reviewed-by:
-
Victor Costan authored
Change-Id: I2cd08bd561f5d9a8be8b0c6562cebe80f4afe398 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2478886Reviewed-by:
enne <enne@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#817972}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/b4fb7cc9ec8f..119d867c232d 2020-10-16 lehoangq@gmail.com Metal: autogen blit & clear shaders for integer textures 2020-10-16 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 312a2b1c to 20073b86 (419 revisions) 2020-10-16 lehoangq@gmail.com Metal: Support 2D array textures and base & max levels. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ynovikov@google.com Change-Id: I7f44a8610cf19f50e794506f01b5796fb49ac7f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2478893Reviewed-by:
-
Toni Barzic authored
Increases the delay for announcing search query changes to give chromevox more time to announce query changes, and to give search results more time to stabilize. Makes sure the selection moves to the search box text field when the user interacts with the search box (e.g. when they change the query). This should ensure that the chromevox announces the textfield changes to the user. Note that this should be done only if the selection has moved to a search result (otherwise ChromeVox would announce the full extfield value on each text update). To achieve this, SearchResultPageView has to notify the SearchBoxView that it changed the current selection - the cl adds a11y_selection_on_search_result_ member to the SearchBoxView that is set by SearchResultPageView, and reset by SearchBoxView when the selection moves back to the textfield. Removes calls to notify a11y selection changes from search result views. SearchResultPageView already handles result selection changes and sends the selection updates, but it also updates the search box state. Moves the a11y selection to the close button when it's focused. Updates the search box accessible name when search box is active not to reference using keys to navigate apps (as there are no apps to navigate when the search box is active). BUG=1111579 Change-Id: Ib11bcc9122e7545c7a37ad4ea2a6005459ee6176 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476903 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#817970}
-
Maksim Sisov authored
This is the last test suite that can be enabled. Next test suites can be enabled only after more resourcese are allocated. See https://crbug.com/1125488 to track the status of that. Bug: 1134495 Change-Id: I611def00a1967c615227d84563ee0fd0d8beb803 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2479165 Auto-Submit: Maksim Sisov (GMT+3) <msisov@igalia.com> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
-
Ethan Jimenez authored
1. Refactoring how `NGGridLayoutAlgorithmTrackCollection` provides iterators for its internal `NGGridSet` collection. 2. Introducing new fields to `NGGridSet` that will be used by the track sizing algorithm, mapping directly to concepts like planned increase, item-incurred increase, infinitely growable, etc. 3. Adding indices to `GridItemData` that point to the `begin` and `end` of the range that each item spans across the relevant collection of `NGGridSet` for both track directions; these indices are cached in the new `NGGridLayoutAlgorithm::CacheItemSetIndices` method. 4. Introducing `NGGridItemContributionType`, an enum to delimitate the stages from https://drafts.csswg.org/css-grid-1/#algo-spanning-items; this enum will be used to determine the size that a grid item will contribute to intrinsic track sizing. It will also be used to adapt the behavior of many of the methods introduced above according to the stage of the algorithm. 5. Introducing most of the intrinsic track sizing algorithm steps described in https://drafts.csswg.org/css-grid-1/#algo-content. Implementation is made up of the following methods: - `ResolveIntrinsicTrackSizes` - `IncreaseTrackSizesToAccommodateGridItems` - `DistributeExtraSpaceToSets` Several other helpers are introduced, but scoped to an unnamed namespace only accessible to `NGGridLayoutAlgorithm`. 6. Updating expectations for several blink web tests; new crashes caused by the missing 'dense' auto placement of grid items are exposed, a fix for this issue is expected to land in a follow up change. Bug: 1045599 Change-Id: Ifffe899ffd5d6752d8e7c319ed04cfde53c825b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461695Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Ethan Jimenez <ethavar@microsoft.com> Cr-Commit-Position: refs/heads/master@{#817968}
-
Ryan Heise authored
Change-Id: I86a9b0e4d74f57cf1e20976084504cacc1883b63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480804Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Ryan Heise <heiserya@google.com> Auto-Submit: Ryan Heise <heiserya@google.com> Cr-Commit-Position: refs/heads/master@{#817967}
-
spdonghao authored
Bug: 1126823 Change-Id: I32ec909f844c29433d1b60e0048ba725052718f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2475575Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
-
S. Ganesh authored
Handle multiple guid substitutions, where |dynamic_guid| is of the form "158428a4-6014-4978-83ba-9fad0dabe791=3d852661-c795-4d20-9b95-5561e9a1d2 d9," "63B8FFB1-5314-48C9-9C57-93EC8BC6184B=D0E1CACC-C63C-4192-94AB-BF8EAD0E3B 83". Before specifying |dynamic_guid| in the build, the IDL file is first compiled with "158428a4-6014-4978-83ba-9fad0dabe791" and "63B8FFB1-5314-48C9-9C57-93EC8BC6184B". These are the "replaceable" guids, i.e., guids that can be replaced in future builds. The resulting MIDL outputs are copied over to src\third_party\win_build_output\. Then, in the future, any changes to these guids can be accomplished by providing a |dynamic_guid| of the format above in the build file. These "dynamic" guid changes by themselves will not require the MIDL compiler and therefore will not require copying output over to src\third_party\win_build_output\. The pre-generated src\third_party\win_build_output\ files are used for cross-compiling on other platforms, since the MIDL compiler is Windows-only. Bug: 1109612 Change-Id: Ia0af825860df7adec3b23e11d32838de02c52604 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476894Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: S. Ganesh <ganesh@chromium.org> Cr-Commit-Position: refs/heads/master@{#817965}
-
Patrick Noland authored
Despite asserts to the contrary, the TabModelSelector can evidently be null at initialization time. Taking a cue from other TabSwitcher components, we allow for this possibility and move the observer setup to setTabModelSelector and make the observer safe to trigger when the underlying view is still null. Bug: 1137994 Change-Id: I9576699235a4f46ff6d28381eaefecea45c150c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477283 Commit-Queue: Patrick Noland <pnoland@chromium.org> Reviewed-by:
Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#817964}
-
Claude van der Merwe authored
This CL prevents Wifi Sync v2 from being enabled after multidevice setup if: 1. Wifi Sync V2 is not supported on the host device. 2. Wifi Sync V2 is prohibited by enterprise policy. The unittests are also updated to test for these cases. Bug: 1117619 Change-Id: I7e797430f4bc81700281ce74c54b2497a71fe312 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468916 Commit-Queue: Claude van der Merwe <cvandermerwe@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Jon Mann <jonmann@chromium.org> Cr-Commit-Position: refs/heads/master@{#817963}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/fab8fd6a143c..ae3dc89611ac 2020-10-16 alcastano@google.com [Devtools docs] Add build directory parameter in layout tests 2020-10-16 pfaffe@chromium.org TypeScriptify DebuggerWorkspaceBindings 2020-10-16 szuend@chromium.org Fix parsed JSON request payload in Network headers view 2020-10-16 carl@cpespe.com Add clip-path property values for autocomplete menu 2020-10-16 bmeurer@chromium.org [wasm] Add support for mouse hover for WebAssembly disassembly. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1058836,chromium:1071432,chromium:1138110,chromium:954126 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I75a31dc07626591d7a9e496b629fc99ab115fc3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480402Reviewed-by:
-
rbpotter authored
Support more general resource path rewrites by adding the option to pass such rewrites from the caller in the form: "original_file_path|resource_path_for_grd" Leverage this to rename rollup files, and remove the special-case logic that was used for this purpose originally. Bug: 1132403 Change-Id: Icffa7d85497ab000044fed1ebcd9542cb5b869bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476623Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#817961}
-
Liquan (Max) Gu authored
Added PaymentAppService#resetForTest() to allow unit tests to clear the factories. This is needed because the singleton PaymentAppService does not clear its states between tests. This method will be used by the //clank tests. Bug: 1091475 Change-Id: Iffd27a74868cca573e3e1086a449f31f3344f66b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477035 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#817960}
-
chromium-internal-autoroll authored
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202010160700_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/9Q3G72W_FP-DamN_GtRTUZe7jm4X8tsVnaUJ3Gp3fuMC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: media-app@grotations.appspotmail.com Change-Id: If3747bdf022e79c6bcf2795958582569db3e4b16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2479323Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#817959}
-
