- 02 Nov, 2018 40 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/643fe6108096..8923650232d6 Created with: gclient setdep -r src-internal@8923650232d6 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I7e93d631e82dafb4a4b7d8ba1d31acfb045a4159 Reviewed-on: https://chromium-review.googlesource.com/c/1314105Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#604919}
-
Samuel Huang authored
Outlining in LLD creates many symbols with names OUTLINED_FUNCTION_0, OUTLINED_FUNCTION_1, etc. that appear many times. Problems: * Unrelated symbols can share the same name. If object path information is available in the .map file (true for arm64 without ThinLTO), then SuperSize would run 10x as long because these paths get joined in an O(n^2) fashion. * In nm output, an address can have many OUTLINED_FUNCTION_* symbols, which adds to the bloat. This CL adds to SuperSize outlining support to solves the problems above. Details: * link_map_parser.py: (for LLD, and also Gold for testing) Detect OUTLINED_FUNCTION_* and reassign the name to '** outlined function'. The '*' prefix labels these symbols as placeholders, so these symbols will be ignored by nm results from .o files, and no object path joining occurs. * nm.py: For the nm call to the main ELF file, combine multiple OUTLINED_FUNCTION_* with the same address into a single symbol, and assign the name to '** outlined function * (count)'. If combination takes place, then "forced passing" occurs, i.e., the name will always be passed (rather than discarded to save space) to |names_by_address|. * archive.py: Updated to reconcile the two sources of '** outlined function' symbols. Outlined functions can share address with named symbols. Due to the combining in nm.py, this causes number of aliased symbols to decrease for affected named symbols (and increases PSS). '** outlined function' symbols can have object_path assigned, but the data are obtained from .map files only, since these symbols are ignored for nm results from .o files. Furthermore, if an outlined function symbol shares an address with any other such symbol (as found by nm results for the main ELF file), then it won't have object_path assigned (since "forced passing" above causes _AddNmAliases() to process the symbol, but this discards object_path data from .map files). Bug: 891061 Change-Id: Ie0109c7fc876749c10a87b5a7673af2be49d38c4 Reviewed-on: https://chromium-review.googlesource.com/c/1312561Reviewed-by:
Samuel Huang <huangs@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#604918}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/fa338454..879aea82 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I968256e6b1db2ce1a5f36b5da7b8bf55328079f2 Reviewed-on: https://chromium-review.googlesource.com/c/1314147Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#604917}
-
khachatryan authored
Disabling window maximize tests on Mac for Chrome v69 Change-Id: Ide707ac877e3f94b32d48ad27400aba41782a19f Reviewed-on: https://chromium-review.googlesource.com/c/1314137Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#604916}
-
Evan Stade authored
Bug: none Change-Id: I92eeb20b32a1127e6b98a7b23d8e4bd40a3e1506 Reviewed-on: https://chromium-review.googlesource.com/c/1313563Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#604915}
-
Morten Stenshorne authored
Fixes imported here: https://chromium-review.googlesource.com/c/1314128 Spec change: https://github.com/w3c/csswg-drafts/issues/2394 TBR=szager@chromium.org Bug: 884588 Change-Id: I4e1c9537122817afb9ebe03ad70290a0558f582c Reviewed-on: https://chromium-review.googlesource.com/c/1314631Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#604914}
-
Lukasz Suder authored
Payment request returns details that are detached from profile. In order to use them by autofill a profile is needed, which we now create on the fly. Bug: 806868 Change-Id: Ic5ef1b4767b0978d2ef47557a5c10b8a2e7c5cfb Reviewed-on: https://chromium-review.googlesource.com/c/1304518 Commit-Queue: Lukasz Suder <lsuder@google.com> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#604913}
-
Miguel Casas authored
Bit of a cleanup accesory to crrev.com/c/1308043: a new pair of private methods (StartListeningForDidProcessTask() and StopListeningForDidProcessTask() ) are added. They work together with the associate renamed flag s/finalize_frame_scheduled_/listening_for_did_process_task_/ to listen for ProcessTask events (WillProcessTask/DidProcessTask). This is a cleanup of things in preparation for the next CL in the chain: crrev.com/c/1308043. No new functionality intended. Bug: 839970 Change-Id: I0bad9e3bfc80b02865c34ba4c20d37f71ecb83a9 Reviewed-on: https://chromium-review.googlesource.com/c/1308754Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#604912}
-
Juan Antonio Navarro Pérez authored
This reverts commit 36713b50. Reason for revert: Causes Chrome to crash on power.typical_10_mobile Rotating earth test. Original change's description: > NavigationPredictor: Skip anchor elements that belong to an ad frame > > At OnLoad event, the renderer notifies browser process of the > anchor elements in the viewport. The browser uses this information > to predict the navigation probability of each of these anchor > elements. > > This CL changes the logic in the render side to skip reporting > of elements that are part of ad frames since we expect these > to be clicked less often. > > Change-Id: Ia131ac301acda317e7618ac206f4bda60c39e5cf > Bug: 899339 > Reviewed-on: https://chromium-review.googlesource.com/c/1300682 > Reviewed-by: Steven Holte <holte@chromium.org> > Reviewed-by: Ryan Sturm <ryansturm@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Commit-Queue: Tarun Bansal <tbansal@chromium.org> > Cr-Commit-Position: refs/heads/master@{#604738} TBR=kinuko@chromium.org,holte@chromium.org,tbansal@chromium.org,ryansturm@chromium.org Change-Id: Ifa21f582007d7f50917e66a94ea905cf3a095902 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 899339 Reviewed-on: https://chromium-review.googlesource.com/c/1315208Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#604911}
-
Rune Lillesveen authored
For some reason we created a new AttachContext entering a ShadowRoot for AttachLayoutTree. If the shadow host was display:contents we would lose the previous_in_flow from the shadow tree checking the need for whitespace LayoutObject for shadow host siblings. Created a common space-separated words expectation for css. Bug: 901323 Change-Id: Ib2fa54d55923c0497ff8e96c5010e68b01570881 Reviewed-on: https://chromium-review.googlesource.com/c/1314589Reviewed-by:
-
edchin authored
Real-world crashes have been caused by WebStateList being nil in a WebStateListObserver callback. Logically, this should not happen since the WebStateList should be guaranteed to be alive until all the observer callbacks have completed. That is unfortunately false. We believe there could be some compiler optimization that is causing the WebStateList to be destructed before the callback is completed. Bug: 877792 Change-Id: I0e7c5cc843d29c6d78349f1fe2f33d7317c20db1 Reviewed-on: https://chromium-review.googlesource.com/c/1309750 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#604909}
-
Max Moroz authored
Apparently there also is ubsan_minimal runtime which we do not use: https://clang.llvm.org/docs/UndefinedBehaviorSanitizer.html#minimal-runtime. It's fairy small though: 20K libclang_rt.ubsan_minimal-i386.a 20K libclang_rt.ubsan_minimal-i386.so 24K libclang_rt.ubsan_minimal-x86_64.a 4.0K libclang_rt.ubsan_minimal-x86_64.a.syms 20K libclang_rt.ubsan_minimal-x86_64.so Bug: 870331 Change-Id: I280fa27fce61095bffe5e91fed92245c75d051db Reviewed-on: https://chromium-review.googlesource.com/c/1313756Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#604908}
-
Alexander Timin authored
As MessageLoopForUI and IO are not part of MessageLoopImpl (they are just talking to the relevant pump), move them to the main file. R=gab@chromium.org BUG=891670 Change-Id: Ifdbb7916c43e8c51331a34b73902d58a3d8a9ecb Reviewed-on: https://chromium-review.googlesource.com/c/1313589Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#604907}
-
Donna Wu authored
As UsbChooserContext stores all device infos available to the device manager, other storages could be reduced by only keeping guid and getting the details from UsbChooserContext by GetDeviceInfo() method. Bug: 699790 Change-Id: I42f19a530fcf030cb896b3b26f218fe019b77e33 Reviewed-on: https://chromium-review.googlesource.com/c/1296313 Commit-Queue: Donna Wu <donna.wu@intel.com> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#604906}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/d4a68bd932a1..41f00de26bb1 git log d4a68bd932a1..41f00de26bb1 --date=short --no-merges --format='%ad %ae %s' 2018-11-02 titovartem@webrtc.org Fix chromium roll 2018-11-02 nisse@webrtc.org Delete rtc::Pathname Created with: gclient setdep -r src/third_party/webrtc@41f00de26bb1 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:NONE TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I34867ce7d77f0c768818b189572465d75ff481a8 Reviewed-on: https://chromium-review.googlesource.com/c/1314102Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#604905}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1294edc1cf83..643fe6108096 Created with: gclient setdep -r src-internal@643fe6108096 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I998d01e272acf9af4f00901133780ce095c84578 Reviewed-on: https://chromium-review.googlesource.com/c/1314100Reviewed-by:
-
Rouslan Solomakhin authored
Before this patch, a website could query PaymentRequest.canMakePayment() with a single set of methods identifiers and parameters per user per 30 minutes. This prevented placing wallet-specific buttons on the page that would be backed by one instance of PaymentRequest each, because only the first of several PaymentRequest.canMakePayment() calls would succeed before the quota limit was hit. This patch adds per-method quota, which allows queries for different payment method identifiers, as long as the method-specific parameters remain unchanged for 30 minutes. The quota code on Android has been refactored to use the common C++ code that is already used on desktop and iOS. The new behavior is behind the chrome://flags/#per-method-can-make-payment-quota flag, which is disabled by default. After this patch, if chrome://flags/#per-method-can-make-payment-quota is enabled, a website can query PaymentRequest.canMakePayment() for each payment method individually, as long as method-specific parameters are unchanged. This allows placing wallet-specific buttons on the page with each button backed by a separate instance of PaymentRequest. Although the website can find out which wallets the user has, the quota still hides the individual instruments within a wallet. Change-Id: I5056984ef3ada913679d3e0d07b10394592b557f Bug: 871791 Reviewed-on: https://chromium-review.googlesource.com/c/1293569Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
-
Mounir Lamouri authored
VideoSurfaceLayer is now enabled by default on trunk as LayoutTests can run with it. As a result, Picture-in-Picture is also enabled, adding one new entry to the overflow menu. Bug: 881040, 895912 Change-Id: Id18c54611c8eb2f4178e4f9b32c449b8c4a50601 Reviewed-on: https://chromium-review.googlesource.com/c/1312483 Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#604902}
-
Marc Treib authored
GetDataTypesFromPreferenceProviders was identical to GetForcedDataTypes, so let's merge it into that. This also includes a tiny behavior change: GetForcedDataTypes will now return only types which are registered. Unregistered types effectively don't exist, so no point in considering them forced. Bug: none Change-Id: I37d5d105ea88f80b25f7b651368a720d3f915fba Reviewed-on: https://chromium-review.googlesource.com/c/1314490Reviewed-by:
vitaliii <vitaliii@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#604901}
-
Guido Urdaneta authored
Bug: 731170 Change-Id: Icb96f03c5a50c1c2387b8a077ff087d783030bae Reviewed-on: https://chromium-review.googlesource.com/c/1309787 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#604900}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 78fd3e5d. With Chromium commits locally applied on WPT: 270d4abd "ServiceWorker: Add new WPT tests to make sure to update a registration with different script type and identical script content." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: mcasas@chromium.org: external/wpt/mediacapture-record NOAUTOREVERT=true TBR=raphael.kubo.da.costa@intel.com No-Export: true Change-Id: I2856e683abc7deba7aa7dabcbf8ebed12db03466 Reviewed-on: https://chromium-review.googlesource.com/c/1314146 Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#604899}
-
Armando Miraglia authored
While Fitness returns a single double value, the SelectBestSettings returns the best settings for a specific property. Independently of the difference in return type, the logic to determine fitness and best settings is the same. This change-list aims at consolidating the two functions to reduce code and logic duplication in the getUserMedia code. BUG=731170 TESTED=./out/Default/content_unittests Change-Id: I91e84a8b9b41cd8b7dff9d08790695ae85670278 Reviewed-on: https://chromium-review.googlesource.com/c/1311918 Commit-Queue: Armando Miraglia <armax@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#604898}
-
vitaliii authored
virtual/outofblink-cors/external/wpt/service-workers/service-worker/update-registration-with-type.https.html virtual/service-worker-servicification/external/wpt/service-workers/service-worker/update-registration-with-type.https.html virtual/outofblink-cors-ns/external/wpt/service-workers/service-worker/update-registration-with-type.https.html TBR=asamidoi@chromium.org NOTRY=true Bug: 901317 Change-Id: I7e8dc6a90cbcf6c13dfe1bddee15c56880138466 Reviewed-on: https://chromium-review.googlesource.com/c/1314493 Commit-Queue: vitaliii <vitaliii@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/17a4d822..fa338454 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I4c27dbe729132800b9f2d2ab7e0e0abfe618f008 Reviewed-on: https://chromium-review.googlesource.com/c/1314145Reviewed-by:
-
vitaliii authored
inspector-protocol/css/css-coverage-new-stylesheet.js TBR=einbinder@chromium.org NOTRY=true Bug: 901314 Change-Id: I67abd717378677fe42239831222ffd35b36b0dea Reviewed-on: https://chromium-review.googlesource.com/c/1314529Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/caeb1e895d7b..a6e8a0c5fee5 git log caeb1e895d7b..a6e8a0c5fee5 --date=short --no-merges --format='%ad %ae %s' 2018-11-02 jiajia.qin@intel.com ES31: Simplify IsInShaderStorageBlock function Created with: gclient setdep -r src/third_party/angle@a6e8a0c5fee5 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: I6424876b1cab86dc1079ae0b52decc4557ab292d Reviewed-on: https://chromium-review.googlesource.com/c/1314101Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/3e4c77f1c128..d4a68bd932a1 git log 3e4c77f1c128..d4a68bd932a1 --date=short --no-merges --format='%ad %ae %s' 2018-11-02 kolmodin@webrtc.org Implement Injectable Audio Codecs for the Java SDK. Created with: gclient setdep -r src/third_party/webrtc@d4a68bd932a1 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I7d75b35fc051ef6e2648ef95c9bbb0922b72f349 Reviewed-on: https://chromium-review.googlesource.com/c/1314099Reviewed-by:
-
Daniel Bratell authored
In jumbo builds, AXVirtualView::GetClassName sometimes expanded to AXVirtual::GetClassNameW (but not always). This caused build breakage. Rather than carefully ensuring that ui/views/accessibility is compiled with the same GetClassName macro every time (be it defined or not defined), just rename it to get the build going. If the undef method is to be used, it needs be in the header file, but then it will also affect View::GetClassName and that is another can of worms. It's possible GetClassName should be added to base/win/windows_types.h which could be used everywhere, but that is a larger fix than just getting the build working again. TBR=nektar@chromium.org,dmazzoni@chromium.org Bug: 811277 Change-Id: I8e5a8b71f21d57ef03a5c5e58bee84b5b99b2abd Reviewed-on: https://chromium-review.googlesource.com/c/1314488 Commit-Queue: Daniel Bratell <bratell@opera.com> Reviewed-by:
Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#604892}
-
vitaliii authored
This is a follow-up to https://chromium-review.googlesource.com/c/chromium/src/+/1312979. TBR=paulmeyer@chromium.org Bug: 900926 Change-Id: I9dd7dec6f30166fad651e3f281738b8b91c27b88 Reviewed-on: https://chromium-review.googlesource.com/c/1313932Reviewed-by:
-
Ross McIlroy authored
No longer used by relocation packing tool, now that Android supports packed relocations within NDK. BUG=chromium:899208 Change-Id: Ife3d46e98846430b65c4f5cb79f8e2bbb20e6b2a Reviewed-on: https://chromium-review.googlesource.com/c/1307498Reviewed-by:
David Turner <digit@chromium.org> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#604890}
-
vitaliii authored
Disable org.chromium.chrome.browser.fullscreen.FullscreenManagerTest#testManualHidingShowingBrowserControls org.chromium.chrome.browser.fullscreen.FullscreenManagerTest#testHideBrowserControlsAfterFlingBoosting because flaky. TBR=bokan@chromium.org Bug: 901280 Change-Id: I5eb8a5c418ac0b83440d26fd2dad07e112a32501 Reviewed-on: https://chromium-review.googlesource.com/c/1314470Reviewed-by:
-
Takashi Sakamoto authored
Bug: 888904 Change-Id: If5ea187530df1f3de0e5f5f9c4b2e3be0e10b397 Reviewed-on: https://chromium-review.googlesource.com/c/1312139Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#604888}
-
Richard Knoll authored
Bug: 710925 Change-Id: I357c105c1aa40b0acca41edde0423141fb6f62c0 Reviewed-on: https://chromium-review.googlesource.com/c/1304793 Commit-Queue: Richard Knoll <knollr@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#604887}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/2dc1e34f9029..13853a120d5a git log 2dc1e34f9029..13853a120d5a --date=short --no-merges --format='%ad %ae %s' 2018-11-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 502d2e215556..caeb1e895d7b (2 commits) Created with: gclient setdep -r src/third_party/skia@13853a120d5a The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=herb@chromium.org Change-Id: Ibd23af2b5576dbfcae39ea639628513b9f9c74f1 Reviewed-on: https://chromium-review.googlesource.com/c/1314098Reviewed-by:
-
Richard Knoll authored
This allows us to only init channel groups once, instead of multiple times, when initializing channels. Bug: 710925 Change-Id: Icb00711eb9a5c204699b73084daa3791f96740da Reviewed-on: https://chromium-review.googlesource.com/c/1304515Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ee5c29c3f1a2..1294edc1cf83 Created with: gclient setdep -r src-internal@1294edc1cf83 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I180592e06f253ca8d7b85c1b7d6277689325d923 Reviewed-on: https://chromium-review.googlesource.com/c/1314097Reviewed-by:
-
Morten Stenshorne authored
Without this fix, 3 tests would fail with https://chromium-review.googlesource.com/c/chromium/src/+/1297367 : external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/contain/contain-paint-clip-004.html fast/overflow/image-selection-highlight.html scrollbars/overflow-scrollbar-combinations.html Change-Id: Iabd95ead6c96cd50f25e654dda6a7f041ac77af0 Reviewed-on: https://chromium-review.googlesource.com/c/1311926Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#604883}
-
Daniel Bratell authored
In jumbo builds many cc files compile in the same translation unit which also means that they share the same anonymous namespace. That means that constant names need to be unique in the whole build target even if they are in anonymous namespaces. A service worker extension just introduced a second kPrefsName into extensions/browser which broke some (but not all) jumbo build configurations. This patch renames them both to prevent confusion (from compiler or human). TBR=lazyboy@chromium.org,rdevlin.cronin@chromium.org Bug: 889687 Change-Id: I6d3d44d9941038cc8e2304bc3100c7e681ea18a9 Reviewed-on: https://chromium-review.googlesource.com/c/1314468Reviewed-by:
-
Mikel Astiz authored
This is generally speaking a good proxy for understanding server-side load, and one we want to keep an eye on for ongoing and near-future experiments, to avoid server-side capacity issues during rollout. Bug: 882489 Change-Id: If775026486de0ab00cfa52ee86170b4251a2ee12 Reviewed-on: https://chromium-review.googlesource.com/c/1307436Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#604881}
-
Chromium WPT Sync authored
Using wpt-import in Chromium b47ce539. With Chromium commits locally applied on WPT: 270d4abd "ServiceWorker: Add new WPT tests to make sure to update a registration with different script type and identical script content." 24c885e6 "[css-properties-values-api] Invalidate paint worklet on registration." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=raphael.kubo.da.costa@intel.com No-Export: true Change-Id: If91c4358e70164375254477477ac51fdd2bbef63 Reviewed-on: https://chromium-review.googlesource.com/c/1314143 Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
-
