GitLab

Fix for user stylesheet bugs where they get parsed using the wrong compatibility mode.  This was a regression
caused from Safari 3 -> 4 by the Acid3 fixes to create a real DOCTYPE in the DOM.

Reviewed by Darin Adler.

This patch makes style selector creation lazy, so that the selector isn't built unless someone asks for it.

In order to avoid creating the style selector before the compatibility mode has been determined, document
style is now created without having a dependence on an instantiated style selector.  The creation of the style
is now done as a static method on CSSStyleSelector called styleForDocument, and a couple of font-related
functions have been made static as well so that they can be used by this method.

m_styleSelector on Document is now an OwnPtr.

Added userscripts/mixed-case-stylesheet.html

* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::styleForDocument):
(WebCore::CSSStyleSelector::applyProperty):
(WebCore::CSSStyleSelector::checkForGenericFamilyChange):
(WebCore::CSSStyleSelector::setFontSize):
(WebCore::CSSStyleSelector::getComputedSizeFromSpecifiedSize):
(WebCore::CSSStyleSelector::fontSizeForKeyword):
* css/CSSStyleSelector.h:
* dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::~Document):
(WebCore::Document::recalcStyle):
(WebCore::Document::createStyleSelector):
(WebCore::Document::attach):
(WebCore::Document::setVisuallyOrdered):
(WebCore::Document::recalcStyleSelector):
* dom/Document.h:
(WebCore::Document::styleSelector):
(WebCore::Document::visuallyOrdered):
* html/HTMLDocument.cpp:
(WebCore::HTMLDocument::determineParseMode):
* loader/PlaceholderDocument.cpp:
(WebCore::PlaceholderDocument::attach):



git-svn-id: svn://svn.chromium.org/blink/trunk@54005 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Alexey Proskuryakov.

        Add layout tests to verify assignment to items of NodeList
        https://bugs.webkit.org/show_bug.cgi?id=34213

        * fast/dom/NodeList/nodelist-item-assignment-expected.txt: Added.
        * fast/dom/NodeList/nodelist-item-assignment.html: Added.

git-svn-id: svn://svn.chromium.org/blink/trunk@54004 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Darin Adler.

        Rename ISODateTime.{cpp,h} to DateComponents.{cpp,h}
        https://bugs.webkit.org/show_bug.cgi?id=34245

        No functional changes.

        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * html/DateComponents.cpp: Copied from WebCore/html/ISODateTime.cpp.
        (WebCore::DateComponents::maxWeekNumberInYear):
        (WebCore::DateComponents::parseYear):
        (WebCore::DateComponents::addDay):
        (WebCore::DateComponents::addMinute):
        (WebCore::DateComponents::parseTimeZone):
        (WebCore::DateComponents::parseMonth):
        (WebCore::DateComponents::parseDate):
        (WebCore::DateComponents::parseWeek):
        (WebCore::DateComponents::parseTime):
        (WebCore::DateComponents::parseDateTimeLocal):
        (WebCore::DateComponents::parseDateTime):
        (WebCore::DateComponents::setMillisecondsSinceMidnightInternal):
        (WebCore::DateComponents::setMillisecondsSinceEpochForDateInternal):
        (WebCore::DateComponents::setMillisecondsSinceEpochForDate):
        (WebCore::DateComponents::setMillisecondsSinceEpochForDateTime):
        (WebCore::DateComponents::setMillisecondsSinceEpochForDateTimeLocal):
        (WebCore::DateComponents::setMillisecondsSinceEpochForMonth):
        (WebCore::DateComponents::setMillisecondsSinceMidnight):
        (WebCore::DateComponents::setMillisecondsSinceEpochForWeek):
        (WebCore::DateComponents::millisecondsSinceEpochForTime):
        (WebCore::DateComponents::millisecondsSinceEpoch):
        (WebCore::DateComponents::toStringForTime):
        (WebCore::DateComponents::toString):
        * html/DateComponents.h: Copied from WebCore/html/ISODateTime.h.
        (WebCore::DateComponents::DateComponents):
        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::parseToDouble):
        (WebCore::HTMLInputElement::valueAsDate):
        (WebCore::HTMLInputElement::setValueAsDate):
        (WebCore::HTMLInputElement::setValueAsNumber):
        (WebCore::HTMLInputElement::formStringToDateComponents):
        * html/HTMLInputElement.h:
        * html/ISODateTime.cpp: Removed.
        * html/ISODateTime.h: Removed.
        * html/ValidityState.cpp:
        (WebCore::ValidityState::typeMismatch):

git-svn-id: svn://svn.chromium.org/blink/trunk@54003 bbb929c8-8fbe-4397-9dbb-9b2b20218538

* DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::DumpRenderTree::DumpRenderTree):
* DumpRenderTree/qt/DumpRenderTreeQt.h:
* DumpRenderTree/qt/LayoutTestControllerQt.cpp:
(LayoutTestController::reset):
* DumpRenderTree/qt/LayoutTestControllerQt.h:
(LayoutTestController::display):



git-svn-id: svn://svn.chromium.org/blink/trunk@54002 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Pavel Feldman.

        Use platform-specific monospace fonts in the Web Inspector

        Move the OS version detection code into the frontend,
        add custom CSS monospace styles for known platforms.
        https://bugs.webkit.org/show_bug.cgi?id=34040

        * inspector/InspectorFrontendHost.cpp:
        (WebCore::InspectorFrontendHost::platform):
        * inspector/front-end/BreakpointsSidebarPane.js:
        (WebInspector.BreakpointsSidebarPane.prototype._appendBreakpointElement):
        * inspector/front-end/DatabaseQueryView.js:
        (WebInspector.DatabaseQueryView):
        * inspector/front-end/InspectorBackendStub.js:
        (.WebInspector.InspectorBackendStub.prototype.releaseWrapperObjectGroup):
        (.WebInspector.InspectorBackendStub.prototype.setInjectedScriptSource):
        * inspector/front-end/SourceFrame.js:
        (WebInspector.SourceFrame.prototype._createConditionElement):
        * inspector/front-end/inspector.css:
        * inspector/front-end/inspector.html:
        * inspector/front-end/inspector.js:
        (WebInspector.URLRegExp.i.get platform):
        (WebInspector._detectPlatform):

git-svn-id: svn://svn.chromium.org/blink/trunk@54001 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Implement the display() method of the layout test controller
        https://bugs.webkit.org/show_bug.cgi?id=34258

        * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
        (WebCore::DumpRenderTree::DumpRenderTree):
        (WebCore::DumpRenderTree::showPage):
        (WebCore::DumpRenderTree::hidePage):
        * DumpRenderTree/qt/DumpRenderTreeQt.h:
        * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
        (LayoutTestController::reset):
        (LayoutTestController::display):
        * DumpRenderTree/qt/LayoutTestControllerQt.h:

git-svn-id: svn://svn.chromium.org/blink/trunk@54000 bbb929c8-8fbe-4397-9dbb-9b2b20218538

default instead.

Reviewed by Simon Hausmann.

* WebCoreSupport/QtFallbackWebPopup.cpp:
(WebCore::QtFallbackWebPopup::populate):

git-svn-id: svn://svn.chromium.org/blink/trunk@53999 bbb929c8-8fbe-4397-9dbb-9b2b20218538

check-webkit-style's cpp.py where it is no longer used.

Reviewed by Shinichiro Hamaji.

https://bugs.webkit.org/show_bug.cgi?id=34249

* Scripts/webkitpy/style/processors/cpp.py:
  - Reduced number of occurrences of "filename" variable from
    approximately 200 to 120.

* Scripts/webkitpy/style/processors/cpp_unittest.py:
  - Refactored unit tests as necessary to accommodate changes to cpp.py.
  - Fixed bug in CppStyleTestBase.perform_include_what_you_use()
    where the incorrect file extension was getting passed to
    cpp_style.check_language().

git-svn-id: svn://svn.chromium.org/blink/trunk@53998 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Patch by Trond Kjernåsen <trond@trolltech.com> on 2010-01-28
Reviewed by Simon Hausmann.

* Api/qwebframe.cpp:
(QWebFrame::print):

git-svn-id: svn://svn.chromium.org/blink/trunk@53997 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Timothy Hatcher.

        Simplify views logic in Profiler panel, and fix the problem described in the issue.
        Remove image from Welcome view.
        Preserve border on status bar-like buttons in Welcome view on window deactivation.

        https://bugs.webkit.org/show_bug.cgi?id=34201

        * inspector/front-end/ProfilesPanel.js:
        (WebInspector.ProfilesPanel.prototype.show):
        (WebInspector.ProfilesPanel.prototype.reset):
        (WebInspector.ProfilesPanel.prototype.addProfileHeader):
        (WebInspector.ProfilesPanel.prototype.showView):
        (WebInspector.ProfilesPanel.prototype._updateInterface):
        * inspector/front-end/WelcomeView.js:
        (WebInspector.WelcomeView):
        * inspector/front-end/inspector.css:

git-svn-id: svn://svn.chromium.org/blink/trunk@53996 bbb929c8-8fbe-4397-9dbb-9b2b20218538

https://bugs.webkit.org/show_bug.cgi?id=33873

The WebCore::String::utf8 method will use the generic WebCore::TextCodec
and then call the encode method on it. In QtWebKit this class is implemented
around the QTextCodec class. Instead of going the generic codec way we treat
the WebCore::String as a QString (no copying) and then use the built-in
QString::toUtf8 to do the conversion.

git-svn-id: svn://svn.chromium.org/blink/trunk@53995 bbb929c8-8fbe-4397-9dbb-9b2b20218538

https://bugs.webkit.org/show_bug.cgi?id=34162

Reviewed by Simon Hausmann.

WebCore: 

The pageX/pageY co-ordinates of a touch event should be relative to the containing frame, not the main frame. This change implements that and also updates the existing touch-inside-iframe test to also examine the page co-ordinates.

* dom/Touch.cpp:
(WebCore::Touch::Touch): Remove dead code.
* dom/Touch.h: Remove dead code.
* page/EventHandler.cpp:
(WebCore::EventHandler::handleTouchEvent): Rename framePoint to pagePoint, as it seems a clearer name. Also adjust the pagePoint to be relative to the touch target element's containing frame rather than the main frame.
* platform/PlatformTouchEvent.h: Rename Android specific constructor parameter to better reflect it's contents.
* platform/PlatformTouchPoint.h: Ditto.
* platform/android/PlatformTouchEventAndroid.cpp: Ditto.
* platform/android/PlatformTouchPointAndroid.cpp: Ditto.

LayoutTests: 

Update the existing iframe touch event test to also examine the page co-ordinates of the touch that is received.

* fast/events/touch/resources/touch-inside-iframe2.html:
* fast/events/touch/touch-inside-iframe-expected.txt:
* fast/events/touch/touch-inside-iframe.html:



git-svn-id: svn://svn.chromium.org/blink/trunk@53994 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Pavel Feldman.

        Simplify isActivation method.

        https://bugs.webkit.org/show_bug.cgi?id=34161

        Test: WebCore/manual-tests/inspector/debugger-scopes-inspection.html

        * bindings/js/JSInjectedScriptHostCustom.cpp:
        (WebCore::JSInjectedScriptHost::isActivation):

git-svn-id: svn://svn.chromium.org/blink/trunk@53993 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        [GTK] Can DnD files to our filechooser widget (<input type="file">)
        https://bugs.webkit.org/show_bug.cgi?id=34246

        Skip failing test because of this missing feature.

        * platform/gtk/Skipped:

git-svn-id: svn://svn.chromium.org/blink/trunk@53992 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Darin Fisher.

        Remove tests for dates later than 275760-09-13T00:00Z.
        https://bugs.webkit.org/show_bug.cgi?id=34240

        Date.UTC() of V8 doesn't support such dates though Date.UTC() of
        JavaScriptCore does.

        * fast/forms/input-valueasnumber-date-expected.txt:
        * fast/forms/input-valueasnumber-datetime-expected.txt:
        * fast/forms/input-valueasnumber-datetimelocal-expected.txt:
        * fast/forms/input-valueasnumber-month-expected.txt:
        * fast/forms/script-tests/input-valueasnumber-date.js:
        * fast/forms/script-tests/input-valueasnumber-datetime.js:
        * fast/forms/script-tests/input-valueasnumber-datetimelocal.js:
        * fast/forms/script-tests/input-valueasnumber-month.js:
        * platform/win/fast/forms/input-valueasnumber-datetime-expected.txt: Removed.

git-svn-id: svn://svn.chromium.org/blink/trunk@53991 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Shinichiro Hamaji.

        In check-webkit-style, eliminated the dependency of
        processors/cpp_unittest.py on checker.py.

        https://bugs.webkit.org/show_bug.cgi?id=34205

        * Scripts/webkitpy/style/checker.py:
          - Addressed FIXME by removing STYLE_CATEGORIES data.
          - Added style_categories().

        * Scripts/webkitpy/style/checker_unittest.py:
          - Minor changes.

        * Scripts/webkitpy/style/processors/cpp.py:
          - Added categories attribute to CppProcessor class (data
            was originally checker.STYLE_CATEGORIES).

        * Scripts/webkitpy/style/processors/cpp_unittest.py:
          - Addressed FIXME by eliminating "import" from checker.py.

git-svn-id: svn://svn.chromium.org/blink/trunk@53990 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Shinichiro Hamaji.

        Improve treatment of conditions and rest of the line for if, else, switch and alikes
        https://bugs.webkit.org/show_bug.cgi?id=34173

        * Scripts/webkitpy/style/cpp_style.py:
        * Scripts/webkitpy/style/cpp_style_unittest.py:

git-svn-id: svn://svn.chromium.org/blink/trunk@53989 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Adam Barth.

        Limit login retries to 5
        https://bugs.webkit.org/show_bug.cgi?id=34193

        * Scripts/webkitpy/bugzilla.py:

git-svn-id: svn://svn.chromium.org/blink/trunk@53976 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Darin Adler.

        rangeOverflow/rangeUnderflow support for type=date
        https://bugs.webkit.org/show_bug.cgi?id=34209

        * fast/forms/ValidityState-rangeOverflow-date-expected.txt: Added.
        * fast/forms/ValidityState-rangeOverflow-date.html: Added.
        * fast/forms/ValidityState-rangeUnderflow-date-expected.txt: Added.
        * fast/forms/ValidityState-rangeUnderflow-date.html: Added.
        * fast/forms/script-tests/ValidityState-rangeOverflow-date.js: Added.
        * fast/forms/script-tests/ValidityState-rangeUnderflow-date.js: Added.

2010-01-27  Kent Tamura  <tkent@chromium.org>

        Reviewed by Darin Adler.

        rangeOverflow/rangeUnderflow support for type=date
        https://bugs.webkit.org/show_bug.cgi?id=34209

        Add DATE type support to rangeUnderflow(), rangeOverflow(),
        minimum(), and maximum() of HTMLInputElement.
        In order to unify parsing code for value, min, and max strings,
        introduce parseToDouble() function and it is called by
        valueAsDate() and valueAsNumber() too.

        Tests: fast/forms/ValidityState-rangeOverflow-date.html
               fast/forms/ValidityState-rangeUnderflow-date.html

        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::rangeUnderflow): Support DATE type, and use parseToDouble().
        (WebCore::HTMLInputElement::rangeOverflow): ditto.
        (WebCore::HTMLInputElement::minimum): ditto.
        (WebCore::HTMLInputElement::maximum): ditto.
        (WebCore::HTMLInputElement::doubleValueFor): Added.
        (WebCore::HTMLInputElement::valueAsDate): Use parseToDouble().
        (WebCore::HTMLInputElement::valueAsNumber): Use parseToDouble().
        * html/HTMLInputElement.h: Declare parseToDouble().

git-svn-id: svn://svn.chromium.org/blink/trunk@53975 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Fix chromium build bustage (take 2).

        * bindings/scripts/CodeGeneratorV8.pm: Really treat V8CustomGetter like CustomGetter in all cases.




git-svn-id: svn://svn.chromium.org/blink/trunk@53974 bbb929c8-8fbe-4397-9dbb-9b2b20218538

* platform/qt/Skipped: fast/dom/Window/window-postmessage-clone-frames.html skipped.



git-svn-id: svn://svn.chromium.org/blink/trunk@53973 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Fix chromium build bustage.

        * bindings/scripts/CodeGeneratorV8.pm: Treat V8CustomGetter like CustomGetter in all cases.



git-svn-id: svn://svn.chromium.org/blink/trunk@53972 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Pavel Feldman.

        Expose HistoryItem::documentSequenceNumber
        https://bugs.webkit.org/show_bug.cgi?id=34243

        * public/WebHistoryItem.h:
        * src/WebHistoryItem.cpp:
        (WebKit::WebHistoryItem::documentSequenceNumber):
        (WebKit::WebHistoryItem::setDocumentSequenceNumber):



git-svn-id: svn://svn.chromium.org/blink/trunk@53971 bbb929c8-8fbe-4397-9dbb-9b2b20218538

git-svn-id: svn://svn.chromium.org/blink/trunk@53970 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Maciej Stachowiak.

        MessageEvent.data should deserialize in the context of the MessageEvent's global object
        https://bugs.webkit.org/show_bug.cgi?id=34227

        Add logic to allow us to create an Object, Array, or Date instance
        so we can create them in the context of a specific global object,
        rather than just using the current lexical global object.

        * JavaScriptCore.exp:
        * runtime/DateInstance.cpp:
        (JSC::DateInstance::DateInstance):
        * runtime/DateInstance.h:
        * runtime/JSGlobalObject.h:
        (JSC::constructEmptyObject):
        (JSC::constructEmptyArray):
2010-01-27  Oliver Hunt  <oliver@apple.com>

        Reviewed by Maciej Stachowiak.

        MessageEvent.data should deserialize in the context of the MessageEvent's global object
        https://bugs.webkit.org/show_bug.cgi?id=34227

        Test that the object returned from postMessage.data is created in the correct context

        * fast/dom/Window/resources/window-postmessage-clone-frames-frame.html: Added.
        * fast/dom/Window/window-postmessage-clone-frames-expected.txt: Added.
        * fast/dom/Window/window-postmessage-clone-frames.html: Added.
2010-01-27  Oliver Hunt  <oliver@apple.com>

        Reviewed by Maciej Stachowiak.

        MessageEvent.data should deserialize in the context of the MessageEvent's global object
        https://bugs.webkit.org/show_bug.cgi?id=34227

        Make ScriptValue deserialisation support the provision of a specific global
        object to use when creating new objects.  This then allows us to make
        MessageEvent.data and PopStateEvent.state deserialize in the correct
        context.

        Test: fast/dom/Window/window-postmessage-clone-frames.html

        * bindings/js/JSPopStateEventCustom.cpp:
          Remove custom implementation of state getter
        * bindings/js/SerializedScriptValue.cpp:
        (WebCore::DeserializingTreeWalker::DeserializingTreeWalker):
        (WebCore::DeserializingTreeWalker::createOutputArray):
        (WebCore::DeserializingTreeWalker::createOutputObject):
        (WebCore::DeserializingTreeWalker::convertIfTerminal):
        (WebCore::SerializedScriptValueData::deserialize):
        (WebCore::SerializedScriptValue::deserialize):
        * bindings/js/SerializedScriptValue.h:
        (WebCore::SerializedScriptValue::deserialize):
        * bindings/scripts/CodeGeneratorJS.pm:
          Update bindings generation to pass the correct global object, and to
          treat "any" as synonymous with SerializedValue.
        * dom/PopStateEvent.idl:

git-svn-id: svn://svn.chromium.org/blink/trunk@53969 bbb929c8-8fbe-4397-9dbb-9b2b20218538

* Scripts/webkitpy/committers.py:



git-svn-id: svn://svn.chromium.org/blink/trunk@53968 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Gustavo Noronha Silva.

        [GTK] Expose the IM context via the API
        https://bugs.webkit.org/show_bug.cgi?id=33327

        Expose the GtkIMMultiContext as a property of WebKitWebView. This will
        allow embedders to generate the input method context menu entries and
        make testing certain IM context behavior possible.

        * webkit/webkitwebview.cpp:
        (webkit_web_view_get_property):
        (DNDContentsRequest::webkit_web_view_get_im_context):
        (DNDContentsRequest::webkit_web_view_class_init):

git-svn-id: svn://svn.chromium.org/blink/trunk@53967 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Eric Carlson.

        Make media controls fade in/out transition duration configurable on a theme level.
        https://bugs.webkit.org/show_bug.cgi?id=34196

        No new tests needed (I hope).

        * rendering/RenderMedia.cpp:
        (WebCore::RenderMedia::RenderMedia): Removed constant from contructor - the initial value is meaningless.
        (WebCore::RenderMedia::updateControlVisibility): Get fade in/out duration from theme.
        * rendering/RenderTheme.h:
        (WebCore::RenderTheme::mediaControlsFadeInDuration): New virtual method.
        (WebCore::RenderTheme::mediaControlsFadeOutDuration): New virtual method.

git-svn-id: svn://svn.chromium.org/blink/trunk@53966 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Dimitri Glazkov.

        Tests that when a page removes an iframe that sleeps in its unload handler and
        terminates its JS execution, the outer page's JS continues running.

        https://bugs.webkit.org/show_bug.cgi?id=34226

        * fast/dom/Window/slow-unload-handler-expected.txt: Copied from LayoutTests/fast/dom/Window/slow_unload_handler-expected.txt.
        * fast/dom/Window/slow-unload-handler-only-frame-is-stopped.html: Added.
        * fast/dom/Window/slow-unload-handler-only-frame-is-stopped-expected.txt: Added.
        * fast/dom/Window/slow-unload-handler.html: Copied from LayoutTests/fast/dom/Window/slow_unload_handler.html.
        * fast/dom/Window/slow_unload_handler-expected.txt: Removed.
        * fast/dom/Window/slow_unload_handler.html: Removed.
        * platform/gtk/Skipped:
        * platform/mac/Skipped:
        * platform/qt/Skipped:
        * platform/win/Skipped:
2010-01-27  John Abd-El-Malek  <jam@chromium.org>

        Reviewed by Dimitri Glazkov.

        Tests that when a page removes an iframe that sleeps in its unload handler and
        terminates its JS execution, the outer page's JS continues running.

        https://bugs.webkit.org/show_bug.cgi?id=34226

        Tests: fast/dom/Window/slow-unload-handler-only-frame-is-stopped.html
               fast/dom/Window/slow-unload-handler.html

        * bindings/v8/DateExtension.cpp:
        (WebCore::DateExtension::OnSleepDetected):

git-svn-id: svn://svn.chromium.org/blink/trunk@53965 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Darin Adler.

        Add valueAsNumber support for type=datetime-local.
        https://bugs.webkit.org/show_bug.cgi?id=34200

        The test data is equivalent to input-valueasnumber-datetime.html.
        The expectation contains two FAIL lines because they check
        unimplemented features.

        * fast/forms/input-valueasnumber-datetimelocal-expected.txt: Added.
        * fast/forms/input-valueasnumber-datetimelocal.html: Added.
        * fast/forms/script-tests/input-valueasnumber-datetimelocal.js: Added.
2010-01-27  Kent Tamura  <tkent@chromium.org>

        Reviewed by Darin Adler.

        Add valueAsNumber support for type=datetime-local.
        https://bugs.webkit.org/show_bug.cgi?id=34200

        Implement necessary methods of ISODateTime, and call them from
        HTMLInputElement.

        Test: fast/forms/input-valueasnumber-datetimelocal.html

        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::valueAsNumber):
        (WebCore::HTMLInputElement::setValueAsNumber):
        * html/ISODateTime.cpp:
        (WebCore::ISODateTime::setMillisecondsSinceEpochForDateTimeLocal):
          Implemented.  Just call setMillisecondsSinceEpochForDateTime().
        (WebCore::ISODateTime::millisecondsSinceEpochForTime):
          Accept to be called for m_type=DateTimeLocal.
        (WebCore::ISODateTime::toString): Add DateTimeLocal support.
        * html/ISODateTime.h: Declare new methods.

git-svn-id: svn://svn.chromium.org/blink/trunk@53964 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Adam Treat.

        https://bugs.webkit.org/show_bug.cgi?id=34216

        Add missing include for wtf/Platform.h

        * DumpRenderTree/AccessibilityController.h:

git-svn-id: svn://svn.chromium.org/blink/trunk@53962 bbb929c8-8fbe-4397-9dbb-9b2b20218538

* platform/graphics/win/WKCACFLayer.cpp:
* platform/graphics/win/WKCACFLayerRenderer.cpp:



git-svn-id: svn://svn.chromium.org/blink/trunk@53961 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Reviewed by Dave Hyatt.

* ForEachCoClass.h:
* WebKitClassFactory.cpp:
Added WebSerializedJSValue.

git-svn-id: svn://svn.chromium.org/blink/trunk@53960 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Add platform specific failing Windows results for two recently
added tests. I will comment on their originating bugs saying that
failing results were landed for Windows.
        
<https://bugs.webkit.org/show_bug.cgi?id=29564>
<https://bugs.webkit.org/show_bug.cgi?id=32696>

* platform/win/fast/css/button-height-expected.txt: Added.
* platform/win/fast/forms/input-valueasnumber-datetime-expected.txt: Added.



git-svn-id: svn://svn.chromium.org/blink/trunk@53959 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by David Levin.

        [chromium] complex text draws newlines as bells
        https://bugs.webkit.org/show_bug.cgi?id=34186

        Revert r45496 -- once we've got a glyph array, it is too late to normalize
        because we could have had multiple codepoints combine into one glyph.  The
        Uniscribe code it mentions it's duplicating uses the log cluster map to fix
        this.

        Instead, we just normalize the input text if it contains any non-ascii-space
        whitespace.

        This fixes fast/text/international/hindi-whitespace, which currently has an
        incorrect baseline containing a square box glyph.

        * platform/graphics/chromium/FontLinux.cpp:
        (WebCore::TextRunWalker::getTextRun):
        (WebCore::TextRunWalker::getNormalizedTextRun):
        * platform/graphics/chromium/HarfbuzzSkia.cpp:
        (WebCore::stringToGlyphs):

git-svn-id: svn://svn.chromium.org/blink/trunk@53958 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        https://bugs.webkit.org/show_bug.cgi?id=34150
        WebKit needs a mechanism to catch stale HashMap entries

        It is very difficult to catch stale pointers that are HashMap keys - since a pointer's hash
        is just its value, it is very unlikely that any observable problem is reproducible.

        This extends hash table consistency checks to check that pointers are referencing allocated
        memory blocks, and makes it possible to invoke the checks explicitly (it is not feasible
        to enable CHECK_HASHTABLE_CONSISTENCY by default, because that affects performance too much).

        * wtf/HashMap.h: (WTF::::checkConsistency): Call through to HashTable implementation. We can
        add similar calls to HashSet and HashCountedSet, but I haven't seen hard to debug problems
        with those yet.

        * wtf/HashSet.h: (WTF::::remove): The version of checkTableConsistency that's guarded by
        CHECK_HASHTABLE_CONSISTENCY is now called internalCheckTableConsistency().

        * wtf/HashTable.h:
        (WTF::HashTable::internalCheckTableConsistency):
        (WTF::HashTable::internalCheckTableConsistencyExceptSize):
        (WTF::HashTable::checkTableConsistencyExceptSize):
        Expose checkTableConsistency() even if CHECK_HASHTABLE_CONSISTENCY is off.
        (WTF::::add): Updated for checkTableConsistency renaming.
        (WTF::::addPassingHashCode): Ditto.
        (WTF::::removeAndInvalidate): Ditto.
        (WTF::::remove): Ditto.
        (WTF::::rehash): Ditto.
        (WTF::::checkTableConsistency): The assertion for !shouldExpand() was not correct - this
        function returns true for tables with m_table == 0.
        (WTF::::checkTableConsistencyExceptSize): Call checkValueConsistency for key. Potentially,
        we could do the same for values.

        * wtf/HashTraits.h:
        (WTF::GenericHashTraits::checkValueConsistency): An empty function that can be overridden
        to add checks. Currently, the only override is for pointer hashes.

        * wtf/RefPtrHashMap.h: (WTF::::remove): Updated for checkTableConsistency renaming.



git-svn-id: svn://svn.chromium.org/blink/trunk@53957 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] DRT Provide worker thread ability to track counters
        https://bugs.webkit.org/show_bug.cgi?id=34221

        Implement workerThreadCount() in LayoutTestController of Qt DRT

        Tests:
        fast/workers/dedicated-worker-lifecycle.html
        fast/workers/shared-worker-frame-lifecycle.html
        fast/workers/shared-worker-lifecycle.html
        fast/workers/worker-lifecycle.html

        * platform/qt/Skipped:
2010-01-27  Diego Gonzalez  <diego.gonzalez@openbossa.org>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] DRT Provide worker thread ability to track counters
        https://bugs.webkit.org/show_bug.cgi?id=34221

        Implement workerThreadCount() in LayoutTestController of Qt DRT

        Tests:
        fast/workers/dedicated-worker-lifecycle.html
        fast/workers/shared-worker-frame-lifecycle.html
        fast/workers/shared-worker-lifecycle.html
        fast/workers/worker-lifecycle.html

        * Api/qwebpage.cpp:
        (qt_drt_workerThreadCount):
2010-01-27  Diego Gonzalez  <diego.gonzalez@openbossa.org>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] DRT Provide worker thread ability to track counters
        https://bugs.webkit.org/show_bug.cgi?id=34221

        Implement workerThreadCount() in LayoutTestController of Qt DRT

        Tests:
        fast/workers/dedicated-worker-lifecycle.html
        fast/workers/shared-worker-frame-lifecycle.html
        fast/workers/shared-worker-lifecycle.html
        fast/workers/worker-lifecycle.html

        * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
        (LayoutTestController::workerThreadCount):
        * DumpRenderTree/qt/LayoutTestControllerQt.h:

git-svn-id: svn://svn.chromium.org/blink/trunk@53956 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Gustavo Noronha Silva.

        [gtk] Add support for windowless NPAPI plugins

        Much of this is a translation of how the Qt backend does this,
        modified for Gtk.

        https://bugs.webkit.org/show_bug.cgi?id=18831

        No new tests; there is already a windowless test in the tree.

        * plugins/PluginView.cpp:
        (WebCore::PluginView::handleEvent):
        (WebCore::PluginView::PluginView):
        * plugins/PluginView.h:
        * plugins/gtk/PluginViewGtk.cpp:
        (WebCore::getRootWindow):
        (WebCore::PluginView::updatePluginWidget):
        (WebCore::PluginView::paint):
        (WebCore::PluginView::handleKeyboardEvent):
        (WebCore::inputEventState):
        (WebCore::PluginView::initXEvent):
        (WebCore::setXButtonEventSpecificFields):
        (WebCore::setXMotionEventSpecificFields):
        (WebCore::setXCrossingEventSpecificFields):
        (WebCore::PluginView::handleMouseEvent):
        (WebCore::PluginView::handleFocusInEvent):
        (WebCore::PluginView::handleFocusOutEvent):
        (WebCore::PluginView::setNPWindowRect):
        (WebCore::PluginView::setNPWindowIfNeeded):
        (WebCore::PluginView::getValueStatic):
        (WebCore::PluginView::invalidateRect):
        (WebCore::getPluginDisplay):
        (WebCore::plug_removed_cb):
        (WebCore::getVisualAndColormap):
        (WebCore::PluginView::platformStart):
        (WebCore::PluginView::platformDestroy):

git-svn-id: svn://svn.chromium.org/blink/trunk@53955 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Darin Adler.

        Remove trailing \ from inline function code
        https://bugs.webkit.org/show_bug.cgi?id=34223

        * assembler/ARMv7Assembler.h:
        (JSC::ARMThumbImmediate::countLeadingZerosPartial):

git-svn-id: svn://svn.chromium.org/blink/trunk@53954 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by David Levin.

        [v8] minor cosmetic fix in V8 bindings codegenerator
        https://bugs.webkit.org/show_bug.cgi?id=34224

        * bindings/scripts/CodeGeneratorV8.pm:

git-svn-id: svn://svn.chromium.org/blink/trunk@53953 bbb929c8-8fbe-4397-9dbb-9b2b20218538